From patchwork Wed Apr 10 07:34:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13623773 X-Patchwork-Delegate: kuba@kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D10813D29F for ; Wed, 10 Apr 2024 07:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734507; cv=none; b=IDLWK7A8l3GEGGHGjAHLkDCbmZ/ZgnuEzLD6gf+iZLRXGzW5tFVtwjlDPIBKCNE0xk6Q2E1xYt3LiWNve9CyCOHG90lTPsTM4JxKeKFDar9/YE2Z0k6elrrmG9ErqXMxzAkm+EiaUXK8Zt8mxDOsbwlxzvBd21cnlTR6ASk8xhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734507; c=relaxed/simple; bh=I0XDCJ0jSC3RZZlCBrBai5GWRKEW6z/idZ0NTi135XM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JjcAqk/bUI5tuTLJkGQxDFV8tojR+TjQ15w5UYiYKIqpONfjQsyo+1gnrRyBwsaop4iFjuBuUj4MUrk6SuMZkxW7RsTUpNXc+eoZDcvVAF+9SGPwwwW9srcT5P6ZHYl97GstUVurjEGTg6UznnjOs1czZ9Nm9kP98z7mcnvgbk0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruSU2-00041U-M4; Wed, 10 Apr 2024 09:35:02 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruSU2-00BS12-5Z; Wed, 10 Apr 2024 09:35:02 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ruSU2-00HQ6O-0I; Wed, 10 Apr 2024 09:35:02 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Richard Cochran Cc: netdev@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH net-next 1/5] ptp: ptp_clockmatrix: Convert to platform remove callback returning void Date: Wed, 10 Apr 2024 09:34:50 +0200 Message-ID: <0f0f5680c1a2a3ef19975935a2c6828a98bc4d25.1712734365.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1738; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=I0XDCJ0jSC3RZZlCBrBai5GWRKEW6z/idZ0NTi135XM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmFkEb6O1ejE4C6uGLQMhKOCekurzrCGYpXtAV7 SvAblUzkFiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZhZBGwAKCRCPgPtYfRL+ TtWUCACH4stU4JhoY4A10opFfOKYezgusbaUhcGdSiNHlddn20obHpsuxhtBp8XRx6JqLR8oGPe N1QcW+Hx+iGt2yS71sRbtaBbXL2VOwW1UubRdGBsDTjeu3nP+gyrpc7lQpQftFK0T56xhlvVQ23 x+xsgEeLk901pRYdO7FbiP3XKNX9IMwal4T3jLVSEz7Bmaz5NZKT9SoD5gIprlgPPlrV957Uj7/ D6gstcmvktLHXRTvVweOEDpRtAz/gbNh/WGkiwCHmvd94WMy9yOR17cz8ng7WanUKx5Ej/2TRsw 3wqSug/hcIw036CNBGX1471Hp8wiXHTGGM/kJA6LKVZEdsoI X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/ptp/ptp_clockmatrix.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c index f6f9d4adce04..209a45a76e6b 100644 --- a/drivers/ptp/ptp_clockmatrix.c +++ b/drivers/ptp/ptp_clockmatrix.c @@ -2457,15 +2457,13 @@ static int idtcm_probe(struct platform_device *pdev) return 0; } -static int idtcm_remove(struct platform_device *pdev) +static void idtcm_remove(struct platform_device *pdev) { struct idtcm *idtcm = platform_get_drvdata(pdev); idtcm->extts_mask = 0; ptp_clock_unregister_all(idtcm); cancel_delayed_work_sync(&idtcm->extts_work); - - return 0; } static struct platform_driver idtcm_driver = { @@ -2473,7 +2471,7 @@ static struct platform_driver idtcm_driver = { .name = "8a3400x-phc", }, .probe = idtcm_probe, - .remove = idtcm_remove, + .remove_new = idtcm_remove, }; module_platform_driver(idtcm_driver); From patchwork Wed Apr 10 07:34:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13623768 X-Patchwork-Delegate: kuba@kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D19313D2A1 for ; Wed, 10 Apr 2024 07:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734506; cv=none; b=D/VGZQ5pdcQTgoMbtEV+cwa1pZqnhLQJS+BQy4tD8CPkGaNezSEXIEtmwWfF8Dw8DRCpqekianVF71K8fzm75i2Rw8s3qVAVoQI0PrXLNsq84AO9CtrnJOQOpPn/kY0/FG8uYLsSi3rxu9MQM9FXCHkEYaxPyJ7RqLm/+sLp5H8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734506; c=relaxed/simple; bh=GKLi1TpQ/4PyoUz6yT+sH3qWf8dCktmZyI9/1Dn7SOI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oQsoWiZvoYd1FuRStlYzVLvb0hjyexdJoGK8+SDEemsklqeecytGHRxmxxxYqcHlXoIOPtq5BlKgg09zgqD9msh+7o/VALoMlD1WrB3aTAk+lxEyGR/c2g+SPxaLQ0XfSDPF0EzBsVeeA1sG0cCXVOr7+7OStKSPHUVrbQMJBb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruSU2-00041V-Nd; Wed, 10 Apr 2024 09:35:02 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruSU2-00BS15-Av; Wed, 10 Apr 2024 09:35:02 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ruSU2-00HQ6S-0q; Wed, 10 Apr 2024 09:35:02 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Richard Cochran Cc: netdev@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH net-next 2/5] ptp: ptp_dte: Convert to platform remove callback returning void Date: Wed, 10 Apr 2024 09:34:51 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1780; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=GKLi1TpQ/4PyoUz6yT+sH3qWf8dCktmZyI9/1Dn7SOI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmFkEc8+twDccL+ZbJtKINx2NYPUIIGFnO2J/NI vHRx1ShSA2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZhZBHAAKCRCPgPtYfRL+ Tj1uB/9GldHrepIHt32G5H9D2zN7qXgbYJ9svEMZs9eepEceJOpGVpygGGPseO8JMnDuidZVvF4 mF9YILMJnKmoobpY+DJcqWeRKRtyCTSSwolAkHp5noWnkwFQ6IjRwwL8Gf2SLdkQRu3eqtFoDrr SYZIDLi3WU4859gvGlq21OvuWfB2/SN6t+wzrHqGhqIzU+CimmAwu65UWRK/r/FYgfTjlkCoC2b R9vVxtxtlu8ewpqmacA41rajaG5eUYlG+jdkd9Fp1XFIKJKX/ylDhiW0eJnsCdTv+KD3MHhu1Bi zA1bJeS97aR0NpX8eEmCM61dIFNnMRokMvdHcVQHD0xJLoJN X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/ptp/ptp_dte.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/ptp/ptp_dte.c b/drivers/ptp/ptp_dte.c index 7cc5a00e625b..449ff90927be 100644 --- a/drivers/ptp/ptp_dte.c +++ b/drivers/ptp/ptp_dte.c @@ -258,7 +258,7 @@ static int ptp_dte_probe(struct platform_device *pdev) return 0; } -static int ptp_dte_remove(struct platform_device *pdev) +static void ptp_dte_remove(struct platform_device *pdev) { struct ptp_dte *ptp_dte = platform_get_drvdata(pdev); u8 i; @@ -267,8 +267,6 @@ static int ptp_dte_remove(struct platform_device *pdev) for (i = 0; i < DTE_NUM_REGS_TO_RESTORE; i++) writel(0, ptp_dte->regs + (i * sizeof(u32))); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -329,7 +327,7 @@ static struct platform_driver ptp_dte_driver = { .of_match_table = ptp_dte_of_match, }, .probe = ptp_dte_probe, - .remove = ptp_dte_remove, + .remove_new = ptp_dte_remove, }; module_platform_driver(ptp_dte_driver); From patchwork Wed Apr 10 07:34:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13623770 X-Patchwork-Delegate: kuba@kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E0513D2A6 for ; Wed, 10 Apr 2024 07:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734506; cv=none; b=llPksU6AaAijZQRY/s5gOVMTLX/J5D2Z0ZnW+m0jhuWfTKkBZwRrMvxKB4YNwdgpkbrUxJpfqAMPHQDeek6u+RveaOjIrQxSlzddAqzJnwl75r//jFrS7K68mbPXqoD0ogP2jG6ILLpTp+TpNA8Ft6kBhnEB17IE+MgLrG1VPjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734506; c=relaxed/simple; bh=zS3A/NvYkdqObR2oT9yvvV1KKg0CD5GJlQWGJRPexTE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XQgK6zl1A9M1Y2QVAChs7XgEPELSfznJFFdtsQ3UM3HnxbPVDK7LuHqJnKY9bc/SQs2ZauvIGKU2ywW4INP0JGifk17N36foMPsiSh16jE+NIpjJWwZdpSNTVJJW8e03NMZU4yHShYf75C5/LFFAKmwKs5zYmKInczIfd7t1vl8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruSU2-00041d-Th; Wed, 10 Apr 2024 09:35:02 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruSU2-00BS18-Gp; Wed, 10 Apr 2024 09:35:02 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ruSU2-00HQ6W-1O; Wed, 10 Apr 2024 09:35:02 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Richard Cochran Cc: netdev@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH net-next 3/5] ptp: ptp_idt82p33: Convert to platform remove callback returning void Date: Wed, 10 Apr 2024 09:34:52 +0200 Message-ID: <5807d0b11214b35f48908fd35cbb7b31b7655ba6.1712734365.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1749; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=zS3A/NvYkdqObR2oT9yvvV1KKg0CD5GJlQWGJRPexTE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmFkEdMnrvnnruNyr9ODQv6iuF0BlpB31TtxeUR gYJfYo4g1mJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZhZBHQAKCRCPgPtYfRL+ TtJOB/4u6FezSgrJpvAPmQCZ0J8hFifXHBBoK4zSk2CuaVgvF79FED4eXPeBAWo4GZqOvpvymhB 0P5HQWNLD0RP0zGMxk7REeJ+QJ/QN3Xp1co5QU1rLANZjr/PC/aOQErQzvHgI7JP6qtZqnvvq/7 MtY/OCNSedbA19J0nYdf0CUnCarEVLh0/waiNQTEXmBv9DWnuqJwqiMsvN8s21m2KdQpxE6F75J 6vaJKeSgTe7cPh5vcAKF15Bk3FzYCZJ2goQ9flVyQ3xzemz4w0Mf9hdHvMGNaaBQ5Na9BffSnmS E0CBP5vSnSrjogGftHKbrWJYqQyTxGp3rArF7M/IAo6B/k2R X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/ptp/ptp_idt82p33.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c index 057190b9cd3d..92bb42c43fb2 100644 --- a/drivers/ptp/ptp_idt82p33.c +++ b/drivers/ptp/ptp_idt82p33.c @@ -1447,15 +1447,13 @@ static int idt82p33_probe(struct platform_device *pdev) return 0; } -static int idt82p33_remove(struct platform_device *pdev) +static void idt82p33_remove(struct platform_device *pdev) { struct idt82p33 *idt82p33 = platform_get_drvdata(pdev); cancel_delayed_work_sync(&idt82p33->extts_work); idt82p33_ptp_clock_unregister_all(idt82p33); - - return 0; } static struct platform_driver idt82p33_driver = { @@ -1463,7 +1461,7 @@ static struct platform_driver idt82p33_driver = { .name = "82p33x1x-phc", }, .probe = idt82p33_probe, - .remove = idt82p33_remove, + .remove_new = idt82p33_remove, }; module_platform_driver(idt82p33_driver); From patchwork Wed Apr 10 07:34:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13623771 X-Patchwork-Delegate: kuba@kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18DEB13D2AE for ; Wed, 10 Apr 2024 07:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734506; cv=none; b=JVgmxM+IcQ80fEpFbOGwrBeLxPRZkTJqCdBEnzFkvWJLz5a1fvuARplAkmWaFw8RlIt0qLg+YIhKeAxdVnZ/ouXoe7vk77yvY/8zQnC6N6S0q8Yr43foPXKU/+9HzWrB6iYde1r9mU7sBqhTZnJLljP8pe1Ik2gYP8dDwmOrT0U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734506; c=relaxed/simple; bh=VzQOwsB3jfY1dogE9hsp8aNW8xE9cnUt5GXKBcanjY8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EX5eZRtqduwA5cXcEwOOGAKjXgi5hwMx5z4RTEZqHphFFZnndAlhpWsa1jqRLsXLnEzQGnZKi03AaT3hpBMBMNtbSdMifpcBkqf2yqh15dGU284qwco+OGn4db5dHiKVflW6LtjBrJerMw5UhmNf0xm8adS3JOwI4O87hO/ZGt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruSU3-00041z-3r; Wed, 10 Apr 2024 09:35:03 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruSU2-00BS1B-N8; Wed, 10 Apr 2024 09:35:02 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ruSU2-00HQ6a-22; Wed, 10 Apr 2024 09:35:02 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Richard Cochran Cc: netdev@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH net-next 4/5] ptp: ptp_ines: Convert to platform remove callback returning void Date: Wed, 10 Apr 2024 09:34:53 +0200 Message-ID: <2cc6c137dd43444abb5bdb53693713f7c2c08b71.1712734365.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1886; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=VzQOwsB3jfY1dogE9hsp8aNW8xE9cnUt5GXKBcanjY8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmFkEeyZ2kDOikR6CDYAps3HLYMfQAXUZDFzkQo 0yEwTrjRw+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZhZBHgAKCRCPgPtYfRL+ Tux4CACb+6HcICS0s8eUtT210h6VaOw7LwzTasxzXfcaP07VHA4V/2KxweXKAL0Um0Xh5saHHK3 uyAGTMjePsx0Lbvei1MrCxmHMhz2thq7G/dtlVGoZzTJLcW5dm4hjIADsenaQwqOBrUDkXWsfV8 gLN6lnI6fwxomDoy9rqHhfve3MVo6mAfeg4iwNRqH6fzNiI6RWL2ipaMAUsOCAOYV95RO0voux+ wLoz22wITj5VW/1u9C9CjzfQue52LwwvW+1jB3aXPKX97Im8khGlS1AC4KxCon8QhPL0kj2uRTf YmrmT2jsINKBvSqJvBgmJyLS8bzzPx/tuxUhoKeA0pgLTvnZ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/ptp/ptp_ines.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_ines.c b/drivers/ptp/ptp_ines.c index 1d2940a78455..385643f3f8fe 100644 --- a/drivers/ptp/ptp_ines.c +++ b/drivers/ptp/ptp_ines.c @@ -765,7 +765,7 @@ static int ines_ptp_ctrl_probe(struct platform_device *pld) return err; } -static int ines_ptp_ctrl_remove(struct platform_device *pld) +static void ines_ptp_ctrl_remove(struct platform_device *pld) { struct ines_clock *clock = dev_get_drvdata(&pld->dev); @@ -775,7 +775,6 @@ static int ines_ptp_ctrl_remove(struct platform_device *pld) mutex_unlock(&ines_clocks_lock); ines_clock_cleanup(clock); kfree(clock); - return 0; } static const struct of_device_id ines_ptp_ctrl_of_match[] = { @@ -787,7 +786,7 @@ MODULE_DEVICE_TABLE(of, ines_ptp_ctrl_of_match); static struct platform_driver ines_ptp_ctrl_driver = { .probe = ines_ptp_ctrl_probe, - .remove = ines_ptp_ctrl_remove, + .remove_new = ines_ptp_ctrl_remove, .driver = { .name = "ines_ptp_ctrl", .of_match_table = ines_ptp_ctrl_of_match, From patchwork Wed Apr 10 07:34:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13623772 X-Patchwork-Delegate: kuba@kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD4013D27F for ; Wed, 10 Apr 2024 07:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734507; cv=none; b=cahez8TImBCyp1ClVJMZXRGfPSRJO71t2oyamYlk54XoCa4E4rsVnVp1FZm+oBtrtqeHop4Omdod9VfVlZGRmcJkMY4ICmiBDpDWNxP9ZNBdQO3Zut1oZMifWKpAli4pErerJ7rhHGTXIqShbD6pQhF7IlcxMbOngpPQTn9byjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712734507; c=relaxed/simple; bh=3M3EjbbjykLd5QusKoud38l8dOFTlf4n5uAyLMf3oMM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G28egFNxWB2ZlCzoMy8NUDCcj580cOaJqRF2KT1dd7GzFStzynInor9qWA3OHvmgyrOz4zOEFmjSOO6qbaLGSpkc1hJ3S73QEOc8AmuK3Z8EWrHxZJ1zfVHMMHFg4LTlX0sQrd106rkKZi8lhN49g0s7CHK3YqiR1Kgplnig1/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruSU3-000428-9c; Wed, 10 Apr 2024 09:35:03 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruSU2-00BS1H-ST; Wed, 10 Apr 2024 09:35:02 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ruSU2-00HQ6e-2Z; Wed, 10 Apr 2024 09:35:02 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Richard Cochran Cc: Yangbo Lu , netdev@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH net-next 5/5] ptp: ptp_qoriq: Convert to platform remove callback returning void Date: Wed, 10 Apr 2024 09:34:54 +0200 Message-ID: <477c6995046eee729447d4f88bf042c7577fe100.1712734365.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1740; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=3M3EjbbjykLd5QusKoud38l8dOFTlf4n5uAyLMf3oMM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmFkEgBl07CxG9YCXrifAJG8BER38HW10E5/Mh0 eEMcxyixzSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZhZBIAAKCRCPgPtYfRL+ TrEvCAC4uuVpkreR7sgGpRWsrXtHl3shsUUB1ZgXTdomPLc9Dq4Jwz8RsRHie1sThSKzIDVHOJ3 GMZEWr7nzS5ZfQnLP+d9ElOeCHziKoTdeYTORDwhREl90nxqNLVyau74h0+sPmOVdIQrbnU5nww NpvaEhQJV72+inmWkHFUktqOEVttNsyMKZWvIaKjvXcWKwUU+WL2Q/P+t4Wfh85CcSy6gc8KdJI 5wmncC4RsL8/Ib8yJx3OXmyc6P/ESpTsIlzmo3cQzLRBt2CYZ2t2ozD8GA+kI+BYJmwLLcw8OjO eJa2Bod966y1XXm9DqoqAea64Jr4Rnl8PJgQsKKWjgkRIOSs X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/ptp/ptp_qoriq.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c index a52859d024f0..879cfc1537ac 100644 --- a/drivers/ptp/ptp_qoriq.c +++ b/drivers/ptp/ptp_qoriq.c @@ -648,14 +648,13 @@ static int ptp_qoriq_probe(struct platform_device *dev) return err; } -static int ptp_qoriq_remove(struct platform_device *dev) +static void ptp_qoriq_remove(struct platform_device *dev) { struct ptp_qoriq *ptp_qoriq = platform_get_drvdata(dev); ptp_qoriq_free(ptp_qoriq); release_resource(ptp_qoriq->rsrc); kfree(ptp_qoriq); - return 0; } static const struct of_device_id match_table[] = { @@ -671,7 +670,7 @@ static struct platform_driver ptp_qoriq_driver = { .of_match_table = match_table, }, .probe = ptp_qoriq_probe, - .remove = ptp_qoriq_remove, + .remove_new = ptp_qoriq_remove, }; module_platform_driver(ptp_qoriq_driver);