From patchwork Thu Apr 11 23:32:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13626613 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D6C8481B4 for ; Thu, 11 Apr 2024 23:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878345; cv=none; b=aCUONPyiH+jCOvuEDkXmIzV4QNJL6n+xfZ3TnIBfU7W+b2p1uNXpHlqKpAs/5LR6DcmSsrpUEiK1sniCnZyiVcdFF6oGVyugNeOZr/cMlYdvHoBxl5hhGShZbUV4f5QHxQvJVXkN5hADD12Lx/7/eWLIYKLrLY3gXXATp9THzD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878345; c=relaxed/simple; bh=aj1NMeFhA5mefTWVn3dIMc7oAZAyt0TuN3zaUFP3E+I=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=CVmglgccZcy3N9BxwIhbWrX8NpKqu4HsmjawIPzS43kLCn7UtwtaFwfM/w39liF6tu6FCWAL0rCfaysCd+n0K7IPt2xMtpsRVkEwmYh4oikFSpMfulqH93OfjWyClS7oERyaPRwUC3Sys8tljsPBmU1D+0xMZZSBn6rHuS6yqwU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sr1tuTVZ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sr1tuTVZ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-417f81ef284so1320035e9.3 for ; Thu, 11 Apr 2024 16:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712878342; x=1713483142; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=OW6nvzJwMQb+PLM1E/EMaRktSScWXvCfer570OXxv6w=; b=Sr1tuTVZo+NY93DQX+6uVJ4m/o4iYfcRetd6iF0qaxuKBs6i7cOnu7DQ98NhOmOuFh K/3vqqKr4Egzw+cmr34JqH7Rwr5yAcAxjpYRVsfdP5Vj00Z/PDKJ5TCt/Z3PB55j2Y5d CI7uov1am9+Wm/1/dN3bYby7Xn9AoxiyZF3NOOhZiGt7XOnNNi3kT5Gi5sNS0ysaGNpy WhLudRlFfkTaEEbWw7YVJMBQVF78LviD3wabKjZCYUNXcR2JEfXNb7Zifj4OiJTguctp 48v/lkHvmfG4FVrYV76pTOY0KoPcRxTWBhrTpf2yRM3m97TluSfnU/F9F7fSA82jDx7G 0EMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712878342; x=1713483142; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OW6nvzJwMQb+PLM1E/EMaRktSScWXvCfer570OXxv6w=; b=mi6WxMrZ+TSTMr12oP/IjVKm90TjnFVTA36zLKCMkDrbGav9b+5YS/jxc5NMcOR4cI nAHcoKvKFB0u//Q4F6ae+1W72cKyu/NcunVCeAj254BeMcWKVc9uy91BTxxnZxrdqouR ohleUL4dSzXwDaBevmgH/a4FaTJ68wXiVSjlFSoCWgXFsAqoP40T1D2/oHhFeP3yKH98 nTu/1C4/1pq4ZB2f5tcybdp2u6AJiueEUak5tJax2OWc8CWOZQJUdlIVMDb64VbDh4mB HbC49bvBJDv9x7qa2+LrGQjZoxp5qmOB3gh4AndBQFXg9eL+NtwZArasxm54zwpCAn6n wM5g== X-Gm-Message-State: AOJu0YxwPrtFjIQnVTzyjCLxWeON7h/ks7VLLxn8EEDdKSfH42InNzEa GpZnh1PbaRt7SrRpz7nmLd7IP3ouogdhD7cnlrKVgh/r8y7LO8/un7Ti9g== X-Google-Smtp-Source: AGHT+IEQzZLBrrvLBpv2C8UwaGhbVRtvV0/qxxpGi25S6PuqLhDueWFKo/87LUFRTJ22KMGhni8uQA== X-Received: by 2002:adf:f74e:0:b0:343:968e:f27c with SMTP id z14-20020adff74e000000b00343968ef27cmr610644wrp.27.1712878341975; Thu, 11 Apr 2024 16:32:21 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id s8-20020a5d6a88000000b00343c06d75bfsm2844307wru.61.2024.04.11.16.32.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:32:21 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 11 Apr 2024 23:32:12 +0000 Subject: [PATCH v4 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Although we've had this script since 4d06402b1b (contrib: add git-contacts helper, 2013-07-21), we don't mention it in our introductory docs. Do so now. Helped-by: Junio C Hamano Signed-off-by: Linus Arver --- Documentation/MyFirstContribution.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt index f06563e9817..de60b3a4fa1 100644 --- a/Documentation/MyFirstContribution.txt +++ b/Documentation/MyFirstContribution.txt @@ -1116,6 +1116,18 @@ $ git send-email --to=target@example.com psuh/*.patch NOTE: Check `git help send-email` for some other options which you may find valuable, such as changing the Reply-to address or adding more CC and BCC lines. +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are not + +part of the core `git` binary and must be called separately. Consult your + +package manager to determine where it is located. For example, on Ubuntu-based + +systems it could be installed under + +`/usr/share/doc/git/contrib/contacts/git-contacts` and may need to be called + +with `perl ...` if it does not have the executable bit set.] + +NOTE: If you're not sure whom to CC, running `contrib/contacts/git-contacts` can +list potential reviewers. In addition, you can do `git send-email +--cc-cmd='/path/to/git-contacts' feature/*.patch`{contrib-scripts} to +automatically pass this list of emails to `send-email`. + NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but please don't send your patchset from the tutorial to the real mailing list! For now, you can send it to yourself, to make sure you understand how it will look. From patchwork Thu Apr 11 23:32:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13626615 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BBC8481C2 for ; Thu, 11 Apr 2024 23:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878346; cv=none; b=UQiMcGVb0ydjlMZ4sbSbk1oWbZUBzZN2oDQfJGgY+YkFL1OR4ksI0ne3/bDASKYVunj3a6cLxL9P2k9JSE2VzG9ZxxKC9N7Yj/2kFW/8YMumNS6eLM5DFNnreF6Oy6K+e/Rr6jIXeeJSzShtpCKc3aZh8/PIDMfOr7AwV3uwLRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878346; c=relaxed/simple; bh=x4PnA19b2SZv51C9P3CaUJoIARINCb/W5YcbwcbDD4s=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=Jcq98v9v+4AndDLkFi+ezt85ne761LR6ATK3CsVUBu3Mmz9to55a4XOV5/EV9XBRhkbFCWlhLCoWmPSZ2GIyUXn6uLtmAc/fx6L8i/r4u3evvP67xkK2t1ongtIU9QeL8aJHERTr9R+dgZj8zb1pvM38iWNv/tQiXrKxjDssLms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gn+Gecjr; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gn+Gecjr" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-417d092f2ffso2866835e9.2 for ; Thu, 11 Apr 2024 16:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712878343; x=1713483143; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ACzd8EiOpJ1sn1V47sERPLxEfhI941PTgUhJpQEy3Co=; b=Gn+Gecjrh74vBZ5+4svPurbG49mYvQcFoJ3rWAW9sEAVCpRMyV1sBBtgJfhIfQSYr4 pW3QTI+0W5yIYQXJAawmRGy9Xih6NW5ez+cdfA5e82pQdhWQzou1RqtR3YyrUBfw2rLM kvSkNhc43tswkwLZSNjfuAcToUDY8bbY3SLsEEDj4SVx6lsnF5WEYRTLlD+UhuMo1co/ OvUIs72gogneScgrs12FltcH7Pb7Suf0GgEZcjud8VlvtOUfNrItgpiMl5tFQOTOUJBe tcdiGccZaygMzCsQHpevWxOHRInwRzLogWHf7kbujflgj3KqR2mbIpNjZCGuikavTLBC APoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712878343; x=1713483143; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ACzd8EiOpJ1sn1V47sERPLxEfhI941PTgUhJpQEy3Co=; b=Fh/M3hiZ6mMF306rk0B8mVNE2DVL2Nc2NGNJ3XLkcn0QHDR7UfdHCdtKEhULlBgGMC UxUJV48zQH8FXS/aqpFiOnkmSM5/+sF5NX8rb+YUnBnNx04vXp2CRrYJlqIvA/P6inzt 3s12MmodeXqp0Zc8DxAS+ySfacseUM17CdEA8UFNdH0n4Pa7FzoRryRM/YFIEjDSiQ9D tHgECQWADt8yTLUhq2T2Zy/uq2VoAPXD/vFRS/mv19MsuMClngzSA/B84LZ07PPwkRPe SxO9XLJJ8xd9HYQuw+zr6/MlS8Lasg3VKqMJJEtoxngWGgYmCUFuwpCkXqTr9p3o/kj8 fUJQ== X-Gm-Message-State: AOJu0YzCeYzu+Q8nozTnUo1hoMN18ZfF6GAXnOgwpRqx3y0uZsfwWhHD ZMwlFMh4AzuIvd8BEF0JseDimGtWv/ccSrSLbmM3TOMuzpr7Y+CJ0Pqi6w== X-Google-Smtp-Source: AGHT+IFJbUM2JGIM5QqiJpVBImFhDR+PNPuVujcfhkefTSrCzVJXOVXNggGx7zgHPhAyT2Mt9xUVyw== X-Received: by 2002:a5d:584a:0:b0:346:301d:8908 with SMTP id i10-20020a5d584a000000b00346301d8908mr803935wrf.49.1712878343265; Thu, 11 Apr 2024 16:32:23 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id k15-20020adfb34f000000b00346e8931f6dsm1127690wrd.117.2024.04.11.16.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:32:22 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 11 Apr 2024 23:32:13 +0000 Subject: [PATCH v4 2/8] SubmittingPatches: clarify 'git-contacts' location Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Use a dash ("git-contacts", not "git contacts") because the script is not a core builtin command that is compiled into the `git` binary. This also puts the script on one line, which should make it easier to grep for with a loose search query, such as $ git grep git.contacts Documentation . Also add a footnote to describe where the script could actually be located, to help readers who may not be familiar with such "contrib" scripts (and how they are not accessible with the usual "git " syntax). Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index e734a3f0f17..8b6e4bf0300 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -493,9 +493,16 @@ security relevant should not be submitted to the public mailing list mentioned below, but should instead be sent privately to the Git Security mailing list{security-ml-ref}. +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are not + +part of the core `git` binary and must be called separately. Consult your + +package manager to determine where it is located. For example, on Ubuntu-based + +systems it could be installed under + +`/usr/share/doc/git/contrib/contacts/git-contacts` and may need to be called + +with `perl ...` if it does not have the executable bit set.] + Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git -contacts` command in `contrib/contacts/` can help to +people who are involved in the area you are touching (the `git-contacts` +script in `contrib/contacts/`{contrib-scripts} can help to identify them), to solicit comments and reviews. Also, when you made trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility From patchwork Thu Apr 11 23:32:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13626616 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ED8F481D0 for ; Thu, 11 Apr 2024 23:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878347; cv=none; b=tDZv85N9uKO0FBWDkjQHx/+mGWpREVyKldEhB++mfSrleut2JJWGA9ueB0EHGkLLEUMbp29K4ZYBTo95R+/IcRjpkZaAdTIXWf/J5QYt/crDB7IozWws5mvPgqHyHOUrbO1zxygKHUfEjkdZKp7yk2vlgqwxUVtBnNz9IsiLf28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878347; c=relaxed/simple; bh=fumMIhhIOjXaB15SAgFyp3TNFUgimmqu2qWllBUWrCU=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=puGlkkv06UaMOJaGsyG+WQ0svIE0YFFJWsecKBLBFHHGvunke/dZ1JQE4IbZiZ/39weaSCR76nbK1sOjm2GHDC/INHZrefwsVSEe59n/BuyDwcsqteHUsNYPKYwu5mJBRI42fT4y6z/AacHY1KieKMDAn4zWPb2GvDoZhtahGM4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Es6diJER; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Es6diJER" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-417d029bee7so2643395e9.1 for ; Thu, 11 Apr 2024 16:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712878344; x=1713483144; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=f0KpQtM58p0btI4p3VnnhRuIBndaCfiIpHHeSFU9oU4=; b=Es6diJER28xgpo26WyGnfK4QL0xhjOXXyd4++Mqqx6UD+Mzktmc+BFbatv3bTQRqMc UbxSpAT+cghbj8pG+1XSBSPoHfaeMuMyakBJrY6Sq8rVNNU7vQ8l5Yp/EMyzu5lYD3GL uk4kZ6LWsK6mta2MWxPH8hS4xlLbdtz0MO5JgpIFD72uidPbQ6hKq9uVcOG+dyQNpG+O bpWE6B3mZLFxokYWGBOO9mhWvrKbpJ4izF5/rQYjXROJcI7bfBkJ/Epq0pxnDXhFS5sC xpdO5preiESLBtPE/2IJJj+1LLpch7aLvzMGbBP70ZfJ096AfnESsLcFaWxiO5sClcyK qIPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712878344; x=1713483144; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f0KpQtM58p0btI4p3VnnhRuIBndaCfiIpHHeSFU9oU4=; b=hzhLyZyXmxEy3yleiH1X2hNlZ/VBZHeJwgDen1ExI/FncPYDVkNa39yD2VM3ftb1/m czRibYainJvF3XvUBbJzxoxxmhPDmkb7i0KAsF1Utw1ayGXNOWE3Hbf8xqLudUDOqk/F MCGpJ7hevoNqanEMTdtlVh6KGEf+itBX/sYHPEUtcegTh2kg68DtHqmZFW0/DT8qhy7i oSQ+KQ9umTa4XQ+NsRkxuqBiibjGbs3dmQnTyB/E30bboNxX/hH+0ozskAlCrO0/rjvu 0Qr+khY8ww/VDtgUdth5sNpIko/yDcbUX1JSIMI5XGTL9QgeYVywL1FbDaenl7NzUKga jRuw== X-Gm-Message-State: AOJu0YwEeIY3qbYm6Nt8VBAq8I/8r0FauNNIjgQ1wyZONpEiMQEnKd4n QUlDgjEsi6bgMzk/dONn14rIqqfCl8v7Gm2bCs1WnK2LVuUteSUxDiol2g== X-Google-Smtp-Source: AGHT+IHkRqwQgQpkEQbcao7ZJtPDNbPWVmDfwQ1wQfUxR8HX43vSaWU0imOqOoPL5cjpJTYREUMb0g== X-Received: by 2002:a05:600c:1549:b0:416:af4d:e3dc with SMTP id f9-20020a05600c154900b00416af4de3dcmr979947wmg.12.1712878344220; Thu, 11 Apr 2024 16:32:24 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id v6-20020a05600c444600b0041668770f37sm3730543wmn.17.2024.04.11.16.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:32:23 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 11 Apr 2024 23:32:14 +0000 Subject: [PATCH v4 3/8] SubmittingPatches: mention GitGitGadget Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 8b6e4bf0300..2226c09e6c5 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -408,6 +408,10 @@ are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. +NOTE: Here we outline the procedure using `format-patch` and +`send-email`, but you can instead use GitGitGadget to send in your +patches (see link:MyFirstContribution.html[MyFirstContribution]). + People on the Git mailing list need to be able to read and comment on the changes you are submitting. It is important for a developer to be able to "quote" your changes, using standard From patchwork Thu Apr 11 23:32:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13626617 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B7C54AEC7 for ; Thu, 11 Apr 2024 23:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878348; cv=none; b=KTeZI+2Jhiv4r3n9xZ/LtJfCPof/DPF3jxf5ups7CzCkDYm0s/XPPUWsoMQYM3Mt29CUSYxbk6wRuw0veqQXkqj0KVIsN9RhCEu9BDDz0qZ9JBG0qzFOguG2WY9ATKd49CBqeo+oUDBlBloUzZyKeTsmiRa2yDuIujvFBoWKrTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878348; c=relaxed/simple; bh=qnKiJD3CT3wf1ILX9c41YZiSgm9Sf2RyaaT2vpZ7mME=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=auGrUAp/AUq2ZMapgSCRXnDCaNtldhLb+YS33Dd1qSzHsPthJPKUu69J+keKnEwUO9MGxiPf4jjwUJR0k6AM0CaVpRNZkGHNXZjFCvhg4UtXS14pCHjwaKiZFHKEqeR3Q2mOFNru3DQkaWkEIHblUJIcI9HXf2iTUGryOP1q0b8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YW7nEZxH; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YW7nEZxH" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-417d092f39aso1866215e9.1 for ; Thu, 11 Apr 2024 16:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712878345; x=1713483145; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KfXXZp67ctZjTXCIGvshqxvVtrY4WlSznM9j9CDoBJM=; b=YW7nEZxHmTP5sdl+LSsbthAwb3wf0og6dJYiglJb7c9OuW6sgZQcucDhYDkr3AD1E7 Qw+NZ1t4ZRIdBsnEmGJ3z1Z/CXFApQhO/bSdHx39FpJYq02nmmoodn7E39Gd51zZti52 g3XZ//bvF9MqFTlLX4DAkOzMv/F+EBPpswjKVgI4/aOzg7CO1oziMHH8rZ2Q1XwU2j2u yaCf/VBYgBxV6i4Mv2IdYLoX3JeO8uHst7AaqTKD57a1Ov3NJrAmeRuNyB8XN4uQxq+e +f3EynDNfjZdx87wly/WdNocbZD0QE4Ew+EuWFWcvdzhgQloi4/vhY/bmb3VM/LESvAa UpfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712878345; x=1713483145; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KfXXZp67ctZjTXCIGvshqxvVtrY4WlSznM9j9CDoBJM=; b=REzFK3b02ERk2s87QJtlQ2XupCDK0c/nU7XfbzbC/H1R9o2qhf93kBK7gx34aKgjcr wQYyGUKeHQHRAEnvGIsGWBCEoxekh2d9/xLrTScavEX2NFUtOY4dwca3sQaYadLLGBTS nF3Tio9VvgSecsKYmtXDJBDiHsv6wntarCVqpn+ROYrB2k/YpFKsNzgFsAhNtbnPG9qv c0lkClt0XvbP5GHwqyapKt+Z0YKLPgKu+k3RBzPJlQC8NZXL+v65x0T9U0CK9NmhJj7l sF5yK/NYrt5ulMef3Y9sm7Zif6uSB1aSZVTNoYo9BuvB+5ZrhCeXzTWK/aQzNq9ywt64 eIkQ== X-Gm-Message-State: AOJu0Yw0n+LMEuXaML72Sw1zzrJogCakaojnO7ya9RbM56uWiB4vUaPn 235rE2uhoX+Idts+lvy4fkbCDkt4nY42pxzHbp/366tNnm6rFOYGLUsyIQ== X-Google-Smtp-Source: AGHT+IE7GTvo8JBfQdrz2CmnYWfYGJZB3M9XaqTvE6M51Db4vVv0xGTFM2Keaq5s0UiO5gxwkIvZXg== X-Received: by 2002:a05:600c:1c23:b0:417:5be9:1319 with SMTP id j35-20020a05600c1c2300b004175be91319mr915068wms.12.1712878345222; Thu, 11 Apr 2024 16:32:25 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id n18-20020a05600c4f9200b00417caec4135sm3752837wmq.4.2024.04.11.16.32.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:32:24 -0700 (PDT) Message-Id: <44470a5d70edb60bd4f573f6b214e7ff5cbb4c05.1712878339.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Thu, 11 Apr 2024 23:32:15 +0000 Subject: [PATCH v4 4/8] SubmittingPatches: quote commands Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 2226c09e6c5..f1c0d1483bd 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -403,7 +403,7 @@ Before sending any patches, please note that patches that may be security relevant should be submitted privately to the Git Security mailing list{security-ml}, instead of the public mailing list. -Learn to use format-patch and send-email if possible. These commands +Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. From patchwork Thu Apr 11 23:32:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13626618 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB9584C60C for ; Thu, 11 Apr 2024 23:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878350; cv=none; b=NbMW0kO3QNDKXQDTG0cefbBrbs5PWMXovcsqrx91MPjjNMlA7Y4OXS83f1h+jnat4eiGTJB5iQNhOtbxaMZgUlEUnSIsNSFmnJEBWA7fKUQN3XspaJYQE0XXij+r8kaBh/7i8EOmV0XW3x5LVruBlgIrYlni6/nuqedEUqCq4bw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878350; c=relaxed/simple; bh=a0DwZJqfHNEiyf1I43XsENVL1rFgZ2rPn7RjEU10J/c=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=QuOGhF2KnwxzyNPikZ0UygnT7IRHGa3PVA2Nk+fdhVyBI6QIXd366MbBEmwIsznex7VXpW0q+EH0M3fy5txAQiAGyQOXcaMPwC9/i5U2DrW4pNZwWhoBkOKlAnHOAVi+MYCSEaJfkr0NzlwgBh+iwkKg77ypoU4ku2qFl9Nz+uM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ktlfdn2T; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ktlfdn2T" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-417d14b3b29so2593175e9.0 for ; Thu, 11 Apr 2024 16:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712878346; x=1713483146; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=GEbXp+6FzrWn85i4TPSECfd3gAlSF9NSyW8X8bUGl4Q=; b=Ktlfdn2ToG3LLjoumgDhHzJp35Lp7NfeHH1ZsGufltEuitWyxf7M1fbhWU1wXgMxKH ktt/20rQnqSAjudhU/NRKSlQqzMVvRxl8G2DzYGBRdAtCVAFeQmau2wezjp/3Be4B+Tj yz1Eueb212nyVP2zmoqB7j5OBJLozWcFYZlIgdK5OUSIJ7QIsKpXaA90yvcPrkyoQn0Q PNAQFHg9kIVbfWug154pArsOreXF7dLSDXiFVHgr+jHfvqB4NzFbViePm2mLTlQmfy7k 4JGzKZBNhDBCu8LYK0iZK1Z3qwHiy1bg9iga/1tcwIGFqzVFf75R6BoBMae3N97z5esm mCZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712878346; x=1713483146; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GEbXp+6FzrWn85i4TPSECfd3gAlSF9NSyW8X8bUGl4Q=; b=TbRmXCRJnc4l9GVNtvylwJz2APHQ8VXGevgpUHbK8UM9/yiH3usT4PtugLbQwW8gWe KTLNHVKHog7D00y0YawjmcmA51O8V5c2d7RfXpnMAkDOpGxHaTwcFT5aBugBe4+uBeAt 0tpDoZdyY+VeZxb5yaFWM7vFwK4e0AzQu10z//A5nCSRcjPi0zzL0SFp3tjmGeWRY2MI l2qB3yjFZ6LCTWOeALmlrBvuqmrBme6bKoUiGlfnWAf3N80wW6XQU6Tr1c3Joh4yyTcH C0g63iUliZUvVyOI42F/+pGF4ZTT+7fJO7bLIDxnWGOez8cMrYtPsAoaKfmnC5YGku7s VSOg== X-Gm-Message-State: AOJu0YypeqZpIDRISKTCp1ZJO/KrjnUsOB9lblq4zcKQdACDbLxh9mK7 tKB7e6rJRik4D6EnHVCZHOE6ExBUqTdwezr2FFqLN1fH26D6ZXpzsZBQ5w== X-Google-Smtp-Source: AGHT+IEZoXyFgsPAVb0i+QSWNp2DlIXOmHbIvUKrbkAzqLLlqq9rbnAL15Asp85QRes+pfeaOZoPiA== X-Received: by 2002:a05:600c:4f0d:b0:416:6dff:9850 with SMTP id l13-20020a05600c4f0d00b004166dff9850mr887033wmq.0.1712878346254; Thu, 11 Apr 2024 16:32:26 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id i7-20020a05600c354700b00416aca5ff66sm6930647wmq.19.2024.04.11.16.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:32:25 -0700 (PDT) Message-Id: <15f9356ff97a428a73226a5ed36bcafff9f00875.1712878339.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Thu, 11 Apr 2024 23:32:16 +0000 Subject: [PATCH v4 5/8] SubmittingPatches: discuss reviewers first Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver No matter how well someone configures their email tooling, understanding who to send the patches to is something that must always be considered. So discuss it first instead of at the end. In the following commit we will clean up the (now redundant) discussion about sending security patches to the Git Security mailing list. Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 72 +++++++++++++++++---------------- 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index f1c0d1483bd..8805579a36e 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -397,6 +397,43 @@ letter. [[send-patches]] === Sending your patches. +==== Choosing your reviewers + +:security-ml-ref: footnoteref:[security-ml] + +As mentioned at the beginning of the section, patches that may be +security relevant should not be submitted to the public mailing list +mentioned below, but should instead be sent privately to the Git +Security mailing list{security-ml-ref}. + +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are not + +part of the core `git` binary and must be called separately. Consult your + +package manager to determine where it is located. For example, on Ubuntu-based + +systems it could be installed under + +`/usr/share/doc/git/contrib/contacts/git-contacts` and may need to be called + +with `perl ...` if it does not have the executable bit set.] + +Send your patch with "To:" set to the mailing list, with "cc:" listing +people who are involved in the area you are touching (the `git-contacts` +script in `contrib/contacts/`{contrib-scripts} can help to +identify them), to solicit comments and reviews. Also, when you made +trial merges of your topic to `next` and `seen`, you may have noticed +work by others conflicting with your changes. There is a good possibility +that these people may know the area you are touching well. + +:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] +:git-ml: footnote:[The mailing list: git@vger.kernel.org] + +After the list reached a consensus that it is a good idea to apply the +patch, re-send it with "To:" set to the maintainer{current-maintainer} +and "cc:" the list{git-ml} for inclusion. This is especially relevant +when the maintainer did not heavily participate in the discussion and +instead left the review to trusted others. + +Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and +`Tested-by:` lines as necessary to credit people who helped your +patch, and "cc:" them when sending such a final version for inclusion. + :security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] Before sending any patches, please note that patches that may be @@ -490,41 +527,6 @@ patch, format it as "multipart/signed", not a text/plain message that starts with `-----BEGIN PGP SIGNED MESSAGE-----`. That is not a text/plain, it's something else. -:security-ml-ref: footnoteref:[security-ml] - -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. - -:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are not + -part of the core `git` binary and must be called separately. Consult your + -package manager to determine where it is located. For example, on Ubuntu-based + -systems it could be installed under + -`/usr/share/doc/git/contrib/contacts/git-contacts` and may need to be called + -with `perl ...` if it does not have the executable bit set.] - -Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git-contacts` -script in `contrib/contacts/`{contrib-scripts} can help to -identify them), to solicit comments and reviews. Also, when you made -trial merges of your topic to `next` and `seen`, you may have noticed -work by others conflicting with your changes. There is a good possibility -that these people may know the area you are touching well. - -:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] -:git-ml: footnote:[The mailing list: git@vger.kernel.org] - -After the list reached a consensus that it is a good idea to apply the -patch, re-send it with "To:" set to the maintainer{current-maintainer} -and "cc:" the list{git-ml} for inclusion. This is especially relevant -when the maintainer did not heavily participate in the discussion and -instead left the review to trusted others. - -Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and -`Tested-by:` lines as necessary to credit people who helped your -patch, and "cc:" them when sending such a final version for inclusion. - == Subsystems with dedicated maintainers Some parts of the system have dedicated maintainers with their own From patchwork Thu Apr 11 23:32:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13626619 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6C584CE04 for ; Thu, 11 Apr 2024 23:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878351; cv=none; b=HgvimcnnlF0YuWhjzAauvPs5C4ulTb61R9E91HsnviCErHU67VfbyIiUnkovljcS8Gd6KcmUFrTY3VNghfZqeNi5MNRZqKltqXi0XOaU6Uzh/g2wfYytHs/CTw5WWYlwajSngo+ns8GVigTug3xwPEdieYBTaTdOK8DITEJgjh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878351; c=relaxed/simple; bh=Kz99GogLEhZHQLY/eZCIt8qbiH76jvagkjpGYXJisR0=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=LBbAp6AJFzjg7YbHtnkBc9oOvqHqUeA9iJwlmeNLhZPr0g5lcW4I1KAdRQc+E6a5krZ63RGE4kAq4e9UgKUd1uZA947ZVYrpFTIr/YeOcL+Jcit6dtYW0oNLGpPW+aRmjFI19Gxt8KELajs+DD0od0g+54IDRer2y0VdlIRTcrQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IXWLJ+GX; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IXWLJ+GX" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d094bc2244so3315181fa.1 for ; Thu, 11 Apr 2024 16:32:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712878348; x=1713483148; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=/cujYfvsf9Q2v8mchqaD3KzHFDOWtn09nJSffrZKYfk=; b=IXWLJ+GXyT8NIRHOEo5fxMldVfL75D2FaQXeDRyGrPG0eH/BrxiQ3d01O7HvEHeMJL cBNIA84pknszCDzInZ99igwvBvGHX+SZosChw6Q6K3XH8Ntq7fo2MwFbIarQBTKhH1Lv +nAWagiRDf1cI6t+KN33O0+rUjpEXglWNaRJAOTcE1wG3E4yYqM/bxMNJU3dHIFXBOmh cMVfhHAE3HTFZyiPWVeDC9VJRnOVMysCTTJZOSih3kDhELquXhPEbyqgaXRuIAitomhs XEotLbCklA94V5Vi7JlArIXFsn4aNrz1JoK5kNsuXnzAwK2lAc5C3zbqpEThHW2hJ8yF dB+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712878348; x=1713483148; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/cujYfvsf9Q2v8mchqaD3KzHFDOWtn09nJSffrZKYfk=; b=CP6Moqxjhs8nmdwOORH0E/X/q51fOk57FxPiQo0/J2I+9k4tBfmy5infSM55+6fAnI 2ksg/0Eqm+W089Kp5HJyYnaL79108vzTtWfQKJr1PMXKmI9mW/fYcGvPX5ynkiv6fdCy ZRR8Kj7VYKemOPe9yFbRTR2eMNapmHp2MvjG8hoa7t9GHctdYE3JmWjkyr3SBsxN2J6W yNs1mnl6iPI1IpM3bv9xc80Nngwno/zAARpueUeYHlZcLSqpfADVDmE0Xr5h45gpxGQw oUZayjjggXztPf2PxOYBigFDa/mxs1A29QJPyrDiEzIQ/nt4Q7YrJxOE8q+HH2bRalRx 1dJg== X-Gm-Message-State: AOJu0YzEu6gADcG/A9xcw/KG0qaDMy/rVVbtfcaGbRK75B1NIvKOBPU9 rO24P9ZW84/3NU2EFgO7TcLayjN6Ng5dZaYPkOQSIgW9OKPXB0XBC3aY8w== X-Google-Smtp-Source: AGHT+IEToDCMMmTPEZpWwiZdE9H2HhhRDh5xbfdcJ+U6gtJY+wgEUzQrSG2BlIsRe4qTVVTjahKPaQ== X-Received: by 2002:a05:651c:484:b0:2d8:4af7:1235 with SMTP id s4-20020a05651c048400b002d84af71235mr445217ljc.44.1712878347702; Thu, 11 Apr 2024 16:32:27 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id l23-20020a05600c1d1700b004163ee3922csm6947200wms.38.2024.04.11.16.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:32:26 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Thu, 11 Apr 2024 23:32:17 +0000 Subject: [PATCH v4 6/8] SubmittingPatches: dedupe discussion of security patches Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 8805579a36e..ecc1622c8bf 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -399,12 +399,11 @@ letter. ==== Choosing your reviewers -:security-ml-ref: footnoteref:[security-ml] +:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. +NOTE: Patches that may be +security relevant should be submitted privately to the Git Security +mailing list{security-ml}, instead of the public mailing list. :contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are not + part of the core `git` binary and must be called separately. Consult your + @@ -434,12 +433,6 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. -:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] - -Before sending any patches, please note that patches that may be -security relevant should be submitted privately to the Git Security -mailing list{security-ml}, instead of the public mailing list. - Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Thu Apr 11 23:32:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13626620 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A88544D135 for ; Thu, 11 Apr 2024 23:32:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878352; cv=none; b=HdnoFqVj6Cw0HM54khOb8ba0vFC1vOdC8ItzlOE9D1GdpI62TsgKfDiP6JBUFik/yZBDj1i2EQLgf934Xd52wkLvsKKtvjI2gVbD6CeBroYpc7qBdJtOuqrgWzlfXvB5Rzny7xvFSR+Ctfl/vq5yZastm7fDkFREU9IEY/Ke1bQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878352; c=relaxed/simple; bh=m65Lyj4qOKzezlQEAP9zCSgUvtX1U62ojZ3VjLrkWzY=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=ZVrjMYdjsk1Q8gnsuRJZHqQ9j5gDFAtxPY6u4KHoiT7T1lqCMhch8Z2KXzPI+z0yjnF5Yc2Kqj5UGRwdQklpAa60pNoFbXDVm8eBvebHN+IpqdUke6Fq+ep8LVAAfuFn/jIOCxsByxcj0wMPFXZFvCX1oTdz8ywDPihN6ngp98A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BoQkr9YM; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BoQkr9YM" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-417e327773cso5467585e9.1 for ; Thu, 11 Apr 2024 16:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712878349; x=1713483149; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=4j0Cobwn8pOLHdBx5HncqmKTqtmSNrQN1DDonsyvETw=; b=BoQkr9YMhEzQy7O7i0yAZvkvPCbGN75N+1grnFLOurZvO+rO3ZfSGqP5Z6J07UJxRU wustxYrbaWgLMIW7B+TkbLWQyLc7tTbqc7SsIBUsi23b2ZPEKBHfzU9eit/DN5JsGInZ SpAjgUAjwixScIE5ApGHul0AwY81P/2YTi6DtG3VvETx4g8g1VbDLw+04wEy4N0FwWW/ Hg9B4rh8jRmZhCZsSNIFYUn6908A52ldot8izbE7L9FN+XJ+zntoGEHpXbwE2x0sygzZ xrZorC8YD7u2o7BWrhj5K52FP47I4wW+IZ/fc5I71JNAgkE+QSzLlsQ6o1Q0GU1B6doW 29Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712878349; x=1713483149; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4j0Cobwn8pOLHdBx5HncqmKTqtmSNrQN1DDonsyvETw=; b=VK1aP7f5cdjT9uVFDq4N3+eokd/wgbQIMM2xaWOX9BMVrKzZtRcyd9hzDOseQ3HKMQ iIFwThxI+kzRnBfEGClTPNLzKipdDGDQ64EMwf0fopTpwz25w9ksZchmAQNqrVW5k3ef kkWibo5OkT5Yv8sSimwi7i7Ns0uCexi61cCnNVMl01GGFUV2V9llasuayrhBuasDd4R4 v0uUEMmy/nQmre0dmBg9Jut4SFZVru4Gi2GE7xv1sSp9djmKItjSK+V1DEb6R6lkGTzv dLhvYpyA0aL+RCK06jK3s9cwyTbVlPG/gqC9cAUOd5To7H8D/zfoABMIiJXBLEamYYur rJJg== X-Gm-Message-State: AOJu0YwnqLgg3HT+RNdVmh8Ti5/ZNh8wndaqaqa3xZ5SkhBehMm4tu+T lqr7GXAf5La+BXH7TyU5cWt2cm2bf2pmkLDtSDuVrumT3A99AjgfGoktww== X-Google-Smtp-Source: AGHT+IEuhLQmamEjjJIAk/zpK5lAOaNcMqrAvcDor216nxm836XbA6BWouCvOiFboed9716dC/4IZQ== X-Received: by 2002:a05:600c:5110:b0:416:3deb:e3ef with SMTP id o16-20020a05600c511000b004163debe3efmr793407wms.1.1712878348773; Thu, 11 Apr 2024 16:32:28 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id a21-20020a05600c349500b0041680911b0fsm6981554wmq.30.2024.04.11.16.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:32:28 -0700 (PDT) Message-Id: <81556298599ffa77ba6bb1304d19afb2b4df079f.1712878339.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Thu, 11 Apr 2024 23:32:18 +0000 Subject: [PATCH v4 7/8] SubmittingPatches: add heading for format-patch and send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index ecc1622c8bf..fd40a444f95 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -433,6 +433,8 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. +==== `format-patch` and `send-email` + Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Thu Apr 11 23:32:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13626621 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABA04D9F4 for ; Thu, 11 Apr 2024 23:32:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878353; cv=none; b=kN/PTZB51OtyfHXBZ/038CW2uYtpgrhwvn33hMCa1jcXtRwT6CDx8IERv+4xww1j0CZ/TWHzb+3jIttppqCDsddIm2Mzi3oh/2oy0Np+xZsgcZ48KQPsjqei9p0m/oc5hk3x10jeYg0yCsdr5/gqwLPPfTOjbKR1QzyYX8JOkvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712878353; c=relaxed/simple; bh=97ZmeyhwahwA2ZW805pXSdSYH/7vhmkQn4p3rhC3agQ=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=BwcbWgTnTirbuU1ONQ+YgcOwO9Tnr10mgg16u4Ts/933bwc1+ubM1o52DWO/PHOvL8IQjW63w6OaxLrPfVd4fMN68E/+m3TKIA0g8u1EUtiuhlQ3MoG+qAxhWuoWJEJE/2U7GaTuFQuLzbsWN8HDXMTJ8SH4moVbea0WVzChzhc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gKA8Qvir; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gKA8Qvir" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-416c4767b07so2722925e9.0 for ; Thu, 11 Apr 2024 16:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712878350; x=1713483150; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KQHtztpLYBisKit05nkkC2rkf/Moh7swzkOTWhRGuc4=; b=gKA8QvirwLzRmz159RGBYhqNd13/66pQMijpn9e7z1EUGv0lc8oAHSVnqCBXStQL7M F4lSU2ng6d7rFGY6pWMBwb3EApylxFHisCn6jkNUV1LW0cTKCsOPP+cTYXrY0P0+s9+q S0gm1bx4ZIJiFt15AfbNqwRyC8MXPBESbKVKVzBhTFAWSN4xRrfgy9gcoHytRnTSWCj3 ySDvLzxxwKnAMISapujn6wfOPA2q2faFDOZkKieP62uCejoKFbWmJtcVEbUcVKLuWDba za5vLrc4qvU27YTglMor1moO2IZnwQvVjJ7NohFNgJ1PHgR36LxJ7zyeMXBv+omVJFyz rWzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712878350; x=1713483150; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KQHtztpLYBisKit05nkkC2rkf/Moh7swzkOTWhRGuc4=; b=EZ6vuyqVaR9hPjO2MZfvbb6Ip7Nbzr2WqkbnQ8nEH4c0aZ7kNGmZOvueabE0YW924O 3vktRXsBT82lalmt/P2kaxKuKKSzdkKwGsPiPO1IT85k3LFSknfB2Eef/dYD2jLU3i8A 3TkVOy+JfclnojdgmxF/SCyS9iv7qIdG+Rfc+W5V8/PTWlICMk04OqrYY1jyMu/MXidh 5+0VITTQ+5absCxDUpgsH7u3QLyEm1B9RFL/xJow/0coEuyHY6eDlpWEBvO0XQq8s+01 wWZMhtXy8ohvU8MMFHWEdZmzpTaPTQhsOZUnhqw5rnrd4zhyJMt8pzEV2oAUWrWmV0fP CJlw== X-Gm-Message-State: AOJu0YxZNWG1Ue2NCFBtSBWhhxignznul0fcJAwqMuNhpoCGO1kSNeTS LUn9ZCdvVE5/NPsL6U9DnncunUiYYpD1/GGRlpQYXIvEylHe1QfiQvy2VA== X-Google-Smtp-Source: AGHT+IE2CDUlgs4zWpmULr5Vx17XIdYvEBfW2tfYItMExq7c/z1yMg0ntzFz5yI9T6m7jlpxN1GBbQ== X-Received: by 2002:a05:600c:3b29:b0:417:fde2:abd5 with SMTP id m41-20020a05600c3b2900b00417fde2abd5mr73353wms.7.1712878349733; Thu, 11 Apr 2024 16:32:29 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id f19-20020a05600c4e9300b0041628f694dfsm3781929wmq.23.2024.04.11.16.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 16:32:29 -0700 (PDT) Message-Id: <84b1cf3f914067f8c2d056578e58d5b38bef7b45.1712878339.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Thu, 11 Apr 2024 23:32:19 +0000 Subject: [PATCH v4 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index fd40a444f95..eac086133bc 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -420,6 +420,13 @@ trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility that these people may know the area you are touching well. +If you are using `send-email`, you can feed it the output of `git contacts` like +this: + +.... + git send-email --cc-cmd='git contacts' feature/*.patch +.... + :current-maintainer: footnote:[The current maintainer: gitster@pobox.com] :git-ml: footnote:[The mailing list: git@vger.kernel.org]