From patchwork Fri Apr 12 14:22:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13627847 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12E28C4345F for ; Fri, 12 Apr 2024 14:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xVyKwThkDYGJHujchE3hFEbjTehuYLeUTYviRT4ejDQ=; b=dtiCKX4bilTYeu PhFocwKrgPl8Y5K80vvX0I3gDkrBLiPvUN69/crMBrv45bNcoQqEzlMDc0oghsV9x3sYaMHoHq1PU 1Vr+abMuGd6JYjkujtuZAkXTeGzEiy7ACOD++zsOFfSn2Fo8SwxfO0hx0AR4aRt+L/JOS5Wr9jfg3 GqyKEp88jsA8dxnNY79hCuGBsJSx58Wm8SLXLCHesWSDdVFC6fnW4I0VdS76Le26iEVLYhwyPO7DI s74EL+0pmyF9yf60MXWTP/6haD1zlGG1LWrEDlx7a+NiNNkqlJ+pEUKuJnbrkw+zLskvsAgwscV3y dU0ODqLMvrDRQvkklJPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHog-0000000HXlD-0syS; Fri, 12 Apr 2024 14:23:46 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHod-0000000HXjL-2VHA for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 14:23:44 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6e782e955adso946332b3a.3 for ; Fri, 12 Apr 2024 07:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712931821; x=1713536621; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YbcIWXIZQhqjePjNygTPT5SO2Zgomq/T2Ylg5jMiQ34=; b=UBICzAsCOcQALOZpu8gJVZ9E02DgQ7laJD7/5OwitwWnyWfEm57B1ZZ7MkHgdRuQb0 I0rTwRwXjPms+/qOFL4P1FYnE9Jc6mfy56oqiQ2YhKEr08dRK6VwuXcFWd4tO6dXWNP7 39LYG5X34+Kvp4vnq00o0p1ngAaGU0/2uwzOsS8/bDhhqUrE8nbRAM1KS1Cb23Ye9Boq cQ2jV83OSXciES2sLnRExPUnIvKmc+KD/jxaII09nvc/NUUo8xXvJd2edr9FIX+DrP9y tUIBAwQXRXsGr1zF7YJYMZLdEhYDhSfSj7LU65jjeXqwARf5zDLQklfGBpoOD0n3Nmie t5XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712931821; x=1713536621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YbcIWXIZQhqjePjNygTPT5SO2Zgomq/T2Ylg5jMiQ34=; b=gC+bwVPnQYoNjKs4+teoX7de2y2j4X3guQJ0h/V0eMCHaKEOhRFs7J64WT6sF0Xb/i tlTHeELgQa5nN9cgqmP0gxuMEQMfNhdtZIlEwFi+jwWCSTfqvGz5kEIjZql24KAEdAbE jQRQ3D0Qnk0JmgelDpHJHu82n+WkJlPVvgyNc+f04NopIP9+nqUv/9g6OCzQVmM8Oxl/ QLxIXn1hnnuyZZGPRF+RwQ27YwN9a2JAcznrSqJdRFwPaeJjAIIs1f+VzydNE6tzGtUU 8vBTQRQMcyb+/tbjjUCLllZxe+BPben1wLKdQ7n3QiI3vIJ8iS1LidvNZi4tPeeOKqWd VQBQ== X-Forwarded-Encrypted: i=1; AJvYcCXpah69pCohThVuJn0zBgMrBvj6MH6HU6q3X2i5jA3o6JaQf24c2T8T7kQ7eJtUzThDRQjlUJDhmJig+Gxfi3K7aXoq7RxKIw+TdAJVHIiaR8tAP9Q= X-Gm-Message-State: AOJu0YyTJA0XgNj9YjyOZOSCLblELG/+55nc275SrRjaig9tF+oRFBkn wyAztQDLe3ZwAQIRfleprkp8eDm1+j0szNaOiMfV7hELALsX22of X-Google-Smtp-Source: AGHT+IEIWwkiKFZ0hzuBzAJRk9Ofk9JFitFBkWwieWH2JxFuFxdmYqQ6OtOWlIDk1o1/OEoLCXoo5Q== X-Received: by 2002:a05:6a21:99b:b0:1a7:6894:cec3 with SMTP id li27-20020a056a21099b00b001a76894cec3mr2899249pzb.32.1712931820933; Fri, 12 Apr 2024 07:23:40 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id n43-20020a056a000d6b00b006e5af565b1dsm2946952pfv.201.2024.04.12.07.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:23:40 -0700 (PDT) From: Anand Moon To: Alan Stern , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , Thinh Nguyen , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/5] usb: ehci-exynos: Use devm_clk_get_enabled() helpers Date: Fri, 12 Apr 2024 19:52:50 +0530 Message-ID: <20240412142317.5191-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240412142317.5191-1-linux.amoon@gmail.com> References: <20240412142317.5191-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_072343_656725_D289313C X-CRM114-Status: GOOD ( 17.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). Signed-off-by: Anand Moon Reviewed-by: Alan Stern --- v3: drop dev_err_probe to simplify the error handle. v2: drop the clk_disable_unprepare in suspend/resume functions fix the usb_put_hcd return before the devm_clk_get_enabled --- drivers/usb/host/ehci-exynos.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index f644b131cc0b..e2303757bc0f 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -159,20 +159,16 @@ static int exynos_ehci_probe(struct platform_device *pdev) err = exynos_ehci_get_phy(&pdev->dev, exynos_ehci); if (err) - goto fail_clk; + goto fail_io; - exynos_ehci->clk = devm_clk_get(&pdev->dev, "usbhost"); + exynos_ehci->clk = devm_clk_get_enabled(&pdev->dev, "usbhost"); if (IS_ERR(exynos_ehci->clk)) { dev_err(&pdev->dev, "Failed to get usbhost clock\n"); err = PTR_ERR(exynos_ehci->clk); - goto fail_clk; + goto fail_io; } - err = clk_prepare_enable(exynos_ehci->clk); - if (err) - goto fail_clk; - hcd->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(hcd->regs)) { err = PTR_ERR(hcd->regs); @@ -223,8 +219,6 @@ static int exynos_ehci_probe(struct platform_device *pdev) exynos_ehci_phy_disable(&pdev->dev); pdev->dev.of_node = exynos_ehci->of_node; fail_io: - clk_disable_unprepare(exynos_ehci->clk); -fail_clk: usb_put_hcd(hcd); return err; } @@ -240,8 +234,6 @@ static void exynos_ehci_remove(struct platform_device *pdev) exynos_ehci_phy_disable(&pdev->dev); - clk_disable_unprepare(exynos_ehci->clk); - usb_put_hcd(hcd); } From patchwork Fri Apr 12 14:22:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13627848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85720C4345F for ; Fri, 12 Apr 2024 14:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0bm2eisxOS6Xv/1aPjVda/qCok1rXoypewTU5Wag91k=; b=2UpKtWSGiRrf8S M7KZK8kqkma0TsEOH4aeLN+cD308siASUb3EXkLvslsIF7+xBxntFWBG6gul5zIDDi2ZLPPOzqeFQ JQMEpKWDoGNVWFrWPZSWl+k7v05Yd0Qsh4l874GjwPQ9jVIkHwgkfNkgCqMSiy2UocCYkFu/9h8F1 VbcNeDhLXB9vstKR8yAW+0csAtqxopVnz3vu1L07RcLwpTT08Fbv1yzXQPXZ0xFEoqagUrVhWJggH Rms7QmszbheAPJ7ZmsMZXf8Uk++RSu4yBoHMYl+l4PeavHFk5sgkwOZyzRngYROLJu+CC6Uu5ixEw 73M2/g9rMKsuln+M+i2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHoo-0000000HXpJ-0tkI; Fri, 12 Apr 2024 14:23:54 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHol-0000000HXmH-13Kn for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 14:23:52 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6eaf1005fcaso681572b3a.3 for ; Fri, 12 Apr 2024 07:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712931829; x=1713536629; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U7xaoM/t7sWthomv9Zj/NBnEov5ePJmCQG8giDyuvlc=; b=U+VTFKzfBexlaStSIMCW7BHRFwMhpEMUjmIWVP8sG/b+GoLv7rN2fbe6W2tStqEe8s K8k0IJI9wbyoCp58jckBD5Keu2PWYeiAnWEsCi0y35xqa920KKgpyCCyMTx6OC6sLYbY 9+Gn49qxh+Sp5rVgXdbkqQ48f1rxibL/451EMxWF/fRzxw6GhYAHFA51eY/z4K83Gq44 riTAXE8BIdmdwROX7XpbYA/usJVU9qE81IWhTXgezrbxXX2fIjOsjFv3Zl+IDjZNHEsg DzN4E9D4aGlzBRW882I65xGBTNMsfV/KAV8+15CYJpvuPfdE/8qifHW1KTJ3zRIuBfnP vzWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712931829; x=1713536629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U7xaoM/t7sWthomv9Zj/NBnEov5ePJmCQG8giDyuvlc=; b=Ro+ybsWqEyoCjb885nOxEUhhQSaasc4vi9CEHsqWUQk5oxiLQK9aThHhTKz/UtJv8x 3CysRycZPVIKJoAh4YAU9yHT+QcHvw85JqsmK/SMEYSBt1+98nAE+tbB2D4tjsZozsKX 7qywrL1wleRrYphcTprVBsFHU5tRQXbBGcBHxQu5YZPvwpmosMnc4twlAIquzanfBYWA 9VPpM5npGuqa2k8FDowBc3piQMFhCFZuHFsqbw/SdfAwAwUKA8BQFdJRp3fnkoZNnzZh w4KTu1W+whQQ6q33MX7c+b0ry0CSWS9zvpzDFOABFqTju0lSS86veCsUvPhfPX4QNmMz +oLg== X-Forwarded-Encrypted: i=1; AJvYcCU8oixzMZVK/EtIEkFau1NmYTfzrVEFBfZQjFI6zAXY03TZZMydjvhfbE6TOFub/ewy/IpaLSOpXgSqtEU6z5jAn/QFYAA4FmvZ7e/Wxgat0fMo2Zc= X-Gm-Message-State: AOJu0Yx99WHjkCWRC+k11Em3UlKsfKAyz+Ksn3zk9T2jydN+HRdeVFMq F0P1FYgWQA9XaoUQ1SpGLo2tw8MjDOdu9DGieolI2IRfHgf5xSF7 X-Google-Smtp-Source: AGHT+IGgvnF6BriGZyRXskbwwm477hSiQyryuqYwynoyzyRo+4cTcjt9St+9+DXj+W6ilmPPRPfQ3w== X-Received: by 2002:a05:6a00:a87:b0:6ed:4a80:133c with SMTP id b7-20020a056a000a8700b006ed4a80133cmr3144178pfl.1.1712931828510; Fri, 12 Apr 2024 07:23:48 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id n43-20020a056a000d6b00b006e5af565b1dsm2946952pfv.201.2024.04.12.07.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:23:48 -0700 (PDT) From: Anand Moon To: Alan Stern , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , Thinh Nguyen , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/5] usb: ehci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Date: Fri, 12 Apr 2024 19:52:51 +0530 Message-ID: <20240412142317.5191-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240412142317.5191-1-linux.amoon@gmail.com> References: <20240412142317.5191-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_072351_313395_6CAD6CDA X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to care about when the functions are actually used. Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM isn't enabled. Signed-off-by: Anand Moon --- v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence change the $subject and the commit message v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM is disabled. dropped RUNTIME_PM_OPS --- drivers/usb/host/ehci-exynos.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index e2303757bc0f..f40bc2a7a124 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb/host/ehci-exynos.c @@ -237,7 +237,6 @@ static void exynos_ehci_remove(struct platform_device *pdev) usb_put_hcd(hcd); } -#ifdef CONFIG_PM static int exynos_ehci_suspend(struct device *dev) { struct usb_hcd *hcd = dev_get_drvdata(dev); @@ -280,15 +279,9 @@ static int exynos_ehci_resume(struct device *dev) ehci_resume(hcd, false); return 0; } -#else -#define exynos_ehci_suspend NULL -#define exynos_ehci_resume NULL -#endif -static const struct dev_pm_ops exynos_ehci_pm_ops = { - .suspend = exynos_ehci_suspend, - .resume = exynos_ehci_resume, -}; +static DEFINE_SIMPLE_DEV_PM_OPS(exynos_ehci_pm_ops, + exynos_ehci_suspend, exynos_ehci_resume); #ifdef CONFIG_OF static const struct of_device_id exynos_ehci_match[] = { @@ -304,7 +297,7 @@ static struct platform_driver exynos_ehci_driver = { .shutdown = usb_hcd_platform_shutdown, .driver = { .name = "exynos-ehci", - .pm = &exynos_ehci_pm_ops, + .pm = pm_ptr(&exynos_ehci_pm_ops), .of_match_table = of_match_ptr(exynos_ehci_match), } }; From patchwork Fri Apr 12 14:22:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13627849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44D53C4345F for ; Fri, 12 Apr 2024 14:24:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wj7qX2XaEiq5rtDI+XA2kCVTSG2Hr2Hnc6lE3dIFO9I=; b=h0ABh+qImPkb3y Y80KeI7s6o84xwKMbyHR25hQ1ICGJoa8/J177Ec5yxBTAAmSx/k/EVJUKLLE+4DNjAHn0AZD6cOgQ w8WU8xK3Vbcbzc4YA1LlH2sQLJDIy4q2QNl0yCuLbzg7i7QkPXsPJK/IX1NhXTHrw5KmdqUWuOcjj wHoxEQKY0kiUOwnJ66QYZcwzcbTANwfVn9OQzXrWxnJ7wpEq6J5Aaj2sOkjtQd/ogvBh0JbCT7wFX Ji/BWdaVMxD84UWrrz1Gb5zA7LUSH0cq4Ol8t4vuu1nmGHNwGwflETE7f9InOTZHjgehnSn0m9QRA trAjreytC1o+gg1wpntw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHow-0000000HXuW-3LCu; Fri, 12 Apr 2024 14:24:02 +0000 Received: from mail-oa1-x35.google.com ([2001:4860:4864:20::35]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHot-0000000HXr1-0Xf0 for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 14:24:01 +0000 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-22ed72b0082so604036fac.3 for ; Fri, 12 Apr 2024 07:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712931836; x=1713536636; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rnop7Tz3u3A6Y7l9rLZDgV358HdsfnR1FGKtIeVuKBc=; b=OT566YI17lZEz8wA2NveK1wkIYNTshp4yY7isrNVEMI1GjlZVif7uTuSuxSf7zDoYL shUtb0siTWwACUJejv5QmN2F1VcDkU32IYnvFWcVexeDutwqoMYs58i77h0O7GwSNJtM wlT3ZHq6n7Z3MwqfiC5c/KGAQIUa0sfhFtIf9UWgjHkR8COE6yNRLXdSN94KRbkK9h1s Ep/kcems6F088vg9eHBnZkhZgA5qvRaAwNZqf+pn28+MJw8Ckdx17riHWwD+19Lk0bNM Kwfa52zSUetUJl8I4nZBKIjb3bJSanYDwpMcjh6bo1RzBeivGBmF9HT7m7g/j5HRsyVP IF0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712931836; x=1713536636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rnop7Tz3u3A6Y7l9rLZDgV358HdsfnR1FGKtIeVuKBc=; b=mjIUjw+UEbFbSfQNlSC7a9lb9ox9xAN1WfgeJ6ffYp5xP0AXys9/zCmVEtroja261f 9Ebx6uScdcncIv6sguZH4f55VnwIU27jAjDug8cdzeN2NIgwpW/dl+u/BhA1Un4eo/xp 8RlOGNy2MLtYxQg9oWyf+Uu0X3lY8fmU44sz31ls2ARrvvw9XH5NeytC/3qjpuBJumJg m9UMcYozjaDQBICpIa6jd6mymAXfRqI2INcPkivVdv0a6I9CleA24Pn66qL/ktaQeYni j+WXxUTEehRp8wNyraXUDJU1HU0hpcFkGnFX//A+4K5WjQIfhZEnIdLns32g0v1Rdj82 Q+bQ== X-Forwarded-Encrypted: i=1; AJvYcCVppHcNTiRN2iThNCxMiG6nTlExcXdP3g5dGYbFIex1b1a5Ib1k7IJatGg0RnLgep4Zt7UyQhaKpLKMclJ6PhQQFYj50025NMD+I68iUCWcRs4sJBs= X-Gm-Message-State: AOJu0YzDpBRcgAfEfPCyDffPoVXy4jN4rusAst/bOksPKxdKrmzWHZKS z+W90ff4xfBqXjWmGr3sFaLwbGaejnXgFQrlNKABQkoiJxZ+T+2eibKFLg== X-Google-Smtp-Source: AGHT+IESH4fkXQOzELFKbwow3I/3zmYaBjB31FBeox2i7Lpcl/4hma+H6YA6EljsfIfiVAabwskJIQ== X-Received: by 2002:a05:6870:4194:b0:22a:f96:28b3 with SMTP id y20-20020a056870419400b0022a0f9628b3mr3085006oac.53.1712931836388; Fri, 12 Apr 2024 07:23:56 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id n43-20020a056a000d6b00b006e5af565b1dsm2946952pfv.201.2024.04.12.07.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:23:56 -0700 (PDT) From: Anand Moon To: Alan Stern , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , Thinh Nguyen , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/5] usb: ohci-exynos: Use devm_clk_get_enabled() helpers Date: Fri, 12 Apr 2024 19:52:52 +0530 Message-ID: <20240412142317.5191-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240412142317.5191-1-linux.amoon@gmail.com> References: <20240412142317.5191-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_072359_273643_EF0AA331 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). Signed-off-by: Anand Moon --- v3: drop dev_err_probe to simplify the error handle. v2: new patch in this series --- drivers/usb/host/ohci-exynos.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 20e26a474591..89e6587c089b 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -135,20 +135,16 @@ static int exynos_ohci_probe(struct platform_device *pdev) err = exynos_ohci_get_phy(&pdev->dev, exynos_ohci); if (err) - goto fail_clk; + goto fail_io; - exynos_ohci->clk = devm_clk_get(&pdev->dev, "usbhost"); + exynos_ohci->clk = devm_clk_get_enabled(&pdev->dev, "usbhost"); if (IS_ERR(exynos_ohci->clk)) { dev_err(&pdev->dev, "Failed to get usbhost clock\n"); err = PTR_ERR(exynos_ohci->clk); - goto fail_clk; + goto fail_io; } - err = clk_prepare_enable(exynos_ohci->clk); - if (err) - goto fail_clk; - hcd->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(hcd->regs)) { err = PTR_ERR(hcd->regs); @@ -191,8 +187,6 @@ static int exynos_ohci_probe(struct platform_device *pdev) exynos_ohci_phy_disable(&pdev->dev); pdev->dev.of_node = exynos_ohci->of_node; fail_io: - clk_disable_unprepare(exynos_ohci->clk); -fail_clk: usb_put_hcd(hcd); return err; } @@ -208,8 +202,6 @@ static void exynos_ohci_remove(struct platform_device *pdev) exynos_ohci_phy_disable(&pdev->dev); - clk_disable_unprepare(exynos_ohci->clk); - usb_put_hcd(hcd); } From patchwork Fri Apr 12 14:22:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13627850 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 572A1C4345F for ; Fri, 12 Apr 2024 14:24:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ugGj8FCFlynuZQ9zQ8x+Zr+hhjAlODwPD/e0ug3Nwl4=; b=0P2BhJL1xXHDWR d8ByFzURBFUDQFfaOBvRk5TVBM2OIAUD3aS7dRkNtGhNYPZRmBKMkZBRE8P2HjFKc1OxPaw88ozuv KOpv7LBn+ldCT+/nwkl/e6R2WyPAsjSY3AEzhI8cvh/hAvhOFWDhZrSkMZU6lvvveMJdQMLcRoRLb A5ps/qtg6Pc/4Zu+LYwFPL1E8caCyKfRDDAX/3WtkwAxpkc+pEaN2kVj488mVyVcurpZIz1s5XHJB EILKUuV2nqC92exq0B2aqTRL2kluUKwWNAHLlNtmO4JF0i1zc7tvvNn3ndM8vWsgzuraQij29ia0d AG0vuBCkPH74O37Cdp2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHp3-0000000HXyt-2GJr; Fri, 12 Apr 2024 14:24:10 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHp0-0000000HXvg-0KtR for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 14:24:07 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6ecf406551aso781544b3a.2 for ; Fri, 12 Apr 2024 07:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712931844; x=1713536644; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DAWpmgXV6PrUtIYpHal4V+0TG6cIPqQRmUscp00ed0M=; b=mi+VW3eIixnggm1P7X/+qvaZoPGq7Om+RKwzw+LIjisdgYgj+r4P0YsW9QoGkO7nb8 b3wF+dZnxQJvjAC7khPu4of+oYlGISx1Gvy9tLyS/WLXE3fG/Y0nwXinH0vdZgtB1rTX U+RQgIkMEN6dgJhVoux0QFZSCuNwdxtME+3kxZTtoTEwnDvPOPdL+G9iND5DaZ8rgbcP f9G9B/OswckTS2YLzYSuelr7evIqHPf1cpQmJU21iDWmzCUsOigKYpuyZfUh+dO5K+bU 2rpV2rqqbeHARA39hFMktaPWk1ZQ092ganb9aM492tWUZJ+MWr7LmhNcMkDt4zza72C5 eQNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712931844; x=1713536644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DAWpmgXV6PrUtIYpHal4V+0TG6cIPqQRmUscp00ed0M=; b=Ua2I5mCgg6cd0Wi7NmzDj4YT/ovld2Q/9rmq2Dhwzd1Dc/xoyl9iPQBHurZClalce/ Jynmzy+VOz8a4QYGXCPatzxjqac1eRCoocN4RXrjk0muBaE8a4Np5+BCbSUlF8+KDWSd 3aia0S98rkO2+YpJrf2/l++5r0SjX2DDittwbcFj++2J/ZvZi6yYt8mr9xjtjyVfsB9t zA3Y+ha/+Grti0K0XxcRosRWP0opUmkdchvpgoPGN/4PvztemtsRPrURgyWVTOIyNm+t HC4jgkVJHd9YGohWhIyqDo1rLoRbc1b63JJzBZtep15pkIVLSdGg2YeU1pjFZdlLOQZC o00g== X-Forwarded-Encrypted: i=1; AJvYcCUDJcjhUfOYsEQSxKYGynfl0wo6LVThfzgy+4o3bvOFC1Tm4Hab04F7LQ9WDxm2Q4n/+rKPpOh0vve7cXJsEFlJc/QHXMoP5XFfo2c1gCObL2DQp7M= X-Gm-Message-State: AOJu0YyuJ+Sc4eEw6Tf2hj8SwT58H71vMtMxcpvpEwq0q21d/EJfgdYz KRidaWM+SgyOwX/GmBwrAdkyl/evvtMVaQx/CBaSBljQUTD6iCbV X-Google-Smtp-Source: AGHT+IEpGPBZdmTxxL9lDAtC+tf3WS6lK3QOjNLU9P/kh8HtQfqldD/Ks3PSn5Y+HC7kfzAkGlppsQ== X-Received: by 2002:a05:6a20:5659:b0:1a7:34c5:d141 with SMTP id is25-20020a056a20565900b001a734c5d141mr2909862pzc.24.1712931843931; Fri, 12 Apr 2024 07:24:03 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id n43-20020a056a000d6b00b006e5af565b1dsm2946952pfv.201.2024.04.12.07.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:24:03 -0700 (PDT) From: Anand Moon To: Alan Stern , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , Thinh Nguyen , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/5] usb: ohci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Date: Fri, 12 Apr 2024 19:52:53 +0530 Message-ID: <20240412142317.5191-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240412142317.5191-1-linux.amoon@gmail.com> References: <20240412142317.5191-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_072406_198533_7410CC38 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to care about when the functions are actually used. Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM isn't enabled. Signed-off-by: Anand Moon --- v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence change the $subject and the commit message v2: new file --- drivers/usb/host/ohci-exynos.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 89e6587c089b..3c4d68fd5c33 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -213,7 +213,6 @@ static void exynos_ohci_shutdown(struct platform_device *pdev) hcd->driver->shutdown(hcd); } -#ifdef CONFIG_PM static int exynos_ohci_suspend(struct device *dev) { struct usb_hcd *hcd = dev_get_drvdata(dev); @@ -250,19 +249,13 @@ static int exynos_ohci_resume(struct device *dev) return 0; } -#else -#define exynos_ohci_suspend NULL -#define exynos_ohci_resume NULL -#endif static const struct ohci_driver_overrides exynos_overrides __initconst = { .extra_priv_size = sizeof(struct exynos_ohci_hcd), }; -static const struct dev_pm_ops exynos_ohci_pm_ops = { - .suspend = exynos_ohci_suspend, - .resume = exynos_ohci_resume, -}; +static DEFINE_SIMPLE_DEV_PM_OPS(exynos_ohci_pm_ops, + exynos_ohci_suspend, exynos_ohci_resume); #ifdef CONFIG_OF static const struct of_device_id exynos_ohci_match[] = { @@ -278,7 +271,7 @@ static struct platform_driver exynos_ohci_driver = { .shutdown = exynos_ohci_shutdown, .driver = { .name = "exynos-ohci", - .pm = &exynos_ohci_pm_ops, + .pm = pm_ptr(&exynos_ohci_pm_ops), .of_match_table = of_match_ptr(exynos_ohci_match), } }; From patchwork Fri Apr 12 14:22:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13627851 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A77C7C4345F for ; Fri, 12 Apr 2024 14:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ncvs84HRqwm26LlQ9rXXQuZnWBFk/4ljBsElhsQX9Jg=; b=LgfqgvmfT5cVD7 rk3sfsnq0pZVHFhrI61VLX7eNJ4oNLM1TR3NIUWm2aSEaYyGCqd+wGcmm6hnDwb6ArmMAKuaudZdi tMVPMaJlEjfXLvYq5kZzExVaTMeR6cr1uN8aRiD6Z5PUPgf6qYq0Qid+mPGVMDia6doP7O6o3e+gG wp/ZCtj4CRtKoNLU+Ok1zPzMHT5Hq3PyYtG6AAHzX5owwVOdEEqpTYX2XeVappS5Fn9q/+f/3ToHq fcpSMiAfpo4Zk/MLm5PJPVeBfb5w9JGYNPTwtmuswuVAjySGlbvWs3dpD/IF2K/KzVyoUBLsyiAG8 IiQ6GAJ6ZH3W++R1xrtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHpF-0000000HY6C-1dbe; Fri, 12 Apr 2024 14:24:21 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvHp7-0000000HY1L-1FuH for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2024 14:24:16 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6ed0e9ccca1so934275b3a.0 for ; Fri, 12 Apr 2024 07:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712931852; x=1713536652; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8ycTUqQHx5D5MreNoECYZAdXjkRI9aE0qu1OLjEN7fk=; b=bvaCWTJULNJUTdUAxJiZPbiPaJ4dCe84gwPtSHzF9wczvYW8eilqshrBg6o7Sku1La B3zJ5PQmYg4EX2OdUznnuT5mdR1XHnMl/LwgG+QsTqRuKMGC8/csR/BvqfiXfdb6vENl dgoR7k/tQHGgoSH4Em8eiS8u+Kzbh/1QQuv/4qeeFKJXBoHIgEDRthSUcQ5Y77+BcFe1 WzuShvhune3qK9w499aFBKfMnCs8SoC6Rg/mefU6T/TgWwWyl7m9s8k3A/107x0sCyQQ G5gkr26yXxmlHQdBdDLeC9M2RWzqOB3AQricpoXhJWftmfnhUJAGjBXj3G6FLV96P/tm /apg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712931852; x=1713536652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8ycTUqQHx5D5MreNoECYZAdXjkRI9aE0qu1OLjEN7fk=; b=jaCfcvF1zxYnEnUahmGSlxloBeTT85VGVizEjf7RjFD0g0zmndpiU6Z1OKZU8SO+HE xjACcWtbJ++q9ZaUZqTVfuCeH9PMhrC6A3jROu0ZXgqFYnMhWYx8oS9yXZAETIUvTuOl EzRgVYZYNd0VEJMuCLLwh47EGWH+ixINQN3k112r0ZWJelKJ94T0HcH8Z15cHkyCsXJT 1gRV0A1XVMtijXkqxOms25x+/ihM2btkBBdvLMICPKv22M+mgJi3KhF5BW82YG7yzaqt uuLi+m1kZ+xpfeOjSpq1xcdNiEK+zx4UDuAocAoxZQ5jwubuwu4J6HX/sSw6GRCXUShC 5spw== X-Forwarded-Encrypted: i=1; AJvYcCUl11RL9p8Z1+mjHfn4GDm1zatYDbeAqhZkyZGQ3503MFlacJJIBlsAFzAP15/AA3mO6vcPyQPI9P0Xu1xQXPDYAAaXgrZCG4WzXhtaTUwLtb2T14Y= X-Gm-Message-State: AOJu0YxN71bj53aYg/+6uKyqg4NnyUd4kUB+cnVp7/YBFtPS2NlpgjB2 ABx69elOvlp8lvjW0wNxLPHuHHwOQpKmu7arKgmGyTWOqrbwCcUP X-Google-Smtp-Source: AGHT+IEVIzMZY6CCMhIHZf+aL4aqZNSAeFET5jkH5mSvmrZ4I4gbLuytamFXU/gqKehAc/d6O6nkoA== X-Received: by 2002:a05:6a00:acf:b0:6ea:ad01:358e with SMTP id c15-20020a056a000acf00b006eaad01358emr3589380pfl.0.1712931852323; Fri, 12 Apr 2024 07:24:12 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id n43-20020a056a000d6b00b006e5af565b1dsm2946952pfv.201.2024.04.12.07.24.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:24:11 -0700 (PDT) From: Anand Moon To: Thinh Nguyen , Greg Kroah-Hartman , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , Christophe JAILLET , Johan Hovold , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/5] usb: dwc3: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Date: Fri, 12 Apr 2024 19:52:54 +0530 Message-ID: <20240412142317.5191-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240412142317.5191-1-linux.amoon@gmail.com> References: <20240412142317.5191-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240412_072413_789091_FF87B00B X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to care about when the functions are actually used. Also make use of pm_sleep_ptr() to discard all PM_SLEEP related stuff if CONFIG_PM_SLEEP isn't enabled. Signed-off-by: Anand Moon Acked-by: Thinh Nguyen --- v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence change the $subject and the commit message v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM is disabled. --- drivers/usb/dwc3/dwc3-exynos.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c index 5d365ca51771..3427522a7c6a 100644 --- a/drivers/usb/dwc3/dwc3-exynos.c +++ b/drivers/usb/dwc3/dwc3-exynos.c @@ -187,7 +187,6 @@ static const struct of_device_id exynos_dwc3_match[] = { }; MODULE_DEVICE_TABLE(of, exynos_dwc3_match); -#ifdef CONFIG_PM_SLEEP static int dwc3_exynos_suspend(struct device *dev) { struct dwc3_exynos *exynos = dev_get_drvdata(dev); @@ -230,14 +229,8 @@ static int dwc3_exynos_resume(struct device *dev) return 0; } -static const struct dev_pm_ops dwc3_exynos_dev_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(dwc3_exynos_suspend, dwc3_exynos_resume) -}; - -#define DEV_PM_OPS (&dwc3_exynos_dev_pm_ops) -#else -#define DEV_PM_OPS NULL -#endif /* CONFIG_PM_SLEEP */ +static DEFINE_SIMPLE_DEV_PM_OPS(dwc3_exynos_dev_pm_ops, + dwc3_exynos_suspend, dwc3_exynos_resume); static struct platform_driver dwc3_exynos_driver = { .probe = dwc3_exynos_probe, @@ -245,7 +238,7 @@ static struct platform_driver dwc3_exynos_driver = { .driver = { .name = "exynos-dwc3", .of_match_table = exynos_dwc3_match, - .pm = DEV_PM_OPS, + .pm = pm_sleep_ptr(&dwc3_exynos_dev_pm_ops), }, };