From patchwork Tue Apr 16 23:01:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13632716 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEB5A84E0B for ; Tue, 16 Apr 2024 23:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308524; cv=none; b=pgG9gAWFsq58DmAMj11EC61VgjaPKABj09+DlcFJVJZ/06CZXN0KdVLf60QQSDcNVaSCMNMeyqnGe1CwY0RlZWU4AVOhjGNsZMQSZe2aJ4F8i1wofxDJcooAnbWzzPBHBy8OaHUZEE3wUwlcdmnR2dTp4kiGPaqnU4SoiUZUZzM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308524; c=relaxed/simple; bh=qM7qk1SrHG4k7tqRZoG4ohaYTrUzYevJI8EiM0kbQ4s=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=Yqtb5DXcr+zQYN9u/eXieNiSi85zEluQFbzqtr6D1FKcN1zMdCsuZPcUpyNQUVvlCFq2U2SkQH6xpu8iFMd8Bexd8JXojAkKACopx/DAHarkTyetVYRvT4xgDeTlc5TTX4AEAmt+F90WiGRz/tc7/3T7aAfqj8X8d3NIGHgdGDQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eMv+mHRq; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eMv+mHRq" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-343b7c015a8so3980691f8f.1 for ; Tue, 16 Apr 2024 16:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713308521; x=1713913321; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=6iXzajJXvNCHbN9kIrXvJadshJjhNqLOyZvoeEKSOmk=; b=eMv+mHRq6DUodyOrp6Dz3hItDurifjWr7hVJ4AQZS3lOfMGaCj6agv0yBmNOgkcwz4 JJMIkpUbEkTiRcN2Ngr6fyFn43WeKPb6Fbb66npSZl65B62KGc2PYap8wuR9REO9P7mh 6ycTnCqiWUomd6oyqQVHAghPJYFUpcydFq28KCwn2kW1/R3JINY5zkzdL+XiDUrIP4f1 dCI6gLoUOpECMglANoYnOyHO0sVIAq0XLEiC/o/lGwvSz2IIyJ08hk9uqcjlt53U1cUM 9s4cUyJ6q5B/eZYdXZ/UXgW9nSo33A9ggfLOjU6M3yGosvQoesHN3FdnOk9yo5oNjVxe awKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713308521; x=1713913321; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6iXzajJXvNCHbN9kIrXvJadshJjhNqLOyZvoeEKSOmk=; b=VauQJeIybtX17pXQj+jkcz/SAICyEXsNZg3jCy62qPh0YFsST2kaQskDKkNF6Xbppp 3nKiH59KiVMliwxecTs+79vB6DuhadatvXatDq843mtX3C8yBPNi8mMpXF7Ewq3UP6NZ cm40PU8VsxaorKpq795HSaE3mNUbbr65OIMz7kIMozpjUm3n5QSKCQOMuVEGXiAJoKa/ 4naqdyy7liyBsAmEYok6C075h7xtpF/UIZDaa268GnE6wjj6BpbPyviZOF+lEHx15lFm jvaT7qbVQVXc3gMjFiuJG0i9ck8vS0gl7H7Ds8sh/CSWq6nSManX8tqHbZ7e70wstrwq BnuQ== X-Gm-Message-State: AOJu0YzibcAKc5vyVeELUaXz7c4rkgJSh4M4rY/GHuCorfi98P0LHPtY BNvqKkZd3bCTlF9FqS8rpiJuRkHrpXgi0M4Y1aw3sYjckHWOinsGM7taVA== X-Google-Smtp-Source: AGHT+IFRq4TChBv3V/gQxtKjUJi2PXk5XbrzB4pNN+aynPf1CG2ADyIC0X9MKK+tvf5YFVfnT4RIkA== X-Received: by 2002:a5d:4104:0:b0:346:9903:d10f with SMTP id l4-20020a5d4104000000b003469903d10fmr9618363wrp.12.1713308520551; Tue, 16 Apr 2024 16:02:00 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id a16-20020adfed10000000b00349ac818326sm646851wro.43.2024.04.16.16.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:02:00 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Tue, 16 Apr 2024 23:01:50 +0000 Subject: [PATCH v5 1/8] MyFirstContribution: mention contrib/contacts/git-contacts Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Although we've had this script since 4d06402b1b (contrib: add git-contacts helper, 2013-07-21), we don't mention it in our introductory docs. Do so now. Helped-by: Junio C Hamano Signed-off-by: Linus Arver --- Documentation/MyFirstContribution.txt | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt index f06563e9817..9665951aeb5 100644 --- a/Documentation/MyFirstContribution.txt +++ b/Documentation/MyFirstContribution.txt @@ -1116,6 +1116,16 @@ $ git send-email --to=target@example.com psuh/*.patch NOTE: Check `git help send-email` for some other options which you may find valuable, such as changing the Reply-to address or adding more CC and BCC lines. +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + +not part of the core `git` binary and must be called directly. Clone the Git + +codebase and run `contrib/contacts/git-contacts` (you must have Perl installed + +in your system).] + +NOTE: If you're not sure whom to CC, running `contrib/contacts/git-contacts` can +list potential reviewers. In addition, you can do `git send-email +--cc-cmd='contrib/contacts/git-contacts' feature/*.patch`{contrib-scripts} to +automatically pass this list of emails to `send-email`. + NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but please don't send your patchset from the tutorial to the real mailing list! For now, you can send it to yourself, to make sure you understand how it will look. From patchwork Tue Apr 16 23:01:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13632718 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58B7B139D04 for ; Tue, 16 Apr 2024 23:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308525; cv=none; b=lxH+gm+lqFP0pHabDWZZWnhwqo2+y3zufmxYPQFaagY4sh9hzm6apBaWXqiHBipwnFMcsUam3VU9NkOhASr2Tyhv2LtMJtQR/XfoMSCeioaL5WSME8UdGCzNMkjoAtQyVES7GbY9KjMAwXXtd+H+8up8OXcVCgEX59Ox41T4LDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308525; c=relaxed/simple; bh=/i06gN9JLo58SuBMM0MO5GoNa1bohi+U/TSGRMHyU4c=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=OU1WewNIDlJPTw6FGTOHD9R+icg3xC3iIMQ52JlOnzCHomqT70TJCEcgGiU8O6O5riYGWSbUzZHnp8S0O6h73Ip0QsmlU4uyQTBb2Pf6oz+NRBdU1J1qP/PUt4ji93F9RBn1uVYNISb1fgK6vgcUQmNiwEWiKNwThrhEkjjCW1w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lx+nqW1R; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lx+nqW1R" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41885eeb104so9624765e9.0 for ; Tue, 16 Apr 2024 16:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713308522; x=1713913322; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=pdXn5fyYAH0E/Lcv+UDT/JGyNE1XzO7g9pDM4UO1A3o=; b=Lx+nqW1RcOJkPT9bYuJWIajlab/5qQbaNtK5ABNQK5fsewNLjTczbGd3gPuKxUJ8W6 JI+rfz+LL3GYX/qbFqwfzy2uwqtH3UAZszPy9r0sADwvCr4WTDLRnG7dY+sB34DfbXGH 5bUk/52+XEcYvKCxBTfE2WGpCpF1ZljbrKCIO5bjkzAU3hF+lejqXvQM4nKTUWauaXyl NKE52HbtpyUQiLSoLX8r2GwcsojB53PATpvVtylwr/468YybNkoOaoqed+/6SsDIIBG3 EpGK4Zjj6tRNtVLYoauHSBZ9+iQdlXgHTPpQ8JhzPrd3rJb2HnSJeYKCl2RsF1WJ5atK 1e1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713308522; x=1713913322; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pdXn5fyYAH0E/Lcv+UDT/JGyNE1XzO7g9pDM4UO1A3o=; b=pMqgsdP1d+Fu+M+J2iJccOHsKys+eS9lL8bfhu/31d0wlaKICOMvVyhd6mhMhd8Ldc QN8ejzVhGP79KrEwg7DaBobhJ/2urrkQQLbbHR6DleJwfQAeU8JqOfJCm9VSNj2oZTys aT9W3BoRmjn+cXDZF2O+dwhqQOkwD9cNBNDE4EzNa2SsLvg100imYe6Grv3/8+N32iTm RvrfcZV4iePLLebhhVlAqrLagMXVSV/LTRfq5LMPAPKus2UIiaZ//7vM4MWwKFXe+UZW jhZ2otLNkYSuDNCl8347iyU3Zz1YUh+UbWXDbmJMk1wNJ6uPMvteoPnC0PsZa2MAZeU3 5rTg== X-Gm-Message-State: AOJu0Yx8wZ5CbUvb7HBm+quUn7vy53WUFuvZufURgP0pAurfZv+L6c1I alJh/TOx5PggXkhKihsPzEHixFuwPydKuCR7Q6hS5QWwm/5CaRlO6B2DPw== X-Google-Smtp-Source: AGHT+IFQ7c6HF4k7ei8rSnzAU/BS5TA1ida44aUXMy+7wuHLSuAqV99/WAobKFBR8AXfBFFHllFMbw== X-Received: by 2002:a05:600c:46cc:b0:417:f5ab:cae with SMTP id q12-20020a05600c46cc00b00417f5ab0caemr10106903wmo.10.1713308521861; Tue, 16 Apr 2024 16:02:01 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id 7-20020a05600c248700b0041668770f37sm392318wms.17.2024.04.16.16.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:02:00 -0700 (PDT) Message-Id: <92d72a8a25a74c63fbd9736bbfe3c6b3618164cc.1713308518.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 16 Apr 2024 23:01:51 +0000 Subject: [PATCH v5 2/8] SubmittingPatches: clarify 'git-contacts' location Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Use a dash ("git-contacts", not "git contacts") because the script is not installed as part of "git" toolset. This also puts the script on one line, which should make it easier to grep for with a loose search query, such as $ git grep git.contacts Documentation Also add a footnote to describe where the script is located, to help readers who may not be familiar with such "contrib" scripts (and how they are not accessible with the usual "git " syntax). Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index e734a3f0f17..0d4276c6c7e 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -493,9 +493,14 @@ security relevant should not be submitted to the public mailing list mentioned below, but should instead be sent privately to the Git Security mailing list{security-ml-ref}. +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + +not part of the core `git` binary and must be called directly. Clone the Git + +codebase and run `contrib/contacts/git-contacts` (you must have Perl installed + +in your system).] + Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git -contacts` command in `contrib/contacts/` can help to +people who are involved in the area you are touching (the `git-contacts` +script in `contrib/contacts/`{contrib-scripts} can help to identify them), to solicit comments and reviews. Also, when you made trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility From patchwork Tue Apr 16 23:01:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13632719 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E29E13A410 for ; Tue, 16 Apr 2024 23:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308526; cv=none; b=PLjlc9EMqhvG+WJL/Nsngfx8qZksHOZ5p6vNA230J4mgne/PU/HFJvr13klGtreuAdyfPYaDnEt48aRy6jKa/KsE8toBuCgXPo43h+Hwf4XMZGgByiR6a205IH6kyMfT+Jf8CWh6anvMBqruSc3ItYbi6FzSQN94W9cS2pVL76U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308526; c=relaxed/simple; bh=GKvQn0S/xGBDGm5jgiU0AKvesBhwyIahDxAyonj+jj0=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=rc7jEloaznWPihqyItzPW+zSvMdzJ0YkxCHRGhvCM1aGdudhUuMX/iYn1jyes6AD7l0+jZaARydChV+Une5JyG9OJjbKtfj9Vs4/4/g6j2Qt2CWnai9/QvyfD18Rkf/sIiZRSamb72mevAFnBW1cDGRgK4+U26oytBa6lBHPUhM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UzGGk3nB; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UzGGk3nB" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4187c47405aso12164745e9.3 for ; Tue, 16 Apr 2024 16:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713308523; x=1713913323; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=WuQ4UGHaaupgIuS5pZX0/sf8mod6lYYHBQMg4k8s9V8=; b=UzGGk3nBWvq16DSfmUJAZ3W04KZMehjH+M8LUBjsEMuV+ypvUYNd3ye8ac3XVEKxCt wIFea9GrQ/LJpNwumLo9bAkJeboFIJhJAFwT01TUGPB0x8sqwgx408RCnOQKbMi73/+B wsqhS3GH/PN07EayjCJIgSe3DG2E70puK8fG1YA53lmKOoOhkbVL1o3i04YH9xkHoQOx qaBf6X/3dkePXBr7js//elytvQjmcS/kcaK6KytGKmlM2tef2DbGkzn6d8W0eWUip2gX cENeRu9ZV8DrgmoM9qE6pEU23EYfW7k9Z1ystrnKj3hGZipkoTrf/VP4sBpyizkhi2/u BnyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713308523; x=1713913323; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WuQ4UGHaaupgIuS5pZX0/sf8mod6lYYHBQMg4k8s9V8=; b=C/X1wEKwcmLReMFU7+Vta+9RP2klVzqbUwHJ0CkjigGFDJJJfecHXMzZnRGI5II8+D gLbbT8uT9sj0ejnGuyHk4FBQbyHv+I6Eg4GsnASmugz0/OT2vOehzOyvs7btOAiMQhfy +7qZBwxBfpAgtDElzrb8BpQJzAgLvtGO5WOww/B3KNDG0iKvL0XCZbHpD/EsXol3JQlt 7d0G5jzdMNkjIcw8obhxPvFlSIb9m8cCys0M++pl8HkHlyMNnsi6KpDGd4Ix8mMFDgJx dhUSjpFS4tM/4x6FLyoUkfEFI7W0xgqm8KLXrfjeGlMgHR4tj4qtMCBp/fLQCbYq1BXS msyA== X-Gm-Message-State: AOJu0YxCMrjQMVk1KgFIaC3z/0ivUQTBPqMUP7WVNX5xxD/QUpWS26pz 0FNLD7KGOD3EC8hadNWE9gYn2/U/l++A+Uwcugq1i3GOIW9bKNXMXt9NLA== X-Google-Smtp-Source: AGHT+IGzb0rbcJPFSL4rz3kWPqOYB8P+QVYOyDso0HyW4jllKMAe16odL16+VxB0ZQyhijKTypWY/g== X-Received: by 2002:a05:600c:470f:b0:418:41a7:d032 with SMTP id v15-20020a05600c470f00b0041841a7d032mr5605917wmo.13.1713308523242; Tue, 16 Apr 2024 16:02:03 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id d15-20020a05600c34cf00b0041897c6171dsm400203wmq.16.2024.04.16.16.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:02:02 -0700 (PDT) Message-Id: <7c4cc5a91f0ab09ff46179aaa24562fb0a0e9706.1713308518.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 16 Apr 2024 23:01:52 +0000 Subject: [PATCH v5 3/8] SubmittingPatches: mention GitGitGadget Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 0d4276c6c7e..a27f7c923b9 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -408,6 +408,10 @@ are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. +NOTE: Here we outline the procedure using `format-patch` and +`send-email`, but you can instead use GitGitGadget to send in your +patches (see link:MyFirstContribution.html[MyFirstContribution]). + People on the Git mailing list need to be able to read and comment on the changes you are submitting. It is important for a developer to be able to "quote" your changes, using standard From patchwork Tue Apr 16 23:01:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13632720 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBA2413A88A for ; Tue, 16 Apr 2024 23:02:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308528; cv=none; b=Z9TTYGxQF9A1IVRb2ch8BdDoLcekHWvnUQ7UB9qnMtdN56uVx3pVIBB5XpnbBkrToOXWov0qrmCCGUWEIar0rTB/CfSo4CjXF3ryNu/5kpvE1I8O0icFZpyDTXFUzSpb/MBgv+9dfMZ9+EB7B4v8+T27hP0FR1mKEYHEKCp2pXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308528; c=relaxed/simple; bh=x/o/CT4qkjLOrPHpzVsNZcsUyj8o2MV2Gg7+zjPbGTs=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=S+VucZ0n1l4OfT0B0NZ3VLN5sx7I5D6OKwsW1VhDnc0UvvYDYLkMHfCKHCdw/M1knv8qlj/24I0EEAw3ybFxpA4CwltiIEmdzEIX1RLdQIpK/fkesr5tIE1gmp+gXgEmWLKtoTZBuhZz2R58iL1iTQ58bz6VC6jDhTdhDr3GQjI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L3dYLUWf; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L3dYLUWf" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4187c47405aso12164855e9.3 for ; Tue, 16 Apr 2024 16:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713308524; x=1713913324; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=CcIcGPosIc+mxAdwBaHIMp4LU33r0cPb7e5LXuF9bLQ=; b=L3dYLUWfQQeoA8VY6o97U9qkLZ3Pkugjy0hi9lShyu92DLkz5af59KniF4o5N2/fvy hGGgeFCLjtuCpq7S+yxJ/CpfnQuGHOnDaoiO4/P/NlOm8yALpCvX+i1wkllTpt2zqnqg mb7s/t6LHN+OLHybz4SSET7DCzvVIHQNGDGaL7KwqwtQDDC2U3NQL2p9Wv0fswYtJKwA o+F3+39l8cAn7/ICwpJSoTbxpfUOpqcBfAsIQO4LFdH9G7IHeOKgtgbnNk96DbrS8DxC 3G6SoCG5IBwtBl2iZs/0sZRkt07KENH3a2JpTs0W43OBzDJnqH9vjq9XSwuoY/H8yYKK ExwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713308524; x=1713913324; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CcIcGPosIc+mxAdwBaHIMp4LU33r0cPb7e5LXuF9bLQ=; b=lCiI7SDzZ7j+hHw0C1e6klz/uGQ5Zwog7K7y2pUIhzllFXek+BYg99wZFGCQi7wVOH 42+qWA4akV9Xir8kVzugQE3CN9uuaEz09tyJqvYu21/yW3l7AyIFTVHfoJOOPRMw8NKT 3/zI2M5M+ThdbntG9FQNVc4SKbLDBqE4eZsGGmzDq/MoLmCNjluvSrgJGVW5Sj7PHzrE a/CD88rCbkn6eROlA0rXZf7sjuTl2PYnhV2j1Zv4otEcsA0T6BBFk/xMQN/i8bhfVfiH +fj/9f60nOPJ+MT4uuteclP2/fAYKs9RsKyehE67o/uRmcYdGVeNrcTjAzGJjqqtmzcD U7RQ== X-Gm-Message-State: AOJu0Yw6+JGFx1HypPd+d38dKJiaYcjPIJOwidsMkjNN+8KbHDtQiz+A hTkTK5Sjl+Au7iQF+Ez09DoDt50XTZ4JfeX8MABTGkD51jEzpuNZ14n/8A== X-Google-Smtp-Source: AGHT+IEDqdRM2RxgT9zUDwVfUGUgOUlqf3/mybR9i5PUM7QKG6G1+3GYGHUvgD4eZk5xLMDyir/d2A== X-Received: by 2002:a05:600c:1c19:b0:418:6138:6777 with SMTP id j25-20020a05600c1c1900b0041861386777mr5038559wms.31.1713308524441; Tue, 16 Apr 2024 16:02:04 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id l26-20020adfa39a000000b00343e825d679sm16151294wrb.87.2024.04.16.16.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:02:03 -0700 (PDT) Message-Id: <621912a64fbe0ec412cbef42561fd647de446660.1713308518.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 16 Apr 2024 23:01:53 +0000 Subject: [PATCH v5 4/8] SubmittingPatches: quote commands Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index a27f7c923b9..b684bdd03a1 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -403,7 +403,7 @@ Before sending any patches, please note that patches that may be security relevant should be submitted privately to the Git Security mailing list{security-ml}, instead of the public mailing list. -Learn to use format-patch and send-email if possible. These commands +Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME type e-mails) might render your patches unusable. From patchwork Tue Apr 16 23:01:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13632721 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B978013AA37 for ; Tue, 16 Apr 2024 23:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308529; cv=none; b=VUo6GSUUBjEwgLp/Ej3D//i4WS0VWQ/anASLibTwzj9C9yxG5FiYzD+6BuIy9OCAOf9/tBxLwZDRCNmSjqmPHzGS7mg4e+8PxvtWRe52PzPBctEe4S5IE9agiFj2oKUzMLzs1PBRTDN95G6mNqLdHH5+3GmXHHnl67wAOYGaaUk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308529; c=relaxed/simple; bh=3IfJr66Hv3JkMkSP2jtPdUbNbjWoEYtSQmob50dYzI0=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=HskirZAGekxOM7SU96ipq/fnhRtYyddx/SXqVr+b8OstF/i6pY3OCl7I74haSi+dxS0+27jCD+4N7Te3rZt/puoSt9SVFQ2k/4SNufw9vQwMW4DaEVt/e+kIjMPjLK5OBABjsApw2sqjTuJLleCIg9WS9mCSSHHkzFvbL2urN5U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AW/TGU5j; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AW/TGU5j" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-417e327773cso1197215e9.1 for ; Tue, 16 Apr 2024 16:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713308526; x=1713913326; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=dotXuEnx+0BKqnk1B9bF1hsL60NvxpDJtQhf2HNdqdE=; b=AW/TGU5jH9W4Kagct4FQngU51IZMBjADzysJ98J3JhJVUFf0g5bVtagqD1JZ1pxkcP 909obY3UPSRvaMownp7NsMNekSXLggq/G9ZaQNMtInclMK8xr8gxFZDASw7TAD5Q2OIe 137O44ZXP/5eb1MIB45VVuKGQF4LUAEb2fQEoepjL0FEnQtjBz/q5tMSocr67m4wrVLH TOo5zvDJVpCnHCQ6MHymdUQfsUzH02SbznCx1IAdI2WDIFn7lnXum9AAf6H78kta71b6 Jf3PK/lDGUD4Mi0wfMFAOaT1Uxe6xIMenN0Cz+cDVbVJBqLwV1GBUih6P2duMDVMH48d PhuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713308526; x=1713913326; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dotXuEnx+0BKqnk1B9bF1hsL60NvxpDJtQhf2HNdqdE=; b=d3o+BAkJPZyeA/pWtq6vPxM/lMRoC2pCqa9cBMqUJWAJNBr+9bop4U7Sytx4pLt2fY eWsCPGcEKhzAzIGFk7W74i0P8D1bYAOpzfCl2J9aPVfBKno5DgWMZk1c5nGHwvHnpcU0 TGyuZsOzmXjdR1XgsjenMgq4v5HXFPuYhyWMsIE9Mxi0dpSXM/Dw28KQGXm9Jzp/a26L r4AnGXLaGT0rvoNusC8NZbJFijHsaESXCQvqZe6Da6ImA/jfRmrxu807nuaawOd+/3x+ wru82N/0a1woXVHSk1hTRjou4GLX41WfFXJLlVbrxmLRHrPfu1+YSrOxMMaAg6iMt5J3 XV0A== X-Gm-Message-State: AOJu0YwOBCOpj9g1BTYgAI/EnxiRpsoSK//NXNBJzmQ/8+8Il9uXhltj dd+zssr9Zix7USIsNZ16jdG7g3QtZKTmzabp/Rqja3o4yMp2X1UQDjw1HQ== X-Google-Smtp-Source: AGHT+IG9TDB/YFnzsogIRYcdgwBYr2z+3eVKTZe5CPAgADpef0ygertWMWehEA+ZNpp79XVMPw8lKA== X-Received: by 2002:a05:600c:56d4:b0:418:2981:c70f with SMTP id ju20-20020a05600c56d400b004182981c70fmr537429wmb.19.1713308525809; Tue, 16 Apr 2024 16:02:05 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id n26-20020a05600c3b9a00b00418a2ce884bsm402602wms.32.2024.04.16.16.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:02:04 -0700 (PDT) Message-Id: <8f44343c482dd2c343b6c449479c5c35dcdbbc50.1713308518.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 16 Apr 2024 23:01:54 +0000 Subject: [PATCH v5 5/8] SubmittingPatches: discuss reviewers first Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver No matter how well someone configures their email tooling, understanding who to send the patches to is something that must always be considered. So discuss it first instead of at the end. In the following commit we will clean up the (now redundant) discussion about sending security patches to the Git Security mailing list. Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 68 +++++++++++++++++---------------- 1 file changed, 35 insertions(+), 33 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index b684bdd03a1..a110f94db4f 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -397,6 +397,41 @@ letter. [[send-patches]] === Sending your patches. +==== Choosing your reviewers + +:security-ml-ref: footnoteref:[security-ml] + +As mentioned at the beginning of the section, patches that may be +security relevant should not be submitted to the public mailing list +mentioned below, but should instead be sent privately to the Git +Security mailing list{security-ml-ref}. + +:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + +not part of the core `git` binary and must be called directly. Clone the Git + +codebase and run `contrib/contacts/git-contacts` (you must have Perl installed + +in your system).] + +Send your patch with "To:" set to the mailing list, with "cc:" listing +people who are involved in the area you are touching (the `git-contacts` +script in `contrib/contacts/`{contrib-scripts} can help to +identify them), to solicit comments and reviews. Also, when you made +trial merges of your topic to `next` and `seen`, you may have noticed +work by others conflicting with your changes. There is a good possibility +that these people may know the area you are touching well. + +:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] +:git-ml: footnote:[The mailing list: git@vger.kernel.org] + +After the list reached a consensus that it is a good idea to apply the +patch, re-send it with "To:" set to the maintainer{current-maintainer} +and "cc:" the list{git-ml} for inclusion. This is especially relevant +when the maintainer did not heavily participate in the discussion and +instead left the review to trusted others. + +Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and +`Tested-by:` lines as necessary to credit people who helped your +patch, and "cc:" them when sending such a final version for inclusion. + :security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] Before sending any patches, please note that patches that may be @@ -490,39 +525,6 @@ patch, format it as "multipart/signed", not a text/plain message that starts with `-----BEGIN PGP SIGNED MESSAGE-----`. That is not a text/plain, it's something else. -:security-ml-ref: footnoteref:[security-ml] - -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. - -:contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + -not part of the core `git` binary and must be called directly. Clone the Git + -codebase and run `contrib/contacts/git-contacts` (you must have Perl installed + -in your system).] - -Send your patch with "To:" set to the mailing list, with "cc:" listing -people who are involved in the area you are touching (the `git-contacts` -script in `contrib/contacts/`{contrib-scripts} can help to -identify them), to solicit comments and reviews. Also, when you made -trial merges of your topic to `next` and `seen`, you may have noticed -work by others conflicting with your changes. There is a good possibility -that these people may know the area you are touching well. - -:current-maintainer: footnote:[The current maintainer: gitster@pobox.com] -:git-ml: footnote:[The mailing list: git@vger.kernel.org] - -After the list reached a consensus that it is a good idea to apply the -patch, re-send it with "To:" set to the maintainer{current-maintainer} -and "cc:" the list{git-ml} for inclusion. This is especially relevant -when the maintainer did not heavily participate in the discussion and -instead left the review to trusted others. - -Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and -`Tested-by:` lines as necessary to credit people who helped your -patch, and "cc:" them when sending such a final version for inclusion. - == Subsystems with dedicated maintainers Some parts of the system have dedicated maintainers with their own From patchwork Tue Apr 16 23:01:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13632722 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FB9013AA48 for ; Tue, 16 Apr 2024 23:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308530; cv=none; b=L1cV+IKzLrrpfVTiaPHmZHipYLbGUZsr3lMZfJLZLFkzfT6DEHQ7mHOmMpbMOIlut4V9qH8zYxU5dRO4T0IpskjhZ0d9Cj28fMN6dSN3LgY1UGyAkTetyotpfdw750+jdhfSV/IgdnI+8a5rU85gwDNozIuKrg6YsaozNw6zv0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308530; c=relaxed/simple; bh=ulyTEcuPvp/VeO96joEDa6mN2f4b1GWZaQpSPIbleLk=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=WjgRTcYVz+TSIVO1RTEctdLhHBzX9OAfhCLTb2ULIlUV1s/f2IYPOxJAkWIJgHp+9bWoNiIoEfqk/EJ+e1pZHVPKZHuYT9GOi9YiPjFyV9SvEY9wndQfOlT8MfXStmeKTqJF7lBBskAY03nqbry4ffa6BR6gvZkiZ0Sx3JuSgOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z+GrIZeM; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z+GrIZeM" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-41892a751faso7577185e9.0 for ; Tue, 16 Apr 2024 16:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713308527; x=1713913327; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=+5LUQ2DI1gy+pHvfC8/qm4H4x816z+sGRCRZfUZnVqw=; b=Z+GrIZeM0VrqaL7HIYWQ9HoWgnsAwrhpLyjtaNEeOdzvoGMECYBlm/dqSZAmdfpDFZ /DchblkmHJgtPI0lbchxNDO9j7zrRhRwCyTxs5mEB2zw5FvgySg1tInXwNpTzJvgtvUT 404PW2W4GEzGp+w6Y6OhAnvaOZdjDpXu/hLuj6/RGVjM1hP08/VQvakgDMt5L9UXi/fN OqUUFeZRIbmvpiJbHel2EsmLHPPn3NRV/jrcFXylBb5H3Z1/ctaTtddtlC+gkbQmKDDJ eaUfoNb/hrcfCGYfrqrygHpRPC6A2yTB9pDzpK/KM7J+QluAdZSBxU33EUzp0FhR5orP tcyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713308527; x=1713913327; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+5LUQ2DI1gy+pHvfC8/qm4H4x816z+sGRCRZfUZnVqw=; b=b169Yw2S5+P9O+aVHE+U+AWyIMPW9pKBuqleF4COKM6rqV0jsyDYzBe7R8e54Ttlqx ZsogMVB83aRTkQKBhOHzmMBwprztQ4kdOQGd1xxCZVY+qeNVsDUd5wPGR4ShA6JohlAP yEmUcVCEZ3sXRAxrUboymfA91IX3Fqkdr3VbY4GKC5NbOOQ2tlkU/csLFnj10EEhULE/ dZeOhxB2jSAbFR2VHc8maC+6oIM8w13t+viHKPI8ZDG8gg6J3o+/o/mpI2itsq62mOEt 3ugaDwZZJp+++o4gBP7OQ0LRhxlmQkxbHnjeMsNRKCmi9AmbKdpwlYcmzZpOE2qTIwM4 +ECw== X-Gm-Message-State: AOJu0YzEIj+3za3tgFS4TVZDfWN/xITCOkpUwUrBRhLbfyD+84eXYEZe POboyBN4feBzQ6kH60AmK1Wyug/7MP56RhWESJ8x6+DQYhJqzfrzHp3MPA== X-Google-Smtp-Source: AGHT+IGfXfkbJEhNQdNRJP9uUIi2ycOxp8NL3Ps4256ariLf8GfH2o3pITspxu4AlH7J42O0/W19qA== X-Received: by 2002:a05:600c:35d5:b0:415:6121:5171 with SMTP id r21-20020a05600c35d500b0041561215171mr8939991wmq.32.1713308526933; Tue, 16 Apr 2024 16:02:06 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id cg14-20020a5d5cce000000b00346d91ddbe3sm14917018wrb.9.2024.04.16.16.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:02:06 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Tue, 16 Apr 2024 23:01:55 +0000 Subject: [PATCH v5 6/8] SubmittingPatches: dedupe discussion of security patches Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index a110f94db4f..060c8069c10 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -399,12 +399,11 @@ letter. ==== Choosing your reviewers -:security-ml-ref: footnoteref:[security-ml] +:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] -As mentioned at the beginning of the section, patches that may be -security relevant should not be submitted to the public mailing list -mentioned below, but should instead be sent privately to the Git -Security mailing list{security-ml-ref}. +NOTE: Patches that may be +security relevant should be submitted privately to the Git Security +mailing list{security-ml}, instead of the public mailing list. :contrib-scripts: footnoteref:[contrib-scripts,Scripts under `contrib/` are + not part of the core `git` binary and must be called directly. Clone the Git + @@ -432,12 +431,6 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. -:security-ml: footnoteref:[security-ml,The Git Security mailing list: git-security@googlegroups.com] - -Before sending any patches, please note that patches that may be -security relevant should be submitted privately to the Git Security -mailing list{security-ml}, instead of the public mailing list. - Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Tue Apr 16 23:01:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13632723 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2D3A13AD09 for ; Tue, 16 Apr 2024 23:02:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308531; cv=none; b=JXqelDigU5LvxXbEozQu+SL9jkZcliphTvzIIr8Z8ADq8qoeTVLXlJx6ujLX9UADYaEj09r6+NFW9jkoFZ0+DGcodV3qiPDPA/R0S1v1+PIV1XSsOTeEgeNMeOPniGNIqFCLWElnP+QMT2gDanwe5MhgezsXAeruebSCdn2yKm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308531; c=relaxed/simple; bh=l3yGsuETX+rCdVToSs260BzmXp0at75lyiOAbnEEWv4=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=LMPavsEM/cIlP4N+3SWyHTsMw19efnmbeErxF/dqvtA6Y2pp2Bo54xK0P9IAeukSwFfPX5+x9+WxCB5O/AvlIVXdv4nsCzi7mqgLoog0RQFf9NplzZIh3nxNYbhZZ6U6GoZZ1yqTxu4+G9yfeqif0HKl3TB6aQbUMV9KNqxn7HY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IxnD87XG; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IxnD87XG" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-346f4266e59so3584082f8f.3 for ; Tue, 16 Apr 2024 16:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713308528; x=1713913328; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=mkHmOr7a1iHdcuXIZuXhos+KLl/CUPe3QCKRD2mfI30=; b=IxnD87XGElAKmNR6luWKBi0IR1Ifoos9nZi/bj39suGKzLQhq5FKzpJ8wwL+W/PUuB D+YcTlDNYj7TmNw0YsNX2nb2/M02GrRkNH70IS5GHcdwLwK4o7LC6HcLF9k3FJkJ3Ij0 fBMoDwdoefzWBtqZNXcN4cFGQQC/WovGQSeVo9SGzafhbnib7wuFH+qFkTlig1tv8c9k 8MXPUor0qcB5H8+ZS2nPnf3AGD+Gjfxigm6wAAArD/7qgokbFs8q3dKEJg8um42PUWTl oXovn2gg88Hznc8venx6JFJrvS4nTyZttUxIzSIAjAtPfeFel0eW+xItT2elh8LSHn1p 7VXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713308528; x=1713913328; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mkHmOr7a1iHdcuXIZuXhos+KLl/CUPe3QCKRD2mfI30=; b=Nq4vUdueP2AGUGcM5ShWrc4THJuHO0uS2+AHt4F2kS4zcRHfREpIDdMG8MHhD9zzQE C81eaokncBG3Hp8bK2P15g8fc7FP6RGEF8qrlyl2pwe1JkWKLpO1yU27/74g4E2JyEag dqO/GdNxqtW1idkJzFdvreiaLfYJklBucuawStNVvrfE7r3xHTB5ILc7nemyA9IpIDRb UbzgB3xTbg8WTb009gb1ZYUtnQtDuW9HdAZq7RS9W+q5wAnnXSvmbsZTdFm8QDlx4iP9 lnRrccA22lsAxA4bjtmkmIihX0lydJIs+fUbOqwmBQxvbgIcnTlBgaHB0ejUZ0H8aQT8 oc9w== X-Gm-Message-State: AOJu0YwIHLV55tjxkgEZRbIvCe0gAlpPseCJkz7JqWX1I0wXsIvgfJ5V BSe9eruKt3M33zGl0HuA9zf6p8J2q/0AiuMfUN6zet5AV/Q1nlBLygxzsg== X-Google-Smtp-Source: AGHT+IHKsqqca+fUSI69dHfoUusyMbF3lFZ74Ot32Ib5sfNptnJnEdKdZjO/CrtG5Ff0Nx4k5veb3w== X-Received: by 2002:a5d:6da5:0:b0:346:42d5:2d86 with SMTP id u5-20020a5d6da5000000b0034642d52d86mr12268228wrs.46.1713308527698; Tue, 16 Apr 2024 16:02:07 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id f12-20020a0560001a8c00b0034744966ff0sm11338573wry.59.2024.04.16.16.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:02:07 -0700 (PDT) Message-Id: In-Reply-To: References: Date: Tue, 16 Apr 2024 23:01:56 +0000 Subject: [PATCH v5 7/8] SubmittingPatches: add heading for format-patch and send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 060c8069c10..1700132a3a4 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -431,6 +431,8 @@ Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and `Tested-by:` lines as necessary to credit people who helped your patch, and "cc:" them when sending such a final version for inclusion. +==== `format-patch` and `send-email` + Learn to use `format-patch` and `send-email` if possible. These commands are optimized for the workflow of sending patches, avoiding many ways your existing e-mail client (often optimized for "multipart/*" MIME From patchwork Tue Apr 16 23:01:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver X-Patchwork-Id: 13632724 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEB8D13AD15 for ; Tue, 16 Apr 2024 23:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308532; cv=none; b=SJPi1AY5Fr+XQwaJ0SvQb9usmGRHW1jy8cgv5kvQ443JqD/gKY3z8mQ1qdAX86ZM7Cd/44awK2EoBBWYgrkBFHOI7ZOJyvhljbMF2lfRp7zhgF1bK/hxlLm+AUG5MaflgPdsB2WLBGX/uYDkX6mIxVfwcttqAhQ+kP/aqmyNto8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713308532; c=relaxed/simple; bh=6EvzbT0ZwXyzqn26rJHk9SzoxP/hJiQdJpzmoErjKwM=; h=Message-Id:In-Reply-To:References:From:Date:Subject:Content-Type: MIME-Version:To:Cc; b=dWwCEjOUAq5vWsm5VN73yr11jfQKmI8MXEW7w2f8MgA8Wb5GDzFHxfzW+VfEvJh+sjQU10bT2VbkZrbG5hfSIT4D4b1IkEhJAsk2skhJVKK/grsMEagFQTffJAFtlLf3V0goPDPX/mVSPP6g4I5DD/hhZEmMlSnfuzNnNrqIdqg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bOtf444S; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bOtf444S" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-41881bce4b5so17400745e9.2 for ; Tue, 16 Apr 2024 16:02:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713308529; x=1713913329; darn=vger.kernel.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:from:to:cc:subject:date :message-id:reply-to; bh=SnRIMveJaHMSHtDNWkRV5TTqCFbIOfzyBizh9rp/a0c=; b=bOtf444SdY1t8Q6vdVKNOcwXycQZpYx5IsJQhAn4isZPPjkLgKwYZx2ofr94I7mDs9 9uCe+YkkV38s9w2gRfd0/DKrypiEDsp4SFwFkC1HnrMgA0+HXER63p6zMjmtuDtnqjjN MGr5CSPS/PfAo8OQpI67XM2PxfeTSRGcgPAd6n+AYTEAvBWy4ZHXp5yZYzLOiDk7N9BB fYJWB6Z94B269MBl3ngMfVID0xThfy8fQgovPeSQOJbCumhOrolpy/5VczIgl/7YnN8w 4YLvkPyDu3biDkZImQiujXL7KDE7hawCCs/hOe+PBaOiuWzt+VCfxsnmAlt5QOzTMqFF A2Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713308529; x=1713913329; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date:from :references:in-reply-to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SnRIMveJaHMSHtDNWkRV5TTqCFbIOfzyBizh9rp/a0c=; b=UBSS725hvswBU8uz1/QLQPn+B+j0Wyl7NLxM2IqtsjFOuO9u3ysdfa9tp7XL13Z93w kv9stjq7Y6i4gGSJ+tenhQ7vWfWuBAZbrsaXJ8KRn/Rxdzi5KUUufh9N9DQuZ+euUW+Z /tsBNi3OrjdPlAV0azdcmo9wEFKIPywSW1ZH82LPLcGRFBNKjsjuryR5eGJDrbAVXUTo oerpARkk9022JeAkH1sPnjv7KdHoxvheiO1pBzdfKICthmeZyTiWxLyHsS7jijYPEnZf E/YTjnqnjF7BzFraEVpDcEbdacQNUYVxmb6/2ouztd7ZQjaPlaNA0+HrJzPznnoxST1a kBXw== X-Gm-Message-State: AOJu0Yzi5ja59UYAyReLAsXYgA0eTVJGpVpr8AnoZZqCZjNOsbh3+nYy HDj0Z/4UY/xPjDQcwgmKi4E/GyXjPOhehUpniGKtZkdgpT0vksezXo6VXQ== X-Google-Smtp-Source: AGHT+IErcoyY2dWrl8Q3jm2cbDdqY+QG0ovN2QWvpg8OydStGWIscPTJoATafaXST6dit7dn+5AJ+A== X-Received: by 2002:adf:f352:0:b0:343:81ea:c539 with SMTP id e18-20020adff352000000b0034381eac539mr11152342wrp.28.1713308528853; Tue, 16 Apr 2024 16:02:08 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id a5-20020adffb85000000b00347e1304639sm6062434wrr.48.2024.04.16.16.02.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 16:02:08 -0700 (PDT) Message-Id: <911d4f2a0e51786c506d9dff3e88561362b108e4.1713308518.git.gitgitgadget@gmail.com> In-Reply-To: References: Date: Tue, 16 Apr 2024 23:01:57 +0000 Subject: [PATCH v5 8/8] SubmittingPatches: demonstrate using git-contacts with git-send-email Fcc: Sent Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Jonathan Tan , Emily Shaffer , Patrick Steinhardt , Matthieu Moy , Eric Sunshine , Kipras Melnikovas , Linus Arver , Linus Arver From: Linus Arver From: Linus Arver Signed-off-by: Linus Arver --- Documentation/SubmittingPatches | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 1700132a3a4..b616422197f 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -418,6 +418,13 @@ trial merges of your topic to `next` and `seen`, you may have noticed work by others conflicting with your changes. There is a good possibility that these people may know the area you are touching well. +If you are using `send-email`, you can feed it the output of `git-contacts` like +this: + +.... + git send-email --cc-cmd='contrib/contacts/git-contacts' feature/*.patch +.... + :current-maintainer: footnote:[The current maintainer: gitster@pobox.com] :git-ml: footnote:[The mailing list: git@vger.kernel.org]