From patchwork Wed Apr 17 04:44:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13632860 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEE90C4345F for ; Wed, 17 Apr 2024 04:45:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=262ouqhs6HWXq6r9OW29kPyTaeQDAmW1GbHzfn+qFYo=; b=VahItJU/kMVtY9 EU2r6zZxTS47cC14Bwc0LpxwycV/RIA6y2vKJypx4/O+64Q8KwWhsxuW8PosTTlhzqUavTUtz/gQu Uu0bNHsZKd/vq7v0q5Dlivkpv3FIPuDMghu69oaGmqZmnzOa3McrX87wN6JguL8whn4/DBLfCH7SU D5NVIC5nDgZZ1wKI1YyvyTaQtu+5GONuPpH+V2S9Qpw/tLO/UaSX/oQlr9UwR7UXzLzRVxAlRiCQA ApJB5AXw3+EaGEmIkZLE0wFy7+zUEJQUIZpmL1CkYZ+OttIEEx9ek1EHd55AzAvcRPMSY73cn/OMv dPZ8iadQgeT75QLdGYQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwxAj-0000000Ehah-2bLE; Wed, 17 Apr 2024 04:45:25 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwxAg-0000000EhZo-1ncN for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 04:45:23 +0000 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5ca29c131ebso3400684a12.0 for ; Tue, 16 Apr 2024 21:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713329120; x=1713933920; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/+FnJ6J/RkjJ0VXVfZtkwMb7BZfv1rFQNC+1ugT22Ak=; b=GSXZNybKI4yeMhtfKSpUH6eG5eNHGnUyXGlVCLoh+Zlz+A0MIUHMBOaxoeNmKekHse 8HHHTql0TfMhczNd9mruOvV+GffDQoCDXaVFNLwsL+WvkzNhTN8Xwp1Mzajo05BNiQLp 38Xs/rOp2m6kCcVfB10NU795ujAlf2UDvsqKXoQ7lg+x2fVmQs4oNaDnvsVTvJ7s+mRD xICjMW2+n/UhwzofsbTWP6TD2hnxpILOUQPIFuAJFNRo6fIA2AJ2DlEcUtyQ+WRoeXpn MTgPKILM5RyBcou56BToBFVx40KnW2aYcHo8YH2GopNDMJN4opDfvUWS1CdxsAy9koaO a42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713329120; x=1713933920; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/+FnJ6J/RkjJ0VXVfZtkwMb7BZfv1rFQNC+1ugT22Ak=; b=ZK4FJDp8TI+pOQV+rPHwYMLfIttwSXYe17LI/nB+/mHJ+n9HG2/3/eNEXZu1ere4z4 ndiCk8q4SXrqkf4iANUwAb0xauol4j7j2o4oGdUNIhCidOUXnui7+SNe2oKGamNWZz56 AojkwpRlw3p5cHHYjSwvl5JEx3Ai25bJSni+lUxSJuhAsPazIwksudm6QwtprM4X/uTa AiTJSDmBOBg6QMG1gzUdB4PEEHQ9NQj1d4i0rv6dEo8Y+g9N4jQ5f27/DcxLT3y3HfqG C3c2OFdGq1z5L5t8gTKCA77lBdBsIwZNQjbgJCd2/QA9WAruQdWLI2aMlzqePQ2732GZ 4qbA== X-Forwarded-Encrypted: i=1; AJvYcCWRPBwT6cU1KweDEFUC3gDqNSSRqoez8Ljq7LM55D4chK8aSRMls9pVvAfgrH1Mz2B+Q7ZSsQYsatqnWP9N+KKXD2mF+XBkOBYwbLCHJ/gwGMxOI4o= X-Gm-Message-State: AOJu0YyjITKK26wQPLm57zymAF77qOvx7JgywGHOvi5OJs9SsvjF7QMx UOjiw1ATKPKqMMzWVH88f9mg5UtDOi8TKUNwNngkh3vPFj8bCLQB X-Google-Smtp-Source: AGHT+IHxRzmBXFzDf+o2Pp3UyCz0NHEGmQbeHnpP5TR162wNSMlZLOZeT8I5OP1PmnGHDYp0Y6h2eQ== X-Received: by 2002:a17:90a:b307:b0:2a3:48a8:cf7b with SMTP id d7-20020a17090ab30700b002a348a8cf7bmr15071413pjr.18.1713329119838; Tue, 16 Apr 2024 21:45:19 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id z88-20020a17090a6d6100b002a2dbbbb36asm511458pjj.37.2024.04.16.21.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 21:45:19 -0700 (PDT) From: Anand Moon To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] PM / devfreq: exynos: Use Use devm_clk_get_enabled() helpers Date: Wed, 17 Apr 2024 10:14:47 +0530 Message-ID: <20240417044459.1908-1-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_214522_490539_319B18B0 X-CRM114-Status: GOOD ( 18.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). While at it, use dev_err_probe consistently, and use its return value to return the error code. Signed-off-by: Anand Moon --- v3 - No change v2 - No change --- drivers/devfreq/exynos-bus.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 245898f1a88e..153340b6685f 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -160,7 +160,6 @@ static void exynos_bus_exit(struct device *dev) platform_device_unregister(bus->icc_pdev); dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); dev_pm_opp_put_regulators(bus->opp_token); } @@ -171,7 +170,6 @@ static void exynos_bus_passive_exit(struct device *dev) platform_device_unregister(bus->icc_pdev); dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); } static int exynos_bus_parent_parse_of(struct device_node *np, @@ -247,23 +245,15 @@ static int exynos_bus_parse_of(struct device_node *np, int ret; /* Get the clock to provide each bus with source clock */ - bus->clk = devm_clk_get(dev, "bus"); - if (IS_ERR(bus->clk)) { - dev_err(dev, "failed to get bus clock\n"); - return PTR_ERR(bus->clk); - } - - ret = clk_prepare_enable(bus->clk); - if (ret < 0) { - dev_err(dev, "failed to get enable clock\n"); - return ret; - } + bus->clk = devm_clk_get_enabled(dev, "bus"); + if (IS_ERR(bus->clk)) + return dev_err_probe(dev, PTR_ERR(bus->clk), "failed to get bus clock\n"); /* Get the freq and voltage from OPP table to scale the bus freq */ ret = dev_pm_opp_of_add_table(dev); if (ret < 0) { dev_err(dev, "failed to get OPP table\n"); - goto err_clk; + return ret; } rate = clk_get_rate(bus->clk); @@ -281,8 +271,6 @@ static int exynos_bus_parse_of(struct device_node *np, err_opp: dev_pm_opp_of_remove_table(dev); -err_clk: - clk_disable_unprepare(bus->clk); return ret; } @@ -453,7 +441,6 @@ static int exynos_bus_probe(struct platform_device *pdev) err: dev_pm_opp_of_remove_table(dev); - clk_disable_unprepare(bus->clk); err_reg: dev_pm_opp_put_regulators(bus->opp_token); From patchwork Wed Apr 17 04:44:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13632861 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8273BC4345F for ; Wed, 17 Apr 2024 04:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iVDouR+VTZu/uppt90P3FgjX9WW5Y0JynCZLFJjF1AA=; b=vNN7UD5hQNMZ0+ Ar6jfOpxvKN6Fy3xVZK6JklHaL/HpWRbG1T4w0qPBOct/IJodsGGDtEMNCd3rGI3TPVDtchKdPq/o y75xNL9uT5314Eu6J5DKkmWSYeuuqlZ9mXlsYZ1UIWHkjsZiu9oQrrZ+2jb6wmRyYhS/D6k0dhKIm k5Q+QKn764xcQia/65e9Up5aAT1u4TWTU820jleHqwDyzs1/MUrJOE6RsIs2l3kbMcUI8bNnMktNx hZuxZf7yJZhgVnm7yWqls2iFHnRAcxBawzgCI34XxIpUX4d1LtJAZF99BGVHgh3Mn6U1ZRLwsL78l t3rkEuAW5TJmhi5m98ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwxAr-0000000EheI-2a6h; Wed, 17 Apr 2024 04:45:33 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwxAm-0000000Ehas-0Ovv for linux-arm-kernel@lists.infradead.org; Wed, 17 Apr 2024 04:45:29 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2a2d248a2e1so315571a91.0 for ; Tue, 16 Apr 2024 21:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713329127; x=1713933927; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ix5I1EmrcVwkdm6oev/n0e0cu3EKBfKkUwQi0q2AcII=; b=E8aDvejxwO57tUEfeCx85vCb0mLcIWkh4ufvh1MZaW21P7nctSNxmeAiobsnN/ldbd 8nYfg7QsbQ/50/Ew7Mm2ZDj1y1hAHWrC9qeDWHKSPyFwzsebM9h8EfoOrTlwTcQUs7NK WICQ/9XAiNnZOGFM2sOBvcuO5jd+AhpjndEAs9mtuAn4/K7HZ8YIl9SBnKf9CsXXBMpj BYfmXP/KP+OGDTWw5hRdg+oMrE/5bKIb7Ox+oPQLiHgrBDxU0I+SfcOMfn5H2Bc7Vt3H jZw35uTqZvi6u49kCE2/N+TrkqaOwnY+Dxtd3GyCl3mWyZOES4ZqfXjKBBITbHAQLjWF Wqpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713329127; x=1713933927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ix5I1EmrcVwkdm6oev/n0e0cu3EKBfKkUwQi0q2AcII=; b=Lu6N31eUvsagGOagGWybaaqOnkuLRNaYr8lZgtvQkCELO3xTxoP+7RjG0DQi6INxnq SUnVCSwJjLPYB3tOXMDoY3Tt4zjyj8OaFQDJy5KpnvQNMikbEVx0sBgScxW7TlOpQBiK kH8PKMgUNXCkdg8Qgmnlak02BzzU8JyfV+b2ymlSdMaSJ55LvgSAyzvYxBCwxnP6okDC Eah0JOOsiTZmU/8o8rXALiSSrOtcD2MePuNJ677EJ2b4/pwbOpyI8DQ4GDai3WWDkxtb A/1dn2fDB8tDu7oTIHlgh4dtHerWXrAKd90ywXOIcT+lLjI8VJ5Xzr3Y22njqTzBd5lJ 3NnQ== X-Forwarded-Encrypted: i=1; AJvYcCXJnfL4OqRfZlEL5Urm3YMnSVZIN+oY1cvRQqdMV1ufDMKVy9PmKtYFw97BOxfKqOcXfluIiySMEyPy6xbZPWZZQeeVqJwb6xjQbnRhoZ2Q9zLs1FE= X-Gm-Message-State: AOJu0YykPPg+i22dM6W2HiY1CeQHV6qY8EiFi1jg9jUbOyNRwq6NPiUR yiOAlul0CXZVkvBzkdbcbP0HGkixP3Oje86Fnyq5dHsnhTodj4vQ X-Google-Smtp-Source: AGHT+IHcijOFiGcrpds/8InYTdLVg2ob8g6xgqf32vPTH6ClkmhGxpsSjcOf+6Heyl309B3TS6AIdw== X-Received: by 2002:a17:90b:3010:b0:2a5:c1ca:801 with SMTP id hg16-20020a17090b301000b002a5c1ca0801mr6393726pjb.23.1713329126906; Tue, 16 Apr 2024 21:45:26 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id z88-20020a17090a6d6100b002a2dbbbb36asm511458pjj.37.2024.04.16.21.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 21:45:26 -0700 (PDT) From: Anand Moon To: Chanwoo Choi , MyungJoo Ham , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: Anand Moon , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] PM / devfreq: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Date: Wed, 17 Apr 2024 10:14:48 +0530 Message-ID: <20240417044459.1908-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240417044459.1908-1-linux.amoon@gmail.com> References: <20240417044459.1908-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_214528_180177_C414B05B X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This macro has the advantage over SET_SYSTEM_SLEEP_PM_OPS that we don't have to care about when the functions are actually used. Also make use of pm_sleep_ptr() to discard all PM_SLEEP related stuff if CONFIG_PM_SLEEP isn't enabled. Signed-off-by: Anand Moon --- v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence change the $subject and the commit message v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM is disabled --- drivers/devfreq/exynos-bus.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 153340b6685f..b89e04eb8430 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -454,7 +454,6 @@ static void exynos_bus_shutdown(struct platform_device *pdev) devfreq_suspend_device(bus->devfreq); } -#ifdef CONFIG_PM_SLEEP static int exynos_bus_resume(struct device *dev) { struct exynos_bus *bus = dev_get_drvdata(dev); @@ -482,11 +481,9 @@ static int exynos_bus_suspend(struct device *dev) return 0; } -#endif -static const struct dev_pm_ops exynos_bus_pm = { - SET_SYSTEM_SLEEP_PM_OPS(exynos_bus_suspend, exynos_bus_resume) -}; +static DEFINE_SIMPLE_DEV_PM_OPS(exynos_bus_pm, + exynos_bus_suspend, exynos_bus_resume); static const struct of_device_id exynos_bus_of_match[] = { { .compatible = "samsung,exynos-bus", }, @@ -499,7 +496,7 @@ static struct platform_driver exynos_bus_platdrv = { .shutdown = exynos_bus_shutdown, .driver = { .name = "exynos-bus", - .pm = &exynos_bus_pm, + .pm = pm_sleep_ptr(&exynos_bus_pm), .of_match_table = exynos_bus_of_match, }, };