From patchwork Tue Apr 23 08:06:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13639585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2B8EC4345F for ; Tue, 23 Apr 2024 08:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d++ImOgdNcqqmB/58vc7pXUfJ8ZiS4qu4Suh7z1LQbU=; b=nqQlZtjuBs5iGm e9N8rRQh80rCc8ErQZZwFLVn0AFRYGhdg5w7jyUSOfHlm2Lh0PCHOQT61XNyLlsLSJdINH3/Mp8Hq 5eBDkdCXzh7H6Vr2WnNyn4zYwet61Di2sfLTrKUtbYQNRCEk0GroEKYHj/jI22w2oGsBvioH0CcW5 +qGp3nnYXFMV8dpL/G41yh0RIbzz5A9IHWe2yEioNT8tuHdeVe40ud+qKNFPl3vDMjrMc1dmqvYTo Vlffj2oSWY+rU9HPXZhYYzeA07Rq0CQJzttdn+EsOm7LPqDNWLBrobeX3Jw9tkI2g2lHSoI6Z99C0 jNLwyd6xgbjY1jO2AvxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBX-0000000GOy9-3VQZ; Tue, 23 Apr 2024 08:07:27 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBS-0000000GOwO-1Agt for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 08:07:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzBBL-000356-H2; Tue, 23 Apr 2024 10:07:15 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzBBK-00Dq1S-1k; Tue, 23 Apr 2024 10:07:14 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rzBBJ-006nfn-35; Tue, 23 Apr 2024 10:07:13 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin , Sudeep Holla , Anshuman Khandual Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Greg Kroah-Hartman Subject: [PATCH 1/5] coresight: catu: Convert to platform remove callback returning void Date: Tue, 23 Apr 2024 10:06:58 +0200 Message-ID: <16a7123efa7d97ae62a02ccbf9b39d146b066860.1713858615.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2094; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=BjhAxTkZNIvybmD/b9JH7cRVNwKUok2CD/cfopx0NDM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmJ2wmEWsuPLqnmVtNSpue5Uah59alkzDLGxFG6 /vy6GZ6+WmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZidsJgAKCRCPgPtYfRL+ Tm0fB/0RSrJxhOAuSeqlAIdns41FxQnQxc9ZzOujhPbpDgeU2y7qDRuUEVFD2WBlj/WibKMuS1V zJqmSzgi4r8JCwGlOwRm8ujQxRYFBu/dT+6ujemJ0rSa7LgHWLrsoNanItWQbxhA5QY3ba8YojY J5sEomrcrmhRJcJu0N4YU2LmvBEJwb+ug5CiRuPi2kzKjm5QRqt846LQ+pN8VX2E4ENcripX1T0 3oAGrMOg+Vv47itA93t2ujzbf0X4x+1PENy6QXuhjUptaWd5sf0P/9D1u8q1BsWqnMhzOlsZYOj YQ4zv2EtnjoxbNeezu/b8MXFSODPQwlH78hfqqpOpS6JHla6 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_010722_352728_0E3E683C X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Fixes: 23567323857d ("coresight: catu: Move ACPI support from AMBA driver to platform driver") Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-catu.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-catu.c b/drivers/hwtracing/coresight/coresight-catu.c index 9712be6acd26..02d9daf265d6 100644 --- a/drivers/hwtracing/coresight/coresight-catu.c +++ b/drivers/hwtracing/coresight/coresight-catu.c @@ -642,18 +642,17 @@ static int catu_platform_probe(struct platform_device *pdev) return ret; } -static int catu_platform_remove(struct platform_device *pdev) +static void catu_platform_remove(struct platform_device *pdev) { struct catu_drvdata *drvdata = dev_get_drvdata(&pdev->dev); if (WARN_ON(!drvdata)) - return -ENODEV; + return; __catu_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!IS_ERR_OR_NULL(drvdata->pclk)) clk_put(drvdata->pclk); - return 0; } #ifdef CONFIG_PM @@ -691,7 +690,7 @@ MODULE_DEVICE_TABLE(acpi, catu_acpi_ids); static struct platform_driver catu_platform_driver = { .probe = catu_platform_probe, - .remove = catu_platform_remove, + .remove_new = catu_platform_remove, .driver = { .name = "coresight-catu-platform", .acpi_match_table = ACPI_PTR(catu_acpi_ids), From patchwork Tue Apr 23 08:06:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13639584 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9820EC4345F for ; Tue, 23 Apr 2024 08:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0XkqIKYgGnOYNETG1arMRaDF3x/A71a7C9/2AVTLjw0=; b=mR0svEeIgFa8wM zLgApGvkr/6TqJHM+YZp8zJfppSnTkqvARY90KP0JakLPKAf0091Fu9T/tvGSGwwMEG10QBvB1psM ZTbUzsv0PhD+SOqu8VH+JyOa/iezDDWiPEgDzDZNiDnWMC6+CL0yoo6EfMKV3CqbUjuoehPqu7QK/ aKyHVKe8STsC7HoC1LJ64ki8qUhQvVWHKYRTtJKXdPRwuIq1S5JHTyppIMtKgk8jZPETqs0fcGTE3 uSzpft7hI6vKKSyq7GGrcoCKI4kMSr/jdAdIGxuQPPe5zRiNv6p68+VlhNBQavbnkOnhL9pwyt0Zg +Grey4oBWjyqU7UILmJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBZ-0000000GOyU-05A9; Tue, 23 Apr 2024 08:07:29 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBS-0000000GOwL-07ru for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 08:07:25 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzBBL-000357-H1; Tue, 23 Apr 2024 10:07:15 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzBBK-00Dq1V-BW; Tue, 23 Apr 2024 10:07:14 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rzBBK-006nfr-0r; Tue, 23 Apr 2024 10:07:14 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin , Sudeep Holla , Anshuman Khandual Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Greg Kroah-Hartman Subject: [PATCH 2/5] coresight: debug: Convert to platform remove callback returning void Date: Tue, 23 Apr 2024 10:06:59 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2147; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=W9VKAaqsnaq3Vzg1avi1vxx/uhnYRc+z2zJhxctEk/s=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmJ2wnOch0b5DoBlz9fvHM0eRISM3BWq6ssrFEe e8fktKx6EOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZidsJwAKCRCPgPtYfRL+ Thn3CACNiWaz06CUaJB8dBBmMRIcMsRDvNH8Mwuj3zmBlR01fInJWdtcQqUqv5uWkFWNwIXsA8x ihxjnCHw18dNuPuq96HWP9dAOzMoS4rWeF01kW4OdKi+fBIzrxZwZDarMwUmB6k27tO8+uLTtsV 0p8bUyd5cN7Ex+fG64GLj9LRF+3J7fmunPRdRyFPoXeOOJh1k4VcYxDqnKRwa7QUr/fsQeL7sUf 3VMbasoA2PF1iC6DaabCiu48IOFUEr8uiYq78qlPSYi0g1aGPC0iU2YqI21NMd1K1yfcxfxBYnM bjWakwnecWKtm4AmLfxLXpxkHDFwHDVEopmJhZx633Z04vQP X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_010722_147884_FEFA4E35 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Fixes: 965edae4e6a2 ("coresight: debug: Move ACPI support from AMBA driver to platform driver") Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-cpu-debug.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c index 3263fc86cb66..75962dae9aa1 100644 --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c @@ -716,18 +716,17 @@ static int debug_platform_probe(struct platform_device *pdev) return ret; } -static int debug_platform_remove(struct platform_device *pdev) +static void debug_platform_remove(struct platform_device *pdev) { struct debug_drvdata *drvdata = dev_get_drvdata(&pdev->dev); if (WARN_ON(!drvdata)) - return -ENODEV; + return; __debug_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!IS_ERR_OR_NULL(drvdata->pclk)) clk_put(drvdata->pclk); - return 0; } #ifdef CONFIG_ACPI @@ -764,7 +763,7 @@ static const struct dev_pm_ops debug_dev_pm_ops = { static struct platform_driver debug_platform_driver = { .probe = debug_platform_probe, - .remove = debug_platform_remove, + .remove_new = debug_platform_remove, .driver = { .name = "coresight-debug-platform", .acpi_match_table = ACPI_PTR(debug_platform_ids), From patchwork Tue Apr 23 08:07:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13639586 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52DF3C4345F for ; Tue, 23 Apr 2024 08:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2tvKMNGi2FYl+yEty211fBsNsVPAUHPhYPZzmabDVRI=; b=3+Wt07yYNZNRat Yc+KfIIRHjNTLO9ncsvDIsF7BxI3o9beFeDikCQTr2WcCGX9taTr5dL3Ky5EDjJmUzCuXBHxEKmnN dRSyWMy8+kf4B325MDJSoQDr96KpRGo5UDcbFF1owrGc0vrWZmgUdsEnrC0U93xUsGPcJf1t/qQLC mA0x6HuFPiQ9x15c3nYJJMhUqzmsnZlntZ/OM6WqYhGTRlEB7wAZ+katj4esM9pGszjfwv5Jzg+RL RPWuVFmnWdMfEqN8cDDVN8ET0H1Z6C4gV0B0DTpEqITarr4/34/JEN0CzdY5BUnoaQkHkldcDJssD eOOfhv+qBMJzh0+IPSoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBo-0000000GP57-1dhC; Tue, 23 Apr 2024 08:07:44 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBT-0000000GOx4-0ykq for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 08:07:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzBBL-000358-JD; Tue, 23 Apr 2024 10:07:15 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzBBK-00Dq1Y-I2; Tue, 23 Apr 2024 10:07:14 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rzBBK-006nfv-1V; Tue, 23 Apr 2024 10:07:14 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Anshuman Khandual , Sudeep Holla Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de, Greg Kroah-Hartman Subject: [PATCH 3/5] coresight: stm: Convert to platform remove callback returning void Date: Tue, 23 Apr 2024 10:07:00 +0200 Message-ID: <3fefa60744fc68c9c4b40aeb69e34cda22582c4b.1713858615.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2082; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=6jj1et03NEbeAAFrK+MkJGJ4zRd04/Wcgxra5zA+vuQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmJ2wol9aHpD6mMPDRKveIJ6x8NgbDf8sNB72sl 2DxjYz27J2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZidsKAAKCRCPgPtYfRL+ TuQSB/9aM2ihAPUtN72QJZb2kgQsH/1X8r6mrqaNXZAA9BED8kRjWGrPMecm8obijzWOWbwgj3v 61+jMl9H0KT4MaNeUw58E1bFB16TkSNRoxjWKD1UgYocLYnhPjHdxbEfTA5qgtJ7sLsJqi94wtY VA/ksJ6v/wC62oc1qRISsOLgpe5PzkejkgmLb8vEloegcD73qHNh2Ui/14AHq5cFn34yCAvYD+w IYluumtU9ck8N9f43GgoZHmGsAznZBVw7ZMvDUkZXErdRpFZUpYWruqvbRlCHoEeyD6f7UqhOmZ NqIb8rDH97KZxpblfWH23tyF5CDzUw0sPWdQeadswDtVaycd X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_010723_293398_EDD2BE1C X-CRM114-Status: GOOD ( 16.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Fixes: 057256aaacc8 ("coresight: stm: Move ACPI support from AMBA driver to platform driver") Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-stm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index cbf7f17556f8..96b1a8cfee14 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -1014,18 +1014,17 @@ static int stm_platform_probe(struct platform_device *pdev) return ret; } -static int stm_platform_remove(struct platform_device *pdev) +static void stm_platform_remove(struct platform_device *pdev) { struct stm_drvdata *drvdata = dev_get_drvdata(&pdev->dev); if (WARN_ON(!drvdata)) - return -ENODEV; + return; __stm_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!IS_ERR_OR_NULL(drvdata->pclk)) clk_put(drvdata->pclk); - return 0; } #ifdef CONFIG_ACPI @@ -1038,7 +1037,7 @@ MODULE_DEVICE_TABLE(acpi, stm_acpi_ids); static struct platform_driver stm_platform_driver = { .probe = stm_platform_probe, - .remove = stm_platform_remove, + .remove_new = stm_platform_remove, .driver = { .name = "coresight-stm-platform", .acpi_match_table = ACPI_PTR(stm_acpi_ids), From patchwork Tue Apr 23 08:07:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13639587 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E501C10F15 for ; Tue, 23 Apr 2024 08:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dcTrbRIWiH4kzyrNEUzH3o/gf02SshiuHt1TLKvID4o=; b=0w2GprSRdhxdmY P7B40dEO7qwdnMQehbpA9A4e/PxAMki22vBLrIrPmY6V55+sJ2rG2VZiOJ7iXE2jrtPyOlbSR/iT7 dMOqmAqzoiEYQauni5g5Q7NvvOwLq7x8xdajW1GszUxRMtqI+daCTxDb4nYpeaOeJfYEKO0300n2+ UH67DDLke0fjV1tsVN2NDpWISpzix5K2qcyuXtbjrQnG5STlvtOzthRt+WEBBeVOom6vw5ZnlsKLm Qfx1I+jQ7Xi2MuJHlCcGJNYPS+v8vihcdqtGdyxojPWOyqByy3Kse501bBcvCZIZ4QC05q7pvmqDm 5wtdjiV0prLNKeukxrJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBp-0000000GP68-29xS; Tue, 23 Apr 2024 08:07:45 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBT-0000000GOwp-0QLM for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 08:07:27 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzBBL-000359-H1; Tue, 23 Apr 2024 10:07:15 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzBBK-00Dq1b-P5; Tue, 23 Apr 2024 10:07:14 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rzBBK-006nfz-2D; Tue, 23 Apr 2024 10:07:14 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin , Anshuman Khandual , Sudeep Holla Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Greg Kroah-Hartman Subject: [PATCH 4/5] coresight: tmc: Convert to platform remove callback returning void Date: Tue, 23 Apr 2024 10:07:01 +0200 Message-ID: <3cf26d85a8d45f0efb07e07f3307a1b435ebf61e.1713858615.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2101; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=OoJNRStSLrqccfR0QEkfFqatKiRfDqr4BLUhHavZyG4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmJ2wpoZbFPBiQMPzqEODC8kwiy07mwzj+G7oNl c5G/N4hLZaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZidsKQAKCRCPgPtYfRL+ Trz4CACnp7B0HA55a6CV1Ok04V+2dtS1+XA9+r2U+JPaY3spVHqe41OGj1xi5FljUpgvwTDxUBf g2jY47UhgyDLQvdVjjxmf7NL9tSiJmxxZxErrqSwf251zPdbVaA73PNSvyNt2dcaOh9iu5ZEj3M REkmTR7ZbjuygAlqUXIzVJH9wTLqzGtuXZ90ULsFkGq34TxEj0jI35+3Wn8fo2PS+C++zhN0ZJ5 wN77tlVdIwUFt54ip71Ie/7J9EdvaQzdJ3Jglv0ZXBV3TKOyUm6SjMTdRxxofS/v0rA5BsRLa22 IAk6h/F/W6jx4X/a65vTHG0cUMcfzoCc0p6Nuw60LT66bJDo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_010723_159335_19ACF88B X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Fixes: 70750e257aab ("coresight: tmc: Move ACPI support from AMBA driver to platform driver") Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-tmc-core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c index c9aaf3567565..4b50d043ce04 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -659,18 +659,17 @@ static int tmc_platform_probe(struct platform_device *pdev) return ret; } -static int tmc_platform_remove(struct platform_device *pdev) +static void tmc_platform_remove(struct platform_device *pdev) { struct tmc_drvdata *drvdata = dev_get_drvdata(&pdev->dev); if (WARN_ON(!drvdata)) - return -ENODEV; + return; __tmc_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!IS_ERR_OR_NULL(drvdata->pclk)) clk_put(drvdata->pclk); - return 0; } #ifdef CONFIG_PM @@ -708,7 +707,7 @@ MODULE_DEVICE_TABLE(acpi, tmc_acpi_ids); static struct platform_driver tmc_platform_driver = { .probe = tmc_platform_probe, - .remove = tmc_platform_remove, + .remove_new = tmc_platform_remove, .driver = { .name = "coresight-tmc-platform", .acpi_match_table = ACPI_PTR(tmc_acpi_ids), From patchwork Tue Apr 23 08:07:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13639589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E07DC04FF8 for ; Tue, 23 Apr 2024 08:08:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IoIzQ5WvqyiOQJdTTVS9BH0AvWV25VA1EqyOdyieYf4=; b=4sMoKeXaSFiQsG wg+GOJl/lyB7Fl8DiSPR9xjermCrk+FpShPrS1k97CIX7msp3bKI9olNJGAiw/0gTqt4wlCNk1vTw hGi10LMi96rN//oMrQa6gqbqXX6bGhu6IMoUqeFTPTcVY1p/OXGS/wJH3bk5mGvSTa0v6Qu7z89Ma aDqgBxAVVPjt6My7G+E035tPz4AWnLFf+HNkr2ZK9G3cLfFcQtlUdyV7eecSlfSU5x+qnTvS4g9dP QSF9tIWTGmSyRl0/a93y3KD5pd3nmBXcBaMjW3Bg5MhaknFPT1VntJqfq3A8+VF+H5FQZiOFkAYgg P+/vO5rbkOh2WkJ2uXxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBq-0000000GP6r-3ee8; Tue, 23 Apr 2024 08:07:46 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzBBY-0000000GOyB-3IDN for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 08:07:30 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzBBL-00035A-H2; Tue, 23 Apr 2024 10:07:15 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzBBL-00Dq1e-1j; Tue, 23 Apr 2024 10:07:15 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rzBBK-006ng3-36; Tue, 23 Apr 2024 10:07:14 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin , Sudeep Holla , Anshuman Khandual Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Greg Kroah-Hartman Subject: [PATCH 5/5] coresight: tpiu: Convert to platform remove callback returning void Date: Tue, 23 Apr 2024 10:07:02 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2096; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=4yDNU8MVKq48/PPwxKQhB1A+zP6kaFxyU8QgR4iOUrE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmJ2wq8WFCFBf3FbwppQtdNJcck2Y7Cy0DDI45N a/TyK84eM6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZidsKgAKCRCPgPtYfRL+ TtDWCACySBGer30IWk+QkI+qnomPSf0fIibrGzOZDkjYZkLrzYspX/XDUnd5dU3ftvwZx0TO1LB 2z+qwkgCQ9yGontDLh8dOSjZY7/ccxtj1MFGRA1JOrwAK09n7WM3TbLEPM4jKwfWns5KXWwn0EM TzlmngNRbmnNYxxx7SKUSRudTztnajkrcMIdUkr0vNQp1KJu432fsxbUzPRtrxP2uvLdcgmqnea XqlK8vfSWxDJZhQWckBrimozKJPKIXUKna/L6wWMNFIncdNSWF0v/4hTASUKd8HGa4YQUGmUN0t hS6zNOz8B3FMxIGrRDE6gG8DNDx0/bWeDIR2NRfDMwBffKGv X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_010728_918509_7CE01FB6 X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Fixes: 3d83d4d4904a ("coresight: tpiu: Move ACPI support from AMBA driver to platform driver") Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-tpiu.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c index 6bf3039839c1..6ecde7d4a25d 100644 --- a/drivers/hwtracing/coresight/coresight-tpiu.c +++ b/drivers/hwtracing/coresight/coresight-tpiu.c @@ -285,18 +285,17 @@ static int tpiu_platform_probe(struct platform_device *pdev) return ret; } -static int tpiu_platform_remove(struct platform_device *pdev) +static void tpiu_platform_remove(struct platform_device *pdev) { struct tpiu_drvdata *drvdata = dev_get_drvdata(&pdev->dev); if (WARN_ON(!drvdata)) - return -ENODEV; + return; __tpiu_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!IS_ERR_OR_NULL(drvdata->pclk)) clk_put(drvdata->pclk); - return 0; } #ifdef CONFIG_ACPI @@ -309,7 +308,7 @@ MODULE_DEVICE_TABLE(acpi, tpiu_acpi_ids); static struct platform_driver tpiu_platform_driver = { .probe = tpiu_platform_probe, - .remove = tpiu_platform_remove, + .remove_new = tpiu_platform_remove, .driver = { .name = "coresight-tpiu-platform", .acpi_match_table = ACPI_PTR(tpiu_acpi_ids),