From patchwork Tue Apr 23 19:23:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13640597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A990BC18E72 for ; Tue, 23 Apr 2024 19:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NqrrYNZMjDRBEOUtxcV4zbAqznrbXahW6xQlIiR/Q2s=; b=qLgjwBOmBLFDZ9 bUmBzrrwqJbEoN0R9lV9RrIvkCnQhAx1LWrdoQDirrsCNTIUJMwAh6kfX/a2L2buniOD7LIY/y4Bi H4GnyEfm3S8/2MJKstbxyVDCooSWOjOoF/8B0jVzQWmvGn1zF4QFsVTAb4R46nFhozLxaImb+fpPI eYLH3S+tekW8MepXui65Tio+6JY4iqndmJGhAx0z3/RFTDRixHPj5c8+a0d8IR0/5ZERJmd3VJrTy TEdBJCYkLzKDch2hxalSLA4clvxeRNmXBtrMd34K0Gm7UvRi+W/nWHGphfDz2vPJ0RP/iKE77r+2K Rq5Zg/tKxvcQaOp0nptw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLlw-00000001Grw-2yKr; Tue, 23 Apr 2024 19:25:44 +0000 Received: from mgamail.intel.com ([198.175.65.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLls-00000001Gox-3fNt; Tue, 23 Apr 2024 19:25:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713900340; x=1745436340; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GFgvUWu7beexxqgqYJWuWc2RAm6vGMhqSdFbjSi68w0=; b=BvYX5OX87epPxmoLcZMpRb/wlwHxGNI9Wg9s77fVhoM56Z1vkyxf97Tp YNFMlJtuh6cG/vMlKtfA1WghFmx88jBg82+VRsCvxJU1M/xTfRGq+gFh7 PTpWV0g3IOgDSV0vMROne/dIOEZaANWGpHCc2oWr06+ucuTRpsX2szGTH 3MrFP6emGh5Jo9BTShxaPK+GPwPTpKzWWRJZx7yW35Sm7eB4G2v5BhVMm nz3ZQLBP0u9U00z9xIQSDxCvFB0sKf/OjXPa5qnhKoEsSUnYKO/xOF2s+ ZUTERMONn7NaNUVSMe9LJ6mxpL08oeSSlHgVVEgY6P/ONfbpRJpzU8S6R g==; X-CSE-ConnectionGUID: P5ZnR1PwRnSj891CJRUiNA== X-CSE-MsgGUID: hWx2NHSrRMKDbN1h0kDRIg== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9669110" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="9669110" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 12:25:36 -0700 X-CSE-ConnectionGUID: LIxgFSoYQRiMXQah94XU/Q== X-CSE-MsgGUID: uRkgrTKnQBm24ipxZkoGzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="61923095" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa001.jf.intel.com with ESMTP; 23 Apr 2024 12:25:32 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id BB7F9142; Tue, 23 Apr 2024 22:25:30 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Rob Herring , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev Cc: Alain Volmat , Hans Verkuil , Mauro Carvalho Chehab , Sean Wang , Sean Young , Matthias Brugger , AngeloGioacchino Del Regno , Patrice Chotard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stefani Seibold , Andrew Morton Subject: [PATCH v2 1/3] media: rc: Add missing io.h Date: Tue, 23 Apr 2024 22:23:08 +0300 Message-ID: <20240423192529.3249134-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240423192529.3249134-1-andriy.shevchenko@linux.intel.com> References: <20240423192529.3249134-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_122541_038441_343D9BF7 X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In many remote control drivers the io.h is implied by others. This is not good as it prevents from cleanups done in other headers. Add missing include. Signed-off-by: Andy Shevchenko --- drivers/media/rc/mtk-cir.c | 1 + drivers/media/rc/serial_ir.c | 1 + drivers/media/rc/st_rc.c | 1 + drivers/media/rc/sunxi-cir.c | 1 + 4 files changed, 4 insertions(+) diff --git a/drivers/media/rc/mtk-cir.c b/drivers/media/rc/mtk-cir.c index 4e294e59d3cb..b2f82b2d1c8d 100644 --- a/drivers/media/rc/mtk-cir.c +++ b/drivers/media/rc/mtk-cir.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/media/rc/serial_ir.c b/drivers/media/rc/serial_ir.c index 96ae0294ac10..fc5fd3927177 100644 --- a/drivers/media/rc/serial_ir.c +++ b/drivers/media/rc/serial_ir.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/media/rc/st_rc.c b/drivers/media/rc/st_rc.c index 28477aa95563..988b09191c4c 100644 --- a/drivers/media/rc/st_rc.c +++ b/drivers/media/rc/st_rc.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c index bf58c965ead8..b49df8355e6b 100644 --- a/drivers/media/rc/sunxi-cir.c +++ b/drivers/media/rc/sunxi-cir.c @@ -12,6 +12,7 @@ #include #include +#include #include #include #include From patchwork Tue Apr 23 19:23:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13640598 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD5FEC4345F for ; Tue, 23 Apr 2024 19:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hmf4PlH2VJkwo6xwChup5t5g9EoDst1EMMXteBLqovg=; b=XJaP88Ik8Czkwa UmcJKurWg1Pd4Ouk8k7OOMZ0L6FW8/XjZInZppIt6OEXZpui4xwFFfghmIma8cfmiiEbR5qrT6GF2 dpSwA4jYOJ3EsJaQOZwLGV74feTyWorfoWZ1shtMJzQWJjpNxXdNNzlyC6cEu3bVi4wQc7WBrmJ4a 4+3ER8icPhkRD3Q8o6me97mQmBiYmhJy1ka5V+LJ8xdYRfkXjY24AJ676ZAH0mo+KXjxLk/I4aGB1 KiEjw1EB5Y69vtkgeVMGbcgFnBNAazyvpGq2OF4pbdq8YwrFAY4lInVxYDe3HOSKDKotR6BcyDGlL L8oWd5cJMBbnJDcfgejQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLmD-00000001H0G-25o9; Tue, 23 Apr 2024 19:26:01 +0000 Received: from mgamail.intel.com ([198.175.65.17]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLlu-00000001Gr4-3FIF; Tue, 23 Apr 2024 19:25:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713900342; x=1745436342; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HTsoFANv6JLEmjESsOo2isIzkzhPyuPDbVVy0uob3Zc=; b=SeafgxBZNbCLOkYSfxmGaSXFGJzexGrCr0KETGfmc0OQhrttQNwqqaLn oLbqQJS+bqhyiPmquj9h6QSNNWmh0GT2+/gZpq3SCx7CDagIn/IHljC7N lxOSi9kM7axMP64TeJkKsgShzsfyVCUFnzpr3aEoNZYNR/5wG3KpnrAqT COpcY3/o7qIH041PGaYs4Gw5R29veRFqfzO0bWUP6O0GabAXeNsALH0HJ IEibvAiMUc7vVS1tELr4rcNN4X8ff2VJuF4w449PEbdvwRQZOoPQ7rEkr yYX8a+lY4f81Sn34gLdfXBPts4goY2R+nHhq9eTrbBjV9TZgcnwI42wFx w==; X-CSE-ConnectionGUID: J+yMBAVtQoKNJO+co/F1+g== X-CSE-MsgGUID: fTt2qPqPSSOkxCSAe1eT1Q== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9613695" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="9613695" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 12:25:36 -0700 X-CSE-ConnectionGUID: jU9dTxssRxCDT9Y4mI+TiA== X-CSE-MsgGUID: owZMSlD9QfSf3MU/LQ5KuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24440743" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa009.jf.intel.com with ESMTP; 23 Apr 2024 12:25:32 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id CA0E244E; Tue, 23 Apr 2024 22:25:30 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Rob Herring , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev Cc: Alain Volmat , Hans Verkuil , Mauro Carvalho Chehab , Sean Wang , Sean Young , Matthias Brugger , AngeloGioacchino Del Regno , Patrice Chotard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stefani Seibold , Andrew Morton Subject: [PATCH v2 2/3] media: stih-cec: Add missing io.h Date: Tue, 23 Apr 2024 22:23:09 +0300 Message-ID: <20240423192529.3249134-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240423192529.3249134-1-andriy.shevchenko@linux.intel.com> References: <20240423192529.3249134-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_122542_904931_DAC6FF77 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the driver the io.h is implied by others. This is not good as it prevents from cleanups done in other headers. Add missing include. Signed-off-by: Andy Shevchenko --- drivers/media/cec/platform/sti/stih-cec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/cec/platform/sti/stih-cec.c b/drivers/media/cec/platform/sti/stih-cec.c index a20fc5c0c88d..99978a7c8d9b 100644 --- a/drivers/media/cec/platform/sti/stih-cec.c +++ b/drivers/media/cec/platform/sti/stih-cec.c @@ -6,6 +6,7 @@ */ #include #include +#include #include #include #include From patchwork Tue Apr 23 19:23:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13640596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 858ABC4345F for ; Tue, 23 Apr 2024 19:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2JNbqbkWPzf3VDNDE2MqCr4/OduljVA+Mp/QCWDixf4=; b=X7M4wwFroQdtda H2y/ALo3gTExeZaogP4/BLLjuiPmHTFLmIJoUsw+hKwD6PaPhlTyUa4T09KscrgL6beJoKv3MqcMW UV9DbxNO7i4fcac5sKjED8+Leszhswxh+ruwb3cYL/PUEHTkGtAjSrPwG/G5plmoRdeLeChgI+331 w65L/NkBaz2zTDrQPalfQyfHB5Rc4K+5x8z/74X+hsor1+PCVqYi6iacvUxsqbpvpNx6EoZh1W/rH CYRGaulp6j1Mj6xPcF4WnFnaYnpcYCexgJkL5MpREmlsmRIQQOmmUho8oKPlKV+06EDUlANZjhs7F gY9XduKo+0N148ZcJ/2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLlv-00000001Grj-2oBl; Tue, 23 Apr 2024 19:25:43 +0000 Received: from mgamail.intel.com ([198.175.65.17]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzLls-00000001Goy-1CmI; Tue, 23 Apr 2024 19:25:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713900340; x=1745436340; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iARSuX9KuhJ/Yd1VAlCEEM5wx1EpDHoBr77TViozzoM=; b=ln7358j+kMP8u8dWEQlZHdH0yfT18RQmQRSGDa/i6+ofMuatAbjF4zYP b2/dLjD0m71DKfPde2RSQMLan7kKVjarmBkkUVLO1Cnbk2KIGyhm2uCEy Qeno1/uLmywEhhTRDEOwEXRVoiUOLu7SNmkuwSzbnEnAkMt0ycJLLVeV4 HxMh7+9thEWApc6WdQcJ8I5UkyaHC5LXW6vB8TXj6ndpkje7tkn/iFvaP DwEaQj7aWly4CrwEyoSBy33FcLFaS9ga0Fn7hbFri0soJLEXgh1DhtO13 XZO5xL6Owx8cmJ94ukmuLUKVFku6QlW/rbEkT8KdUfYi2KwvdRhBjq+YN g==; X-CSE-ConnectionGUID: DpURiXGNTLWuLYKSzl8Bsg== X-CSE-MsgGUID: U20v9JybRjqf9Wna1z0cKA== X-IronPort-AV: E=McAfee;i="6600,9927,11053"; a="9613661" X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="9613661" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2024 12:25:36 -0700 X-CSE-ConnectionGUID: w/ztJlpcRnuDr+9rvjbvpw== X-CSE-MsgGUID: v5WeMhnJTXS6NM71pfP0ZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,222,1708416000"; d="scan'208";a="24440742" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa009.jf.intel.com with ESMTP; 23 Apr 2024 12:25:32 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id D372D489; Tue, 23 Apr 2024 22:25:30 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Rob Herring , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev Cc: Alain Volmat , Hans Verkuil , Mauro Carvalho Chehab , Sean Wang , Sean Young , Matthias Brugger , AngeloGioacchino Del Regno , Patrice Chotard , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Stefani Seibold , Andrew Morton Subject: [PATCH v2 3/3] kfifo: Don't use "proxy" headers Date: Tue, 23 Apr 2024 22:23:10 +0300 Message-ID: <20240423192529.3249134-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240423192529.3249134-1-andriy.shevchenko@linux.intel.com> References: <20240423192529.3249134-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_122540_370119_C3A1DB48 X-CRM114-Status: GOOD ( 10.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Update header inclusions to follow IWYU (Include What You Use) principle. Signed-off-by: Andy Shevchenko --- include/linux/kfifo.h | 9 +++++++-- lib/kfifo.c | 10 +++++----- samples/kfifo/dma-example.c | 3 ++- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h index 0b35a41440ff..6b28d642f332 100644 --- a/include/linux/kfifo.h +++ b/include/linux/kfifo.h @@ -36,10 +36,15 @@ * to lock the reader. */ -#include +#include #include #include -#include +#include + +#include +#include + +struct scatterlist; struct __kfifo { unsigned int in; diff --git a/lib/kfifo.c b/lib/kfifo.c index 12f5a347aa13..15acdee4a8f3 100644 --- a/lib/kfifo.c +++ b/lib/kfifo.c @@ -5,13 +5,13 @@ * Copyright (C) 2009/2010 Stefani Seibold */ -#include -#include -#include #include -#include -#include +#include #include +#include +#include +#include +#include /* * internal helper to calculate the unused elements in a fifo diff --git a/samples/kfifo/dma-example.c b/samples/kfifo/dma-example.c index 0cf27483cb36..74fe915b7ffe 100644 --- a/samples/kfifo/dma-example.c +++ b/samples/kfifo/dma-example.c @@ -6,8 +6,9 @@ */ #include -#include #include +#include +#include /* * This module shows how to handle fifo dma operations.