From patchwork Wed May 1 06:39:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 13650252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CF0DC4345F for ; Wed, 1 May 2024 06:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=L3fzQ+1gPzM9boQjk8PBsnHFc4myflp30rb3PJBk038=; b=R3Y4lEtp7IrQtE Q7szOHhDM9DPchn+3iVmsxExKazeDdRoJo4XF+aVyaQ0RbNIISWUgd5nqYx6dLpkDgJ3bgfUpjJcc rU8Jzae4NzaX8KgKb4H+xDGJ89eSxdRpn/WzcH4jQfivAhGdkjfAlQquDIIYFwsoj1SH5xZ1MGNZd rCsBZ+pxHgdK83pZuDHlQm3r26sI0TKgvXUQ9nPtNkIffZ5EX8LjMM/HV9Qa3nE2G3L5y66gJ8gQd UupxZZRTM7smmGAQwBRdrGhOJywlPiRQhJbpa8Tfq/sN5pLQi/uqPggXFNLnzeaB6MrTJ4fQFMHR8 CF4K76yc8Y3+/56JAVaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s23d2-00000008h7P-0xiv; Wed, 01 May 2024 06:39:44 +0000 Received: from smtp-19.smtpout.orange.fr ([80.12.242.19] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s23cx-00000008h6j-0aV6 for linux-arm-kernel@lists.infradead.org; Wed, 01 May 2024 06:39:42 +0000 Received: from localhost.localdomain ([86.243.17.157]) by smtp.orange.fr with ESMTPA id 23cpsg4WsiGtU23cpsV8pf; Wed, 01 May 2024 08:39:34 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1714545574; bh=M+oQc6JbU4H5ILw/Gp3smalwG/kTbPKlBTcVS0kEisI=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=WnkAf95+yRHSkMlpztZS8xaysBAf3t08wYpfMYHH0R9u0FbYZAvbG3PnynE9rdVQk WvqVpb3yQNf7CLlwv/jv7ns7vvvBk+ew/R8YyN6QSKLKHU28ns1HpEQ0NKPHcB8Oql a47Hil64smDlKkazEwBV4sH9ZtbOfB4fdRXtT1ekiY5D7HX1/gD08mYKZFiid/y6uz KaRB+0tB5cF/FtJSmDdzK+FUBmdw7KlxHEXeK2SjmmDeb5b5v5ZZoCM4N1hEEJHWOr U+7mcdbBu1wj8X3KnBvIivtJeO7h6mQ2mqXypTU3429ooU2ppu8W9Pae4O15liyPVB Orh0/FQA/aNUg== X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 01 May 2024 08:39:34 +0200 X-ME-IP: 86.243.17.157 From: Christophe JAILLET To: Dmitry Torokhov , Vladimir Zapolskiy Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] Input: lpc32xx-keys - Remove an unused field in struct lpc32xx_kscan_drv Date: Wed, 1 May 2024 08:39:23 +0200 Message-ID: X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_233939_606794_5A89F628 X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In "struct lpc32xx_kscan_drv", the 'irq' field is unused. Remove it. Found with cppcheck, unusedStructMember. While at it, move the 'row_shift' field in order to fill a hole in the structure (at least on 64 bits arch). Signed-off-by: Christophe JAILLET --- Compile tested only. It was added in the initial commit 69690bec400e ("Input: add support for key scan interface of the LPC32xx SoC") but was never used. --- drivers/input/keyboard/lpc32xx-keys.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/keyboard/lpc32xx-keys.c b/drivers/input/keyboard/lpc32xx-keys.c index 322a87807159..423035be86fb 100644 --- a/drivers/input/keyboard/lpc32xx-keys.c +++ b/drivers/input/keyboard/lpc32xx-keys.c @@ -57,14 +57,13 @@ struct lpc32xx_kscan_drv { struct input_dev *input; struct clk *clk; void __iomem *kscan_base; - unsigned int irq; u32 matrix_sz; /* Size of matrix in XxY, ie. 3 = 3x3 */ u32 deb_clks; /* Debounce clocks (based on 32KHz clock) */ u32 scan_delay; /* Scan delay (based on 32KHz clock) */ - unsigned short *keymap; /* Pointer to key map for the scan matrix */ unsigned int row_shift; + unsigned short *keymap; /* Pointer to key map for the scan matrix */ u8 lastkeystates[8]; };