From patchwork Fri May 3 05:25:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 13652409 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA7FF2C181 for ; Fri, 3 May 2024 05:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714713926; cv=none; b=kVu0XZd7Dp2RX8pkJcLtheObnh1L5yFECxFtHhsBLvkujjhy0REWQjB/VFMbmIcLJWKHGsHjiiO03Os9y3HnM7fEc/wTFibSegkW3TUdHaHA4ciH3ccXhB+8Dp9X55oiBUCy/WfbBnQFXwpldSUe9Bj45+/2RRZmX+LaqPHn9hw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714713926; c=relaxed/simple; bh=/5uJMQp3yNu8bhBnBFO/iH8SSkGNUC3g8iOpw2JBT38=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c2dmh6isaMhd4DRS6oLdVeirEHXRvK+hyY5XXqAtPXKdZAy59NcnC8kYZ0u5jT8Egl6zfiG/tMgtQxAe+YXG4DMCGowsOql7tZUzrNpPtX7ITO1vSzIXXrKxwSKNBnObUiuS/nGFB+f8QlyP2VsMWK3RaWq63kbVc4xtNnvKIxo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ePGDkfsx; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ePGDkfsx" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6f42924ca64so2005990b3a.2 for ; Thu, 02 May 2024 22:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714713924; x=1715318724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4UbIgVBqQvP02FKP8S0NEy2lwq+MKac1wEMDpbWbGGY=; b=ePGDkfsx9cWAM9GKAqtdaLiv6uHlXy1XMQrUMTwTRnuRi0DzLoG6X3h4xSrPQMFTp+ NIebtNJt267kjcf1IOMCcc3tpSvpnrpL099Zc30HFn7ZlReYIgmbZXNRHmrJdyuDhGui SzFQBGs36UyGxW0/i61FSZ/PA/ilUcMrcczNUS/c771NXicafQshwB3T130HLu4uZxcT b0jdpSANLn9UTqbuHtxUKqsWc9l0dKs//D2SPlCGM0XgObdnzvv7TtP9sXh3gUTGHRhF FXShPX0p0Idu9QbnGQmVrgnX1WRpwX6p1fL91f/2eAGGFAlUeJO+OaoUjRI1qkRoiVEN yunA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714713924; x=1715318724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4UbIgVBqQvP02FKP8S0NEy2lwq+MKac1wEMDpbWbGGY=; b=vEp0/RAhTFo1zY7qrDnoTOR7IkHclOiHCp5mVcP2Wcffm99ZUMJKJb2NmVl20mBnKu 9haj2V2BPuSIVZhxjcYxkReRIdr498u2UtEZGBIAGV0CIL6iTlNXOaNOw2JablLYaQQV QvR7V+mDZdnXJjtjvL/kzNjVwet2ZssrK1unjw2OsxLssIho5Gvjq9cOjlclIlcrTA8d OX3xbk0rLi12dV2e1oufJkNzbTqcxIQUlzzLaH6ZGx2Q2NIIgGElVthwtwGaecc2rKRa TOgWuhsWyJae5hF4gJNBV4jPwXKKCtqViiQchf2AMs4WU8Q1cuhFRki+NyDSIM//Ssv5 Bvow== X-Forwarded-Encrypted: i=1; AJvYcCWOkuT09paPwt3qxnH59bfezePXzEukbT/B0VzyS7MUrdVkoum3unKzkFGQy9l8eUjJzkmnsJHUPS+2hzaLkh8ONz7m X-Gm-Message-State: AOJu0Yw8GKy0xEISzF5jpHtCyxsKf2suoyod4bjtc0bV2qBX/wdusvCH iXEl3AjVVT/yXLcGmt09FQjdFEosG+f1z2ntv536guD/YAKDyCGv X-Google-Smtp-Source: AGHT+IHFYEWop2IhIirSfpH+QcxAMZ7fjLEj89ByiMeJxNxxryk37TEpKcQqrbPMWxGZ8N+d/cyQBQ== X-Received: by 2002:a05:6a00:140f:b0:6ed:4288:650a with SMTP id l15-20020a056a00140f00b006ed4288650amr1560736pfu.19.1714713922965; Thu, 02 May 2024 22:25:22 -0700 (PDT) Received: from wheely.local0.net ([1.146.23.181]) by smtp.gmail.com with ESMTPSA id y21-20020a056a00191500b006ece7bb5636sm2205571pfi.134.2024.05.02.22.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 22:25:22 -0700 (PDT) From: Nicholas Piggin To: Thomas Huth , Andrew Jones Cc: Nicholas Piggin , kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 1/2] shellcheck: Fix shellcheck target with out of tree build Date: Fri, 3 May 2024 15:25:06 +1000 Message-ID: <20240503052510.968229-2-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240503052510.968229-1-npiggin@gmail.com> References: <20240503052510.968229-1-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Prepend source directory to script names, and include source directory in shellcheck search path. Fixes: ddfdcc3929aef ("Add initial shellcheck checking") Signed-off-by: Nicholas Piggin Tested-by: Thomas Huth --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6240d8dfa..b0f7ad08b 100644 --- a/Makefile +++ b/Makefile @@ -143,7 +143,7 @@ cscope: .PHONY: shellcheck shellcheck: - shellcheck -a run_tests.sh */run */efi/run scripts/mkstandalone.sh + shellcheck -P $(SRCDIR) -a $(SRCDIR)/run_tests.sh $(SRCDIR)/*/run $(SRCDIR)/*/efi/run $(SRCDIR)/scripts/mkstandalone.sh .PHONY: tags tags: From patchwork Fri May 3 05:25:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 13652410 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD17E139CE5 for ; Fri, 3 May 2024 05:25:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714713928; cv=none; b=txUdYday+2jAJJnUuYeEung/zy2y+FPpy7UdtSNa3M5W2UeMnfBx4AbYF0P1NWGG2iI9tHUR8KuLdWfwexm3IYFFmQZ+nsD1wQjX1LbGzAc19CbPctnklrcAWelLIlqqRtyCdsUfiLfUl24ZpjpIcIKmQo0NWvwjrUb35N2MDqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714713928; c=relaxed/simple; bh=JeA5mI3vUMr7R/JPmKozJDAF3D/4aqmNm6hY31qIEFw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=paZ2+cHTUqMuR86q9AGuImVhAA6M+jU77H8TdvcPKAbMiO511S06Vc4R/Kb2DUZI/FIAGo7WTzImtBIobDJwZHbAkvyjcwx4f0suFYZaC4as9W+XSfH4O5fszbYfPe1fEKKycQYkRXihJztfTPQaxpKZUVuGIC5lEcggiduEnuE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S7xdoRVA; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S7xdoRVA" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6f42924ca64so2005998b3a.2 for ; Thu, 02 May 2024 22:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714713926; x=1715318726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3yFEwOR14pqnbOrQHNSsBfGSjqz3qQtVBLsgwLzoh18=; b=S7xdoRVAsPJMo4CfwSfvjC574zOoH2oOIi9HlnEO6EHZMtCTbGo6Vjw+AXGOvFel3k hslCGf2g8/anux1QNOrctRU3vNoR2M6u0j4Etd0hQP0P8Rm1LFe213y3jb3zfdo3Jxip bzqiXgoG8//ty6vplCg3OYsTA1vckeleMaXbGZVi/F9SGn+iDMGUlwpmgQVvYKHc0mqq OYOqoHb4gAR+T0a4BjWH8QvsdiE3RM8po/2nfAUxkN2MhxJQ/qUchIbFUyD7UPh5USbU 614A0kQOZ8EAzaqROQw8s6ZbTZJQSHoau6PBLE3Pd6eQlVCWjU5pSWPykaQMdk3IyAQM TS4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714713926; x=1715318726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3yFEwOR14pqnbOrQHNSsBfGSjqz3qQtVBLsgwLzoh18=; b=VA8hN51xSs/jrHKVjkcIk9teA50wOQ499jVLQgJMBwqilT9J1QR1You9hi99naKeOJ ypfOglykGaRkrwSLCOu+o0NYRytv5CZQ74PQRrfiLHsZRvms+3Rbwbx4/EHgwcW4PeSx PdTg0Aajp29kLhZ5OArDOyGs/G6i2HqAsGyIkOHPN19Sp5WrxRhK0B7Ox3tSNhlIMD08 +zjjL8CcVcV8LPLk/4tHdeL4psriNoONo5f2AvtO4J+ElheDzIcXxhuqS1PWyRRICX+8 gOfUjMM1f3+PMFj8ywUp+wL6BPdFZ8QXXbBx5A8u4EmbxdHQvQAEcuSJTWprJEeH8wcr sh+w== X-Forwarded-Encrypted: i=1; AJvYcCXo6J84JZ9zp26arRpCzIduF2c5de8y7CX/Okow2bNEjT6qxTp4d9c0e+SC0Ui9ySAGzg3exRvGTf+lTSLtAAJWJnrD X-Gm-Message-State: AOJu0Yx8NiLAzP6MHe38+UcOMpJlPP3heTM8BaDZCEps819H/wVPApy6 KLdkiUYVf7j3/eX1bGnqb7GrDfg2HAOr3jU3LrMas9tchmVCG1vJ X-Google-Smtp-Source: AGHT+IG5YNdyQwD93MND3nm+K3xCFtMT7ZViZ3Ss2JwTZCMXoihFOunPJgT1NL9ji/scK6s56/ecfw== X-Received: by 2002:a05:6a00:2e14:b0:6ed:e1c:102b with SMTP id fc20-20020a056a002e1400b006ed0e1c102bmr1903008pfb.4.1714713926125; Thu, 02 May 2024 22:25:26 -0700 (PDT) Received: from wheely.local0.net ([1.146.23.181]) by smtp.gmail.com with ESMTPSA id y21-20020a056a00191500b006ece7bb5636sm2205571pfi.134.2024.05.02.22.25.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 22:25:25 -0700 (PDT) From: Nicholas Piggin To: Thomas Huth , Andrew Jones Cc: Nicholas Piggin , kvm@vger.kernel.org Subject: [kvm-unit-tests PATCH 2/2] shellcheck: Suppress SC2209 quoting warning in config.mak Date: Fri, 3 May 2024 15:25:07 +1000 Message-ID: <20240503052510.968229-3-npiggin@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240503052510.968229-1-npiggin@gmail.com> References: <20240503052510.968229-1-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 It's not necessary to quote strings in simple command variables like this where the pattern makes the intention quite clear. config.mak is also included as Makefile, and in that case the quotes do slightly change behaviour (the quotes are used when invoking the command), and is not the typical Makefile style. Signed-off-by: Nicholas Piggin Tested-by: Thomas Huth --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index a8520a35f..0e0a28825 100755 --- a/configure +++ b/configure @@ -420,6 +420,8 @@ ln -sf "$asm" lib/asm cat < config.mak # Shellcheck does not see these are used # shellcheck disable=SC2034 +# Shellcheck can give pointless quoting warnings for some commands +# shellcheck disable=SC2209 SRCDIR=$srcdir PREFIX=$prefix HOST=$host