From patchwork Thu May 9 01:37:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 13659343 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDBF1C04FFE for ; Thu, 9 May 2024 01:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=DxOmtsrRtoKbedzvCbyCMUfdrKhrBCoVf/yC7VXkuF4=; b=ECcMq23Sea9Z4C DNU+Lp3wikhKkiS4zFgKszM2hGXpqQZgph6oWqnn5EJ6gVRZYOM9+vYobvPpuGkgStlsn29TYOk4D gofB+9eQSmB8JH40vRTToPe1ofeMI0peDOhlUgClfWH2wiiZF1E+mpeGEom1HOXu1YtjQIWL+r7WM lVbbNMtVVqBQ0ksfzo3byOMyDUh4jpQZKXTpe6nwHCQv/sOBubocVW4G9QfAKfKWzVfUkQvKjIqo9 f559yisedhkFhvSuTRdZjbKYIuQ9ifC9xI1DDH1mc3Vi9R5EDtUZri6lB3FkG5MS6a/jSl35jpGk4 6BKhJhCEgvS0lXm6OlsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4sj4-0000000HYR6-3eQp; Thu, 09 May 2024 01:37:38 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4sj0-0000000HYPj-3BgW for linux-arm-kernel@lists.infradead.org; Thu, 09 May 2024 01:37:36 +0000 Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-36c791e9faaso1812115ab.1 for ; Wed, 08 May 2024 18:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1715218649; x=1715823449; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=w8nEiAnrrvoqrUnhic8kVR/TQCD7dz1dJX6ammFBF+s=; b=D6B8Gz2/O8hA6Whs/sWrovn1Ev3Uij1/VpZSfNH5tHVfAB5XKk5mEAKaiVzLQIe/U6 TLSfbgadX7ycx7fsIBBZXF+bZjtS1znjcxZYh7lmXadqQVFG45wcWP5OfxKNdirU1smw +doy3VgKSb/8n3R+LxU4ml795uZIeH8XiGoWJwljhQ2fXcHmJUI9175ZcNUa/1dYbaN/ ylzo3GWrH0o7I98+azlrzDn3mtcOZ97X3B/5L6UwLU17+9ZyMwpbUH7dKRUzcZ1d6xUB U36+13rbhTjapJXHWiMCAIn6/3mYZS6Ly3jJF2yxCQL9n1kBrzR6ZIs/8n/E5UUrr+HB UgOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715218649; x=1715823449; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w8nEiAnrrvoqrUnhic8kVR/TQCD7dz1dJX6ammFBF+s=; b=C2w6RsTwPnkx8bUn5jlxHKiJ4daIVg6Uis2o90u1SjsPjVUYqNE1DTB/4tv1mb8AVa OGROTtIfyIburFsK0jgY3sdLUbMsu4qgzJWVZ7oj26W+k4MzWVqottNzTLndf3yBO/Hs TxVttadE5cCVBV5laGtmoo1fLchia6eZL2zdiuDhiOAu6pJQbwPLhteXwDp4qOWZS+uO ETKqoxlGTL8VE/wbII0gdiH6Wn94AYL18eEvrdzOLI/Cl4RKGRxr/CEwLG9JOhHkfAbM gziqbGrq0kdcHebcVEW0ZT7yKYfCHa/1CV+bgW7e3JFChBLCIMqbu7QaxAEZeeUA5fTl YkcA== X-Forwarded-Encrypted: i=1; AJvYcCVaweQIaDn5DWrkElE6oHf6UoRjKrVYcTIZaK8cElwb8wCN11vV1leTQYdzMD+u77/dsov92aMWjwQD+P35TJ/nfiJFFH38C35Lzaq+1AVe/Q2y2pc= X-Gm-Message-State: AOJu0YzAunHQ8XktoGgDs1lAO/jFFrlWBUR7kZH2IV7yWJeHMekDjtlC ARxzt89lQOz2iU8pW9YfXu4aR8Nbn4Av5pWfmRDBlFqRiznkbTNAdugq0bP9hGo= X-Google-Smtp-Source: AGHT+IHpSD4lyUmHxlYUauGGuGqZjazTVD9fSRC10uwBI/bVjd4EXQ/hPAJ0qb89iSq4E50z09RmTg== X-Received: by 2002:a05:6e02:20ea:b0:36c:4688:85aa with SMTP id e9e14a558f8ab-36caece2c35mr49616085ab.10.1715218649330; Wed, 08 May 2024 18:37:29 -0700 (PDT) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-634117191f1sm178084a12.90.2024.05.08.18.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 18:37:28 -0700 (PDT) From: Samuel Holland To: Andrew Morton , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Samuel Holland , Thiago Jung Bauermann , kernel test robot , Ard Biesheuvel , Andrew Davis , Arnd Bergmann , =?utf-8?q?Christi?= =?utf-8?q?an_K=C3=B6nig?= , Eric DeVolder , Rob Herring , Russell King , Thomas Gleixner Subject: [PATCH] ARM: Do not select ARCH_HAS_KERNEL_FPU_SUPPORT Date: Wed, 8 May 2024 18:37:10 -0700 Message-ID: <20240509013727.648600-1-samuel.holland@sifive.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240508_183734_943590_C731B243 X-CRM114-Status: GOOD ( 13.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 32-bit ARM, conversions between `double` and `long long` require runtime library support. Since the kernel does not currently provide this library support, the amdgpu driver fails to build: ERROR: modpost: "__aeabi_l2d" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: modpost: "__aeabi_d2ulz" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! As Arnd reports, there are likely no 32-bit ARM platforms which can use the amdgpu driver anyway, due to lack of features like 64-bit prefetchable BARs. Since amdgpu is currently the only real user of ARCH_HAS_KERNEL_FPU_SUPPORT, drop support for this option instead of bothering to implement the library functions. Fixes: 12624fe2d707 ("ARM: implement ARCH_HAS_KERNEL_FPU_SUPPORT") Reported-by: Thiago Jung Bauermann Closes: https://lore.kernel.org/lkml/87wmp4oo3y.fsf@linaro.org/ Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404042327.jRpt81kP-lkp@intel.com/ Suggested-by: Ard Biesheuvel Signed-off-by: Samuel Holland --- arch/arm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index b1751c2cab87..b14aed3a17ab 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -15,7 +15,6 @@ config ARM select ARCH_HAS_FORTIFY_SOURCE select ARCH_HAS_KEEPINITRD select ARCH_HAS_KCOV - select ARCH_HAS_KERNEL_FPU_SUPPORT if KERNEL_MODE_NEON select ARCH_HAS_MEMBARRIER_SYNC_CORE select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE select ARCH_HAS_PTE_SPECIAL if ARM_LPAE