From patchwork Fri May 10 15:58:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zijian Zhang X-Patchwork-Id: 13661777 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4779017277F for ; Fri, 10 May 2024 15:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356771; cv=none; b=p+C/+DQrEgC6dn1gOHC86CSGC3KKIOT9wGYU68cu2WjkX1vEriboILmPWx8vJ2XrgBOxf9jDFBrg5A5/lTBgIQL1+PtxTP5KwGXDMigF6y3XkptgwL+W8Vv4DHwuzm7JQkKPjOwt55SYdTDG+zTgFP7tTKk9aGnKNztYi8uBb14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356771; c=relaxed/simple; bh=dNWcyM476OH0vYBSo/Kk3Jx7KuSnoow7Mr3DNeSolcA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SNt/UQ/7CWxA5I0ThcLy8Fr937oPEKvN6ynJnyy8Y0o+u3BA0nhRcyFpggJpl4boTZYIJp3OaqiMJpi+9z8gDXle5IxqIHieGnXjwoWhUy5A6MgL56xDrXx31l7RSXB4eEcclDd5nVODbgpJ1Ob7l+kys2INkKA/pu6/DnrIVDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=A4v0glSv; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="A4v0glSv" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-792b8c9046bso169958585a.3 for ; Fri, 10 May 2024 08:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1715356767; x=1715961567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rabWcKhADufYxgChzwdAanqzucOdi69JhATOYQQ8ag4=; b=A4v0glSv+Y96SQr9tjMAE0MouzSX3kabegNOCaXxdizWb+mGzWIUiA+26vkZVHoggs wETtHgZlZzOA+S7rvT3YUMvO0eH+5IH/tHqAD0jTiWCABqk1KKJbqRJb4gsdyB3UXnU8 J3Y4uW5EHy4nZ47AB1eaXPjbJbMJBeArUcwdeBzM3/1h79/cgFI3ZWE+a/nwUT/J5m+O 48gX2jmVEjWqxqpXhPU94P9o4B1M7uAGbWWon/1zhZe9oZ6qiJpEO+eoQD+FtSot6lgW zieuHsYReLdVT8XfZGdEFlgeBx0ijTkex3Yl+NsHm9MKIIWf4CMmQ3UTY03Ps9t9Bm9G 6ZLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715356767; x=1715961567; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rabWcKhADufYxgChzwdAanqzucOdi69JhATOYQQ8ag4=; b=p276zYYVEUoozJOCXwZKaGhsLQin1Gh9B6a0lI5j7iHqKhFZTIUr7riXmEA4HJdSvG sZCORv5wp7QfXa4H3/oZCyDwdyYGwlgYaLu/44GsQUTvQYfWg0qTEisVkAUxPIlVFJs7 GrCjqJbxaeWjn0d/+TbTQQDnFl/H86115UAZBf+huIGvc3rNln2CrIGtDkxpErCIqQ/9 Amjkm+/zS9AQVCIG9fRke3d4V8bK39yb7e5LIYjsZevCxkkUR3lWI89e3IofR55Bm7+u s4LDreSlTPEiLG+kc2uT1FJAQuHSjz2rPXVflpMTMrnhddc2qnKFDy/EPGYlhKTVV4h4 uYVw== X-Gm-Message-State: AOJu0YzTWIz3aOKuVPjf+Cqvfl2d2nxKEduku4/cJF22iUtwZwlyjCEO lHb/mjHWRJcoX2anMv2ASrCYbKvZpmvwQ+jWznuumoqGIdRA3WOar2WKqEndsSpzzTK38HUsqS6 Y X-Google-Smtp-Source: AGHT+IGfoqc2OLCOIDV0TbHDnHqiMYv1lxqvI74HmMvM1QTYu3gtS82MWT1dk7qUI29Vna3Upw9rcg== X-Received: by 2002:a05:620a:4607:b0:790:a304:f420 with SMTP id af79cd13be357-792c7577211mr390267685a.12.1715356767448; Fri, 10 May 2024 08:59:27 -0700 (PDT) Received: from n191-036-066.byted.org ([147.160.184.94]) by smtp.gmail.com with ESMTPSA id af79cd13be357-792bf32e705sm191553285a.124.2024.05.10.08.59.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 08:59:27 -0700 (PDT) From: zijianzhang@bytedance.com To: netdev@vger.kernel.org Cc: edumazet@google.com, willemdebruijn.kernel@gmail.com, cong.wang@bytedance.com, xiaochun.lu@bytedance.com, Zijian Zhang Subject: [PATCH net-next v3 1/3] selftests: fix OOM problem in msg_zerocopy selftest Date: Fri, 10 May 2024 15:58:58 +0000 Message-Id: <20240510155900.1825946-2-zijianzhang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240510155900.1825946-1-zijianzhang@bytedance.com> References: <20240510155900.1825946-1-zijianzhang@bytedance.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Zijian Zhang In selftests/net/msg_zerocopy.c, it has a while loop keeps calling sendmsg on a socket with MSG_ZEROCOPY flag, and it will recv the notifications until the socket is not writable. Typically, it will start the receiving process after around 30+ sendmsgs. However, because of the commit dfa2f0483360 ("tcp: get rid of sysctl_tcp_adv_win_scale") the sender is always writable and does not get any chance to run recv notifications. The selftest always exits with OUT_OF_MEMORY because the memory used by opt_skb exceeds the core.sysctl_optmem_max. According to our experiments, this problem can be mitigated by open the DEBUG_LOCKDEP configuration for the kernel. But it will makes the notifications disordered even in good commits before commit dfa2f0483360 ("tcp: get rid of sysctl_tcp_adv_win_scale"). We introduce "cfg_notification_limit" to force sender to receive notifications after some number of sendmsgs. And, notifications may not come in order, because of the reason we present above. We have order checking code managed by cfg_verbose. Signed-off-by: Zijian Zhang Signed-off-by: Xiaochun Lu --- tools/testing/selftests/net/msg_zerocopy.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/msg_zerocopy.c b/tools/testing/selftests/net/msg_zerocopy.c index bdc03a2097e8..ba6c257f689c 100644 --- a/tools/testing/selftests/net/msg_zerocopy.c +++ b/tools/testing/selftests/net/msg_zerocopy.c @@ -85,6 +85,7 @@ static bool cfg_rx; static int cfg_runtime_ms = 4200; static int cfg_verbose; static int cfg_waittime_ms = 500; +static int cfg_notification_limit = 32; static bool cfg_zerocopy; static socklen_t cfg_alen; @@ -95,6 +96,8 @@ static char payload[IP_MAXPACKET]; static long packets, bytes, completions, expected_completions; static int zerocopied = -1; static uint32_t next_completion; +/* The number of sendmsgs which have not received notified yet */ +static uint32_t sendmsg_counter; static unsigned long gettimeofday_ms(void) { @@ -208,6 +211,7 @@ static bool do_sendmsg(int fd, struct msghdr *msg, bool do_zerocopy, int domain) error(1, errno, "send"); if (cfg_verbose && ret != len) fprintf(stderr, "send: ret=%u != %u\n", ret, len); + sendmsg_counter++; if (len) { packets++; @@ -435,7 +439,7 @@ static bool do_recv_completion(int fd, int domain) /* Detect notification gaps. These should not happen often, if at all. * Gaps can occur due to drops, reordering and retransmissions. */ - if (lo != next_completion) + if (cfg_verbose && lo != next_completion) fprintf(stderr, "gap: %u..%u does not append to %u\n", lo, hi, next_completion); next_completion = hi + 1; @@ -460,6 +464,7 @@ static bool do_recv_completion(int fd, int domain) static void do_recv_completions(int fd, int domain) { while (do_recv_completion(fd, domain)) {} + sendmsg_counter = 0; } /* Wait for all remaining completions on the errqueue */ @@ -549,6 +554,9 @@ static void do_tx(int domain, int type, int protocol) else do_sendmsg(fd, &msg, cfg_zerocopy, domain); + if (cfg_zerocopy && sendmsg_counter >= cfg_notification_limit) + do_recv_completions(fd, domain); + while (!do_poll(fd, POLLOUT)) { if (cfg_zerocopy) do_recv_completions(fd, domain); @@ -708,7 +716,7 @@ static void parse_opts(int argc, char **argv) cfg_payload_len = max_payload_len; - while ((c = getopt(argc, argv, "46c:C:D:i:mp:rs:S:t:vz")) != -1) { + while ((c = getopt(argc, argv, "46c:C:D:i:l:mp:rs:S:t:vz")) != -1) { switch (c) { case '4': if (cfg_family != PF_UNSPEC) @@ -736,6 +744,9 @@ static void parse_opts(int argc, char **argv) if (cfg_ifindex == 0) error(1, errno, "invalid iface: %s", optarg); break; + case 'l': + cfg_notification_limit = strtoul(optarg, NULL, 0); + break; case 'm': cfg_cork_mixed = true; break; From patchwork Fri May 10 15:58:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zijian Zhang X-Patchwork-Id: 13661778 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 621AD173354 for ; Fri, 10 May 2024 15:59:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356772; cv=none; b=ReTQqB66U2h44yy1s48ik5r5KqKa+R/O2E9PKPxOyQT/VZgZY0puNm6PKwCvgUXrBFwknT8Ju5gN89kzqNMk9xx36JXaw2HR39rXo5dv2SUpL/Qw/k0/r3AAso3oK+WGxXyffcet5GyGJgu6uWn+DPbigE+gE8ZEMJleVMFRM/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356772; c=relaxed/simple; bh=18S9LTZioOr8vyhuZZFKi/3v1ZpLd/o3kZArFfN2lZM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZVQDvYBMbOoGH7+xkrIoLEk92ZRvCCBjaPdv4g7wThEXGyocLB1RBTlSBxUUSfEtvYtRyTavTShGHNPS9khbnNciMvlESaKq94CczezV66Ql8EjSqmk7zKLsjzlZqbVnuJGvcTVX9yZSV47ZXVMRNBGMZLZym00sp2Adt7CrjhE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=TtkxjV33; arc=none smtp.client-ip=209.85.219.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="TtkxjV33" Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-de60a51fe21so2186819276.0 for ; Fri, 10 May 2024 08:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1715356769; x=1715961569; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MnnGsDOk+brIvVnCkoZvqvDB9cWsR4hPxVXZ4DrMfqo=; b=TtkxjV3319DiHv6UnNjzikbuncXmpnttsnRYOllW8++D238Umua0iaZDkIO8KJkz4x HK6Bu4vYDBa9MnS2qdXDtiHNDk6YnzXMWZgLwIraoV7Z+nHVyBNnjhpPvSbTus6djjW5 wVHkxB2Urlyi2UueIWbZkokJ1MDMlMASJXA8mOzfXndQhQKkKMWq9aXwBSassIhe04U5 QPWHkXaiWLX4uBguoeF3iurYH4RxP8UvWA3txcsxrudFEWibfAHhKrUikZKdV9M/eZEr JpByh0Gz53rpV00XaUQGOzTuRt9D2qHRSFfHgaJqRDSCJcv1hxokF3PBML50mGFZfezN 2pzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715356769; x=1715961569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MnnGsDOk+brIvVnCkoZvqvDB9cWsR4hPxVXZ4DrMfqo=; b=HuwcawYncPreGT7hA+Zmi2qHRiIeSh+zeu6xMp0gcWym3PcJFbDlhOeTGKP3eMsSDi aCGPadD9HtB6f9aaVuAcnjrp0GCQ/jQ8uHCwEiS9fqImbpRJwyi0o1EqNRKhtjblxuNU 2noR9JUxUoTxV7oT5114OUtLpfnVNoq1vrbn2OjfyIZRc2/vVsrPf1NFtF9MN/asNZca sLqPWrQl6hbeBxWL8dl6nq2JsSC8OnaFVRA2Pg/GBz2J3TYcaRcZL/vJvT7eif0241dO U3UE21nC7hJgyGy6fRFfascMNHUbqhh7R7dX+KkykNvALu8WG3XCVXQ8M+hHnfXeFPfY TT+w== X-Gm-Message-State: AOJu0YyyP+loKIgTjT6q2RTQPy1YSCsitLHXuvbWUszkUE1y5CLPj0Na 27dzEMibIlBnJ5HRJg2HsymcXdJmbvduLQk5oGfFuDOaAQOitE2ukG5HgksCmsHF4lhuQDJhVSk + X-Google-Smtp-Source: AGHT+IHR8aPK7+kLeSbsBqLWkzGkVp2IJ64uGTZVGpGZV/8RfC4VyZn86gv6ZoFLCWcbmmNW/xcqjw== X-Received: by 2002:a25:dc87:0:b0:dc6:d87c:fc73 with SMTP id 3f1490d57ef6-dee4f35b7c8mr3549191276.35.1715356769069; Fri, 10 May 2024 08:59:29 -0700 (PDT) Received: from n191-036-066.byted.org ([147.160.184.94]) by smtp.gmail.com with ESMTPSA id af79cd13be357-792bf32e705sm191553285a.124.2024.05.10.08.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 08:59:28 -0700 (PDT) From: zijianzhang@bytedance.com To: netdev@vger.kernel.org Cc: edumazet@google.com, willemdebruijn.kernel@gmail.com, cong.wang@bytedance.com, xiaochun.lu@bytedance.com, Zijian Zhang Subject: [PATCH net-next v3 2/3] sock: add MSG_ZEROCOPY notification mechanism based on msg_control Date: Fri, 10 May 2024 15:58:59 +0000 Message-Id: <20240510155900.1825946-3-zijianzhang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240510155900.1825946-1-zijianzhang@bytedance.com> References: <20240510155900.1825946-1-zijianzhang@bytedance.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Zijian Zhang The MSG_ZEROCOPY flag enables copy avoidance for socket send calls. However, zerocopy is not a free lunch. Apart from the management of user pages, the combination of poll + recvmsg to receive notifications incurs unignorable overhead in the applications. The overhead of such sometimes might be more than the CPU savings from zerocopy. We try to solve this problem with a new notification mechanism based on msgcontrol. This new mechanism aims to reduce the overhead associated with receiving notifications by embedding them directly into user arguments passed with each sendmsg control message. By doing so, we can significantly reduce the complexity and overhead for managing notifications. In an ideal pattern, the user will keep calling sendmsg with SCM_ZC_NOTIFICATION msg_control, and the notification will be delivered as soon as possible. Signed-off-by: Zijian Zhang Signed-off-by: Xiaochun Lu --- arch/alpha/include/uapi/asm/socket.h | 2 + arch/mips/include/uapi/asm/socket.h | 2 + arch/parisc/include/uapi/asm/socket.h | 2 + arch/sparc/include/uapi/asm/socket.h | 2 + include/uapi/asm-generic/socket.h | 2 + include/uapi/linux/socket.h | 10 ++++ net/core/sock.c | 68 +++++++++++++++++++++++++++ 7 files changed, 88 insertions(+) diff --git a/arch/alpha/include/uapi/asm/socket.h b/arch/alpha/include/uapi/asm/socket.h index e94f621903fe..7761a4e0ea2c 100644 --- a/arch/alpha/include/uapi/asm/socket.h +++ b/arch/alpha/include/uapi/asm/socket.h @@ -140,6 +140,8 @@ #define SO_PASSPIDFD 76 #define SO_PEERPIDFD 77 +#define SCM_ZC_NOTIFICATION 78 + #if !defined(__KERNEL__) #if __BITS_PER_LONG == 64 diff --git a/arch/mips/include/uapi/asm/socket.h b/arch/mips/include/uapi/asm/socket.h index 60ebaed28a4c..89edc51380f0 100644 --- a/arch/mips/include/uapi/asm/socket.h +++ b/arch/mips/include/uapi/asm/socket.h @@ -151,6 +151,8 @@ #define SO_PASSPIDFD 76 #define SO_PEERPIDFD 77 +#define SCM_ZC_NOTIFICATION 78 + #if !defined(__KERNEL__) #if __BITS_PER_LONG == 64 diff --git a/arch/parisc/include/uapi/asm/socket.h b/arch/parisc/include/uapi/asm/socket.h index be264c2b1a11..2911b43e6a9d 100644 --- a/arch/parisc/include/uapi/asm/socket.h +++ b/arch/parisc/include/uapi/asm/socket.h @@ -132,6 +132,8 @@ #define SO_PASSPIDFD 0x404A #define SO_PEERPIDFD 0x404B +#define SCM_ZC_NOTIFICATION 0x404C + #if !defined(__KERNEL__) #if __BITS_PER_LONG == 64 diff --git a/arch/sparc/include/uapi/asm/socket.h b/arch/sparc/include/uapi/asm/socket.h index 682da3714686..dc045e87cc8e 100644 --- a/arch/sparc/include/uapi/asm/socket.h +++ b/arch/sparc/include/uapi/asm/socket.h @@ -133,6 +133,8 @@ #define SO_PASSPIDFD 0x0055 #define SO_PEERPIDFD 0x0056 +#define SCM_ZC_NOTIFICATION 0x0057 + #if !defined(__KERNEL__) diff --git a/include/uapi/asm-generic/socket.h b/include/uapi/asm-generic/socket.h index 8ce8a39a1e5f..7474c8a244bc 100644 --- a/include/uapi/asm-generic/socket.h +++ b/include/uapi/asm-generic/socket.h @@ -135,6 +135,8 @@ #define SO_PASSPIDFD 76 #define SO_PEERPIDFD 77 +#define SCM_ZC_NOTIFICATION 78 + #if !defined(__KERNEL__) #if __BITS_PER_LONG == 64 || (defined(__x86_64__) && defined(__ILP32__)) diff --git a/include/uapi/linux/socket.h b/include/uapi/linux/socket.h index d3fcd3b5ec53..15cec8819f34 100644 --- a/include/uapi/linux/socket.h +++ b/include/uapi/linux/socket.h @@ -2,6 +2,8 @@ #ifndef _UAPI_LINUX_SOCKET_H #define _UAPI_LINUX_SOCKET_H +#include + /* * Desired design of maximum size and alignment (see RFC2553) */ @@ -35,4 +37,12 @@ struct __kernel_sockaddr_storage { #define SOCK_TXREHASH_DISABLED 0 #define SOCK_TXREHASH_ENABLED 1 +#define SOCK_ZC_INFO_MAX 128 + +struct zc_info_elem { + __u32 lo; + __u32 hi; + __u8 zerocopy; +}; + #endif /* _UAPI_LINUX_SOCKET_H */ diff --git a/net/core/sock.c b/net/core/sock.c index 8d6e638b5426..15da609be026 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -2842,6 +2842,74 @@ int __sock_cmsg_send(struct sock *sk, struct cmsghdr *cmsg, case SCM_RIGHTS: case SCM_CREDENTIALS: break; + case SCM_ZC_NOTIFICATION: { + int ret, i = 0; + int cmsg_data_len, zc_info_elem_num; + void __user *usr_addr; + struct zc_info_elem zc_info_kern[SOCK_ZC_INFO_MAX]; + unsigned long flags; + struct sk_buff_head *q, local_q; + struct sk_buff *skb, *tmp; + struct sock_exterr_skb *serr; + + if (!sock_flag(sk, SOCK_ZEROCOPY) || sk->sk_family == PF_RDS) + return -EINVAL; + + cmsg_data_len = cmsg->cmsg_len - sizeof(struct cmsghdr); + if (cmsg_data_len % sizeof(struct zc_info_elem)) + return -EINVAL; + + zc_info_elem_num = cmsg_data_len / sizeof(struct zc_info_elem); + if (!zc_info_elem_num || zc_info_elem_num > SOCK_ZC_INFO_MAX) + return -EINVAL; + + if (in_compat_syscall()) + usr_addr = compat_ptr(*(compat_uptr_t *)CMSG_DATA(cmsg)); + else + usr_addr = (void __user *)*(void **)CMSG_DATA(cmsg); + if (!access_ok(usr_addr, cmsg_data_len)) + return -EFAULT; + + q = &sk->sk_error_queue; + skb_queue_head_init(&local_q); + spin_lock_irqsave(&q->lock, flags); + skb = skb_peek(q); + while (skb && i < zc_info_elem_num) { + struct sk_buff *skb_next = skb_peek_next(skb, q); + + serr = SKB_EXT_ERR(skb); + if (serr->ee.ee_errno == 0 && + serr->ee.ee_origin == SO_EE_ORIGIN_ZEROCOPY) { + zc_info_kern[i].hi = serr->ee.ee_data; + zc_info_kern[i].lo = serr->ee.ee_info; + zc_info_kern[i].zerocopy = !(serr->ee.ee_code + & SO_EE_CODE_ZEROCOPY_COPIED); + __skb_unlink(skb, q); + __skb_queue_tail(&local_q, skb); + i++; + } + skb = skb_next; + } + spin_unlock_irqrestore(&q->lock, flags); + + ret = copy_to_user(usr_addr, + zc_info_kern, + i * sizeof(struct zc_info_elem)); + + if (unlikely(ret)) { + spin_lock_irqsave(&q->lock, flags); + skb_queue_reverse_walk_safe(&local_q, skb, tmp) { + __skb_unlink(skb, &local_q); + __skb_queue_head(q, skb); + } + spin_unlock_irqrestore(&q->lock, flags); + return -EFAULT; + } + + while ((skb = __skb_dequeue(&local_q))) + consume_skb(skb); + break; + } default: return -EINVAL; } From patchwork Fri May 10 15:59:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zijian Zhang X-Patchwork-Id: 13661779 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A11D3174ED1 for ; Fri, 10 May 2024 15:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356774; cv=none; b=tXXjQCWqh1v+xJ4HKAaTLazNbmPzJMDARjguP0PzoKU2mrKpcPYUFcwLerUMz9JLaxxzNeYc2GrLRFumfwcTfwqYMOL02loeXX/dczfvd9fXxFgwQ6r+P9TQmt05C7/BvqmaCS15WiNcnIXfh47Q5BnVAS/B/RVJjgJBEtmaDmA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356774; c=relaxed/simple; bh=4yfs2Nl8yUORfU9xJ0tw5I5G5B1ggqQ/R8KCWZZrVlA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IRLFx0vyTiflwp91weWtjHdadCEPY3gGXpNzNG3RY5seH1Gf5oyYV0CRc2s0GePDrVaf5jdfljQZ85yxUFb+wyzMEhYq0+TQwyN89YjP2tFyXrmRWmUnu+Y6uT3nQANPot4nh3wULjZVOP397k7MDepENIy58KUV5NSX02f9kvY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=Z9g3CTXx; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="Z9g3CTXx" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-792b8d989e4so165049885a.2 for ; Fri, 10 May 2024 08:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1715356771; x=1715961571; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hSMjgtZl0FFUIBNXq0ZFWaWaR2txjAdQiVKI/+fWLPg=; b=Z9g3CTXxB8W30hyQRcxtwm1X2/QpIZ5gHpW9SNBR1nZ9Cc6F4ESIrTZa96IJ/C+UDq 1+ExEN9aUzwk1mZOGUO4uDmGN7mydiZnsEkan+NOfocJowRUsCdQfNAk2KIlhP1z9HMT SGzI7yUiCq9csEtsCzlfA9VABe/SK56YVrVKeN+Q1KtayCGpbIMEukfoEYoWPSCjySjK sANDCgcX/eqoHM8wMoxqE4SOVM2SzVfkghaAltseZjoZH6gqA3zMZ48v1arFxw+MgFfr 2Bt8m74DhNjPh3yR6dY84P6Q10CcmdRCDtjx2kn6iX1qV6fSUWONV5ImpT5l0UCZ3eZW Jwiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715356771; x=1715961571; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hSMjgtZl0FFUIBNXq0ZFWaWaR2txjAdQiVKI/+fWLPg=; b=IzvJl4rLgGPlQUszP+qSbis39gYwY46mS5kup6bbubx9XmW2pB58ZREcSFq8XpPVws znYBK2F+Dh0A7jdPWtDaKTmmFONy4ZpTRLEXNyi9RonbqrDTmV5qRxOez1DGqmrIHpEi G3AECx4JZGTuUfsQFc/G9ZqYEdlFwxDHwbD1auer12+7rjCKseCYgRUC1I6PraZERNZ2 XU4hNoh4lHSAUXCQH/2riNjoxeepleisr3prsDnCMfZ8T8D9z69Gc7VpgHyE0OEQAN7r UX77adMbT+rTriKYD2DysRihX8HDqt1uVJG0kAZdwn2n7nkNuTbRbkBKzCdsG5VQynNg INOQ== X-Gm-Message-State: AOJu0YziSkhxBo3sekPDERyXnUDj+BtonqKXbpW839DY2MB3fhZH9wa8 dbEDxREoER8fBcTX/+pNtetSRz0IXjfDAPaFByTolB/n6ZLyN7acSa+f3S/yocrCA/WsMrfAAt2 l X-Google-Smtp-Source: AGHT+IFZjrQL28a0naaKiYCUVVWD9ftq1ke0skfCCcj5IZZ8wR48ODmN3rY8iu1cIeS4k+so58iC+g== X-Received: by 2002:a05:620a:2552:b0:78e:fd7d:6b07 with SMTP id af79cd13be357-792c760369emr327150585a.69.1715356770767; Fri, 10 May 2024 08:59:30 -0700 (PDT) Received: from n191-036-066.byted.org ([147.160.184.94]) by smtp.gmail.com with ESMTPSA id af79cd13be357-792bf32e705sm191553285a.124.2024.05.10.08.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 08:59:30 -0700 (PDT) From: zijianzhang@bytedance.com To: netdev@vger.kernel.org Cc: edumazet@google.com, willemdebruijn.kernel@gmail.com, cong.wang@bytedance.com, xiaochun.lu@bytedance.com, Zijian Zhang Subject: [PATCH net-next v3 3/3] selftests: add MSG_ZEROCOPY msg_control notification test Date: Fri, 10 May 2024 15:59:00 +0000 Message-Id: <20240510155900.1825946-4-zijianzhang@bytedance.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20240510155900.1825946-1-zijianzhang@bytedance.com> References: <20240510155900.1825946-1-zijianzhang@bytedance.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Zijian Zhang We update selftests/net/msg_zerocopy.c to accommodate the new mechanism. Test result from selftests/net/msg_zerocopy.c, cfg_notification_limit = 1, in this case MSG_ZEROCOPY approximately aligns with the semantics of MSG_ZEROCOPY_UARG. In this case, the new flag has around 13% cpu savings in TCP and 18% cpu savings in UDP. +---------------------+---------+---------+---------+---------+ | Test Type / Protocol| TCP v4 | TCP v6 | UDP v4 | UDP v6 | +---------------------+---------+---------+---------+---------+ | ZCopy (MB) | 5147 | 4885 | 7489 | 7854 | +---------------------+---------+---------+---------+---------+ | New ZCopy (MB) | 5859 | 5505 | 9053 | 9236 | +---------------------+---------+---------+---------+---------+ | New ZCopy / ZCopy | 113.83% | 112.69% | 120.88% | 117.59% | +---------------------+---------+---------+---------+---------+ cfg_notification_limit = 32, it means less poll + recvmsg overhead, the new mechanism performs 8% better in TCP. For UDP, no obvious performance gain is observed and sometimes may lead to degradation. Thus, if users don't need to retrieve the notification ASAP in UDP, the original mechanism is preferred. +---------------------+---------+---------+---------+---------+ | Test Type / Protocol| TCP v4 | TCP v6 | UDP v4 | UDP v6 | +---------------------+---------+---------+---------+---------+ | ZCopy (MB) | 6272 | 6138 | 12138 | 10055 | +---------------------+---------+---------+---------+---------+ | New ZCopy (MB) | 6774 | 6620 | 11504 | 10355 | +---------------------+---------+---------+---------+---------+ | New ZCopy / ZCopy | 108.00% | 107.85% | 94.78% | 102.98% | +---------------------+---------+---------+---------+---------+ Signed-off-by: Zijian Zhang Signed-off-by: Xiaochun Lu --- tools/testing/selftests/net/msg_zerocopy.c | 103 ++++++++++++++++++-- tools/testing/selftests/net/msg_zerocopy.sh | 1 + 2 files changed, 97 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/net/msg_zerocopy.c b/tools/testing/selftests/net/msg_zerocopy.c index ba6c257f689c..48750a7a162c 100644 --- a/tools/testing/selftests/net/msg_zerocopy.c +++ b/tools/testing/selftests/net/msg_zerocopy.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* Evaluate MSG_ZEROCOPY * * Send traffic between two processes over one of the supported @@ -66,6 +67,10 @@ #define SO_ZEROCOPY 60 #endif +#ifndef SCM_ZC_NOTIFICATION +#define SCM_ZC_NOTIFICATION 78 +#endif + #ifndef SO_EE_CODE_ZEROCOPY_COPIED #define SO_EE_CODE_ZEROCOPY_COPIED 1 #endif @@ -74,6 +79,13 @@ #define MSG_ZEROCOPY 0x4000000 #endif +#define ZC_MSGERR_NOTIFICATION 1 +#define ZC_MSGCTL_NOTIFICATION 2 + +#define SOCK_ZC_INFO_NUM 8 + +#define INVALID_ZEROCOPY_VAL 2 + static int cfg_cork; static bool cfg_cork_mixed; static int cfg_cpu = -1; /* default: pin to last cpu */ @@ -86,13 +98,16 @@ static int cfg_runtime_ms = 4200; static int cfg_verbose; static int cfg_waittime_ms = 500; static int cfg_notification_limit = 32; -static bool cfg_zerocopy; +static int cfg_zerocopy; /* Either 1 or 2, mode for SO_ZEROCOPY */ static socklen_t cfg_alen; static struct sockaddr_storage cfg_dst_addr; static struct sockaddr_storage cfg_src_addr; static char payload[IP_MAXPACKET]; +static struct zc_info_elem zc_info[SOCK_ZC_INFO_NUM]; +static char zc_ckbuf[CMSG_SPACE(sizeof(void *))]; +static struct zc_info_elem *zc_info_ptr = zc_info; static long packets, bytes, completions, expected_completions; static int zerocopied = -1; static uint32_t next_completion; @@ -170,6 +185,26 @@ static int do_accept(int fd) return fd; } +static void add_zcopy_info(struct msghdr *msg) +{ + int i; + struct cmsghdr *cm; + + if (!msg->msg_control) + error(1, errno, "NULL user arg"); + cm = (void *)msg->msg_control; + /* Although only the address of the array will be written into the + * zc_ckbuf, we assign cmsg_len to CMSG_LEN(sizeof(zc_info)) to specify + * the length of the array. + */ + cm->cmsg_len = CMSG_LEN(sizeof(zc_info)); + cm->cmsg_level = SOL_SOCKET; + cm->cmsg_type = SCM_ZC_NOTIFICATION; + memcpy(CMSG_DATA(cm), &zc_info_ptr, sizeof(zc_info_ptr)); + for (i = 0; i < SOCK_ZC_INFO_NUM; i++) + zc_info[i].zerocopy = INVALID_ZEROCOPY_VAL; +} + static void add_zcopy_cookie(struct msghdr *msg, uint32_t cookie) { struct cmsghdr *cm; @@ -183,7 +218,7 @@ static void add_zcopy_cookie(struct msghdr *msg, uint32_t cookie) memcpy(CMSG_DATA(cm), &cookie, sizeof(cookie)); } -static bool do_sendmsg(int fd, struct msghdr *msg, bool do_zerocopy, int domain) +static bool do_sendmsg(int fd, struct msghdr *msg, int do_zerocopy, int domain) { int ret, len, i, flags; static uint32_t cookie; @@ -201,6 +236,15 @@ static bool do_sendmsg(int fd, struct msghdr *msg, bool do_zerocopy, int domain) msg->msg_controllen = CMSG_SPACE(sizeof(cookie)); msg->msg_control = (struct cmsghdr *)ckbuf; add_zcopy_cookie(msg, ++cookie); + } else if (do_zerocopy == ZC_MSGCTL_NOTIFICATION) { + memset(&msg->msg_control, 0, sizeof(msg->msg_control)); + /* Although only the address of the array will be written into the + * zc_ckbuf, msg_controllen must be larger or equal than any cmsg_len + * in it. Otherwise, we will get -EINVAL. + */ + msg->msg_controllen = CMSG_SPACE(sizeof(zc_info)); + msg->msg_control = (struct cmsghdr *)zc_ckbuf; + add_zcopy_info(msg); } } @@ -219,7 +263,7 @@ static bool do_sendmsg(int fd, struct msghdr *msg, bool do_zerocopy, int domain) if (do_zerocopy && ret) expected_completions++; } - if (do_zerocopy && domain == PF_RDS) { + if (msg->msg_control) { msg->msg_control = NULL; msg->msg_controllen = 0; } @@ -393,6 +437,42 @@ static bool do_recvmsg_completion(int fd) return ret; } +static void do_recv_completions2(void) +{ + int i; + __u32 hi, lo, range; + __u8 zerocopy; + + for (i = 0; zc_info[i].zerocopy != INVALID_ZEROCOPY_VAL; i++) { + struct zc_info_elem elem = zc_info[i]; + + hi = elem.hi; + lo = elem.lo; + zerocopy = elem.zerocopy; + range = hi - lo + 1; + + if (cfg_verbose && lo != next_completion) + fprintf(stderr, "gap: %u..%u does not append to %u\n", + lo, hi, next_completion); + next_completion = hi + 1; + + if (zerocopied == -1) + zerocopied = zerocopy; + else if (zerocopied != zerocopy) { + fprintf(stderr, "serr: inconsistent\n"); + zerocopied = zerocopy; + } + + completions += range; + + if (cfg_verbose >= 2) + fprintf(stderr, "completed: %u (h=%u l=%u)\n", + range, hi, lo); + } + + sendmsg_counter -= i; +} + static bool do_recv_completion(int fd, int domain) { struct sock_extended_err *serr; @@ -554,11 +634,15 @@ static void do_tx(int domain, int type, int protocol) else do_sendmsg(fd, &msg, cfg_zerocopy, domain); - if (cfg_zerocopy && sendmsg_counter >= cfg_notification_limit) + if (cfg_zerocopy == ZC_MSGERR_NOTIFICATION && + sendmsg_counter >= cfg_notification_limit) do_recv_completions(fd, domain); + if (cfg_zerocopy == ZC_MSGCTL_NOTIFICATION) + do_recv_completions2(); + while (!do_poll(fd, POLLOUT)) { - if (cfg_zerocopy) + if (cfg_zerocopy == ZC_MSGERR_NOTIFICATION) do_recv_completions(fd, domain); } @@ -716,7 +800,7 @@ static void parse_opts(int argc, char **argv) cfg_payload_len = max_payload_len; - while ((c = getopt(argc, argv, "46c:C:D:i:l:mp:rs:S:t:vz")) != -1) { + while ((c = getopt(argc, argv, "46c:C:D:i:l:mnp:rs:S:t:vz")) != -1) { switch (c) { case '4': if (cfg_family != PF_UNSPEC) @@ -750,6 +834,9 @@ static void parse_opts(int argc, char **argv) case 'm': cfg_cork_mixed = true; break; + case 'n': + cfg_zerocopy = ZC_MSGCTL_NOTIFICATION; + break; case 'p': cfg_port = strtoul(optarg, NULL, 0); break; @@ -769,7 +856,7 @@ static void parse_opts(int argc, char **argv) cfg_verbose++; break; case 'z': - cfg_zerocopy = true; + cfg_zerocopy = ZC_MSGERR_NOTIFICATION; break; } } @@ -780,6 +867,8 @@ static void parse_opts(int argc, char **argv) error(1, 0, "-D required for PF_RDS\n"); if (!cfg_rx && !saddr) error(1, 0, "-S required for PF_RDS\n"); + if (cfg_zerocopy == ZC_MSGCTL_NOTIFICATION) + error(1, 0, "PF_RDS does not support ZC_MSGCTL_NOTIFICATION"); } setup_sockaddr(cfg_family, daddr, &cfg_dst_addr); setup_sockaddr(cfg_family, saddr, &cfg_src_addr); diff --git a/tools/testing/selftests/net/msg_zerocopy.sh b/tools/testing/selftests/net/msg_zerocopy.sh index 89c22f5320e0..022a6936d86f 100755 --- a/tools/testing/selftests/net/msg_zerocopy.sh +++ b/tools/testing/selftests/net/msg_zerocopy.sh @@ -118,4 +118,5 @@ do_test() { do_test "${EXTRA_ARGS}" do_test "-z ${EXTRA_ARGS}" +do_test "-n ${EXTRA_ARGS}" echo ok