From patchwork Wed May 22 18:57:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Detlev Casanova X-Patchwork-Id: 13671026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2987C25B78 for ; Wed, 22 May 2024 19:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VFZPHxn1ps4zm54UE7TIF3w28CZ6qwShRgIB1oP3KkY=; b=jSJwO87pudppmm muQtVDcuC4kQWZ7v1sA29Lh7V4uPP79pAnfudqRc1XA5azxktE7+QNabR/lVseaQrIIqQhvToxfj0 Z6HUK8G/AIX9Q4OUebywDT7O/fkiipFzdjEdjQzy6nrq5pO+3XfBorBGRZok8P9X+sGxa8mG8w6Mj N3jw27lQH2958pJEOlyshhBJL//K03n768c25nPa1ixLxvsROhHYIoDYZd4aAIt/fS0s52Zrgi5S4 4kzbGqJx8ESXSFBDg8agJPXVlskjxnyC9cDQ8UMDLZADvBtqx+7NS1VtYhRzwvaXjg45haz/KAM9A xOoYsZTR2p5/fmn6wpig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9rCJ-00000003ryI-1Z6g; Wed, 22 May 2024 19:00:23 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9rC2-00000003rjL-0XgX; Wed, 22 May 2024 19:00:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1716404400; bh=PVF+wmm/VCwQDTYpdenLM3gXX3oTTIiq5Q5qfjbuvLE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=08XQe887W1a3THcyloUj9bHJ9IdB4JXxZhcaOun91U4AUljYMREpO5d+Wky9QpOmN epFZT7kJTR7z18QGZ2CouCWvGCO9u/QbMjuT1CrHNTfCEAu3fv2K8g8KFpknPFqvbc KJvXpL3MTUMgpskmorA9bY7aIKkbEUkeN7iR94CGMrA1xGWP+ggURlhE1OhX/l6YwX Z+dulPucGSU24QeJN55sMqu/Dt6+fMfsdy7KJsGoslcc4CQvrvlOXSAfB+1rt+lf7q WimPioxOoZ1fyLn8aAXs4MEg/sOfQ/o/RbQr1XtQiuVo29Hcuq5mgp3Bbz+BAtFAMn ANtpc5obaYsTQ== Received: from arisu.mtl.collabora.ca (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 37792378218D; Wed, 22 May 2024 18:59:57 +0000 (UTC) From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , Dragan Simic , Chris Morgan , Diederik de Haas , Boris Brezillon , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Detlev Casanova Subject: [PATCH v2 1/3] vop2: Add clock resets support Date: Wed, 22 May 2024 14:57:48 -0400 Message-ID: <20240522185924.461742-2-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.44.1 In-Reply-To: <20240522185924.461742-1-detlev.casanova@collabora.com> References: <20240522185924.461742-1-detlev.casanova@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_120006_454909_B6BD81BC X-CRM114-Status: GOOD ( 15.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org At the end of initialization, each VP clock needs to be reset before they can be used. Failing to do so can put the VOP in an undefined state where the generated HDMI signal is either lost or not matching the selected mode. Signed-off-by: Detlev Casanova --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 30 ++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index fdd768bbd487c..e81a67161d29a 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -157,6 +158,7 @@ struct vop2_win { struct vop2_video_port { struct drm_crtc crtc; struct vop2 *vop2; + struct reset_control *dclk_rst; struct clk *dclk; unsigned int id; const struct vop2_video_port_data *data; @@ -1915,6 +1917,26 @@ static int us_to_vertical_line(struct drm_display_mode *mode, int us) return us * mode->clock / mode->htotal / 1000; } +static int vop2_clk_reset(struct vop2_video_port *vp) +{ + struct reset_control *rstc = vp->dclk_rst; + struct vop2 *vop2 = vp->vop2; + int ret; + + if (!rstc) + return 0; + + ret = reset_control_assert(rstc); + if (ret < 0) + drm_warn(vop2->drm, "failed to assert reset\n"); + udelay(10); + ret = reset_control_deassert(rstc); + if (ret < 0) + drm_warn(vop2->drm, "failed to deassert reset\n"); + + return ret; +} + static void vop2_crtc_atomic_enable(struct drm_crtc *crtc, struct drm_atomic_state *state) { @@ -2055,6 +2077,8 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc, vop2_vp_write(vp, RK3568_VP_DSP_CTRL, dsp_ctrl); + vop2_clk_reset(vp); + drm_crtc_vblank_on(crtc); vop2_unlock(vop2); @@ -2706,6 +2730,12 @@ static int vop2_create_crtcs(struct vop2 *vop2) vp->data = vp_data; snprintf(dclk_name, sizeof(dclk_name), "dclk_vp%d", vp->id); + vp->dclk_rst = devm_reset_control_get_optional(vop2->dev, dclk_name); + if (IS_ERR(vp->dclk_rst)) { + drm_err(vop2->drm, "failed to get %s reset\n", dclk_name); + return PTR_ERR(vp->dclk_rst); + } + vp->dclk = devm_clk_get(vop2->dev, dclk_name); if (IS_ERR(vp->dclk)) { drm_err(vop2->drm, "failed to get %s\n", dclk_name); From patchwork Wed May 22 18:57:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Detlev Casanova X-Patchwork-Id: 13671027 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 932B8C25B78 for ; Wed, 22 May 2024 19:00:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1yK+5DZYdZaTRVN1ly7ou6srpdhNQp0wYVO9QN3DnCs=; b=OvRx3ZyZpsZTMG b0/09EiV/omE12apMWjY3KhTw9gWceoCWIFGMjpzyQTCa2tWQybW5PmAPNXewe1nwOyFTwEAWfhWP 8hJAzyEV4arxz8hUi9LCE5mwA/9u2RLq8pBskpikCEXyFybRaWv8FOJNIvNKG8J/vU4Gp2yuwj/Fe 1V4T9EEAF9qL8XW+NrxrPm8RMTUCHCwKzcMSe1PzXGplvuYdZ4FZTUxuwOoLXhmYDtTXqlzaljleX OXM7JVt1O++FD0MnsUDtQu1Sn/X7h+JqjELCmnSoOq2E0N6JN0BFzDghlUkuWmn/g7TxSyWM6xCfa xzDMH/x8I4naUv+Sun1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9rCN-00000003s21-1eyc; Wed, 22 May 2024 19:00:27 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9rC2-00000003rl1-29oo; Wed, 22 May 2024 19:00:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1716404405; bh=LfctjAd5uH9RnEI2V0jx8z9y7pEnFvsn8ifaV8F3Mx8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=45kzaSJ9T8lf1/Zh9CeVPM38MgoiD8SDrf9tCrazJTsjXVyWvNSa/nIDKi7WRfbj2 6I9b89QkEE95FUQkExwMerQySbVOMOE8TWimMwgB3Nzji4cUiwRvYjf3iBsNbxoYHH qJiH5xRlMKYotPQm2MiQ8/h6ftj7W7NlepNWewPpLSraNtJ1t4UCOwV6tjXxFQ0hIy Dx4R++SLb7DKY8gU2DyZZKqFmjm5LKf+SPONJ7IV4ULmuO/wZ4GjbD3i+QOYY5kxOt Cof3tOtLPyloyx3Vf5yhvtp19dVbfz9Bnii+/yDs8/JcjS07CgSAs55t7naznmaRfC lOIcKq9MC0QgQ== Received: from arisu.mtl.collabora.ca (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 5C6BD37821A4; Wed, 22 May 2024 19:00:02 +0000 (UTC) From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , Dragan Simic , Chris Morgan , Diederik de Haas , Boris Brezillon , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Detlev Casanova Subject: [PATCH v2 2/3] arm64: dts: rockchip: Add VOP clock resets for rk3588s Date: Wed, 22 May 2024 14:57:49 -0400 Message-ID: <20240522185924.461742-3-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.44.1 In-Reply-To: <20240522185924.461742-1-detlev.casanova@collabora.com> References: <20240522185924.461742-1-detlev.casanova@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_120006_816388_C17C87C8 X-CRM114-Status: UNSURE ( 8.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This adds the needed clock resets for all rk3588(s) based SOCs. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi index 6ac5ac8b48abb..490a525700498 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi @@ -1193,6 +1193,18 @@ vop: vop@fdd90000 { "pclk_vop"; iommus = <&vop_mmu>; power-domains = <&power RK3588_PD_VOP>; + resets = <&cru SRST_A_VOP>, + <&cru SRST_H_VOP>, + <&cru SRST_D_VOP0>, + <&cru SRST_D_VOP1>, + <&cru SRST_D_VOP2>, + <&cru SRST_D_VOP3>; + reset-names = "aclk", + "hclk", + "dclk_vp0", + "dclk_vp1", + "dclk_vp2", + "dclk_vp3"; rockchip,grf = <&sys_grf>; rockchip,vop-grf = <&vop_grf>; rockchip,vo1-grf = <&vo1_grf>; From patchwork Wed May 22 18:57:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Detlev Casanova X-Patchwork-Id: 13671028 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F9D4C25B78 for ; Wed, 22 May 2024 19:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iXNb3oMVJUcI4F8trabFogCKCbSVUzmRlUTpvgTHniU=; b=CTBLQx9bZ0oLPu wGH1kOJktAA00mjFMwp71ps13rAfLrj1+lVJW51qWlskoEy5zcaKhmCTjO9Qo9mLAYjzScH1Mwdci Ev8hfcx/Qy53IXP94ejaMfcikYmwSGQVloZcIwz/JEvnlQ2ZIyn6aFnMCcf4laCvq0thm7s9vAXdD B5lnLA6RKx/UN+zGESaGGnHZgz8UqT0qg25WrMueYgvy9MNZ1EKZ8gG9C5VUQNfbTpl5bSm5g5wnw Z4row9lpFapye1+D812u1u+Gk+TRoYpIHYnIjfQQbIuWkgL23KAe3ELcCTw2EDSSkv2aQlhg9gDW+ qYn6UK5IlhIJu2t1wt7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9rCn-00000003sM2-0toa; Wed, 22 May 2024 19:00:53 +0000 Received: from madrid.collaboradmins.com ([46.235.227.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9rCC-00000003rsX-08il; Wed, 22 May 2024 19:00:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1716404414; bh=K3uqibnV7b1duUbZhowQg1V7PD62JhL0za691muIla8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CMPxjpOO1qi4VJjsALN6Lc1a2LCGtl9hJ0RLXqhFk5Huqb74x9MgzegSZPWhzDDFP 2KddNFQvPVu8s62ZuD3p2qSoydHVb3J2qSOsi/hIxGdQpDSdvzpcDAjFw4NrVQlMM0 Jwp5Z1KHoKS6gax+AycckJRz5FIb/vUc+y3hxYyCadUVkXbgKEGqtpAHBWokjYhq4j 8sCSDM1BNJst1hW3GuPduRmnsZLaldi8rEVlV/2hVC14fPn2Wk61Sho8tRK/Ryn2H1 AG4+j7kBNfF4VXcIbMzWpQrS0Yban+6AEuWE2slvRzk4TsBheZyw1jcgEHT0/gJ27Q WXjLCrX3xSWVw== Received: from arisu.mtl.collabora.ca (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 33966378218D; Wed, 22 May 2024 19:00:11 +0000 (UTC) From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , Dragan Simic , Chris Morgan , Diederik de Haas , Boris Brezillon , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Detlev Casanova Subject: [PATCH v2 3/3] dt-bindings: display: vop2: Add VP clock resets Date: Wed, 22 May 2024 14:57:50 -0400 Message-ID: <20240522185924.461742-4-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.44.1 In-Reply-To: <20240522185924.461742-1-detlev.casanova@collabora.com> References: <20240522185924.461742-1-detlev.casanova@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_120016_243122_DB035D9A X-CRM114-Status: UNSURE ( 8.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add the documentation for VOP2 video ports reset clocks. One reset can be set per video port. Signed-off-by: Detlev Casanova Reviewed-by: Conor Dooley --- .../display/rockchip/rockchip-vop2.yaml | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml index 2531726af306b..5b59d91de47bd 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml @@ -65,6 +65,26 @@ properties: - const: dclk_vp3 - const: pclk_vop + resets: + minItems: 5 + items: + - description: AXI clock reset. + - description: AHB clock reset. + - description: Pixel clock reset for video port 0. + - description: Pixel clock reset for video port 1. + - description: Pixel clock reset for video port 2. + - description: Pixel clock reset for video port 3. + + reset-names: + minItems: 5 + items: + - const: aclk + - const: hclk + - const: dclk_vp0 + - const: dclk_vp1 + - const: dclk_vp2 + - const: dclk_vp3 + rockchip,grf: $ref: /schemas/types.yaml#/definitions/phandle description: @@ -128,6 +148,11 @@ allOf: clock-names: minItems: 7 + resets: + minItems: 6 + reset-names: + minItems: 6 + ports: required: - port@0 @@ -152,6 +177,11 @@ allOf: clock-names: maxItems: 5 + resets: + maxItems: 5 + reset-names: + maxItems: 5 + ports: required: - port@0 @@ -183,6 +213,16 @@ examples: "dclk_vp0", "dclk_vp1", "dclk_vp2"; + resets = <&cru SRST_A_VOP>, + <&cru SRST_H_VOP>, + <&cru SRST_VOP0>, + <&cru SRST_VOP1>, + <&cru SRST_VOP2>; + reset-names = "aclk", + "hclk", + "dclk_vp0", + "dclk_vp1", + "dclk_vp2"; power-domains = <&power RK3568_PD_VO>; iommus = <&vop_mmu>; vop_out: ports {