From patchwork Sat May 25 19:22:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lothar Rubusch X-Patchwork-Id: 13674120 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA81BC25B78 for ; Sat, 25 May 2024 19:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Eg+/R6VFHpYj6Aq68BAZEJhrgyuW5Cwva1hl37XynBw=; b=lpoje39ubVG8tj 5Cta49lHhUC3ewycshuFxM52QfoJDKCTLe9Xb+7aLwgEs82OXEBe4ffjIfL0MeN58lbvPWed/wRTa KYrwtZRpbiaUN8tY7Pp0olLK2xwjtO970pzPG1qf/cjr+HZS0nhux2KPFTqOuNnJbqRCJ+ytqakwt 1RnRbcV2KWF9at6I6K7xhX+PStaAWki/smve5FN8v8t5HPn+PAAsniZS5WzU26NLOQN+YAiVZCwMJ mhtYIx0nC2ycy8BJw21ZW2DnKkp5mBnpEL1CPeWkK64C4+cxYdND6KztMKdYNPscQV9Wko/sMqV4k pU7TwVNagcmuZfl7rd5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sAwye-0000000BZmJ-1RQU; Sat, 25 May 2024 19:22:48 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sAwyb-0000000BZlm-20UF for linux-arm-kernel@lists.infradead.org; Sat, 25 May 2024 19:22:47 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-420160f8f52so39971395e9.0 for ; Sat, 25 May 2024 12:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716664961; x=1717269761; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L8MCPhQT7noHqmvmJire3u4Gi4h4yWWwXkiOGYuXUaw=; b=nZ8ghWFqsRQUdzoUCi0cg78BU7cSAQwc/+nKGGnXWobA3MV56xuovov2AYh9xgwE1o TurC1O8e+daGfFmTseIH9PW5s+p/jHaPTUDBoiAvwaJgTp20TFAQVuR5WWmYkldIcHQO W4n0jszBYvsoEh5vAxjaCEq83wTKPaSujdlE8hxDja7JgnSSXhCTEtUYwGUUkxqcqqN3 W0EwgMF2q3bHClLEN5eib2+HLrJYDJjqbWySOOZEsqwBuH6qxV+LgCO16m29gPw76ttx xOT41J0W2gSu5l/UQ+ddT8V+5Ps2jyXK0oPa6eKjt4gfskwEJwta1N48/uIcSAA4PVl8 uASg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716664961; x=1717269761; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L8MCPhQT7noHqmvmJire3u4Gi4h4yWWwXkiOGYuXUaw=; b=fRkZ382IS928vsBhK7qGba8Kn4cWxukUCBuVqwaBlgTCDeMver8GwckcXzYCkRNyUO c7EKYHlgg2VDIcw7CCOhj9MDc049R6jhkUn2wv8rPD578ffYQr+ir/h05KX7teMv9LnJ lHjzh+QOFQ3TJvnOoCLMhawZXjcZ8FbbX0ccX+jwxtnjv8scAjVTrIH+B7+NXYdc64XZ Vne+pSfQ+CZ8+tYWpvvZYtWNMoHKPk2gK5azBTg8Chhr+QnZR2fPLYKlqG3IqV5w24In 7zYSv0AhUXqcCqhKiJC1N7Lb2+e7QVfPH+url4NPzxjzk0BcuDydCfo7Iu4h0vhVcC0z 15dw== X-Forwarded-Encrypted: i=1; AJvYcCXthVZeGyYr2NuvHWtu2+1dYvxCVIOtUjg6y5h/HEM3g1fzJfktx2ePs5mBo9E6aNEYBJdfl+ylLMP8mOBhkILRF/Ib1nfSfhWVfw0uzV4d3J+rLmw= X-Gm-Message-State: AOJu0YzDie2kUc12AgQYznKZ++f46jgPbcjas7cm0G4g54UWyn2zgB4z MLkHDmc0Ypwoj7aNqDgXlv957C400ZX79PM/ExGujfv4mjCWdw/U X-Google-Smtp-Source: AGHT+IERkIy03icxUl2SODD5nZiZYFnyNluiiiPPa/mCUEkjdVytK3ca57JQ7MWLVkgmDZslBTx2VA== X-Received: by 2002:a05:600c:295:b0:41b:da5b:a60d with SMTP id 5b1f17b1804b1-421089ec277mr48325605e9.6.1716664960374; Sat, 25 May 2024 12:22:40 -0700 (PDT) Received: from 4728cded2e8d.v.cablecom.net (84-72-156-211.dclient.hispeed.ch. [84.72.156.211]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4210897bc02sm56661955e9.22.2024.05.25.12.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 12:22:40 -0700 (PDT) From: Lothar Rubusch To: herbert@gondor.apana.org.au, davem@davemloft.net Subject: [PATCH] crypto: atmel-sha204a - fix negated return value Date: Sat, 25 May 2024 19:22:37 +0000 Message-Id: <20240525192237.9837-1-l.rubusch@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240525_122245_754147_7A127FC1 X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dan.carpenter@linaro.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, claudiu.beznea@tuxon.dev, l.rubusch@gmail.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix negated variable return value. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/linux-crypto/34cd4179-090e-479d-b459-8d0d35dd327d@moroto.mountain/ Signed-off-by: Lothar Rubusch --- drivers/crypto/atmel-sha204a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index 24ffdf505023..2034f6031518 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -106,7 +106,7 @@ static int atmel_sha204a_otp_read(struct i2c_client *client, u16 addr, u8 *otp) if (cmd.data[0] == 0xff) { dev_err(&client->dev, "failed, device not ready\n"); - return -ret; + return -EINVAL; } memcpy(otp, cmd.data+1, 4);