From patchwork Mon May 27 06:30:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: MD Danish Anwar X-Patchwork-Id: 13674617 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEF25C25B7C for ; Mon, 27 May 2024 06:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WcRG1IQDIM2oRywNqzABR7Lb1K//g23g+E7lQjnV/Wc=; b=lBj7r0jNSeYmPA 0TV4gSQS52iARFDme6YZuSScuzjVNRxpa0VMSS/sioMB0+PykQO0tsPe/vdlDgItQeqpOvPXWF3w7 7GpTkF6y0vfuIb1msl0aJ29Hpd4pfXtlj139o00nmEuKVFAlAERCYV6iD1do8qxh4WFGfXod+yZoz 9Zuyh6QIeLjpcyRxB3EHbYLWBU7SpONtFPWd090re+gNnlKeBJm5/1y5aHq9rieA/zjNnTF7Wamta 18BpL3s9N6eOzBJz/n7z7YwEm9JxeEqgbNkjgsRIH3b30x3jFTOFgu43zlIHKJK/8NeY0dunyZlgz X84Er+vdC8Z6TGR2NOWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBTsL-0000000DvhT-2qJs; Mon, 27 May 2024 06:30:29 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBTsI-0000000Dvgs-0BAX for linux-arm-kernel@lists.infradead.org; Mon, 27 May 2024 06:30:28 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 44R6UI7w123976; Mon, 27 May 2024 01:30:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1716791418; bh=03tHTJNR6JRpcSZNxBdBLsUOYYQnOce3h4UMjr16pHg=; h=From:To:CC:Subject:Date; b=Pd0SQjXlquFv+yYHhyoBRVi2BJarhQwUk8LydogqK1fKRut1TL3kj2GZi0tJgwNgt YpXo3ExwyBApGhvp5Y8+B2RDGf5ABC9EcsRgF4W98P6bxhft0MQWkie6tjj3xdcLDg fUNjIv1vrZsehfr+WEI3VuV9xzLXSqT+IRNzzDzw= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 44R6UItR021611 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 27 May 2024 01:30:18 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 27 May 2024 01:30:18 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 27 May 2024 01:30:18 -0500 Received: from lelv0854.itg.ti.com (lelv0854.itg.ti.com [10.181.64.140]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 44R6UIg1128224; Mon, 27 May 2024 01:30:18 -0500 Received: from localhost (danish-tpc.dhcp.ti.com [10.24.69.25]) by lelv0854.itg.ti.com (8.14.7/8.14.7) with ESMTP id 44R6UHO7031809; Mon, 27 May 2024 01:30:18 -0500 From: MD Danish Anwar To: Diogo Ivo , Andrew Lunn , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" CC: , , , , Vignesh Raghavendra , Roger Quadros , MD Danish Anwar , Florian Fainelli Subject: [PATCH net v2] net: ti: icssg-prueth: Fix start counter for ft1 filter Date: Mon, 27 May 2024 12:00:15 +0530 Message-ID: <20240527063015.263748-1-danishanwar@ti.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240526_233026_264418_9464AEF5 X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The start counter for FT1 filter is wrongly set to 0 in the driver. FT1 is used for source address violation (SAV) check and source address starts at Byte 6 not Byte 0. Fix this by changing start counter to ETH_ALEN in icssg_ft1_set_mac_addr(). Fixes: e9b4ece7d74b ("net: ti: icssg-prueth: Add Firmware config and classification APIs.") Signed-off-by: MD Danish Anwar --- Cc: Florian Fainelli Changes from v1 to v2: *) Using ETH_ALEN instead of hardcoding the values to 6 as suggested by Florian Fainelli v1: https://lore.kernel.org/all/20240524093719.68353-1-danishanwar@ti.com/ drivers/net/ethernet/ti/icssg/icssg_classifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 0b4f5add9fa59bfd42c1030f572db2e4c395181b diff --git a/drivers/net/ethernet/ti/icssg/icssg_classifier.c b/drivers/net/ethernet/ti/icssg/icssg_classifier.c index 79ba47bb3602..f7d21da1a0fb 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_classifier.c +++ b/drivers/net/ethernet/ti/icssg/icssg_classifier.c @@ -455,7 +455,7 @@ void icssg_ft1_set_mac_addr(struct regmap *miig_rt, int slice, u8 *mac_addr) { const u8 mask_addr[] = { 0, 0, 0, 0, 0, 0, }; - rx_class_ft1_set_start_len(miig_rt, slice, 0, 6); + rx_class_ft1_set_start_len(miig_rt, slice, ETH_ALEN, ETH_ALEN); rx_class_ft1_set_da(miig_rt, slice, 0, mac_addr); rx_class_ft1_set_da_mask(miig_rt, slice, 0, mask_addr); rx_class_ft1_cfg_set_type(miig_rt, slice, 0, FT1_CFG_TYPE_EQ);