From patchwork Thu May 30 00:52:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 13679583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83837C25B75 for ; Thu, 30 May 2024 00:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Nxd3gA3yifhvRYaI64n0J86dSzrcB7wgwWuJb7dAQjY=; b=a3N9aPoeJUpNbk WfnlBet1osZi6Qn0opwlpkVfeXaoehkT/CkRgXjM/NuRkozAcrfqHYHz0Qokn5HtFTvqNvKgezEdF iomWI1KLpi1eXVvWWKL8jfeuZ5aeGblnGqYH8KObO1iJRScuipBHYcSG7b7K1FSyJVvPh4t8K1n6x 9/FYktzgJXAPTble6o1XChf2JQUWiUWMMHG3jIEatxKIlsOX3SqfHUgdX7PoWUKRfGb/FX3mX7zCW IOSAQC0NiPiJwmrl0x7klqhr2IzWRP6FOCgukVbDQXivRdqrkTgshYhsXydzFa1+VkA94YSjXboII IkIh1msyOvT1xmvfz2cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCU2Q-00000005wDt-4Ban; Thu, 30 May 2024 00:53:03 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCU2N-00000005wCV-47cN for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2024 00:53:01 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-7021ab0d0f5so314271b3a.2 for ; Wed, 29 May 2024 17:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1717030376; x=1717635176; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=m2qTNyHyYfp+d7DaR++BJjcIzT2YJygLkWTT2HYJmoM=; b=Cv9+ugWIgxZWxvS/3DHxyYM5nkXKsryHpNJ+txy/FqL0D9/2yGx6Oy56k3+cyZdp+R k21UsTU4eWlCYYOcaedodKHQmRHKijmertZhp1f7UrFzC51H6dPmU1ucOTt/aAuBdZxU 5Ko+Z+al9FKSm1gXDn3o0cQST8Gm8HaokMOQyqu4DXU7qfLg5b1D1lYY8U1c1wFrif/I RknAYib4T34KzLmErkF1eh0LV70fxLer02G3Fr1nLrNwmageBVmkB9zVfNocpgEjqKRe l5Izy45fZktFbF6XYpA+S//lHYiRDYau6jOYYPix3mjXNNpZhjeHcDR8/kStqguSlulS E/Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717030376; x=1717635176; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=m2qTNyHyYfp+d7DaR++BJjcIzT2YJygLkWTT2HYJmoM=; b=NGMI51dyxdHY5LH2zGO3khyHfGUTI3HVYRtGMqNcdrOm3sCKkIKmfkDjD7B5ZdQdNa X5z1o8/XsZrDK07ejXi8CHqsZd5UkEot25QogSXhoXrSWCOYvikCMdCI0jW4lCkDQ/hu fNnMRZsF/ZE+wGYATPcWHKa4xcV0g6524Txtw/K8uEBO4nyz7jFnQYLgDovxyiLP2NqK yt3lQt5YbL6rqZ4dViQMKjI2FRo/LGpRI3I81tbsCcUaEcnVhSMvmlnEwQ899K/Uqa7b AwZhE/lOFOgQW7VDjxAX25rDdoHObdREF/mnmLlbWNAA69BCtFBRHnRtoiGQ+WdVSEls 0LfQ== X-Forwarded-Encrypted: i=1; AJvYcCU5w/mAwf2bZAAMM8axV8ypuxcavKHhCANUCLYdm3m+6AtHeE+5B/ndvc9gUyChPT/wmFIcknjbeEHtebSfL/VqejWko1dLCgC7ddML7m268iBaTDw= X-Gm-Message-State: AOJu0YxxuWgN4Z97dtqYl/EtzGIkyqnhqOgotaBux0NoDhfLdu8JBQ/b NRAlFx+n0y7jtkCCgXYFb9qol1z1lXaO/5rBCNVkIW2IN02+JJf4vW0m+bj8x7I= X-Google-Smtp-Source: AGHT+IEpamNzOMpXej0aUkSI+HNZYElaFeXaRdTiKb76E3pGSGOp3OZNuTRt+FHSImXs8V4onJ+Esw== X-Received: by 2002:a05:6a20:a129:b0:1af:fbab:cf92 with SMTP id adf61e73a8af0-1b264633325mr747533637.54.1717030376269; Wed, 29 May 2024 17:52:56 -0700 (PDT) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c9683b3sm105898415ad.163.2024.05.29.17.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 17:52:55 -0700 (PDT) From: Samuel Holland To: Thomas Gleixner Cc: Samuel Holland , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] irqchip/gic: Use smp_wmb() instead of dmb(ishst) Date: Wed, 29 May 2024 17:52:30 -0700 Message-ID: <20240530005254.1495461-1-samuel.holland@sifive.com> X-Mailer: git-send-email 2.44.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_175300_219434_628F6AE3 X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is equivalent on ARM, but also works on other architectures. Signed-off-by: Samuel Holland --- drivers/irqchip/irq-gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 98aa383e39db..dc2e4018a40c 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -839,7 +839,7 @@ static void gic_ipi_send_mask(struct irq_data *d, const struct cpumask *mask) * Ensure that stores to Normal memory are visible to the * other CPUs before they observe us issuing the IPI. */ - dmb(ishst); + smp_wmb(); /* this always happens on GIC0 */ writel_relaxed(map << 16 | d->hwirq, gic_data_dist_base(&gic_data[0]) + GIC_DIST_SOFTINT);