From patchwork Fri May 31 03:05:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhaoyang.huang" X-Patchwork-Id: 13681077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07319C25B74 for ; Fri, 31 May 2024 03:06:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E0246B008A; Thu, 30 May 2024 23:06:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 690016B0092; Thu, 30 May 2024 23:06:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57E246B0093; Thu, 30 May 2024 23:06:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3B05B6B008A for ; Thu, 30 May 2024 23:06:16 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DFC4CA0F4D for ; Fri, 31 May 2024 03:06:15 +0000 (UTC) X-FDA: 82177202310.20.C4747EB Received: from SHSQR01.spreadtrum.com (unknown [222.66.158.135]) by imf03.hostedemail.com (Postfix) with ESMTP id 5E48320005 for ; Fri, 31 May 2024 03:06:10 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717124771; a=rsa-sha256; cv=none; b=5UZHNHsChfoRfvDLskAFSZQpQ9VCVd1D57g5U0PfLpU2ikyoatSe7M4yaTW2jre7QaQb2a nGJs1Q+GsuCtQVg0H65GePgFlR8NoY8vTPAP4arh84IUMrBwT/uiBPi6Y8Lw2fGLUXstli sbizD3ielYHFe/RhyWzoULu9sA4hGBE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of zhaoyang.huang@unisoc.com designates 222.66.158.135 as permitted sender) smtp.mailfrom=zhaoyang.huang@unisoc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717124771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=ujvc+YklsSJj+QlsmCEy6OHizKJWLW8xNEpzvhECgBE=; b=1fdKzAtR0MqGtT7tssZGUz3Qj7R6TQlrpMXBf+yZ09wWgArAsb0ytNm1Jx57SQ1uM4jiK1 vFKbvgXuEM2rpPpD/WPEds5j9fHw/ArYhLeMblIcz5BIFdYojQ3aSAoMkqJSIHiybpDMug 9CkYu9OYAlWxKbTCZOMj3wtQWgUGgLM= Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 44V35RmE064534; Fri, 31 May 2024 11:05:27 +0800 (+08) (envelope-from zhaoyang.huang@unisoc.com) Received: from SHDLP.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4Vr7Dw3fpPz2QLg51; Fri, 31 May 2024 11:01:36 +0800 (CST) Received: from bj03382pcu01.spreadtrum.com (10.0.73.40) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 31 May 2024 11:05:24 +0800 From: "zhaoyang.huang" To: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Baoquan He , Thomas Gleixner , hailong liu , , , Zhaoyang Huang , Subject: [PATCHv3] mm: fix incorrect vbq reference in purge_fragmented_block Date: Fri, 31 May 2024 11:05:20 +0800 Message-ID: <20240531030520.1615833-1-zhaoyang.huang@unisoc.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.0.73.40] X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 44V35RmE064534 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5E48320005 X-Stat-Signature: 649jor7defaeoqqf361jz4rp4ec1tqc1 X-HE-Tag: 1717124769-495766 X-HE-Meta: U2FsdGVkX180xhBo6fed4ido6FNvJZtIw1efuOgzQxFWLJHsf+0OWbN2yF2ekatsO0/MIkVuNcxSgGk+4pb7dqAI+OnmwWFW2F7MH9g9pY2aSKVHi5/KDevuvyd6utNLQ7Va2soGmiqaXBJr2oHl52YI2URF9COlkpfRdYio9IlBx/ntZjmLLLvXA4cAwMhHOjJApKT+hy5uDWeQAasFpNm0aCl/embRnm/jZyVxncB/XWCMPULzx0nwxCAESQ40YpRP3jiX4c5tFM1Kmd24l6sNLyCRjZ1LBC+cdbRfT9llfMfxMjZ0jRxSFZs+QRU6z7a9byZ3h6NA0DH0vZ1UangBZq0ANOEtnR7wz3PukML3TReI8uiu589FBGxCc1A6gEjKJvgxheiW24o2c9ZT55xVRw2tlYRka3Xrr9dUh40R6uvZQZs3lErDShHPKYPzCFGqnoyYqtscsQ2ww7z27ywfPJ7tu9hVcHu7V55x0Zvz4h2oj9w98DzbNoh8yfz0Jlh7wSyAagzOzIHpIW/OpmCcklCqYRcaSFLDO3k/fzbSLDhppVfcTONrNBc5LggEmnlApgiBgiSGbceP6DDZVTzJJbVjSgTWJB4LPZV8s407cwLafuqZrrf+h3zgyG5ZNHwBK9v9jTKZC8x6I3IgWNcspVyhQC6BfcMPl+XY90/SgBWuDAY+Pbru4aSIwJgwoHwCVh36OJNsQHbFRZzEX5vUafQYBJ/TaeP+pPGn8FxU/BgXsX48RULjHQ6yjqLsewvhovf7BrIRAP6c8S3mYNa3Z8yc/jE7uiSgxdtBBe6/IqCLosJez+Lj/p2cBg4PhEnWf3xAwh8/RaukRQxh8/jt9TB+9obp9volfet5nTgGo4Y46zm99QrAav0yuGZIJsRqqGGvDJ1sDwSJw7CPrYvQSkuIEU8zgo0MVLCAZR9Sv8sHl+Wmf8ApGCNNZ/WgGep5InmWMVIpQu7eiwN YZ93mrOV gbSLk71siPNu61GPcEJFzOqcyybNlxm8U3RW2qszvWuGc0DINRpWyYgiQz59ORdgVIuA6Jmx2GydV9XDIkr/0qTs8dS44LbPJVSSIsjejeyQAXNZ8aORM0Sm1hLGVEDssh5uYy8la4Fy8b590UIPmBRZoE5ATQdlAe1HzW7O/3Djn9RBZe74fX8nZkY2LSo8juYQtqnLPwV/wfKsM4Psmb7gQcyuiAkMonGKv2WQQCXOrrYR3+FWiHfShxnMCCSY8zPJGV1S4TJuwlNQfSkCyuIVkcVBUDOzVmQuohx7luWIDwpqGjroUVCwjIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Zhaoyang Huang vmalloc area runs out in our ARM64 system during an erofs test as vm_map_ram failed[1]. By following the debug log, we find that vm_map_ram()->vb_alloc() will allocate new vb->va which corresponding to 4MB vmalloc area as list_for_each_entry_rcu returns immediately when vbq->free->next points to vbq->free. That is to say, 65536 times of page fault after the list's broken will run out of the whole vmalloc area. This should be introduced by one vbq->free->next point to vbq->free which makes list_for_each_entry_rcu can not iterate the list and find the BUG. [1] PID: 1 TASK: ffffff80802b4e00 CPU: 6 COMMAND: "init" #0 [ffffffc08006afe0] __switch_to at ffffffc08111d5cc #1 [ffffffc08006b040] __schedule at ffffffc08111dde0 #2 [ffffffc08006b0a0] schedule at ffffffc08111e294 #3 [ffffffc08006b0d0] schedule_preempt_disabled at ffffffc08111e3f0 #4 [ffffffc08006b140] __mutex_lock at ffffffc08112068c #5 [ffffffc08006b180] __mutex_lock_slowpath at ffffffc08111f8f8 #6 [ffffffc08006b1a0] mutex_lock at ffffffc08111f834 #7 [ffffffc08006b1d0] reclaim_and_purge_vmap_areas at ffffffc0803ebc3c #8 [ffffffc08006b290] alloc_vmap_area at ffffffc0803e83fc #9 [ffffffc08006b300] vm_map_ram at ffffffc0803e78c0 Fixes: fc1e0d980037 ("mm/vmalloc: prevent stale TLBs in fully utilized blocks") Suggested-by: Hailong.Liu Signed-off-by: Zhaoyang Huang Signed-off-by: Baoquan He --- v2: introduce cpu in vmap_block to record the right CPU number v3: use get_cpu/put_cpu to prevent schedule between core --- --- mm/vmalloc.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 22aa63f4ef63..ecdb75d10949 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2458,6 +2458,7 @@ struct vmap_block { struct list_head free_list; struct rcu_head rcu_head; struct list_head purge; + unsigned int cpu; }; /* Queue of free and dirty vmap blocks, for allocation and flushing purposes */ @@ -2586,10 +2587,12 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) return ERR_PTR(err); } + vb->cpu = get_cpu(); vbq = raw_cpu_ptr(&vmap_block_queue); spin_lock(&vbq->lock); list_add_tail_rcu(&vb->free_list, &vbq->free); spin_unlock(&vbq->lock); + put_cpu(); return vaddr; } @@ -2614,9 +2617,10 @@ static void free_vmap_block(struct vmap_block *vb) } static bool purge_fragmented_block(struct vmap_block *vb, - struct vmap_block_queue *vbq, struct list_head *purge_list, - bool force_purge) + struct list_head *purge_list, bool force_purge) { + struct vmap_block_queue *vbq = &per_cpu(vmap_block_queue, vb->cpu); + if (vb->free + vb->dirty != VMAP_BBMAP_BITS || vb->dirty == VMAP_BBMAP_BITS) return false; @@ -2664,7 +2668,7 @@ static void purge_fragmented_blocks(int cpu) continue; spin_lock(&vb->lock); - purge_fragmented_block(vb, vbq, &purge, true); + purge_fragmented_block(vb, &purge, true); spin_unlock(&vb->lock); } rcu_read_unlock(); @@ -2801,7 +2805,7 @@ static void _vm_unmap_aliases(unsigned long start, unsigned long end, int flush) * not purgeable, check whether there is dirty * space to be flushed. */ - if (!purge_fragmented_block(vb, vbq, &purge_list, false) && + if (!purge_fragmented_block(vb, &purge_list, false) && vb->dirty_max && vb->dirty != VMAP_BBMAP_BITS) { unsigned long va_start = vb->va->va_start; unsigned long s, e;