From patchwork Thu Jun 6 11:10:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13688291 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7002C25B75 for ; Thu, 6 Jun 2024 11:11:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF2C410E8D6; Thu, 6 Jun 2024 11:11:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="FubXOwkz"; dkim-atps=neutral Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B5F210E8EE for ; Thu, 6 Jun 2024 11:11:22 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a6265d48ec3so98489766b.0 for ; Thu, 06 Jun 2024 04:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717672280; x=1718277080; darn=lists.freedesktop.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=pswOTtwBv3zIZovO9Qr4d5tz863/qgk3gUc3EVk4oGo=; b=FubXOwkzGw7wq+DcOQUnoAlLHRgx8OSvpmhpPa4cfRXzQ7x59/bsZImt2tyDcCKRvT TaJNTV5uCdf9FwUIiLrcHbuTIUWBrcFyYU2qn+QzrRJBA2gzOQFhjpJ5qA6sa1a9/IPD alEsClQh9VeBGmYHexbofckCv0TXG7ubAmgrGF9N8pgDhwr1D8P/wOxTQ9IgDxgT+v3s Ejg1Axzab8SfDvWFdH2II3xRhb4KFnEAPb3kYMMIfpCgfryM+z4EKHEC/hPAFI5uftPC AEK87qlvbaLo4ILYCy/VtTTCP3BpY4lE2Jd+XKWBahT+/0JIc/2aAJ2u8XMfVO8s0SuI 4i2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717672280; x=1718277080; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pswOTtwBv3zIZovO9Qr4d5tz863/qgk3gUc3EVk4oGo=; b=sHS5XwuaB7890PvV9JHgqkih4/jrt3n0tfKpluL9HKfQvZkWz6UbLtzF9PtHKiSxJz X+KvV6KK9G7J7Dwp3ICvCa2szzVnXnLUTWy4h9umkKjFeQrA9ixbYVU3yApZwmVr/fsG nRl9C8BekyiUlIzL1V6AokmD4bz8T6qG8LatGDyKj1R9L/nS3KwXHJ5BoQTBhEdfFbN4 jrb+CFFrZlOx4SI47niDKRtPHuxnbGxVilaCMXbGWYQKwN2/a83BhL2DDq91lz6vkMYQ j4rJh6FGjlOSwxXhqweuOYroJJojNpZ+rtAZcQ86DYA9XkMis3fYKCyB9XvP4MQkuGpb ewrw== X-Forwarded-Encrypted: i=1; AJvYcCV3zzdFkPe1Py2jj++SmxT8F2g5mXp9YXmDf6kUdXPj9FASsMKwTJ1ym76MHtm0Urp8a3fifsZYWy6H9V2m4UjefkHIMsdy5xdJ5D4mp5ZP X-Gm-Message-State: AOJu0YxiBcV13+M0JDQWZzPNHmUcPiyhJyrdWarkukjTNWUyY3PqzdIv 3iZjGJ9BhVTNLDjI/li+fV+4STOorQjb5x041Iq0AGA+1I42WCaFbNk9Skth18Q= X-Google-Smtp-Source: AGHT+IHmyWxJzfXZI/7TrL+CVbTgNs57aPkmFDQ9Y2zmJIYoz1GTSYJenkqQ4Qfqa4czEODu9Ho3+A== X-Received: by 2002:a17:906:d181:b0:a68:c2dd:8ce0 with SMTP id a640c23a62f3a-a699fab8b68mr332921166b.13.1717672280445; Thu, 06 Jun 2024 04:11:20 -0700 (PDT) Received: from [192.168.128.139] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6c80581b5esm82609166b.3.2024.06.06.04.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 04:11:19 -0700 (PDT) From: Konrad Dybcio Date: Thu, 06 Jun 2024 13:10:49 +0200 Subject: [PATCH] drm/msm/a6xx: Fix A702 UBWC mode MIME-Version: 1.0 Message-Id: <20240606-topic-a702_ubwcmode-v1-1-283fa9588af8@linaro.org> X-B4-Tracking: v=1; b=H4sIADiZYWYC/x3MSQqAMAxA0atI1hZincCriIimqWahldYJxLtbX L7F/w8E9sIBmuQBz6cEcWtEliZA87BOrMREg0ZdYIWV2t0mpIYadX+MFy3OsDJEpTWMNs8RYrl 5tnL/17Z73w/J8xNPZQAAAA== To: Rob Clark , Sean Paul , Abhinav Kumar , Dmitry Baryshkov , David Airlie , Daniel Vetter Cc: Marijn Suijten , Rob Clark , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Connor Abbott , Konrad Dybcio X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1717672278; l=1178; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Ldc+cMjnwRL8nNUZJjSiU8UmJQHSwKHt5iyZLBbi+zM=; b=D3kFiXSEs1918VgiCdBOZ1/YGTXUMjoAlJK+iua109QgkNzopKU7GVJI8O2igJRd19wo1U7p/ 7ywEF+9sq67AJ93AEDcLzm+Qa5Rj9iheryNjZC3qYqRiEwp8rV5bqSd X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" UBWC_MODE is a one-bit-wide field, so a value of 2 is obviously bogus. Replace it with the correct value (0). Fixes: 18397519cb62 ("drm/msm/adreno: Add A702 support") Reported-by: Connor Abbott Closes: https://lore.kernel.org/linux-arm-msm/CACu1E7FTN=kwaDJMNiTmFspALzj2+Q-nvsN5ugi=vz4RdUGvGw@mail.gmail.com/ Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: ee78a17615ad0cfdbbc27182b1047cd36c9d4d5f change-id: 20240606-topic-a702_ubwcmode-dcc5fde0f330 Best regards, diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 973872ad0474..5383aff84830 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -1409,7 +1409,7 @@ static void a6xx_calc_ubwc_config(struct adreno_gpu *gpu) if (adreno_is_a702(gpu)) { gpu->ubwc_config.highest_bank_bit = 14; gpu->ubwc_config.min_acc_len = 1; - gpu->ubwc_config.ubwc_mode = 2; + gpu->ubwc_config.ubwc_mode = 0; } }