From patchwork Fri Jun 7 17:06:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: TJ Adams X-Patchwork-Id: 13690555 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82852198E86 for ; Fri, 7 Jun 2024 17:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717780014; cv=none; b=t8kJCYozTshczZzuht63rIFkhPQmY/wZxuXIttrt7pIQ/u332wRjqcPRrQqEjTaJ6pFdwcjVFF9W1J7OKMTxdN8NSDjvztkjlKpjHVj9At27XEQ2h3xj2zOTzj0Ww9ROuBGL+YyfnFNucy4TtUYt4h+k9i5x5wH/QWyN3AsZlOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717780014; c=relaxed/simple; bh=kceaFwwjaSlBmkhXtusA3USI+23jbBoLODkMZKgX7RE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=U0aPT7uA1CpUg+SetFfNQSuskPQMta4Nn4nTd/lB9fJmzdibUGsamWJGUSs5xX+QnWmffUYuFOBzNHRscbMDVDEJYvZW0dRNT1ACIV7pmDJUYLHFYt2BdGu5nAw5tYbTqIAuX1mOOiQQa7TmEFwm7DCM6xYE2Mat7cADiOoapbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tadamsjr.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=mdlzbKav; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tadamsjr.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mdlzbKav" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-df78ea30f83so3930331276.1 for ; Fri, 07 Jun 2024 10:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717780011; x=1718384811; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=68M9FutlL8cAjPUlj6bX6OztbAKg98sW3h68noYav98=; b=mdlzbKavxpchLMVgpDhuCEf3Vw3rlSScTo8AR1cOVKYWhSoKCO8sd1kG4o8hKM38zB WFRkkDmd1o8AwrwTfIuGkXc9FQSwyrOOogNqgbu28H4W3VbF76zc2heqBRMBfduoKvot dbtDXDJZwASVfMJmv3sF6YXmqJvKtED6jYsPsGucDd0eqEK0NMs9WE3OatNcUj3nX1FC qIbD8iKkukRA9WwFyzUhLaH8AGbDvPae6o4WB1sFyq0InGkqpTD7ifTfN7i5AGDtnqwz 4HaVqIMa0IMWTf6dYINYbIt19d6TC0jAR6RWfHgXYNBwAfVQGIUqrkB2Xh5oS3CTZUJx Colw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717780011; x=1718384811; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=68M9FutlL8cAjPUlj6bX6OztbAKg98sW3h68noYav98=; b=Tib59SI70cb/BHNrKptr2E1zNI+2urdz2AHF6LRyxzkHKGF3ddnvBdmMgzycu9/y9+ rG0R/hW2YgH69dQ0F8xVnNNQtjJJP+Cq6s8WGzii6/lIGweYdDej2VYOcLbitivXnE2/ eETWcW2KVKUhYx29cDPENH4t0vih0tzXrm5aK+7ARJmFevRulln6mKkGSAry5D5JboWH YhU3m/7RFMNP+qR9vIoOjZMlR7D0vU/DWzlsm3tCxO6zPIj0HhfRr7I2nCNCtBH++FNv FkCocxOfr4bFX2Sw8ZgY6hyZ+s8RYEiBzBYhAJgAE5oN3csrZSLBWJ0WfFMTL3bb6pNS v/aQ== X-Gm-Message-State: AOJu0YzodUlN8K3fjHL+JE0wiyxQmpAyWunmzL7m3t/b55Yg78Pgt2zC TqJNv2Cmj/8utRx4iwAiYhUEbUsEFVYRHKN828FRLYO4nbFX6cLYzvrwZaZ+xNdvm5BJhQF7Iwh 4AuPAgMeVKw== X-Google-Smtp-Source: AGHT+IFT5aEoM2VyFyvMEdDzIdkli7oOXjB1ywaBH9N15G5CUpvbx40Ae/EvDQg+bdLIXR18sBr4Kj91Gu9sMQ== X-Received: from tadamsjr.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:177c]) (user=tadamsjr job=sendgmr) by 2002:a05:6902:1209:b0:dfa:ff27:db9 with SMTP id 3f1490d57ef6-dfaff2712cdmr498457276.5.1717780011508; Fri, 07 Jun 2024 10:06:51 -0700 (PDT) Date: Fri, 7 Jun 2024 17:06:37 +0000 In-Reply-To: <20240607170639.3973949-1-tadamsjr@google.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240607170639.3973949-1-tadamsjr@google.com> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog Message-ID: <20240607170639.3973949-2-tadamsjr@google.com> Subject: [PATCH 1/3] scsi: pm80xx: Set phy->enable_completion only when we wait for it From: TJ Adams To: jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, ipylypiv@google.com, Terrence Adams From: Igor Pylypiv pm8001_phy_control() populates the enable_completion pointer with a stack address, sends a PHY_LINK_RESET / PHY_HARD_RESET, waits 300 ms, and returns. The problem arises when a phy control response comes late. After 300 ms the pm8001_phy_control() function returns and the passed enable_completion stack address is no longer valid. Late phy control response invokes complete() on a dangling enable_completion pointer which leads to a kernel crash. Signed-off-by: Igor Pylypiv Signed-off-by: Terrence Adams --- drivers/scsi/pm8001/pm8001_sas.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c index a5a31dfa4512..ee2da8e49d4c 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c @@ -166,7 +166,6 @@ int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func, unsigned long flags; pm8001_ha = sas_phy->ha->lldd_ha; phy = &pm8001_ha->phy[phy_id]; - pm8001_ha->phy[phy_id].enable_completion = &completion; if (PM8001_CHIP_DISP->fatal_errors(pm8001_ha)) { /* @@ -190,6 +189,7 @@ int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func, rates->maximum_linkrate; } if (pm8001_ha->phy[phy_id].phy_state == PHY_LINK_DISABLE) { + pm8001_ha->phy[phy_id].enable_completion = &completion; PM8001_CHIP_DISP->phy_start_req(pm8001_ha, phy_id); wait_for_completion(&completion); } @@ -198,6 +198,7 @@ int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func, break; case PHY_FUNC_HARD_RESET: if (pm8001_ha->phy[phy_id].phy_state == PHY_LINK_DISABLE) { + pm8001_ha->phy[phy_id].enable_completion = &completion; PM8001_CHIP_DISP->phy_start_req(pm8001_ha, phy_id); wait_for_completion(&completion); } @@ -206,6 +207,7 @@ int pm8001_phy_control(struct asd_sas_phy *sas_phy, enum phy_func func, break; case PHY_FUNC_LINK_RESET: if (pm8001_ha->phy[phy_id].phy_state == PHY_LINK_DISABLE) { + pm8001_ha->phy[phy_id].enable_completion = &completion; PM8001_CHIP_DISP->phy_start_req(pm8001_ha, phy_id); wait_for_completion(&completion); } From patchwork Fri Jun 7 17:06:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: TJ Adams X-Patchwork-Id: 13690556 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 326C819AA77 for ; Fri, 7 Jun 2024 17:06:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717780015; cv=none; b=L4QsZT+d5w6sFVEEZFs09XUAhemEVDleyCQxm2lEg8ywj1AqP3SvZo1NnNrMczs9tquhET34EGUIdBVy+efbeFXI9qo0Vyn3TF6OBRTp2vVwUrFKCUcomUbtRip7M5B8SHJbnlCkYy49cmFfEeFGQ5ikIwIWCVvBS+bsm2FIFOI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717780015; c=relaxed/simple; bh=77RomTbxoT5IvK9cD9wwGOCTWkN2mvquDo1FazG6ADk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZLNRo0X+axfl3/yMfjBsIAKOYAjkG0aaxe6jhhlSUsJ6QXVT/kN6LNU3UbRMdTaTk1sNOsVDLmi1xmvDp58r3WQcNsX3f3myAXRKCYsyUhSDvBb4iD5alZ30urEFg8V85Bc//0A5rsNTKYLSIT8Os4vA/yrc54SBeFLD3zMmtkk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tadamsjr.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gj1NYkkH; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tadamsjr.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gj1NYkkH" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-62c7a4f8cd6so45191257b3.0 for ; Fri, 07 Jun 2024 10:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717780013; x=1718384813; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Gu46/3S2zZA6k5Oex8T+jABLwZXyDcysB54lkLA/uRc=; b=gj1NYkkHKOiXOYBlKK0ynGMiOI3U6HcVpjwOkaz+3hfNpV7vN5C2lAioyCCr1YhQZL f7C69lClVVPFw1mMQM7GreJ0avxuhQuYsMB5Ixt/TyBAD3uDkPf4o3Vyqu0jL41sO1SR G5Uf8EtJyeNmdUDjH21tjtDSWhHCyIyHYQ7WtrW47huwat15r4SxUt5R/vW4NFDKX+Qm V5cL18dZebAf47CghP3V9+SjAhniFB3Vh9uLlfp4otSGCQ180NE5awz6hgDrkw2xMAzZ pVCkygxxKkClQdutOI16S+l2YFlonT36/d7SdMgl3upBf+PIydSkLh62+cISnZtMOX4j WvmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717780013; x=1718384813; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gu46/3S2zZA6k5Oex8T+jABLwZXyDcysB54lkLA/uRc=; b=rwbO/IovNuKn21ZvUJ9tfeI2JzhySkrYhoCN8+swY6u0CZ8EnX0qCbMufg1oCOoL5I wucIiqAQt7LYoa5A7VTLsuTOZSqoiWAdYmnyA8+zlL8hnu7KJ6COxEJPBfxtY3m9R325 GaGzzcOFurpJb54VmWiOcW5mKbql71NAeBAphYXowq9rVtihwgZoH47nwkebnWNrjBYr +UgthU4ZukMw/isChMRQlRwYry8GrpA3elwyIqygGz4hfsfsIPZ7MBasVTx05/QZuTZ3 8JQHVI5CRo2GH8V08j80+mWOxoMuobLPReVjbJoS8nkaapFf4TJfY89vCDBPVPBk7zpc mVOA== X-Gm-Message-State: AOJu0YxlAV9ougrogyLHHXFfdXtqeR9P2E4ajHJWDM1owAd69ZinWL1h GLtLKsSmHl+NzwPrVeceLurWp2012qPfkFsjprx8yMVdcGf5/aQUp1r69z0ofxPJ6AR0MoP0hFf OhlZ3oWk67g== X-Google-Smtp-Source: AGHT+IEBUs3uUV5tTDdeJVp0mGVtfQhaJBiNAC5D5idG3gpWD28gJrfuM1uQfFzs/ISfUztDpKhEvtBJna4YAQ== X-Received: from tadamsjr.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:177c]) (user=tadamsjr job=sendgmr) by 2002:a25:6f08:0:b0:deb:88f5:fa10 with SMTP id 3f1490d57ef6-dfaf652eb7bmr616555276.5.1717780013124; Fri, 07 Jun 2024 10:06:53 -0700 (PDT) Date: Fri, 7 Jun 2024 17:06:38 +0000 In-Reply-To: <20240607170639.3973949-1-tadamsjr@google.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240607170639.3973949-1-tadamsjr@google.com> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog Message-ID: <20240607170639.3973949-3-tadamsjr@google.com> Subject: [PATCH 2/3] scsi: pm80xx: Do not issue hard reset before NCQ EH From: TJ Adams To: jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, ipylypiv@google.com, Terrence Adams From: Igor Pylypiv v6.2 commit 811be570a9a8 ("scsi: pm8001: Use sas_ata_device_link_abort() to handle NCQ errors") removed duplicate NCQ EH from the pm80xx driver and started relying on libata to handle the NCQ errors. The PM8006 controller has a special EH sequence that was added in v4.15 commit 869ddbdcae3b ("scsi: pm80xx: corrected SATA abort handling sequence."). The special EH sequence issues a hard reset to a drive before libata EH has a chance to read the NCQ log page. Libata EH gets confused by empty NCQ log page which results in HSM violation. The failed command gets retried a few times and each time fails with the same HSM violation. Finally, libata decides to disable NCQ due to subsequent HSM vioaltions. To avoid unwanted hard resets we can initiate abort all from the driver to prevent libsas EH from calling lldd_abort_task()/pm8001_abort_task(). Signed-off-by: Igor Pylypiv Signed-off-by: Terrence Adams --- drivers/scsi/pm8001/pm8001_hwi.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index dec1e2d380f1..f19f76dc6e1c 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c @@ -1672,7 +1672,18 @@ void pm8001_work_fn(struct work_struct *work) break; case IO_XFER_ERROR_ABORTED_NCQ_MODE: { + struct pm8001_hba_info *pm8001_ha = pw->pm8001_ha; dev = pm8001_dev->sas_device; + /* + * pm8001_abort_task() issues a hard reset to a drive + * before libata EH has a chance to read the NCQ log page. + * + * Initiate abort all from the driver to prevent libsas EH + * from calling lldd_abort_task() / pm8001_abort_task(). + */ + if (pm8001_ha->chip_id == chip_8006) + sas_execute_internal_abort_dev(dev, 0, NULL); + sas_ata_device_link_abort(dev, false); } break; From patchwork Fri Jun 7 17:06:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: TJ Adams X-Patchwork-Id: 13690557 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA0FB198E86 for ; Fri, 7 Jun 2024 17:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717780017; cv=none; b=UoPr72ZDzls29Yi8GK8X0L8AygbIV7T+QL7YMIAluAzl+KGVer0WFUrz9bDrk/a1wrcnfs6ZJ9moO7WW8Dm+YuzpViUvYcgAQobHPW8dBjuFInL6n1th3uoN+z+1A+WRtDJ9+ZvR7hkuATzU4vu54l1prZ+0p7GaldFs02HisKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717780017; c=relaxed/simple; bh=iAbPGXH/r5gL1hZgWkLgKCD1/WIGTyanOjQWhd5s0L4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=b13bBHstMOSN/Kjem4FjWp74WgJE7vDkYG1TCUYU3S37y3Gn9EMOlLLv6Q3HDgQP3DyxfEmfu0HbYvsMMf9BrA+GGvYQn3Pjv+PgEX3/AUzVBOMgUZGNv49/ddI0fQJA/t7LkFHyqytxHgQKJ/HFFbloMw7Ms9eN6v33qmhlAto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tadamsjr.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ps715JDL; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tadamsjr.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ps715JDL" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dfa75354911so3818497276.0 for ; Fri, 07 Jun 2024 10:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717780015; x=1718384815; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+1aQwu1iGrHhm3SengJCu2MFtSP+MYd6cSL40GeM53Y=; b=ps715JDLGptltPdCPW3QatT/4wDBnjFNt4gBDKcCK8kviV6yKg46wfSlqCl9mz7srx y1IpgPGzoNtqDCJ/MRJAfNJ+m23FNx+2Qi27R1nz9oe3Y3T6BRgvPF1uwqyQR2qL+YqM EBk8UmILBL9mjAKMSnz2FFaGwWeQFqlC9ijyCsLlAin0gk1EB4BFVvKO7wh6OBNCyd8i FOZCGApB9gIE5vVD1P04K62kwjaQqd/ahND9iF9x8EaJjqFDCUKLqyrmo/Imq32WIMxE igfHkxN4QPNy0jXghr3W5htLMBjUNFxdGP9wvCMkj5u4EOulOjEG/z+7nZG8fp7BBtcq jFOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717780015; x=1718384815; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+1aQwu1iGrHhm3SengJCu2MFtSP+MYd6cSL40GeM53Y=; b=kDQvZp14l0akGk1dzOqH5CfNBJg0bNmW4MS6NSEEGPywLiodo8RJmgME/x5tFokn+X G1Qx850/98ndDM/Lp/jYGXgLrWdgUQf5Iselz8l18hpQHgdkuXwYZ02gu/fYI9A12S59 kszS43wutmkNKcCHS+Sm5aXutmfPNGXZCwWZ1X4bJMsLI46EjfcMZZxf2Q61M+U5Iloj FHeKA7VSAZZ6/2S06ke2JvgXiuxNHLBBaIc/9i4Erb8EbJ6V+iii6QRknBAccbX1D0vo VVtQ+Xaja31qIizaTVqSmA1FUPkLr5OfFSrLhsSghrSHF16gYLbXbw9EaB3gom1m5gq1 7A5Q== X-Gm-Message-State: AOJu0YxGOi7ud273VQXKydVEmuIWybNycW4/DlCFr6U0mey1P+cxFiE1 Iqr01AxRyzkOO3UheHFKU5woSHP7Uz0DTc/4TgPyifM+jw6cazxE9GacFB7DxbszVacpyMTEMxt dU/PzldxQSA== X-Google-Smtp-Source: AGHT+IEWfyGzm83cGRqGBS0J9f1TYfWuqmEnzU14H2go4y66H8sDPlOOnoW013f8z11MSu4bAHBo7PH7HlEepQ== X-Received: from tadamsjr.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:177c]) (user=tadamsjr job=sendgmr) by 2002:a05:6902:1009:b0:dd9:2d94:cd8a with SMTP id 3f1490d57ef6-dfaf6647ademr268916276.9.1717780014727; Fri, 07 Jun 2024 10:06:54 -0700 (PDT) Date: Fri, 7 Jun 2024 17:06:39 +0000 In-Reply-To: <20240607170639.3973949-1-tadamsjr@google.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240607170639.3973949-1-tadamsjr@google.com> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog Message-ID: <20240607170639.3973949-4-tadamsjr@google.com> Subject: [PATCH 3/3] scsi: pm8001: Update log level when reading config table From: TJ Adams To: jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, ipylypiv@google.com, Terrence Adams From: Terrence Adams Reading the main config table occurs as a part of initialization in pm80xx_chip_init(). Because of this it makes more sense to have it be a part of the INIT logging. Signed-off-by: Terrence Adams --- drivers/scsi/pm8001/pm80xx_hwi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c index a52ae6841939..8fe886dc5e47 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -568,13 +568,13 @@ static void read_main_config_table(struct pm8001_hba_info *pm8001_ha) pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version = pm8001_mr32(address, MAIN_MPI_INACTIVE_FW_VERSION); - pm8001_dbg(pm8001_ha, DEV, + pm8001_dbg(pm8001_ha, INIT, "Main cfg table: sign:%x interface rev:%x fw_rev:%x\n", pm8001_ha->main_cfg_tbl.pm80xx_tbl.signature, pm8001_ha->main_cfg_tbl.pm80xx_tbl.interface_rev, pm8001_ha->main_cfg_tbl.pm80xx_tbl.firmware_rev); - pm8001_dbg(pm8001_ha, DEV, + pm8001_dbg(pm8001_ha, INIT, "table offset: gst:%x iq:%x oq:%x int vec:%x phy attr:%x\n", pm8001_ha->main_cfg_tbl.pm80xx_tbl.gst_offset, pm8001_ha->main_cfg_tbl.pm80xx_tbl.inbound_queue_offset, @@ -582,7 +582,7 @@ static void read_main_config_table(struct pm8001_hba_info *pm8001_ha) pm8001_ha->main_cfg_tbl.pm80xx_tbl.int_vec_table_offset, pm8001_ha->main_cfg_tbl.pm80xx_tbl.phy_attr_table_offset); - pm8001_dbg(pm8001_ha, DEV, + pm8001_dbg(pm8001_ha, INIT, "Main cfg table; ila rev:%x Inactive fw rev:%x\n", pm8001_ha->main_cfg_tbl.pm80xx_tbl.ila_version, pm8001_ha->main_cfg_tbl.pm80xx_tbl.inc_fw_version);