From patchwork Tue Jun 11 14:49:12 2024
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Steven Rostedt <rostedt@goodmis.org>
X-Patchwork-Id: 13693872
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A3C80C27C75
	for <linux-mm@archiver.kernel.org>; Tue, 11 Jun 2024 14:49:40 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id 8E6C96B00A4; Tue, 11 Jun 2024 10:49:38 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 894646B00A5; Tue, 11 Jun 2024 10:49:38 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 6E6E86B00A6; Tue, 11 Jun 2024 10:49:38 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com
 [216.40.44.14])
	by kanga.kvack.org (Postfix) with ESMTP id 4F8406B00A4
	for <linux-mm@kvack.org>; Tue, 11 Jun 2024 10:49:38 -0400 (EDT)
Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1])
	by unirelay08.hostedemail.com (Postfix) with ESMTP id 03F941408F7
	for <linux-mm@kvack.org>; Tue, 11 Jun 2024 14:49:37 +0000 (UTC)
X-FDA: 82218891636.29.E109CB0
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
	by imf15.hostedemail.com (Postfix) with ESMTP id 3DCE1A0003
	for <linux-mm@kvack.org>; Tue, 11 Jun 2024 14:49:35 +0000 (UTC)
Authentication-Results: imf15.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=pass (imf15.hostedemail.com: domain of
 "SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as
 permitted sender) smtp.mailfrom="SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
 d=hostedemail.com;
	s=arc-20220608; t=1718117375;
	h=from:from:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:content-transfer-encoding:in-reply-to:
	 references:references; bh=bSvhJ4Q1mzHI+U9+5/HN/kopc3HpcHLFPrC0sUaTll4=;
	b=OwK/3YvoIJMvAogUes2iBxONQO1EYwg3rIm39GLZ+aVqvMoE9su1MOf39QykwpddSn9ksw
	LZunm9bDZo8H2H03TWtTanbdt2zvwNo0IJ5qju++bwSVC9yeD+FeC+QlSegEqX15tmUwpv
	tsmzxOiRAN1kM6+jFtHwCuoR5lP5vv4=
ARC-Authentication-Results: i=1;
	imf15.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=pass (imf15.hostedemail.com: domain of
 "SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as
 permitted sender) smtp.mailfrom="SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org"
ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718117375; a=rsa-sha256;
	cv=none;
	b=3iYGVA1PTTIi0SUgyxXcUqfv1vtypDFOwhJ9IKl0eRpC8uZpT9MgBczyOTvp6b7NT81BGX
	pxnI6T6RrqTTYwxIfBqmgIYB/0ny5dtgBmqom2YOU+vHU0AArzjL6e9XIoUYjrbUVmVv1U
	uJpEerPzL+gDOGT+YQ6955DBUiYwpLk=
Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])
	by dfw.source.kernel.org (Postfix) with ESMTP id 184AE60EE0;
	Tue, 11 Jun 2024 14:49:34 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96C44C4AF49;
	Tue, 11 Jun 2024 14:49:33 +0000 (UTC)
Received: from rostedt by gandalf with local (Exim 4.97)
	(envelope-from <rostedt@goodmis.org>)
	id 1sH2on-00000001Onf-2roL;
	Tue, 11 Jun 2024 10:49:49 -0400
Message-ID: <20240611144949.544382280@goodmis.org>
User-Agent: quilt/0.68
Date: Tue, 11 Jun 2024 10:49:12 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "Liam R. Howlett" <Liam.Howlett@oracle.com>,
 Vlastimil Babka <vbabka@suse.cz>,
 Lorenzo Stoakes <lstoakes@gmail.com>,
 linux-mm@kvack.org,
 Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org,
 "H. Peter Anvin" <hpa@zytor.com>,
 Peter Zijlstra <peterz@infradead.org>,
 Kees Cook <keescook@chromium.org>,
 Tony Luck <tony.luck@intel.com>,
 "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
 linux-hardening@vger.kernel.org,
 Guenter Roeck <linux@roeck-us.net>,
 Ross Zwisler <zwisler@google.com>,
 wklin@google.com,
 Vineeth Remanan Pillai <vineeth@bitbyteword.org>,
 Joel Fernandes <joel@joelfernandes.org>,
 Suleiman Souhlal <suleiman@google.com>,
 Linus Torvalds <torvalds@linuxfoundation.org>,
 Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>,
 Ard Biesheuvel <ardb@kernel.org>,
 Mike Rapoport <rppt@kernel.org>
Subject: [PATCH v3 1/2] mm/memblock: Add "reserve_mem" to reserved named
 memory at boot up
References: <20240611144911.327227285@goodmis.org>
MIME-Version: 1.0
X-Rspamd-Queue-Id: 3DCE1A0003
X-Rspamd-Server: rspam10
X-Rspam-User: 
X-Stat-Signature: 7wqoy6uqpx7q5dcs1js3mton6q3tdwfd
X-HE-Tag: 1718117375-318862
X-HE-Meta: 
 U2FsdGVkX1+T/kf/jRMBZ1c7W04wSXJHMSAmrOcBUpY5D6I6OI8iRp7W4ohMPPSoxNEAlO8PjOO17vOhOVTkkEdwyRvF4WS4cIZj7o4+R65++APKSL+NRdDuiN0Gf/zId+5+3FKJCmWU30rBew8U6UwxHcbXqVgZMOMF2SfZz1P1+xAvgIMcSvhO172YhS3O8hXN7T4Hym7HiYmeMBBXsjZ+iGgXo1TfU0suvrcg8RKLONZN3BdDs5WtzRaBmPn6QTBuIyizG6qg2CrZoEu01BG1rWGHWnza41ZoKtJ2tHdYeR4nw2cnNcKO4S45X9YFV1X/XecnXPJhe25OzQu/0modEKq6TyJEBFl0GFeUqwyxtlqZhgTwZ6Bga/q4IwmhRZQi+hxP/HAuCzizeaOW3DOlhXMgtRRIQl2FHGcidy1BZxdgamCs2TEaS8vBi0vWEOAB2V0NvgpH66GA/SVAHIXugeLJ8CILemzzSXPe3JsGVlaFTQqSNEt0sTy3SPUHdd+9TLOylfC2wSEwCYOd268RtDkseE8N58OBaVANA1r7FB+xJH4BySWthTORIJVRydHmkCL25HIKwqi0Tdl5UT1FrJ4ZrImzvengnDsLPa4ycdI5/gK+bvzzc4imGEluWUDSPuo5jG6htVwLdXm9rtTnIJhGvOpeuj56qSxD3YGvJAHCwxI6G5IJAijoRAIBiqw+KXrKtB78SIfRPm+O8Vubv/0ADSIC1AdlFnXokds5fuMFL5otqc67n5bF9kmzZ4hjE0i7r9F6FgOwvN9p39U9bcO7PnxJQw2+Sl9nR9b5WV5gQgIjl814TbRudrwFlt5hWDmQUlb7TwGDZB00sJ518+SlbheVtH0MYVn9hrAKmgkUeDErLHnrRWZO2K7vBIflyS/HkcAUH6IaTW50GKkAhFA4dUuG0Ji/NznVP/j6yXM8frje2vReEGrJ9efBnhc0pE/nfNGBDhORCb2
 RFNmhFyG
 VanxYm3AI8gBOCMRPJL7uPnm3mtUf7rsFJup3mlPHUG+pT5ONtcmJMVo5FMtbCgVsUD/PPM/HYZx/rRRiBzZXe5E8iwcueOzFoM+k3Yfg3zLUBONlbPpBlkB81dYX4bHZN5zXJXBJPDHadyy+ENo5j0pCHA9ZKFOznbeWB4Ugyyo0JA0spCGi6lgvEwConLLNh6XY/rsCfPlr3F7UtxmyFMah6s3or/noOoJebINbuoTqinRnPv0Qqb+emdTZwsz0tP6HyPp/Y/M9QSzXJnDGqSwOyIvd8CuEgKfh5yKaC7CYzXQ8+bcrj/itLGyn6QsFWYJ0zRh9x+nzlaSDM8CPdBaRCy4X51YIdF9U0ekTW6Mgh4J93yQN5LftFPZHU9EhWSoIjn+cJ6olIBc0yceGY6KwuEBKhpq/hSiTEtfcgI+9PCod6pc4B0Lqqm/UGp1jClTIyocJc6N04Q4=
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>
List-Subscribe: <mailto:majordomo@kvack.org>
List-Unsubscribe: <mailto:majordomo@kvack.org>

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

In order to allow for requesting a memory region that can be used for
things like pstore on multiple machines where the memory layout is not the
same, add a new option to the kernel command line called "reserve_mem".

The format is:  reserve_mem=nn:align:name

Where it will find nn amount of memory at the given alignment of align.
The name field is to allow another subsystem to retrieve where the memory
was found. For example:

  reserve_mem=12M:4096:oops ramoops.mem_name=oops

Where ramoops.mem_name will tell ramoops that memory was reserved for it
via the reserve_mem option and it can find it by calling:

  if (reserve_mem_find_by_name("oops", &start, &size)) {
	// start holds the start address and size holds the size given

This is typically used for systems that do not wipe the RAM, and this
command line will try to reserve the same physical memory on soft reboots.
Note, it is not guaranteed to be the same location. For example, if KASLR
places the kernel at the location of where the RAM reservation was from a
previous boot, the new reservation will be at a different location.  Any
subsystem using this feature must add a way to verify that the contents of
the physical memory is from a previous boot, as there may be cases where
the memory will not be located at the same location.

Not all systems may work either. There could be bit flips if the reboot
goes through the BIOS. Using kexec to reboot the machine is likely to
have better results in such cases.

Link: https://lore.kernel.org/all/ZjJVnZUX3NZiGW6q@kernel.org/

Suggested-by: Mike Rapoport <rppt@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
Changes since v2: https://lore.kernel.org/linux-trace-kernel/20240606150316.751642266@goodmis.org

- Fixed typo "reserver"

- Added EXPORT_SYMBOL_GPL() for reserve_mem_find_by_name()

 .../admin-guide/kernel-parameters.txt         | 20 ++++
 include/linux/mm.h                            |  2 +
 mm/memblock.c                                 | 98 +++++++++++++++++++
 3 files changed, 120 insertions(+)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index b600df82669d..ce7de8136f2f 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -5710,6 +5710,26 @@
 			them.  If <base> is less than 0x10000, the region
 			is assumed to be I/O ports; otherwise it is memory.
 
+	reserve_mem=	[RAM]
+			Format: nn[KNG]:<align>:<label>
+			Reserve physical memory and label it with a name that
+			other subsystems can use to access it. This is typically
+			used for systems that do not wipe the RAM, and this command
+			line will try to reserve the same physical memory on
+			soft reboots. Note, it is not guaranteed to be the same
+			location. For example, if KASLR places the kernel at the
+			location of where the RAM reservation was from a previous
+			boot, the new reservation will be at a different location.
+			Any subsystem using this feature must add a way to verify
+			that the contents of the physical memory is from a previous
+			boot, as there may be cases where the memory will not be
+			located at the same location.
+
+			The format is size:align:label for example, to request
+			12 megabytes of 4096 alignment for ramoops:
+
+			reserve_mem=12M:4096:oops ramoops.mem_name=oops
+
 	reservetop=	[X86-32,EARLY]
 			Format: nn[KMG]
 			Reserves a hole at the top of the kernel virtual
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 9849dfda44d4..b4455cc02f2c 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -4263,4 +4263,6 @@ static inline bool pfn_is_unaccepted_memory(unsigned long pfn)
 void vma_pgtable_walk_begin(struct vm_area_struct *vma);
 void vma_pgtable_walk_end(struct vm_area_struct *vma);
 
+int reserve_mem_find_by_name(const char *name, unsigned long *start, unsigned long *size);
+
 #endif /* _LINUX_MM_H */
diff --git a/mm/memblock.c b/mm/memblock.c
index d09136e040d3..60a2161de351 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -2244,6 +2244,104 @@ void __init memblock_free_all(void)
 	totalram_pages_add(pages);
 }
 
+/* Keep a table to reserve named memory */
+#define RESERVE_MEM_MAX_ENTRIES		8
+#define RESERVE_MEM_NAME_SIZE		16
+struct reserve_mem_table {
+	char			name[RESERVE_MEM_NAME_SIZE];
+	unsigned long		start;
+	unsigned long		size;
+};
+static struct reserve_mem_table reserved_mem_table[RESERVE_MEM_MAX_ENTRIES];
+static int reserved_mem_count;
+
+/* Add wildcard region with a lookup name */
+static int __init reserved_mem_add(unsigned long start, unsigned long size,
+				   const char *name)
+{
+	struct reserve_mem_table *map;
+
+	if (!name || !name[0] || strlen(name) >= RESERVE_MEM_NAME_SIZE)
+		return -EINVAL;
+
+	if (reserved_mem_count >= RESERVE_MEM_MAX_ENTRIES)
+		return -1;
+
+	map = &reserved_mem_table[reserved_mem_count++];
+	map->start = start;
+	map->size = size;
+	strscpy(map->name, name);
+	return 0;
+}
+
+/**
+ * reserve_mem_find_by_name - Find reserved memory region with a given name
+ * @name: The name that is attached to a reserved memory region
+ * @start: If found, holds the start address
+ * @size: If found, holds the size of the address.
+ *
+ * Returns: 1 if found or 0 if not found.
+ */
+int reserve_mem_find_by_name(const char *name, unsigned long *start, unsigned long *size)
+{
+	struct reserve_mem_table *map;
+	int i;
+
+	for (i = 0; i < reserved_mem_count; i++) {
+		map = &reserved_mem_table[i];
+		if (!map->size)
+			continue;
+		if (strcmp(name, map->name) == 0) {
+			*start = map->start;
+			*size = map->size;
+			return 1;
+		}
+	}
+	return 0;
+}
+EXPORT_SYMBOL_GPL(reserve_mem_find_by_name);
+
+/*
+ * Parse early_reserve_mem=nn:align:name
+ */
+static int __init reserve_mem(char *p)
+{
+	phys_addr_t start, size, align;
+	char *oldp;
+	int err;
+
+	if (!p)
+		return -EINVAL;
+
+	oldp = p;
+	size = memparse(p, &p);
+	if (p == oldp)
+		return -EINVAL;
+
+	if (*p != ':')
+		return -EINVAL;
+
+	align = memparse(p+1, &p);
+	if (*p != ':')
+		return -EINVAL;
+
+	start = memblock_phys_alloc(size, align);
+	if (!start)
+		return -ENOMEM;
+
+	p++;
+	err = reserved_mem_add(start, size, p);
+	if (err) {
+		memblock_phys_free(start, size);
+		return err;
+	}
+
+	p += strlen(p);
+
+	return *p == '\0' ? 0: -EINVAL;
+}
+__setup("reserve_mem=", reserve_mem);
+
 #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_ARCH_KEEP_MEMBLOCK)
 static const char * const flagname[] = {
 	[ilog2(MEMBLOCK_HOTPLUG)] = "HOTPLUG",

From patchwork Tue Jun 11 14:49:13 2024
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Steven Rostedt <rostedt@goodmis.org>
X-Patchwork-Id: 13693871
Return-Path: <owner-linux-mm@kvack.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 30BB8C27C77
	for <linux-mm@archiver.kernel.org>; Tue, 11 Jun 2024 14:49:38 +0000 (UTC)
Received: by kanga.kvack.org (Postfix)
	id B071F6B00A3; Tue, 11 Jun 2024 10:49:37 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id A8F686B00A4; Tue, 11 Jun 2024 10:49:37 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 8BA986B00A5; Tue, 11 Jun 2024 10:49:37 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com
 [216.40.44.11])
	by kanga.kvack.org (Postfix) with ESMTP id 6EBD26B00A3
	for <linux-mm@kvack.org>; Tue, 11 Jun 2024 10:49:37 -0400 (EDT)
Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1])
	by unirelay04.hostedemail.com (Postfix) with ESMTP id 231181A126B
	for <linux-mm@kvack.org>; Tue, 11 Jun 2024 14:49:37 +0000 (UTC)
X-FDA: 82218891594.26.1F25F42
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
	by imf21.hostedemail.com (Postfix) with ESMTP id 873661C0009
	for <linux-mm@kvack.org>; Tue, 11 Jun 2024 14:49:35 +0000 (UTC)
Authentication-Results: imf21.hostedemail.com;
	dkim=none;
	spf=pass (imf21.hostedemail.com: domain of
 "SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as
 permitted sender)
 smtp.mailfrom="SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org";
	dmarc=none
ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718117375; a=rsa-sha256;
	cv=none;
	b=odaKwXmXxrCkTUAGq+o/eSdqHiS5qTw+7HJ18y0Nvcyl634dc6yYqpptu7BcqJ4sRdUVv6
	y2gugWgiZwVqb3dZz5PDfLCN7M8bSQmAwckbfrv1YipDy7RA/e7m1Yyt6Gn2I7jGCzIM9x
	bVkWllxni0098jV7ckV2tRDY4CnUEDM=
ARC-Authentication-Results: i=1;
	imf21.hostedemail.com;
	dkim=none;
	spf=pass (imf21.hostedemail.com: domain of
 "SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as
 permitted sender)
 smtp.mailfrom="SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org";
	dmarc=none
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed;
 d=hostedemail.com;
	s=arc-20220608; t=1718117375;
	h=from:from:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:content-transfer-encoding:in-reply-to:
	 references:references; bh=ZR5VQ90ZVMnvrAnWcqdc5KE2OBHygirUwjTUkw3SWgM=;
	b=4YG6t6gRRcSZSdhTqmofndWK61XZFNr4e/cEHBMfW1gM/KRXMIU3AmvuZoX+pyuxpJOhxm
	oIAz4s1g2VCIsLZbN1gYx5fQcYj6ZtlBNv3V4UcXpwa19MqdOjsPD9qMWQyqVoIgALgseS
	UQdNqyfdladqos8jLWR7KKtSF3hz/8s=
Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])
	by dfw.source.kernel.org (Postfix) with ESMTP id 5229D60EE9;
	Tue, 11 Jun 2024 14:49:34 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C55C8C4AF61;
	Tue, 11 Jun 2024 14:49:33 +0000 (UTC)
Received: from rostedt by gandalf with local (Exim 4.97)
	(envelope-from <rostedt@goodmis.org>)
	id 1sH2on-00000001OoA-3XSY;
	Tue, 11 Jun 2024 10:49:49 -0400
Message-ID: <20240611144949.703297941@goodmis.org>
User-Agent: quilt/0.68
Date: Tue, 11 Jun 2024 10:49:13 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "Liam R. Howlett" <Liam.Howlett@oracle.com>,
 Vlastimil Babka <vbabka@suse.cz>,
 Lorenzo Stoakes <lstoakes@gmail.com>,
 linux-mm@kvack.org,
 Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>,
 x86@kernel.org,
 "H. Peter Anvin" <hpa@zytor.com>,
 Peter Zijlstra <peterz@infradead.org>,
 Kees Cook <keescook@chromium.org>,
 Tony Luck <tony.luck@intel.com>,
 "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
 linux-hardening@vger.kernel.org,
 Guenter Roeck <linux@roeck-us.net>,
 Ross Zwisler <zwisler@google.com>,
 wklin@google.com,
 Vineeth Remanan Pillai <vineeth@bitbyteword.org>,
 Joel Fernandes <joel@joelfernandes.org>,
 Suleiman Souhlal <suleiman@google.com>,
 Linus Torvalds <torvalds@linuxfoundation.org>,
 Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>,
 Ard Biesheuvel <ardb@kernel.org>,
 Mike Rapoport <rppt@kernel.org>
Subject: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line
 option
References: <20240611144911.327227285@goodmis.org>
MIME-Version: 1.0
X-Stat-Signature: shtp8p84567heayos8t1u5toyda8r9zb
X-Rspamd-Queue-Id: 873661C0009
X-Rspamd-Server: rspam04
X-Rspam-User: 
X-HE-Tag: 1718117375-191264
X-HE-Meta: 
 U2FsdGVkX1/Vk3OzA8u7S032RUByu8NW02eCvDj2epUGGAq6dz3OSLWgMAVUZzAe5u8GF5Rubo2B47uNGrz5JR69jTNTLZjyzY2AADzvA9pbxsHraG6BfSxWbXap1vQ/A1OuvuIEip7sjo8GPCNwIhjguXy/tcxMQDuEXSIO2LDPT+yLrnOwr7CAkRLXYQhlj9X3EBPbsXrUfjFKBxsz2UtWkyned+YC/SgOJH/rpd0fyCc/cAuVOgbMpTrlPlkhM9QqCBvKZoYAFxpZ/SQIe1/ekMWcO6lsDnuDawYOcZC7JObF5WXbM8meNISc+qx4fNkFww2tvo47feus2Sr5BiBSAKXGkEEavDoodfdk//DVpMPOpm9paJlpKQhsLOA3N748E+PwRi0gpTzDI+lnFFd7LrblTtMhoWmCq7Wxwla8ke1JS08JdLguwu6ANn21t0ACb3R9gHPre6FZMbFq43ZTLnVVqQ1SaFtGLm+b+2W8+Wg2uyMI9ixBdCbdjFH4OXuXARZWTGl32zhPgvjWXzfChJbI7mhn8IJMM8h/Ic3iPcikQWkEHiMVaQ8b77tgeNxytTC6gpkQPOcPsj3mFfk5T4ihoW/kLL9SPu55U8mAG+N6nT0nkxhejHwTdC8hXRjGLX39D44iljiY+Lfj5a1Zk/hAuto8w/Rnm0q1wQb1XMiv9UOWmoqmy4c1DUomFLKEu58bj47fEmThrDw0ty7ipQHjAsO4cLI8R+bfoTVAHJtmBNo0dt2sdg+T6clOBsdZe2M2CUZqU1U/vqy1tXEHYRItR8uTa9/7YmerbTf1NWf20yVOMdB0hPgtfApyrmqzqpw7pE5PVbaZ/PkgE6cqNC00QNJ5ZqjRup4iYj72EA1B7DvOE9tq8yuLvgPo7R+d/vneM8ijsCs1tm0XbMVocUG5x8rAmR4VPdn3OZcSkGkrI+m37am9kn+J2MIPh/OO62LtHdHgY5jYfXL
 DKqnJMmR
 VnOdSydTiBbmgTYudsVjpjNLvipRzwvrOytQ86hSkX3loLuvOzplmk/WqWpmvJxQDYoTWJGZQJqZgO3PBBgzBloZhn0OcXBZAJ1Q5PX2upRLBHH/5VcDPqk9Rug1n2fpUootsdh/JfljJNMMcKA3ukAJkDxB7lgw+KJ3W0NY4XiklEoZQC+kcu0ocohBpW1qSXzWSVufRN5tFT8WIYk72FkeqK0KZlQe46S1y3jxS25QS8RtlKLEAceN456qOkic9HSxbqechaF02EwrI7AwBnAqbykhLGqb8Djb6wBM8vuTzDQ22KzVIiIBV07VS7qZRqoY9Ubui2FDOssVjSjQRehd194OkBo/xssR1Agb7UQf3uFqoXVcGWK3vECuq5N2kWNGgfy4O1npi7X8Q6kOWnG8bmi5xpWbxHVf6N/Z1vix+N7T1LWyuUNBg+40M+0UbBR96E2bgLjpyOqQ=
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>
List-Subscribe: <mailto:majordomo@kvack.org>
List-Unsubscribe: <mailto:majordomo@kvack.org>

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

Add a method to find a region specified by reserve_mem=nn:align:name for
ramoops. Adding a kernel command line parameter:

  reserve_mem=12M:4096:oops ramoops.mem_name=oops

Will use the size and location defined by the memmap parameter where it
finds the memory and labels it "oops". The "oops" in the ramoops option
is used to search for it.

This allows for arbitrary RAM to be used for ramoops if it is known that
the memory is not cleared on kernel crashes or soft reboots.

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Kees Cook <kees@kernel.org>
---
Changes since v2: https://lore.kernel.org/linux-trace-kernel/20240606150316.916395285@goodmis.org

- Removed "built-in" from module description that was changed from v1.

 fs/pstore/ram.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index b1a455f42e93..0653b76c70fe 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -50,6 +50,10 @@ module_param_hw(mem_address, ullong, other, 0400);
 MODULE_PARM_DESC(mem_address,
 		"start of reserved RAM used to store oops/panic logs");
 
+static char *mem_name;
+module_param_named(mem_name, mem_name, charp, 0400);
+MODULE_PARM_DESC(mem_name, "name of kernel param that holds addr");
+
 static ulong mem_size;
 module_param(mem_size, ulong, 0400);
 MODULE_PARM_DESC(mem_size,
@@ -914,6 +918,16 @@ static void __init ramoops_register_dummy(void)
 {
 	struct ramoops_platform_data pdata;
 
+	if (mem_name) {
+		unsigned long start;
+		unsigned long size;
+
+		if (reserve_mem_find_by_name(mem_name, &start, &size)) {
+			mem_address = start;
+			mem_size = size;
+		}
+	}
+
 	/*
 	 * Prepare a dummy platform data structure to carry the module
 	 * parameters. If mem_size isn't set, then there are no module