From patchwork Thu Jun 13 08:21:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 13696299 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D99B8C27C4F for ; Thu, 13 Jun 2024 08:21:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 773B86B0099; Thu, 13 Jun 2024 04:21:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7241F6B009A; Thu, 13 Jun 2024 04:21:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EC846B009B; Thu, 13 Jun 2024 04:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3F9706B0099 for ; Thu, 13 Jun 2024 04:21:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D601780648 for ; Thu, 13 Jun 2024 08:21:32 +0000 (UTC) X-FDA: 82225171224.14.B89C37A Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf18.hostedemail.com (Postfix) with ESMTP id C30C71C0014 for ; Thu, 13 Jun 2024 08:21:30 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=d0ILD08A; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718266890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=0QrNpcoNy4k31Qxi3z0ZW2oJXA9rvfY0thkoxU4Y00M=; b=1QJbdVwB1N/jIJd99gNKSwY1w4T2vQ2l2obM9qRqqxU13lJfhg8PNVSuIXA3IanB4jU/FS BiOlUqcTOK0HU1HF9XVpYLDLa+7wrC1TQG/62VXMZD1fEK7vf3p/cQ9q6jqcX+33MsXGPv 5eS+5FOqmGQCV0oW9sWsWVduox0PKKo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718266890; a=rsa-sha256; cv=none; b=SZB9trGI/brXbUuziWio7+mf5L8GSTaiEhFuvQzSaaU3Ybltx/ArnskRVcA0rRxgp1WQpP WeN4soxagEpnvHOpoVY4R0feIfHHGjDnltcfyIg5yeH0LP2ePeTBslCfmWl7+AO5kcy8H2 Vk6vX2Pbrt4cbywqQSpgu9SEVFKAOIc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=d0ILD08A; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.133 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718266888; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=0QrNpcoNy4k31Qxi3z0ZW2oJXA9rvfY0thkoxU4Y00M=; b=d0ILD08AUHSpKiJfHP0R7ocCt6vbOW6k1nQwg0tENhU0/L0b4Kjt51hu7N0CvOFeFnk2sSWPb+jPZU0i73YuUro+yu33lnH5z99F0oy0nAGG63lRHvHaEFoJuUwT4SqIh4vx3TYFzB32BHCScxd04x5cgS9nAFuyLKC3kf5oV3s= X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R711e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067110;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0W8NU4tU_1718266886; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8NU4tU_1718266886) by smtp.aliyun-inc.com; Thu, 13 Jun 2024 16:21:27 +0800 From: Baolin Wang To: akpm@linux-foundation.org, hughd@google.com Cc: hannes@cmpxchg.org, nphamcs@gmail.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: shmem: fix getting incorrect lruvec when replacing a shmem folio Date: Thu, 13 Jun 2024 16:21:19 +0800 Message-Id: <3c11000dd6c1df83015a8321a859e9775ebbc23e.1718266112.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C30C71C0014 X-Stat-Signature: y9473iqb9why6shpzdt8rzwpzmus9omg X-Rspam-User: X-HE-Tag: 1718266890-185428 X-HE-Meta: U2FsdGVkX19s6jXI48Kg7DL5F8uFjE2TN97WcIIdHtvwGgIsq+vZsLM7zXOD3ePkuVhMBG212zaiKKrOQN10PT8mZiAgzCI8QutLCkziOkNHcpIyr9MiCZm0F4tmh57cP8tzwpd+hYH9BWYgoyIJfq5B8hZxmLcXjavaDEZHUpMXlWk7Gv0Wl+ao2Ow55fCA+RmRv+biSS2r/9qjuRRuFaZaU2Hj0ihJt+A6KzR08YjaIQebEMbr8w8sTjnpPOtLHFPpCU2kqBIz+PsXpDK0/VVlRzo+yqsHpHFCFm9q5oe+D2HRo8pHHmulaqT/DXrIskeHIdLJSgZXveB1KmKjBL9XjFLBxxpnS8+OqTmyrZD1wFNAHoSHC/BrdBhP3UEVk7fSCPpLsdcE8+7wpNxycDFs8bQT6i0meefoDAjmB1XfUpYy5al9qBHvQu/QAA5i5v4mLHfU2roIsviYi9KT6hJUPZmJkPbqfXzNZ4Os+nIJzadhtPPrqoLDQB6lECAu+KKSB2gZXJ+pURfMb/NWp6f4w6vMG3EgDQEy4iO5y8gSsIONmYH4CZaP3RAuMR4rU013WSu6KZ6JVbxP8Xo3beXYT1dNh30gSaOs7p3Ml26s45fLjZDucOzq37lCtZ3YZ517earQaqJcLcokfzyMcY48HaMO0wu49UEDTIz3a6gdXA7Vho0TH+czs3HG5yRUFy8+9b1JBLQNPrBheCdqqUmxyq2UnqDNK6xXMYQg+5kc3Gd053CRwn9LqAJpbPUKLZckGE+m6HoaREWIOLA96PoVaywiDbeobr+o/ZQRWHEteFM8PS7Vc3ETKjXT8ZTi6d6fv5vWatYmo7dSQ9sLI+ex0PEeGAyw4AxmHMDDMS+41k6pXWHqh12I6srPalpjP66jkilfDxFaFcAry2sNIGf/YiFFnjMQREKEpTwE0206DYdMH/OfctlfDUMVZy4Qo8h+uVFSzEcb5q8h6fI U0s2Cbev gu+ZxSb0ZXH/cld2cwtlnihW3QbxUoLsQmLn3M/cWnc6A+6Tbrr5V34mUlbLwtiwMwwLtcPMMM/+MtbdUrp5+X8ZAGSRemQono+3lvC0xTdUSvxDe+coUZODRj5/pBskdjYRE0hcbvWcbs2FO2wrf4T28KPPlXx6lsckKCXfOqLQv/Gm5h8WdnZbAzfuv/M90KQz5Q5LU8VPUIn1zWIWCVOTNDv2ZHfkV26SE2OGyl/hNS84= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When testing shmem swapin, I encountered the warning below on my machine. The reason is that replacing an old shmem folio with a new one causes mem_cgroup_migrate() to clear the old folio's memcg data. As a result, the old folio cannot get the correct memcg's lruvec needed to remove itself from the LRU list when it is being freed. This could lead to possible serious problems, such as LRU list crashes due to holding the wrong LRU lock, and incorrect LRU statistics. To fix this issue, we can fallback to use the mem_cgroup_replace_folio() to replace the old shmem folio. [ 5241.100311] page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x5d9960 [ 5241.100317] head: order:4 mapcount:0 entire_mapcount:0 nr_pages_mapped:0 pincount:0 [ 5241.100319] flags: 0x17fffe0000040068(uptodate|lru|head|swapbacked|node=0|zone=2|lastcpupid=0x3ffff) [ 5241.100323] raw: 17fffe0000040068 fffffdffd6687948 fffffdffd69ae008 0000000000000000 [ 5241.100325] raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 [ 5241.100326] head: 17fffe0000040068 fffffdffd6687948 fffffdffd69ae008 0000000000000000 [ 5241.100327] head: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 [ 5241.100328] head: 17fffe0000000204 fffffdffd6665801 ffffffffffffffff 0000000000000000 [ 5241.100329] head: 0000000a00000010 0000000000000000 00000000ffffffff 0000000000000000 [ 5241.100330] page dumped because: VM_WARN_ON_ONCE_FOLIO(!memcg && !mem_cgroup_disabled()) [ 5241.100338] ------------[ cut here ]------------ [ 5241.100339] WARNING: CPU: 19 PID: 78402 at include/linux/memcontrol.h:775 folio_lruvec_lock_irqsave+0x140/0x150 [...] [ 5241.100374] pc : folio_lruvec_lock_irqsave+0x140/0x150 [ 5241.100375] lr : folio_lruvec_lock_irqsave+0x138/0x150 [ 5241.100376] sp : ffff80008b38b930 [...] [ 5241.100398] Call trace: [ 5241.100399] folio_lruvec_lock_irqsave+0x140/0x150 [ 5241.100401] __page_cache_release+0x90/0x300 [ 5241.100404] __folio_put+0x50/0x108 [ 5241.100406] shmem_replace_folio+0x1b4/0x240 [ 5241.100409] shmem_swapin_folio+0x314/0x528 [ 5241.100411] shmem_get_folio_gfp+0x3b4/0x930 [ 5241.100412] shmem_fault+0x74/0x160 [ 5241.100414] __do_fault+0x40/0x218 [ 5241.100417] do_shared_fault+0x34/0x1b0 [ 5241.100419] do_fault+0x40/0x168 [ 5241.100420] handle_pte_fault+0x80/0x228 [ 5241.100422] __handle_mm_fault+0x1c4/0x440 [ 5241.100424] handle_mm_fault+0x60/0x1f0 [ 5241.100426] do_page_fault+0x120/0x488 [ 5241.100429] do_translation_fault+0x4c/0x68 [ 5241.100431] do_mem_abort+0x48/0xa0 [ 5241.100434] el0_da+0x38/0xc0 [ 5241.100436] el0t_64_sync_handler+0x68/0xc0 [ 5241.100437] el0t_64_sync+0x14c/0x150 [ 5241.100439] ---[ end trace 0000000000000000 ]--- Fixes: 85ce2c517ade ("memcontrol: only transfer the memcg data for migration") Signed-off-by: Baolin Wang Reviewed-by: Shakeel Butt --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index 99bd3c34f0fb..4acaf02bfe44 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1908,7 +1908,7 @@ static int shmem_replace_folio(struct folio **foliop, gfp_t gfp, xa_lock_irq(&swap_mapping->i_pages); error = shmem_replace_entry(swap_mapping, swap_index, old, new); if (!error) { - mem_cgroup_migrate(old, new); + mem_cgroup_replace_folio(old, new); __lruvec_stat_mod_folio(new, NR_FILE_PAGES, 1); __lruvec_stat_mod_folio(new, NR_SHMEM, 1); __lruvec_stat_mod_folio(old, NR_FILE_PAGES, -1);