From patchwork Thu Jun 13 21:09:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697475 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 883DF146A8A for ; Thu, 13 Jun 2024 21:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313596; cv=none; b=Ce5L0efiWRm5ejGru/2fEfPIMiF5L79/P5xEJcj8G8cU3e8f1vtlFCZg5yrVikoxWmtjdhcdvsnM3XgxUsQHb3TiuHK+IrXtM8JOerE08Q8+DOCM57nWoCJpOMhnjTduz6LPoT6eJ84Ef/SizjthUMaxNscHgoD3/ToU3tjsErw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313596; c=relaxed/simple; bh=bOUOYj1yJWVfslyu9pCNZsN+CqdeAchG298E4ENLkPY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E1b9Wtya6g5CVtOMb70AOA6dLRzXHkxlzCdox9J5eqX8fZrrEAlD9wwHZ1LCkX3+fghoAl5JYItJNtJk8JX5fJJkvWAk+QrdqEJwXc4eHqNOMBlFZWHWlC1jNpFCZdaHuhtouC6eFNDtQxb4jL+/oBbdQXRibyuBhiyQFJBG0TM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bh9ooRJ8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bh9ooRJ8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718313592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jk9BFaIBdnRuur/DRp9Mi6o2SQFE0p2XyV62LiyPpE4=; b=Bh9ooRJ8z54MwqM2kwkm7Axbp091ptcC8wdrP08V+uNekhY4+1jQ2VnDaBuMdwXQ5DFovY rOLRJjSBML/RLHwrO7rY8t3JG1NoDgeSA8UGRXTXYQ+cKi2yUA3+tI5293HqE4MAET++Ph SPxvS3ULixQo2iT7++ymms9ghPz5T/c= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-FeVufd7dM16eScmIATa7wQ-1; Thu, 13 Jun 2024 17:19:50 -0400 X-MC-Unique: FeVufd7dM16eScmIATa7wQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 729C51956088 for ; Thu, 13 Jun 2024 21:19:49 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 752D71956056; Thu, 13 Jun 2024 21:19:48 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH v2 1/4] mkfs.xfs: avoid potential overflowing expression in xfs_mkfs.c Date: Thu, 13 Jun 2024 16:09:15 -0500 Message-ID: <20240613211933.1169581-2-bodonnel@redhat.com> In-Reply-To: <20240613211933.1169581-1-bodonnel@redhat.com> References: <20240613211933.1169581-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Cast max_tx_bytes to uint64_t to avoid overflowing expression in calc_concurrency_logblocks(). Coverity-id: 1596603 Signed-off-by: Bill O'Donnell Reviewed-by: Darrick J. Wong --- mkfs/xfs_mkfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index f4a9bf20..2f801dd4 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -3678,7 +3678,7 @@ calc_concurrency_logblocks( * without blocking for space. Increase the figure by 50% so that * background threads can also run. */ - log_bytes = max_tx_bytes * 3 * cli->log_concurrency / 2; + log_bytes = (uint64_t)max_tx_bytes * 3 * cli->log_concurrency / 2; new_logblocks = min(XFS_MAX_LOG_BYTES >> cfg->blocklog, log_bytes >> cfg->blocklog); From patchwork Thu Jun 13 21:09:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697473 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CD2146A8B for ; Thu, 13 Jun 2024 21:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313595; cv=none; b=PhEWHwLfEpWVXVXpeyZD/nRmTgKTJibsUoflsgGwa9M1HOeWQ/UdqYM2aqNlUmhFNXCNsqZH1f3owYyptveWQfaVQfGEWOKPyeqrEEy/A1rx1nPht8JiIdag/5PJlXPnrA+psqSinsCIrgbsIGeOuDhw+Y/L+w1Q8iXJjQ7Zzxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313595; c=relaxed/simple; bh=MsUb0lGC++++dHyYNwhtYinCgn/ezm/B8qvnNlS0ibQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QcjA1lROz6NW4dJ1LWb8CbitpHIq4z/N359n/m+LqoyFZbgp8K8YysqzVcOdYKVic5sFiNaruyQ+HoExbBCVqvePlQ49vz+/vgprwKeK+/QqM1QRfD8E0PD8VPdSzswyn5KxDE8m6/WZ095v+qjaTwkIPbspKo9AafvQLYmigfk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=huxy9CN1; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="huxy9CN1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718313592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BluPTFhbGG4VfN2SKggYKjir+O59yxRUyVs90UZ89JA=; b=huxy9CN1Jio0E/t+UgshJSvG9hXGttL6kwZr68zWMJrEU+1+vMT88w5VtonqTLl4PMB3KN uZCjxojXRcFz2DdbpbC3O6fGoRm/15rx4HeSyn8CrrS/nByObM/CeSLzgDpCzEfSkrEjp+ jS9qtPBPdbttLwg5sibrj+h+3Vvtb20= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-LBHA4VstNjGs-YeWx2QUgQ-1; Thu, 13 Jun 2024 17:19:51 -0400 X-MC-Unique: LBHA4VstNjGs-YeWx2QUgQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 45CEB19560AA for ; Thu, 13 Jun 2024 21:19:50 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 77E431956050; Thu, 13 Jun 2024 21:19:49 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH v2 2/4] xfs_db: fix unitialized automatic struct ifake to 0. Date: Thu, 13 Jun 2024 16:09:16 -0500 Message-ID: <20240613211933.1169581-3-bodonnel@redhat.com> In-Reply-To: <20240613211933.1169581-1-bodonnel@redhat.com> References: <20240613211933.1169581-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Ensure automatic struct ifake is properly initialized. Coverity-id: 1596600, 1596597 Signed-off-by: Bill O'Donnell Reviewed-by: Darrick J. Wong --- db/bmap_inflate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/db/bmap_inflate.c b/db/bmap_inflate.c index 33b0c954..219f9bbf 100644 --- a/db/bmap_inflate.c +++ b/db/bmap_inflate.c @@ -340,7 +340,7 @@ build_new_datafork( const struct xfs_bmbt_irec *irec, xfs_extnum_t nextents) { - struct xbtree_ifakeroot ifake; + struct xbtree_ifakeroot ifake = {}; struct xfs_btree_cur *bmap_cur; int error; @@ -394,7 +394,7 @@ estimate_size( .leaf_slack = 1, .node_slack = 1, }; - struct xbtree_ifakeroot ifake; + struct xbtree_ifakeroot ifake = {}; struct xfs_btree_cur *bmap_cur; int error; From patchwork Thu Jun 13 21:09:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697474 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A74B0149DF7 for ; Thu, 13 Jun 2024 21:19:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313596; cv=none; b=AX6sRJFRRaM6B7AXuxk4pzLw4fv3v8xyL8mRFKoRTimu67kMovl4EqAL/xx6e5O+jPbZ7lglF0yBueB1cW2MTX4EwzrFtl4AshKaeClNnA7kyLlT+nYHynT5Al4jxfIp42vYzdAXuTSrWlyIR5Z25jz3Emvk6d45ozUyeCtjenM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313596; c=relaxed/simple; bh=Psgl4jWfxo5CxhvH5p9i+VXNoKSO6EurRUXoquwBArM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qrPhSbLVZr7mpUBhVMNx05U03BPuvffmhCRle+7u5mReJkhlmD3sGa+UBw8Tg/75U3vZtWgNVKNccCvFfbtJSczV7zwiWO8gyCr4sGhoP34dVw62wSKzvm5wnW0QOVBN+Brljj/ZESUuSvdVnRNlFhPEZrApaf8PPtQpaOEtttE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AU7QZHw9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AU7QZHw9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718313593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZIlJphp8G8/h6O5w/8tP06TqZ6erkdAGwexKEZ/9fI=; b=AU7QZHw9Xv36yFh728ry1CwtRQl8pdHcLioD5DYfS3Yx/+EEDPXCvPrZmwRW8XhynE92p6 cV5r3136OjOXFffxUwiPhl6qzIEIZeZxZKAFmdnu424l3qKNoTVbE5NPWF8W9kTfbJvc2x KrUaSKx8hmmmbr6yMHlDpwNfUPaq0WA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-A_mjydQVNR-dVFnvcmBeFQ-1; Thu, 13 Jun 2024 17:19:52 -0400 X-MC-Unique: A_mjydQVNR-dVFnvcmBeFQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6034C19560B2 for ; Thu, 13 Jun 2024 21:19:51 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 79C131956056; Thu, 13 Jun 2024 21:19:50 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH v2 3/4] xfs_fsr: correct type in fsrprintf() call Date: Thu, 13 Jun 2024 16:09:17 -0500 Message-ID: <20240613211933.1169581-4-bodonnel@redhat.com> In-Reply-To: <20240613211933.1169581-1-bodonnel@redhat.com> References: <20240613211933.1169581-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Use %ld instead of %d for howlong variable. Coverity-id: 1596598 Signed-off-by: Bill O'Donnell --- fsr/xfs_fsr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c index fdd37756..d204e3a4 100644 --- a/fsr/xfs_fsr.c +++ b/fsr/xfs_fsr.c @@ -426,7 +426,7 @@ fsrallfs(char *mtab, time_t howlong, char *leftofffile) fsdesc_t *fsp; struct stat sb, sb2; - fsrprintf("xfs_fsr -m %s -t %d -f %s ...\n", mtab, howlong, leftofffile); + fsrprintf("xfs_fsr -m %s -t %ld -f %s ...\n", mtab, howlong, leftofffile); endtime = starttime + howlong; fs = fsbase; From patchwork Thu Jun 13 21:09:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13697476 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AABD13E03E for ; Thu, 13 Jun 2024 21:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313598; cv=none; b=X28pG36pVkBk03OP13Wfl3i2unqgdpkrTahGXdbbL/lUlcfshpl0TFMzMvcQugCz18Fn+SoPOWnlKtveubsmn/WLyaFUfBY0zSyW+AMJrmNCaJl8lDVzBw2Icx5yODd0B2Cih3pC/iwfgXghkTYmwVzMmKUutQElOR+UmJYswxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718313598; c=relaxed/simple; bh=hcgP6moRKDZpupzvJuP5HEtlh8u9Gky/DxONTuAjDWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I5d+tfRTk5ExCOo/irGbBf4ostx13vRzNGj1DIKTcy8q3RktGIbAOHcKj23i/gSGLc78GQJZhKRw1SA1njg7DHWPHj7CBbUXMozNOedca2gTrxylCf5/r+lCow8N+xjEBKyHmeNrem4l/kFuMsaYgzfR6f+7vrCQRBmf5Tebf30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jGyMTVIg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jGyMTVIg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718313596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=snThJpWDNgNHCNOl6uD91ooMEJ1Wr3g9bkc7QeOUZT8=; b=jGyMTVIgC/Pg4N6r3gMopj0ambFHmlNw+/529moDd0wUJmEHNowTTJx9PKLZIjtWj7C+E/ iCKxOgfadrOWw+IS9nIFV/TzX90M8JVJbHzYbSVNbgREZVHnbodoa/QocquYR7UuBMw8li Qr7Z63MVp55ILS5qmNCq0mr9zAINd3Y= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417--LXLnofsPHKUzydXYUukBg-1; Thu, 13 Jun 2024 17:19:53 -0400 X-MC-Unique: -LXLnofsPHKUzydXYUukBg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C4EA19560A0 for ; Thu, 13 Jun 2024 21:19:52 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7D868195605B; Thu, 13 Jun 2024 21:19:51 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH v2 4/4] xfs_repair: correct type of variable global_msgs.interval to time_t Date: Thu, 13 Jun 2024 16:09:18 -0500 Message-ID: <20240613211933.1169581-5-bodonnel@redhat.com> In-Reply-To: <20240613211933.1169581-1-bodonnel@redhat.com> References: <20240613211933.1169581-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Use time_t instead of int for interval field. Coverity-id: 1596599 Signed-off-by: Bill O'Donnell Reviewed-by: Darrick J. Wong --- repair/progress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repair/progress.c b/repair/progress.c index 2ce36cef..15455a99 100644 --- a/repair/progress.c +++ b/repair/progress.c @@ -91,7 +91,7 @@ typedef struct msg_block_s { uint64_t *done; uint64_t *total; int count; - int interval; + time_t interval; } msg_block_t; static msg_block_t global_msgs;