From patchwork Fri Jun 14 01:49:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Hoang X-Patchwork-Id: 13697705 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C58F0183071 for ; Fri, 14 Jun 2024 01:49:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329799; cv=fail; b=p9jB31cxcsM++OweUilf/zrEVIXN1LdhkXa0FgnUiIHzANZrYjf00iwQ2QvfwT0eWoKu6DY6kDxn12g3nYPQCXlR7xV1P9BIpjMWskkVpqsNFleFmex9e7jscmpW0rPSOSYY4DV45skl93ci/4uwsUFBp+TyLSD44teY2ge8syE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329799; c=relaxed/simple; bh=wzbFtF929EmOpL3R7A4y94DuxhaM70xBH1qOc1UHGuU=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=PKQg0+ZMR8vdNzRKZgCqmLF/MGxGmf3XnlwsE9HI++uyI3frZsxsq/vvharbPQo6dfrv7uHKMWo2cUW4sH2rJ6JcxGET8VFWfWDfHmq2mTdnlEFt8tJzc76R193oF5+RW7Rn27rAT/xQxyuOMFtwOv2TV7+72Ep8tUwGR4ZGPrY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=QyoLJj6q; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=GXpbfVg4; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="QyoLJj6q"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="GXpbfVg4" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1gB54010532 for ; Fri, 14 Jun 2024 01:49:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=vB2FtZhWSXYF6eXYBwhRuPML8GvZWdeFCFMjHI24LB0=; b= QyoLJj6q3AKgw3MKQ6L9+idRA+1eHJZOKmbs4sRo8bd2B7OAP9msBH9yz17ArnxN D6l3YSGSqWbS+JTMlij5ZoCr5xHFVDqE/WVYxixrDZexA+oIYmqwkqOoG3Im8fEb sQwK0kz08JgvrSvjNEBLr/DfqbQfFGPiwOdIVmTHGue9l405N4ZFkDajXV8AX8PT Cew4KdhHaH09C0pTya2zmwVupPoX0h9hla+E1Jo8vkRFTSYFWBsI4g/vzzxMgdKi EY99uMcW6OrFrd+UC2wddWt3T7ptiRy6A3+NtyMRswXs1zkGbMtD2gKB/XR9yayt RuDds5EOENncJnxGbBBhgA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymh19aq6t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:49:56 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45E00CkM020262 for ; Fri, 14 Jun 2024 01:49:55 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2170.outbound.protection.outlook.com [104.47.58.170]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ync91ytw7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:49:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISqm31l2Mns3ANbZTuGqnTS572AugsB+oFLzzcFtC1A5liGNJUZG9BEFGVYr+rFA7oKN40yS2YmlIkgV+SbahEdDemAoY1fDkbsCmCLrnDAh1HeuBKai6nT8vPP/uWKU44mRKA4hkQhVQg6qcuOfgfO0ivbZ5oFucI253YKVI3+v5zaOikSaSeQJdLiAAuPYRp/FeQlYbF8y0WCVvKdsFvUHBLVvXRydNJGRVQnCr2upgPdkBFof1Ozua3f6ZzaaLRJaC1c87Ov4/C0v7g5CDgBJVZbIzU0KuBbNBc/6Jttr+GTP7QS6XzrOqZRPPB3HBMXUQ5b8qbs4uuR7pfVY8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vB2FtZhWSXYF6eXYBwhRuPML8GvZWdeFCFMjHI24LB0=; b=QAJXFPHmisbODjos5xEaYy+Lc4T9cANv8VAX4oc2p1eorN9jb48fYXP+7icSBNNuYF7UpSp/CMqollfMKfMUynYke7iEgdTvMAAc13a12wLagOpK3tu4xs7W0wHbT4Cp8tk/eeG+0dcIp4N/SOYrDDXmlVJDWQ9gLeOByu7nvQ1hsYpSCAMjj5RSdiKUUa6AJdUUhqwOYilVKayU0zYnb8n6vl/9w6WTswGE1NkaCs/+2Z99fDbE6D4fVer5CfPOXJXFpqBoOxtnVfoxEuy73bhXnSI3NeNYCBWBCX/phWqGizm3EKXvswNz5A47bv59VGMeypR+D0wIBbQ5ViFnIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vB2FtZhWSXYF6eXYBwhRuPML8GvZWdeFCFMjHI24LB0=; b=GXpbfVg4298W2XLN5WTlbfQKwY9OxOU+ASk5r+Wm/zIZEBo4S3gqHB+b5ps5di/JDTpnnP5fNik6nFvI2GqvefR5lJBl5X8NyssvgF61SwVymJ/EnekWD1QSPT6pUpqPJjX2dtipaeziYvCuy/Bg/LXNq3+C3nVyDwAaqmqjQJQ= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB7475.namprd10.prod.outlook.com (2603:10b6:8:187::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 01:49:53 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 01:49:53 +0000 From: Catherine Hoang To: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 CANDIDATE 1/8] xfs: fix imprecise logic in xchk_btree_check_block_owner Date: Thu, 13 Jun 2024 18:49:39 -0700 Message-Id: <20240614014946.43237-2-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20240614014946.43237-1-catherine.hoang@oracle.com> References: <20240614014946.43237-1-catherine.hoang@oracle.com> X-ClientProxiedBy: SJ0PR13CA0028.namprd13.prod.outlook.com (2603:10b6:a03:2c0::33) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: 90b2368d-58e2-4d64-2df4-08dc8c144912 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: 6OJLW3kVPWjo8/ksvkJF1vYfsFrkF3wFczD3qPUjZl8X0KPjdqBSI0NiBSUCOW+I4HO7xmfP3ldU5lLnQ+2Wj3PpVUMMrBNkrPn4gueNbe9LqtvmR59mFIpmvOrb+ZvlVgFxlqVw+frKbWE/reb+nXHo4ypMqFhbotes4icNGm7sxrgRDx28nXIQaXvPEYI/UqRAkCgQiH2//TqcHLGirv3kwBF0zoK4x07o7EZQM6QKf5r+SFlO9OivJvJaQ/qBorBhMhuL75WwXxWgtPfObruIxtJgUxyTgEuHeauz8Eqvqujmv0GZq4NLU+lySGymESbvDU0jsH+rHMu6XLWhMPDAupvqFBhodA9VFwipjhpwkTZtNPGn/Ajx9ChXWKJfGwSx8dsPImBzkZO9J4WtgrDpFZWgUmwoTnuVlWX4+l3AAt/cn8enDDy540iYp/LoLXTeEuBDt4vUX+lidofe4SNAUHt0DqRKP/80EByxUHSMIwkyzdv2lK4wSNU6ggtdoNQVI+QjkrdH0p8RLRcQe2a1PtglPFU/XCtJoK6RRbmzbyyHzfoXi0FlOkSRbHPrTK9LdMc8erIzulc5L6ngTGUcOY7cUq08Rf28hja8MMQjlNBvRCOw/cusUQWyzDjYb5kWFY7zHOa9UwI1u8hA3f6QSo9sQ5PwqL9oPTgOSg3xf3KxDHifV7MiLD5NbUWiObovqp3WQMPacyIgel3Uan0ZQjn5wllMj1zX4zFYiVFojuA3nGU636eMKdcGzVqcIR/GELpsoL9/HlqX3bP0JvEVdGH+5Zq8R4bl85fjwqJydVD0vbl23xssvZdvb/5Cgao/fLRNUsmcfIqUmKt5IHUbgt8/R/jpjTT0FMUYUZQtco59g1ZiWHXzhjiTIO+xjtC6GI391ctsj2BPXXE7IeBLu0B9mQeu2zzoXlx76Yq2yr5e1RWtUTigdXn/Omih1l/MMERibZU6ez1XQC4ZOT06wJt0K3UUbrvXtu3ehAmb+LGZyfdilvq6nrf0OHdQ1jmqDaCpqjuHZKKaghvBQsETZfaq5uReUA+OVReGLP4zI/hWRoJC2Ea2ZQUg+RS2PFKmTe+7PU2eb4Kj3yC7GlNt3LKyLSXiOKoRK4REDDIxWbVPmq7sb9duJfVTMTs2WBhbZ718Cf66I1lNGwHUvQJOxGygcsSc8bjTnrwYIKhlzwl4UfRwsWOdDdBKnt4ytaXxT1CxTVIUNFP5vGIsHVfE6TSHO45Xk/8gJ188kkEIBnimPut8jWrPVQVSEXrx7aLdo/Mqp5TfPWascL0RlHqhJ6x7FLxQ3Sh9nFTMhLmXdC9xDjojPTOXxDpz81Wd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4MLVrmH1QuDWesBGSNaMN+ifKu5BOg3drrHTvs6M/Tx6zCQpJStEL+X9VJlZuKeyTEh8sgEy1kw5WZ27VObjIUQZIxVOizY7YSxnMgEGyV7panMwWapEPIuImIE6ebrsaJgSMdIClPGOjo12hzy1EcGrkFr47dX1RWAwdqkAnoZeAjNK9/i6KYfuoL761kWTXM0KzCCVj4TBdWuhQltR35gGafV1EBhxDFRKQrUOfN4HNnXD0e+MzB3IN6YWFbhzAUrRzZ4ukijTPxSUrcH3fCsByAL6J2zGpOqkNHLPKXhoXL3MEks9E0D+jscdeXUqO3PaeKYXisH68438TcOhhhgZWk+7c1HpzTnson5IbsALu/xLevVRgJRWRHqwDYw5FOuENwWUg3NZmlKY8zzKBbSoxUWLvp+Jycb8040A/dRP+4BRqR9X80gB37ZuUqqJ/mrEylWv6C/JUXab6KOySzpdMgMwCi4I/Ggb7oY3UYcPXa1xAhFzJDdo5nnxAd4p190sKNCO/QmAgPBcpLtlKZ0NaTPb3uiwyUIqCWVNhOmb+LygfZJRiWOLNS/GALIx1pMBuqThATMTc9280PhoxFD0nb+VaQuEW4OQtfCQgP4eQLL0L2QKbkTIqZixwsBsBLpKZkZkKlj73vbOXxUsFDQRIC6k1Gdup7CChGy/lStEGPLJVDCT+D5Ziap7M93BalfRbk2uj8S2SBYlSoRirdznSWYJNgpNE5InkJK2Ox0BKpu4xH15y1Nd1Nwjd9zY0IuuYK/RPPVo2F7DU4unM2E4Z4uaJ8KSGL6BiJJ90h2152YG1mEJdpGj78kdlvSN3ktOH9AB511XYkDYm2032SUfyTT5U0dmHjFNCqFBsqK7M1tp8/zfM6k0DGLMoYPb2JQvSN00DcV9/buoR7qXJc9+qes7e43p5uqAgaDg+/Dm3fZFmBVcqZmMOILF3WpS1X+3TN9Xj6+S9WuiYd86N0cApxdRJEDO2AR2S4ZDLlDAAR1xJo4af3ce4UabhmKDCEmuO+s1Uy0ClSmJxUEfEVrqvCCYJfCuqeOK6uBIEVA6eBvTYOaLHHa/B9PGjqJ3I7ZLnbI7YR33OojsxxoPstlZe3NqfMJ4l/BFnRM5ivDq1aifNCe+BrDvskAZwgipGgxOELCSeBGW81+wYPPBPdtiJ8dORwXwNZXOir1mS8xrBgCmz/QBUZT25V9aeAhciPulCfKGvHeHeifdrNUGHjBdYYf8NKEz4uncKl1MtA21UZhZsTuTvntnU6hiwSwmRX/yh4BfDWeOUQiOU4038eYpafn7cdfO0iMiSlJeDGA35V5ts1lgVACHcXH7tfKfrltmZzgs+2K9co4RTTCyA44LHVPKJ6CczKCC1RL81Jkdcg1UBOzdE9lIUgWA7jZ0yxeSKqh/qHGKhcGgqN5L1YC9MrrHXVZDnVSIO9FU80ClXycsW5vQfB3gTpB1JehrTr8hQLGEiNdtJnc1hWb06g9eTpjen+SlF2lJb9ELFL1R25wvERpK7MnwsfCE6vNlWVrWeAVKQw/LBva9mR4a+XdfRu6PDIEP0G1tTJi0V1StYsuJZmtLc2aUaoKHYDti0QR0NtXyJCpDAbYxyNAy2bMLsVYog2ai8h61JFhnRDpQJwkFdLxbR1WqMg3zoLn2G0OtzQlIMk77m19PusgVRw== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 8NwtfhB+Xc5NrEnZYCHo3xp1eK6uM63IktnBGZhXmE0a5DYkSyxxPzCZ3cOArW9CxkWptwJEoR79tVqfbrPUsl2q6DheSIeorTbEkl+1h1flBVTrnH+tMu1yMl6XLyfCfZx2Fw22di081XZfjhLTqQWIo5r0xkSVeLsc4U4QSkYA/UZUZ3LlLC+L9gsMTZcCu7utjCj2yv4QT9jalkJXN4avNaNgH2lg4CMYxRTcd1iLY8aUByh05p4nK2aJTziwpZebK7XtcI41XrtE7pPRTy7Zk6pePdWZyjTNMvm2ycnX1Q4O4fjwp5aNfnLy7UlLyjPGFvVDBLQXuA2PwbpuhbURAnGsXSPYLAFK8hRKSBRkVvAs32vAg/8SjWlf/stAludgvZUn0jtsltqxUiyASbG3gkAdzIzi1cCFvQu+AkxIhNH9oujC8dI89o512/axtHfTRdySxxjgxeEGd5umJ3VZx72E4sJRuckfQVAeMcs7jZu1AzKvqvtKXu6boXecZII9oHI3dZoZLR1v0Az8B10zTXl2ddk489ZEUF9urHPBpPt8sr8xlcpa95yoEPr59iNdQBIcVWasQr1C0YdD6dmCKaMAqcczh2FF+Mpct+Y= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90b2368d-58e2-4d64-2df4-08dc8c144912 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:49:53.4382 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2Vq+m7FEImjh4mSOOhF5HA0il7vwgf03ZTU0flSfOBoTDfbo1guE4WYJBjXRW+bvxKEXTOe2DJsviDNhiufHUI3bLQaBycxsmhIK2sBjRN4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140009 X-Proofpoint-GUID: qjO8BYw5raWsYzWtKPD20sFHkyF8lQTx X-Proofpoint-ORIG-GUID: qjO8BYw5raWsYzWtKPD20sFHkyF8lQTx From: "Darrick J. Wong" commit c0afba9a8363f17d4efed22a8764df33389aebe8 upstream. A reviewer was confused by the init_sa logic in this function. Upon checking the logic, I discovered that the code is imprecise. What we want to do here is check that there is an ownership record in the rmap btree for the AG that contains a btree block. For an inode-rooted btree (e.g. the bmbt) the per-AG btree cursors have not been initialized because inode btrees can span multiple AGs. Therefore, we must initialize the per-AG btree cursors in sc->sa before proceeding. That is what init_sa controls, and hence the logic should be gated on XFS_BTREE_ROOT_IN_INODE, not XFS_BTREE_LONG_PTRS. In practice, ROOT_IN_INODE and LONG_PTRS are coincident so this hasn't mattered. However, we're about to refactor both of those flags into separate btree_ops fields so we want this the logic to make sense afterwards. Fixes: 858333dcf021a ("xfs: check btree block ownership with bnobt/rmapbt when scrubbing btree") Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Catherine Hoang --- fs/xfs/scrub/btree.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/xfs/scrub/btree.c b/fs/xfs/scrub/btree.c index 1935b9ce1885..c3a9f33e5a8d 100644 --- a/fs/xfs/scrub/btree.c +++ b/fs/xfs/scrub/btree.c @@ -385,7 +385,12 @@ xchk_btree_check_block_owner( agno = xfs_daddr_to_agno(bs->cur->bc_mp, daddr); agbno = xfs_daddr_to_agbno(bs->cur->bc_mp, daddr); - init_sa = bs->cur->bc_flags & XFS_BTREE_LONG_PTRS; + /* + * If the btree being examined is not itself a per-AG btree, initialize + * sc->sa so that we can check for the presence of an ownership record + * in the rmap btree for the AG containing the block. + */ + init_sa = bs->cur->bc_flags & XFS_BTREE_ROOT_IN_INODE; if (init_sa) { error = xchk_ag_init_existing(bs->sc, agno, &bs->sc->sa); if (!xchk_btree_xref_process_error(bs->sc, bs->cur, From patchwork Fri Jun 14 01:49:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Hoang X-Patchwork-Id: 13697706 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02295183071 for ; Fri, 14 Jun 2024 01:49:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329801; cv=fail; b=UfOVjfamPZNjajhlzCDLKspdf1ZBtohHyBX/bQHB49IzxkOfNaO1kGiAUGd/O/my5IJGRl1H+b/VCBfsie6053X+QIy1RUK/nZz9Tr0x9/LU2BZfJaBcEn6niOaHHNIsPZNDdtHw7cxNaixsjEMTYXSqMUlePOH8/AGlmdxZWPk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329801; c=relaxed/simple; bh=Vi6URTW+xE45X/TiFWIKAg34Bs197fIgD4ZXSbDmew8=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=rMWarCatSjAwmCxCFJ7jSTrgvV50eatFd22zSP7Wedg+88+daJcM9loJ5ZBTI1BFSCgPdINaotediEu6mK83me19X9TiFIavd0AbGOiyaEmKQ+A/JVKFrPwQ9g+GBwVlivRX5oT3ckWfyiNGzNDLgwixLY+7ALA8izsYH09cxNE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=K3cuY/4/; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=q5Kqc3wB; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="K3cuY/4/"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="q5Kqc3wB" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1fVXU029842 for ; Fri, 14 Jun 2024 01:49:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=6tI/eWEHU5k27jVKl4QE80YPRsxgzIgyX0BXs1AXpGA=; b= K3cuY/4/y0ryRCL7gxQEUD6SgIySl771JJ/YIUJ5uqkV2ps+WMPH9+VbNd02cnfg 9hMY1zHTdxAcOi7QCOFSUQ7E680nudgmkn9g5t194WrFP0HW3TSP2vymoYyGB7fI smwUqGELXaOMaihXhIox3KLbJix2OIgJo53EiXniqcU4kV3++d5r1/ZRKB8Uz+3y pYQZXxDCtCnWNjmQt+wD6Ij8Y0W97txfqAq6ETv53WOINET+v4IQMv7JrcM0g/YJ +LIP6ELuoldA4KRZjDy33a1RvFh3DS6lN3SpQliw2oWDubuPwd7lo4sv4Z26WYuS vq7uzOztjLgPQ8gKSzyM5Q== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymh3pangf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:49:58 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45DNkGX5013327 for ; Fri, 14 Jun 2024 01:49:57 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ynca1uvu2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:49:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LkT1Jkycl5/xNHofCifkKU/GakzpiMlCDJIUuR08viAUk4qkj1nb0zTY/50zccPAGjDrDn83qL5X1ExLxepdKz+1zHktWIFDY2shTVzXWDGU4mEwb2GRD3D4DhASA5JxgcQ8LDW34awCX4tajB8h//gjGoUNd7UKzns6LRcpEB7OEBgdUuuWS3wL7h/Rq4O/TNG4THw/i7sLRUxO1VfXqQZXbcNs74ExCEsNeHJEc8upbekIipEh6MVuUGsZZrcpcIOcsI/nOrSNYq11riBr1rpIMqpPTiNjQSccOLXdQjG8MAQgqlJJm3cKNAhHkrP/CrnsrG9gX6qD4EtE3sRIrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6tI/eWEHU5k27jVKl4QE80YPRsxgzIgyX0BXs1AXpGA=; b=b6ZB/qEhAGSuzRNd8ox14vWuDAjSX+RHGYrYNdg1EF0UrArGZ/Vj76r3rnWKU/+tNIfcAJcKco8tG6oKbFXo1pYcc1kpCNvCDfzIgo4MmwZN8WAwsNs1HtmKju8pRcdyu9m5yg9CnfgqNMU8spIkRjE7KLHGgdHb9wzHEGuIdCdx7aCXlBjmTv95iD9o/e4Uj+3q2an5XmxE2G6vz7I+cjSHYpY3bSa8rxjo1ISTllds35Ssle2Kbd7I3BAZZB7Oh4nJP3MgsNbJ5SmlRV6W0CH80mRY2gt5A51EUxeHtMA0rKD5SXszaeMOBRUtjfEWiLFpXkuV3Jji7PRKBECqhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6tI/eWEHU5k27jVKl4QE80YPRsxgzIgyX0BXs1AXpGA=; b=q5Kqc3wBRrELsbFNm2bR5YsAgs7eISfipr4zyUI1j6AcDdhZwur8paIls4je4OIGropkGyoJdqWtaedJE7ROiJm4s+/oqXFBMjFK/3mN2dj4m/DnzkoUY5eAw5E0nW/rNiFOmBiBTV5+veueuzimoGuaB09OAHw7jI/SDcKDWm4= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB7475.namprd10.prod.outlook.com (2603:10b6:8:187::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 01:49:55 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 01:49:55 +0000 From: Catherine Hoang To: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 CANDIDATE 2/8] xfs: fix scrub stats file permissions Date: Thu, 13 Jun 2024 18:49:40 -0700 Message-Id: <20240614014946.43237-3-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20240614014946.43237-1-catherine.hoang@oracle.com> References: <20240614014946.43237-1-catherine.hoang@oracle.com> X-ClientProxiedBy: SJ0PR13CA0020.namprd13.prod.outlook.com (2603:10b6:a03:2c0::25) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: 9716f524-6ad3-431b-aebe-08dc8c144a60 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: ZpLpk9+Z39dySoA6Wnewo/b/q976ZyVAGRcSDJSMBxg7ve5ChxgE2jfX2Y4GI2gNnFA8Y/A+vsCpK6l3gq3J0ca/vUUbgwrpB0c0m0qGngFt8VOlZ7zwK6lrUCg+q6bU5gfumjfp1YGc1t41rTwFrYdyefd8eqle0ani5TumWbznYEncov70Y8PfeBbgpde34Kyh35Fg9qXVauplWVxoW9ON36ezHuhAqX1bu+a5oS8LDJNUTfRtNx8w+4FGwmfu8l62ou5wEaU/V8Xun82iXpWqllNZw7eaXPTSZrt8oHOg6wGB8J2FOpVqdcJL9KGNBYIAluNSHZw7Bvhn9Oaivw/AahXwetnz/sb1pGkBuBGHm7W+62BHUnUJ7R5CzTT7lY/UIvmGWns4AQlpNOp3ep53UShVPOzBA3AqcN65zzLRvvDnUa8/gIG/r7hKdpfdzd+24BX2TwW6QfcDLSmFM3OO4U7osNEIo+CaR6w4oouqjsSPK0TbIH7ZPlH70UkoUlbBKjksb8Alx6d5kae0p66o51jiT/tgMrXlXBgqU/cRuNJZamu4HrZmmRR7eGSrlRXlQ3rkwxAqs2cHaK5X89CLoT1uWWkQYd3FhuJAR+L7bNSNR7w06fHIQllZA0y7c3wjkONMlMJnBgL3RHfeEUDPF51T+U7G0WRy1Y5LuGTWimAiagvXN8H4gD3IV7bdVtS8XaonDU4f0/75ZmlDPIQrRHx/Z/Bl34Mq1QAHQ22qZWvhNlTUdc2csr3vlNwnCd0Qrr39+JNcPsJTmGmAJqNToNjEZyDiYQLT29zg7w9LVDqddR+IzgBuqHcj4NtrLmthssLW7t4HzX8Lhg6owPuXj6kExYTcMWa8jrpbpif6NZaAevcs/NsaGnxCdfKDx0zT86qjvXqdFtFTpIBY4wppWvpaBNJa0+dRKjUdiWoOUWE/g2blAVqJhcUt6XcYJIJ48xHKzbz5ktYtAOOaG4xRHhuA+R8v4eZJdbwYO40MLjhELRSrh7qJPq1TvBkU3fzS3HjcWLKsmQk47y5jJKjPRqrgjoY5k//OmIE5b8j+VnHS97qjKVJsTzVUN6bgsBH7rpN+qb3MGytKSarZ17ago3ALqczhaJNRqP05KrvHkAdRXx8BjVtu+GBJhe686G+g8eOTpoeANhb+zCQEvd2Z5xr2sNfDoia79Z+z856YqUkVkji/KaydYF/G6HrHfOzXWTPxbT7+JLWSGTTr+njWK5Gl/m7upYABO55k4DSSQgyHiUSMtNuN1QBN3RdXcHJDQb7SNs2et0M1jpSY27r4w+AwR6L5dUIO8qkNjfSZMwUz0vsetpvlqPZQ5L9V X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DtElAl93NeefnX9uzihy+JYzK5CH4D2FFJE481+ffilUI0CPcfXun3My9usdIjB4y0foL0ZrciD2fICkbs0efg9vQDp6BocCrjwutYIOz6qOFpqu+V3xtocFyKQBJb2QCaYFanhAEhxAnCvSBZ++SWFgLoGcjAKQi7CCgGQOYW9Eix9sfHqojt7Rro7/GR9Nw/tmF/Mg4HhUSsu5GOc7hb4orHsYynunu1LkBZ6D0AryorkzwDtPrlcr2RXcKirYE1rAlEv9AQUokbUDhYqmSOfrZS88K6nEfZ+uwRjG+pHa3TTzaXGMX2gHIcml6uC/qn7ayLIAZgFNqyFrvNdjhotbT56AtPVBpqaGusQApiPuoY81PEstzzZZzBQ5QoVDvWhS0r+U72SORMREOu8/X6aXTG0/X5cb/aAlf3V5lttD7ekyL25N+BSmwGcBgQaVK7UKlh1imDtLK+qQx8NwvoVPrr3axMZKkG+VrEaIQYPuAavdC2lVRX2QaX1JTZoffznzYqzRlgvoSKoR1lX/pqFT+TjQOWeLIRRr9SbLudbaLAY36Coe75L7YizJclJBXUNN2dtY+DvwB3poZJTKQ5UpwkpD8uxuH0zZ28FgzPYmI2AXqQy6kH5nUiWUa+9UygVcqMfHtdpH60Dw9wtp+egi7pQnCkXN1eaWUFanyqkelKd24tVFYje/eQuSc1xvi/w/SuIcmCmiJkjqXMe4j690LaHwjKxnmKVUz1J3TrObc7JV+izKLcjMGmXToFUl40EhRWV1zAcxNg+WLg+6AsHaNjpUIPlShiEK7cAFoaTHEA+H1l3SfllbZgVfziWhV4w7weDh2dBZyrAYAd1TdKvvL03W6XJO/NmWDWiO+tfApXBGHBVT+MtoQAtHUIMTUpcu05RFwktPY9Ppr3APH8vz9swAHzKeObzMoAntU3jNHuj1RVZbH8sRuFH2q6yE95VfL8aiH8ddYPQPIMWbvnNSkoN0dGUr0/evSfMxm9ZX7fkZqGWjtT3j9+pLkat/juAgl9aD3xRv59UuehTwsDPmeBFPuWUqiqO+6I2x1NW33lPJNkX05R82M0lWgL9jeCLKP1REeNPNxMoZuub+Hk6W45hwPgVjS0mqTcD+G/czvHxhnY1+54GN5y+cYc0QB/zQOMArNXW5OYEQ4bQmLF4QLlv5Iz9FTJ0dwRady6IUdSjDFDktfHr/6r02XV8FC8sxLH/6l9cJazgu783+hRDYtgniSVaq4cEkj+M1kU7qgdzSWooYtxE35WFnUxnkZIqK+pBH/X60PnRoQXJ2Ya0eCzM/VS373SydTiOqhmF+v/D6DeS1XV7SiLFBYOQeXM68YVvZ31LN6+44LDFBlLoGxRW13PSUV8wNAYBltEZ6caZHH8aMMk4cVGLAHJJdoHbnq6K0T9YTW722JMk81cTFZVJjNhcfSDUcBij7U6C2vXA6h+fsp+FaCDZD1QNcnt/XIg8bsEp6eWd2cSTGwZ6wghqbSqFhVecwUrwjW05HckdxMiB/4DdbtJvb8MQUo0VhI/1RbIWWCwgYk4w1tPxyWAhu0lmxv+mjijTtx0z+oPLIC00W1zyJ6Enxa4iPmWjjE6bYfPbeg75A391mIDOHQlGtSXPcSrLrG1mdLImPfUnFuwBDGNuouOu6jgjjIOypvTVm35IX50zedRVrsw== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LELnkHVrZ79Gzf/4Y8MtHGBNIO/JtXgU4WB+PJzq0/KUDgF6lDzktxFkuImPXRYbxmnrIzBlFFPO7veR2W0h9kQTYXGOsVPU9I+4+dEzy1jmmi8GSwaYYuy+NRxrP0yHHHYiiQhR3Mc1Kiw5PD4ZwfFShm/C+/CcL51QsEE6Cb0EgKaZCMUNwERBToZI86tazBKK/diO6tj6ZuJ69Ab4S3Djtr+kjs3nJq3Iuez9Fh3nGJLjMwBxRQyjlRRiU4aUgWdMVPE7v8MYTHzZUO6++qcgfO8pjw6lovNY5BRrD4RxArmbo0nXwVYxclaFzcvdFF0ayNq91uerqzV5GB/Rb73PWeXSqnj4ckdL3CINn4iPpsx8Fs4fhYUCRkvR+2sDpp168vN4YPcytU9uAQ7N7HJc2NZjoyTTkPpMjOITHhIRKjvjLfAVm788j658R1HaoS7LaTQ5RZoledZpc8GwaOvZ9AJIPmYPlh6yEwVDScHkWSalldAFfEZEUWDh/wkFz8pSQSZdghDT0UqM/v+P1LnC00yFQr2IxfDS5d283IoT1xWx/8Agm15alET9zQMd3sDddQ1cz5Y/q90mSsov8cR6+2J8vloxnMlOJMa1LDM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9716f524-6ad3-431b-aebe-08dc8c144a60 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:49:55.6330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9s3VwHXYk7CAHPQ50l6gndYGaro3V0QCXcjtqYLvocrkjQKaW01x3G/AGp08fYZkpZZlOO+f+/dhRXD3oUFyq8v6kiU7YsdlKmyfOxOV53c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140009 X-Proofpoint-GUID: 7pgZQDOhkFAsawlO452G7aVWHz3_mIBL X-Proofpoint-ORIG-GUID: 7pgZQDOhkFAsawlO452G7aVWHz3_mIBL From: "Darrick J. Wong" commit e610e856b938a1fc86e7ee83ad2f39716082bca7 upstream. When the kernel is in lockdown mode, debugfs will only show files that are world-readable and cannot be written, mmaped, or used with ioctl. That more or less describes the scrub stats file, except that the permissions are wrong -- they should be 0444, not 0644. You can't write the stats file, so the 0200 makes no sense. Meanwhile, the clear_stats file is only writable, but it got mode 0400 instead of 0200, which would make more sense. Fix both files so that they make sense. Fixes: d7a74cad8f451 ("xfs: track usage statistics of online fsck") Signed-off-by: "Darrick J. Wong" Reviewed-by: Christoph Hellwig Signed-off-by: Chandan Babu R Signed-off-by: Catherine Hoang --- fs/xfs/scrub/stats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/xfs/scrub/stats.c b/fs/xfs/scrub/stats.c index cd91db4a5548..82499270e20b 100644 --- a/fs/xfs/scrub/stats.c +++ b/fs/xfs/scrub/stats.c @@ -329,9 +329,9 @@ xchk_stats_register( if (!cs->cs_debugfs) return; - debugfs_create_file("stats", 0644, cs->cs_debugfs, cs, + debugfs_create_file("stats", 0444, cs->cs_debugfs, cs, &scrub_stats_fops); - debugfs_create_file("clear_stats", 0400, cs->cs_debugfs, cs, + debugfs_create_file("clear_stats", 0200, cs->cs_debugfs, cs, &clear_scrub_stats_fops); } From patchwork Fri Jun 14 01:49:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Hoang X-Patchwork-Id: 13697707 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C80FD183085 for ; Fri, 14 Jun 2024 01:50:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329804; cv=fail; b=OL6UrqW7hyw6zRmyxfOxVHhQqWZivOig0+zxPg72ZmYflBULs+Cau4jc8DzDeWV4GNUMQV6u1ysTbM+00N+QDHv68PeACX4w3QmXVDPaPeiKwbzHu9bY4lPU0WhgY5jmLYe3QHESSc49MuGfwCO5VG+hLAx+0rmhxH5SuapYfVM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329804; c=relaxed/simple; bh=rR+1/6FyAKBJMmqVkASxyuW+Rr/Lp68hs5Cg39YVy5k=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Y87ojRoyFny3yFYafU/fHH6qm8enMb8bjUsWlhZOhS8PzIlivklcDyWAMYImSdlboVsOFWaHOignMoB0pFYnUtly/udIi2DiBl9f92V9ACoGr0NHvIKmju1QMnUkmi7PEhB2XG5AgCY3/im8IfrXJDi/KV5EohUPmRi9/7OdHhI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=ghtGficB; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=KNF+8LQ0; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ghtGficB"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="KNF+8LQ0" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1goZr023646 for ; Fri, 14 Jun 2024 01:50:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=EJtd8geM4PZXNGvBAuL6kI1RTJvHuk+clRI6j67iCPs=; b= ghtGficBJhBRhcWgdD7kWQC9l2oqytSkPETJK5bwBTY51DWxjDes1LBBWBC3ZLC4 Nve5Eg4NFHxCXVB/vQFxFQf7HEZFXulhInWYgWx4p3JvAwSUu1Ajz+ndZHemOlFP 4e9f1OamcCkDPk5YtV27l78j0ofAxP609BAFjRIQBg0V2JoMav8rOwA3g9RjVGH8 lGm1YzLw4PHnTyxUYOixWeJkiO5N9j9nHPstrW6Xewy92eY85WwTUJQe4D02acap I9jdxw9mXU8bDdMDWK6tNBqJ9ZrNwCmNpaNKNNtyZEFmNQF8pxbWygK+nRKHaPLw j3RqdunlIUbc/16hWR0eEA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymh7dtseg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:01 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45E1FJsq020228 for ; Fri, 14 Jun 2024 01:50:01 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ync91ytxe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OsGcv+Gt4IVNdU2SJBiZMx1XaGet19RSpuhEZaftojnscPxjwNwQfJdn9WyXtGpi/3pvU8L4qqKSpvI8CGWAceywP+j46nNivMf2kuGwH/hk0rJRfFGEY086iagYShrTP/s/N6+pLmaTDJi7XZa4WhSYHFT3hNrA98s9zg7LPYjSlKMFDV2sEPKjEdvl0I/iObsqK4Zp1aBGzr+AUfiHVU6IlJPo4UgLrCoO+vbjkMPo2kEWTULs3jg8zqCLguywb50yX107FD83W6H50ue0Ei0fm/Mj0+usn9vCDdjdWHeuGFjRAN4ZfwedY8G81n1hDAl/W7MeRPCd8hYiirvgwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EJtd8geM4PZXNGvBAuL6kI1RTJvHuk+clRI6j67iCPs=; b=LogyunMAG7MKEA7CUCBsY0bNsdei7+M/J8wahOb2mZd6pu4NjUA/eoBPIa6+ulyTzMFRpfgaOcMkcqkJxLg5a0JbUuIIDrP74okU9eWdQnxpJWtGxq2+zSWWR4a3VBtxBoA1UyvRsSIx+ppBfX4KP2FNstGmvWBSWNVrlogeXNFJm1maJVJU/ufnqeKthUUhK4b4MvzQ++YzCtNEFvwwi8wuBjluBEkcrfBarAR8LXqH50wxBWZhxonwhKANB/lZwMC7x9qjInaXdFzvnj2YVh4SrLT2xI9ZO0uAlEFAju5NENYLGJn3pXur9zn2x/vzUbaiB/IuY2VT0CRhbFsc3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EJtd8geM4PZXNGvBAuL6kI1RTJvHuk+clRI6j67iCPs=; b=KNF+8LQ01kL0CJkXI1Z3Ui/1Jm/vCsYyGXy/rSunS5PicutVZf3FUaYYCYhbfAr1csaVRxN1+aMu9NeO3pPrdt+ilJHDmt4tjhwPv7PqnTi6pSlWxZAFz+QURiHSMhw22ZQyrLID3BZsaJI+XRBJdRhwfK8fuNmGK7vLv6KljcE= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB7475.namprd10.prod.outlook.com (2603:10b6:8:187::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 01:49:57 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 01:49:57 +0000 From: Catherine Hoang To: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 CANDIDATE 3/8] xfs: fix SEEK_HOLE/DATA for regions with active COW extents Date: Thu, 13 Jun 2024 18:49:41 -0700 Message-Id: <20240614014946.43237-4-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20240614014946.43237-1-catherine.hoang@oracle.com> References: <20240614014946.43237-1-catherine.hoang@oracle.com> X-ClientProxiedBy: SJ0PR13CA0003.namprd13.prod.outlook.com (2603:10b6:a03:2c0::8) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e32c0ce-f453-4f9d-b7b0-08dc8c144b86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: SdbLrxR4X+Pp69X3gkD0fWDQEdSF8ioVCzNx40vUM6qsPfECYqeBnb4SVPKv91VbQ+UkiAEPbPpDVT5KI+HKpa/1w6aq/s3vOQEcP1KrUIX7YhNNp12RFCI+U6gvLmc4KYvcYvAPAIzzqMxAsyyQyZgvlAdpw3UAYJQjaV0QOBEVAEEzbN/s4nsZ8IE1ePZY9yBaCzdXPqRXCnUoHN3X1vcbLzd2G7S9d/Dd70w9avYDQB9awurUrFjgfs0YjKr+j554uMIdkzbyVJ2PBh5DGA6gg6gLTBiu/OhimU7EFADXr3LTA2ZBbt/Z13JmbEzSVjEZBRYid5JzWAKKzPaEak9r7TOei6WWOXERF1aoNRP8+w3sYqviBmJCIex5rI6PGdOKRGAT4vbHBnOvOBaRm24SSaEJ7KM3Cv71hXtUsvccUD7ABJulG7iXI7kA/b0IlLQxJPvmk53OINA+Gm1dJMv6KbbT3YPm4pn6QsRO9T29NTD4donMiAVPq2lPb3oEp5hPBtgQgx2aQlZnJHwUx4IdiWcixyd/oX3huylFvdneI3A08ucbYPU/u+O7KcvlwQsMQ2kF37oPsy0AGwvV0jXD7BUPrB7C/e7pkbxhkvZEhI0XOLvA5QqwUeE0nT4fb93TSAsY8+PKyeu7heeJJIC9MdzAQopOSjqV5Tstlyag66U1yzkNQPh3o+elY+3wugnIAU5595/VOlOLGUEQpbLDRT6ZHtb1Q7kWKw5VhrBIuU25bWebMgzpQKWnDIHJi/wyKEEBOCQtaFh37iCyb73GMVydy3HLOkVUwmwJQkNVwm0VsbpAOuIoYnswqxRPxcBV1Ph+S9cWnD+Yo3yqa+fGHPK4cuZeBiJYYV1/wPzo7co5sor21rKmON8mOBvJ2w7dpA38mOKy0z0AQjVIfi19aGkwzlK3kqLzKkFOBdVey8vimCYxC4iHdJvTeg7xTBXoS3GozwkrIXITGvd8DHXcupYhp4UrIYh/suQDFN4ngUWdOkwrLvniG0ALgf5D7HeP9TsZ2Ft2kq5FH2LDsKyGd3bI2MpYF5+VdzJGY4GnT8bZcjrvMoPpL9SP07/I2Cl6R6JgUpj1UDeMpe3enhqvkpL8cff+OJg0styjOdqtARTJD0b66o7MGmmJPpOlkFslx/mJA2Po6AJCQaFTOBjKwFIeR9/ua9mzKs+9ucy/9bhwFsULNIIGAf/pYJUoGwYZ+kWDlmLX4QVRMcXAdzwuWWpiUb5Qs/a9JZ2XLT5YYCAuWpN0ZmPv1yqhyUKr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oipoSEq5ZEin3UDBJk88e6KxirrFv3WxDVZb+4kUHjPLmSKLY9mNtpj0xx43xEG7Y+pxF5ndXzeLyhrsI7uWl1ARCKPNbtQO8b4r7rzT5+CM2oovgiq9DvM2q9OyCuUD3LWSu7vzz4m43J6uuQslPwsHxhIBBIyjjNBDOgxuTy2e7GvFRZJiRJNHifC9xzgAf9xTyXQHtN0qniz2zlfZ3lEaOqa/GhU6+hCEu6Bu9JM1cW1olDbqZrGbBGPzaMr72ZR4JhvDzKs7j3cV+qqkAa1jaLQpp1YK2tYsGAV+IUFsW8NHMVzcNYVGvsiJMeo+BzKr9TNrI1HPAID2IePKhfkTuJUWl+AM5n7rrcK8oXfodFirf8QXnkcdQYYscfrEqr1tZK1TTv4T0aKXrx9kex73wSqZxFdU8uD1bp3JAnrPe0knjwh0FbNxPZNpNxnf/O1qNp+TgLX7bciJcpZl0uetD9LizPYb5FVv86yPrFEvpkXXfgq4CXbFTGRS7fXtUhrbKIlWXF3Ky6W85/5ZcNBf1Zop95pCPs5Q5QbQbsxpOReJn6TC/BgazkxFN2AFYGoxSEhZsEpPmNopzaaxYzkNl/l3xiCIisVChKXVDF7GDuCt5WSwqndUNQeLjhXV0Ssd8r3N8sfXkXN0IRnZLnfAxvx6RUydjGZqeWIpP2SUEc44upB4m3ukPEEXmolCHnZLkI2ofzbtbwusidMPf/PrbIVwxunTP1E7D1gS0RYdc7qNWdNtrzN1Q5Fv/sFsvKhozY1aLnRQBkezbPpfKY9KHdgnAO/h+tbz3I928ehsO3/vCbsl3Z4BraJhZG36h/hQCpFyo4Jrh2UDc6959SPUdgKNP1bgT356JTk3ZjIX/awWqjLU57iqpHEVY2NjirxI1PePo3iGiP1LCfrAEgb+dCyKuSMXhv04vw2DOrs0RyTl+FZSss/1v7WLyeZ+arzVlvkd1uty+zZriHbIz97LfLNTzEncEr4RrISJHxL9WnrBkIyFHOpQ9wPKrwc4yi3P1IPXicLNJpNT6KaXHcL/9GSldD+VS3ED2B9hiS7P/UwYPTBtkC39NzYy9FyBDVeQvItr9/hvzTDurbU7xFBh9Eq7dXNvWQ2o2tcAj8mpTxHNcT3JvQSuI94GlXLWQlGrxN3x2aO/3h3Ww8u7kE0MYgSicYPboGFFWsnoI+qoO3vFj50c1dxu390S1fzmoFWLwUhGeEc7AX+beBRuYtGklil/4ph499lbKX22eISt0+wDge2KOqt4/a5ZypjDQjzsYZkh2Ra3E0nu7AkL1+RNtjsIjZnbeOkYnYgkThT7+f4Mj4eqrmDd0WOio819rpvGYVHUihp2tm2Dw3rG0VOcWkEaZ9tc7sh5BV/NmHrJlTs8w85Rqq9WiS/28jgtmpPsN+ldEL1WEv9ncNq3KIJXxWfNFd+UOdFK/l7uNptDe7eG8V3XGu9LgeN6afQw3vjR2E2etQ5JFgrOxvJNvHf/boChlkZAaI5ImX0zgCxo0D3wk6BNWRHCof9q36YMFLPJG6wtYvTBzHOj8DposbLTEoWrCWFK3Ud2PdP/SOX23vvDBYJOqPHphxGyZS4XCBmRovFotK8ILlcZbCNdiC1ZOP3o56RYEuhUDz8t64XlZI1JQS4Ewe6bCHZfbu/lyruzCxc9s4EdrTrKdNAb7A== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uLNGzGhtciTy9uQIik/hjeJHbOx7bfib3EUfgYmi7HtKjbjD7SNabEMd1/pIN6TetAFeEXWhx1UYem3/SFnthIzKkECchdhWZK+IiWO7+nc1OQlYjn4HpczOJKYnjxhHS1VHluZdEfFoE4NToXS0NeSDlJ4wzATO4PeKYmSavl0zWcTpW7eEbJtrMMGYWOvISjJj9OW7EuxbRnppWJGjVynVio+6deBkiNMb6JdEJpV3kgxPqMxooG09HDtHFxasEHtXPyrUa5x7ze3q+us3TnuWI+9ailsVFYILflXzOG0ONmlH7+0NMrr6dvNIwzJhfgjwlRf7JU1xNtEodAWcut9IZQ7UvGtcmB8ouci6OHk+zIjAzooMChx/sq6UDb06fudxPi0kTITmrXldItGiWmj1xyQBOO6yrbFEzvGZ2Kl4FGg/jFvWU5evqHBukSD6zv7fXNQLDHjlINgOdEWiQzDbbrYsVvX6coAGhRR6J4SKrIVsfqjDMbQaDtrOl6+8jTHNy0kn9oStf5JfUNnZnw1Qdz5poY5acTyZjFbjYH1CtZxTKQxpC+Qmr+LNCoSoP3Wj2DO+dRg6IlaPPhXeWiH77e95Xm64m19rlwJh+58= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e32c0ce-f453-4f9d-b7b0-08dc8c144b86 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:49:57.4957 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iwHHvcMYx1rZHL7KNdiW4/ejr/TrzBcRZwWz/KRs6o1G2Rx2p439Z1wKPIcUAhGq5KftlZBYwnlxqFyv7xs+z5t72fouWS5I/cDZGx7b0jU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140009 X-Proofpoint-GUID: Xdkp2qq2aYZyvqMMStlt6rzTPJIFp3RB X-Proofpoint-ORIG-GUID: Xdkp2qq2aYZyvqMMStlt6rzTPJIFp3RB From: Dave Chinner commit 4b2f459d86252619448455013f581836c8b1b7da upstream. A data corruption problem was reported by CoreOS image builders when using reflink based disk image copies and then converting them to qcow2 images. The converted images failed the conversion verification step, and it was isolated down to the fact that qemu-img uses SEEK_HOLE/SEEK_DATA to find the data it is supposed to copy. The reproducer allowed me to isolate the issue down to a region of the file that had overlapping data and COW fork extents, and the problem was that the COW fork extent was being reported in it's entirity by xfs_seek_iomap_begin() and so skipping over the real data fork extents in that range. This was somewhat hidden by the fact that 'xfs_bmap -vvp' reported all the extents correctly, and reading the file completely (i.e. not using seek to skip holes) would map the file correctly and all the correct data extents are read. Hence the problem is isolated to just the xfs_seek_iomap_begin() implementation. Instrumentation with trace_printk made the problem obvious: we are passing the wrong length to xfs_trim_extent() in xfs_seek_iomap_begin(). We are passing the end_fsb, not the maximum length of the extent we want to trim the map too. Hence the COW extent map never gets trimmed to the start of the next data fork extent, and so the seek code treats the entire COW fork extent as unwritten and skips entirely over the data fork extents in that range. Link: https://github.com/coreos/coreos-assembler/issues/3728 Fixes: 60271ab79d40 ("xfs: fix SEEK_DATA for speculative COW fork preallocation") Signed-off-by: Dave Chinner Reviewed-by: "Darrick J. Wong" Reviewed-by: Christoph Hellwig Signed-off-by: Chandan Babu R Signed-off-by: Catherine Hoang --- fs/xfs/xfs_iomap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c index 18c8f168b153..055cdec2e9ad 100644 --- a/fs/xfs/xfs_iomap.c +++ b/fs/xfs/xfs_iomap.c @@ -1323,7 +1323,7 @@ xfs_seek_iomap_begin( if (cow_fsb != NULLFILEOFF && cow_fsb <= offset_fsb) { if (data_fsb < cow_fsb + cmap.br_blockcount) end_fsb = min(end_fsb, data_fsb); - xfs_trim_extent(&cmap, offset_fsb, end_fsb); + xfs_trim_extent(&cmap, offset_fsb, end_fsb - offset_fsb); seq = xfs_iomap_inode_sequence(ip, IOMAP_F_SHARED); error = xfs_bmbt_to_iomap(ip, iomap, &cmap, flags, IOMAP_F_SHARED, seq); @@ -1348,7 +1348,7 @@ xfs_seek_iomap_begin( imap.br_state = XFS_EXT_NORM; done: seq = xfs_iomap_inode_sequence(ip, 0); - xfs_trim_extent(&imap, offset_fsb, end_fsb); + xfs_trim_extent(&imap, offset_fsb, end_fsb - offset_fsb); error = xfs_bmbt_to_iomap(ip, iomap, &imap, flags, 0, seq); out_unlock: xfs_iunlock(ip, lockmode); From patchwork Fri Jun 14 01:49:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Hoang X-Patchwork-Id: 13697708 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 267721773D for ; Fri, 14 Jun 2024 01:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329805; cv=fail; b=OrKdXW6Y99q7Bc7luyt3eUQmE32Z9pKq5FW/adyevRiTYYgS1prM8CCZg8fNCSugTCG/pMTIxZaFzuYZLws0fByZz623j7bQFw/jepEv2hWT8MAbCyMxD4UFOeU7kLQXqSoCT32hgsmVv+Mj2h/j+RHld0OCAI5otMC5FJpXeL4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329805; c=relaxed/simple; bh=EIyLHTTVsg20gj5f2xR274eE5lpaU9ef5pGsfpfAl7Q=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=p5VRhDDi9xyulmQuLw9Vz773qhKEuFHpa3G3mSaWmnTOFCx5HmMELm+vuN9sTSO7kmkdu/TP4T09WEIhu3aqbfIXZ0XsxquN/q2JUeLusN8MWmXOwT9tLv9FvkOoCabq0+OcSYrJ51QJcUq1omB69r3Jmw0TnChhUDuSXT9q6I0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=Km5a1eEy; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=wyOubES4; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Km5a1eEy"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="wyOubES4" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1fn5Y022929 for ; Fri, 14 Jun 2024 01:50:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=nZmP4JtkHnQuBRaeyfkpiryiRXqHLtjBFJBVEAi+KPY=; b= Km5a1eEy+TH0oyKfrOA5qkAYeiYebnE92g5UzPejWgjcC/D6nzTO4uTG94eUghZ6 4BO+qjyu5RkDuYXk8WTAbVRtkxKyq5pR6fHWfr8/Dev9Qa6m1u555dzjihUessul U7YTBMHVhlAIWWafIQW6QBFEk3yc1RsTWyGc9ItDw2UYWa8UxpNuHc09FvnnxYWU gWdRE3de+BMnoMNAOBnNypxOGFzUbYR3rmWnvIg5IbpEaVj7DOnJHhX0QoBxWnrK 80oVFp3J0nnOX4XenQ8Qy8prO0UXiXaiVGa67EX2fDRhI+xt4p37QQTNW3Z1Vd5c ysOvSuIHkw7rPd83Wj8aMg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymh1mjs7c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:02 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45DMsKU5021135 for ; Fri, 14 Jun 2024 01:50:02 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2173.outbound.protection.outlook.com [104.47.58.173]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3yncayaukk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTcwdL1jP4G0wakpdVPPMUFWbUNzrr+QSTIyD/+sLnXr8T4ZeRgGXJkd2qj+wZPCOX43XPq8X9Zt2pNze1CHTBXyeSBymDDwuvmm8kvm7+tNSYXNkNO9CPZD5uGltBMjHj6bhz7d59wcLDyJnQGqAkB51RjPqall6jqFVbQOeo9S47TnJyeBjBJbSl4xAG2TGM7WgZ/kZVmn5HiWYFIMYG67MY9+RRrvtExIk8YlLtzpFgzTBsOa8OkuHGKdzCX/y0T95hCUBcddiezVs4um48TnbQ6JFZmxrtWoDSyf1pBX2d6JrVBHPjWMiO9PwPtHimYvrjxKagaeVWOExlxsKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nZmP4JtkHnQuBRaeyfkpiryiRXqHLtjBFJBVEAi+KPY=; b=HZ18gVKlEjH1BCn1UqhDPl3fMRaZn+93DWyXJ/cqfq2as5QJXmT+jiR4gsOQNbnGFrIAsEYe7El0hGhvnE5sbOLDfBtvpM1sSLioe5Jke4OrA2SyXik6PQIztVCCDRI9o9BQ8CZltWlJpV6ZKjXEe1/n0Hwct563IGwdhMBGrm/sFw92dN1xOhPwePAM+vEuGSy0FovOqUqU5wT6YxxeNgyvCkH2KoeYGwQ8NS6gmgAgOwS01YJ3LNiK8T5WMHuI/tPgmJ3o7dDCvRxO85JykvOGgoQqnRzrUxkykX5zTU3d9GAI6pxnAtRVB13grU/exleeHmgzCvTESzXHMqDWqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nZmP4JtkHnQuBRaeyfkpiryiRXqHLtjBFJBVEAi+KPY=; b=wyOubES4ALsVhFOQ8NPWWGPDlTBDbmaKjaEOHsnjLwUmSrudFxD4Z7RsYZxK1nJt1ulXJ+pte41UMoavq96CpyKlYWjjeqq24cGfFDQtkudqfGF7FifKtp1zgcnMJY0yhNqi2Ah/l9Z+l6q7UjO/cWzmaeo6uJ1srq1+/1QzIqk= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB7475.namprd10.prod.outlook.com (2603:10b6:8:187::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 01:50:00 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 01:49:59 +0000 From: Catherine Hoang To: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 CANDIDATE 4/8] xfs: shrink failure needs to hold AGI buffer Date: Thu, 13 Jun 2024 18:49:42 -0700 Message-Id: <20240614014946.43237-5-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20240614014946.43237-1-catherine.hoang@oracle.com> References: <20240614014946.43237-1-catherine.hoang@oracle.com> X-ClientProxiedBy: SJ0PR13CA0029.namprd13.prod.outlook.com (2603:10b6:a03:2c0::34) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: e4258572-4978-41d5-b899-08dc8c144ca7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: QjSSD0Sfxh0achQyyrj1k09eQKSY+G8atLBaT4Tkn8tPHJjiGEO3fvzD9rp7nPAmyOzimOmEWiUGfGOxJI0XBmwc/I3huS2sO29Rk4BFta8NieboCIO7DybZy9S35ZCEMxNJgo99y8kfPFuOQCpa5QhkGYLi+FP7xwxmIJVujjSWnHeubztBFbQXwwyzlNA3CfDhQQlDSEol9d3alkKQeMsTqYJXcHB/m9IiKF+KXg2UZRn//ZLDsujOJe5ucQ3XLqU5NO98+cI5CYtfpCzHNNswu/Q3vcOKaLqKqjDRicygjYXKgARPk7EXB1cxs8Rd0MMV3eaPJiXgZgb7d3KoaFaPSe65WXP4mbBSECctshuJyKots7zkU4cGgbEpFUV5FWxmnF9k4F5pHOxEQ9sbr9Zms1ZjILOL08wkDFtB7aUhTa0je8NpEpAXKMhK1rSKs/UgMJUjfKZTro9c+87fkjldMZM1zhxfAjM4Eu3N0z+kThE7tzEctknSyrX3vY+n8FT3l/S/haxBThwgpDVfVhbcLABWXkRbOukl9ZogzbAK0P+Gb8sQzY0inNjjglIq5Uv0la1owdaAxC4Cs2Fxk8f3X6zbH1SIbJx1C5Ww3FwFO1szQIVKf4UntX7GZUkhkBdf6wS0EZxxQnJViK8gFTUizJmMfnFEj+MolrcBnxjK4KK/0fPHJDlynOLYMA+GaoTn21/M6sC3tRUkeGyT3WYMF1DJpKGv7YDnJdG/8GR57eblPOOCTGQVCXD3z2HM5M+TdJJK9Pw9McypR2J/Xhe3Kcl4W/W0az4skStWNCZUB2yc966WFkitxJ9JsOvL7vJlo8nj1W5uTFcxjX0XXTm/b5uQmB2M5ma3obEck7BztsEnbqgAyPOi6L7s+yu1rkAo9Dh+kOCOtk2yN45Rw4KAAp9NwcTgmdAM4m7jPFgjRTw/mZoyznUJ4/BMSO77juiayqXtKrIX8FYmkwS9gEAgXuRiThlCCfIWL5kVu39Odwco9o8291YbAM4Uc/OgWwmsgXaSlO02XH3AED/vs+SPR4/wWA5LD+DsMDxzGAECq3OFltb35aWowC7szgzMcfNI0JgWDo7uYub1VoLS7lvUy+fFiPENRIKaYBPdwHibnS6+Cosayd6r9KmPq0qLRnjVGYR33Uik0V+6NXUtxJYtYTVxVk+EgKbmbPNoXAMdd63HiJNEzAebrAlBJQvUsnQBb86L6EbHmBA0ul0LkvXrMacAKU34mMyzmrTjELYMrNwK54nk13IhOTD4jmY21LD/PCxs597sxqls/dkOns/dXdpAor7pYLCGebvCEXtqnmuwslHDCXIIBoHr1rC7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YRNz77nVIac0uf5/D44FDft8V3TtnRAuM8zwgioN12dnlQcuk1i5yxSiFYfjt/dM76IvFqPSk3xT12IRRnH5EZQaxlOZJvYLO8hkuftOHG8blqs8MhSbn6D15Bb9DT04qdRP9B6A4RUV9ksdnAvJr28PDWRtNRx7iRPWECHM4Zwgk2yjOTw2pmDhHf8suCX6x86+GjQ1efjdt9nqlzjFMTo+8pW7S2bnSFAL2t/qzpV9rdAeKLuB+/3/RDOynog1uOdZNwQEVgx4prgLy3L3tXjj0yBE3I58bA9fu+zezuMJQibU6TCTK/Vg5g7rAFcMq2UIlBZlYH4SUKx8jwlJty5O7YsZPkRBLm+JAr4wWpAjGrdJToCScwqMLnLFZdr6m6KrsHV1iyQMxzFBA+QgDIu+NpOxc5KnJJ0xPoU8HbOe8frvFaB3wFr9j1HS0GHX+TVWNPSkf4rLvIM7k/UT+Wz6Asd+piJPoDN2sqL8TTLgO4yDh1KHWF0mYH62xDkA5mjVrqtcBvGvKRkudJPF3acbKnil5NfMmaj1PreIXTgpWAOGmeOb6pNrMlTTeVfFfD4duhBh8gsr9gEsKkvv28A1qDDU5wzDPHwInsHjB8sTESpqoMT8BiNriBC2jA6wPRpVJ0yaNR+8vv3FUEFm98E6wmUj+nvza1gJcEU8F1MrRxsdtNXJx06mm3FJWkgi+RJQ7mSr8QErWIQgJflhc0PCckdxXWsqH2R1sKiM1iYu6I8B+Akc61rKkA72Ao7yXjsmsNj4o6rZ3Y0TehmKlYUT9FwmgEuR2X9Itu3j0ruyFNdSt03jMqt3HvynW1FBM2DRJBZ2SuQjVpeLP7wRTAv/vlCAXgC1YPvYfR7G6HuPmiuBZHDHZtVNvgEj2JBUa6RDxemJ+oxo1JWDkDyroRIKjO5nbKLN9KhyexYON9RS2DkE9Xj6hWLpwNWcJrV1QnQ3tGFiDTK48dIeBaX3lWJ6a7LSXtJZqeiFrVVITN9oqBmxxYVoTy7ATky4pw15e7kbZgqQKsZjuf2qHMZYLJtCLJDFNFppy0wKM2S9dbd35X+UPqC42WtzLnu+UqJhUxTHpDqdY24v/Xln3IF+8DERt8PCMo05Z1wCxXS6n60JYh+y3fWimibuID9+6j6b15jYO0zdSPXyW7RlZwBH/80FBlj6pbaAulxN3IJVQhk0fjtFlrvJORUPDbAHo2arKGDaq8D1wNbbT5vJs/6ekKkRz92F3RWP5CyNzLrlQ6AakQLuIow7ksLSGHKwrpMpji3u1UYZip8UbxTrHr+Kub3h/8hy+lh+4xi4xSMoI1JxNPqTz6Cf7OMnfXuY6q/4AWM2V5F4XK3DL3/lvBKUu5U5TJfZAuE+Sg8xUhUAsK8OL2ojCbKnFHsJmD+gkF8vxIsiWzkTYCcYNa+W05ukiZ5EVofiklWv5BPxg2MNrXFoVdstm8Reg8805inXeSPiPuYr8Z0nI+ARnKMcaM6uqjmna0EgnzPIwWtqJEqYY8WdLcKcUZ0/DMDGoagb9/4jfoUrcYhxBKfd/CX3YsnYRyOPe9KCE0yPfDBtk6VRz6IdSDaxPvQTPxTSgtRrozVvobzQIUbN1GuvL1ZgDy/cKqmh6c5KSf9gLxTho8dCRfUVCcZatj5UEupeOL+C5uUPaHFITD3DxqtcSJenBUvttA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CZI7IEshpTgJE/u1ZCe3dplCcOq/4u8xFKtQ1PAGCp/y6MUHfKcyTQLGL9HxyiRoyjPLT3X9srv4GnMLftKXchYPpxdOLwmgcatli/Yx1vdCPVDcwcJM8HMobIsCr4SIsmFPuhiwMdzdc3q0BT9DPzGFxVUG+/c/eBab1l+Sqc2DTTnRL8JFOSBKlh7h5ohoVWarFH48APgjWYqxNP4SKdYG3YzxjrMMgMTpZzln9RZR4Q1pGJdyuUaPLv7Np/vdO+/MKp5ORTaPzsF4JyIuUn065rKGQug2ha3zyE15PD4+uuyF9UjTe8Dh5uOcfHk0tJ4O72dpPOZm3Sn/ixLhcV0rc/dJ2mVGD6ohVPWYiB/LNCgBKBXc2DeRdZZAXVfzKHhtE4QrA1PEPLN+sQ2omUqC47K3kaPr7mDeVpaIGulZ7c6MflkyWSDV2Cqx/R2HDeF3sXPJvK5OfbU9KewpOSAsiXQ9JSgrpHBNR3E1GQejj4q0W80m6jRzVsF5pK63lO9sEaCdjZyN4El7D05wtqC8Kn3644EdkDpx8XLjJNtuhB14ESBCqA6yQag5DOSKLnNniTwItKOROd5l79tWyn3q7BTxqTxNYJW1ru1rdNY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4258572-4978-41d5-b899-08dc8c144ca7 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:49:59.4615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zSWgUFE6psV5+9Xn8b1dAlL6Fo0NppSJDog6XB/2WVp6Ec59MklMyCsh3i/lbDFO8b2x1cHfl2bLKvStHSl/r41ZHe2pfGzI0RpYYDcvOTY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140009 X-Proofpoint-ORIG-GUID: CISWJPzvBWPYZcsiOqH8BRHpRsPo8gR0 X-Proofpoint-GUID: CISWJPzvBWPYZcsiOqH8BRHpRsPo8gR0 From: Dave Chinner commit 75bcffbb9e7563259b7aed0fa77459d6a3a35627 upstream. Chandan reported a AGI/AGF lock order hang on xfs/168 during recent testing. The cause of the problem was the task running xfs_growfs to shrink the filesystem. A failure occurred trying to remove the free space from the btrees that the shrink would make disappear, and that meant it ran the error handling for a partial failure. This error path involves restoring the per-ag block reservations, and that requires calculating the amount of space needed to be reserved for the free inode btree. The growfs operation hung here: [18679.536829] down+0x71/0xa0 [18679.537657] xfs_buf_lock+0xa4/0x290 [xfs] [18679.538731] xfs_buf_find_lock+0xf7/0x4d0 [xfs] [18679.539920] xfs_buf_lookup.constprop.0+0x289/0x500 [xfs] [18679.542628] xfs_buf_get_map+0x2b3/0xe40 [xfs] [18679.547076] xfs_buf_read_map+0xbb/0x900 [xfs] [18679.562616] xfs_trans_read_buf_map+0x449/0xb10 [xfs] [18679.569778] xfs_read_agi+0x1cd/0x500 [xfs] [18679.573126] xfs_ialloc_read_agi+0xc2/0x5b0 [xfs] [18679.578708] xfs_finobt_calc_reserves+0xe7/0x4d0 [xfs] [18679.582480] xfs_ag_resv_init+0x2c5/0x490 [xfs] [18679.586023] xfs_ag_shrink_space+0x736/0xd30 [xfs] [18679.590730] xfs_growfs_data_private.isra.0+0x55e/0x990 [xfs] [18679.599764] xfs_growfs_data+0x2f1/0x410 [xfs] [18679.602212] xfs_file_ioctl+0xd1e/0x1370 [xfs] trying to get the AGI lock. The AGI lock was held by a fstress task trying to do an inode allocation, and it was waiting on the AGF lock to allocate a new inode chunk on disk. Hence deadlock. The fix for this is for the growfs code to hold the AGI over the transaction roll it does in the error path. It already holds the AGF locked across this, and that is what causes the lock order inversion in the xfs_ag_resv_init() call. Reported-by: Chandan Babu R Fixes: 46141dc891f7 ("xfs: introduce xfs_ag_shrink_space()") Signed-off-by: Dave Chinner Reviewed-by: Gao Xiang Reviewed-by: Christoph Hellwig Signed-off-by: Chandan Babu R Signed-off-by: Catherine Hoang --- fs/xfs/libxfs/xfs_ag.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c index 18d9bb2ebe8e..1531bd0ee359 100644 --- a/fs/xfs/libxfs/xfs_ag.c +++ b/fs/xfs/libxfs/xfs_ag.c @@ -979,14 +979,23 @@ xfs_ag_shrink_space( if (error) { /* - * if extent allocation fails, need to roll the transaction to + * If extent allocation fails, need to roll the transaction to * ensure that the AGFL fixup has been committed anyway. + * + * We need to hold the AGF across the roll to ensure nothing can + * access the AG for allocation until the shrink is fully + * cleaned up. And due to the resetting of the AG block + * reservation space needing to lock the AGI, we also have to + * hold that so we don't get AGI/AGF lock order inversions in + * the error handling path. */ xfs_trans_bhold(*tpp, agfbp); + xfs_trans_bhold(*tpp, agibp); err2 = xfs_trans_roll(tpp); if (err2) return err2; xfs_trans_bjoin(*tpp, agfbp); + xfs_trans_bjoin(*tpp, agibp); goto resv_init_out; } From patchwork Fri Jun 14 01:49:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Hoang X-Patchwork-Id: 13697709 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EA9718307E for ; Fri, 14 Jun 2024 01:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329806; cv=fail; b=QmZnVBqWgfAmup5i49QaJbP2KaK9DtQM0+3ZGtIaO0y1zBEQdj/tfePwT/C2XMlp8k1yKnNENmrqAWb1asikZruweEPUZGllTsNZGrydBog/8QXlm95F4JWYFeHqIJA23yT8M9c7U8M5atjiUxDxWQR3QKboUNXydUT4I7dJlV4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329806; c=relaxed/simple; bh=h08h4RlV4yVXa7tlNzC2rgXcm2qixD0sig1lAOmQupI=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=hHGNJdYLBKzOs7L4Pc/l5P4BiHMN7X7wOMRXY52I7Prq5K0OG6q4BkMyWUz0mLyuWKLZYpu8TqmFvXHIbwGsbpF2hjSL2i3ktjNE4jIj6w4uuzC55XBrqYyIhPlzcwWnBrFAQzCfPH6bsrnrOYHt2XFOIe2Ktyw3nNSx+nogr9I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=G8t2AAQi; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=ycrrNqA+; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="G8t2AAQi"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="ycrrNqA+" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1fQgQ010212 for ; Fri, 14 Jun 2024 01:50:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=j4AYwDEUk7A82tS7R/8Bs4kb3E/SeU7+3+Mo7cFQzSU=; b= G8t2AAQib/TkncZafr/xML9xjq/uPhNBuW2cCTCXVxGprK+zMLi7FonfLf2IBpnh zwBMNMLB6VVCnnO8tk51PLj56JXwL3yUQz1mhasjp+bDglRG/ywYBEyRRquEIRsf 34Pe98jCj7RuGOKBA9YDJcmOI8NiHF0n+rFaNHuSlRtKReqOmo3prELR0Mbs5gc4 GeEoRh0COrEapH1zXv7ct33UwYhI2LJjKisbNM/c3lZB1JwL3SPbG/YKtRIYqk0V CVq8oFYPZn/Zc8PivE6IcfdUcSQQCxs0/Jp6f1u9hHX6AMh/zggwbnO7NaqeHWjT hpWTQB4B63AU3z/xVIIa2A== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymh1gjw10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:03 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45DMsKU6021135 for ; Fri, 14 Jun 2024 01:50:02 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2173.outbound.protection.outlook.com [104.47.58.173]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3yncayaukk-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZycfO6bze4H/P9ihb7RZ8SEP2fIS23FRZPZMhgKCJpu8u6tUvoMCGO/lKZ+MKV9bXpMl1ePj+QlQtwvc7gYa6Fi4hr2OTJxeusLnPbJ0KrKxEo4SlidnRZiq2hp/Q8KTG7jqDSE6DU6x4KyfwlZCObNdVx1Z1N8G2Cd/S4pdQvo7wbmsv2HkCqnCkrDokzVwSH9FJXJFHMD/awiOdYzNKx1SNMHeKIoOaULTI1guwq39CsXNfCp490WBz9uKPRaFwHz0iR11FNZpby4lFP99ATJl4FeYGp3kOUnSxNhMNuPeUS3HCGBA3PGfmzyO1sLnRrZ5hrF6kK/S5+WzDgixdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j4AYwDEUk7A82tS7R/8Bs4kb3E/SeU7+3+Mo7cFQzSU=; b=DIdsGAP78DML1gjYgzJ5fkQ2VGNCivpckGQwvpl6qBYEuHClhzi0PPibRqnlAn9cCUyq64toFHI/K/Fsj2eJjq0G/fr+eSjTohKracitHgaCZMfR+noqCcezkWMGlaSp+s3VYaHYiO9D3w594ZZJDBwFAw7WP+7MvWUpFYaHq3xbw20uraYAPWdOtxnU6M2+NXVOa4kmV9F+51A71V2OnsihLgEYALgvLjdTVDJnaIM6HU5T1NhCwS1IB1DuI25H4uDWsr4oCEnt1yYfkChJ11FV18K0RGE8bwJeZUMYC218oATfLf3AK88q1ObkR9tLPab2yQhJDdQyMLGB5zfjMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j4AYwDEUk7A82tS7R/8Bs4kb3E/SeU7+3+Mo7cFQzSU=; b=ycrrNqA+O7DSIWB/qdle7ScPubdIJ15uxcg0lQXSCjDEwWS2myEpgVLO1jnlEHwEyde3eNeqy1zZPx7UPRtTyilCi/PQidWGhgjhGoWdXguPe+D3hww7eQqhYBsmlFeuwx5HvlWGwm280aHF5Z4VuTemii9rdxMXj3pdstVyols= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB7475.namprd10.prod.outlook.com (2603:10b6:8:187::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 01:50:01 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 01:50:01 +0000 From: Catherine Hoang To: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 CANDIDATE 5/8] xfs: ensure submit buffers on LSN boundaries in error handlers Date: Thu, 13 Jun 2024 18:49:43 -0700 Message-Id: <20240614014946.43237-6-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20240614014946.43237-1-catherine.hoang@oracle.com> References: <20240614014946.43237-1-catherine.hoang@oracle.com> X-ClientProxiedBy: SJ0PR13CA0015.namprd13.prod.outlook.com (2603:10b6:a03:2c0::20) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: 38c266c7-e9f6-4d2e-7d69-08dc8c144dbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: IdgcSfFUDs0OZQLTQFFAu4WS4sB+SrhqyzPu/Ff/xaadDGIKjVCWVmywXNXdUFax5q5zsl2MUc3wnler8dg2YfGasttpmgXpR67hInYfXFFP7iUwyVzPr6hP9x4c4feMLJG07rlLYrvHTVwDPtQqQifClPziQjWwfuxXtx9gIpE+xnDLyPttbPkj84H/ElCRx1cQ0k6oxTQMuCNhOLfxeppnKPxydt0jl4nq0flJav5zmlisqnGBPNjSbQ7gSI9P33UAXxtMs9Q+5INFPoV/mZ9gRrQK4u+YjNBLOv42RmCeRjLam0xrpEOC3HdHzXzZEmB+W0BKtnqOXxK1KTfE9UH60xmzfwZ5G7Woxu9LXp8TrEdYHwW14OY5dPq5sbTFhJgF+13tQRd0TRPaHAK5XkC0EXCdyq83RjWTo2+DzAJlwt1XDQzPZBBFLDarVf6PyDQFhHvVh0YXhW+05q/cBlUesq0z7TQa0OT9XfzeZloiCXpZgzUbCQYQP83iLG8VEU5VbZNh+daXHcj5bxf5X/tci+X01MyfsQeVr3VMHuEOLzTI0lHErVfCEAUCobCLhTJ5P7bbYyLn1XWDRU8X0mH43fuu2/a7Z9vZ0eYgyZXrG3GsvvXXY2BzKiB/OA55VjQkiNZyg24IXHTos7OBtrh3ngSFW3x4b4iYqS2kr3OSBJj5BkiPF7sQwvJzSi1w5WDcukyz424Q8AJTRrmJaexcZIZKUvW/WBDQBY4ZJtOQSBXvG4Ibwf9eD7PAT8qJSf2HhaF4XRIkv6Dvj8f2zevLzxrRX7yu6yDuF6NpAbcX9GQ8tNdhXk5LUl7RXrrgk+URCrtUK/ONhbxVY6BW/n9ey+8yrIbSugsUKoFo+fnqsMv8haV1qgMOlZDM8PgxsP2P334Bego5w6DOjQc0zZG15i05uN2Ax7b0IQFe4ECZLhF/LEDXSeX23ateMrD2bmhlQS8oyupegoFmFgzyM3KZTCNVhStzwYZWF4Np6a7ovt4I1GMwHcZjb8eL+vyB6IVRnHceGQZXk35Mtces4r7yr+IB8dU/woE7c4mzAE+l6EePbCkirU8RE5P/tu1arqGeNPUw1W4OwvhnXuTQ/siCRXLInNflUZsrpGXhOsqNaqmqMMIuz+0f1shCb0Q75I8u13akopHVH1p17NlhCQrDrH7+Ev1sD9ZHd+ACVHnlceaVb6HqOax/M3fnNPzaX1g5rGcw6DSfa+MMxCEB3oh2Y1DLQThi/bfI0DQBAK/RkxC5YK81n6HNF2Y8oQLRcWBpJ6RWxuF5MKHrNz0LIWnNoHRz2Dd0U9F73D4q285faIcgVvGKGflkrh9n6eXO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UPfyTh0N1Hd6SsyH2SjzKwCiaQpGL8zcPsJdCSQ+HhFhXlcghSayr/LQfH0yYxLm6pA7/K17PO6ssjOA3oBRr7cLT3ZYgds1upA9c/pMbtICfKqSQXPdkZggzOakx5524xeK/iQd7pRtlU0fqb3/RI+za23qqj09wuUQDsJ2v4tmP/s58YFaZ0h5XlfK484Gpy4KkkRQ7r6X99UQPX72W/urHx+ptqOlWrFgHHLhmu4DU8IAn+rsQSqspSlZiJr6xY/iKG6mUwVPZp8sgu13gJ2IBdr6Oqy8iJ/bLlgoDTJyNMyQqHECeRM1fX7UwuFAAuorVzzTQ6JJ4AQnEWol3vxHYLdncUc8eHlhDbDLmZHJgo7OYohTaIObkZPTcXrMFufnly5fdVal8aFyO0Nn0s8gNs6NNix2Atj75+V4MpLdyXq28DLyD2wgO/S5SpoYG2j6BhAmP78hWY8YWZ2slOtRtk+uvmQdNWRu+KDL5eq/k0P0dfHVadStjvRT6HrbZG93zv9kGIy4gX4Ikblc7HrjKl02EoYE2vzOYZJp5G5s8Tch0n4qe2kmLkswyMqZNKiNdiWtaIp4MiSTKdb0yykK9GIpBMuYjsM0P9Vn3iIZsrSjTo/C/Ag+FxjY/MbatKXDYzr/NB5td+8bSbNgpK1o/VXWX7/XCH8SvMye81OBOOmjIO+X4M5m0ps/YLfFvl15Hp8g72I7PPa1D/yXr8ZW8I4O3qXc+IV3kKlJZCF+jSkKZPdliu3zCo3W1iYoH2PSj7fXXsnv71tw3hwh39/MjbbLMhQd4E2lW/shQzM2Fovx8zDbdRcR/xhYee7LTi3Bgt6JXHZaS4ZwKfbgvsojoHRP2fa8A7ri5kg5ZUljCU6qsxwLlgJFaOzqwwjNzgtrdw8ceqs4q7a0dA60rTef69w4GUeUB1AxznyudpLi7TU1UspFWCyRUyycHPmaUDHV7I6k6kAyF6aPr2bjiIjy4P/KttAiKmS+x4mMNwHnPCwDi3olelTajs38tPTdbe8ZkwM9J3y1y4Jo7EPy8QyWTstD6RAs0mxbDB6gclECA+o2BurXEkveiDcUOlM9MEGc/FaXmfjIasC9/2dnjfX9PlI1gn3s6KB4PSo7Wi4+5HGKG/wAn+/K1dWhiOm6zGy1EKi/JS9Y+i35765rZeMtUA+NJqPn0IGHcka9cuLN9OxFZFDmySoVciP8wFSMSr/tgtmOJuPoUGTpuIKhQMko30qXiNTRXan/CBGVpo7ksoil1ZPqvJxuoDaNv8CTPdZrG3316tdN40usJfGeXGyJF/2MAL4n0a3gUArjmbmfR/1fcdBti4T0zLCeUr4o2+hkWRpIPNwPXHVp+6VoVvdFLPi3n7N4Z8QHHQrVZQw3gmqvsOMrmtg18gq+meiLXbK//u12Ui2PatAk91dz+SA9n0WIBsFqcJITVC48bAxi/Hq2LK/PVPaotboCE5A8g3aCGgB6hORCf+dW0oDomQiUyt6DOpzjI+0DINJ0I+O7b3dV9QDnYX7RgSgQypbV64AJCzoq0/o0SaKNefPe8jM9q9vhOLppknZnGBzlikpHKWg+JPYPz8ono4g8wWhPptMKn9y0Q+9LTJlwyIGf4WH3rigFkb7uqAyOKeCOc4NZmDu+70Kw6UkPCZluVYohhsezP9B6D3TAudN2UGNyAA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GyzkNp33Y/bmI+CpmHCCxgRDKIEzphBF8uotKUCF4ew1BzcufSBtW3IP3+gBOPgWXjIlEnkxaOQ3WOSbYQl2Nnx4iS6SKMQJXh7qjJaTWXI4AGGdkzdvRdE34Yho6xy3UrIkmaTOdN/7RJ3SA40PTMknDn6485SWiDSQNTjyKhtjaM+b0q5CVklJ82zdFp4hwUTG8p+N2ffsG4YcjC5NhYS0overo8EW1kE++URD+DDbXthumNPdm9xi+QNKHNJFBJqox//Mm68Bqz0HRxWFb0qPaMfd4JzbiP7AKZiTKvAe84FwM1rp2Cfalsap44c3/wroTJKEi0idd4Y4IEh+WgvdZ6+KsZbkuiSfZgpb7EiC10oni2gxg8mH/fa37TDnykGe6m2Jqlx7jv+PsxB+15sTTMtSbECj2KRM/Tuc8LKWPsLk8RH6HtIh4Ci5CGZcMr+0Ga3tuwPYfd5tB3prht/Z2K08Jdw7PxQW8iXvm7DiUnVkuCCkfPHIzMQQXThXN6vW37/jYQ/gPJJ35Bk1CDuxcTr5jr3pq+G3UfBthT3rbyexMcNbTXpVpsK/cYXkzthdk3S5fJuuR4DvPtXpdXd31avoPRhkVd5OT4CVsG4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38c266c7-e9f6-4d2e-7d69-08dc8c144dbd X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:50:01.2650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oB0ujBHLFNoiLtZJI2TLiB7rqLrwebJo39x+605Q4tRjVS8AG92GE2eGu7UkHrBphG2jP8sChUCCjLN2whQ0GqVo1G4AKSxyXqSh62yhmxE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140009 X-Proofpoint-ORIG-GUID: V3tVODC8Y-GGC-feYacLTfGuK-jdoptA X-Proofpoint-GUID: V3tVODC8Y-GGC-feYacLTfGuK-jdoptA From: Long Li commit e4c3b72a6ea93ed9c1815c74312eee9305638852 upstream. While performing the IO fault injection test, I caught the following data corruption report: XFS (dm-0): Internal error ltbno + ltlen > bno at line 1957 of file fs/xfs/libxfs/xfs_alloc.c. Caller xfs_free_ag_extent+0x79c/0x1130 CPU: 3 PID: 33 Comm: kworker/3:0 Not tainted 6.5.0-rc7-next-20230825-00001-g7f8666926889 #214 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS ?-20190727_073836-buildvm-ppc64le-16.ppc.fedoraproject.org-3.fc31 04/01/2014 Workqueue: xfs-inodegc/dm-0 xfs_inodegc_worker Call Trace: dump_stack_lvl+0x50/0x70 xfs_corruption_error+0x134/0x150 xfs_free_ag_extent+0x7d3/0x1130 __xfs_free_extent+0x201/0x3c0 xfs_trans_free_extent+0x29b/0xa10 xfs_extent_free_finish_item+0x2a/0xb0 xfs_defer_finish_noroll+0x8d1/0x1b40 xfs_defer_finish+0x21/0x200 xfs_itruncate_extents_flags+0x1cb/0x650 xfs_free_eofblocks+0x18f/0x250 xfs_inactive+0x485/0x570 xfs_inodegc_worker+0x207/0x530 process_scheduled_works+0x24a/0xe10 worker_thread+0x5ac/0xc60 kthread+0x2cd/0x3c0 ret_from_fork+0x4a/0x80 ret_from_fork_asm+0x11/0x20 XFS (dm-0): Corruption detected. Unmount and run xfs_repair After analyzing the disk image, it was found that the corruption was triggered by the fact that extent was recorded in both inode datafork and AGF btree blocks. After a long time of reproduction and analysis, we found that the reason of free sapce btree corruption was that the AGF btree was not recovered correctly. Consider the following situation, Checkpoint A and Checkpoint B are in the same record and share the same start LSN1, buf items of same object (AGF btree block) is included in both Checkpoint A and Checkpoint B. If the buf item in Checkpoint A has been recovered and updates metadata LSN permanently, then the buf item in Checkpoint B cannot be recovered, because log recovery skips items with a metadata LSN >= the current LSN of the recovery item. If there is still an inode item in Checkpoint B that records the Extent X, the Extent X will be recorded in both inode datafork and AGF btree block after Checkpoint B is recovered. Such transaction can be seen when allocing enxtent for inode bmap, it record both the addition of extent to the inode extent list and the removing extent from the AGF. |------------Record (LSN1)------------------|---Record (LSN2)---| |-------Checkpoint A----------|----------Checkpoint B-----------| | Buf Item(Extent X) | Buf Item / Inode item(Extent X) | | Extent X is freed | Extent X is allocated | After commit 12818d24db8a ("xfs: rework log recovery to submit buffers on LSN boundaries") was introduced, we submit buffers on lsn boundaries during log recovery. The above problem can be avoided under normal paths, but it's not guaranteed under abnormal paths. Consider the following process, if an error was encountered after recover buf item in Checkpoint A and before recover buf item in Checkpoint B, buffers that have been added to the buffer_list will still be submitted, this violates the submits rule on lsn boundaries. So buf item in Checkpoint B cannot be recovered on the next mount due to current lsn of transaction equal to metadata lsn on disk. The detailed process of the problem is as follows. First Mount: xlog_do_recovery_pass error = xlog_recover_process xlog_recover_process_data xlog_recover_process_ophdr xlog_recovery_process_trans ... /* recover buf item in Checkpoint A */ xlog_recover_buf_commit_pass2 xlog_recover_do_reg_buffer /* add buffer of agf btree block to buffer_list */ xfs_buf_delwri_queue(bp, buffer_list) ... ==> Encounter read IO error and return /* submit buffers regardless of error */ if (!list_empty(&buffer_list)) xfs_buf_delwri_submit(&buffer_list); Second Mount: xlog_do_recovery_pass error = xlog_recover_process xlog_recover_process_data xlog_recover_process_ophdr xlog_recovery_process_trans ... /* recover buf item in Checkpoint B */ xlog_recover_buf_commit_pass2 /* buffer of agf btree block wouldn't added to buffer_list due to lsn equal to current_lsn */ if (XFS_LSN_CMP(lsn, current_lsn) >= 0) goto out_release In order to make sure that submits buffers on lsn boundaries in the abnormal paths, we need to check error status before submit buffers that have been added from the last record processed. If error status exist, buffers in the bufffer_list should not be writen to disk. Canceling the buffers in the buffer_list directly isn't correct, unlike any other place where write list was canceled, these buffers has been initialized by xfs_buf_item_init() during recovery and held by buf item, buf items will not be released in xfs_buf_delwri_cancel(), it's not easy to solve. If the filesystem has been shut down, then delwri list submission will error out all buffers on the list via IO submission/completion and do all the correct cleanup automatically. So shutting down the filesystem could prevents buffers in the bufffer_list from being written to disk. Fixes: 50d5c8d8e938 ("xfs: check LSN ordering for v5 superblocks during recovery") Signed-off-by: Long Li Reviewed-by: "Darrick J. Wong" Signed-off-by: Chandan Babu R Signed-off-by: Catherine Hoang --- fs/xfs/xfs_log_recover.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index cc14cd1c2282..57f366c3d355 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c @@ -3203,11 +3203,28 @@ xlog_do_recovery_pass( kmem_free(hbp); /* - * Submit buffers that have been added from the last record processed, - * regardless of error status. + * Submit buffers that have been dirtied by the last record recovered. */ - if (!list_empty(&buffer_list)) + if (!list_empty(&buffer_list)) { + if (error) { + /* + * If there has been an item recovery error then we + * cannot allow partial checkpoint writeback to + * occur. We might have multiple checkpoints with the + * same start LSN in this buffer list, and partial + * writeback of a checkpoint in this situation can + * prevent future recovery of all the changes in the + * checkpoints at this start LSN. + * + * Note: Shutting down the filesystem will result in the + * delwri submission marking all the buffers stale, + * completing them and cleaning up _XBF_LOGRECOVERY + * state without doing any IO. + */ + xlog_force_shutdown(log, SHUTDOWN_LOG_IO_ERROR); + } error2 = xfs_buf_delwri_submit(&buffer_list); + } if (error && first_bad) *first_bad = rhead_blk; From patchwork Fri Jun 14 01:49:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Hoang X-Patchwork-Id: 13697710 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2887D3211 for ; Fri, 14 Jun 2024 01:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329808; cv=fail; b=W85yUmR+c9f+AGiNe+cm1PguZjzasAVR22+N+Ym5AGuehTXSkVmtUiFs4BHPas30Qe0FFw50OfrlrWrgRYJ44dgqkQ0bPZNrCL5QReQ12K8b/Z6ZvQ/ozeMNGnLQdhty8Uk1FXWo2o4IAe8K5yrI3bZAhqAiONVYTDx9qi5w4pg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329808; c=relaxed/simple; bh=nfoaLKzd/AvB1cVW5YKg13V1gt/GkV6hE04KVMfkPYQ=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Un+QTilChf19WsTUPGPVxTX15Pxm5rhPlfFCfZbTQQliWykgit9ME5ffK+msycusetuRa3BSJUKn/ceQDBYSluqOXZKl5nopi6Xs/ywlBwa4c4Alne4Tqkv/OlrctUNYAJq177cSFlwpyj5APqGUirWBdiNLrQlAD1fLOVNGz2s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=X0odEcnj; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=Nd3IOh5B; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="X0odEcnj"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="Nd3IOh5B" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1fWN7006369 for ; Fri, 14 Jun 2024 01:50:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=qdluHNktMQI/+0oPHzcna72Ke0r0azmSgSieW9j1xCg=; b= X0odEcnjymFH7iL6+8HmyPqP0HJwZvCn24cJ/8Ity063g6Bx3xKYVaNU7phtqVKF v94oMaHcoRHimPyjjzAG4M8/cMjud58X0o2kg3ntWLw5i/l4K3R7+iXez1qWXUzg yzYkl8fJemHIa38L7z7YKn1FxQjfhWoQB3gBxeZUBUmMqnWdMfNOmpFboO+1f/g/ fTgsfAM3l/cP9e5EfBWDKdSG05Ayoiyc45dXkqyXLI0siaasutYNgMRPP3iEiEP+ LUrNyCcV6CLtZvhO3+sFDlxWzxtP6f8+3ZMKAVhJa+QwvV2w1RhQudIxNRd3u4/U 5n3W3mMs2yIEg0hBo8Yl7w== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymhf1js9v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:06 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45E06JVL020455 for ; Fri, 14 Jun 2024 01:50:04 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2172.outbound.protection.outlook.com [104.47.58.172]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3yncayaune-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H8tqeHJfozLWLSHZqwL0b4uLDsB5zjFbYEG9QoIWeBC49U+9iqleardTjGX0REgI70AAdRYfti+OOz+aPEOD7UzLOE+jGgJJXBPSHXqjVCasOZr0kBT17xF3HvlRM76Qt/8KwxnnDXj81huPivF/SUgCeuJ7gJ7WvPzUAFBEDReW3j7IcTWeJpcqS3aeg41IVXc6cmTjGtRT260FkIgeP/rCe8DhaURNp67q+S2mOk7FV53LqKLWuDh8cDvgxP1fnyF93faiSa2BZp3jRmoj1hk1UfS0kEKXnQzQWCSLYSfAGXjrs3PfZeqGeJx//kF41iP5ZvtPOGdB9BsAdp+beA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qdluHNktMQI/+0oPHzcna72Ke0r0azmSgSieW9j1xCg=; b=OjIqEBRyvZJSpnvhxYfdGMBrSEeutaXnp1hvMoYRfW8TqANcvRGSyH3gAk00424tz/C+lDbV5IajzfGqUhd+umumcwbgFhk9jCTyKxl/Po2nr75hwvQ3vQb7AomloOWwfSfEp3ZCkcGSq08b2n2oZPTUP9hrwh5adsVvRowrnYsYrybfJkIcfOr1NUgErSPhSWUMHaf2TRLiT/eQCMlQE9dS6oaR7QL3W32ogTIiLCCqBYHOWA3SNztV5KqSd/uqLOpp+UtSCPgKMaRjGjoogjO0gVTSQB2EMiXyLHn+uzL60y41HMCz6QiLMDTpxYAqk3m/HXvqwIWZXhDJ3cyUPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qdluHNktMQI/+0oPHzcna72Ke0r0azmSgSieW9j1xCg=; b=Nd3IOh5BuaWQ7cmH8k7ocPyx4Dc1LAlW+grujSF/OBFTaQUDOgJymz4QQ0vN4fzCwN4THs5UMiati89Ku9+LK3ky3bS+Np/8FTnzKGcfMtWNo3kXPsuJryub++BLpyXS41HbWWfZ9KkJ7Dv4m4mswbHSjParHdg8q3kEEhCmTFw= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB7475.namprd10.prod.outlook.com (2603:10b6:8:187::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 01:50:03 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 01:50:03 +0000 From: Catherine Hoang To: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 CANDIDATE 6/8] xfs: allow sunit mount option to repair bad primary sb stripe values Date: Thu, 13 Jun 2024 18:49:44 -0700 Message-Id: <20240614014946.43237-7-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20240614014946.43237-1-catherine.hoang@oracle.com> References: <20240614014946.43237-1-catherine.hoang@oracle.com> X-ClientProxiedBy: SJ0PR13CA0016.namprd13.prod.outlook.com (2603:10b6:a03:2c0::21) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bdb58ed-484d-4459-57e8-08dc8c144ecc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: c4QRn2B9tg3LHuBzwzzzgx/UhBR+myu7/YM3xHxhSYUL3fnDWat1oeibN9ZhoZeHzEIdhcO/xP0jn+43v9Bs6BZClEF77iNFZwzhz0kIJN3X3gBaiqWb/Lw+Q6Y4YWjeU74oxsntGGAutyu0tGxQJXzZMaXZIezGLk5HdbgpqFynHM2zBExGcNj2x1bMOTJCXtAyqMK+LhXtuOjAY2gfMfUZfDDCVNNQiOLX1dBOlXyFfDGU9ALRr9OwSfVJUNNvwHVSSRweChYXcPbfW7Vq3lXJlfh0/n4XslB/TKnRokHXSN67SwhhSGOW3aeOXXQA4cRy0RpxZn6ahUmIOfwwH4G1+6Fb3Bk5GoylrWCyl0qdHZPZSh3NDTa3Qwynt710x+eOQd7rbr3b6gr4t/gzXe0Rqxa6dTMvpfRbw0SNdRKWkuJDsRHXxJeWK//00+9BNinKiAF4Aiap8ua2WtO4cJcWqlvrkwsPSv2J0fFwO5+m7UIhYG9brLYijSk7cLgdxa4T2t7T9v+q09RZhO5XP0sUI7VrH+3Lxxchi65LyOlpQHKLeS4RtvvedsW0j8cRmTgWORQlDDsXqLNkcUER5adV14rG8wctnaVS41ipSgrHK1/QJbLvrGUBocxLje59CDDzhiX5Gr8/3x/RTsK9HxcUQH17T5vV8VP5T44zIlVmYp7HM5r+DtgBMwD+/Qaj1M0t+2abM2caTrOwKhKzFnwmwG189h6GJrDayeSfYYc2IQbu4w41wQuDwL92YaaoaYFdfxOs+9ohzfRcOtg+x0trya2sfYebDTArAq4L3zWsG3bkC0HEVtSXZAXztmnjo2i84pZjrpBnnaKHE3MFSJLn89n+b9fvabdHjpd7KktmaB1vlapxqHNro3TwCeJKIbrm013XXgX2+J/xNAknkkFil1p410lwCrpCRw/+KXkDo+8vjF5KpyKDtSn/MDBinHeehG2PyKifehVcfwKk7s9L7BKqvYYWHw/DO+8gOjG9Wt5wdng4R2cSvJyU51ksIY83wQ5W4Id/lg4av7EhlvFLqpt6YgjOoXS3Ux1XufecRneXM6UYvpLdVBWPwb2nlRoBrFtMiJaMx/P4nVVm8mOqMR6ZgTUEwxvWY+tOhEaeZj0l9/ygP4YIgjvrD9hTfhZqRoMK52F5APQPkL7iI54jgVw5JX6BBAemJ8pYvWZCfkXXVyjTyvrJYAZfbdkytt2mQTRxMOUA16wHr50rIzOJWYhW/hQ/BeBZQtyplG5OG2U1Ixy+6H9L60QFCWqDZQRtrqkmsbd8XQasHSfo50RJWcAnsEfDwhbk0CDL5TmWgK0XdFGJIoFCv1JGGfe4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0h/i83/L0VjNayhH6K/fy1HCtBofiwbHnKmUgPFL2EL0Jedv+6h92X1WkzKkg/NJ2PQ+on9ojHm1hstz6Xt6mZlprvJesEkGsRn6UFNNL3HJCfJ71uKM9awCOFRu4hvEbVpDUPMDGvXmS0qhyz8UVgsM7O1I/es31LMQ31qo9wXIdtLXuopJLgPuZ9ht0vsoSq+b7pQZloQkDYon8nE+bjRcEuIYgXzvYCK3J0ck0d8O3ZXp0e4IXd1jEOuu/X4YxIAAVjG3kjxSs90/DVA4PPOqz35/Q/NJhMjU5XK+snfmh3+l8UySdSgqhSYqvSza/5YdRfZNqsvRJQeV1CFllvKFU7rzv5erFm+mAZcs1kelWraCWFCfPNSB4cVpnVkYFZCUw8hMOAl7wKLdB8UnjkGM040YmugX/cQ3TH9yMbqDtrcTryvmNuCLb0NV/qqbsUkVvdsjSzNYKWov9I034tkoN4SGuJIEn+kdIotuuOqiA62PcocBasRK5W4nhT2g2TQJjg0vNcB/YyrkLhY7jXX8P5kFFl3FOgw4izu3FMsJFvxAKQnVbZfSWSGqNQaNjLiamgiTnq/d1CvRF4il9KJlEz0sZ1K+7wE31KxdJmyE413QLcvoGR0WTr30CYgCcb5avM2lRov1dahwsCyG8bIY3pKfdVhmyNxjoC8Ror/K/0SCUBTV4SwhLn7VmZ5V9IWpNbrwIXoYL8DHSn0v4lV+HvnnsEoCxQrKNf4lS01Era4Nk/81INd6LqqHHPk4kOwxxylKmzUdN4eDG39oqzieG6f943PzNaOQx6xVJ5xPqptEQ91YBX/dfy5nE5ZxUZZ1Uhjjp3SpOjj4OCxrgZnKhdELt/muTYXEXFWSQu+JaV5i+P26KFBcAB3sQN9J8hEznwjERzXgHy8yCWIPxnaDZPXlU0haTeqndjrFu8DBGJwFLQC0wlp6tXa23b49sNKM0TcrwYnO9c9Ih+ep6uqBa6PT74Ic+OPhE91IOU2g3VyJX6WAYErpjFt4TJUs0bNvkOrsc2K+ap0AJsslhx16YboHg+jlrdKrP/UmGyJTo4LFm93pSnv8TpqfqgpIyPyRp3s2kx6M0hiqpo8eUsP/bWt5tnDFX/G+UWNRiEgt6gdDLVc1xJeh2brSAEU7RI40S7KE1myM+brSx9/IoXGGz36WlX/4PxdLBeGfgrcuxeq4upewBYamPuNVls+PUMqnJ5TyPwg4GquNBPw+/wBg+gEvFn0HlFMAv4+tBSDqBESbpxhrJxJ7+ZleU5QJfek4UH7eHqbtJ68e24s7yNmtMKU8qP7FkgFyGkDZfEgk3LyLdLNnedL/pCutCkkUw3C+qow0I2XyeZ3aDm3PLuR0G5qnsKCitih3gp1LtPi5kM5ajvtbtGMXpBvF2uWqcvVc6MjkommoxWBxy65Cnkza6U2Ssdk4QJZQYWeiwa7Wn1s8hD7pPxJLI9OkHzQl3YJbU9DEnsjpNFoeoyfCPDTuW9kTP0X6AlbiWBuiq7Kg1DbdZS2ZDfQC7C8rfIC99/fkJAAiz5CBTvbIUeLu1mFBD7+38XNetSKynC0x1uh0S68jGHfFmqaKslr4rbNG37Avop+BaU+r7egvSOl89fS3QOvGIQTl7j4J2UFwb2940XZ/bI4OgeFBnneSmrEJTQPHhAqG+Te07rq1stvwaw== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 759fZVstsgQO4bbU5HAhDYVXCjQpc++TSQ57yHoMYE2B3ES1p/VJBvS2RC5CfB68BU47lQZ6tYLWwcUMClyPQAmI7MSir7NVfmtwvkO84B15xb3BkcH7wPKl7gBFLiaOGsAwz9v+LOj3PucP4aUU0YbacdaI+ZE0Tb1Sin78CjU4NI/tOGKCwU0OUBsNfoYPRF7jXsz/VS3rTwCE4YhGS417/Bsm5CxkREXldqk/V9PuJHMoMRVvayMJp3H5CAzo3I3FtFb0vPpWyhw4vxCOrOK8316LoTgBFcuI/jq+XOdvqRSfK8FJE9N6/AZefkVqEfpmIg7hKcfEXh4q3wNYxRWzbysyAhDpJyNvci6EAnLc8UbmzMgerceFcGZo9wyd7d0BQxJKGPdM+8oY5QTj0C9xUlLDUqO4I3/1FJIYSCIDlXFc/INpoVGb8fdmNRBn4hIezQp12Fo6vA5zRYtn25EA4SSvV2iY+C3W/m00j7JhKwhZfMbclEgVksp5JTrijFCFrvNiQyNcnp8MmtJWP+fc2KzOfFCCEPOFFaWjG+Vej83Iz1D7gTljAhHlXGaqy5mrl75kZd2KUcBEda2jGt60PokvHfTuH7fZamAmW9k= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bdb58ed-484d-4459-57e8-08dc8c144ecc X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:50:03.0549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kbCLGCcdt6SgUFxBsuW5/aBonHst+2RRh1xYxCvFjEpdkke0R2TypbJQQ/PIAS9EXFX9cUU5vOrt2aMz3APVApq7jnXXVCp2R1nnb5F67M8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140009 X-Proofpoint-ORIG-GUID: YrR4f9b4kiHYI-cSPxl_qtkecrs6KDRh X-Proofpoint-GUID: YrR4f9b4kiHYI-cSPxl_qtkecrs6KDRh From: Dave Chinner commit 15922f5dbf51dad334cde888ce6835d377678dc9 upstream. If a filesystem has a busted stripe alignment configuration on disk (e.g. because broken RAID firmware told mkfs that swidth was smaller than sunit), then the filesystem will refuse to mount due to the stripe validation failing. This failure is triggering during distro upgrades from old kernels lacking this check to newer kernels with this check, and currently the only way to fix it is with offline xfs_db surgery. This runtime validity checking occurs when we read the superblock for the first time and causes the mount to fail immediately. This prevents the rewrite of stripe unit/width via mount options that occurs later in the mount process. Hence there is no way to recover this situation without resorting to offline xfs_db rewrite of the values. However, we parse the mount options long before we read the superblock, and we know if the mount has been asked to re-write the stripe alignment configuration when we are reading the superblock and verifying it for the first time. Hence we can conditionally ignore stripe verification failures if the mount options specified will correct the issue. We validate that the new stripe unit/width are valid before we overwrite the superblock values, so we can ignore the invalid config at verification and fail the mount later if the new values are not valid. This, at least, gives users the chance of correcting the issue after a kernel upgrade without having to resort to xfs-db hacks. Signed-off-by: Dave Chinner Reviewed-by: Christoph Hellwig Reviewed-by: "Darrick J. Wong" Signed-off-by: Chandan Babu R Signed-off-by: Catherine Hoang --- fs/xfs/libxfs/xfs_sb.c | 40 +++++++++++++++++++++++++++++++--------- fs/xfs/libxfs/xfs_sb.h | 5 +++-- 2 files changed, 34 insertions(+), 11 deletions(-) diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c index 571bb2a770ac..59c4804e4d79 100644 --- a/fs/xfs/libxfs/xfs_sb.c +++ b/fs/xfs/libxfs/xfs_sb.c @@ -530,7 +530,8 @@ xfs_validate_sb_common( } if (!xfs_validate_stripe_geometry(mp, XFS_FSB_TO_B(mp, sbp->sb_unit), - XFS_FSB_TO_B(mp, sbp->sb_width), 0, false)) + XFS_FSB_TO_B(mp, sbp->sb_width), 0, + xfs_buf_daddr(bp) == XFS_SB_DADDR, false)) return -EFSCORRUPTED; /* @@ -1319,8 +1320,10 @@ xfs_sb_get_secondary( } /* - * sunit, swidth, sectorsize(optional with 0) should be all in bytes, - * so users won't be confused by values in error messages. + * sunit, swidth, sectorsize(optional with 0) should be all in bytes, so users + * won't be confused by values in error messages. This function returns false + * if the stripe geometry is invalid and the caller is unable to repair the + * stripe configuration later in the mount process. */ bool xfs_validate_stripe_geometry( @@ -1328,20 +1331,21 @@ xfs_validate_stripe_geometry( __s64 sunit, __s64 swidth, int sectorsize, + bool may_repair, bool silent) { if (swidth > INT_MAX) { if (!silent) xfs_notice(mp, "stripe width (%lld) is too large", swidth); - return false; + goto check_override; } if (sunit > swidth) { if (!silent) xfs_notice(mp, "stripe unit (%lld) is larger than the stripe width (%lld)", sunit, swidth); - return false; + goto check_override; } if (sectorsize && (int)sunit % sectorsize) { @@ -1349,21 +1353,21 @@ xfs_validate_stripe_geometry( xfs_notice(mp, "stripe unit (%lld) must be a multiple of the sector size (%d)", sunit, sectorsize); - return false; + goto check_override; } if (sunit && !swidth) { if (!silent) xfs_notice(mp, "invalid stripe unit (%lld) and stripe width of 0", sunit); - return false; + goto check_override; } if (!sunit && swidth) { if (!silent) xfs_notice(mp, "invalid stripe width (%lld) and stripe unit of 0", swidth); - return false; + goto check_override; } if (sunit && (int)swidth % (int)sunit) { @@ -1371,9 +1375,27 @@ xfs_validate_stripe_geometry( xfs_notice(mp, "stripe width (%lld) must be a multiple of the stripe unit (%lld)", swidth, sunit); - return false; + goto check_override; } return true; + +check_override: + if (!may_repair) + return false; + /* + * During mount, mp->m_dalign will not be set unless the sunit mount + * option was set. If it was set, ignore the bad stripe alignment values + * and allow the validation and overwrite later in the mount process to + * attempt to overwrite the bad stripe alignment values with the values + * supplied by mount options. + */ + if (!mp->m_dalign) + return false; + if (!silent) + xfs_notice(mp, +"Will try to correct with specified mount options sunit (%d) and swidth (%d)", + BBTOB(mp->m_dalign), BBTOB(mp->m_swidth)); + return true; } /* diff --git a/fs/xfs/libxfs/xfs_sb.h b/fs/xfs/libxfs/xfs_sb.h index 2e8e8d63d4eb..37b1ed1bc209 100644 --- a/fs/xfs/libxfs/xfs_sb.h +++ b/fs/xfs/libxfs/xfs_sb.h @@ -35,8 +35,9 @@ extern int xfs_sb_get_secondary(struct xfs_mount *mp, struct xfs_trans *tp, xfs_agnumber_t agno, struct xfs_buf **bpp); -extern bool xfs_validate_stripe_geometry(struct xfs_mount *mp, - __s64 sunit, __s64 swidth, int sectorsize, bool silent); +bool xfs_validate_stripe_geometry(struct xfs_mount *mp, + __s64 sunit, __s64 swidth, int sectorsize, bool may_repair, + bool silent); uint8_t xfs_compute_rextslog(xfs_rtbxlen_t rtextents); From patchwork Fri Jun 14 01:49:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Hoang X-Patchwork-Id: 13697712 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30053183094 for ; Fri, 14 Jun 2024 01:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329811; cv=fail; b=ZMRpYmLf0KeN3QeYd7Jh6N794oiE9L/i7a0QjWT3Zl8eyrW7PxQxA6Q5YN7PWr1VXh3cB+rDpRth7HhSW9bvy65npmxrcWxLCrE2rFy8qaSCjAmrkCLLEgm3b/a1Krma0OlrDKqC9NRTs6Sk5vSjJZ7OwlN4N1pHjexwgMYAOlg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329811; c=relaxed/simple; bh=3/Whu5djeSVVuU2sxYhU5fUwPh7ZdzfRED4VPPG62PU=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=jzbcZIQb6YUR1AzIK0LNOfaT5QQ6fS19ygXLFoMAebE7aOlJX5wZk9Gu/MK4MDM1JNvNmYa42trWzbsA9figXiQE881LQh0NI6uwlQw2/egfxznE7xjisIYUnd5jyix1QniJmtWupiMlm73CMiqTO3W2kVKj9jY/GWhnfYUydD8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=oDNoZYuX; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=r7/uC72U; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="oDNoZYuX"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="r7/uC72U" Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1fpDq029945 for ; Fri, 14 Jun 2024 01:50:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=5xgls130spLE51iyGYJRg6WubAZle7LHF/OhLQev2R8=; b= oDNoZYuXefwcnS4S7YrePPql0prhwTUcazUgSAx1AbaAhWK1sgNcajgQZEM7uJM+ shMAHs8B1cgxaGD/VMeUpSO8Y/oQqNPFveuZ4kH0EXHAsd49OlGJSXUlWQ8Pa8Fe I4gb2HKl4l4wosybt/t9vejb6LAIWk90Dy28qgFNZsZNWg7YPdOubNr7QIGf3m0+ Bqctv+Ev/3Juo0PoNCeTX4c0OLc5lsPcroyPHydXU0R0xsq825NLkG+n24fwHojb D2hll2s2kJnZTgeWUbIp/foGV9MKBkjCzIQQ6LYKnBzu9qBSbegfqJd3XimERdKE RhWn1XEfdE1Mkuym0eNC+g== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymh3pangp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:08 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45DNDhaE012526 for ; Fri, 14 Jun 2024 01:50:08 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ynca1uw1k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7X04BBSw7TQ6zM16NJNHeAYqZ+xHBSwQeQ1sWMuIFTqFzsFC90dMiB0iBHqerJiHA2K97ovSvN9W+Pt7qmyhyfOwD5+nrtOe7edIF8FqgNCgOKsz8Pd1AC9+H551pPEivqHrd5PYI7pM70cH7gfVsvZtLaNmbTx+lYsmP+VFFcu8GGKp1cnMxwlrwvozipBtz5s/PDIeaxrGI+9ToUmLUDJ8mr6VeuCC+wTv1BjuPAo7Q02Jinr6gvAAyI4kSGHIyn36IfJAe6DVQOwdxkmNmoTeLUOkgYiweqH0knjtxl6MeMAVAJVSg1MJsiTKmgi+pHP1KrMhiaQAaP3LAM7SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5xgls130spLE51iyGYJRg6WubAZle7LHF/OhLQev2R8=; b=hzjQhQ4MM84foL5JuF5qr7vSsjcjABSUtQG0DLdKHWlpFpC18IjjF/hPdPZ++u5nGnJqmaHPnplcbLOUTYxV980i7YXwIg/MdDTfLdJM40+zWrEVdw+9KKfSwL258Bl6d4aSaAxRE1IvO1QnnvH+pa0R2O7luR3uyxH/wHoRjMzuW1e0oKGGNhK0UN7E/wyy0USmgKMOWQ+Odk69GCYIkXJaPUkd5PDTsd5OKDYAEGKYfA2fRzMWDpgkW6ZfV8n1R+Vst0pJkvF6wsjNT1V9v1T525iuxmQ8VI9xzvRf2DJzvLDHpMu9n09vmeBTa4jrfmVO9g3NCIZ3vF3eTQDRIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5xgls130spLE51iyGYJRg6WubAZle7LHF/OhLQev2R8=; b=r7/uC72UMNVlNm8uIakxl3lkLL2kqosszoB5UWodA9LQC9VW1ify2M4cnZ9/hiFtFJWkJo9WpSuvnleU3v6AUOTvip/ZVLGQ4nsyYfkXPFgHMeRvFfNkSgN/FOjsaImLJkVmzIIy+JcCv9PZ19WOL6JnS6K8qy6TxUsbj3qf/EY= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB7475.namprd10.prod.outlook.com (2603:10b6:8:187::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 01:50:05 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 01:50:05 +0000 From: Catherine Hoang To: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 CANDIDATE 7/8] xfs: don't use current->journal_info Date: Thu, 13 Jun 2024 18:49:45 -0700 Message-Id: <20240614014946.43237-8-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20240614014946.43237-1-catherine.hoang@oracle.com> References: <20240614014946.43237-1-catherine.hoang@oracle.com> X-ClientProxiedBy: SJ0PR13CA0010.namprd13.prod.outlook.com (2603:10b6:a03:2c0::15) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: 3612999f-d5db-4132-cbed-08dc8c145009 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: 1n54AWagXwT6iubCERFehI43G5OakHea2NqovXzxn3OyYRJ/017mrp4GJ0ubdcd73JQ4eoH+9bjkRBz8Fw/qFna2EaLBCnJqnbCzixHitn4meUyxeIJPKv9BQgRi9sxpjL4JWHhxjg9+ivgxw6se2bfNNVaZLBdxVXi7aeQk2mebGTXpvs/XkM2RGyYRCGb99InjgnHvTe8ulvNgAwWRIj6iZ8lgeqf7MjPO1i709dlpurf9vnFyXBKJtkx77U0Hhv1ndb9tJg3jB/3bIc04a/avLB0hpKrNQ0aTrDrk2Q4L2V8MdzoA+4IVCJp9brT67gz0sDfzpNWsquI/P9JKtx+1W3qChHrtzpnDMUhwjijhQeQK9Un70ZnU9+p4gJruHUg5bQh64JEEhbnFcZrJ/bE3uIhMJdZrpA7jF/tnt5MBj3aQq6rW35zeG0XlfQrHZQjRd0BhBVOxkUTr3NrTiV5D+g9r5EUcxwEgxUwYklp2H90cfZb0pTXC2fZXuDROLIZt9lUhC8Y2C446iAQYx41xtWiraqdxZ+GuQd7ZMGzibSLi80xsxrpYeS45cYT4ldCFwqRK0Kwux4/D6cUINAeBxaQ0kyu8s081EtQqhKWgzUJZuJXxwFfcgMKt9ceGXSydXQA557ewaVcBPPb5ygjbhNQJi4HHEFPh2wQPJ9/R9vt9UbFtrTbEEx841tCeRViWofRQMRytSL5e0WpciRMKoO376yJD/F58VNxA1wOLnbhLyBnmX8RqNhMUW69sDbW/znKIOlIEgCjm7zCKyXGW/ApvlwNnPms5/T3OSsQYTyv1SaoW2whFQ8KV+jGIfgK3bGPUOGb6Y9O1KF68jUZwFu+hahjiQsjO1pkTkAvq0Eh25HCc3SXMLkE/z6ZVQq6RqZ0dKo3ZaDChrbUNike9IQrcb6dTaVHqH3II8lr2/13FvR9gASRcyc9Gzzw99CL1CcOOVtYOplnS1DkYxUriT343QNMCseAfgsGQ35eacLJv3zcgcQTw8wztwx4HKC0k65b0OhDV9R0BBoZrfnvsJ41Ip8CHMfoGAX2wOAYjBJ4YBSOGG/chBrpIr38FYU1kArbUdWsQ8GsuxgfO8VhqXTCHGjwphWYmkMdPlY3bEBmRBMdcCoexMMDGrxrcXS5ae+XuBGxR+H5WYWApN57lM7nATsvfg0+MuP4N4Eyp8klqf7SfO8JqzeffVOCoxjD4l5lyqapD2cdrXxJ9GILQU9tOiUarNsppi7Y/6LpNAFutVn7ds2cKNRnd+CGYi+k9mghSGsuEdl8R0vdBLpsh2pUI8wTDnL4Rjy3murA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 0IGfptyGhOiM/104lzRxaLnqQ2shngQlceZDhL0+Iz5MrYbi1bIPgD5K+pJfTE6SypvtEONbCTq+IDBDsopoC9LSAMOMUxDz6fVm/giIHCUp0x689Z1/2OfSDjQx49Bz1tThGWreDZqDrlAAATVfJ6qJPbXWxEqyGRDfJOhk+rnbrIRgw1Cr3KwaMxgLbh2ya/fCCrDmqVHYAMCoIJ1iMkQ7Xfstqk7yRau2ZxH2ue6sbO6HXnMGZfchGyfj/NuCfXNE+USPMi3iTHIwfueOygC7YDzxXnBNlV+MzMgjG38thWon/FETuH6+T9Mzlpvk6hzYzYmH3YtAaR/UcDAXh0U7YJl52X/U65/cukix5mxUIUnC5q5a4keMlHvulWZL1dzZdMc+CGPwONPNYSRhiK7uBrsCe+bTt15x5uHBJyaJ9eiVAnjLPxep2Bmq3DQe7AVcOTEhLGw9eyDTsJ+nok7G5sJ88+O4pzxZoq9RKdCrtkT0OdyueSW8j2U4seH9w91tWOZEZjCbCxVGBOOdbzyCWCaZBcMk+NLamQE2KESjER6CUoYags0W4uR76HUYxYFApOetx5B461l8WOCY+v2oYH5c3qfvwiy8NmLs3EwAYHjX6ra3I9UWNJpW6BOcNxg1dRc9VVKAsLnuPmAiic6ejNcu68LEA8GwYi96walBdaS7zatcwoyv92m79DUOcXdJyHFOd+24aEcaDM0kL5XNINBwgpq/BmW9pWp/Ublye2FKlugq2RvVm832syosV9dl+ZbfiBsUCfWLCaHaH5Z/ClXofYwA6Wy4PN6N8Mnu3suiPJejROZ+yxXUWRTtou73pMdPWmEnOfoZdOQri5EQVOlbvg39tVsi9W75ZaPz2c7aIQ+jzNQ828czc55MgF8Bqrji8VOxuLdss+dVvZvKIPNW2QyoUo0HnVgXw9iM7MMO4B3qWpUOnge00uyhTby+B0r2Hf2AT2tc+Mm6a/lLfvoqaKivVNcRD0boajC3Oeoijy0F9FvOzUgnMQSK25qeQaQQ+DRj+gWYrmjB4h4x/83xkEVVLOaUiQ5QINnz9j5LG6StDAEfgifwObF4cKRwZocKcJesuSIPRIWEFmfGV7iPlrAIii2H7/mF/hjEfAbtw70PTFbw8ZPidiJC/GL4AOoLCFKjAlBNbLLOEPOJGbTZkieOkOTDOHpa96Yyvm1EwsuclE3TeMufg02K6n/z+2vDyTIqRBV2H33PHuIYHCmYLoncAF4zt0V+2pgOnmVYvDkCqX0E8P9lZPiU7v38/XTmZFY+ZpFQbSctUGj+h1fwwoOEhvhMI9ydyhj3CGZU4jfqn4e304xkWpllQjJuEVUYvKgVSCDRfdDSQ+TnJB2/ZS8FFMZYZy307sLjC9E+drisPWJN2uYypQvF+N8HiBMoVMP+80C1qtsAhxJE+aI+BstlDKvOUs5pgSMrBQLh482DqKi1iMe7ekguSCQWJMWaDbM0yntvCdJyRjuTJN6GdpYYrlICPsG5XbFnMAC7EPZVnbS0qCAAT1ktwdY/ZnDtyPzYGNxN+/ZRIMZ/UY/9Ypm0RT3vCDhPUsF2+gGrAwglCPH2tE7qEy8gPPf58/3Z1bPdUw9lhJs1l/nNrmbhUn2Iz3OjQrXblNtmZo2LBROZi69pdGEImmJH6TEQhw8WEXOVH1BeVsOdwQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iorQs06CI7RJ0FEml+oZus1PzR2gLnYrarw1QDAgvZ73yPK2aIxLggQHZTGXVkNyDsmfKDArzqXwNXBD2hY7zkTjfplQojgB4Lhyzw+G/UPw5cAg26W2mdIu4TtEDlwKcQJ3sX3VW1jrhvmVMz6fwR1HG+q/ux4CylFZj8lpFCYCp1ziu4+y8B3QfZM6Pcz65h8fRvkTwSb2906hMzBVAtaxDiB389+f7CNFA/t9lTcC7flu9P2/8bPRvtBytqG8WNjYVPhQnrt5LgM2cf8K4z/lWaICMviQHiDF/JBdk6/zYFWtfiMBziYPJaNcKXyPaEPANkwNIUXHHpajbWDcDWO2Bi9bypMgTWnM3/d2kPk8RiZ6XA4upRMJmtvc6BjwmU2GnKV5PFX8c5djwW4BzAiZwOy6z9SfT7DTIlXDVdbL22Z3N9mut+dK2bJ1HMnYTiV0lQAB9Z8ytpInvrW+W5kutVbRfslgFiLkYsAZI0GRCr5+EjO9gRhVUqOioPY4vjh8hMjQoV9Po6o0Bjp/Y2QChYToKdYU+ceSKqi1Bg8cNrI2C1etbJV5Nhbs0JVTSq/ioF1ktsWvvpoG63qGHMcyD70xIGl8Q2Ut3pKFHPo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3612999f-d5db-4132-cbed-08dc8c145009 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:50:05.1552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EDsm7IdyN/iuxhaq016m1+rznyTd0NCYHGp8l+61NqFdw4YFPHsMwy/FdZBqP2ASpJ5RM/AHsCpGyycLP4miDZg6dtUSOcx8fGEoJC2fCYs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140009 X-Proofpoint-GUID: JmPaoyfbcNQMAeWFTaPlAur_rGGnlLhl X-Proofpoint-ORIG-GUID: JmPaoyfbcNQMAeWFTaPlAur_rGGnlLhl From: Dave Chinner commit f2e812c1522dab847912309b00abcc762dd696da upstream. syzbot reported an ext4 panic during a page fault where found a journal handle when it didn't expect to find one. The structure it tripped over had a value of 'TRAN' in the first entry in the structure, and that indicates it tripped over a struct xfs_trans instead of a jbd2 handle. The reason for this is that the page fault was taken during a copy-out to a user buffer from an xfs bulkstat operation. XFS uses an "empty" transaction context for bulkstat to do automated metadata buffer cleanup, and so the transaction context is valid across the copyout of the bulkstat info into the user buffer. We are using empty transaction contexts like this in XFS to reduce the risk of failing to release objects we reference during the operation, especially during error handling. Hence we really need to ensure that we can take page faults from these contexts without leaving landmines for the code processing the page fault to trip over. However, this same behaviour could happen from any other filesystem that triggers a page fault or any other exception that is handled on-stack from within a task context that has current->journal_info set. Having a page fault from some other filesystem bounce into XFS where we have to run a transaction isn't a bug at all, but the usage of current->journal_info means that this could result corruption of the outer task's journal_info structure. The problem is purely that we now have two different contexts that now think they own current->journal_info. IOWs, no filesystem can allow page faults or on-stack exceptions while current->journal_info is set by the filesystem because the exception processing might use current->journal_info itself. If we end up with nested XFS transactions whilst holding an empty transaction, then it isn't an issue as the outer transaction does not hold a log reservation. If we ignore the current->journal_info usage, then the only problem that might occur is a deadlock if the exception tries to take the same locks the upper context holds. That, however, is not a problem that setting current->journal_info would solve, so it's largely an irrelevant concern here. IOWs, we really only use current->journal_info for a warning check in xfs_vm_writepages() to ensure we aren't doing writeback from a transaction context. Writeback might need to do allocation, so it can need to run transactions itself. Hence it's a debug check to warn us that we've done something silly, and largely it is not all that useful. So let's just remove all the use of current->journal_info in XFS and get rid of all the potential issues from nested contexts where current->journal_info might get misused by another filesystem context. Reported-by: syzbot+cdee56dbcdf0096ef605@syzkaller.appspotmail.com Signed-off-by: Dave Chinner Reviewed-by: "Darrick J. Wong" Reviewed-by: Mark Tinguely Reviewed-by: Christoph Hellwig Signed-off-by: Chandan Babu R Signed-off-by: Catherine Hoang --- fs/xfs/scrub/common.c | 4 +--- fs/xfs/xfs_aops.c | 7 ------- fs/xfs/xfs_icache.c | 8 +++++--- fs/xfs/xfs_trans.h | 9 +-------- 4 files changed, 7 insertions(+), 21 deletions(-) diff --git a/fs/xfs/scrub/common.c b/fs/xfs/scrub/common.c index 23944fcc1a6c..08e292485268 100644 --- a/fs/xfs/scrub/common.c +++ b/fs/xfs/scrub/common.c @@ -978,9 +978,7 @@ xchk_irele( struct xfs_scrub *sc, struct xfs_inode *ip) { - if (current->journal_info != NULL) { - ASSERT(current->journal_info == sc->tp); - + if (sc->tp) { /* * If we are in a transaction, we /cannot/ drop the inode * ourselves, because the VFS will trigger writeback, which diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 465d7630bb21..e74097e58097 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -502,13 +502,6 @@ xfs_vm_writepages( { struct xfs_writepage_ctx wpc = { }; - /* - * Writing back data in a transaction context can result in recursive - * transactions. This is bad, so issue a warning and get out of here. - */ - if (WARN_ON_ONCE(current->journal_info)) - return 0; - xfs_iflags_clear(XFS_I(mapping->host), XFS_ITRUNCATED); return iomap_writepages(mapping, wbc, &wpc.ctx, &xfs_writeback_ops); } diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c index 3c210ac83713..db88f41c94c6 100644 --- a/fs/xfs/xfs_icache.c +++ b/fs/xfs/xfs_icache.c @@ -2031,8 +2031,10 @@ xfs_inodegc_want_queue_work( * - Memory shrinkers queued the inactivation worker and it hasn't finished. * - The queue depth exceeds the maximum allowable percpu backlog. * - * Note: If the current thread is running a transaction, we don't ever want to - * wait for other transactions because that could introduce a deadlock. + * Note: If we are in a NOFS context here (e.g. current thread is running a + * transaction) the we don't want to block here as inodegc progress may require + * filesystem resources we hold to make progress and that could result in a + * deadlock. Hence we skip out of here if we are in a scoped NOFS context. */ static inline bool xfs_inodegc_want_flush_work( @@ -2040,7 +2042,7 @@ xfs_inodegc_want_flush_work( unsigned int items, unsigned int shrinker_hits) { - if (current->journal_info) + if (current->flags & PF_MEMALLOC_NOFS) return false; if (shrinker_hits > 0) diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h index 4e38357237c3..ead65f5f8dc3 100644 --- a/fs/xfs/xfs_trans.h +++ b/fs/xfs/xfs_trans.h @@ -277,19 +277,14 @@ static inline void xfs_trans_set_context( struct xfs_trans *tp) { - ASSERT(current->journal_info == NULL); tp->t_pflags = memalloc_nofs_save(); - current->journal_info = tp; } static inline void xfs_trans_clear_context( struct xfs_trans *tp) { - if (current->journal_info == tp) { - memalloc_nofs_restore(tp->t_pflags); - current->journal_info = NULL; - } + memalloc_nofs_restore(tp->t_pflags); } static inline void @@ -297,10 +292,8 @@ xfs_trans_switch_context( struct xfs_trans *old_tp, struct xfs_trans *new_tp) { - ASSERT(current->journal_info == old_tp); new_tp->t_pflags = old_tp->t_pflags; old_tp->t_pflags = 0; - current->journal_info = new_tp; } #endif /* __XFS_TRANS_H__ */ From patchwork Fri Jun 14 01:49:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Catherine Hoang X-Patchwork-Id: 13697711 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3B64183090 for ; Fri, 14 Jun 2024 01:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329811; cv=fail; b=QvjHSVUmf0v7zH/RrXA2JDAunlMgCOIG23NVzkXdyrDkYvwenPacslzm8gosQrJQrAHSDtYM00eJ4XW0PjCpvC0XXgvS4pYLeh9OKerq+P5VFHWrkf6eAUjKBEM0OlHGGjXTC5YdoR5sA+gdoSkVj/ALBX7uT/CbcEQJ77TLo1Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718329811; c=relaxed/simple; bh=/orzX7XLPrxEoS3qndmy+k+sDZvyVrozlQWNR0pDNMU=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Oa0XEgPZaRMXpupuW3GXy5GgluXHAetptApOFs4XzVovn+rEvY6QQUq8a260jAZURqPde0dL6jOXPVQSGsv9/nPWR3vPpl0aG7EgsRSBoGgecHTsgEdL9TdgKcIDEjH65blQMeLP392bZYghU8DCfauejWhaPIH7bUvluxYxe7E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=iEPc7MJb; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=NTbjXWgU; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="iEPc7MJb"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="NTbjXWgU" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45E1goZs023646 for ; Fri, 14 Jun 2024 01:50:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= from:to:subject:date:message-id:in-reply-to:references :content-transfer-encoding:content-type:mime-version; s= corp-2023-11-20; bh=aikzMMpciFRBSI9in0ivglFdYBjN67UIqzirxX0NUKY=; b= iEPc7MJbTD+KADeBG8fLiWb7TczeeVyJ3DFfh0/gV8b9wIhRRVluPUcSoGtVq27G /bjHlWCrlZc2ZZWo7d4veHBr/IkGy7zI7mYctJHWrtboGdLK3AXkPbr2kfrOlsRN r/EEwYEfnZGUhOA67LpXxmxXQmii9DD7Bf10x3Leg0HNPq7+9z58Dvo13uskAxAw Lsy2KzIBE2mTQQvCu/DOrDnEFXgnusbI/6tDK3pVZskwWymXGnJQNvZd+WTLVLUw YOmK+r/4NBBQm2Mo1ja3ktVH72R2JSwbDtkUuiTfT0nPU4dnv3KvIhuJYzsFKGzJ Yj8jih8HfS0aG5RiXlGWAg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ymh7dtser-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:09 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 45DNDhaF012526 for ; Fri, 14 Jun 2024 01:50:08 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ynca1uw1k-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 14 Jun 2024 01:50:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/Bh4WPk15BkCilZ7sA9b0pN8Z/IW4cuLWUkxhn5G8bZ7nktu1xr7FsG5z/fIb9CXUrvVI4hfhoKJKu1y3B63hf22hm6/mGErLpDMKgRMFeXOghlUreZpiuIFzlexuPoyrqIZKpeZ4j3iQ2/PldBC2Ubuyx0CReItiLzh5poF4j0i4AKvffUHG/r8ehrHBKI4Q8ODanlzpCTd9Ha5FRe0gLYeKFeZDaajYHyPORof8fho85zlg6ZKOqOCjjdk8p9gwU9Q8+UhIaLQ/PXrHm+kYzwzefTcnHSvCiLMlLxL8ji9Ib9sARyeemHs2N6Fy6k1YeySgpHoVPTHdee6RAg+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aikzMMpciFRBSI9in0ivglFdYBjN67UIqzirxX0NUKY=; b=j6vizkR1psb4SApbIlYuDGbkVztxUZD/eZ1b4qKZGYkNPtdiPdHdzQ3fUybqUNVq7OtB7s5rrhM8XG/gxJUgY0boN1aGtv6R36lJSCMRLWNxUhJFd7h6AIy7IVzhk9m5LCsG5ZmxbH5xS2TACc3BYuHkfKl//9zuBIFigyU0T8IvQPUSpDfFl/STpadRrPrCt+sQ0yFQE6RT9AT6zvuOSak+JfrP7mVSAZMRHp5PAHZoFgUbkXJaw/Qw3UzH7VM91r3nQAfEovopJx48ytKp3nUe9xUSm+lPgRV07gcDqTO+LuaiodC6ubCeRN4XT+DwXu/xf8b7YhGeiSPTusogUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aikzMMpciFRBSI9in0ivglFdYBjN67UIqzirxX0NUKY=; b=NTbjXWgUT0+phfoYUsFoE7s59NRI2xNjitNQsRsLJFeDiKj2N+i9xinUn1Jq+D/C6Qv9BLXe+PG2IhyYEutc9dSpO/Adwxky7nuOixhU54aO0Blkkhi/yzZXKK34PIKBKJHiK8bxeMc2HXIEhsVl3tmAg9aDx1OBP2b1q8mdDeU= Received: from BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) by DM4PR10MB7475.namprd10.prod.outlook.com (2603:10b6:8:187::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.20; Fri, 14 Jun 2024 01:50:06 +0000 Received: from BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142]) by BLAPR10MB5316.namprd10.prod.outlook.com ([fe80::a63b:c94b:7ed8:4142%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 01:50:06 +0000 From: Catherine Hoang To: linux-xfs@vger.kernel.org Subject: [PATCH 6.6 CANDIDATE 8/8] xfs: allow cross-linking special files without project quota Date: Thu, 13 Jun 2024 18:49:46 -0700 Message-Id: <20240614014946.43237-9-catherine.hoang@oracle.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <20240614014946.43237-1-catherine.hoang@oracle.com> References: <20240614014946.43237-1-catherine.hoang@oracle.com> X-ClientProxiedBy: SJ0PR03CA0387.namprd03.prod.outlook.com (2603:10b6:a03:3a1::32) To BLAPR10MB5316.namprd10.prod.outlook.com (2603:10b6:208:326::6) Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLAPR10MB5316:EE_|DM4PR10MB7475:EE_ X-MS-Office365-Filtering-Correlation-Id: 55bf3a98-7392-4844-42af-08dc8c1450fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230035|1800799019|366011|376009; X-Microsoft-Antispam-Message-Info: tzA3deZEH0iSGdbisuSShT2ZpDkGwZFmfrC4ikFP1e8A6XaCfh8PnjeADIaw2M/7XjCeWP9+ySqJCyqCR9kCZ3aQhhsToLIwFeYyYFynszlWOHpG7AsVSIlUVlj0RlDkEs2BS5kaAcLdQRN2CdhTNv+w26h8Z539vxCdWq3doXvVhrTWEbms7P8tN6wLo1ZTaHHqWC9SBe9ZmNo5dVtf1yjzquWcJnjHexZpUcCcfU+kWV5TeJ1rAM3d30zqR8WeFlKlQAVvqtDqvih6Cf+cfrRC8yDwHO7KFL0Ykiq505JPExvSC2+DzV9ql3nsnw2shV41JoJla8NmX3aPl2mFfejNgHi/EMoomP6Fp8IysxhKupItD43V0COPg5/DnByU7342XQRuhF9ean0bYzQMrmVqkhiG/5FWMMGdTo7B8af4T/zYuwKPrQqZ6SRx81e8MfZXnuzR1ZVXpT0irfgqmhknbVr5/qc83IkwINYbdUSPdT+kLMwtb1Ws7nZoDV4txmR8hmBny6yINTfhUbyAfIfevcSJlUDmpAiougyhihcroyoK+8uIN64/NMjmRSUh+Wis4GWhSKPZIT6vTTb6aCvm/P3ee2LfnG7bS0iXV+3V/W/e+3yJJvJtTg87rJS7M6xMFvh9vD5ceECBcABYasavGBSJtrNe7D7gZl01A910luV2JwgzRj2wSCLNpR8DOgpnBmyJEeV4WQjP4W33FWs5S0Iout9dNzN79NP30N53y6UV0VY1wPI9KHWNyKMgF022Nw35blvJjrB65VVLgqWOBiofj0AJRTmLFRtC6shxn05s/3IvSqtq7A84/pWmTLYKK98hkWcO0RJlkJBRoOrpJgAiIKVDSwTIMBuek2N0/ubQuVKCb3M32HL/htW8jyHoHUbRJKlMZe1KyPWeC3nTtQUykubckK8WLQeV1n++Fur5wBfKUJTLCmiMZJWPgmYkmjKM4R5iSBx8OuPygjT7OxmxJSB0EBF85DmrzeKxT+bdh02dspwyDgWvBZrwrKK3G87wqjGgNf1cXBX1+1GGcawLCi8zmwZXnx3EROHoeIcQ0hjWqN+bBBB5nMg3TetlIRUTwk5sPt1LgAqdHD3sk5kNPmPK2Uoud19+xO5qET5otz6FWfJf4pdqqyzqBygDBaCiWL6L8yjt9VimiwIe9dOGna21nN7BPSY/mw1JUmlkEzQXb4MM2M7gJALVHJ/2je1qeQdu4rbDswQ8MzV40UiwT8ayfFlTrnfUJQaClN4KhasKhPlQFX2FLgkcP9FiT8GVSu3sx92xAxzeZsva5A8vvZEcJ4R9LtoS3fOkmc8cO6Bwj9JZ6gnjfR48 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5316.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230035)(1800799019)(366011)(376009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nRGEBDblws7gOk13iykfmXgSMtsGuCPJFU/WrUj13kDnxXusx+ZbSz/h0ThV/FjPF+MAvVlMwVyk9GQeMQLkG/Po8kFJweVNZubuO4iuo56ZuacEv3JHxs40Pp4YHkS2CpRHrDSMO8GhpuBX/4GpR5cPVceqS3u3xCOy0fBdaF6jqvlJJT6pjNsCfPlQTXcAOIu2R8QJD8mggISeRhB2pzo7yhWOQg7f/A2n6mcdOAZqMx2xm5IZMjIqTrn6/BU9EIg3Bjgel2UVwgc0ZUwh1YkyPY4UlAbmjtklOXw4QHMh96IEyLXICknzjWZmWGP4M0BfeiB68fGx2iOMSnuedkDESXfIvq8CFdUKMjkFUNOqqAbKHHrXjbKm6aJ8SAVmHNZUHisaDyg18NbjDdSzJsNNjOwszKvqdHSTw/+uGQpyqK96IAU7TGoMClfMja+N2er8W5HNbwpI++FtP1UPoiNeKPqji5BQSlc5dTA2LeJfqAJchOoecH9RajQiLSkM+W4TdCKkeBalJW+hUvFsrk+LCI9uawBsAb5oXyObBFoDCA4peZG1B6uzCGJ5oXf9iDeG6Dhu2PqSBG3r21Hf5dNbhgV/AqvcjwieWPvuMxgmj8KAlv3X0ztLOR6Aom7xZVBVpVbgpSLYDO36aJW7Mm1Nz5xIfKr5GPz/Wbo7U2KTsriHLp/8Aiwk597MwvgRSzBsLps9Wn4j3V2yus+XU09zogVumEVSsMsPGQ8PIT3tv9MsaenCY/IOlylLxNT6qanJjOHvoGX4/8rDYnemp766nYh/fEs+u2rObqwWlwQxnE/N5MebDLCSUzHjWWi8DSMRnGpCEpFRvxzaHOcjd7uUlID0lm1l/Scbjm/XLvnc9zHW6B52sTXwxzNduZa5N0FoRX613CvjX4gRjT8V8C5E3/vzGXFb8TXYxGa3kjRnGyCYpg1CaHTQN5V4eVPfY1Xttjfab6mYHgCBOCF/MSFD4y1Na1Z6ByrSiizQNYWD4CLJaHMKQ/24Smik0Qf+tTFmvcadPWwiQO4bvy/7IUYdXGRnWMWd6Jl3hhZ5S7DhJLFk31tYs61CiekQozKff2xURfTFMyg8hflCRXDwcbxtY0Qx6auo9f4UMO7mBuVjRRBElzReFr50gXuQtE3SzAfnfZ3otcbNdd5fBnZhb3qx/H13lIApXm95M9PTZxF/5q7OL+wMi+50jPEZgjfZm9GlNHCdT06Nsz8+m7dijl7mIPQFm566x2ru2x7qQTMt4L/gFU3rG0S3PhDdI28wUzCYHb6IJD8n39phWH95efsHQGbFjtkHSnL2rHjrJZ64LQwe5pK/wfyHO3Ffwept6H5IJG4Hv2Ao8PbXp/33MReC9V9CRqacoOP5bQ9OYDypoMFPzDsPmQdLIhKZlcuTZwWyjS+CmON01UbvBwbEhMUgJEZOxa2/NVx3cdbK/qjgt/CH3czjlaczbP2xb6afbycA2KcWvL3R7YspioygSuq9WJHrXBYl6fP2M8tZLKiNUXrmGugzaXyy4LGl/hwn36SINOhPS4ENRzA7j3EQ0D78hLftXwQ0MdaJGl1wp/b3vH+wl1kt6U1VtOTWmt2kGvB/FBRKM+Vv4CWI2Au390tU7lXCLg8GcBpbFKCvVOdKMcI12nrrrfLaVCrUnhkTwrZDZ5jDJMkjEQ7+VmfdjA== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IDWKOY1/0rpt6C4NFk+HdFdPw683K7E2D0q0rKqb6+lXiOo9+EuQR5UNR1ZLtypGoimC8hN0YpsLctXIyWVSgCF9zbRW+dBCezYP633afUzh/9KKZ9l4zB6DKhl/spD5thS+dx+gkP1ox1nHtMksYy23mZm3J4/8VW/rKujSMpFwepYnuLobJeb+QlizaKw9WXFoxe6VKJLIUWdo0TT7ZGnsBa+cTP1QClVW/e6x6K0Nn6Dcrz/zdHf6O8V5xiyFlc+Jp80KjAO6Ws++LoRKri4GAdux7PAO0N/g3fcs6y8QzISjnsfsNOHJwNIpO2AqcM9KbCB8QCXSv/q/rNe5dTbZMAc+qY2Mzp8PxCaKF41ATlLcG/hDkiARSW1tCK44WU8z6PJ8vear7HM8RznG3F6paoZ+Qfl2vDfMEWdRemCuynQBhQH0lQwS7KHx1MHc5VylzZuB9uJDqeKbaAVKpd4owR78e38rSBwj4rTY/ET6iw8DWz0zvdLGBZRDU56liUOaXkpWxVAD9MCibUXNnsTnDaccNm3+mgxrvMKRduZTnUzc1bd9NBXDjFSkpWhxhpdA67g4xEbDQzriW955sLKxZw2wLxnVXqwWcoVCJI8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55bf3a98-7392-4844-42af-08dc8c1450fb X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5316.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 01:50:06.7119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XbK4B5GdQcb3fZPrPi1CJMQ0Zn8KonSl6cEX12S25IrZvEEmd/oB18WVodOF2DJDTkHRON1gr6HfEHCz3d1rXpPIHv+WniPol2lXQkoD5cc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7475 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-13_15,2024-06-13_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406140009 X-Proofpoint-GUID: UChlaab6HWW7jCqasiESVForSEKwp-Fh X-Proofpoint-ORIG-GUID: UChlaab6HWW7jCqasiESVForSEKwp-Fh From: Andrey Albershteyn commit e23d7e82b707d1d0a627e334fb46370e4f772c11 upstream. There's an issue that if special files is created before quota project is enabled, then it's not possible to link this file. This works fine for normal files. This happens because xfs_quota skips special files (no ioctls to set necessary flags). The check for having the same project ID for source and destination then fails as source file doesn't have any ID. mkfs.xfs -f /dev/sda mount -o prjquota /dev/sda /mnt/test mkdir /mnt/test/foo mkfifo /mnt/test/foo/fifo1 xfs_quota -xc "project -sp /mnt/test/foo 9" /mnt/test > Setting up project 9 (path /mnt/test/foo)... > xfs_quota: skipping special file /mnt/test/foo/fifo1 > Processed 1 (/etc/projects and cmdline) paths for project 9 with recursion depth infinite (-1). ln /mnt/test/foo/fifo1 /mnt/test/foo/fifo1_link > ln: failed to create hard link '/mnt/test/testdir/fifo1_link' => '/mnt/test/testdir/fifo1': Invalid cross-device link mkfifo /mnt/test/foo/fifo2 ln /mnt/test/foo/fifo2 /mnt/test/foo/fifo2_link Fix this by allowing linking of special files to the project quota if special files doesn't have any ID set (ID = 0). Signed-off-by: Andrey Albershteyn Reviewed-by: "Darrick J. Wong" Signed-off-by: Chandan Babu R Signed-off-by: Catherine Hoang --- fs/xfs/xfs_inode.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index f9d29acd72b9..efb6b8f35617 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -1239,8 +1239,19 @@ xfs_link( */ if (unlikely((tdp->i_diflags & XFS_DIFLAG_PROJINHERIT) && tdp->i_projid != sip->i_projid)) { - error = -EXDEV; - goto error_return; + /* + * Project quota setup skips special files which can + * leave inodes in a PROJINHERIT directory without a + * project ID set. We need to allow links to be made + * to these "project-less" inodes because userspace + * expects them to succeed after project ID setup, + * but everything else should be rejected. + */ + if (!special_file(VFS_I(sip)->i_mode) || + sip->i_projid != 0) { + error = -EXDEV; + goto error_return; + } } if (!resblks) {