From patchwork Fri Jun 14 16:00:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13698923 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4C215F41D for ; Fri, 14 Jun 2024 16:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381236; cv=none; b=pp0M/wTNWVw8l5SqRbHad6j7O4lOEyZqF/7t5W4/ZNJR4svAlohXiLso0xa3QSiErFpEmeWzVB6NTPt3TzdvKV79SwmePMetp+PBM5bdHeumbOBMFQSR0BE/A3uvCwN/FBNjQx3Kqoyb0bj/tA7fQiw2dhg3lHru0hBag8YCsLQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381236; c=relaxed/simple; bh=cegaVVSne7+vtUTFtDiscA8vJJUMFLEvP8aDaQ9mGII=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lDpzi7CbM0Qca1AUE39u2uzCOtsi+y7uP4QjT60fZnqb3FsiEcyI0QHyAEucMlxQU11hEMT2/6+U8hXoKlrD2gshKsbUF/qAKygscCeaoKwIV111LAHghwbV5AZvNONVJQyLlDPhPwVBjLFNahTNkhoDIaNdqvUhWz1FQ8WuaXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eePqvnVu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eePqvnVu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718381233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZomfkoVq0suL2c8mJWdTAIMC632vfRZrJwPBlAjNVJo=; b=eePqvnVufos3xWIjz7YuRSTieBnjb+aNcibgOKJfjYNz9oIGDnJt+a4jyDMpV23Pv5eQ0F xb7Wvp2LmOWIYO0qIZAuac7c8rHG1IOeIyy76eFd4QJrYJJVGavpy+mmR5YdaPlUt6lN/H BA150Z/1Y7KXZ3tF+/Rgt5jsZHKnxQE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-M2k544CfPVGk_Xqg2PI7yw-1; Fri, 14 Jun 2024 12:07:10 -0400 X-MC-Unique: M2k544CfPVGk_Xqg2PI7yw-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 31968195608B; Fri, 14 Jun 2024 16:07:09 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A39511955E74; Fri, 14 Jun 2024 16:07:07 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell , Christoph Hellwig , "Darrick J . Wong" Subject: [PATCH v3 1/4] mkfs.xfs: avoid potential overflowing expression in xfs_mkfs.c Date: Fri, 14 Jun 2024 11:00:13 -0500 Message-ID: <20240614160643.1879156-2-bodonnel@redhat.com> In-Reply-To: <20240614160643.1879156-1-bodonnel@redhat.com> References: <20240614160643.1879156-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Cast max_tx_bytes to uint64_t to avoid overflowing expression in calc_concurrency_logblocks(). Coverity-id: 1596603 Signed-off-by: Bill O'Donnell Reviewed-by: Christoph Hellwig Reviewed-by: Darrick J. Wong --- mkfs/xfs_mkfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index f4a9bf20..2f801dd4 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -3678,7 +3678,7 @@ calc_concurrency_logblocks( * without blocking for space. Increase the figure by 50% so that * background threads can also run. */ - log_bytes = max_tx_bytes * 3 * cli->log_concurrency / 2; + log_bytes = (uint64_t)max_tx_bytes * 3 * cli->log_concurrency / 2; new_logblocks = min(XFS_MAX_LOG_BYTES >> cfg->blocklog, log_bytes >> cfg->blocklog); From patchwork Fri Jun 14 16:00:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13698924 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6B7C15FA73 for ; Fri, 14 Jun 2024 16:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381236; cv=none; b=MlttqHzuq7QtLLPo1tdlDmb80gBARLdk6TERntwFVX7PBqiBlEr5aWK0gYdHSdnKlWqqZ+Fi0jwC+cJpGUvwV8Z46lx2lkZoAKZv7oK8+diOEPoB2Sf5t00WRhKh49BPv3eIEM8X42Gd6x+N7GD8erT1v2IR3jjVdgB1eNQKf/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381236; c=relaxed/simple; bh=XYMuT9GJrVKXvr/NqfPnXmIHzJIajSiZCb3ATD8A59E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JhhRLrMuWODKGrn+FZJBajriMmJemuQ5VQbd3qk4NZ+gdMA6FPV14DfyypR+gT5wy/bV6jsGZifYOqPPCrr9T+OgWtZKO21NaZ9poLIoG+/pbD4lPvcZA2pH0BpsNg8UyLI5MqKrMuPn3B4EokdrL6wkTUGns4xJcDKKNLb87+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=a2Lzmmv3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a2Lzmmv3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718381234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aUlYbVOQDqfN6smUHD74NPUgX6Wbz3CUTP7zc3W/Xn0=; b=a2Lzmmv3gAz6Cmb6+DH5AAO7N53kg42VlUN8PbvSEdRIsk/JXsmSA+C7UO2G6m8JyXmSzk Uqxyei2ParuAD7XiSwdWc8Lkk7UiasYC2LdTvrWAKNztNKdlaWZIAhgFRVdJxuX+pWdXFO 1DKx0Rfmmct9hZ/p6UguFzPfFAKTIN8= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-grIl4KdLPze5o9irBeXRpA-1; Fri, 14 Jun 2024 12:07:12 -0400 X-MC-Unique: grIl4KdLPze5o9irBeXRpA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E654419560B1; Fri, 14 Jun 2024 16:07:10 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 558B319560BF; Fri, 14 Jun 2024 16:07:09 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell , "Darrick J . Wong" , Christoph Hellwig Subject: [PATCH v3 2/4] xfs_db: fix unitialized automatic struct ifake to 0. Date: Fri, 14 Jun 2024 11:00:14 -0500 Message-ID: <20240614160643.1879156-3-bodonnel@redhat.com> In-Reply-To: <20240614160643.1879156-1-bodonnel@redhat.com> References: <20240614160643.1879156-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Ensure automatic struct ifake is properly initialized. Coverity-id: 1596600, 1596597 Signed-off-by: Bill O'Donnell Reviewed-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- db/bmap_inflate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/db/bmap_inflate.c b/db/bmap_inflate.c index 33b0c954..219f9bbf 100644 --- a/db/bmap_inflate.c +++ b/db/bmap_inflate.c @@ -340,7 +340,7 @@ build_new_datafork( const struct xfs_bmbt_irec *irec, xfs_extnum_t nextents) { - struct xbtree_ifakeroot ifake; + struct xbtree_ifakeroot ifake = {}; struct xfs_btree_cur *bmap_cur; int error; @@ -394,7 +394,7 @@ estimate_size( .leaf_slack = 1, .node_slack = 1, }; - struct xbtree_ifakeroot ifake; + struct xbtree_ifakeroot ifake = {}; struct xfs_btree_cur *bmap_cur; int error; From patchwork Fri Jun 14 16:00:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13698925 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7805315FA7C for ; Fri, 14 Jun 2024 16:07:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381236; cv=none; b=mfiTBYpPtGRqEys8ZfcGrRje3POZQ5kLj1R+ODm97vYKl2hO3hKazHCpGkMMIRlhb10xCXFtm+wOW0naUm0ZCYp+9E/2Mvizd0rS8AbMciZMnrJlRp/5zMGZocEU95QVZTQ7PWgkI+PlrOgkcECK7jKOno5mjPGb0SABtwJ4HX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381236; c=relaxed/simple; bh=z/Oa0t/afI9qXk+YYiKVjvK/vguOt1ij2iWhTg4fMT0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BuC31Of5DIl4qUDSSr+l+fRR3QrXLLQ41ZqSV95kZMLncEe1U8sPoGjkpCffdqRUzUon2CYP7VuAPJzXcZhun/3NpRxNv9VFX+/9FcBlo/doAmBn0Dmiy9ocdRhAR+FV7uJ6hEI6PCkh3Cw4WYIX7isJpX1WN+cJ/vCyOfUtWiQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QJP2W9Rh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QJP2W9Rh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718381234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l1ZxR2I94Q4eCiiQ+Tgtohe9AJ6ChZgZQQE4+LgSneo=; b=QJP2W9RhbhSkjfxnzxZepg9yWO5EdQufuRYdYb7EV92Kp3eZUrldR35OhqC53hwiD8KKKK SITBf9fJhShI9RZ+/o0k1qYQisPl3TiEJ24kTCi8eHpM/UWiKRyMUWeZKX63dAb0BDib3I bAW+MxgiZfOfGSTkY0H6yRA6/3qnEEs= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-o8o1w4IGPzePkI8IVi7YNA-1; Fri, 14 Jun 2024 12:07:12 -0400 X-MC-Unique: o8o1w4IGPzePkI8IVi7YNA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 186431977325 for ; Fri, 14 Jun 2024 16:07:12 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1727319560BF; Fri, 14 Jun 2024 16:07:10 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell Subject: [PATCH v3 3/4] xfs_fsr: correct type in fsrprintf() call Date: Fri, 14 Jun 2024 11:00:15 -0500 Message-ID: <20240614160643.1879156-4-bodonnel@redhat.com> In-Reply-To: <20240614160643.1879156-1-bodonnel@redhat.com> References: <20240614160643.1879156-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Use %lld instead of %d for howlong variable. Coverity-id: 1596598 Signed-off-by: Bill O'Donnell Reviewed-by: Christoph Hellwig Reviewed-by: Darrick J. Wong --- fsr/xfs_fsr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c index fdd37756..06cc0552 100644 --- a/fsr/xfs_fsr.c +++ b/fsr/xfs_fsr.c @@ -426,7 +426,8 @@ fsrallfs(char *mtab, time_t howlong, char *leftofffile) fsdesc_t *fsp; struct stat sb, sb2; - fsrprintf("xfs_fsr -m %s -t %d -f %s ...\n", mtab, howlong, leftofffile); + fsrprintf("xfs_fsr -m %s -t %lld -f %s ...\n", mtab, + (long long)howlong, leftofffile); endtime = starttime + howlong; fs = fsbase; From patchwork Fri Jun 14 16:00:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill O'Donnell X-Patchwork-Id: 13698926 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A726D15FA7C for ; Fri, 14 Jun 2024 16:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381241; cv=none; b=JYKX2fi69H865f+K5TzSDHELFfq2E2qpAilAy3njbZGyraLLheiCRlMEwZoJxou7abD68WdM1mPGHnp36k4oFNQIC6Lwry7nCt4hzl+FbnaKv2r+LDWXJAEPxbWptFih59MApUFfT1BiV1IP+AEF/s/MoGAi4FTXM1psWEPAMTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718381241; c=relaxed/simple; bh=KS9sk5Ltsv+8EZ29iGSyuSKwEbpt7VaxwpkHUKIFmtQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Pc2xrMbFsRy/F0Vd0G/48ojGE42tt5YtzkVVbe/h1Fhx01Yxmc4Rfw5LNL+oRxjv+R0Cv/cmlfyHWO5Q9f3eeDnddHUqZPlKcajypL/0E79BJq1qm5TfNwcR+EG779cMNGaK5nEobPCeYHbAl7yBMCPBr1ryDOTowFDLj8TuneA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QOZ6eFA9; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QOZ6eFA9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718381238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9PVRyo3ezgSjZI9Bg5Iq38keITb7PbMizTr25hGog0M=; b=QOZ6eFA9JkEBSSOKxbg2D6Kh2/M1CGPH33iwacioKb9aiJIpeGiQfUpHKYOvm7QC5X7IMQ k7lYXkNbbV680ITp3Pzh6SQGN6Cn2wXNH7s1k8uUGYHQVKpHgH5aj/AvilwVLl+a7iODFs 7lVY92fukbQ5MvS8Xw5H25srQ355fqo= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-MhIbYsedNy6P4zHr-U4Xfw-1; Fri, 14 Jun 2024 12:07:15 -0400 X-MC-Unique: MhIbYsedNy6P4zHr-U4Xfw-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BB475195608B; Fri, 14 Jun 2024 16:07:13 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.34.24]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3A71419560BF; Fri, 14 Jun 2024 16:07:12 +0000 (UTC) From: Bill O'Donnell To: linux-xfs@vger.kernel.org Cc: cmaiolino@redhat.com, Bill O'Donnell , Christoph Hellwig , "Darrick J . Wong" Subject: [PATCH v3 4/4] xfs_repair: correct type of variable global_msgs.interval to time_t Date: Fri, 14 Jun 2024 11:00:16 -0500 Message-ID: <20240614160643.1879156-5-bodonnel@redhat.com> In-Reply-To: <20240614160643.1879156-1-bodonnel@redhat.com> References: <20240614160643.1879156-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Use time_t instead of int for interval field. Coverity-id: 1596599 Signed-off-by: Bill O'Donnell Reviewed-by: Christoph Hellwig Reviewed-by: Darrick J. Wong --- repair/progress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repair/progress.c b/repair/progress.c index 2ce36cef..15455a99 100644 --- a/repair/progress.c +++ b/repair/progress.c @@ -91,7 +91,7 @@ typedef struct msg_block_s { uint64_t *done; uint64_t *total; int count; - int interval; + time_t interval; } msg_block_t; static msg_block_t global_msgs;