From patchwork Thu Jun 20 08:43:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Potin Lai X-Patchwork-Id: 13705002 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85DE6C2BA1A for ; Thu, 20 Jun 2024 08:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Fte78PnOfBiH+sJHP9JZR7QJmPh/4n6xzLMPWhbJ8Gc=; b=MQLZPblsmvjEjX4GhcH0iLBV0q cB86IY4O2UHVZ+T6UEEPixAU3yKupJ6nakUmLUyaHtmlXjuwfCQQ7Bpq0k2F86z+P+odelUs0/P4Z wFSQp9+sAoXuKHZGG58+5moaN4DaQh4I3jV9v2MhznZ35AITKUZf6EC4TEzedEQ4NEiEqU2PF9STu Kin+evMThWp4nG8c1N5NW7siqdAUyGjGRiRkeJ9a2nkpSIgNV7VWd2uWEy4ZDJ4s6TcrhOiO9ELbo uod6cxMDqHORq31L9LnTuY65nONqPPEK8gavF1z7XwMXQYxZiXFlebzpmuijJTXCCDLHGN2LxeYxs LFIMWqfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDQm-00000004EWJ-2tMn; Thu, 20 Jun 2024 08:46:08 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDQa-00000004EPq-0798 for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 08:45:57 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-70436ac8882so545066b3a.2 for ; Thu, 20 Jun 2024 01:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718873155; x=1719477955; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fte78PnOfBiH+sJHP9JZR7QJmPh/4n6xzLMPWhbJ8Gc=; b=GYvfYQwj88h2BmjIkyO42d3jITMMTkbxIYXlSsfk3lHsWNfPvOwV5hxErVQPATBACL 4SZTvG4em9x+3Evdvoni4PMJmwdjzlDYewmCqouoFfy3HbGpzjZJKjEGOGuCvnXrlv/J odJ7MJfc1L3cN7OaqSEQPCv6RUodHUigdWiKELGqLOtcTmZIS9v9iWEm/IMZeflWyLi1 NgfKS0Q/ALffbgswuApEuvPHS8ZNHuew0812DAyT7RHgZaGCHRBWYianO1zGN8QtE/kV 6S/khOzt83rVsobdjXdoARNYcGoKaUQvOgRoeVY7YVC1t6YekYF8eW5KCG77ot+/4/Db p7zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718873155; x=1719477955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fte78PnOfBiH+sJHP9JZR7QJmPh/4n6xzLMPWhbJ8Gc=; b=QVXiqbhRn7xKxH1uNnOIDi4Hl9M4HTQ+yXn1NEVmk51mJL4qzg4SN1240rtE3Maqtf VHmE8vdDlBVWGKt+vt4PbTLvEaxb1t7nqHHRG/gOwDvLHsxgOYQ3nuykeT4rOUozSfrh NcJmQCepc0gCki3C6Mp4UQ99yEl4L1fI7mSb0GNHgk1Mp9msO6VwVViBxb6t3fca+cYK WiMOAv2JriUXzSF3s5Smr8RYXD++gRqzpFv7IKzmXzmJj5zAH21XTVyhKqaxGNJ3+vKA UtiWF0CE9PniaJ3WY0VMuAKk61CacjQVA4aw5jvYmBz/6mP+igcJN991/UyqrPZvsuen wjzg== X-Forwarded-Encrypted: i=1; AJvYcCUXhni688AfsmXKVV76gdCrwtY7lvJfSCq+mg6/Pv8WOVWu8azfdGc23sncRohH3Jmi36bVfBdbzPPPZB5gibGF14762e4l/TuMobdNZ0qFN3BuW4w= X-Gm-Message-State: AOJu0YxamOkDsCBEBl7m7bxoTBFd5WwnOdxuyjSpU71l+F9Rgd4w2mEf Is8p5uyVWRrwqYQvUY4cS2RQ5mquvKtnz4Uuw1kvYc/j47vNBYsI X-Google-Smtp-Source: AGHT+IFxym5JK2ZJ/HsMfJgwaJm993/2O/e1hkkImoYa+PVFsL906eYHSVqcL7DY+taWQyuSWfH3Bw== X-Received: by 2002:a05:6a20:968e:b0:1b8:a13f:3a39 with SMTP id adf61e73a8af0-1bcbb5cb26fmr5082372637.38.1718873154815; Thu, 20 Jun 2024 01:45:54 -0700 (PDT) Received: from localhost.localdomain (61-220-246-151.hinet-ip.hinet.net. [61.220.246.151]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb6b9besm11895592b3a.165.2024.06.20.01.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:45:54 -0700 (PDT) From: Potin Lai To: Andrew Jeffery , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Patrick Williams , Cosmo Chou , Potin Lai , Potin Lai , Krzysztof Kozlowski Subject: [PATCH v3 1/2] dt-bindings: pinctrl: aspeed,ast2600-pinctrl: add NCSI group Date: Thu, 20 Jun 2024 16:43:36 +0800 Message-Id: <20240620084337.3525690-2-potin.lai.pt@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240620084337.3525690-1-potin.lai.pt@gmail.com> References: <20240620084337.3525690-1-potin.lai.pt@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_014556_124723_0C3CD6BC X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the NCSI pin table, the reference clock output pin (RMIIXRCLKO) is not needed on the management controller side. Add NCSI group to distinguish the pin group between RMII and NCSI. - RMII pins: - RMIIXRCLKI - RMIIXRXD0 - RMIIXRXD1 - RMIIXCRSDV - RMIIXRXER - RMIIXRCLKO - RMIIXTXEN - RMIIXTXD0 - RMIIXTXD1 - NCSI pins: - RMIIXRCLKI - RMIIXRXD0 - RMIIXRXD1 - RMIIXCRSDV - RMIIXRXER - RMIIXTXEN - RMIIXTXD0 - RMIIXTXD1 Acked-by: Krzysztof Kozlowski Signed-off-by: Potin Lai --- .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml index 00b6974a5ed3d..3f02dc94a7ce2 100644 --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml @@ -337,6 +337,8 @@ additionalProperties: - MDIO2 - MDIO3 - MDIO4 + - NCSI3 + - NCSI4 - NCTS1 - NCTS2 - NCTS3 From patchwork Thu Jun 20 08:43:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Potin Lai X-Patchwork-Id: 13705001 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19F84C27C79 for ; Thu, 20 Jun 2024 08:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EiJfmKO8nNBSX1oUuFOSypNRXVZPBtzmshynKzoPzUw=; b=hxr1PS56lCUSZ64KbrN3600xC1 cxPO8KgtBC3NxdbhC/gD3UJz/meGweAWNii/Toudug/lOE2XiW3JAiGToL5Ego5IAjvte3boXPDjc HW6cge3TBY4euPCHDsRPIQTu4kafSxseCnTGw40PzUx+jHp9fA7olmOm14QvqGvzTnRaldoD7enX3 sUA68KK0ynaP4FAbjv5EWKW6m4Vmie+7Kti4O99NicK3x+oeKYQalmNnXseUB8uiDU5aqNd1aCVEv Pt14u77miAN2ALNRlzaKg7msJ4h22pwp1wlnq/4mbNW93WcuH9kZyrP6eZ6/x2S0I7idVQdPvFjg0 b+at57dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDQn-00000004EWg-1Rbb; Thu, 20 Jun 2024 08:46:09 +0000 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDQe-00000004ESD-0XOQ for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 08:46:02 +0000 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3d4430b8591so279875b6e.2 for ; Thu, 20 Jun 2024 01:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718873159; x=1719477959; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EiJfmKO8nNBSX1oUuFOSypNRXVZPBtzmshynKzoPzUw=; b=mCPYHRY8tO1X0VMYFzsaoqFOpU0kSwNKuOvDN4GtYIPsmuJqj0Yq91i4Ip/Au03y/W cmTD9nSIYqOc99FaBwZgruGhqlmOTIbgZQ32+4Qh1wUuqaoXLDPPQyy1Ue1yq14Q2ZlG rXaiLuTsC9r+5oq0Bg9WzM5UY1nqPupg1bEpicBOh+4jdO11w2aZRlxAnhIt4XZ2rUYi NQhAbOBZejJFkziensBtU352zImDQhQYZjCnZa6O8fP2pucHNXonW/2eAZ/0koB6eK2N s7N3EFPOhhV8E4P2sLiCRWxIuHGo4uEWFnkesWSGfGTAPDi2oELicUzNS+E7FgO7YPsC AqjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718873159; x=1719477959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EiJfmKO8nNBSX1oUuFOSypNRXVZPBtzmshynKzoPzUw=; b=b/bazOlWmtEHoUD+FF2JsfQHaZ/9LtEhHh5sKaA9M7zlDMtVO6oqgXO2dHdBM/Ha12 P6wD/jJQyq6ceF5XoCJh9NCUjSoFVlDoThUyDPkQYzS1L7SuRz/azfYzku0XGISA6OaV EbSeuznNC3ww4uv5RvMZofaXC//GOcWPX3sLak5X0uwL+FoGkm3LxDdgNBgDiT6T9zNP SwVcT9xxI8bsUkVGZVbcoB4LV3cCbpqtrgrCL9f50WyHYS8QrWCiu/RX22aq2PqpS58F kbQaJHGFuvIP0+/CQxaLSlSr350VbfZFbw3MNzjz3HNEaYk09l5Rncb1A+YzwWiWR2Qx Lj3g== X-Forwarded-Encrypted: i=1; AJvYcCXTv9cxVwaCAxgxyVGqg6IGVWZtJJTQn50KHgvlhArDtjWmqAT5jRO17yfiQoSw7ctLwgmiZfe4YlTcbh0K8SV6Ezno2AobuxBiKtXW+YO1c16AndY= X-Gm-Message-State: AOJu0YyXmaJpx7GprwbL9M2+yZaLL0hGrG5Hmsgd9lDJYIa5FPrUJOpw j09UYmJcaZRtdUOvnphLKeUqEt6MaSGhp2Q/2FJsYKmxiiXg5nHY X-Google-Smtp-Source: AGHT+IGhGDKSgAv0T6Xql5g7csBDAeTCcq8i/P2W7WhnsCqa2jWpcloUNmsMrFYRH/C43jnjpNWvwg== X-Received: by 2002:a05:6808:199c:b0:3d2:1e98:cb04 with SMTP id 5614622812f47-3d51b9824c4mr5393367b6e.7.1718873157886; Thu, 20 Jun 2024 01:45:57 -0700 (PDT) Received: from localhost.localdomain (61-220-246-151.hinet-ip.hinet.net. [61.220.246.151]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb6b9besm11895592b3a.165.2024.06.20.01.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 01:45:57 -0700 (PDT) From: Potin Lai To: Andrew Jeffery , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Patrick Williams , Cosmo Chou , Potin Lai , Potin Lai Subject: [PATCH v3 2/2] pinctrl: aspeed-g6: Add NCSI pin group config Date: Thu, 20 Jun 2024 16:43:37 +0800 Message-Id: <20240620084337.3525690-3-potin.lai.pt@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240620084337.3525690-1-potin.lai.pt@gmail.com> References: <20240620084337.3525690-1-potin.lai.pt@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_014600_318730_27DA651A X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Based on the NCSI pin table (Table 181) in NCSI spec[1], the reference clock output pin (RMIIXRCLKO) is not needed on the management controller side. To optimize pin usage, add new NCSI pin group that excludes RMIIXRCLKO, reducing the number of required pins. LINK: [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.2.0a.pdf Signed-off-by: Potin Lai --- drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c index 7938741136a2c..31e4e0b342a00 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c @@ -249,7 +249,9 @@ PIN_DECL_2(E26, GPIOD3, RGMII3RXD3, RMII3RXER); FUNC_GROUP_DECL(RGMII3, H24, J22, H22, H23, G22, F22, G23, G24, F23, F26, F25, E26); -FUNC_GROUP_DECL(RMII3, H24, J22, H22, H23, G23, F23, F26, F25, E26); +GROUP_DECL(RMII3, H24, J22, H22, H23, G23, F23, F26, F25, E26); +GROUP_DECL(NCSI3, J22, H22, H23, G23, F23, F26, F25, E26); +FUNC_DECL_2(RMII3, RMII3, NCSI3); #define F24 28 SIG_EXPR_LIST_DECL_SESG(F24, NCTS3, NCTS3, SIG_DESC_SET(SCU410, 28)); @@ -355,7 +357,9 @@ FUNC_GROUP_DECL(NRTS4, B24); FUNC_GROUP_DECL(RGMII4, F24, E23, E24, E25, D26, D24, C25, C26, C24, B26, B25, B24); -FUNC_GROUP_DECL(RMII4, F24, E23, E24, E25, C25, C24, B26, B25, B24); +GROUP_DECL(RMII4, F24, E23, E24, E25, C25, C24, B26, B25, B24); +GROUP_DECL(NCSI4, E23, E24, E25, C25, C24, B26, B25, B24); +FUNC_DECL_2(RMII4, RMII4, NCSI4); #define D22 40 SIG_EXPR_LIST_DECL_SESG(D22, SD1CLK, SD1, SIG_DESC_SET(SCU414, 8)); @@ -1976,6 +1980,8 @@ static const struct aspeed_pin_group aspeed_g6_groups[] = { ASPEED_PINCTRL_GROUP(MDIO2), ASPEED_PINCTRL_GROUP(MDIO3), ASPEED_PINCTRL_GROUP(MDIO4), + ASPEED_PINCTRL_GROUP(NCSI3), + ASPEED_PINCTRL_GROUP(NCSI4), ASPEED_PINCTRL_GROUP(NCTS1), ASPEED_PINCTRL_GROUP(NCTS2), ASPEED_PINCTRL_GROUP(NCTS3),