From patchwork Thu Jun 20 11:07:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13705137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11E97C27C79 for ; Thu, 20 Jun 2024 11:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RPBGYY5td1EMcuY3iygqH+AEjM8Wu3wmmgXhFD8MRgE=; b=I1i8hybI3tMERoclpZzSfSAWUc CLhEOoDyraJXo8vnMdUbHJ6vweNxBbnWIFZxD2YDiGxtmGsjcU7QqXe36ROMdRicmGHpuKo/cR/za /5FqATjM5H2lN+cQz66FhmFEvnHiD+63KcLYqg7k1jSbwGiq6Tu3/o6i8CKL4IjNmFuymb53dJCMr PzIIJJ39db8ut/MV8vCYuZ2219/b5PdRJkoMgSSaFNQ5JSfDuFx0p6AOd9UO1+gXsO0BsLd8vhRK7 KSeKT6PDXCkc+ts9olqO80IY9qBDLe9hLSh61nMg6n4I6v2gHZB4IgbIq+0k8TyhFQGgHl1RN7UFl /4Zxyfvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKFeN-00000004ga4-3v8A; Thu, 20 Jun 2024 11:08:19 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKFeB-00000004gV1-3ZpS; Thu, 20 Jun 2024 11:08:10 +0000 Received: from [127.0.1.1] (91-158-144-210.elisa-laajakaista.fi [91.158.144.210]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 492B2BD1; Thu, 20 Jun 2024 13:07:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718881666; bh=dkciKZ2czVyXoXQEJLApgDJKl8vul98p+Hbzt6azbQ4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=es5TNrgx2LsUfmhfaZz42V4tMow5d8gLh3+zEC8HlfV6VkWzmuPe18LRyiZlOU6Oe zblsI6ZkFhQrCC0jnyndVRry96/N3kO/q3mMP2CYUwOpixjLPVBwkt+xGS20ZIt8i6 NxpJnWEYTpjFcsmja2XUdQqA0y9z9ORASD9LKg7c= From: Tomi Valkeinen Date: Thu, 20 Jun 2024 14:07:50 +0300 Subject: [PATCH v2 1/4] media: uapi: Add meta formats for PiSP FE config and stats MIME-Version: 1.0 Message-Id: <20240620-rp1-cfe-v2-1-b8b48fdba3b3@ideasonboard.com> References: <20240620-rp1-cfe-v2-0-b8b48fdba3b3@ideasonboard.com> In-Reply-To: <20240620-rp1-cfe-v2-0-b8b48fdba3b3@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen , 20240531080707.34568-1-jacopo.mondi@ideasonboard.com X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4361; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=dkciKZ2czVyXoXQEJLApgDJKl8vul98p+Hbzt6azbQ4=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBmdA2RN2JyKlA4oCRJH49YI7sOZtb17AVdYbVYK /zA8wEzZ/SJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZnQNkQAKCRD6PaqMvJYe 9XCwD/0dM504PanpR3R4SzT0xiKp0rvstTplyAPyZM5Z890wkDTKrt9B+96oKueUq/B/TZwo9vH qjAZ+xvaN8yseGnOoZo4jGpTck7NtYWlMlT5slg+oWVjM9yALWiLvx00k3SyXXM0KYFerMXnAcV n0yTLVZ6wTjSF32VeUmBSOPIKGhdJNfncvgHtmNbeDXTyhxO38FBq4ZifZjUggMULRVY6AUFPfu Y0lIDDgGzscxkgKJ5gKkPga1xtbttKP1TCXCqqIN0D1GKwhJ7Uip3FZzSi1ZuX9J08cvli1eraV L1K2uqkz4oiHJKmNIg3SnquKO0TB+TQ7/Kr1917ldMy9jem7Sgz7+rhsPxvuMmxkL+V/nb+upap 0AyY5HjYWsBRyeG3D9bI3MC+u9I+beg9Mkq1ng/zJA4bkYTUlQl7tMvyI6d1IiHx1sAMVWfVuAn 55pAdxQnAI1OuPw1YeceOSwccLZNYv4QrALST6ObmT/1VRBjoNWbRNeXTmy3VtBiTltQ0L9mCVU A3Eu7BcMm/aSU14k7hELx2UyhPeRbiSUgx34mE1bxoxZ9Eju+KFJ6/cyscSllFkfYhtSgKEkD55 rDfV4sPIvlfWWW7qwLPewzaZOTvp7Av7fIe8PjZU26OFt4hl6F9E5iJMKQNrIyZekkZRqCZs/MD MqrZh/CjH8ZukjA== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_040808_075709_E819CA23 X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add two meta formats for PiSP FE: V4L2_META_FMT_RPI_FE_CFG and V4L2_META_FMT_RPI_FE_STATS. The former is used to provide configuration for the FE and the latter is used to read the statistics from the FE. Signed-off-by: Tomi Valkeinen --- .../userspace-api/media/v4l/meta-formats.rst | 1 + .../userspace-api/media/v4l/metafmt-pisp-fe.rst | 39 ++++++++++++++++++++++ drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 2 ++ 4 files changed, 44 insertions(+) diff --git a/Documentation/userspace-api/media/v4l/meta-formats.rst b/Documentation/userspace-api/media/v4l/meta-formats.rst index c6e56b5888bc..86ffb3bc8ade 100644 --- a/Documentation/userspace-api/media/v4l/meta-formats.rst +++ b/Documentation/userspace-api/media/v4l/meta-formats.rst @@ -16,6 +16,7 @@ These formats are used for the :ref:`metadata` interface only. metafmt-generic metafmt-intel-ipu3 metafmt-pisp-be + metafmt-pisp-fe metafmt-rkisp1 metafmt-uvc metafmt-vivid diff --git a/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst b/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst new file mode 100644 index 000000000000..fddeada83e4a --- /dev/null +++ b/Documentation/userspace-api/media/v4l/metafmt-pisp-fe.rst @@ -0,0 +1,39 @@ +.. SPDX-License-Identifier: GPL-2.0 + +.. _v4l2-meta-fmt-rpi-fe-cfg: + +************************ +V4L2_META_FMT_RPI_FE_CFG +************************ + +Raspberry Pi PiSP Front End configuration format +================================================ + +The Raspberry Pi PiSP Front End image signal processor is configured by +userspace by providing a buffer of configuration parameters to the +`rp1-cfe-fe-config` output video device node using the +:c:type:`v4l2_meta_format` interface. + +The `Raspberry Pi PiSP technical specification +`_ +provide detailed description of the Front End configuration and programming +model. + +.. _v4l2-meta-fmt-rpi-fe-stats: + +************************** +V4L2_META_FMT_RPI_FE_STATS +************************** + +Raspberry Pi PiSP Front End statistics format +============================================= + +The Raspberry Pi PiSP Front End image signal processor provides statistics data +by writing to a buffer provided via the `rp1-cfe-fe-stats` capture video device +node using the +:c:type:`v4l2_meta_format` interface. + +The `Raspberry Pi PiSP technical specification +`_ +provide detailed description of the Front End configuration and programming +model. diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 5eb4d797d259..95c2c4a97966 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -1466,6 +1466,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) case V4L2_PIX_FMT_Y212: descr = "12-bit YUYV Packed"; break; case V4L2_PIX_FMT_Y216: descr = "16-bit YUYV Packed"; break; case V4L2_META_FMT_RPI_BE_CFG: descr = "RPi PiSP BE Config format"; break; + case V4L2_META_FMT_RPI_FE_CFG: descr = "RPi PiSP FE Config format"; break; + case V4L2_META_FMT_RPI_FE_STATS: descr = "RPi PiSP FE Statistics format"; break; case V4L2_META_FMT_GENERIC_8: descr = "8-bit Generic Metadata"; break; case V4L2_META_FMT_GENERIC_CSI2_10: descr = "8-bit Generic Meta, 10b CSI-2"; break; case V4L2_META_FMT_GENERIC_CSI2_12: descr = "8-bit Generic Meta, 12b CSI-2"; break; diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 4e91362da6da..9f68cd55248f 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -857,6 +857,8 @@ struct v4l2_pix_format { /* Vendor specific - used for RaspberryPi PiSP */ #define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C') /* PiSP BE configuration */ +#define V4L2_META_FMT_RPI_FE_CFG v4l2_fourcc('R', 'P', 'F', 'C') /* PiSP FE configuration */ +#define V4L2_META_FMT_RPI_FE_STATS v4l2_fourcc('R', 'P', 'F', 'S') /* PiSP FE stats */ #ifdef __KERNEL__ /* From patchwork Thu Jun 20 11:07:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13705138 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DC96C2BA1A for ; Thu, 20 Jun 2024 11:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QGJFdskLcxwwe7Brj/Ce3H07ZdvinTGspsDUmSUrz7A=; b=lJaqlwt1lmpfZculw/Y/wsfUD2 16vgDut3HbzZRrWGFNmLgpiDwqYnpYCznqSHi7yyioSKWQhUi69zIxxCqFqKjN0UI8W+CpAwUzbs3 vD25OsNSdg1Bmkimgz8rxfINAxfGYImNfLc8yFcOilj6IEXZqxm4GREnn/fpLGiWEYAHQyr+l9MH9 M8DImwsQGzxmibD1Juu8cQNhdKp11M4hEWVYA+18WvESezD9/v5DIdi6e7qBM7kC+rUoyfi6fdNVY hJm7EM2DGpAzqZ+FFr9P6ktxAkiuOCD96SW7POiA7vid9cHk391fouLJJLMY7baIQiHqR2wUhgLOn tOgwo+1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKFeP-00000004gai-0U9h; Thu, 20 Jun 2024 11:08:21 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKFeC-00000004gVR-16ib; Thu, 20 Jun 2024 11:08:10 +0000 Received: from [127.0.1.1] (91-158-144-210.elisa-laajakaista.fi [91.158.144.210]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DB6ADD9; Thu, 20 Jun 2024 13:07:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718881667; bh=DurrYkPiOJ4QrUXT8rIw5NfkncY5M8gvtRLrv+kHYsc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=SYRDxjCXSbwIi7sZwDhrOs/F1dqoXF6anmefRYD4MYUmWMk8oIuOfMxLp58AgEr33 HoNs6l3HYh5/WoFrCxfVAzOK6wKgAc2mnDyk+MB9Nl+TOQGq0Oq/tZIqpMECfGVUOf qsgNms9ArJS3AsWuG1WRT/w1YR0Se5WESjrqGp0s= From: Tomi Valkeinen Date: Thu, 20 Jun 2024 14:07:51 +0300 Subject: [PATCH v2 2/4] dt-bindings: media: Add bindings for raspberrypi,rp1-cfe MIME-Version: 1.0 Message-Id: <20240620-rp1-cfe-v2-2-b8b48fdba3b3@ideasonboard.com> References: <20240620-rp1-cfe-v2-0-b8b48fdba3b3@ideasonboard.com> In-Reply-To: <20240620-rp1-cfe-v2-0-b8b48fdba3b3@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen , 20240531080707.34568-1-jacopo.mondi@ideasonboard.com X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2962; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=DurrYkPiOJ4QrUXT8rIw5NfkncY5M8gvtRLrv+kHYsc=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBmdA2RAJPAk/x5ycEjDDzhogpO2XLeMFVj7GUvr l4wxnP5OyOJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZnQNkQAKCRD6PaqMvJYe 9fU5D/46l2utzerYrP/0Nbo1hFey+lNZ4Jau94sFP5SL1BctRgECU+e5wwNRZDt+is+3WNLBz8z fhdvgi31UiA13mTAt8HIy67Qm39WEAdKUx5OLghYwwDAvbmqA0b+t1aIlA/MA8VydP2UitV7uWx DhgH5qbg8DA8j0ynromwMEUXyONXWu9FpQV6vrVSDyJGJ0irbvi9nPkByidtTFi6GUA1SU7Yc6+ lEdwOv7miBFdTHXHDO3HqQzFzasnTfuvRdZAoH9fhHyFmPYeCL+t8YMRvUoFJsnBpCrCXSE6cKL JyRM1+sobFGAgtTxC5Iu6T8gnr/oY5rFG++/tTaxozmrcsjaHk+B1xcAeFQ2frlZE5R4tA/HkGB YNw5SNlts/KS9jju3w+FHdgTu5pc8QYRTTMKzQxBckwboelm8uSCtxWc7luVVLeYGOVCOhZ0Sdt 9JOl57x6edd2aF6Kbwi8/d5bbrHymXKXZQBF1R8pXVkM/lsu7jWcitgjuJQOrYmuIfL4VF+mRoR BSo2f53bm9O//4fGZRagArEBx7Z4fI17QWjqfYzTrC31gCIASwTUxEUnn60JHWMviMu7tQ+U67I bPn8T2xHKqJag0v8j878317yqMDEuYbGo2iJhn8oYogZouiyrhP1n+6yBTzb/j0WwzelWuxyZPH TVhEnhSxDdTFqvw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_040808_531859_37D56280 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add DT bindings for raspberrypi,rp1-cfe. Signed-off-by: Tomi Valkeinen Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/raspberrypi,rp1-cfe.yaml | 98 ++++++++++++++++++++++ 1 file changed, 98 insertions(+) diff --git a/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml new file mode 100644 index 000000000000..851533de2305 --- /dev/null +++ b/Documentation/devicetree/bindings/media/raspberrypi,rp1-cfe.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/raspberrypi,rp1-cfe.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Raspberry Pi PiSP Camera Front End + +maintainers: + - Tomi Valkeinen + - Raspberry Pi Kernel Maintenance + +description: | + The Raspberry Pi PiSP Camera Front End is a module in Raspberrypi 5's RP1 I/O + controller, that contains: + - MIPI D-PHY + - MIPI CSI-2 receiver + - Simple image processor (called PiSP Front End, or FE) + + The FE documentation is available at: + https://datasheets.raspberrypi.com/camera/raspberry-pi-image-signal-processor-specification.pdf + + The PHY and CSI-2 receiver part have no public documentation. + +properties: + compatible: + items: + - const: raspberrypi,rp1-cfe + + reg: + items: + - description: CSI-2 registers + - description: D-PHY registers + - description: MIPI CFG (a simple top-level mux) registers + - description: FE registers + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + description: CSI-2 RX Port + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + minItems: 1 + maxItems: 4 + + clock-lanes: + maxItems: 1 + + required: + - clock-lanes + - data-lanes + +required: + - compatible + - reg + - interrupts + - clocks + +additionalProperties: false + +examples: + - | + rp1 { + #address-cells = <2>; + #size-cells = <2>; + + csi@110000 { + compatible = "raspberrypi,rp1-cfe"; + reg = <0xc0 0x40110000 0x0 0x100>, + <0xc0 0x40114000 0x0 0x100>, + <0xc0 0x40120000 0x0 0x100>, + <0xc0 0x40124000 0x0 0x1000>; + + interrupts = <42>; + + clocks = <&rp1_clocks>; + + port { + csi_ep: endpoint { + remote-endpoint = <&cam_endpoint>; + clock-lanes = <0>; + data-lanes = <1 2>; + }; + }; + }; + }; From patchwork Thu Jun 20 11:07:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 13705139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED81CC27C79 for ; Thu, 20 Jun 2024 11:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QaRASgZMKH9Xfo/wEZzz2Ms1/rYASDj6yWkC9yDiBWQ=; b=tFZ3KhKI2p2mgmtFSr6S74CM+i 8mR5zWGxEsooidDiUelwDxIcdZNKOwCj8V5yTSfhMBCXvoRBxafY7d4sG+QequBR8d6uPKy8XwdOJ DyZrjosoUt1I+ngjwJnKdxvgZJYk33tfKdf8a2e9O5wHrl+QN1tTOK98EKPcktIs2SbrONEtHQy1k gVg3ndYnFaiWtpqx5t4h2soeAl8cdfsO99cI+yhf24k2twBfcQ58CCUy9QY0D1DFb9yFwzcfYRDKH kqyyScX5rQB4saaUsHYWCqVTlffariI+QL+WRca55XnHR5c8djNYaRCRhLIfCABxiGIlZw4HPnHSy vLhJCP6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKFeh-00000004glK-2mId; Thu, 20 Jun 2024 11:08:39 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKFeE-00000004gWT-2oAN; Thu, 20 Jun 2024 11:08:14 +0000 Received: from [127.0.1.1] (91-158-144-210.elisa-laajakaista.fi [91.158.144.210]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A382F1440; Thu, 20 Jun 2024 13:07:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718881670; bh=hkNlI+sgdGQzSZGPKmgnDdL4kzR0qMFhYbi4GF2MhhA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=rNGWKIWVj+WZjUGyHSSfIhd/vSJ9Pi6oM0cfDcXLwo9oHnrO+/5d8D5esn+xWeBDJ 7I/EPFUCg96RwOS2N2JkXJAQ+Kg1V3as2dQscVDODR+A6oIqzqCl+8PvTHpqgnCOOM CBtBkXIqWFGRLJa7dePh/2O8HYBOd4rgopiGN0lo= From: Tomi Valkeinen Date: Thu, 20 Jun 2024 14:07:53 +0300 Subject: [PATCH v2 4/4] media: admin-guide: Document the Raspberry Pi CFE (rp1-cfe) MIME-Version: 1.0 Message-Id: <20240620-rp1-cfe-v2-4-b8b48fdba3b3@ideasonboard.com> References: <20240620-rp1-cfe-v2-0-b8b48fdba3b3@ideasonboard.com> In-Reply-To: <20240620-rp1-cfe-v2-0-b8b48fdba3b3@ideasonboard.com> To: Mauro Carvalho Chehab , Raspberry Pi Kernel Maintenance , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Naushir Patuck , Laurent Pinchart , Sakari Ailus , Jacopo Mondi , Kieran Bingham , Tomi Valkeinen , 20240531080707.34568-1-jacopo.mondi@ideasonboard.com X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=6375; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=hkNlI+sgdGQzSZGPKmgnDdL4kzR0qMFhYbi4GF2MhhA=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBmdA2SFjXFTwKl1fuxvldNezS4egKmmfjRMPAhZ WJ2iaZzzFWJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZnQNkgAKCRD6PaqMvJYe 9VnpEACCQe8jSHZ+Ry+Dw4k039nV97aOw/U6Rsq76xf9hANgmtvGgXXmiQDpPn/oGeIt8PySOqf bUMvcm7Id0zQmyLACo3cmgiiyQyRIOKa/5xHHUiGcjjwf9ux4/u/iBgDh53tacO+tobbIldyRuR 7BSMChsvVvQxDErg/MuH4ze2mrea7Z6yWJ3CqzeEfmld3B8NfS6TNlbCGBWQl15Hprg1Nvw1VjK Nc6/h92reR5/A0m/LyNDUU0fjdxIKXzwk+GpgNmolYkPHT3liSYvkBbARwgkvrsq0XG2FFUxT7u xID354KNZrfpEFpM8VH14r1GudiuUuJbdLLVEx9I3PpseMKtCTrchkez4IsOaB65RidCkl7GIek hsIDE5zdSWAubYWBgIBlS3Kzd+pTbvZRoxHTDFpBSZp6wF2uYMmg4nDBq+/RaC+D9+ZApDkl41X dnkEfBU/Blhy3uzNcKilHTl649hI+aRB6MZpyw5IgBLf1PT8qR6Eiix+LABEb4Cb98zhOMGIc7l CxxM3YEbbAiIF+Tdvnt5MDCAH001brcyr51uOsz0FEvQOQFYTuV/SsOaOp6XIeWFSf5iI3PL693 aLDMaQ7197pqbzwHAF62QfYRyZQ2X4EL9w9MpAhlnw2Xp9WJ8h2o3FeCcloSzshKZE6KDkywtEQ tgM7tKaZL9dpotw== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_040811_058564_8508AC2C X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add documentation for rp1-cfe driver. Signed-off-by: Tomi Valkeinen --- .../admin-guide/media/raspberrypi-rp1-cfe.dot | 27 ++++++++ .../admin-guide/media/raspberrypi-rp1-cfe.rst | 78 ++++++++++++++++++++++ Documentation/admin-guide/media/v4l-drivers.rst | 1 + 3 files changed, 106 insertions(+) diff --git a/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot new file mode 100644 index 000000000000..7717f2291049 --- /dev/null +++ b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.dot @@ -0,0 +1,27 @@ +digraph board { + rankdir=TB + n00000001 [label="{{ 0} | csi2\n/dev/v4l-subdev0 | { 1 | 2 | 3 | 4}}", shape=Mrecord, style=filled, fillcolor=green] + n00000001:port1 -> n00000011 [style=dashed] + n00000001:port1 -> n00000007:port0 + n00000001:port2 -> n00000015 + n00000001:port2 -> n00000007:port0 [style=dashed] + n00000001:port3 -> n00000019 [style=dashed] + n00000001:port3 -> n00000007:port0 [style=dashed] + n00000001:port4 -> n0000001d [style=dashed] + n00000001:port4 -> n00000007:port0 [style=dashed] + n00000007 [label="{{ 0 | 1} | pisp-fe\n/dev/v4l-subdev1 | { 2 | 3 | 4}}", shape=Mrecord, style=filled, fillcolor=green] + n00000007:port2 -> n00000021 + n00000007:port3 -> n00000025 [style=dashed] + n00000007:port4 -> n00000029 + n0000000d [label="{imx219 6-0010\n/dev/v4l-subdev2 | { 0}}", shape=Mrecord, style=filled, fillcolor=green] + n0000000d:port0 -> n00000001:port0 [style=bold] + n00000011 [label="rp1-cfe-csi2-ch0\n/dev/video0", shape=box, style=filled, fillcolor=yellow] + n00000015 [label="rp1-cfe-csi2-ch1\n/dev/video1", shape=box, style=filled, fillcolor=yellow] + n00000019 [label="rp1-cfe-csi2-ch2\n/dev/video2", shape=box, style=filled, fillcolor=yellow] + n0000001d [label="rp1-cfe-csi2-ch3\n/dev/video3", shape=box, style=filled, fillcolor=yellow] + n00000021 [label="rp1-cfe-fe-image0\n/dev/video4", shape=box, style=filled, fillcolor=yellow] + n00000025 [label="rp1-cfe-fe-image1\n/dev/video5", shape=box, style=filled, fillcolor=yellow] + n00000029 [label="rp1-cfe-fe-stats\n/dev/video6", shape=box, style=filled, fillcolor=yellow] + n0000002d [label="rp1-cfe-fe-config\n/dev/video7", shape=box, style=filled, fillcolor=yellow] + n0000002d -> n00000007:port1 +} diff --git a/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst new file mode 100644 index 000000000000..668d978a9875 --- /dev/null +++ b/Documentation/admin-guide/media/raspberrypi-rp1-cfe.rst @@ -0,0 +1,78 @@ +.. SPDX-License-Identifier: GPL-2.0 + +============================================ +Raspberry Pi PiSP Camera Front End (rp1-cfe) +============================================ + +The PiSP Camera Front End +========================= + +The PiSP Camera Front End (CFE) is a module which combines a CSI-2 receiver with +a simple ISP, called the Front End (FE). + +The CFE has four DMA engines and can write frames from four separate streams +received from the CSI-2 to the memory. One of those streams can also be routed +directly to the FE, which can do minimal image processing, write two versions +(e.g. non-scaled and downscaled versions) of the received frames to memory and +provide statistics of the received frames. + +The FE registers are documented in the `Raspberry Pi Image Signal Processor +(ISP) Specification document +`_, +and example code for FE can be found in `libpisp +`_. + +The rp1-cfe driver +================== + +The Raspberry Pi PiSP Camera Front End (rp1-cfe) driver is located under +drivers/media/platform/raspberrypi/rp1-cfe. It uses the `V4L2 API` to register +a number of video capture and output devices, the `V4L2 subdev API` to register +subdevices for the CSI-2 received and the FE that connects the video devices in +a single media graph realized using the `Media Controller (MC) API`. + +The media topology registered by the `rp1-cfe` driver, in this particular +example connected to an imx219 sensor, is the following one: + +.. _rp1-cfe-topology: + +.. kernel-figure:: raspberrypi-rp1-cfe.dot + :alt: Diagram of an example media pipeline topology + :align: center + +The media graph contains the following video device nodes: + +- rp1-cfe-csi2-ch0: capture device for the first CSI-2 stream +- rp1-cfe-csi2-ch1: capture device for the second CSI-2 stream +- rp1-cfe-csi2-ch2: capture device for the third CSI-2 stream +- rp1-cfe-csi2-ch3: capture device for the fourth CSI-2 stream +- rp1-cfe-fe-image0: capture device for the first FE output +- rp1-cfe-fe-image1: capture device for the second FE output +- rp1-cfe-fe-stats: capture device for the FE statistics +- rp1-cfe-fe-config: output device for FE configuration + +rp1-cfe-csi2-chX +---------------- + +The rp1-cfe-csi2-chX capture devices are normal V4L2 capture devices which +can be used to capture video frames or metadata received from the CSI-2. + +rp1-cfe-fe-image0, rp1-cfe-fe-image1 +------------------------------------ + +The rp1-cfe-fe-image0 and rp1-cfe-fe-image1 capture devices are used to write +the processed frames to memory. + +rp1-cfe-fe-stats +---------------- + +The format of the FE statistics buffer is defined by +:c:type:`pisp_statistics` C structure and the meaning of each parameter is +described in the `PiSP specification` document. + +rp1-cfe-fe-config +----------------- + +The format of the FE configuration buffer is defined by +:c:type:`pisp_fe_config` C structure and the meaning of each parameter is +described in the `PiSP specification` document. diff --git a/Documentation/admin-guide/media/v4l-drivers.rst b/Documentation/admin-guide/media/v4l-drivers.rst index b6af448b9fe9..61da154e079a 100644 --- a/Documentation/admin-guide/media/v4l-drivers.rst +++ b/Documentation/admin-guide/media/v4l-drivers.rst @@ -26,6 +26,7 @@ Video4Linux (V4L) driver-specific documentation raspberrypi-pisp-be rcar-fdp1 rkisp1 + raspberrypi-rp1-cfe saa7134 si470x si4713