From patchwork Fri Jun 21 09:31:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Potin Lai X-Patchwork-Id: 13707150 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DDF7C41513 for ; Fri, 21 Jun 2024 09:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BlPyR2DwNKIhgYcJR7RVlheTP0T99OY10zKkh8vPfJo=; b=iaenjoctnPUKWuD+u16ACCx69T YsBrtmSxRvyeeJldFGy9NVI6dIr5QvXNnRDLixbe/pgVqrjDupv5w185eNSFuU5OI9/s/JV64FWuw z0tsfOz/g5WZnKjtUEwuOj+PR5M7dD2SlqnLd02YZyvDVET1+MuQWxhosPonRAaZ2TWkDYOk5DE8U UwvICnK5DouUC3WhvwIf725dMBmrabnL0tzWNcO24GJpgxZcnegibgRdwLBbQKPVNBO013XpHYULP TY4ex+HxJltGvJn+kNGKJaTGShsQCF5fcpfOC5Qv7e2deEkp0OicsOGXlNnZne14/qIqHTXAvD2bq +YxvZaLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKaeq-00000008ZXc-1eyF; Fri, 21 Jun 2024 09:34:12 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKaeh-00000008ZTe-0X5Z for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 09:34:04 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1f8395a530dso14255865ad.0 for ; Fri, 21 Jun 2024 02:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718962442; x=1719567242; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BlPyR2DwNKIhgYcJR7RVlheTP0T99OY10zKkh8vPfJo=; b=miKls9Ha5VPiTv8eqUhenEeOMEoPJuU94Iolq29SlGiVToOukoKY29sKZWlU2Irdif 26ESK8Z2LbX7ajD81WrGgt2W5RcV+70NfHNdDIjduAmA9FwWtzwNsRZhe77HkhzIPDlo trfJqU9JyOOp2bNW7mk2l1zBeoyVUPtPRIf6Efc/srVdEBkK70v8KXxhsw0FXNgfmLX1 GsshYkaISEc3VZGpZvZvN3xXVu447sHVDM0dvZpOlhAnZ5emWQ45Ro221qX3ySl6hFnV uNZXQ9lH2jrJfUR37gXEtafoQxnZt81+leB6R1CKNLD4rBfgxmRDeubvZ0QQdbvCid0H 27QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718962442; x=1719567242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BlPyR2DwNKIhgYcJR7RVlheTP0T99OY10zKkh8vPfJo=; b=jfTddO99vZc0TR0LMf44YnY2Dy2YQeTwchc0Empj4XocrM7+wuN8l7WKhZ6hNmUtMF hyHddlcDQHTUi3IgZKXFSTf1h5mJIzXXMUMmYZWkVsJwLOPfh+KNn6Z2wv6weY9qEhil A5scdzXy4mUcVbodoSTnZA0JZd6DyDPf7obn89Y7dwPB47JMDi0yEXIcjyoP8cqBCquN Lkay8D6pJXsyydA6caVPAhLo8iLRpA7ry6mMPWjnsJulnlrqbmQ7pr80n40bYX1L9CdI 1lezD+BDnzJoWSIRxqmrCN6syfW4PSIliq5ROE6LGzdbbDoXqhZfkxfzWGL95qdscOF4 YIoQ== X-Forwarded-Encrypted: i=1; AJvYcCVVGtoW8WLeaPXtTuNE2LnmBlZC0ra1bj7qWDqw634e7fUTwi5e9nX6OC2XQAeAZUwL+N1IMAyvprOgoXCl59MP3Lc3zQlB8HNt/dnrlSO3vD5hVyE= X-Gm-Message-State: AOJu0YxX7xMwo0WDiRSXcjht4/wybhrId+xvdVL+UkSuDU975otHLq4s K+MgJjZGkkXyUtXAepvvUuV31sxFU63McheS4Z7t+sOrLK/VoZM/ X-Google-Smtp-Source: AGHT+IFfA7C54egHwv68x+7wV7g0a7OIDYQlMXJVlMpjxHZw9f4QfFjmcMgrvV4MeiBayo09KJSZQg== X-Received: by 2002:a17:902:cec1:b0:1f8:67e4:398a with SMTP id d9443c01a7336-1f9aa3bcab8mr82874115ad.13.1718962441726; Fri, 21 Jun 2024 02:34:01 -0700 (PDT) Received: from localhost.localdomain (61-220-246-151.hinet-ip.hinet.net. [61.220.246.151]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbc72e9sm9810365ad.296.2024.06.21.02.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 02:34:01 -0700 (PDT) From: Potin Lai To: Andrew Jeffery , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Patrick Williams , Cosmo Chou , Potin Lai Subject: [PATCH v4 1/2] dt-bindings: pinctrl: aspeed,ast2600-pinctrl: add NCSI groups Date: Fri, 21 Jun 2024 17:31:41 +0800 Message-Id: <20240621093142.698529-2-potin.lai.pt@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240621093142.698529-1-potin.lai.pt@gmail.com> References: <20240621093142.698529-1-potin.lai.pt@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_023403_197569_211FCF88 X-CRM114-Status: GOOD ( 10.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the NCSI pin table, the reference clock output pin (RMIIXRCLKO) is not needed on the management controller side. Add "NCSI" pin groups that are equivalent to the RMII pin groups, but without the RMIIXRCLKO pin. Acked-by: Krzysztof Kozlowski Signed-off-by: Potin Lai Reviewed-by: Andrew Jeffery --- .../bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml index 00b6974a5ed3d..80974c46f3ef9 100644 --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml @@ -19,6 +19,11 @@ description: |+ Refer to the bindings described in Documentation/devicetree/bindings/mfd/syscon.yaml + Note: According to the NCSI specification, the reference clock output pin + (RMIIXRCLKO) is not required on the management controller side. To optimize + pin usage, add "NCSI" pin groups that are equivalent to the RMII pin groups, + but without the RMIIXRCLKO pin. + properties: compatible: const: aspeed,ast2600-pinctrl @@ -337,6 +342,8 @@ additionalProperties: - MDIO2 - MDIO3 - MDIO4 + - NCSI3 + - NCSI4 - NCTS1 - NCTS2 - NCTS3 From patchwork Fri Jun 21 09:31:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Potin Lai X-Patchwork-Id: 13707149 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D124CC2BA1A for ; Fri, 21 Jun 2024 09:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EiJfmKO8nNBSX1oUuFOSypNRXVZPBtzmshynKzoPzUw=; b=epsIHvqKFWLDuxBNXvB8m5pkMo 6qeGzGo6To+o/u8xN5Y+iD6Oy3DSg0Gdrqy8JupjX+2b+1ZBHh2id5dE4zSCkGKQPQWfUUxjWun+T dv4lRZj9i2muvOEZH7szbAqp2eFfugPD61svG5TgtX6N7phn2a9l6PkPdggaRcz/zGqWK8/oZYJE0 HcttEDk3l+w3A1jN2ZeJJv/cB2ZbUgnTmw2BErAMpcjdUxsJeWAfYxDZ3mBQSSOw0qEceaL7kMx6I rBlOZhwA/dGn78VfnfRRelmbzPgaPENYFB7iE62+C22WaPUSFwYHpMfBYe1uxlb/Du1eK18Nuh9pO kr+WlR2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKaer-00000008ZYL-0n9V; Fri, 21 Jun 2024 09:34:13 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKaek-00000008ZUf-0LJ5 for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 09:34:07 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1f6da06ba24so13455255ad.2 for ; Fri, 21 Jun 2024 02:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718962444; x=1719567244; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EiJfmKO8nNBSX1oUuFOSypNRXVZPBtzmshynKzoPzUw=; b=PBQOkZFrPS69D8azEiroXYjIDE+XP6R2HTrwqRo36sp66ZSQwNg+v9JMRihDre8s5y 85Vmu008Vq7ZKqP48k/h9i/NrFMPSvoe5qKEevqgT4q3KV0inEqREzY8x+XLCSMPZzq1 qHethG6Eh0ASZ/tbTfd8LNU8wKh/3z1gf8QdyQe/eH2CaAkKJELSSBjbzIhJbP+EY1wl +uKLz7JZwJdfuKZmz7Bj/EKx4z/DBds8e8DVN4HhVkIZGryOGAL9QIi4qfZooUDqIa1O yTBF6nvpXX13vTrHd4ggx38kcWYzrzdvLqC6DYASnutoGkDyNEvs0kdvvBoM8B8hGN9U 9oXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718962444; x=1719567244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EiJfmKO8nNBSX1oUuFOSypNRXVZPBtzmshynKzoPzUw=; b=jLbz/E1lSrfII6x67337TJiVnrdF+TpqIo7TyWC7K5XbXusSOdR/Cbbn0Hh72E9e9S QZELSjVu4ykyHi4KnmE7vbK4d1LVa98u44UGrvjEf1QqaFeiv0BDdddd5DJq6aNa0dhP wrhjXCmDpVCSD3Xdo900X/z4lIRBcMIMX9V7AjxHL8RTigJ2M6oKVEx9PnHJID+EZqfa hSDwxgVhFyOJfv2UGU9s9GNoy1xSExlxAb3FLSeqEeSuIYCuST/85MrZhBZuUEm6TpFz 8ICC8G17adpVrjIn+ZT5ayktCzj1dlv8jreXCSQIX0QfH8xlDr1VTpJVHzPnM7/uaITB VJ6w== X-Forwarded-Encrypted: i=1; AJvYcCWu5Ks7J0p32p5R9C3dkVtU0savka6HKUGadAyA6uBSo/wg7z/qAIsoH9JtMayA/OGa26PCJm1x0XemiEq/FgpBnVsQuMgd0unzwvEZCt5jUvo3aXM= X-Gm-Message-State: AOJu0YwohC/P8K39EdZvmLgE8xrpFG/T5AzjIZdsgxXUOVg5TyFhln4G 98six6Pt7abM6RvRwm1RjE2u2z1CqfGw7kWn6Elm4cTiscAmRBCd X-Google-Smtp-Source: AGHT+IFOKXrh2SxGVKHFT+5si9TabUQXPaizDpK8J7kyQ+x11v7jWslxqA6il5ABG6GwYYLtHI0tSA== X-Received: by 2002:a17:902:d4c1:b0:1f6:7f8f:65c7 with SMTP id d9443c01a7336-1f9aa3e9e54mr90810285ad.26.1718962444561; Fri, 21 Jun 2024 02:34:04 -0700 (PDT) Received: from localhost.localdomain (61-220-246-151.hinet-ip.hinet.net. [61.220.246.151]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbc72e9sm9810365ad.296.2024.06.21.02.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 02:34:04 -0700 (PDT) From: Potin Lai To: Andrew Jeffery , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Patrick Williams , Cosmo Chou , Potin Lai Subject: [PATCH v4 2/2] pinctrl: aspeed-g6: Add NCSI pin group config Date: Fri, 21 Jun 2024 17:31:42 +0800 Message-Id: <20240621093142.698529-3-potin.lai.pt@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240621093142.698529-1-potin.lai.pt@gmail.com> References: <20240621093142.698529-1-potin.lai.pt@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_023406_199141_568BBBD5 X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Based on the NCSI pin table (Table 181) in NCSI spec[1], the reference clock output pin (RMIIXRCLKO) is not needed on the management controller side. To optimize pin usage, add new NCSI pin group that excludes RMIIXRCLKO, reducing the number of required pins. LINK: [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.2.0a.pdf Signed-off-by: Potin Lai Reviewed-by: Andrew Jeffery --- drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c index 7938741136a2c..31e4e0b342a00 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c @@ -249,7 +249,9 @@ PIN_DECL_2(E26, GPIOD3, RGMII3RXD3, RMII3RXER); FUNC_GROUP_DECL(RGMII3, H24, J22, H22, H23, G22, F22, G23, G24, F23, F26, F25, E26); -FUNC_GROUP_DECL(RMII3, H24, J22, H22, H23, G23, F23, F26, F25, E26); +GROUP_DECL(RMII3, H24, J22, H22, H23, G23, F23, F26, F25, E26); +GROUP_DECL(NCSI3, J22, H22, H23, G23, F23, F26, F25, E26); +FUNC_DECL_2(RMII3, RMII3, NCSI3); #define F24 28 SIG_EXPR_LIST_DECL_SESG(F24, NCTS3, NCTS3, SIG_DESC_SET(SCU410, 28)); @@ -355,7 +357,9 @@ FUNC_GROUP_DECL(NRTS4, B24); FUNC_GROUP_DECL(RGMII4, F24, E23, E24, E25, D26, D24, C25, C26, C24, B26, B25, B24); -FUNC_GROUP_DECL(RMII4, F24, E23, E24, E25, C25, C24, B26, B25, B24); +GROUP_DECL(RMII4, F24, E23, E24, E25, C25, C24, B26, B25, B24); +GROUP_DECL(NCSI4, E23, E24, E25, C25, C24, B26, B25, B24); +FUNC_DECL_2(RMII4, RMII4, NCSI4); #define D22 40 SIG_EXPR_LIST_DECL_SESG(D22, SD1CLK, SD1, SIG_DESC_SET(SCU414, 8)); @@ -1976,6 +1980,8 @@ static const struct aspeed_pin_group aspeed_g6_groups[] = { ASPEED_PINCTRL_GROUP(MDIO2), ASPEED_PINCTRL_GROUP(MDIO3), ASPEED_PINCTRL_GROUP(MDIO4), + ASPEED_PINCTRL_GROUP(NCSI3), + ASPEED_PINCTRL_GROUP(NCSI4), ASPEED_PINCTRL_GROUP(NCTS1), ASPEED_PINCTRL_GROUP(NCTS2), ASPEED_PINCTRL_GROUP(NCTS3),