From patchwork Wed Jun 26 09:42:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiu Jianfeng X-Patchwork-Id: 13712498 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 182D7C27C4F for ; Wed, 26 Jun 2024 09:50:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5995A6B0082; Wed, 26 Jun 2024 05:50:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5492D6B0085; Wed, 26 Jun 2024 05:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 438046B0088; Wed, 26 Jun 2024 05:50:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 280486B0082 for ; Wed, 26 Jun 2024 05:50:45 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8FD111C2157 for ; Wed, 26 Jun 2024 09:50:44 +0000 (UTC) X-FDA: 82272570408.16.AC08B44 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf15.hostedemail.com (Postfix) with ESMTP id E7726A0017 for ; Wed, 26 Jun 2024 09:50:41 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719395434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=+Bp8PKWqVORkwTwnJo+ojaDjjFAUl8pnm3/o9e+Kceo=; b=cJ3+IDVMg4LWyZxhuYajkkYy9GnnrpkzQ5vUX7Xokj6qqqUHATJ4xd/dTK8u1MfjR6Ca4I 4xNmfMKyLxbP/p4mUT+fDHbELt4H3n/limT/QawHUYyoHp2UM4bFXod3NBHEot99jpM9gc S7BrCCHjz5fpfigM51eh3BogwCuuYik= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719395434; a=rsa-sha256; cv=none; b=ujlDJ05PH8SqI+BeDT0JlvAaJxwot6eYH9dkVOsR7Q91HoJfB/LFVk6DClQ0oOHUuvU5qF 62YYEcDg4lJQmSH1cKwc7TrxKDsIOrnKugt9frWsmXna1E4dq1Miw6BmkiNn9eIWzSBDQ4 Bvge9y0ShNGAaYV2uXLynJN++2PDAmk= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4W8H4l6t1KznXgs; Wed, 26 Jun 2024 17:50:31 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id 22048180086; Wed, 26 Jun 2024 17:50:38 +0800 (CST) Received: from hulk-vt.huawei.com (10.67.174.26) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 26 Jun 2024 17:50:37 +0800 From: Xiu Jianfeng To: , , , , , CC: , , Subject: [PATCH -next] mm: memcg: remove redundant seq_buf_has_overflowed() Date: Wed, 26 Jun 2024 09:42:32 +0000 Message-ID: <20240626094232.2432891-1-xiujianfeng@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.67.174.26] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500023.china.huawei.com (7.185.36.114) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E7726A0017 X-Stat-Signature: ek3d84bciy38z8caz8k1a5h8hr5juep9 X-Rspam-User: X-HE-Tag: 1719395441-399374 X-HE-Meta: U2FsdGVkX1+e1hn7e0uAvCk+bpEXZ08n/hOm58vXZxSBvop6A/qHkbuSbVCHcT6bd2NyAK0ClXdf3yPl0BG2wOCB3HHt5BeAWLDUIiiIeoA/o2IfH6t+MV2U8LZh3LVNvstg53KdRlp1No+GUjPVXwAWCPwclI0NkNWAXETWEP2PfD74pEK/ghd3zoRO3MDZRAypWnwRfKia24XWXDSr1aeAiuteYx+1SpdeGE6geXPpcxnopMSQv1SFgq3PoGCp7mzs2YNsEVrpYgl0GVxSVxvU5AWK0iHGcIMVucSTh19vkyOnTRJACrTOma11EQb8FcKfZioujtg5g1BpilRyJ//aiL/G9dpjyDvo1nj9BmkD40OAe3FNb2fZGaGCnLNb2teILa1c1wgbZQR1aiVunDo8qcSEpMEJTElMhK0SkedKbt3B0d3D0j2ajnQ81ZukFZQGfBHi7xvejtiUiCpJVng0vX4l1Fk9cI6itRiCUjzp5eemLpZFDXPoVQW0pmL0h0/xhhw1Zb/FN8d2rtrBkZ7EUFyONdrSAns2qC+dE4J5a+9YbKAYT+lILcHl1FbJ2pxp5mBKWqvLJRxf5XSaZGrCuG/Hur/JhKeNi5APVt0PPONvfFPVicrRAB+iU2G16QABQboCBKBotcGwP92yUmrXZjDc+mBAw1gjfbaSJ4IZ4L8av7Tc4n9eQ4QtjJoqJL0PcLHFSBXGnWrxafqUPoqtiTFOQXfY7+dVyxjx7wqOGLb1cxAfcGFY5Y7oFoZOM0UGtoDHqXAsWogGDcvQNy07Fxdg40xggr1jLJXPbOBOv8M5OjaZUzxtBtpiFyg1bnfknfMcsNw3xEuBlkD9UAxi5f8tTOcVY2wD/ebPYoVpqUW5XrwOm4EcYH70YHb5Pc1WHoW4v2kjFiK4Kr+pxigoRvCZrSU4ANWiCObIbdrcnZEjN1YtxBhHCFpz3UxIQMNJ2h7uGLy5hhPewbo wGE/ja2U 3g2HwJOhnSgM5wSNZkhpL0K6xD92sFfE7v5n/+mkgAk5c4b8G5MCmSq6RQ+/AWKboxQMUQG/K3SLZCD21oMKRjlKw88nG4HFAvWm1b5UuWbN4TIEDKGV6R7noWSQDK5CQpi+kAFASyEU+TpMZHwZptB3QirT3wbCC3aFaE2IWbOJgLwefCpXYBj6OisjZtmZjiHpk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Both the end of memory_stat_format() and memcg_stat_format() will call WARN_ON_ONCE(seq_buf_has_overflowed()). However, memory_stat_format() is the only caller of memcg_stat_format(), when memcg is on the default hierarchy, seq_buf_has_overflowed() will be executed twice, so remove the reduntant one. Signed-off-by: Xiu Jianfeng --- mm/memcontrol.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 974bd160838c..776d22bc66a2 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1846,9 +1846,6 @@ static void memcg_stat_format(struct mem_cgroup *memcg, struct seq_buf *s) vm_event_name(memcg_vm_event_stat[i]), memcg_events(memcg, memcg_vm_event_stat[i])); } - - /* The above should easily fit into one page */ - WARN_ON_ONCE(seq_buf_has_overflowed(s)); } static void memcg1_stat_format(struct mem_cgroup *memcg, struct seq_buf *s);