From patchwork Wed Jul 10 17:04:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729500 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD281953BA for ; Wed, 10 Jul 2024 17:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631119; cv=none; b=kEQ+e+OlsQQxvZ9zSbenNT/UJBuXEXtrEWPpg/rEzU5uLc5/ZDAaFlQV9mf+GcjywsQ58lzw2Q0rGuqDr07g7ebp7R3iTfPcDLL3KJkPvoYblCJbyQEoF7wAa2UMcCDb/V05SHNBLXBd7qIQ3MtDO3Rc2HcxMuoZVM1g8VtVPNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631119; c=relaxed/simple; bh=wXcS/KnBI5LgsGogTMFCCth33LAkgZkI+3fauQ91JiE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cFIYu4HVFW04A13n7ZfYRldRMb9MOqxjAfLctb2JG0oIB083lSo74g+TlbXEgUbv87yLd6v3bP44WEyLW663pit49bTds71jSx1JRIA2/E9C2zAp1OsPzGXnsoJek9Wk79zZIBmrRS1zNvAJt25eIOr/EvJQBVetF2yE8AtSLFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e/bXP+WV; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e/bXP+WV" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-36798e62aeeso4358763f8f.1 for ; Wed, 10 Jul 2024 10:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631116; x=1721235916; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ri1KrrJv5lGlLAnLFws19LhHfpuP+FO80ojRQ99yShw=; b=e/bXP+WVdxJ+GppzonXkozIOLiRKmMnJ9RCWcsH8N0GO7ky4VDOy99r0PlGkNOqoSR 7aNcu0a49hIQIXHXtVPsgDbj+dGvgkFxD4aP2F/Fb4rCBpRvqnzmcR4FDSrn8ozIR+cp CdqvMuCHRz9PvpN8BN0Ioj5PzSmlebZjnHx+ZyYW0LxPw8ua85X3GL+Ph/DJ/D8kjn2Z IiQosaFf69Mct8pZkKXm7m+PC2utw5TUeBNTVVwbJYVzjLENfgnX5ZBM2VChfrCYjmup BDUCMiTAesCYcmnQqfwLnX/4alm65oGj1OVSTL/UWUw15Q3WJBeEjGYhArfn1nl9EPax UfDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631116; x=1721235916; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ri1KrrJv5lGlLAnLFws19LhHfpuP+FO80ojRQ99yShw=; b=IleGsQGtm/38PucIPNkj4orQ7pyCpSKupO/d7BFH3lAk+bAVQYOg4snETHMhtwwC3T 8PJ3ySWb/GHOR2XOAaetGO7msU1NOAMnzKHXeURC1pN0/zl83IJ2mvzJgo6VsfXoAn7r NjoAtm5NxLEvIjNijl5C5Io4WvuIhafjzFsxVeCJJb6csA1afgw7n0t6npm+t2i9V0YM JeiF4onb8ewPHi0/4g8Rp4mVyaTSmER0FU6Kd4fFxXTpGx1Hfwl6ekFZY90yKvPymSD7 DtDbFIE7TkU+jrRZ9xQiQs/h7PT7yPJxizqUiihVb7+3PyHDu3wFDguYI7DLBAmmHjdz 0viw== X-Forwarded-Encrypted: i=1; AJvYcCViHQ/HNgpphMbheX8r9QLeOCoQ3U3CSyoMtxoaTzNyh2/cGZ/O7DZpH4b/z53yYmthmXeHok7jHp58mv76YEHs+j4PeoPt0pCxyTDEWA== X-Gm-Message-State: AOJu0Yy7DaTC0aKnaFbvcQj+Nt9Nt02GdWzXsln/Z6X33gGhbaKyr2td KEGQ+a3H9AkDthgOh8Kq7RAvR9vzXZ448+V/3dI1kNxbg3qel8CIEX5jBzKUBYs= X-Google-Smtp-Source: AGHT+IG2I2vfs2A9BrUdEREFeLsTLIRYJLTlw8D0se40K1gnpRKxO6FDo/ods9+emAorOvUndvejzA== X-Received: by 2002:adf:978f:0:b0:366:e9f3:c242 with SMTP id ffacd0b85a97d-367cea46887mr3987846f8f.12.1720631115960; Wed, 10 Jul 2024 10:05:15 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:15 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:57 +0200 Subject: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-1-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the existing ATNA33XC20 panel, just with a larger resolution and size. Add a new "samsung,atna45af01" compatible to describe this panel in the DT. Signed-off-by: Stephan Gerhold Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml index 765ca155c83a..d668e8d0d296 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml @@ -14,7 +14,11 @@ allOf: properties: compatible: - const: samsung,atna33xc20 + enum: + # Samsung 13.3" FHD (1920x1080 pixels) eDP AMOLED panel + - samsung,atna33xc20 + # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel + - samsung,atna45af01 enable-gpios: true port: true From patchwork Wed Jul 10 17:04:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729502 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DFA3195809 for ; Wed, 10 Jul 2024 17:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631121; cv=none; b=X7Oq4+J4OtqL9Nf/hCY6TXwks9BxZgGIZ5RzdZjoKEiBYkJAQ44ERCbWf2VbZE812f2p+xLQYTgSOgoFHXdZNjyBdR+LDcbrguH6Cotnf5ibEaGIHtB7IqMW7X1XV0qtjmAZK1QPXPoI2ZYziG97Zy6xKcIbtvjk8XFCTVoyZxM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631121; c=relaxed/simple; bh=4u4EzVnigRGaEkzIutm5rdwG3oK439XpXPx5hpNTB2s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p2I862+9v82LeeLxfGzFENy7bNZZ+UlSZkJd/0QrGpgt2BKc8YM+vYq+63V/Q38+4YHIvjUqPlz0fMFayIwWUPkCa5S+3BMy2JOukV3BiyM17KrryOuVAM8T0vaiE5h2PKop+9MOFg4VpLWry7iP4Xhi6YQ2ATMMmsabDli8s/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DsGkDBh4; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DsGkDBh4" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3678aa359b7so710232f8f.1 for ; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631117; x=1721235917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/g1Yb1+vfOCpHonxF+Jqbu5p5cwpmV8OmQtPa+jVmyk=; b=DsGkDBh4bRXaavMvuqB/oQezv1jE2QdIFeLx4Ihe/nBwclajIIjRUwfruDljE9JFXv t2OL9AwPQjVDezw1LJAGFqHpnNow9oaZM/q73aOs90fH5zjcIPkQqpaddmMKUks5EKk9 GQUNo7cnhjvalgFE3DFfx7lCXKTYwr/WwQKX/yKEV8wx/tBHF102lO3tT5IHaRI3hP5o dbZ4goidzy8xqRIzqUQ+FHL6gtb94bagPZjpWwIDEZZe3OehhFvnMqoTLbUB7/nF68cS I2tKCuZyQOIjRhKlwHEU2wXXLyguorxvuSM1ctKqyu5haZr3iBK/VoLk5SZSgVz/lrQi GT9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631117; x=1721235917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/g1Yb1+vfOCpHonxF+Jqbu5p5cwpmV8OmQtPa+jVmyk=; b=qElO1pvvU7oJc2NxYhxUJYtmANZfuE1IU9x2rGjMvyv7pH6S09Bgm9KEWYqXDlMff8 ShHHka0zbWodSt+bicXSqyxWZiBSk4CB1pBKPns3aSfJBVBfy3Orb+kWhMfMiVvPW6/M zCQtPF0Mw7LHBxp0YMT0OFasoyNkJ9cgaCq0GGlIx5i2j/WHDkfLpLuS+kz7raUFNXlk GrTbEDcF2svJJHRZCoAKpa80uAhiRdKQwDl6xI61HsrKfyWQTK2L0eHmRCoahcymXtdh pLrMypteEeX+HJfk/Ng4AVJOtK7liAFchbTV3aQOYsO6aU3Ggq4kOOmBg+Pgye1cOweo 4wag== X-Forwarded-Encrypted: i=1; AJvYcCXmtSwGOGEiwrbOVH0lvvi9hdAVMgRCC6mD8wdqqx9fOxqTjrmcp39vvuPqhMhYhVr7vSKIg7NjHGk8VuFlfCupZkgFQJayw9/RZZcRcw== X-Gm-Message-State: AOJu0YxNCZU+TgNpAI3t4biKHCPKobNEU+joDCD0j/PfHU+UaKNOr9fi Ypbb6REBx/4wPwZLq4zm0pE2cdAT+d8+ELZ3yKZ9+g+fwOjviHxXyXcr5jDm4Ik= X-Google-Smtp-Source: AGHT+IHrRXiCsidR4X+LasiuthOFj9ICKMJe5oQgZWQE5LzqBbT6SBTjtUxtWEVsNWAdJXaa53sXHw== X-Received: by 2002:adf:e0d0:0:b0:360:8c88:ab82 with SMTP id ffacd0b85a97d-367f04de8e6mr260014f8f.30.1720631116954; Wed, 10 Jul 2024 10:05:16 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:16 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:58 +0200 Subject: [PATCH 2/5] drm/panel: samsung-atna33xc20: Add compatible for ATNA45AF01 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-2-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The Samsung ATNA45AF01 panel needs exactly the same non-standard power sequence as the Samsung ATNA33XC20 panel for backlight to work properly. Add the new "samsung,atna45af01" compatible to the driver to make it handle these panels as well. While ATNA45AF01 would also work with "samsung,atna33xc20" as a fallback compatible, the original submission of the compatible in commit 4bfe6c8f7c23 ("drm/panel-simple: Add Samsung ATNA33XC20") had the timings and resolution hardcoded. These would not work for ATNA45AF01. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c index 9a482a744b8c..fd56fd02df87 100644 --- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c +++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c @@ -333,6 +333,7 @@ static void atana33xc20_remove(struct dp_aux_ep_device *aux_ep) static const struct of_device_id atana33xc20_dt_match[] = { { .compatible = "samsung,atna33xc20", }, + { .compatible = "samsung,atna45af01", }, { /* sentinal */ } }; MODULE_DEVICE_TABLE(of, atana33xc20_dt_match); From patchwork Wed Jul 10 17:04:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729501 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33185195B14 for ; Wed, 10 Jul 2024 17:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631120; cv=none; b=YNmZBNlboUF6n7fIH5ozY/entKOlFpTB7lOO+5wYAPZ+p6+3GZ/ifhQ6AQgxmRx8oAzxi5QiBFLi06jI23fwW16mvuhD2DplKZcH1+6gUfqge6QFfhITJnnrjt/1SIWI/CcoqOQD+i0r/W7o5myN9WNiJ3FCTLYbdi12mWUStgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631120; c=relaxed/simple; bh=OjIv6lSyIoOmyQVHsNTFY8WnoyqlDx5HT8DrVGCLkuY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ccDcbQquCHsUGDOatD2OdWNbOvRjFJ34LpJ4OdZ1ZTybmrQAAVm+aqhz1NI+4JaxOGA1aJ6s3yCs/AV8A22Gftdbenkaatalye/dlaWbfPMZHLnl81bRBImNcO2C8PwvmXdtbzmLuWms4eQh5H1SYtSvlMAm56ouLhx84hC2h28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nkWXSBSj; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nkWXSBSj" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-426636ef8c9so25935515e9.2 for ; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631117; x=1721235917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S4NkoAIT77VT3upOcUYDgNo3eUGfA37eNUjC42fZIhc=; b=nkWXSBSjzqJ1ESlxQPj7Yb/ecY3DMOnq6LU7RR7lE5zaSowR+rJZsGleqCmWnR82/m xSvcyDKd0rCCcbwgtSjN/VvUD8DLs9n51/z2hO5pYvLaJXPmXxOfETTRsZJAPyTILpsR J+LLS2TVZH9svZZt9XEbzqJ13nLQpKEjOPfCSi0WFXmJBjvOQ+/JZaQE33rtWbmp+ObN xJQ2e2x5x8uqmrj9/NCmNnrVP/4zoBpT+bgORSBfTJxLq36kyRe9iFP02KjC89LcYI0T Es4PSvBzDNJxu4AmZfxg/Rg23Qi3w6DXkxtE9NfRQVdzjezbRjZ/+Loa9LuolZ+EUEMP OOpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631117; x=1721235917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S4NkoAIT77VT3upOcUYDgNo3eUGfA37eNUjC42fZIhc=; b=QtkcaA7A8uhyxueYGIx2z7K9kFLJeTlp6MdFK4Q+RLQEif9lQrmUFz1wBgQbOzcKU7 8eOaw4lW9VChgsSMXi9QiHaIW+ryPAy3h8cOQBHY4HmPIfgOPkIKEPaujoykjW1p5NYa ddtAbkATWj1WUWdNyyE1I0xwWOz5xqnqGLXXpe/MB0kRtthuPkv7F4N1hnsgGQk86PAz jxa+NNP66R6CBIUfTl0bJEKMZAyN9iQAAcUDHwUPcaa9MBBmzWZnomZGu/N5Vl1s6nTJ JANYwgiPaFzWWPz57rbeGVTrSUY/vfSUIqXG8EG7Cs4LIPkG+cg+5jp7AoX/icQootaC ZDtA== X-Forwarded-Encrypted: i=1; AJvYcCUfdZna1EOwdFAycw8+AD137F9mgMpCMgsmskVawDJAMgGycbjj9Ss2TGqUlzXDTqYb7K9ncc2T5U5z/GMITItTEu6Z+UxyBjg/GsNJXg== X-Gm-Message-State: AOJu0YyzhwCDo/VgOuBCl5/GrQ3BjK/vXDw7PpNm5Kat8wXyVilYEZuW W9AfBCnzMO6pDE/vF+/AcynPtRRmfMDdKF8WnGi8/IZ+yWmKPQcvLQJDtnud9ZI= X-Google-Smtp-Source: AGHT+IGkLUFSUmZ5ECS3GHwAe+MqsROrwZrfQE/I+tdJdPvxCPyYlWVxShiAik5dzVjABnYcvtZ7ZQ== X-Received: by 2002:a05:600c:896:b0:426:5216:3254 with SMTP id 5b1f17b1804b1-426708f1eebmr46866985e9.32.1720631117621; Wed, 10 Jul 2024 10:05:17 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:17 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:59 +0200 Subject: [PATCH 3/5] Revert "drm/panel-edp: Add SDC ATNA45AF01" Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-3-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only partially in that configuration: It works after boot but once the screen gets disabled it does not turn on again until after reboot. It behaves the same way with the default "conservative" timings, so we might as well drop the configuration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Signed-off-by: Stephan Gerhold Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 3a574a9b46e7..d2d682385e89 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), From patchwork Wed Jul 10 17:05:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729503 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56BA9195FD1 for ; Wed, 10 Jul 2024 17:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631122; cv=none; b=LU5PqKbUXku6XzGZdSHe/hR0aWEBwJzH/VnLmdX2IxHUAjO5f6sQWIXWXqTgiMvzOc6sB+EiGpFDxYn3ViLJlX1DqKfbmRMf87j73KvG5mp3xPs6XMmSbvojTDpIAzCCLQz03lewOD1zeuEkcV482KMhj9Vo/e1RsUpzh1mytoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631122; c=relaxed/simple; bh=UtGbOemBnLSiS/SSxde0/IPn7E11HeciK/KMJx5zgzg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UXzPUYLvuezBbEO4l/pUwxj4pnf+5YayJIpysm48fJvZh4nQ1sEkVEvaoo+plXbUrKVjH1weMi7Ud9ya3iJ/4e4Y+QEP5IhzG/sduR0guzmCELW7t8Pji2oRn/IvZUQhenLpFNKAwjytLlL7xkQBGHT890vvJEG6KtDKkB6NP3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LsLq3ko0; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LsLq3ko0" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52e976208f8so7221546e87.2 for ; Wed, 10 Jul 2024 10:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631118; x=1721235918; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ejuDXxzDzIH7zcxYcOPWRk3uTUuzsIoqRWToUCtONmU=; b=LsLq3ko0dEzIxVV03b/Sxfq0ohjNb7DdPmSl2uFnq3WU8jJ13/fccWpT/ATmUPgcuK k+Csu+TO8PGmCRyBNyasjp2FDjQ6cdZ0QWIkNL+nE6vkuo8WHimXlRTY/p1FfcfgJw77 56F45oodFpoGj+RMHwrm/oso9eAwGI7HNKdFS04ZzT1Dl6LYrSiPlCI+Tu9v6AdfNo01 MG8DlqovWQHyPCVAoIFBCM4aZsHPWJFf19TJQodeKj9G7fN94BMGYuwI7ekFHJ7b9GXa LmcUNCVAjfqLIVOmox8yTG6IhYL5ef86ZbR/j/j8VUUohaZxhlaRGoG8deaQXsplmYTt Sc2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631118; x=1721235918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ejuDXxzDzIH7zcxYcOPWRk3uTUuzsIoqRWToUCtONmU=; b=lQuMaPqcLMEkPYPHHo1z8Tog5NVj0cv+aRUzeE3wj8sxlw2Njd0EP5HnV4I8Ir9eqG LOcGk3/HtZHaixuunnTAT2S/yfoZVHKz1eaoXqdlD9Xi3RItmkt6ePXvgy6TRMjqFA2q +2yIIC9X3DBECejJLZqcQkzg6UMpNVbD+GhhQJ6rgjogRCNha723L+rN2StoHRBgqViV oh835Lw5N6Bsrdg8uveTpyf41s/yYdnYi+PuJzq9mK5Cg4CQexolYs+925SZg68SDbL4 g+t055SPucAoIFJnNy04gLQ5BXN0+E2ssF4jx5QE1/FOPxwEnKZ+0pHIP42nE0ML4r0g yH6w== X-Forwarded-Encrypted: i=1; AJvYcCVD09dmR6z1i2lu4lXJS9HFBQd5a1SHCHArT67Sq5PgmzvxfMh0fypUon+94JY9z7YusH6mpDnNDggFjUOfg+Y2fJCF1yqOEvaDNbJBQw== X-Gm-Message-State: AOJu0YzQM/29VF9nghB3g49dRg02GAoKeOjj1DKZHAzkIdDHM8pJHp36 yO6wAJs9ZRviH7GoQYK7ujD5liwegHFUpEDSJn7tQptE8F9bSJrhV9TNTw221+Y= X-Google-Smtp-Source: AGHT+IEdzDMqSpFrgPIKMoDSkhiU2e+ql+AL5vU9wurvK32RxWDhsTOWJlgEkSrVCpO+E3+Am+YAjQ== X-Received: by 2002:ac2:4281:0:b0:52e:9471:e533 with SMTP id 2adb3069b0e04-52eb99d5fb9mr3803124e87.66.1720631118372; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:18 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:05:00 +0200 Subject: [PATCH 4/5] arm64: dts: qcom: x1e80100-crd: Fix backlight Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-4-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. Switch the panel in the DT to the new compatible and make two more changes to make it work correctly: 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and enable-gpios in the DT). 2. Drop the regulator-always-on for the panel regulator. The panel does not seem to power off properly if the regulator stays on. Signed-off-by: Stephan Gerhold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index 6152bcd0bc1f..7d6800dd9b8a 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -268,7 +268,6 @@ vreg_edp_3p3: regulator-edp-3p3 { pinctrl-0 = <&edp_reg_en>; pinctrl-names = "default"; - regulator-always-on; regulator-boot-on; }; @@ -724,9 +723,13 @@ &mdss_dp3 { aux-bus { panel { - compatible = "edp-panel"; + compatible = "samsung,atna45af01"; + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; power-supply = <&vreg_edp_3p3>; + pinctrl-0 = <&edp_bl_en>; + pinctrl-names = "default"; + port { edp_panel_in: endpoint { remote-endpoint = <&mdss_dp3_out>; @@ -785,6 +788,16 @@ &pcie6a_phy { status = "okay"; }; +&pmc8380_3_gpios { + edp_bl_en: edp-bl-en-state { + pins = "gpio4"; + function = "normal"; + power-source = <1>; /* 1.8V */ + input-disable; + output-enable; + }; +}; + &qupv3_0 { status = "okay"; }; From patchwork Wed Jul 10 17:05:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729504 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA9CC195FF0 for ; Wed, 10 Jul 2024 17:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631122; cv=none; b=s+UBafGL1AOb7ToT2RNdpbBg2HCVsVBcaCkRIE6Vsh8wADagZYFylh2OmMxdPZxq1yzH2jy42xUu+LTLBpyTa3RkQRi6LIfnxSfFrRHb2dZXaiDHva5bOV0GxEAedHIqtTR2E6YbrkFdHrrRVsvCW2uXTBfGaKnaOnwzntryOHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720631122; c=relaxed/simple; bh=qR1uns0P44537MoqBjAHf1EyiKDwg3hxEEorjfsnBX8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bwWx4L6PhBj/gUJdagIENprbBFpYdnpD9nz0fR/3vqWfUfCtCvmF0DlZHHYN7HoFZfXKGMZGeawUBeKJGHNaFQS0vwoXdimpl7g8wTvKrgGNKlacKGaCI4QqLgh44AtDR1rueJuOetpWXn+JgnZN4b5jHTNP8sjWsDZVYbVemT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ghpt6v2u; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ghpt6v2u" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-367a464e200so3506221f8f.2 for ; Wed, 10 Jul 2024 10:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631119; x=1721235919; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qJL9ctqEQ6EbrQ1caBlXUSKz2PPn/p138eO0sdvXuFQ=; b=ghpt6v2uCKCccrj5MSnJMi4VyrCY7dmJIm3O2xQP3o0wf9kvp+O9Pr4+B66Ko6bwNq wnlSSWc5wxDVmRYk6qQF8BAirQrreim5cjj6Eaq8Vjn/YH9hjjfw/N9DWtto2268qLYs TXaVUa8Pwl8wqS6iUuCFDzX7NYcRfp29mKbQFQM2vRT1cOXZprIAsyOnLlkf6jXJqO9E 8JZqdEznAgQr2XZEX6KzAoy8XrPSDCbNZC3pP/jIDU3ZumzD16t4y5oPtqkbqgdxpUrD Xfr9+Bc1x6wvZBdwMdz2Wfs1MyfALsyjLaAoAwiiQ1gOADaFrBC9IYOmijTZyAmiyvO7 ZfYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631119; x=1721235919; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qJL9ctqEQ6EbrQ1caBlXUSKz2PPn/p138eO0sdvXuFQ=; b=Wv5GzSNWEc3ewXFXwp4Q/z9wMMmxAaxYt+I4LaVJkE+iefqbBpiwNG+2MgFtWHEsKj 2vX3CxVAJ6i3zOwB3zXcx3fpdk0H8vHz6Sh4cORL598ea4OyBE6TcWG4XUbQtMSFgA7M h3rhIbZl8nFa2QGVsqwUhGzSlAIyzYSEaQwBja/GPrW3ZX79n1Dqo4QwXiorwBa7z37W HNCins2D4ndX4v3hXJVCDygHXbEZK2D2sMuSBOoRyn1iFYmsJdBmZudfGJW3FpNYfLQA gZWKRMsSo9FkdfvF58bzPHksMRlz1pWYSfo40LUjFmWGkiSQh3RP0MC03x8dpQgetHMV dRkA== X-Forwarded-Encrypted: i=1; AJvYcCUR9xApGlcIYP+iUC4SlukV6q373K47Z17duxvpeZHiAHykLuW6jVkAu0P1YZubTLA9Gd1WPxf6nwVpruahAO6R2b4qJ4WRSzfHgli48A== X-Gm-Message-State: AOJu0YxRRjleVPz+vEeR3A0af+4eDc0zLHiZWdMPzIdotJKKKu5Te6Qa 0y+IymF7NoO7FJ2NghjKB3kPpaSAQTBIi1bFSsDhKBYV/jiQa9IhtYeCZVLPhgc= X-Google-Smtp-Source: AGHT+IH53Sy5DifFmLWeIWcstw3PzJyB9vgs2HFmeKb0z3bxjT4/dpNjOk8wqX3EUyluYvb65bRiiw== X-Received: by 2002:a5d:4811:0:b0:367:8a3e:c127 with SMTP id ffacd0b85a97d-367cead9253mr4193011f8f.63.1720631119088; Wed, 10 Jul 2024 10:05:19 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:18 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:05:01 +0200 Subject: [PATCH 5/5] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-5-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5c9fcf9ad395..9572c337ec29 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -889,6 +889,7 @@ CONFIG_DRM_PANEL_KHADAS_TS050=m CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=m CONFIG_DRM_PANEL_NOVATEK_NT36672E=m CONFIG_DRM_PANEL_RAYDIUM_RM67191=m +CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=m CONFIG_DRM_PANEL_SITRONIX_ST7703=m CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=m CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m