From patchwork Wed Jul 10 17:04:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74E78C3DA47 for ; Wed, 10 Jul 2024 17:05:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC92610E846; Wed, 10 Jul 2024 17:05:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="pbyVmnPy"; dkim-atps=neutral Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A26610E838 for ; Wed, 10 Jul 2024 17:05:17 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3678f36f154so3457862f8f.2 for ; Wed, 10 Jul 2024 10:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631116; x=1721235916; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ri1KrrJv5lGlLAnLFws19LhHfpuP+FO80ojRQ99yShw=; b=pbyVmnPysOuL1ASEtzbMkXQxOB8ilLNyVcVIUHgRp2vOumKUIFmpN24gPWcdgwxekb 7N5mTcSWpzgyX6Xmo4/5XxiN9vagp57NIZ3Ar7MI1UMzxndTg2eKKA4y/AFrVs3G3mhz AXQXM2IvW/zA8upmj6SAfJUzeYacQh2lTfgtf17KL9l5/+48MQ7wL2en+xZxYFiCZlaC +FUqeqXFsUZZWqArE7SwXTfaQvTGQr16de2USKuIhgH9uboaXUDCPRiFB014dR7nckg/ /vPvpCooeBBjQSkDAaOqECj7gkHA/Pif47Iz8KF9M4UUH9cyPZtqbSnyMWSlTNv04SG+ HBIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631116; x=1721235916; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ri1KrrJv5lGlLAnLFws19LhHfpuP+FO80ojRQ99yShw=; b=LucMnFQ8YUELSDIS67d9N7jWw92DJY4K2o+aOjsu0HT7YogvxVu4GrD9h9wp426MBY 46oSzrqC34eOwjbXw+MQ3txiIUAR6CEfnILtuHT51ghZma9Zs3yICRiQmSvu6BQn6RQ8 OG0wlZA7h4VGWRAlasr6s5XjE3QvKF/2MLVd61agtJI9/k1pg4eBE90mHn3DPV2L6Dr2 Jfd/DmpeCpUQcJkbcIerCqJg8i6sp/wD8cEnsZI+SLK/6ozJwJzDyQoN67uIJAaIAons epIDntKd2v6dgXiN9WVP/lOZerUDxi5sij93vZzo4ltw2NdroA2idoJUFvnfuxSpr5vU tX/Q== X-Forwarded-Encrypted: i=1; AJvYcCUB2CdlG842duqxixxsHf+WPcUdcAuOM45J4egVfaUMkSMsWwkIQmuLo5nJiZ6DUQJWivEi4mQ4zAQa3shSRVHoHEnFvqb4wAfUl3WJjjU2 X-Gm-Message-State: AOJu0Yy+LQwbLo75Tfn13tCXTYB/yDv6wPsl8JRbdD1vz7NBwYMssJc3 /3YuTRW1WDc3kbTn9Z8TCHMpn3F3ZspjlAd6UUakQGwMYbGS3MMXp4FWcklP/HI= X-Google-Smtp-Source: AGHT+IG2I2vfs2A9BrUdEREFeLsTLIRYJLTlw8D0se40K1gnpRKxO6FDo/ods9+emAorOvUndvejzA== X-Received: by 2002:adf:978f:0:b0:366:e9f3:c242 with SMTP id ffacd0b85a97d-367cea46887mr3987846f8f.12.1720631115960; Wed, 10 Jul 2024 10:05:15 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:15 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:57 +0200 Subject: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01 MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-1-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the existing ATNA33XC20 panel, just with a larger resolution and size. Add a new "samsung,atna45af01" compatible to describe this panel in the DT. Signed-off-by: Stephan Gerhold Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml index 765ca155c83a..d668e8d0d296 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml @@ -14,7 +14,11 @@ allOf: properties: compatible: - const: samsung,atna33xc20 + enum: + # Samsung 13.3" FHD (1920x1080 pixels) eDP AMOLED panel + - samsung,atna33xc20 + # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel + - samsung,atna45af01 enable-gpios: true port: true From patchwork Wed Jul 10 17:04:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729506 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B6B2C3DA41 for ; Wed, 10 Jul 2024 17:05:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADB4B10E29B; Wed, 10 Jul 2024 17:05:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="xUW6T/7a"; dkim-atps=neutral Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A20D10E83D for ; Wed, 10 Jul 2024 17:05:18 +0000 (UTC) Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3679df4cb4cso21611f8f.0 for ; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631117; x=1721235917; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/g1Yb1+vfOCpHonxF+Jqbu5p5cwpmV8OmQtPa+jVmyk=; b=xUW6T/7atPChn8TJeWOFBHVbJyoBjcyLccKghMIWUwa7fYrZ76nVDHrOvhEaoZ3O4G 8rQffZ9qi+icqHUS0TOqfYZ+SIQF0si2lXvgvw7ryGIwaivoMnsGk6MMRL2wPaH5mIQH G2OYBp4CW2IXbo97PtpUYkjqPO630KvxUa+xHff3WqfCiyVTK3TZxYJK9XIJaCkIWHCh ujAjCaUptjE0kT73hHqBscsAed6ETiCO6XFv2c1Lo2mTaKfue8U0QmMmzFVAlq4O5Gaa X1IrFoNiLVJ+BWv6ab/BWceukD/zOHc+Wvt5uCKXuzPtave1CcOhIi1Vn0H3BJioTrNF aLyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631117; x=1721235917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/g1Yb1+vfOCpHonxF+Jqbu5p5cwpmV8OmQtPa+jVmyk=; b=l+JH4l7aK79fMGm66/cDIGcY3V/Drz3N9HDn8vnnB9UFrt9lZlWZrfnbTftXepGVxO BDBntxWcBfxqn1j7tMADzG7ar1F2J5+IR71Bkb9HOBzkFHTGFMJL+Adw9/nS7zcdQ/OJ 0mLL5xCKsaJ2PXQ8blzhPFOF4H/ZaoQ/JBcMXiwPHtpTkCWbil9m6nvns6du07mjIkqs MxFlGvyUpwRGx9rGS0pG7MR9xe4TKtpxc1SG2z3eQ6RAOHheSVg1FVEc4ArBuY9H66dp 2ZvwRoNYnP9dSN0h+Xx6PYnxTwWd2yCiprSXdX9gU97bEhkX3lDHfwIkyJ4nHgo2OQ8g klkg== X-Forwarded-Encrypted: i=1; AJvYcCU1pmwdGwIM3yQT6ifk2qbVHo8xKBtLPYKo5Gbp1OgAhyMGlH0jxYQzq6NTBemzTcaCe1LnySExz8qsYuayFJjQ2bFDp3OsqSLpGc3TflZv X-Gm-Message-State: AOJu0YyMEtTSuCNgeAP5VAPafQWsLt95ujn3ko8PTqYe3zy37uVDtIfK /ksDean8B1nLndQ/heC5mbuMzio0SJ8PtMt7IshwuBUu79loeJdY/9wlO/oPmr0= X-Google-Smtp-Source: AGHT+IHrRXiCsidR4X+LasiuthOFj9ICKMJe5oQgZWQE5LzqBbT6SBTjtUxtWEVsNWAdJXaa53sXHw== X-Received: by 2002:adf:e0d0:0:b0:360:8c88:ab82 with SMTP id ffacd0b85a97d-367f04de8e6mr260014f8f.30.1720631116954; Wed, 10 Jul 2024 10:05:16 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:16 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:58 +0200 Subject: [PATCH 2/5] drm/panel: samsung-atna33xc20: Add compatible for ATNA45AF01 MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-2-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The Samsung ATNA45AF01 panel needs exactly the same non-standard power sequence as the Samsung ATNA33XC20 panel for backlight to work properly. Add the new "samsung,atna45af01" compatible to the driver to make it handle these panels as well. While ATNA45AF01 would also work with "samsung,atna33xc20" as a fallback compatible, the original submission of the compatible in commit 4bfe6c8f7c23 ("drm/panel-simple: Add Samsung ATNA33XC20") had the timings and resolution hardcoded. These would not work for ATNA45AF01. Signed-off-by: Stephan Gerhold --- drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c index 9a482a744b8c..fd56fd02df87 100644 --- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c +++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c @@ -333,6 +333,7 @@ static void atana33xc20_remove(struct dp_aux_ep_device *aux_ep) static const struct of_device_id atana33xc20_dt_match[] = { { .compatible = "samsung,atna33xc20", }, + { .compatible = "samsung,atna45af01", }, { /* sentinal */ } }; MODULE_DEVICE_TABLE(of, atana33xc20_dt_match); From patchwork Wed Jul 10 17:04:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729507 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D826C3DA42 for ; Wed, 10 Jul 2024 17:05:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F24010E83D; Wed, 10 Jul 2024 17:05:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="aKR4b3sq"; dkim-atps=neutral Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AD8D10E83D for ; Wed, 10 Jul 2024 17:05:19 +0000 (UTC) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4266f535e82so16275555e9.1 for ; Wed, 10 Jul 2024 10:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631117; x=1721235917; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S4NkoAIT77VT3upOcUYDgNo3eUGfA37eNUjC42fZIhc=; b=aKR4b3sqWs/ZSyTRE7BnDyKjPgSr/4JHvEc+wUEE5Zizx7tCDCXAgNlyF+dKS6GvVd VKq8x4RFIdeArqlp8IkdNYCkHqYHRCypPegIBOzISI/vi55+wcLZC2zNj6N8sg8Ws7oq Wat/u3pXuEIDs1LDx3ZN027/FQUWXGagg0SJLOwH7nBYhL1l9oTlzba/+hVReKsTi7RF BWB7rPAFcd23dArdlYImtHrPzw0yIdLxVX0ydyUhKUtC9JDc39zo2YftDP0/I6PBr3l9 5ugpwUyLEBzkVZq5NgNqwRHVLEbp/WXaqaz2MMcYq5aivQGRxNy51KKV0eZ28wcVnYtR dOCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631117; x=1721235917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S4NkoAIT77VT3upOcUYDgNo3eUGfA37eNUjC42fZIhc=; b=pz3P1f6YBndJvJg6KZsa4JDg0hCSc3bwhmqNfV/MdFUSDxQezD9/unBdvb+3NfaHmX Aes+Ndsrkx3JayjNmpA9aasaOMgEiZ4pXk6/CFy2prHsT0rcu2u+53YSo7upZ7fhfLzk Vjetm9E5Gn7NVlHZ/eN+kDKZF8Lda71rCME1WpYLIFyDfHN1/Es//G/Hnj6j0+W3bi7L GvDPdndguc1uTqTL8kyLUjpErqZ2vUKvkYvHPvJiTtyA5/czhDhRDNCu2EDp/IdzKWaU SYeHsZMLwHtJ4vhDvR7IJfPsGbdlLN/AgsXG6zIscmUIndS0eN+j6U0zXQc5uvfBM//t Hpcw== X-Forwarded-Encrypted: i=1; AJvYcCWDXArNawY01GpUBj6+Ks35C/8EUQ8+YZiVfXpu4UTYWomh3MRqr15oEGfNm+ju56tWW2dnXL9iFTedh/fvrIwK2kHrIL+hHlN6QdcKQniM X-Gm-Message-State: AOJu0YwTjaS/cFx3VCPs7EQ/Dn0gH8jaZk+l2KOLpdpVXvzxTuiiONq9 q+zWuYIs/TMTk3rZDOzxGxc3iKXLvfo7KjX0cSj2yi9d9I0qlXPlLvt3fXZ2KtFxusLk7MneasD T7e353A== X-Google-Smtp-Source: AGHT+IGkLUFSUmZ5ECS3GHwAe+MqsROrwZrfQE/I+tdJdPvxCPyYlWVxShiAik5dzVjABnYcvtZ7ZQ== X-Received: by 2002:a05:600c:896:b0:426:5216:3254 with SMTP id 5b1f17b1804b1-426708f1eebmr46866985e9.32.1720631117621; Wed, 10 Jul 2024 10:05:17 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:17 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:04:59 +0200 Subject: [PATCH 3/5] Revert "drm/panel-edp: Add SDC ATNA45AF01" MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-3-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only partially in that configuration: It works after boot but once the screen gets disabled it does not turn on again until after reboot. It behaves the same way with the default "conservative" timings, so we might as well drop the configuration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Signed-off-by: Stephan Gerhold Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 3a574a9b46e7..d2d682385e89 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), From patchwork Wed Jul 10 17:05:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729508 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71B98C3DA41 for ; Wed, 10 Jul 2024 17:05:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F22410E2A9; Wed, 10 Jul 2024 17:05:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="JJLhvZTE"; dkim-atps=neutral Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5833D10E2A9 for ; Wed, 10 Jul 2024 17:05:20 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52e976208f8so7221547e87.2 for ; Wed, 10 Jul 2024 10:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631118; x=1721235918; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ejuDXxzDzIH7zcxYcOPWRk3uTUuzsIoqRWToUCtONmU=; b=JJLhvZTEcTjlDA8tdOMgibjopFTRSuMUU5j/aLOXsGF5ovJjSdXpRDdEH3lfateAw3 BgWejUOMx30SCNUfPT56cftvb62lKnt31yLfP9qflZFiFIFSmJs6eSFSYB8jXMjOTaoi vgphPmuPUS1mFQE0ObbwTGIw+GTPM2hpzwAAtQw/fiYiLZEV7JdvjmjMFzWO+6BWNJIN kFjr77TW8nBqjCO3HEoDPwSHDR5ZIL5b9JZfDwX17bsyLd09+ypszKuwdXunWA8prHyw TQ56az5jJAHORHEoOGI7F+txGAf/a5IViUyZfchhfJzDndOFms/Qt+PnMnxWbZPZvpPs qpFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631118; x=1721235918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ejuDXxzDzIH7zcxYcOPWRk3uTUuzsIoqRWToUCtONmU=; b=j5+K59jSSk5vdwRlQAyJ4bSoClsmACkywljTgHXecSvGAE+JFq5ZgpycECzsxe3p8A eQGZZ4CNHXoAR0dtkTZOetJ7HyO8tRjfNj/6NglB7kKBwPiJaMr/gLzSZmInup4lMEPL nn3H8qt1lxWJ6tNuvML/qFsEX2o4FHdLe5nnYlRbr5OeVNv/XNecpzYhf8a6B/arCi18 Hz0KkeTan2fSQI+Mb+iCfxL+aWn33VOe/iD2+WEhlj+OCyFbaFNtw009xobA8C8LvAwR NHtS0Y7imCMhphMPxbhZ4fDYZ9zHg1xlEscq2SHAWkMzqRumAfQwSncsiSXGkgsKhzhW oipA== X-Forwarded-Encrypted: i=1; AJvYcCVRp9nxXiVt7AwJVtA/EtFzZDKRq3T2SD+s7BFifuN0ehgqaoaEnsyPGBqmYdq4Zofg180h4lqTgHrRG2t2P4JQkElDnTPLnUSh0gBMsClr X-Gm-Message-State: AOJu0Yy+fZQ+sa9PGffUsLADwOH1oxbx4pcrdWm0dapo08phQDPUuDVx Fu952jQ3vpB6z0HuRKnSZdP3GOEpjoEQ3PAMmHjX0+fw+vFmLjwhzPjuo+NzxX4= X-Google-Smtp-Source: AGHT+IEdzDMqSpFrgPIKMoDSkhiU2e+ql+AL5vU9wurvK32RxWDhsTOWJlgEkSrVCpO+E3+Am+YAjQ== X-Received: by 2002:ac2:4281:0:b0:52e:9471:e533 with SMTP id 2adb3069b0e04-52eb99d5fb9mr3803124e87.66.1720631118372; Wed, 10 Jul 2024 10:05:18 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:18 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:05:00 +0200 Subject: [PATCH 4/5] arm64: dts: qcom: x1e80100-crd: Fix backlight MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-4-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. Switch the panel in the DT to the new compatible and make two more changes to make it work correctly: 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and enable-gpios in the DT). 2. Drop the regulator-always-on for the panel regulator. The panel does not seem to power off properly if the regulator stays on. Signed-off-by: Stephan Gerhold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index 6152bcd0bc1f..7d6800dd9b8a 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -268,7 +268,6 @@ vreg_edp_3p3: regulator-edp-3p3 { pinctrl-0 = <&edp_reg_en>; pinctrl-names = "default"; - regulator-always-on; regulator-boot-on; }; @@ -724,9 +723,13 @@ &mdss_dp3 { aux-bus { panel { - compatible = "edp-panel"; + compatible = "samsung,atna45af01"; + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; power-supply = <&vreg_edp_3p3>; + pinctrl-0 = <&edp_bl_en>; + pinctrl-names = "default"; + port { edp_panel_in: endpoint { remote-endpoint = <&mdss_dp3_out>; @@ -785,6 +788,16 @@ &pcie6a_phy { status = "okay"; }; +&pmc8380_3_gpios { + edp_bl_en: edp-bl-en-state { + pins = "gpio4"; + function = "normal"; + power-source = <1>; /* 1.8V */ + input-disable; + output-enable; + }; +}; + &qupv3_0 { status = "okay"; }; From patchwork Wed Jul 10 17:05:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13729510 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8591DC3DA4A for ; Wed, 10 Jul 2024 17:05:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC06310E847; Wed, 10 Jul 2024 17:05:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="fIZa39x7"; dkim-atps=neutral Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBB1A10E2A9 for ; Wed, 10 Jul 2024 17:05:20 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-367975543a8so4403415f8f.3 for ; Wed, 10 Jul 2024 10:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720631119; x=1721235919; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qJL9ctqEQ6EbrQ1caBlXUSKz2PPn/p138eO0sdvXuFQ=; b=fIZa39x7bs/ncEZiqdkDA6dMOkFTQqlTERytUrLBA6WhzNPE3XfzuYpznOO7Uw6FFP GrYrjlGRdfdklB4715DsfNyj+i50j4VwgHKwF5kISgYVwaFsaGqGiny1BO97po0YrDGI DBzkpbV7TDy+WzBSdGi6M/qV6JRub7olK2djiy4//gtfcE0uEegVor8LdUIRas6gbIMi UT9fyfvy6LxMqlN5K378y8N1ZEeUZtn6HevDKPBpzMlx7hbhNathWaQOVwIpKYXx9D1p EayixaqXf8Dkn7MfCrwCtPLfN3KwSEyCgnj5v/5w9fpQ6C6KbwkfGiFJoIMprsb+syyX RhTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720631119; x=1721235919; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qJL9ctqEQ6EbrQ1caBlXUSKz2PPn/p138eO0sdvXuFQ=; b=sLmVIvmGugO68D2jOTYkFGFc30eVUwrZrJTjVa0URhbasE6bNEgQDmuU2RcBFjLrqv 8Ck2n4V1DBSknKS9wQPgS9AVxtBxZ5LPj4oApSO8JRR2tPgqgbYFuSTBwEiw962Nap/0 WBUllOEd/r+anKmfb/llKeU/Vt8Zgyzia7+Czp8LPHvFYfQQGJDzFAXPouVi3/ZzsnaM XP9VD6Dl7DzN10eXn/vzk4KnM/cZ8CR9aT61lVwaL2VPhqrlW1GH8JrL0enNp22Y05FB DjTHkyV2lwhMlHrbibNJ1RWilEry8BiSHt0xEMkzrFt9CLnrh9/hVUAn5AD3hnD0uzPe YQqA== X-Forwarded-Encrypted: i=1; AJvYcCU3XCBH5kx+IXbtKuuXTD+oODmzcGq49YS4klyIeZjlEDTeCxbtS5Xc2Ej1vO5m1lnPzdAqhmkSBYE50FJFBWpqIW9vDZVFRNAm+0KX4tJ8 X-Gm-Message-State: AOJu0YwhUvz0UB3koXx+9dAQUTZ8g2qgcuM2I9BuXSWPTbQlmNZ4wzB7 c0e/FUiTcGKZuslNzQza2LiwVcenN+hL3km7aR4ME+c0s/WajZg5MoaOiLjGAI0= X-Google-Smtp-Source: AGHT+IH53Sy5DifFmLWeIWcstw3PzJyB9vgs2HFmeKb0z3bxjT4/dpNjOk8wqX3EUyluYvb65bRiiw== X-Received: by 2002:a5d:4811:0:b0:367:8a3e:c127 with SMTP id ffacd0b85a97d-367cead9253mr4193011f8f.63.1720631119088; Wed, 10 Jul 2024 10:05:19 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:65e6:93ca:5f80:ea9b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7dedfsm5838446f8f.24.2024.07.10.10.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 10:05:18 -0700 (PDT) From: Stephan Gerhold Date: Wed, 10 Jul 2024 19:05:01 +0200 Subject: [PATCH 5/5] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 MIME-Version: 1.0 Message-Id: <20240710-x1e80100-crd-backlight-v1-5-eb242311a23e@linaro.org> References: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> In-Reply-To: <20240710-x1e80100-crd-backlight-v1-0-eb242311a23e@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5c9fcf9ad395..9572c337ec29 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -889,6 +889,7 @@ CONFIG_DRM_PANEL_KHADAS_TS050=m CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=m CONFIG_DRM_PANEL_NOVATEK_NT36672E=m CONFIG_DRM_PANEL_RAYDIUM_RM67191=m +CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=m CONFIG_DRM_PANEL_SITRONIX_ST7703=m CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=m CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m