From patchwork Fri Jul 12 16:45:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13731974 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAD78C2BD09 for ; Fri, 12 Jul 2024 16:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=M8hQBMOCC88TnMaMEC29979qpSY4qzsa36avP/MMKqk=; b=nGgpIYWGK0Kw19 5A16dS4AF9EKVDXbDiWdTQqStGzSK0pIlduWGJevPa9ywum94M2O2Q/VMSD3w2qaidJJR7OTWX11Z rxwobCrLyyG2ikpllYFeJjQAvK9+feEtYLRZpVcoBHHjtnxrCaAc4uUj/zlxDEMLeO+y0/2wtZwfa PD5smW+HOckJUXZmIsldMniElNeeKcsYJagjkzPqnxuDqXEO7hBcIicquDzaH2GqlEVNg0J2d7jTl CQ1Z7SqsHSSas6c8DVRfunGzsgboZ6TDkrRihCRJxUMpnsjClyagIItBUVRhC1F24jtcnxzLdlh8+ aFWm92fCbdOwiFZqXETQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSJQP-00000000imS-37G1; Fri, 12 Jul 2024 16:47:13 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSJPr-00000000ibh-3iLJ; Fri, 12 Jul 2024 16:46:41 +0000 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-75c3afd7a50so1613099a12.2; Fri, 12 Jul 2024 09:46:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720802798; x=1721407598; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=78IepMnmU/3kKOZs1MFUObqCBdnDJ+SvmFkmQ0mtZdQ=; b=Au7Do9ZSK5Yf5nNZI4GRYOVcU2hK+n0gkuzoWKQgl0pvkgmunUZGOdx/8qSro6dqO+ G8j3qKdquTPoKOXnpmltSF70VJC+IQJrUi1EPfMqZB71/Rf3/G+qpbFFZH9h+b7+lGpd SwdBNYgHbpPgi5RfNaUjb4GxTlYGsaUrBiiwowtHXvHE0dNAzn4q/rJw98H6I6Hy2QKp JLLrLl2TSJAZaxFOTIX4/dEyPdyBESLLDZYRMpzprn3bn7L8wihdVSZVCHb0Tlh4T3iq PZZhoJXcRrkmOJY9HXNCxFh+i3SkAn8qkplsRPxYY1Ge+6g7j+lvAD/RoDp0ybMrChSh +oyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720802798; x=1721407598; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=78IepMnmU/3kKOZs1MFUObqCBdnDJ+SvmFkmQ0mtZdQ=; b=L6/RXeXM1Jd8bh2lhHfmuHNoGk1mzzN1vgEFBdqM15+TO2VZ0f22lPwgGAu7gNEh2U 1wGAvYejgxTaWE3z/cTofuJufctVpHFUwwo+7BUAkZ7DF8yCoKnGexcG/Q5Q/RfgcE3J 9I6nWAWqtyO12epvgncek5siNoj265dUIGGO2rpcLXvOZFGLNrOgXzew1Zb1hKY5+UY3 j2STusp+rTIxMXUBErPpkE9CJMuhymJEbN9O1c4COtZfP/nsZGP86WojIiYi9jr+cTjD OYsUHlFgqrZOfqouDZpVtCbYsRd+eCrvkfhdxrLKX+Cm9zdcsUbgGPqJjldSoeHQccFg 7WpQ== X-Forwarded-Encrypted: i=1; AJvYcCWZ4BCutDa9ikq1mu+3N7uz4nhVxmmhiIy2o/o05/mGwqbDqTXePOO1FEJNHDAYWJ9adSNnGvoshpxM41g5lQwK211vUuZPVf6HZxzKN61nOKeYe3jlvddkka0XaqlN/yFD9aIAmZwdberyIGotXArqWJpbPp9WbrA= X-Gm-Message-State: AOJu0Yx6E++dCDZFwYDSU/X7EZUg6mezHyKaxIkmcMd47DRBWHoz+AIJ +PGVTgiRP4uAenlXPV6+UTlUnExKn/EDwnMDdNcf3UjPHJg4+q7O X-Google-Smtp-Source: AGHT+IFmaeWr7wFpB8oCJawosait80Yrc0MOzrvGc/xTpX5SwheOPSjGoN3sw7j+RsF+hUMJx6wSrg== X-Received: by 2002:a05:6a20:258f:b0:1c0:d9c9:64f9 with SMTP id adf61e73a8af0-1c298243af3mr13027593637.36.1720802798295; Fri, 12 Jul 2024 09:46:38 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cacd65a663sm1765436a91.40.2024.07.12.09.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jul 2024 09:46:37 -0700 (PDT) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Anand Moon , Jonas Karlman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH-next v3 1/3] arm64: dts: rockchip: Add missing pinctrl for PCIe30x4 node Date: Fri, 12 Jul 2024 22:15:49 +0530 Message-ID: <20240712164554.1763-1-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_094639_950826_87F974AF X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Add missing pinctrl settings for PCIe 3.0 x4 clock request and wake signals. Each component of PCIe communication have the following control signals: PERST, WAKE, CLKREQ, and REFCLK. These signals work to generate high-speed signals and communicate with other PCIe devices. Used by root complex to endpoint depending on the power state. PERST is referred to as a fundamental reset. PERST should be held low until all the power rails in the system and the reference clock are stable. A transition from low to high in this signal usually indicates the beginning of link initialization. WAKE signal is an active-low signal that is used to return the PCIe interface to an active state when in a low-power state. CLKREQ signal is also an active-low signal and is used to request the reference clock. Rename node from 'pcie3' to 'pcie30x4' to align with schematic nomenclature. Signed-off-by: Anand Moon --- V3: use pinctrl local to board V2: Update the commit messge to describe the changs. use pinctl group as its pre define in pinctrl dtsi --- .../arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index 966bbc582d89..721e87a3a464 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts @@ -338,7 +338,7 @@ &pcie30phy { &pcie3x4 { pinctrl-names = "default"; - pinctrl-0 = <&pcie3_rst>; + pinctrl-0 = <&pcie30x4_pins>; reset-gpios = <&gpio4 RK_PB6 GPIO_ACTIVE_HIGH>; vpcie3v3-supply = <&vcc3v3_pcie30>; status = "okay"; @@ -377,14 +377,20 @@ pcie2_2_rst: pcie2-2-rst { }; }; - pcie3 { - pcie3_rst: pcie3-rst { - rockchip,pins = <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; - }; - + pcie30x4 { pcie3_vcc3v3_en: pcie3-vcc3v3-en { rockchip,pins = <1 RK_PA4 RK_FUNC_GPIO &pcfg_pull_none>; }; + + pcie30x4_pins: pcie30x4-pins { + rockchip,pins = + /* PCIE30X4_CLKREQn_M1_L */ + <4 RK_PB4 4 &pcfg_pull_up>, + /* PCIE30X4_PERSTn_M1_L */ + <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_down>, + /* PCIE30X4_WAKEn_M1_L */ + <4 RK_PB5 4 &pcfg_pull_down>; + }; }; usb { From patchwork Fri Jul 12 16:45:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13731975 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90C72C2BD09 for ; Fri, 12 Jul 2024 16:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JBOw/8VYOOmpO1mfWGbmFvIDZFBeBPjGeXlUYOrVC+U=; b=qJiMkBSSJpRpgC QgG4gmrxY0AXxIEX5nZtwCvd5X482EMzBb3Degkd38IYYgxSa0b7wyJDzBdS5enTewezbkbRvJmWm y/EgxB13ZWB7YZKSobqWtfgLYd1AFLC7TVQqwc4S6LcCI138vdIbsvEcGtndP/oU6VLURdkhKsV4o ixBBUNTXeyYsZVApYKY3pJpp/HGewM1yDJEH7CCxC3s3c+yYy4oIKWu+cacOLaBjifkuF4fvlrsbU BsHzAfm4xdD5PmLV8hw47mPaikLrrrUzCI244VR5WJwcwyUT/2zA3LW6AQwhvbyBAJN5UBA0TcxEF 88Se6kt2o2Ki37PVepzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSJQh-00000000ix3-2rIp; Fri, 12 Jul 2024 16:47:31 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSJPv-00000000idG-4500; Fri, 12 Jul 2024 16:46:45 +0000 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-71871d5e087so1573926a12.1; Fri, 12 Jul 2024 09:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720802803; x=1721407603; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R0p6c631FLQWoVkBf59WViemKYmG2YbdNp5MW1ulJ3U=; b=EA43wDuFSxTXwwRCP0mNFEAeZLzVyuuR6L/q/wT1TwdNXjMToDwzsbxu6bjaIZlaTz 7hP6fnv7eXrDtdGzfbWKe8XiRtvetjkEMAIpBtpFBqcIwVtb0HL4ABCAiXw41AmLqqCy j44CvRdsPZYLHNoAFdwMY3ZcCrCMmtfMXQdTEjkvQjcta4rCtRfVfFesH7J0qlFa0HVV 2ANIeXDIDoC90rsGzBvgBTWC6jnDDimLILE0ZbgLYny/QWsnzpS5rpdagDhlfUFMONxn l3LKk8Jk1BvRFLmrlsrw8ceabueq7O5vVL72rUzCNgA5jJgK/u9YPELd8u9KqGNNf+F0 HfcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720802803; x=1721407603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R0p6c631FLQWoVkBf59WViemKYmG2YbdNp5MW1ulJ3U=; b=hPStPB3XskZ0BC5dx+YZ7C3Ps8Qatxr8SziiEBVLfBHUD1JM7WXxucrBKuqVJMV8Vy uZlHgri6SIhG0AvN2T45zPnzMZ2vHgtrzVG3Uyvk8PWoo2FyKWf2PY5OA1IVtVqzjkag Dk8efPjRRmh4yp6UoanjKrEqOWV1hLYimeLnHbmd7ibs4Xg7/WcSma6krkw75Fs0NLxU uHGcU/SBAhySZdDQVMyX4GSYlEizDMyqnm1+9t064nxHfLIetb33qtirybtoBWMX11hD H1GVEbV4Sv5MqCYUIQm6H9iWWYUSX9OF7G52/fys395RVulR5EyjXOR2s1OT7ix7WfDI U6og== X-Forwarded-Encrypted: i=1; AJvYcCVpG0ObFXILTFeduX6tD3AlWEw4yb2WsH1doLag+RfqZZKK2CnIjP7fIZEkvKt/LcNTM6lkNVp8Uaoqlt7/jKC4TI4DgWJWeKxsxa90O9bZVg4jFnSr9NR/PBjMXF6FmwDEmaoyVQYi9U3gl3wZIAyspsirgfAWWnM= X-Gm-Message-State: AOJu0YzZD4jxgQcLXOlbYwpn7UwSS9oJ03uEZ/hXD6iGotgo0Ul7YcMG MQDBYwGB9rmOf4EhPzGfSVvPQPVE7K+OhX/zOmCs47/zfGOj4ro2 X-Google-Smtp-Source: AGHT+IFDNxRREJPmJRLCYo6XCextG0QrJvySxgtmRlqYBjRTxLmp/vQCGH+/Vxt91Db5JSs0j42PXQ== X-Received: by 2002:a05:6a21:999d:b0:1c2:a0b2:e69 with SMTP id adf61e73a8af0-1c2a0b2110bmr12269918637.33.1720802802998; Fri, 12 Jul 2024 09:46:42 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cacd65a663sm1765436a91.40.2024.07.12.09.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jul 2024 09:46:42 -0700 (PDT) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Anand Moon , Jonas Karlman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH-next v3 2/3] arm64: dts: rockchip: Add missing pinctrl for PCIe30x1 node Date: Fri, 12 Jul 2024 22:15:50 +0530 Message-ID: <20240712164554.1763-2-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240712164554.1763-1-linux.amoon@gmail.com> References: <20240712164554.1763-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_094644_033839_99DCD835 X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Add missing pinctrl settings for PCIe 3.0 x1 clock request and wake signals. Each component of PCIe communication have the following control signals: PERST, WAKE, CLKREQ, and REFCLK. These signals work to generate high-speed signals and communicate with other PCIe devices. Used by root complex to endpoint depending on the power state. PERST is referred to as a fundamental reset. PERST should be held low until all the power rails in the system and the reference clock are stable. A transition from low to high in this signal usually indicates the beginning of link initialization. WAKE signal is an active-low signal that is used to return the PCIe interface to an active state when in a low-power state. CLKREQ signal is also an active-low signal and is used to request the reference clock. Rename node from 'pcie2' to 'pcie30x1' to align with schematic nomenclature. Signed-off-by: Anand Moon --- .../arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index 721e87a3a464..c5ac233264fc 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts @@ -318,7 +318,7 @@ map2 { &pcie2x1l0 { pinctrl-names = "default"; - pinctrl-0 = <&pcie2_0_rst>; + pinctrl-0 = <&pcie30x1_pins>; reset-gpios = <&gpio4 RK_PA5 GPIO_ACTIVE_HIGH>; vpcie3v3-supply = <&vcc3v3_pcie2x1l0>; status = "okay"; @@ -364,16 +364,24 @@ hp_detect: hp-detect { }; pcie2 { - pcie2_0_rst: pcie2-0-rst { - rockchip,pins = <4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_none>; + pcie2_2_rst: pcie2-2-rst { + rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; }; + }; + pcie30x1 { pcie2_0_vcc3v3_en: pcie2-0-vcc-en { rockchip,pins = <1 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>; }; - pcie2_2_rst: pcie2-2-rst { - rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; + pcie30x1_pins: pcie30x1-pins { + rockchip,pins = + /* PCIE30x1_0_CLKREQn_M1_L */ + <4 RK_PA3 4 &pcfg_pull_down>, + /* PCIE30x1_0_PERSTn_M1_L */ + <4 RK_PA5 RK_FUNC_GPIO &pcfg_pull_down>, + /* PCIE30x1_0_WAKEn_M1_L */ + <4 RK_PA4 4 &pcfg_pull_down>; }; }; From patchwork Fri Jul 12 16:45:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 13731976 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5703C2BD09 for ; Fri, 12 Jul 2024 16:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dnNrnd6VTXN59yKjlZXfHBS26fdUu5FEKANWxp31qVY=; b=dWK4NsbefPw+CK YZOKrlAOIwlDe2cPl/kPqnHavLQq/21cnwWR9o5EUykqNVm492vkQwfpl5sDYYR3Bz9inE8RARuEg NlPt7p2SfRRds3/shrHJoInHLNB24bY/DarUOej1kmTwdO0avZyqQPYseC7dGeK16noDNUblKYSQb D/IeDjH/Uaj8PVv409dhnRn8PrmMVFddiaa0OmPA+AnzzKluKvWXwJjwjkWtnGTKFncMb3FCS83ME u9qIKwBXnGfHkVh14mq5IhQmQS0HUigsz/zPo4tfn/9E40DvFHwt+R6wCobMNdwot8tk7pmUKFtLg HXzM7mhrMau6JAidXIzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSJR0-00000000j7O-3ymh; Fri, 12 Jul 2024 16:47:50 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSJQ0-00000000ie5-1wYv; Fri, 12 Jul 2024 16:46:49 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2c5362c7c0bso1718724a91.1; Fri, 12 Jul 2024 09:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720802807; x=1721407607; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PlSTu8e9NEa7x8cqCEciuuE7yj+zz0dZw/tC3iuljOI=; b=MDnhtNeqqF9JwfytBV9Z/57I8y9mwI1QYSf90pF+ygobi94wmidnM0GJY4Nl32RXnE YCDikAoPf0XHDjRjH+yPSdZYoW+O98S2/VFqHPPRJJOEYtjK29C6IOFEgtKQZ88TON3S Pxn/XPflPr4SSvUR4ykp0oObBiNSmZTWa3D0gGF8sE7u9EUp6TWAbFsRXembfJlVu8ti 8gBSgLphN+dZyU1JWSyCfUtiZTmIAhLN83EQUeJlpZu4XIkWBWJrZDSpnzjDWSA7V5Vc AvEYZ8AwoGp+Xs81W3NqjTkwiB06OqxsYWj+G0/6zPwHqeHWxJA8Wm2YXyK3lALTlZYX +ipw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720802807; x=1721407607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PlSTu8e9NEa7x8cqCEciuuE7yj+zz0dZw/tC3iuljOI=; b=W0OG/kKUcvDYOBmbqk3RniB43zAMQqmk3WyVzrt8CBgc+9TST56oA0DYXABLax3PYI LnDdJH3t9FgC8GWoASlFbnnQPySE4yPe7awP7vktzshLRbAfcyuuRk1/n1FmUQ3QJ+ca FRPF9YsOkvEEjjR5f6PBo0PBYyIgye5AUP6zBs1RGwDV/L0RUkHR4x8pNfuU87xFPfLD F8HCOnCanKZqncmTQKvW7fY0YCW58e9tpGfNLAaCSRbqwzHWQVuuV181IvT8PBOMflmE 0M5gqM6PTeGHJKGsYdPgIHkWMlY7aOHsdJG837LiWYv0Ut7FDFVs5+h8XHvixDjG3XPy Vi5A== X-Forwarded-Encrypted: i=1; AJvYcCW5YhR16Bke3QzceXjwcYQ9hn6J6pddYM9x7SxEM2L/6eqYIMIpGPXF4tQpfl6GYyB/oRDvPP65XDCtFEEOFbdKn1cUjLBZzUPaXu2ruKViUNHIZ/yt7wcJ0xVxxQhsMsnvHJYE3GF/NpiDdVyBT/8s4wTRgYxXeHk= X-Gm-Message-State: AOJu0Yyi3zMxlmD+591UaQUUmBszcOPe3mWCcoqGKdRju9HbSR5qDMYb sKVmTOPherIW5DCfvN01u6M+fuzFCr4L9vIHzdXL0W4YKXAnsf7h X-Google-Smtp-Source: AGHT+IE3gd839oKFIr0D0QdBOBET0btxNgDgPKYQ9uzxuv19+FxgjT5x6cE0vXTyKc33JJRvBRpF1w== X-Received: by 2002:a17:90b:d85:b0:2c9:6b02:15ca with SMTP id 98e67ed59e1d1-2ca35d4b0f0mr9339931a91.39.1720802807357; Fri, 12 Jul 2024 09:46:47 -0700 (PDT) Received: from localhost.localdomain ([113.30.217.222]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2cacd65a663sm1765436a91.40.2024.07.12.09.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jul 2024 09:46:47 -0700 (PDT) From: Anand Moon To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Anand Moon , Jonas Karlman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH-next v3 3/3] arm64: dts: rockchip: Add missing pinctrl for PCIe20x1 node Date: Fri, 12 Jul 2024 22:15:51 +0530 Message-ID: <20240712164554.1763-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240712164554.1763-1-linux.amoon@gmail.com> References: <20240712164554.1763-1-linux.amoon@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_094648_523167_968E75BF X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Add missing pinctrl settings for PCIe 2.0 x1 clock request and wake signals. Each component of PCIe communication have the following control signals: PERST, WAKE, CLKREQ, and REFCLK. These signals work to generate high-speed signals and communicate with other PCIe devices. Used by root complex to endpoint depending on the power state. PERST is referred to as a fundamental reset. PERST should be held low until all the power rails in the system and the reference clock are stable. A transition from low to high in this signal usually indicates the beginning of link initialization. WAKE signal is an active-low signal that is used to return the PCIe interface to an active state when in a low-power state. CLKREQ signal is also an active-low signal and is used to request the reference clock. Rename node from 'pcie2' to 'pcie20x1' to align with schematic nomenclature. Signed-off-by: Anand Moon --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts index c5ac233264fc..a1e83546f1be 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts @@ -326,7 +326,7 @@ &pcie2x1l0 { &pcie2x1l2 { pinctrl-names = "default"; - pinctrl-0 = <&pcie2_2_rst>; + pinctrl-0 = <&pcie20x12_pins>; reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_HIGH>; vpcie3v3-supply = <&vcc3v3_pcie2x1l2>; status = "okay"; @@ -363,9 +363,15 @@ hp_detect: hp-detect { }; }; - pcie2 { - pcie2_2_rst: pcie2-2-rst { - rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; + pcie20x1 { + pcie20x12_pins: pcie20x12-pins { + rockchip,pins = + /* PCIE20_1_2_CLKREQn_M1_L */ + <3 RK_PC7 4 &pcfg_pull_up>, + /* PCIE_PERST_L */ + <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>, + /* PCIE20_1_2_WAKEn_M1_L */ + <3 RK_PD0 4 &pcfg_pull_up>; }; };