From patchwork Mon Jul 15 12:15:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13733377 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0792187357 for ; Mon, 15 Jul 2024 12:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045769; cv=none; b=YjC0kIQgYZIyuyzAK9+vlUaYvo1VcoroLny/PO3jnUlLSKUUBWbpKrTMinHBijAA7E3jrTzfB78etHztsA/mn1VOTzLUQZ6CJr1qsLAP3O3XRD7lbROyKSMrsJI1QnI3rkph4AWHB936rRtOk8U86wGDdmI6IFC36QJEkc1n6zg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045769; c=relaxed/simple; bh=5xxCslBz39cd9KCBn386k+DYETh3rATBhqlskCXMh/4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Qq6HPQMQ0hWW3exScefiy24APlNcueffiZmkV9/IdtbaPAy0lrUEkSwfx1A2QqDfsOgCj/kCwDR+FSZx/h8ZZPrgDW0ZA3bksPf7OVr0SELzaQ0/mCLQ4z8Gp/SA4ke9IMyvMgfO4jRA6Fgnt9BzoPLbTe7UrwDjrSXjSnoSUMc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=udJEA3t/; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="udJEA3t/" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-367a183df54so2825644f8f.2 for ; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045766; x=1721650566; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CwYPDTPYAwmjKmZ1/Gf11accW/fLFhZgeFXsYW2+ut4=; b=udJEA3t/couQkVT3Z443Rkb88vX0bp7H5bvfLt7NoCtVzWhv4+4GwoFn9+NkEz5JU7 JFtZdz5JtGNb0T6T+4FVYXMmyl1D4EORzAPlH/TxGVupStL/j+to8ngahPhaRI18nVp4 Bs5yeq5yUArHjT5vEErVj0TRW6n2cVOmOQ1DFRqmvuXzDICmxNbUdb9L3Dcy3EJLyJDx LjFGmHQ7e+yb2pxzc4j0exUDvDT7w4g6/prxg8zYKPr9PrP9Ro9n3UKb2wGWVVLIPwjC kaT5QNaSDapoK/TZWgnsWu8B9I7AmHLNbOPJCF95ymDofMx8KLjecoknNxIIWsGGWja+ J2Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045766; x=1721650566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CwYPDTPYAwmjKmZ1/Gf11accW/fLFhZgeFXsYW2+ut4=; b=hojYedRDvYE0h7xYS9It5EVidimt9qZKiNHohOO16dVcmdexTOOVG4aNv9KAbOrWhS 1ftKfcXwUaEgJ4EDMAnx/uOOq2Spb8lkKuLD2eqOp3tRdmb3+EWGZ3pqpJg16iE3vaOg 4KLIaHy4W/UImYB+w8l2G0h8bUX07B1vUwzCaWriGKxG8tOzKpny8GvK/g1Mk7h1T1J2 T1flz7i1YMYA2b/wa5FPgv8DpDdIzcshR9nChTemrr8ghO/ELXN0C5boYnad/Y1gTs7B YgElgtgZh85++fJqwYOomi0qPJOljBD58Ndu4vsmQgquYaeGjKR0o9twhU7af1EqzY3U mc/w== X-Forwarded-Encrypted: i=1; AJvYcCXBPJ7ETnnfDpZVoO6J9PCOL9Bcvu313D9qx/W97hzHchQu1WPtWGFbhPtIGaBU/v1ULIOGrqZVT+ufayCf1UmrlQ69/UzAgJJtmRpeJw== X-Gm-Message-State: AOJu0Yy/dbPPGNmLz26MKThRajPRWiSCTPmXXFNpJpPiHBqRuaehjxev K6mbt6KhXJWSXVug1QAexIoQYFENdZPvODOHJyIAxpbRik7+WcMegcirB+9ip9A= X-Google-Smtp-Source: AGHT+IGqx28NbMNvmzLw5J0w/TQ3ZQHmxkK+h/DWdncxb76LIdC5qwbxWV7jVF8Ibsfqau3YeIjlGw== X-Received: by 2002:a5d:47c3:0:b0:367:8a3b:2098 with SMTP id ffacd0b85a97d-367cea46076mr15982239f8f.3.1721045765987; Mon, 15 Jul 2024 05:16:05 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:05 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:37 +0200 Subject: [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240715-x1e80100-crd-backlight-v2-1-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the existing ATNA33XC20 panel, just with a larger resolution and size. Add a new "samsung,atna45af01" compatible to describe this panel in the DT. Use the existing "samsung,atna33xc20" as fallback compatible since existing drivers should work as-is, given that resolution and size are discoverable through the eDP link. Signed-off-by: Stephan Gerhold Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson Acked-by: Conor Dooley --- .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml index 765ca155c83a..5192c93fbd67 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml @@ -14,7 +14,13 @@ allOf: properties: compatible: - const: samsung,atna33xc20 + oneOf: + # Samsung 13.3" FHD (1920x1080 pixels) eDP AMOLED panel + - const: samsung,atna33xc20 + # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel + - items: + - const: samsung,atna45af01 + - const: samsung,atna33xc20 enable-gpios: true port: true From patchwork Mon Jul 15 12:15:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13733379 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AB391891AB for ; Mon, 15 Jul 2024 12:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045771; cv=none; b=nBr8UU+mNt1mi+vBJnysnblgAyXScaAUZGjM8QEvYUg5wTGDMfUEJDQllYqo1hoi3tm4UdIaePtCXNrnFko4CZx89G4S0lXMWXH4kiDjAgMbot1jl8NvTMDjiNs8exlivdK4OOIZc+d0sV72A4Ikj6X3+iobyQoP7SMlmiNgfAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045771; c=relaxed/simple; bh=us5vFbV1oXrFQ1IRmJFjWmuvUJ7Mz2t9/i5d0K/nxWo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cIbnBnocGKNUxTQu8hS0XZyCKH/AfpdwhrwkDW3OojrzlInD/xVuOmI6W/vFFdw9X27JMEMwk0nVd7Vns8p/13r76feO4msR/sEgLh96vs0kQqHjD8DxZNxJgPEy190OFsIEDWFbydFQmqwDr2XYjhuN4XOjKdbkd1ck3R2wZz4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kClym+ZD; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kClym+ZD" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-36798ea618bso2505178f8f.0 for ; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045766; x=1721650566; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=C4zewyPEhlNFFIG7IewHHr+zZpf0Zw7H1PjOS7/qftA=; b=kClym+ZDk2qJRRmPpHLGp01d73dPEUrnBzUe10NhIWj1PTHpD2+JUj6L6o+aKXkdQI iTv9chTm18X1y4P5pc01TDu2dd/c4Uh5279v2RC2KMU0Bi9B73Q2rl9O2uSo5imMX0Uj kLMBjCMlFw6O0+pVs/ImgcYZvvk4enNMwtiX1R9Y/cD6pQCFaX0gR4UpuhHAZthbMV0n D7IiBvn+yjxSnli/aE+tZ8SyaoJ71HnF5/q6SyVaFVkkRZ6oGqZmwELHflfelsm+vM2D e3M74eaf95kDjspy01yQBLOUF7E9+77wT0Zm2fJiHlhbUZBztFoTbDwtGXx5PfBGspyO gtiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045766; x=1721650566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C4zewyPEhlNFFIG7IewHHr+zZpf0Zw7H1PjOS7/qftA=; b=H9rNNBUZCTu3eJtHTRL51fylkjtAF4wzuQ5aWjfqqeo02+fvAGZ1jE0IUlC+Ofd1eJ csvkeBGIE/8YN8MgigBZF6S+kPD6Qu2Iovv8DteCSS+SfSbru9s80DJydHkK/HEBBDZD Qe1PG0m40BMOh36UG6yiH2JWvXB8eKBbINd0V6ugM/zbeJmZcNPjLGVDyo5AmA37RStU 7ZVpFvHkwh/NFXANrAYDrRo19PnrR+CUfLp3Ljx1++apPrj9PJPtGm9uRZSdmZK0Bv+G zYQ29Z/Ze7/CMpv5vccRpxTo3Z9LTrW+LxKMbpx6t09G7k3X3d4mhIZSyrALT5x8rmo+ qa7g== X-Forwarded-Encrypted: i=1; AJvYcCWiavpoba+Rkj0r6h2/85tthXwQRG2MB0Z7fLoBR2O5BM4g95pcpcXwxpGdYhsvBHFBIq+wD6yER+reb0HAW8/mRW+iIjurON9+AKmgjA== X-Gm-Message-State: AOJu0YyImrhC9DUy4ijmDZfvWNm9b6Zy6N6j9qSo93JJVmdGs9MbAnaU yqqsayzwcs4slLqqyltuja8myB8tJAAPBwg8cb01ItVD3uZQH+h2KHAqZRcSQFs= X-Google-Smtp-Source: AGHT+IE1hOML28f+XraJzEd8SFOSIj91LonNL45CkfZTFsChgS0t1o51jq4Yctj5be3mCBmPsTXBdQ== X-Received: by 2002:adf:ffcd:0:b0:367:9791:2939 with SMTP id ffacd0b85a97d-367cea6b804mr11785800f8f.21.1721045766633; Mon, 15 Jul 2024 05:16:06 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:06 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:38 +0200 Subject: [PATCH v2 2/4] Revert "drm/panel-edp: Add SDC ATNA45AF01" Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240715-x1e80100-crd-backlight-v2-2-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the Qualcomm X1E80100 CRD), but the screen works only partially in that configuration: It works after boot but once the screen gets disabled it does not turn on again until after reboot. It behaves the same way with the default "conservative" timings, so we might as well drop the configuration from the panel-edp driver. That way, users with old DTBs will get a warning and can move to the new driver. Reviewed-by: Douglas Anderson Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold Tested-by: Johan Hovold --- drivers/gpu/drm/panel/panel-edp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 3a574a9b46e7..d2d682385e89 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1960,8 +1960,6 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('L', 'G', 'D', 0x05af, &delay_200_500_e200_d200, "Unknown"), EDP_PANEL_ENTRY('L', 'G', 'D', 0x05f1, &delay_200_500_e200_d200, "Unknown"), - EDP_PANEL_ENTRY('S', 'D', 'C', 0x416d, &delay_100_500_e200, "ATNA45AF01"), - EDP_PANEL_ENTRY('S', 'H', 'P', 0x1511, &delay_200_500_e50, "LQ140M1JW48"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x1523, &delay_80_500_e50, "LQ140M1JW46"), EDP_PANEL_ENTRY('S', 'H', 'P', 0x153a, &delay_200_500_e50, "LQ140T1JH01"), From patchwork Mon Jul 15 12:15:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13733378 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9D518A95A for ; Mon, 15 Jul 2024 12:16:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045770; cv=none; b=YnHMENpDvV0LYdlU6LXRfagrtllXzYaOWcqhFD8NqaDnm9xt182FInQZBDaZGQJk3icKX6T/d1wl1WCyuzw0xNI2IP2hQ3BGyAsg5punR64AVX609nvX8VcLCy8/HKjGq+/Kui1JDJ/rBoLKOLJbnJdzVVG8HPGlc4tURj1FasQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045770; c=relaxed/simple; bh=uRHj+xASeRStbUPUcco0GvGgUPHvwx8Q22ADeqLFEsw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lDJhQVfxoAed5a/76JOSpXhNNoI+8R0MhCGVfyFd4PVjbWlGt4fMraR7ZgN7+n7gAjKaHX9WT/XAc7p9gnxLQ9tEAjxRzCp3JmnaH5Kuj+31Xf7KOqRWfSiDKfmBstqdQ5jHYYdbpKOFhaFQmAplEXBQrq4Wi1uxN+L11GVZGIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BCT9xen/; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BCT9xen/" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-36798e62aeeso2692674f8f.1 for ; Mon, 15 Jul 2024 05:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045767; x=1721650567; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nlicpzX8j7ceD/JMCHCgT4Wp1znP1wKt2ZwJqztrd3Q=; b=BCT9xen/HkPZmswnKd8e98txmjSZD63NCzsGErdCO/fLiloTaLeBRV7DHU/8Zt+ZdB tPIH2cWppYioAZ45FHoFN9w2yslKoUysd5uHkjv/to3IE9XWUjQNG0zmPLxWnRihTqXG HN3Y+oNGTdfU7Ns0fZ/CDzd+uP6U7JVgWh9/fP+F1k+IWzFcXQJ18SkFKXbZhm3fm19k OshAbzsZcHWtDi+eITydJ6bQWMi7wvCSWp6aqgN/PUv48rv2WH+AZRRTVBJihqKTbg8f 1xNNoK3gpdewkqNYZ0Uz6UZ5vrGDLfggJ0/nDQUTzZvwK7viSXx7BbzIngWZMP1PuL9h Qs3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045767; x=1721650567; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nlicpzX8j7ceD/JMCHCgT4Wp1znP1wKt2ZwJqztrd3Q=; b=vINvk5pZzMP2eu4Gh2Bq4QPu2KQwYdiwSDeOQeSecu2tVFSIm1qKHsfFpb4Hkbh7jz MqxfKrO9907fvexds/MwX07/J7rj5VodL6QzEErAOvV8syy5+Rgsz51FA0IeTyyfbjuL 3UG4g8HeAUXiuBtF7nGT8SMWu2YUR1IwK7dysSYAJadCpIlp5C8ycBHBQp90e9gShD/f MHdPPZe0Z5wGRemNkFigET5q7nfxu0vfeWrFiFSu9iI73MxzTTscwRPKuJVlw7zQYb7e PjbJmbK3Ro9D6aBne3O39zRejmGuuakMqnxd9hcilSGRmcvA3i2KsYRoGJGRGzKJyHek lQ+A== X-Forwarded-Encrypted: i=1; AJvYcCVAoKpgJJhv2DU/gc5zkwbcru0tDnUGnxEFr8d4Dgu6BzuPak4jJ55JmiAEY8NBjfy7hAaAwwgeYk3SOIwdXfc4TFVIkDQfD5+Kh7v1dQ== X-Gm-Message-State: AOJu0YyMnzFKedMyXYrwgDGuOYhWrzHY2zJU/8vcCROmfHZjhVFY0cE4 HdI8gaEaME7b69ZoWwv/0uoJPmS4Pg9tqWqqtOt9QjolNfyJDBUHeGH+SyhD1yc= X-Google-Smtp-Source: AGHT+IGgvcNb0nVQlFTcKcu6JOIlWWDkfbIbuPOAB1CSXeabBGkhzvEOawCNDGbvQTG94lGN9DpG+Q== X-Received: by 2002:a05:6000:2c3:b0:367:f281:260e with SMTP id ffacd0b85a97d-367f2812acamr10220652f8f.3.1721045767292; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:07 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:39 +0200 Subject: [PATCH v2 3/4] arm64: dts: qcom: x1e80100-crd: Fix backlight Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240715-x1e80100-crd-backlight-v2-3-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-samsung-atna33xc20 driver for sc7180-trogdor-homestar. Switch the panel in the DT to the new compatible and make two more changes to make it work correctly: 1. Add the missing GPIO for the panel EL_ON3 line (EDP_BL_EN on CRD and enable-gpios in the DT). 2. Drop the regulator-always-on for the panel regulator. The panel does not seem to power off properly if the regulator stays on. Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support") Reviewed-by: Konrad Dybcio Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold Tested-by: Johan Hovold --- This can be applied as fix for 6.11 since the driver works as-is with the fallback compatible. If so, the defconfig patch should ideally also go there to ensure people actually have the driver enabled. --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts index 6152bcd0bc1f..4a4eb7211e69 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -268,7 +268,6 @@ vreg_edp_3p3: regulator-edp-3p3 { pinctrl-0 = <&edp_reg_en>; pinctrl-names = "default"; - regulator-always-on; regulator-boot-on; }; @@ -724,9 +723,13 @@ &mdss_dp3 { aux-bus { panel { - compatible = "edp-panel"; + compatible = "samsung,atna45af01", "samsung,atna33xc20"; + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; power-supply = <&vreg_edp_3p3>; + pinctrl-0 = <&edp_bl_en>; + pinctrl-names = "default"; + port { edp_panel_in: endpoint { remote-endpoint = <&mdss_dp3_out>; @@ -785,6 +788,16 @@ &pcie6a_phy { status = "okay"; }; +&pmc8380_3_gpios { + edp_bl_en: edp-bl-en-state { + pins = "gpio4"; + function = "normal"; + power-source = <1>; /* 1.8V */ + input-disable; + output-enable; + }; +}; + &qupv3_0 { status = "okay"; }; From patchwork Mon Jul 15 12:15:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephan Gerhold X-Patchwork-Id: 13733380 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A2301862AC for ; Mon, 15 Jul 2024 12:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045771; cv=none; b=UsqE1NIDS9Sx1GMoKBbf/bJasqnK2ljIokTul3F03SK6fivX+VwthP16P8fD2C1FygDnUrjsWYaJwx503zqgyVYU3HaAXuJRyxDSsxbqdlDMLdn0iT1Q/3BctyPgjniN2z1N+zSLlRgM7T7Vb30AWklzDpZ5sSwSVXg8PgVHHx4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721045771; c=relaxed/simple; bh=ensaB3Sd9xExyqosO4x4Zulfh8zxqrHJ2g7V01Sv1AA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zsmm2I7fbW21y001GUo8GMpWjbk4GrBWKxDSGsOQPOiYVzH0pmhxixk62jYYm0PxCT50SpiaSKPZkjX/P1vn/FawAUE+4wFvpPS57Cht9aWaD441T7xJRweRUCIU4IcPN6CJkv9mkoI+5EQaOHYF/11VdRJqJT9P43hjEYKvj3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wfoDu2s4; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wfoDu2s4" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-367b6e5ffbfso2354106f8f.0 for ; Mon, 15 Jul 2024 05:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721045768; x=1721650568; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kTq2r+cTBBf6PJ97371cfxGvOYB5A8cmvVmwB9VmmPg=; b=wfoDu2s4Hi+kMtiB4X5oD6fBKi62FoHAU6/B/6ZSXxoXvgtA2IQstHH0VYFU26VMh5 /T6RdWHd4Il0t3FTX4ItgatvMogsni+hF0+QGaDUWuCUkNgSFSQvBH3msxJEFrK/GlyN MiReNX6uSFsE4erBLEajrdZLW+XhqLfggLwOg1H/2BmZzd9QUexzpEr2BKXIn2VZqIWd pNSgI6lpP5rItElsrttHCzFEiyWFAiJYLcOkEnLBSPm8B5PAl8banRh4NVjB9+o6hUWe us3pUAKRUXoo2BVPySQtwIhV3+ea295DLFp81C82SHvfjBYCFgon9cqdgy+HdIHygkLN ufmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721045768; x=1721650568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kTq2r+cTBBf6PJ97371cfxGvOYB5A8cmvVmwB9VmmPg=; b=Sm4R28OF3oi/5VbuDwVx8++yJ2KCQ2CaedbyWTxVDi/Nb2klq6YYIJBtIgFik511ma UN+hpW5zoEug0LuaoZCG9I5TIs/YBnR9ubZzd+IprVE/8vaDUTWh0Oh46bvRE+CjFwCT 0VSb7YyOC1P4v+HmAoJD4CJaC5Sq/25ZzZ1a2NEdQ1vCF7aN/j4oO7qWWS8m1/hNMo1C Tb/Sbun5qgRECFKKglfMIOHOqe7n4G8vEOFDaZwCBOcQ0dMhXZWPka6d0pz7YjoX8ruX q7B358A/heDQoTM0tymzlQOTCn+qoHuzC5iP0/PeVDJPNl4ZHPnwceTfu59fiY/xa5/+ qIaA== X-Forwarded-Encrypted: i=1; AJvYcCWsGRGjk5Ii/gWeePPagXVdbf21oBtBSaScu3cMPCPSnG0WSe+7nRsmey7zvSxsSL0kIV1zg6Wvw4h/DXdL5emoGC+Ygc/xOqBpacGiQw== X-Gm-Message-State: AOJu0YzJa51R4KYvBqgwKaOEB7Z0NAJVcOH6P2766N2RKOSSQ2BaoOYU 4rT75XBOc8/qQpcx/1bpl7ZTp/X0hOpCMr7U9ZmpgzTfWdr7sElaGN8k8jWFihk= X-Google-Smtp-Source: AGHT+IFs1erFYCijcBGp0SVQyMBvfH9pHBYbLhKOfck+AMcQPdS3cmXHK20l4yRwr/hKh+tKqHhBsQ== X-Received: by 2002:a5d:480c:0:b0:364:6c08:b9b2 with SMTP id ffacd0b85a97d-367cead1d1amr10964785f8f.45.1721045767976; Mon, 15 Jul 2024 05:16:07 -0700 (PDT) Received: from [127.0.0.2] ([2a02:2454:ff1f:b240:886b:1a3a:7569:3d95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680d9771aasm6369201f8f.0.2024.07.15.05.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 05:16:07 -0700 (PDT) From: Stephan Gerhold Date: Mon, 15 Jul 2024 14:15:40 +0200 Subject: [PATCH v2 4/4] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240715-x1e80100-crd-backlight-v2-4-31b7f2f658a3@linaro.org> References: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> In-Reply-To: <20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@linaro.org> To: Neil Armstrong , Bjorn Andersson , Konrad Dybcio Cc: Jessica Zhang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.13.0 This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold Reviewed-by: Johan Hovold Reviewed-by: Douglas Anderson --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 7d32fca64996..362df9390263 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -887,6 +887,7 @@ CONFIG_DRM_PANEL_KHADAS_TS050=m CONFIG_DRM_PANEL_MANTIX_MLAF057WE51=m CONFIG_DRM_PANEL_NOVATEK_NT36672E=m CONFIG_DRM_PANEL_RAYDIUM_RM67191=m +CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=m CONFIG_DRM_PANEL_SITRONIX_ST7703=m CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA=m CONFIG_DRM_PANEL_VISIONOX_VTDR6130=m