From patchwork Sun Jul 21 16:28:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kousik Sanagavarapu X-Patchwork-Id: 13738045 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26278C3DA61 for ; Sun, 21 Jul 2024 17:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G9aEJfvEVkHc3rc+qcpiZ+r3iAy/bh/OhW1EfSbvL3c=; b=TSWr9rWYdAfIOvxi9sTIVH0p0Y dOCsi/CKBX5oha6wk0z3z3fcOuIIV/bg2qmSw3KnE11tY3rgtVYL6GtKG5rmChGw9vqGx1jTy/vFu Bp8j/h+0ELCGklyU5quCwrtHq0HQgXe+Z5DeSpXJudJzxEhPSEP6Fzywig6RDTwalP/izmYjtU5v4 wiqTaH4hVVtkbhfeUaU2JJKIX3UAcmnFsj5NedFMHRxROFa02NZTrus6D1ipi107SMdBCThPdklO5 CAA9HyJsbYv2lFNyFHd/wy5LFpbugkg4MiITG4FFIww0At0pCv4i5yjdS8XzxaWnn4YtgnA8IyDTt oojRd8Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVa4C-00000007CKk-2pAY; Sun, 21 Jul 2024 17:09:48 +0000 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVa3d-00000007C8W-16TW for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2024 17:09:15 +0000 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-70448cae1e0so1863704a34.3 for ; Sun, 21 Jul 2024 10:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721581752; x=1722186552; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G9aEJfvEVkHc3rc+qcpiZ+r3iAy/bh/OhW1EfSbvL3c=; b=SseFTGaT3Prdu6YRUBAXvYuRyga+nAr/M4i4/rBWv18HHFAzzxXE1ZbYB6itPehEkV TZEfn3tl78ohnp5lX6dTlXISKypu/pIYfg3Qa6eRW4Wq7zBBaSsVSRBtU03v0GXsN7jD 5J1Iwe0oM3HZPBDgXhmDv5kxkbRz4XB8E34ulSO9EPdHa6Pn4zCuTkqtkUGB8X1mqBuB +/T8k81tTV0KYP7d6gmIKOxNKjQ1iJZ6JE6TlzQFkfu1Ck/xz0QmcxFCYWQKryYJc+EH ZT3CFK6JdQo74+iAYfFqbx7r1fMew+3Gp7QGRpLnl+06eDg/1qYrJvylX799QBiPhgCj XP/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721581752; x=1722186552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G9aEJfvEVkHc3rc+qcpiZ+r3iAy/bh/OhW1EfSbvL3c=; b=sbTCPTrJWB8EA9dsdi6uAx6YNLv9lsmH239Idch5obhPLjuzuW99KG2cA5loawu+M9 9Uy/gll0o5SxTevXLfFQqQ27BQB8pjl7PvaO/EPzzS+EtAt9tF46CGn7UIvu3YlSrByJ 1qYSoxxCSTflSSG3f75+FRE8qTP3oWqBN0IPJKkIZ42ZFmOjBlBLgh91uT40fQSu8l8e S6mAMKUCHQwOVWFXLjgcOAT8dPsPkRTeRtTscMEtmMSoTXq3qokZcDaxfr/c7w67RAmV Sf//wTsnVIYEL9YkBtvwARWrHo4+S+IT9hdmP81a8XAHMuk1B+E7B+WZPGPFa4rKdrDZ xQvg== X-Forwarded-Encrypted: i=1; AJvYcCWc8ZH54xeY8GQAYUxeeTf6CpAljaDM3VUatiUgbGFKfz918d5K1NH7e0waZKiB5ekNmBMB9NQ2J4ZN63Nd6LK9i9GcUEzEfDYsh6OwK0hxDLRjK9M= X-Gm-Message-State: AOJu0Yww4NqPT1wOIG/P767WRrQOoUnqmbja+7oz0YUY0VSXOoA/VhXS d92FgiMmoxpacjEe/PpMZXUbW9NKJM7kFsPFLLT1L345RpGte5SR X-Google-Smtp-Source: AGHT+IG4RGm6UldBRPirm/sgg0RJFRpR7a2pTNHo9NF5qkkB4iyXZ5ybq2E6dEdqmje5bNCJc3Rb7w== X-Received: by 2002:a05:6830:391b:b0:703:b0e9:d951 with SMTP id 46e09a7af769-709008d0de4mr6872850a34.6.1721581751955; Sun, 21 Jul 2024 10:09:11 -0700 (PDT) Received: from kousik.local ([2405:201:c006:312d:f66f:2b12:abd:60ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d285943e3sm417810b3a.213.2024.07.21.10.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 10:09:11 -0700 (PDT) From: Kousik Sanagavarapu To: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Kousik Sanagavarapu Subject: [PATCH 1/3] dt-bindings: timer: ti,davinci-timer: convert to dtschema Date: Sun, 21 Jul 2024 21:58:34 +0530 Message-ID: <20240721170840.15569-2-five231003@gmail.com> X-Mailer: git-send-email 2.45.2.827.g557ae147e6.dirty In-Reply-To: <20240721170840.15569-1-five231003@gmail.com> References: <20240721170840.15569-1-five231003@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240721_100913_327480_D07B64AC X-CRM114-Status: GOOD ( 17.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Convert txt binding of TI's DaVinci timer to dtschema to allow for validation. Signed-off-by: Kousik Sanagavarapu --- .../bindings/timer/ti,davinci-timer.txt | 37 ---------- .../bindings/timer/ti,davinci-timer.yaml | 68 +++++++++++++++++++ 2 files changed, 68 insertions(+), 37 deletions(-) delete mode 100644 Documentation/devicetree/bindings/timer/ti,davinci-timer.txt create mode 100644 Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml diff --git a/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt deleted file mode 100644 index 29bf91ccf5b7..000000000000 --- a/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt +++ /dev/null @@ -1,37 +0,0 @@ -* Device tree bindings for Texas Instruments DaVinci timer - -This document provides bindings for the 64-bit timer in the DaVinci -architecture devices. The timer can be configured as a general-purpose 64-bit -timer, dual general-purpose 32-bit timers. When configured as dual 32-bit -timers, each half can operate in conjunction (chain mode) or independently -(unchained mode) of each other. - -The timer is a free running up-counter and can generate interrupts when the -counter reaches preset counter values. - -Also see ../watchdog/davinci-wdt.txt for timers that are configurable as -watchdog timers. - -Required properties: - -- compatible : should be "ti,da830-timer". -- reg : specifies base physical address and count of the registers. -- interrupts : interrupts generated by the timer. -- interrupt-names: should be "tint12", "tint34", "cmpint0", "cmpint1", - "cmpint2", "cmpint3", "cmpint4", "cmpint5", "cmpint6", - "cmpint7" ("cmpintX" may be omitted if not present in the - hardware). -- clocks : the clock feeding the timer clock. - -Example: - - clocksource: timer@20000 { - compatible = "ti,da830-timer"; - reg = <0x20000 0x1000>; - interrupts = <21>, <22>, <74>, <75>, <76>, <77>, <78>, <79>, - <80>, <81>; - interrupt-names = "tint12", "tint34", "cmpint0", "cmpint1", - "cmpint2", "cmpint3", "cmpint4", "cmpint5", - "cmpint6", "cmpint7"; - clocks = <&pll0_auxclk>; - }; diff --git a/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml b/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml new file mode 100644 index 000000000000..615ceb8f30af --- /dev/null +++ b/Documentation/devicetree/bindings/timer/ti,davinci-timer.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/timer/ti,davinci-timer.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI DaVinci Timer + +maintainers: + - Kousik Sanagavarapu + +description: | + + This is a 64-bit timer found on TI's DaVinci architecture devices. The timer + can be configured as a general-purpose 64-bit timer, dual general-purpose + 32-bit timers. When configured as dual 32-bit timers, each half can operate + in conjunction (chain mode) or independently (unchained mode) of each other. + + The timer is a free running up-counter and can generate interrupts when the + counter reaches preset counter values. + +properties: + compatible: + const: ti,da830-timer + + reg: + maxItems: 1 + + interrupts: + minItems: 2 + + interrupt-names: + minItems: 2 + items: + - const: tint12 + - const: tint34 + - const: cmpint0 + - const: cmpint1 + - const: cmpint2 + - const: cmpint3 + - const: cmpint4 + - const: cmpint5 + - const: cmpint6 + - const: cmpint7 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - interrupt-names + - clocks + +additionalProperties: false + +examples: + - | + timer@20000 { + compatible = "ti,da830-timer"; + reg = <0x20000 0x1000>; + interrupts = <21>, <22>; + interrupt-names = "tint12", "tint34"; + clocks = <&pll0_auxclk>; + }; + +... From patchwork Sun Jul 21 16:28:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kousik Sanagavarapu X-Patchwork-Id: 13738046 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B041FC3DA61 for ; Sun, 21 Jul 2024 17:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m+xFnJLXKFSs1rD/pdMgqeISRYaT8z33SQNfYCihvv0=; b=ZkivTwXgp0d8QfC4GjJkoI2rD8 TSe2LNF0lbRYvICmarVKGoDxp8zVYTfdREz21qfpola867cl2rua4bgK59K8tjn9mLjJ+SmJO4DW8 1y3/lyzXyyoQ/fvxdn02wezYyMi55MZAw4zvy0cMxGwo04fNQpZzqf+1uIoHORmtLr5Mw8e9sb2N0 wv4dz943xNSQnvUOv5qQ1Er27WP0FRT1oFqYP7ZznKe5nKqCK5gOIFIZOLll+ySkc3UHAReZ/5o31 o7IzHvpb1QH3cRA3Q8Yq3zFz/Fs/KHLOSEgt7z8bF3zK/txKzumdiPdDXAdO1PoCdbGZGelwVVJEJ WFPxhL4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVa4Y-00000007CTL-0P4S; Sun, 21 Jul 2024 17:10:10 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVa3j-00000007CAR-3QOW for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2024 17:09:21 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-70d18112b60so442038b3a.1 for ; Sun, 21 Jul 2024 10:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721581759; x=1722186559; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m+xFnJLXKFSs1rD/pdMgqeISRYaT8z33SQNfYCihvv0=; b=AK380AMsef2EsdGS6iQdPtXeHIEOx3k+Es7sq20CGGEZ9t8sc/9tFWLYiuUK/Snx/W awAkJbqF9GcXotdzRAs9gloGJSZDb8Gt+M+bPqETDwEfHUaRPE/F6eo9GRFxlvErBVTH YKYzJU4+fHzv4Uxh4VQi0OTMRKeeRB7Eu8kLPURrJt6HppD0O84nIkhkbMxrJgO2/Bgf PeOS8qcWejqNwY+h8AjEcciRAV86ooi4+eAchxDqOS/V3UMYAG0CCxbHt/4ycMuuTAfx JBDvGYCJRsvUi2/Hhj0jbqyAjNcYSsh9Jz3R4OK0greLapOLsUJKILUcGKBBX/rOYrag Viiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721581759; x=1722186559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m+xFnJLXKFSs1rD/pdMgqeISRYaT8z33SQNfYCihvv0=; b=ra92iJOnUkX5vCgC8+u/TiOmzGo+Sb/G3KZMWmwHUg3UAriep46NmxZoy41M/FCJPg vtiYcThlczsA7l5xHkoaSlAOPe2kan2CSxiJmHargx6/Zzgx8vq3Y6mPnjkXwKoMYd4j nVJ9hEttCXK4apr1N0Dp35/k8SMjl53cyBKQa5oQxX8x/saxsZ4cW7HEN/VGg4PM09sc kdIt4oGUJxbExqCLpzergfoSzl3JXxIrc7OoEz9YVwKghxkHqioeAR81uLfYB1k8C/cn 1/oUvrUWIGyRV6sABQUHofNhDtn9ZNBgpcnU/BpDpRgwRYzuZ6WBPSL8Q/XnIChlpaQS cC2Q== X-Forwarded-Encrypted: i=1; AJvYcCXsfwYeQNIKldrN6C3JRtuRkcCS6Ax0Iq/lc5cmqC3R4qGSv1Fz2Jsy7vgfUKIKI3tkJhd8RtfmvwQCvy8e+33imIRVuT0uI7ml5IYaDPHXYD87I0A= X-Gm-Message-State: AOJu0YzFNQE/d9WTFpH4eiLhB64tXusu6PGvAjjTNPAj/q67PASImRwH uKolAKbLFl2MwFaubQNMfvLzkmgofbV2AaV1g59oYxTnf7Z5KnK8 X-Google-Smtp-Source: AGHT+IENAylm5O+0sTieY5CFralyVXeCUeaCnUG9F/PIBeQRb/dRfNNLBPxjkB3W/gCU0FJWFl0g0w== X-Received: by 2002:a05:6a00:1954:b0:704:2516:8d17 with SMTP id d2e1a72fcca58-70cfd51e05cmr14110055b3a.8.1721581758481; Sun, 21 Jul 2024 10:09:18 -0700 (PDT) Received: from kousik.local ([2405:201:c006:312d:f66f:2b12:abd:60ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d285943e3sm417810b3a.213.2024.07.21.10.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 10:09:18 -0700 (PDT) From: Kousik Sanagavarapu To: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Kousik Sanagavarapu Subject: [RFC PATCH 2/3] dt-bindings: watchdog: ti,davinci-wdt: convert to dtschema Date: Sun, 21 Jul 2024 21:58:35 +0530 Message-ID: <20240721170840.15569-3-five231003@gmail.com> X-Mailer: git-send-email 2.45.2.827.g557ae147e6.dirty In-Reply-To: <20240721170840.15569-1-five231003@gmail.com> References: <20240721170840.15569-1-five231003@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240721_100919_880255_09626F2A X-CRM114-Status: GOOD ( 18.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Convert txt bindings of TI's DaVinci/Keystone Watchdog Timer Controller to dtschema to allow for validation. Signed-off-by: Kousik Sanagavarapu --- This patch was submitted to the lists before by Nik https://lore.kernel.org/linux-devicetree/20231024195839.49607-1-n2h9z4@gmail.com/ Although it seems that the right way include the "power-domians" property was not decided upon (read through the thread). I grepped for instances of "power-domains" in ti related SoCs and other subsystems and it seems that there is always only 1 such "power-domains" phandle Documentation/devicetree/bindings/display/ti/ti,k2g-dss.yaml The existing dts code also confirms this arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi Again, I guess it would be great if someone could point out if this is right - so RFC. Also, shouldn't "clocks" be "required"? - RFC. .../bindings/watchdog/davinci-wdt.txt | 24 --------- .../bindings/watchdog/ti,davinci-wdt.yaml | 52 +++++++++++++++++++ 2 files changed, 52 insertions(+), 24 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/davinci-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml diff --git a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt deleted file mode 100644 index aa10b8ec36e2..000000000000 --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt +++ /dev/null @@ -1,24 +0,0 @@ -Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller - -Required properties: -- compatible : Should be "ti,davinci-wdt", "ti,keystone-wdt" -- reg : Should contain WDT registers location and length - -Optional properties: -- timeout-sec : Contains the watchdog timeout in seconds -- clocks : the clock feeding the watchdog timer. - Needed if platform uses clocks. - See clock-bindings.txt - -Documentation: -Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf -Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf - -Examples: - -wdt: wdt@2320000 { - compatible = "ti,davinci-wdt"; - reg = <0x02320000 0x80>; - timeout-sec = <30>; - clocks = <&clkwdtimer0>; -}; diff --git a/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml new file mode 100644 index 000000000000..1829c407147d --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/ti,davinci-wdt.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI DaVinci/Keystone Watchdog Timer Controller + +maintainers: + - Kousik Sanagavarapu + +description: | + TI's Watchdog Timer Controller for DaVinci and Keystone Processors. + + Datasheets + + Davinci DM646x - https://www.ti.com/lit/ug/spruer5b/spruer5b.pdf + Keystone - https://www.ti.com/lit/ug/sprugv5a/sprugv5a.pdf + +allOf: + - $ref: watchdog.yaml# + +properties: + compatible: + enum: + - ti,davinci-wdt + - ti,keystone-wdt + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + watchdog@22f0080 { + compatible = "ti,davinci-wdt"; + reg = <0x022f0080 0x80>; + clocks = <&clkwdtimer0>; + }; + +... From patchwork Sun Jul 21 16:28:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kousik Sanagavarapu X-Patchwork-Id: 13738047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB0DBC3DA61 for ; Sun, 21 Jul 2024 17:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TJbtHFQcNPBsqXeFfU2FjoOsfer626zKkq+lXutNICI=; b=iBPqu3IeGZ2ShEb3T0YKA0yecc aMkIUkpIq17TMr35S7OAetaLUuZV2QPQEiotIg8KgK9/bDCZqjUnCQI55nRlQE6yZrxsX/DRx7C7B ZLzRzxUZtkNMItt1rG74Mds0vMA5h8p4gWj+hcKM9MMcXFnDjBso64nVK8macXdoCRVi1LrYU9Qrm w49bOzd7LVRX0YpB5LhWz2cmJPKfJWaEnvUsuyDu7kRandgsb4PC9K4zSMQ9CNxoQfXysvjElZ6gK dV9teW/6bpbSr3kNul1GAPIshDMy1reXVj9uOr1TXQPmuNAGrABT/1iJbic4qDtKP+Ya8hFCvS1bZ XDgRyT7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVa4s-00000007CZX-2eCj; Sun, 21 Jul 2024 17:10:30 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVa3q-00000007CCd-1oqK for linux-arm-kernel@lists.infradead.org; Sun, 21 Jul 2024 17:09:28 +0000 Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-8063553b837so150908639f.1 for ; Sun, 21 Jul 2024 10:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721581765; x=1722186565; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TJbtHFQcNPBsqXeFfU2FjoOsfer626zKkq+lXutNICI=; b=P+j66gp5IGqTveAlA5V9heFtlRw0ipmen20Huz4ITTz4iTeE/ZJaydEHDw+obJkaUs 5yeOxXCPSoxEe+QtXOPC0Fnx2jD44zAeDxqY+ZfYn32vPg2imnZM2XBPNE5u0xMJg4zy bL1c7ol9oV5BTqizfWXHDi2x5XoNkIvwR6mSkcNY6yvY7ip7bqPhEvYKh8lT9m7PEYXH jCEZtpOfCKrJOwvBPl0KmNiQfc1qH7V3pT9t1yED6FhGoN8Y/w158lOEDoEOW6Lc/JRU 3fZIPasgSridGRp3S5fUnFxoSTPkTD7qyiQcCRcG5V16xqPWxar6gjK/liMVD8MrR5ng g0kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721581765; x=1722186565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TJbtHFQcNPBsqXeFfU2FjoOsfer626zKkq+lXutNICI=; b=w9GrbMTf7iWUMph6vk5+hb3/0chJXjZ8Ys+Q83L4V7DGOsUrijCuQyFzbGamHFUlsu rwyM0wbvAHpW6KMBv0IgkSgxfneWMQHnoTYu0EkKTgf7sQ5aBQY91QpSN2Vo9GG/hFF5 0xsF/iVqRHl8dXq3ltTYNSuhKAQE+M7DfyrMFkmO9DoLoPQf48X6k1c539vNMQTyZrLS xFn0GaOzlRAABmHQ4C41mH4lAK9mtXlczR3MLWmfdix9kd61OQT+Lr+V3sZ5TxN53U2t 5vqCoBEE1lS7DaN410loCAXSau5ME/OpMALa7YklcJ10nTrQRIM7PwzIUPwRcdEGJMof M8Hg== X-Forwarded-Encrypted: i=1; AJvYcCWksabqPVQY/f+tYEvp/U+1R+yUw/wxzuDRX59tdv2ZzERfb10NyTVql/DiNoKkGd2u0CdBKBjpcF2zV9CKUPX7mKk4u59T6tcfRtleebByCfbsCoM= X-Gm-Message-State: AOJu0YzxQdZjk40jj3hYODFCg9/o3ZnHU3b4U17Y05PFPMoPq0upU1eS HSYDhzGlHpnCLUhlrgtM44ffOF7k6Qgamyyd01Hu9RcGPEQtAkht X-Google-Smtp-Source: AGHT+IHTUuDmrSkpDNTCs+DM7fkQIf/sYoD1C3wpPlVfiRwZYjxYuCgZLbQbZW5lfAz3EpEk6s1CMw== X-Received: by 2002:a05:6602:6422:b0:806:31ee:13b with SMTP id ca18e2360f4ac-81aa538d525mr787891739f.4.1721581765062; Sun, 21 Jul 2024 10:09:25 -0700 (PDT) Received: from kousik.local ([2405:201:c006:312d:f66f:2b12:abd:60ff]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70d285943e3sm417810b3a.213.2024.07.21.10.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jul 2024 10:09:24 -0700 (PDT) From: Kousik Sanagavarapu To: Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wim Van Sebroeck , Guenter Roeck , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Kousik Sanagavarapu Subject: [RFC PATCH 3/3] ARM: dts: davinci, keystone: correct watchdog nodenames Date: Sun, 21 Jul 2024 21:58:36 +0530 Message-ID: <20240721170840.15569-4-five231003@gmail.com> X-Mailer: git-send-email 2.45.2.827.g557ae147e6.dirty In-Reply-To: <20240721170840.15569-1-five231003@gmail.com> References: <20240721170840.15569-1-five231003@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240721_100926_495630_8383E5D0 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using "wdt" instead of "watchdog" for watchdog timer nodes doesn't allow for validation with the corresponding dtschema and gives errors $ make CHECK_DTBS=y DT_SCHEMA_FILES=ti,davinci-wdt.yaml \ ti/keystone/keystone-k2g-ice.dtb DTC_CHK arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb arch/arm/boot/dts/ti/keystone/keystone-k2g-ice.dtb: wdt@02250000: $nodename:0: 'wdt@02250000' does not match '^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$' from schema $id: http://devicetree.org/schemas/watchdog/ti,davinci-wdt.yaml# Therefore change "wdt@" to "watchdog@". While at it, remove "ti,davinci-wdt" compatible from the keystone dts code. Signed-off-by: Kousik Sanagavarapu --- Question: Should "wdt@" be changed everywhere in the dts code or is it only a requirement of validation against dtschema? Also, I'm not sure about removing "ti,davinci-wdt" from the keystone dts code. I'm thinking it is only there so that the driver code can get information from keystone nodes too, because it seems that there is no code for ti,keystone-wdt. So question, - Is WDT Controller driver for keystone not written yet? Or - Does the WDT Controller driver for keystone have the same functionality as one on davinci - hence leading us to simply do .compatible = "ti,keystone-wdt" ? arch/arm/boot/dts/ti/davinci/da850.dtsi | 2 +- arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi | 4 ++-- arch/arm/boot/dts/ti/keystone/keystone.dtsi | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/ti/davinci/da850.dtsi b/arch/arm/boot/dts/ti/davinci/da850.dtsi index 1d3fb5397ce3..89055ab87256 100644 --- a/arch/arm/boot/dts/ti/davinci/da850.dtsi +++ b/arch/arm/boot/dts/ti/davinci/da850.dtsi @@ -525,7 +525,7 @@ clocksource: timer@20000 { interrupt-names = "tint12", "tint34"; clocks = <&pll0_auxclk>; }; - wdt: wdt@21000 { + wdt: watchdog@21000 { compatible = "ti,davinci-wdt"; reg = <0x21000 0x1000>; clocks = <&pll0_auxclk>; diff --git a/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi b/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi index dafe485dfe19..884402a5fe4a 100644 --- a/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi +++ b/arch/arm/boot/dts/ti/keystone/keystone-k2g.dtsi @@ -610,8 +610,8 @@ spi3: spi@21806000 { clocks = <&k2g_clks 0x0013 0>; }; - wdt: wdt@02250000 { - compatible = "ti,keystone-wdt", "ti,davinci-wdt"; + wdt: watchdog@02250000 { + compatible = "ti,keystone-wdt"; reg = <0x02250000 0x80>; power-domains = <&k2g_pds 0x22>; clocks = <&k2g_clks 0x22 0>; diff --git a/arch/arm/boot/dts/ti/keystone/keystone.dtsi b/arch/arm/boot/dts/ti/keystone/keystone.dtsi index ff16428860a9..f697f27edcfc 100644 --- a/arch/arm/boot/dts/ti/keystone/keystone.dtsi +++ b/arch/arm/boot/dts/ti/keystone/keystone.dtsi @@ -225,8 +225,8 @@ usb0: usb@2690000 { }; }; - wdt: wdt@22f0080 { - compatible = "ti,keystone-wdt","ti,davinci-wdt"; + wdt: watchdog@22f0080 { + compatible = "ti,keystone-wdt"; reg = <0x022f0080 0x80>; clocks = <&clkwdtimer0>; };