From patchwork Mon Jul 22 13:45:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Miclaus, Antoniu" X-Patchwork-Id: 13738870 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C4D31598F4; Mon, 22 Jul 2024 14:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721660332; cv=none; b=msApms1ERam9UWWqVMFwwZtAuTWHrZzYWbxX3qxuwQ2rWRGXVW2tjs8qzVckzH56lsKe4FskKf8OLCRngkGJO7Zfnxk/rqQ7Mga6IBPrUCzeVMfM8oVUg7gz5JaBw2lk4j6bHc/7dIJNH/vE3E4l6q71BwU9fCM/Qy//Cm9isIU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721660332; c=relaxed/simple; bh=C/MBpDZjWPIQS5cLI7WOnqLI1/fZ+0rziP5aUhJv3MU=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=BVThKOifpLe+T24zO5AUkaVxoUlEp8XkgP9REaqIauNfuFY1GzxXR4LidF7hrR96CCRwxv7bxYkeunyCE8az9Px1YZ0aKuE+CqUW4n6E6srx6LTZJcIBIEBJ9tCRDwbmX+74hUVXdetgB3pjwkYPtO+c2C3Y6l6oSqzPjchywaI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=uPSCLXc+; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="uPSCLXc+" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46MBqCi6025124; Mon, 22 Jul 2024 09:45:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=DKIM; bh=HOIIX9wN5/wJs2WX7cLfRkVT4ya 0pl+yior1HVd5iNY=; b=uPSCLXc+fxEU2lmP3TKs292fw7ajq9Mt66N1y1n2TWB 9297ddpGEHUomjakRLL5VJGMw+oh1CEvPjSXK5GgSbk28uJ81JSg07ksYheaVw54 wiJtc3dPNRslBEKY3Zvl1kCEU7Z/LVGGW+FjFWWO2+q7Fji4A0cjzmvFxWPpf5QB TUeu73K59mCxwiAQDD27M6MXAWctwNDVhDt8EU0hnPjy+aAISjpEKD0+3YYaL+54 Ft1ujoUqGCtC1nDuFKEMSU5Vm2aZ5q147hWyOc7fV4l8Lqofhmiahp8XRCXRp/3t 9l3C7YFKu0QN5x0XBA3XapKuTrvMC8dyylgUtkqEexg== Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 40hj2b9d6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Jul 2024 09:45:32 -0400 (EDT) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 46MDjUWJ013051 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 22 Jul 2024 09:45:30 -0400 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Mon, 22 Jul 2024 09:45:30 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Mon, 22 Jul 2024 09:45:29 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Mon, 22 Jul 2024 09:45:29 -0400 Received: from amiclaus-VirtualBox.ad.analog.com ([10.65.36.213]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 46MDjH9J016251; Mon, 22 Jul 2024 09:45:19 -0400 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , "Dragos Bogdan" , , , Subject: [PATCH v2 1/2] dt-bindings: iio: adf4377: add adf4378 support Date: Mon, 22 Jul 2024 16:45:05 +0300 Message-ID: <20240722134508.25234-1-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: RhRZbkxCA3vxL-JvKhiLA_cF_fAsUnTU X-Proofpoint-GUID: RhRZbkxCA3vxL-JvKhiLA_cF_fAsUnTU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-22_09,2024-07-22_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407220103 Add porperty conditions for the adf4378. Add product link for the adf4378. Signed-off-by: Antoniu Miclaus --- changes in v2: - use property conditions for clk2 gpio Note: the compatible is already available from the firs iteration of the driver where these particularities weren't available for adf4378 .../devicetree/bindings/iio/frequency/adi,adf4377.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml index aa6a3193b4e0..5f950ee9aec7 100644 --- a/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml +++ b/Documentation/devicetree/bindings/iio/frequency/adi,adf4377.yaml @@ -17,6 +17,7 @@ description: | applications. https://www.analog.com/en/products/adf4377.html + https://www.analog.com/en/products/adf4378.html properties: compatible: @@ -73,6 +74,15 @@ required: allOf: - $ref: /schemas/spi/spi-peripheral-props.yaml# + - if: + properties: + compatible: + contains: + enum: + - adi,adf4378 + then: + properties: + clk2-enable-gpios: false unevaluatedProperties: false From patchwork Mon Jul 22 13:45:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Miclaus, Antoniu" X-Patchwork-Id: 13738869 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6570FF9FE; Mon, 22 Jul 2024 14:37:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721659039; cv=none; b=p4nftBm1Uvj5hG88Rn/VXYo6jUvBwnJSk2EVxJBwt0xJZZmgmHvARIsVTwYVNtewSlcXFq2PqiUE2ArYTwe6CduEYMsRTd/YCq7xx7tYewcWW8nOSesmGVsYCKP+Sgj8t6lpMF1JL9gkpGPcyymdo9DVezcgXeoDv7OjANKv/4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721659039; c=relaxed/simple; bh=jFV16UmVCI6fxImUzE1wTiJZxB/8UcM+LYPVCkYuhX4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jbGlMNsTUqT7pZY1i7JAU589Mq900bBrOOEnxU9Ib16XpSDaEc0m2kpty8Y2n8EjmAngShzM0mt8KGI6UAYQ2sTETpDfkxl0X8u6EJcpTcTh7Xh2Q+3paZH/T5HBIhVTmA1WBHUcou3KBBbTUeEByAAhd3BKOCSmLgEEsavmf+Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=REaeCjLQ; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="REaeCjLQ" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46MC4wb5025513; Mon, 22 Jul 2024 09:45:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=FB2/W eqXqRX1phygT/WXuafr1de4oPqjPnsJDOqdkZ4=; b=REaeCjLQF6BFnLr7YYLM7 TMnKSBaEn3QycdzBWvRbLbgk+UJBbPKmmFSlWPXTbdUoaWhjgX0mxBErD548m2K0 TMcU1iadgQIggv9FwtE1am4ASuzEOLmH4Pz5pjgSLVhoPvSvLpnhtsPgVB1CqHWk OoPwimqT1WzWnQ4uh3eDVglAt2zeyW4My5e61YAqBBDi7B+mBbZ2eEDB9r0H3W+Y lW00CWkKI6jMmY0Mof5nhc7DqOwYjmCT+BJMXKMRsiwDGDhEV/oZJFOSjQy4i/sl ovOS3JAJlNuQ5KKbSaxWjES494mcGpYAzhNqaRwlXf3Nn/maDraD2KtzVz2ll1mb A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 40hj2b9d74-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 22 Jul 2024 09:45:37 -0400 (EDT) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 46MDja0S025940 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 22 Jul 2024 09:45:36 -0400 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Mon, 22 Jul 2024 09:45:35 -0400 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Mon, 22 Jul 2024 09:45:35 -0400 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.986.14 via Frontend Transport; Mon, 22 Jul 2024 09:45:35 -0400 Received: from amiclaus-VirtualBox.ad.analog.com ([10.65.36.213]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 46MDjH9K016251; Mon, 22 Jul 2024 09:45:24 -0400 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , "Dragos Bogdan" , , , Subject: [PATCH v2 2/2] iio: frequency: adf4377: add adf4378 support Date: Mon, 22 Jul 2024 16:45:06 +0300 Message-ID: <20240722134508.25234-2-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240722134508.25234-1-antoniu.miclaus@analog.com> References: <20240722134508.25234-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: tUrVznoMtNlT3vH_U7XWk4k2fRHVSLa3 X-Proofpoint-GUID: tUrVznoMtNlT3vH_U7XWk4k2fRHVSLa3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-22_09,2024-07-22_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407220103 Add separate handling for adf4378 within the driver. The main difference between adf4377 and adf4378 is that adf4378 has only one output which is handled by only one gpio. Signed-off-by: Antoniu Miclaus --- changes in v2: - use chip_info structure to handle new added part (adf4378) - use spi_get_device_match_data - drop redundant check in if statement. drivers/iio/frequency/adf4377.c | 36 ++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf4377.c index 9284c13f1abb..82374f5d2695 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -400,7 +400,13 @@ enum muxout_select_mode { ADF4377_MUXOUT_HIGH = 0x8, }; +struct adf4377_chip_info { + const char *name; + bool has_gpio_enclk2; +}; + struct adf4377_state { + const struct adf4377_chip_info *chip_info; struct spi_device *spi; struct regmap *regmap; struct clk *clkin; @@ -889,11 +895,13 @@ static int adf4377_properties_parse(struct adf4377_state *st) return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk1), "failed to get the CE GPIO\n"); - st->gpio_enclk2 = devm_gpiod_get_optional(&st->spi->dev, "clk2-enable", - GPIOD_OUT_LOW); - if (IS_ERR(st->gpio_enclk2)) - return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk2), - "failed to get the CE GPIO\n"); + if (st->chip_info->has_gpio_enclk2) { + st->gpio_enclk2 = devm_gpiod_get_optional(&st->spi->dev, "clk2-enable", + GPIOD_OUT_LOW); + if (IS_ERR(st->gpio_enclk2)) + return dev_err_probe(&spi->dev, PTR_ERR(st->gpio_enclk2), + "failed to get the CE GPIO\n"); + } ret = device_property_match_property_string(&spi->dev, "adi,muxout-select", adf4377_muxout_modes, @@ -921,6 +929,17 @@ static int adf4377_freq_change(struct notifier_block *nb, unsigned long action, return NOTIFY_OK; } +static const struct adf4377_chip_info adf4377_chip_info_tbl[] = { + { + .name = "adf4377", + .has_gpio_enclk2 = true, + }, + { + .name = "adf4378", + .has_gpio_enclk2 = false, + }, +}; + static int adf4377_probe(struct spi_device *spi) { struct iio_dev *indio_dev; @@ -945,6 +964,7 @@ static int adf4377_probe(struct spi_device *spi) st->regmap = regmap; st->spi = spi; + st->chip_info = spi_get_device_match_data(spi); mutex_init(&st->lock); ret = adf4377_properties_parse(st); @@ -964,13 +984,15 @@ static int adf4377_probe(struct spi_device *spi) } static const struct spi_device_id adf4377_id[] = { - { "adf4377", 0 }, + { "adf4377", (kernel_ulong_t)&adf4377_chip_info_tbl[0] }, + { "adf4378", (kernel_ulong_t)&adf4377_chip_info_tbl[1] }, {} }; MODULE_DEVICE_TABLE(spi, adf4377_id); static const struct of_device_id adf4377_of_match[] = { - { .compatible = "adi,adf4377" }, + { .compatible = "adi,adf4377", .data = &adf4377_chip_info_tbl[0] }, + { .compatible = "adi,adf4378", .data = &adf4377_chip_info_tbl[1]}, {} }; MODULE_DEVICE_TABLE(of, adf4377_of_match);