From patchwork Fri Jul 26 23:15:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13743250 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3016A14EC5D for ; Fri, 26 Jul 2024 23:00:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034802; cv=none; b=hKaw71tfbtWhtz4Ogl0tjL8s+SkFlYt6uE2AqJQCt2eHmiyHDQyvim+gCmS2gAfeLC9PEgnPmaz+ZtUSeQucKkrk6/Fut2lWbNjIPxD4rhNTsjKWPlLvSzZjl5TFTv4mTS5a4iz15653d5jQ6Evk0s0v3AYijtxsE5cc8ZsmikA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034802; c=relaxed/simple; bh=BM3fxsZJz/PtyG0YFv5p6QB7ElzFaJgOm5d29hOI8Ic=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ah0CKDnrOVXakcF7ziN98Jz3/px98mq0XSjYZ61FhSy0vA1FxzqVVLWRaXUL5JfyOu3w/DByBfHj6v7DWt7s7TSB76XUkgnK64a6tRFqjKdbXX0zVz27xqDkPQO0Rmd+VuuWeuJ/fJEHQYgURWMvLrRoKVD3f9MK2f3DxdyBwac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hN4JIF/S; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hN4JIF/S" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-260ec349a63so32547fac.0 for ; Fri, 26 Jul 2024 16:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722034800; x=1722639600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jzNxfxFXYxhV3zOTEy2zl/WDEKQehno+mpouleGevmA=; b=hN4JIF/Sdf6c3tlNU+uBoCbSWpsbx1z/o+NS19ODScqaHm5CpiUb8YeF4Z94dAD5T3 lWhJV/7Dp2xyld51H1Y7sJZOXViN7a92kg1Y3av6qStadVSEaFS1RbFZnAHTwEZHDBiQ UhtK/QsrtxUtHJApCSLROtDvmU9n9iFZf2NptQm1InpqiC3D81ij33H+98ERgIjX9vMn /t4e/05ve5k7Vw6hxNQ0PqdqO3s4Mlrc8L4+vXzmeqjKcgPtmxbfhCFVRjunOiOsguWB V/VPVKtbfPPjliooMx3SSc3jgHArik3APWSLem88HbF9AQ8Y3OFykeyYEIH0hZ9PDHBR q+1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034800; x=1722639600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jzNxfxFXYxhV3zOTEy2zl/WDEKQehno+mpouleGevmA=; b=mgEcwTBJbyBz1e37LhsyXiY2mflPhRFGmSbOqf8cr0Aax7NYrniLb07/Vc1qCXctYM g1R77UyqlA3uSv+RuckSnSSWzYOD5bKe32l0aFMe5CTn6tLZePNBMsNHxhxAhmnNIJkV rVWWJu6y2CcWGp2u/LIoF6TQ59RX+GYis6FsfDGBEpY7+5oZapcuNP0ODQjhGn8WpuQW /4gLiN0QJjLcrMb7Wg1kofMSS/zilEBN+w1aU0pVJXGvy7n/SrGAYxXWg/ukGyzawB7Z DVdVRcNAoYiN4dX7aHL5sKuto+jz7AxLxXJVMWr7HDGRgqcJITKOKhYyDMPrU7l+kP0j 4zDg== X-Gm-Message-State: AOJu0Yy0qb5lUL7sVCOxUVAFtRKWeFhQcWH1VPScqZXgBKLkFQ2uZCkK XKwZLPFUpJDs1Za7/vgMyC5s2PMiK5kH3//dQxU/2ly7XMOWRsCqhcexoQ== X-Google-Smtp-Source: AGHT+IEC8LhqBLKFDJRVIUXmj+r6KOOnroQ3+vJ+VwubcPeuhxgjQZPtbKoOGLIupqAnyY7WNuZaIw== X-Received: by 2002:a05:6871:e2d7:b0:260:23bb:1087 with SMTP id 586e51a60fabf-264a3230e2fmr4806936fac.0.1722034799994; Fri, 26 Jul 2024 15:59:59 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm3308540b3a.178.2024.07.26.15.59.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 15:59:59 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 1/8] lpfc: Change diagnostic log flag during receipt of unknown ELS cmds Date: Fri, 26 Jul 2024 16:15:05 -0700 Message-Id: <20240726231512.92867-2-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240726231512.92867-1-justintee8345@gmail.com> References: <20240726231512.92867-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 During diagnostics, it has been determined that the 0115 log message for receipt of unknown ELS cmds does not benefit from trace buffer dumps. The trace buffer dump floods the console with unnecessary information, and the singular LOG_ELS flag has proven more beneficial in debugging efforts when dealing with unknown ELS cmds. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_els.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 929cbfc95163..50c0c0c91fdc 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -10742,7 +10742,7 @@ lpfc_els_unsol_buffer(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, rjt_exp = LSEXP_NOTHING_MORE; /* Unknown ELS command received from NPORT */ - lpfc_printf_vlog(vport, KERN_ERR, LOG_TRACE_EVENT, + lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS, "0115 Unknown ELS command x%x " "received from NPORT x%x\n", cmd, did); if (newnode) From patchwork Fri Jul 26 23:15:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13743251 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C13561514F8 for ; Fri, 26 Jul 2024 23:00:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034804; cv=none; b=tV2s3jXyBimR/aealvTyM5Kje2mL9FEXI7PT1GzjuzR9rpF3LZMfYDCJA63Dd1PtJJsSrCf45c8VSysUvsSKewR51CqtaYVaeAeFOyQMze1HXf1YEis2LFohzbnwZ2R0phjJ3FAB0OgWsSiGkBWLRKStjmr8cTElVyWJ+Z81BdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034804; c=relaxed/simple; bh=gTV1ckEZE0QwBd5mAQfb+2xvuMydgG8sNzQhZ7c4168=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hnuuCeVj2sw8e1E8WMfvmFlra+o+QVikGTzF/0kEwP3pkg6is2Fpk65EGtML4AuVmfJ2tfYMglyUjKEOzjIHTwx9cy7us1Mg2r1uZjYY1knFHPuHIORoQckttnWLXdV986jwQeRF+1IfsnRcg09KZwJxM5QtcOEF/mwQy/WbaKw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JgvMUkZp; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JgvMUkZp" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-70e9545d8b2so143014b3a.3 for ; Fri, 26 Jul 2024 16:00:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722034802; x=1722639602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nIoxDRwduWTKxH7+VDIAP9AK6F0RiGBltWj+tE+qQfY=; b=JgvMUkZpWgD4ZP62YzfGoOOOObwfTXxqffaOyxwMx7F0pesi6L6W6Wa2M3DtfGC/ju TcFTx3HEfUA0imQYFwEh/a14j599wWW07HMV9ecoYiDHOZlg3aBnns/42atzcou8w8AS 1q7Ktpc1IZ0j0jF5qW9jlbyKSqXgK87jmKi+N+pPCNgQvJFefKpKI828dqEJ/woERJT8 mR3/hH2KhrQWiy/345cTtvjbds3j9AGALKj9mZRIoHtx87utFdKxvp4bC7qN6IatUmjN EYtLu1GIq/+1R3VVIG0ypd/r/eJ8hCu2Gp+NNOX/dcel/M7lIaChCwF/2PCnjKUf55Io ANPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034802; x=1722639602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nIoxDRwduWTKxH7+VDIAP9AK6F0RiGBltWj+tE+qQfY=; b=nk6SH3BuT8Xk2dS5EQWVr9P5k6xNADTXi9diWtuAGOl3WOYUwpCYqgoWWXcHs5TXCk dyeRxhekGwz9qMI48gSviTdyI6CRGAQgFZqd6ZErldfGVNzYgqZeBvNsNiZy1yN9fPpW ITK02TKtDwVH9WSL4ESZSrmd5lb0Xz2oDFuorlOgHx8HqnBXOiZOefNO0GR8y0fPDh3C +A68pm8gsvGbggrLO+8fnbIDgpA9qPRUnEzGwrE+/2dfYUmdib128E3amepU9/va9NlJ vmPdVr8jn3Gv+04m8nC5AheZme6MXdF6lPqDt1nJru1i/IsviaU540gn0yjS49JRnt1D z++Q== X-Gm-Message-State: AOJu0YxTmCmzqO1eDqshW5Zd3nsc3ZTJo5MnfHN+cAgBbqJ+VYYI1I5a C0aNm6+XTCoNOZ0J8J69g7p0iOBvEHC0BQEdbuaHzbgTblLO/R5jtfbZSQ== X-Google-Smtp-Source: AGHT+IG7CMJez6iX9Rk02Dqqu7URZE+AtRCKravEXta9NQDhqU4QrA3sOAXMxRQ30uiySylrmWcfzg== X-Received: by 2002:a05:6a00:8596:b0:70e:a06f:7057 with SMTP id d2e1a72fcca58-70eaca93f4amr4854912b3a.4.1722034801867; Fri, 26 Jul 2024 16:00:01 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm3308540b3a.178.2024.07.26.16.00.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 16:00:01 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 2/8] lpfc: Remove redundant vport assignment when building an abort request Date: Fri, 26 Jul 2024 16:15:06 -0700 Message-Id: <20240726231512.92867-3-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240726231512.92867-1-justintee8345@gmail.com> References: <20240726231512.92867-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The lpfc_sli_issue_abort_iotag routine has a redundant assignment of abtsiocbp->vport = vport; The duplicate lines are from a previous refactoring, and this patch removes the accidental redundancy. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_sli.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 88debef2fb6d..d240bbded4c8 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -12473,8 +12473,6 @@ lpfc_sli_issue_abort_iotag(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, cmdiocb->iocb.ulpClass, LPFC_WQE_CQ_ID_DEFAULT, ia, false); - abtsiocbp->vport = vport; - /* ABTS WQE must go to the same WQ as the WQE to be aborted */ abtsiocbp->hba_wqidx = cmdiocb->hba_wqidx; if (cmdiocb->cmd_flag & LPFC_IO_FCP) From patchwork Fri Jul 26 23:15:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13743252 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9700F1514EF for ; Fri, 26 Jul 2024 23:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034806; cv=none; b=TUJ23t3Jxtx/nzJWWZ8jgQnhoEwjUr17SnQFDSnlNt9QCtuF8J7zOE+cLZDe5y/iu7fMp89Fp2XD19oSMh4LVakCs3IltvnStmwvYf6zut5VUuWyHeZPKQYzS36uY9pSDNwVTsquwk+LlEgmWD+HSBps6jvKpQ3AD0ejfk7IHMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034806; c=relaxed/simple; bh=lAiUL8ce01UJECO5BUALuMocYkyyrqLycbdb74oLkDU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F4FVXc3kBuol0kr1nCJgCPphszBQBxGTuLxbsuRXOzrIyBSjRm9fZyV1FRWwe6NCwbIAxmS6mskdvMc0oFnrs4J4ksw24etdsQZZOYoqzNJlj/BS4k/IYj8q4FHJSt5PkBttjfGE2Krec9JX8BhX/LzWdoR3Q8B2T2SGCcNVELI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mfjEnyGE; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mfjEnyGE" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-81f82478b70so11787639f.0 for ; Fri, 26 Jul 2024 16:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722034803; x=1722639603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+O6rIP5ddPDwYqH7AORHrX49Sj0oJNOV55RUSW14M9o=; b=mfjEnyGEKibSA7jLv6rAmI0uGy/gjR0eC6nJwcsMGiVAs3y/f4wFtOLAM4q415VqIE Iyp5cZsY3ZThrPR2mawfw1333KY0mEay70qF+6QoChJMVeQI/3qXzQe1A4b4kerbf5jh 8HasbHGj2NKSsZ+J7LMEYGQ8IQqK9bGo9S1dCyd7vBnvRVTvgUjmWuNdNljqseDKJOvS F2oVmTFyjqYhFtU0dAfErji3l5b66BRDuAWW7KNsBbimUwAvx+3KcAMouwxSp9Buw54/ ICTzVOQ4TWjZCU/BNn2aNNXeBihhBisJ/wKvJEenZaEgXGCA21YacCH/o1Hm4pZeuJUO a19w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034803; x=1722639603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+O6rIP5ddPDwYqH7AORHrX49Sj0oJNOV55RUSW14M9o=; b=ngPKhl0Jqm5J5hnBVOWUyi2zPIz65qvV8TopX8hsR7ZNvki0CAPFOLUAmRm2Sd5/B3 41YJAD3k1BCxfABBji72c4oSMRK2KVUYh5nVkIpsl/CzVMf2TGkumIV6vFNs3Dslg4q4 bJ0Y5p8RnHFzb4Odf0jZTluba4xbXbLUEJ2XvG+AWEj19+bMKxgWJYHyYztcHMkfFGE4 yOFGWs9MoDy7irt/BKO/iWY1U4XHJEUhodZ7VZYVYibxWxEBhdpXJNRbZvxI3gJgvXkj L2sOiyylsBdDI/nGZ/YT65AiNYEuSzrMRzwbxwkRXYbS8S/GxpxuFeAL/6PpgUYmsVJd WnhA== X-Gm-Message-State: AOJu0YwN/8yll2Aw/+yWrGcgukKqCl8E+4PVL0dcM51WswVoNpN83PEA 9KaTudwa585FazizptY2IYmQ2VhYv/4U+nUMlEGKJsblVhf0ugbMhekiZw== X-Google-Smtp-Source: AGHT+IGrl0H883ybNatSc+zsQi5gREFyhf370651VwyixprBx/KrSf7w+72/F4GeWhCgKJa6gGjX8Q== X-Received: by 2002:a05:6e02:12c7:b0:39a:eba6:6a07 with SMTP id e9e14a558f8ab-39aeba69492mr9196925ab.3.1722034803518; Fri, 26 Jul 2024 16:00:03 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm3308540b3a.178.2024.07.26.16.00.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 16:00:03 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 3/8] lpfc: Validate hdwq pointers before dereferencing in reset/errata paths Date: Fri, 26 Jul 2024 16:15:07 -0700 Message-Id: <20240726231512.92867-4-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240726231512.92867-1-justintee8345@gmail.com> References: <20240726231512.92867-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When the HBA is undergoing a reset or is handling an errata event, NULL ptr dereference crashes may occur in routines such as lpfc_sli_flush_io_rings, lpfc_dev_loss_tmo_callbk, or lpfc_abort_handler. Add NULL ptr checks before dereferencing hdwq pointers that may have been freed due to operations colliding with a reset or errata event handler. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_hbadisc.c | 3 ++- drivers/scsi/lpfc/lpfc_scsi.c | 13 +++++++++++-- drivers/scsi/lpfc/lpfc_sli.c | 11 +++++++++++ 3 files changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 6943f6c6395c..f21c5993e8d7 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -175,7 +175,8 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport) ndlp->nlp_state, ndlp->fc4_xpt_flags); /* Don't schedule a worker thread event if the vport is going down. */ - if (test_bit(FC_UNLOADING, &vport->load_flag)) { + if (test_bit(FC_UNLOADING, &vport->load_flag) || + !test_bit(HBA_SETUP, &phba->hba_flag)) { spin_lock_irqsave(&ndlp->lock, iflags); ndlp->rport = NULL; diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index 98ce9d97a225..60cd60ebff38 100644 --- a/drivers/scsi/lpfc/lpfc_scsi.c +++ b/drivers/scsi/lpfc/lpfc_scsi.c @@ -5555,11 +5555,20 @@ lpfc_abort_handler(struct scsi_cmnd *cmnd) iocb = &lpfc_cmd->cur_iocbq; if (phba->sli_rev == LPFC_SLI_REV4) { - pring_s4 = phba->sli4_hba.hdwq[iocb->hba_wqidx].io_wq->pring; - if (!pring_s4) { + /* if the io_wq & pring are gone, the port was reset. */ + if (!phba->sli4_hba.hdwq[iocb->hba_wqidx].io_wq || + !phba->sli4_hba.hdwq[iocb->hba_wqidx].io_wq->pring) { + lpfc_printf_vlog(vport, KERN_WARNING, LOG_FCP, + "2877 SCSI Layer I/O Abort Request " + "IO CMPL Status x%x ID %d LUN %llu " + "HBA_SETUP %d\n", FAILED, + cmnd->device->id, + (u64)cmnd->device->lun, + test_bit(HBA_SETUP, &phba->hba_flag)); ret = FAILED; goto out_unlock_hba; } + pring_s4 = phba->sli4_hba.hdwq[iocb->hba_wqidx].io_wq->pring; spin_lock(&pring_s4->ring_lock); } /* the command is in process of being cancelled */ diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index d240bbded4c8..332b8d2348e9 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -4687,6 +4687,17 @@ lpfc_sli_flush_io_rings(struct lpfc_hba *phba) /* Look on all the FCP Rings for the iotag */ if (phba->sli_rev >= LPFC_SLI_REV4) { for (i = 0; i < phba->cfg_hdw_queue; i++) { + if (!phba->sli4_hba.hdwq || + !phba->sli4_hba.hdwq[i].io_wq) { + lpfc_printf_log(phba, KERN_ERR, LOG_SLI, + "7777 hdwq's deleted %lx " + "%lx %x %x\n", + phba->pport->load_flag, + phba->hba_flag, + phba->link_state, + phba->sli.sli_flag); + return; + } pring = phba->sli4_hba.hdwq[i].io_wq->pring; spin_lock_irq(&pring->ring_lock); From patchwork Fri Jul 26 23:15:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13743253 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 058E82BAE2 for ; Fri, 26 Jul 2024 23:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034807; cv=none; b=pOyBbUaZSQGDil1ETTh4nEkfSEzJuu/9zf6BOmR+h0JxjAbWuTBs0CPlprollenqFFyPIrEs5oNrD5s6K0agq5CHZTRSdbfweNQvAEhPZvrUH1E805wW2lybCuqPbO86P9S78ssirBHDAxNOI13qEjlYVqJQvtXI8ONvV9XzInU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034807; c=relaxed/simple; bh=KTvQTCs5FRJ9N6wykTchg0wPASaDTlQh/X0EIebEh6g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=N4aqxzZjP9PKXa7LyWdaKHIOLqqzcrD0LcV/vsDa/T1kYQMFeqPRY9qSg6Eo1Kw3iGRfCTzCddWpeM9fgFFwmuFX2/KaW4m+h8eLt60AsMROroNNbSXM3kMiP7HNfBdjvpkBM115WMsfVnXuJKrQWHSBpUxDvroEohj6UvANgwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qkyb2MjN; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qkyb2MjN" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3db10d8830aso169967b6e.0 for ; Fri, 26 Jul 2024 16:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722034805; x=1722639605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FUx43Ks49fCSXSh8Vm3DV/SnJp+l7FEdN9Tv2732TjI=; b=Qkyb2MjNhb42sh+6RqipA7azChFf1i6x6JhVKQmrVpTq+UGLcwkDhfUSCJfxwRZAHW JZn1V36ANO87uLCwjGHHLtdLeNH29xNg0VjR47GqlHfndk+wUHEtwAEMhpAKcc/zL2b8 phf/QUGV0MIxYHCEAmClBoV8X1AxpQ4NtbTB3mnoP7/DxybGUDGetJJlz3lVIESI5F3G BAPWjBnapj2PkjYx6ck6SmUNbZFwnVyvSwOdXvTEb99/+1emOoFzgt273V9WQX3Ovqh3 KnfHms869yTX3hy3PixrYZDWRfxw1hN25cwN88Hf52WwD3AheW5sPFZ3RWsb4rr92o0L +Oaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034805; x=1722639605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FUx43Ks49fCSXSh8Vm3DV/SnJp+l7FEdN9Tv2732TjI=; b=iIiLzCyQ8eVlWGzCneU+9FNvW58SpFhCtiYqEsS51uW3v/ZstP1FbMFFfV17GHRbBE X5GchziNmoAN1XHEaZUcCkmh/dOZughf88kK+mlrZT0+j08qzcI/nUbhUHLSiTq7S0Rx H9crc9h86EPFf/ddrpy74bs9OxBoMGL50VAt0pZQn/RdXCv6GnmNfB8t4lFuUzzBE/rw n6Zypl92yvuB6mV8KyYZElmY6q8DqacjV8h5IdRmjz2S7KF9lzIkiFWwjlv1qmoSB/bT fu4UarSjUsMp9WvbxDGGI++MQN6QVMGa8evg6CxhrLnRXokUAbtmRMQufcJLxcmzxI75 agTw== X-Gm-Message-State: AOJu0YwBsGiOx6OFpjW7PVNS/sdr/KmlO5/63PwsrDCQRF8SQSNMmbnl NprkHep7a5izLMfeq44rG+Kg4w53zpuXSek3octjO7HywlH1IR5oEYctEQ== X-Google-Smtp-Source: AGHT+IEBgeIMoRlipOld+iXLYz/jodT4/iT7j9iGH937arUrIZpmf16N4ZdvJ/CyzjA2Sj2kNIuxxQ== X-Received: by 2002:a05:6871:e2d0:b0:261:934:873d with SMTP id 586e51a60fabf-264be1e0f03mr4669651fac.5.1722034804863; Fri, 26 Jul 2024 16:00:04 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm3308540b3a.178.2024.07.26.16.00.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 16:00:04 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 4/8] lpfc: Fix unintentional double clearing of vmid_flag Date: Fri, 26 Jul 2024 16:15:08 -0700 Message-Id: <20240726231512.92867-5-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240726231512.92867-1-justintee8345@gmail.com> References: <20240726231512.92867-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The vport->vmid_flag is unintentionally cleared twice after an issue_lip via the lpfc_reinit_vmid routine. The first call to lpfc_reinit_vmid is in lpfc_cmpl_els_flogi. Then lpfc_cmpl_els_flogi_fabric calls lpfc_register_new_vport, which calls lpfc_cmpl_reg_new_vport when the mbox command completes and calls lpfc_reinit_vmid a second time. Fix by moving the vmid_flag clear outside of the lpfc_reinit_vmid routine so that vmid_flag is only cleared once upon FLOGI completion. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_els.c | 4 +++- drivers/scsi/lpfc/lpfc_vmid.c | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 50c0c0c91fdc..6d49e23f6a62 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -1099,8 +1099,10 @@ lpfc_cmpl_els_flogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, sp->cmn.priority_tagging, kref_read(&ndlp->kref)); /* reinitialize the VMID datastructure before returning */ - if (lpfc_is_vmid_enabled(phba)) + if (lpfc_is_vmid_enabled(phba)) { lpfc_reinit_vmid(vport); + vport->vmid_flag = 0; + } if (sp->cmn.priority_tagging) vport->phba->pport->vmid_flag |= (LPFC_VMID_ISSUE_QFPA | LPFC_VMID_TYPE_PRIO); diff --git a/drivers/scsi/lpfc/lpfc_vmid.c b/drivers/scsi/lpfc/lpfc_vmid.c index 773e02ae20c3..cf8ba840d0ea 100644 --- a/drivers/scsi/lpfc/lpfc_vmid.c +++ b/drivers/scsi/lpfc/lpfc_vmid.c @@ -321,6 +321,5 @@ lpfc_reinit_vmid(struct lpfc_vport *vport) if (!hash_empty(vport->hash_table)) hash_for_each_safe(vport->hash_table, bucket, tmp, cur, hnode) hash_del(&cur->hnode); - vport->vmid_flag = 0; write_unlock(&vport->vmid_lock); } From patchwork Fri Jul 26 23:15:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13743254 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3328D154456 for ; Fri, 26 Jul 2024 23:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034808; cv=none; b=Ylmw4U0lohjVg4s/fg75hA/n0mM6bHvZTUy8SUvvobvrJlNj0+kxD9QdoUGI/u6qx5fW/RVVx8UMBobd29FX2xrbIBprXYfiLGxeRhO5V3WNqKScvhkkqQA6ono5d5ge1+U5wvuUHKdcs5IGdOucorMVTzzd8ICVOwKh2nS8Cuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034808; c=relaxed/simple; bh=geS1UQbXcXnkW/yiSUsID3n7alvo9NI0iJ1i0JTVVEE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bO59dAxq5go4clnZg/Q7RIEe0iEvH+8qWWo3D++9PX5lFOMYszHegW53XBNUDwlL/kL5xrrmibKCaqeTzFclDMu3jGl4UQ0G//GJcolfr01RUz0cCWG0Ok8JtYQ4oBDfhv+845oP3/B3KpvCsTEF1Z7IkryCBeSAQZxD/vIwJ24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZfnHKdWr; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZfnHKdWr" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2cb5a947b7dso221857a91.3 for ; Fri, 26 Jul 2024 16:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722034806; x=1722639606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ytktVYeSc9xWuiSFp3A3dHAJ+APcHDsQuE2Mmxd6Iok=; b=ZfnHKdWrMvBd4n8NPmyj5rnAz6JJqVbPUoeXvf/10f5ulIaw6ZLwg4cX8Ifsd44LPf OQ1ziBst2nWEeXJxE4SEMMN7Cvjpfa2znpP1LSp/HB7+b28Ga+C3WVkjT/GSIiKXMIYn B0HxRcRJNpgX3ZFsmTDIGBEQPFAfT0P/MFf+nKzJnUJ+mb+pjFRkghkM4mT5qSUIvc7A 975A+uzKc7FECicMKljH9jvZijnofz61SxZ9w+FggENCOdUdX/kJgD7g7inr5sveZE7N ymkmNIG1+d1Hw0MMm7EMI9+hxQ8H2/zn4bSAkMYuMJL7Fy7umLSk1qvxSVR7D6HCWQH+ IK7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034806; x=1722639606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ytktVYeSc9xWuiSFp3A3dHAJ+APcHDsQuE2Mmxd6Iok=; b=Apd2pfpU1kqiUwvOZtlYmmn/BXtJCq+2WRLVQttXasDhJO+Mj2xKGIC5gk9vqbHVIe AoK9cGovXJSQ9LCOTNklIZX59i0pEXid+dK6ygkrut/FTQx0/IT5DH/dcrka6KxoxWOh yYf/dkuqhibvTTDxY7zsHd2idEjtdmrnhIJGuGyPwXaJTd/xfwzXaQqJf3aPxsjgocLV 5GOuQCcXzJ1EDB+DgWxl3AplXUcHXPe72Md4ntOUVEgj5WIhPHVNl3Y+1LNybV5FX2+7 ERc7FDjdQYqhe3p3q+5YHvkbsDP7hLmM5OeiNl9TAYDJJBOLqdI0yn4A94+eg0GGSy5L 2P+Q== X-Gm-Message-State: AOJu0YwCa5Kmi8UhYvKYIm+pIEegbEq0DID/okt0wF09dgEVQD8wBsaz kmcylJfs3o9mZRqUklzTXnddOp4Ph3ZX036slvNuGbbQt400RLZoZ+6vWA== X-Google-Smtp-Source: AGHT+IEAJvclkMMfTl0/dfVhGQKyYsU5HYbvI/t1BRP4o9sb08Ja5g35a0CVFJ6TiVG1KU7cajgmhg== X-Received: by 2002:a05:6a21:710a:b0:1c3:c1cf:7b98 with SMTP id adf61e73a8af0-1c477448549mr4791073637.7.1722034806235; Fri, 26 Jul 2024 16:00:06 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm3308540b3a.178.2024.07.26.16.00.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 16:00:06 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 5/8] lpfc: Fix unsolicited FLOGI kref imbalance when in direct attached topology Date: Fri, 26 Jul 2024 16:15:09 -0700 Message-Id: <20240726231512.92867-6-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240726231512.92867-1-justintee8345@gmail.com> References: <20240726231512.92867-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In direct attached topology, certain target vendors that are quick to issue FLOGI followed by a cable pull for more than dev_loss_tmo may result in a kref imbalance for the remote port ndlp object. Add an nlp_get when the defer_flogi_acc flag is set. This is expected to balance the nlp_put in the defer_flogi_acc clause in the lpfc_issue_els_flogi routine. Because we need to retain the ndlp ptr, reorganize all of the defer_flogi_acc information into one lpfc_defer_flogi_acc struct. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc.h | 12 ++++++--- drivers/scsi/lpfc/lpfc_els.c | 46 +++++++++++++++++++------------- drivers/scsi/lpfc/lpfc_hbadisc.c | 11 ++++++-- 3 files changed, 46 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h index 7c147d6ea8a8..e5a9c5a323f8 100644 --- a/drivers/scsi/lpfc/lpfc.h +++ b/drivers/scsi/lpfc/lpfc.h @@ -306,6 +306,14 @@ struct lpfc_stats { struct lpfc_hba; +/* Data structure to keep withheld FLOGI_ACC information */ +struct lpfc_defer_flogi_acc { + bool flag; + u16 rx_id; + u16 ox_id; + struct lpfc_nodelist *ndlp; + +}; #define LPFC_VMID_TIMER 300 /* timer interval in seconds */ @@ -1430,9 +1438,7 @@ struct lpfc_hba { uint16_t vlan_id; struct list_head fcf_conn_rec_list; - bool defer_flogi_acc_flag; - uint16_t defer_flogi_acc_rx_id; - uint16_t defer_flogi_acc_ox_id; + struct lpfc_defer_flogi_acc defer_flogi_acc; spinlock_t ct_ev_lock; /* synchronize access to ct_ev_waiters */ struct list_head ct_ev_waiters; diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 6d49e23f6a62..b5a8d050419a 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -1392,7 +1392,7 @@ lpfc_issue_els_flogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, phba->link_flag &= ~LS_EXTERNAL_LOOPBACK; /* Check for a deferred FLOGI ACC condition */ - if (phba->defer_flogi_acc_flag) { + if (phba->defer_flogi_acc.flag) { /* lookup ndlp for received FLOGI */ ndlp = lpfc_findnode_did(vport, 0); if (!ndlp) @@ -1406,34 +1406,38 @@ lpfc_issue_els_flogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, if (phba->sli_rev == LPFC_SLI_REV4) { bf_set(wqe_ctxt_tag, &defer_flogi_acc.wqe.xmit_els_rsp.wqe_com, - phba->defer_flogi_acc_rx_id); + phba->defer_flogi_acc.rx_id); bf_set(wqe_rcvoxid, &defer_flogi_acc.wqe.xmit_els_rsp.wqe_com, - phba->defer_flogi_acc_ox_id); + phba->defer_flogi_acc.ox_id); } else { icmd = &defer_flogi_acc.iocb; - icmd->ulpContext = phba->defer_flogi_acc_rx_id; + icmd->ulpContext = phba->defer_flogi_acc.rx_id; icmd->unsli3.rcvsli3.ox_id = - phba->defer_flogi_acc_ox_id; + phba->defer_flogi_acc.ox_id; } lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "3354 Xmit deferred FLOGI ACC: rx_id: x%x," " ox_id: x%x, hba_flag x%lx\n", - phba->defer_flogi_acc_rx_id, - phba->defer_flogi_acc_ox_id, phba->hba_flag); + phba->defer_flogi_acc.rx_id, + phba->defer_flogi_acc.ox_id, phba->hba_flag); /* Send deferred FLOGI ACC */ lpfc_els_rsp_acc(vport, ELS_CMD_FLOGI, &defer_flogi_acc, ndlp, NULL); - phba->defer_flogi_acc_flag = false; - vport->fc_myDID = did; + phba->defer_flogi_acc.flag = false; - /* Decrement ndlp reference count to indicate the node can be - * released when other references are removed. + /* Decrement the held ndlp that was incremented when the + * deferred flogi acc flag was set. */ - lpfc_nlp_put(ndlp); + if (phba->defer_flogi_acc.ndlp) { + lpfc_nlp_put(phba->defer_flogi_acc.ndlp); + phba->defer_flogi_acc.ndlp = NULL; + } + + vport->fc_myDID = did; } return 0; @@ -8456,9 +8460,9 @@ lpfc_els_rcv_flogi(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, /* Defer ACC response until AFTER we issue a FLOGI */ if (!test_bit(HBA_FLOGI_ISSUED, &phba->hba_flag)) { - phba->defer_flogi_acc_rx_id = bf_get(wqe_ctxt_tag, + phba->defer_flogi_acc.rx_id = bf_get(wqe_ctxt_tag, &wqe->xmit_els_rsp.wqe_com); - phba->defer_flogi_acc_ox_id = bf_get(wqe_rcvoxid, + phba->defer_flogi_acc.ox_id = bf_get(wqe_rcvoxid, &wqe->xmit_els_rsp.wqe_com); vport->fc_myDID = did; @@ -8466,11 +8470,17 @@ lpfc_els_rcv_flogi(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb, lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "3344 Deferring FLOGI ACC: rx_id: x%x," " ox_id: x%x, hba_flag x%lx\n", - phba->defer_flogi_acc_rx_id, - phba->defer_flogi_acc_ox_id, phba->hba_flag); + phba->defer_flogi_acc.rx_id, + phba->defer_flogi_acc.ox_id, phba->hba_flag); - phba->defer_flogi_acc_flag = true; + phba->defer_flogi_acc.flag = true; + /* This nlp_get is paired with nlp_puts that reset the + * defer_flogi_acc.flag back to false. We need to retain + * a kref on the ndlp until the deferred FLOGI ACC is + * processed or cancelled. + */ + phba->defer_flogi_acc.ndlp = lpfc_nlp_get(ndlp); return 0; } @@ -10506,7 +10516,7 @@ lpfc_els_unsol_buffer(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, lpfc_els_rcv_flogi(vport, elsiocb, ndlp); /* retain node if our response is deferred */ - if (phba->defer_flogi_acc_flag) + if (phba->defer_flogi_acc.flag) break; if (newnode) lpfc_disc_state_machine(vport, ndlp, NULL, diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index f21c5993e8d7..35c9181c6608 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -1255,7 +1255,14 @@ lpfc_linkdown(struct lpfc_hba *phba) lpfc_scsi_dev_block(phba); offline = pci_channel_offline(phba->pcidev); - phba->defer_flogi_acc_flag = false; + /* Decrement the held ndlp if there is a deferred flogi acc */ + if (phba->defer_flogi_acc.flag) { + if (phba->defer_flogi_acc.ndlp) { + lpfc_nlp_put(phba->defer_flogi_acc.ndlp); + phba->defer_flogi_acc.ndlp = NULL; + } + } + phba->defer_flogi_acc.flag = false; /* Clear external loopback plug detected flag */ phba->link_flag &= ~LS_EXTERNAL_LOOPBACK; @@ -1377,7 +1384,7 @@ lpfc_linkup_port(struct lpfc_vport *vport) (vport != phba->pport)) return; - if (phba->defer_flogi_acc_flag) { + if (phba->defer_flogi_acc.flag) { clear_bit(FC_ABORT_DISCOVERY, &vport->fc_flag); clear_bit(FC_RSCN_MODE, &vport->fc_flag); clear_bit(FC_NLP_MORE, &vport->fc_flag); From patchwork Fri Jul 26 23:15:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13743255 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB42E1527BB for ; Fri, 26 Jul 2024 23:00:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034810; cv=none; b=nPnlvOjGB4bM3VZLx7D6BJyadtgfa3j+4EQnbk0Uf4ZyhX9eqGSZqLvKnHrEUzzmFZl8HR2I1gyh74Q5E+yMI+GnK/vWgBbKEH8W3Vr1vOL6/CRWHFEjocc4r6V5oEChih5XxL1J1aBe5MH3QhawT5qF05kyN5XGmlg0cKPnBfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034810; c=relaxed/simple; bh=YfC8+wMtK3tDA8+FCyrmBh5/pAjFiuwzJdBXNu5YcrU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KTA/8JppL8gUHNLMjRkYpHX1AD+MWxpmn0O0TLGoSpKdM6HZ7Uy8HMBQ4cUw+VFI7EY1Y28YCo6fmFFTumDRxfX+S76+UZDJ9MH0WkbBmtSCR8Ii8SS4NT0bC4b89dMptu+jUnKAb7MhzF7bdEm4TcgC6z1mJ4r4La4X1u0WrpA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tt+1Gola; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tt+1Gola" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3db10d8830aso169970b6e.0 for ; Fri, 26 Jul 2024 16:00:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722034808; x=1722639608; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MddidqU/RGIlO0vgZMgZIJgKpfz/9aGGUJheDEJs4CY=; b=Tt+1GolaTHFh/FV0Q1EdSORZyFW5p+9jgi7uZG0SnL3cOITmJXQUDY+DFya0ClVEdF 8wK6h23DuScq8WrGYLdnVpvrMcOF/p2Hr437biXOfHnq5/hbH0jGDp3zuu4B6fB0b51n Pm48Z9DlsPciZKN2Y9w6vyH6Um9tmr0uUgR1OLk3xYVMOTbXnK1gzqmrBKA8hWct1q6O PDYAPX5l2q9YYGuzF+U3QEyBJa0Xi/pDdxfMJj/nrVbvElrk/zV0KMRmR2aFZct6DvDy eFlDJa0IKqa5AOUp+mM1WX0byQEUCoCxMKTUQz04ei3t5xTnqarsdbjwbDW4UTJA41K7 MOsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034808; x=1722639608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MddidqU/RGIlO0vgZMgZIJgKpfz/9aGGUJheDEJs4CY=; b=a23Nt+4HsrTyGjh8k7BApdGdse4edpgSO9ee9GzSCqI6drGNoWg0k0IH/dD2BtwyGs 7ha9ZFdEH5nm3AvN5BdD/Mkenl1+AAD0v18OS5BNhv4SPTvrWzA16ZF+l3EDLpkULPC1 E6PwIxltehKh8gWuwfpjoRJoZL1sTawrG8lit3iD/qy6fPUR0ksqHU5G4pQTVSixXC2L +N5VzN4ajd9Dzcc2bHUni22USO0jM0Gr1oa8lnUdgWnaqPPKMGCtzzHO/k2OV3Bw6sZZ ffqv0e6M4yr4lEH/i+4vXrcOON1ilb2gW/kN5W20kan9RHwRVNzDw/FLaLMCSiOPk8ld kHSA== X-Gm-Message-State: AOJu0YyKwnAhBc98vahKjFelJREq9PBf/TzRhI9hIQARrrsY+EyD9aSz 3R7SoNY6YVx57k6K+lH+/6ebuN2f8UuGALzWHxC1HqmYyUNnBpJIzbMJug== X-Google-Smtp-Source: AGHT+IEElMmc+GWvOT/Tsw9MFFeh3lY1tuJpTH3JuFvn1fQJl33HhCOZcVBzXbn0GCDIN/SUrCdy/Q== X-Received: by 2002:a05:687c:2c19:b0:259:f03c:4e90 with SMTP id 586e51a60fabf-264a35d1c79mr4671087fac.4.1722034807606; Fri, 26 Jul 2024 16:00:07 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm3308540b3a.178.2024.07.26.16.00.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 16:00:07 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 6/8] lpfc: Update PRLO handling in direct attached topology Date: Fri, 26 Jul 2024 16:15:10 -0700 Message-Id: <20240726231512.92867-7-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240726231512.92867-1-justintee8345@gmail.com> References: <20240726231512.92867-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 A kref imbalance occurs when handling an unsolicited PRLO in direct attached topology. Rework PRLO rcv handling when in MAPPED state. Save the state that we were handling a PRLO by setting nlp_last_elscmd to ELS_CMD_PRLO. Then in the lpfc_cmpl_els_logo_acc completion routine, manually restart discovery. By issuing the PLOGI, which nlp_gets, before nlp_put at the end of the lpfc_cmpl_els_logo_acc routine, we are saving us from a final nlp_put. And, we are still allowing the unreg_rpi to happen. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_els.c | 27 ++++++++++++++++----------- drivers/scsi/lpfc/lpfc_nportdisc.c | 22 ++++++++++++++++++++-- 2 files changed, 36 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index b5a8d050419a..de0ec945d2f1 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -5246,9 +5246,10 @@ lpfc_cmpl_els_logo_acc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, /* ACC to LOGO completes to NPort */ lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "0109 ACC to LOGO completes to NPort x%x refcnt %d " - "Data: x%x x%x x%x\n", - ndlp->nlp_DID, kref_read(&ndlp->kref), ndlp->nlp_flag, - ndlp->nlp_state, ndlp->nlp_rpi); + "last els x%x Data: x%x x%x x%x\n", + ndlp->nlp_DID, kref_read(&ndlp->kref), + ndlp->nlp_last_elscmd, ndlp->nlp_flag, ndlp->nlp_state, + ndlp->nlp_rpi); /* This clause allows the LOGO ACC to complete and free resources * for the Fabric Domain Controller. It does deliberately skip @@ -5260,18 +5261,22 @@ lpfc_cmpl_els_logo_acc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, goto out; if (ndlp->nlp_state == NLP_STE_NPR_NODE) { - /* If PLOGI is being retried, PLOGI completion will cleanup the - * node. The NLP_NPR_2B_DISC flag needs to be retained to make - * progress on nodes discovered from last RSCN. - */ - if ((ndlp->nlp_flag & NLP_DELAY_TMO) && - (ndlp->nlp_last_elscmd == ELS_CMD_PLOGI)) - goto out; - if (ndlp->nlp_flag & NLP_RPI_REGISTERED) lpfc_unreg_rpi(vport, ndlp); + /* If came from PRLO, then PRLO_ACC is done. + * Start rediscovery now. + */ + if (ndlp->nlp_last_elscmd == ELS_CMD_PRLO) { + spin_lock_irq(&ndlp->lock); + ndlp->nlp_flag |= NLP_NPR_2B_DISC; + spin_unlock_irq(&ndlp->lock); + ndlp->nlp_prev_state = ndlp->nlp_state; + lpfc_nlp_set_state(vport, ndlp, NLP_STE_PLOGI_ISSUE); + lpfc_issue_els_plogi(vport, ndlp->nlp_DID, 0); + } } + out: /* * The driver received a LOGO from the rport and has ACK'd it. diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c index f6a53446e57f..4574716c8764 100644 --- a/drivers/scsi/lpfc/lpfc_nportdisc.c +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c @@ -2652,8 +2652,26 @@ lpfc_rcv_prlo_mapped_node(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, /* flush the target */ lpfc_sli_abort_iocb(vport, ndlp->nlp_sid, 0, LPFC_CTX_TGT); - /* Treat like rcv logo */ - lpfc_rcv_logo(vport, ndlp, cmdiocb, ELS_CMD_PRLO); + /* Send PRLO_ACC */ + spin_lock_irq(&ndlp->lock); + ndlp->nlp_flag |= NLP_LOGO_ACC; + spin_unlock_irq(&ndlp->lock); + lpfc_els_rsp_acc(vport, ELS_CMD_PRLO, cmdiocb, ndlp, NULL); + + /* Save ELS_CMD_PRLO as the last elscmd and then set to NPR. + * lpfc_cmpl_els_logo_acc is expected to restart discovery. + */ + ndlp->nlp_last_elscmd = ELS_CMD_PRLO; + ndlp->nlp_prev_state = ndlp->nlp_state; + + lpfc_printf_vlog(vport, KERN_INFO, LOG_NODE | LOG_ELS | LOG_DISCOVERY, + "3422 DID x%06x nflag x%x lastels x%x ref cnt %u\n", + ndlp->nlp_DID, ndlp->nlp_flag, + ndlp->nlp_last_elscmd, + kref_read(&ndlp->kref)); + + lpfc_nlp_set_state(vport, ndlp, NLP_STE_NPR_NODE); + return ndlp->nlp_state; } From patchwork Fri Jul 26 23:15:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13743256 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBA2514E2CC for ; Fri, 26 Jul 2024 23:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034811; cv=none; b=XqPuAjOK++rXFapzUlSE9vAi9FgkWO1l+DOfufMqH0XB0Z8600iEyyj+wgq0cU32vOq+lqmdrcE7SN188WJMBsHiPAuNIOxseO2sSJLX5WUeCO3uuwcYOiQxzjCjFg33h0Ao66gdr5QCtyBwXpn/ddRcrx7nMWPZskXXokQg+ks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034811; c=relaxed/simple; bh=x78SigZZKpv4PGuy6dVQbxwWxETEUsAp+e9sK/1QOmQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Qt8VtUCeSnZD0bQsUbhq09CBr6Fm2OcOKuk75GJnMHAv/VtYH54UEHchL10X91oUTLZnLvTqj7S9mKDmt/LhETDeHgcUl9nj0s2dPY1phvdFXXcF12K2/Lgcne/0qiuCUw7179sqL28qzOUMHiVjINuCsBKEhYNkF5bASnx4wIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vvrje0NE; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vvrje0NE" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2cb7344ed8cso239096a91.2 for ; Fri, 26 Jul 2024 16:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722034809; x=1722639609; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hkGGT6Cl4eQMAs1FA6JIr0lCMLReUe6VTrJIDGqg9Wc=; b=Vvrje0NEkJSFJgUvnErbbOmgq23YhNTBikra5fgPZ/SbjDzBhvPSvIfUXNPNxm8mJZ T5kds/P6lb7cyfqqMbyQQGn9NVxI5Dkq64bcSUeyVSnF21uLLdyD8qSn1YYyiB6DfnBp ooBKe4+aiO3iOPfSeuEFCkRK0gTpjcFfapzf6LYnIoVVD7lD429M8WojHx2k4hSF/t+l +EId2UFwNVfab6LC185OmNpb/nMi26Iws0aEjvUtydt6ji69pI6M67NGIK/XuOqQ/u2e zxpkRLZQVJhbmpIiBzF8XbxRveaOqRfjoAHUcTer+oE/YlAsa/eSW/WOsI3OyG5EZ2ZF m0ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034809; x=1722639609; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hkGGT6Cl4eQMAs1FA6JIr0lCMLReUe6VTrJIDGqg9Wc=; b=kAP/AjgUO1RuV50NcU96yskpnpiZVRq60CAkcjWQtSgU3vGMD1PMTko/BIOkKCozib /a32F9/aC2ijm5GL1UtWgMzBqOvJQQh3mGJ94OTwbNbI9GM33TBcuBzgARmfr2PeJm9z pRyqDY32iDeWrkl4tdwM14FWVKNCX89UmaCsX7NQAYwZqYKWdU3NvoH/RBSUTICWc0UZ MCUOabSDRi0FXDN/FryPkd1MouaP9qAaWpvn2PGtL2a1TGy9jRdN8BbYJbsvw+GjdCP8 9a52Lz0VLuDBmP7CFtM6LYxm9V3ORYl2EY/7s5Z37OwqevnYoFpU8QrimlOXTiSM/uI1 xyuQ== X-Gm-Message-State: AOJu0YwGpjaThWGo0DqOLjNPEUgsxGEe2XNK8hiu0M4u2t4HCXXOJnrE aUxQjhArCPhDDmGHBQcWExifcfahDxkoV5dmTsHHbTGHNwSq1XoBc10NBQ== X-Google-Smtp-Source: AGHT+IGyXGDtKt4yHmTqIKg4hsxcdSi8lAofQjTN4TeTuM86p/o35BdJwD7ia7SdlHrczu34R1N/pg== X-Received: by 2002:a05:6a20:9d94:b0:1be:c3fc:1ccf with SMTP id adf61e73a8af0-1c47737480amr5423659637.2.1722034808951; Fri, 26 Jul 2024 16:00:08 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm3308540b3a.178.2024.07.26.16.00.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 16:00:08 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 7/8] lpfc: Update lpfc version to 14.4.0.4 Date: Fri, 26 Jul 2024 16:15:11 -0700 Message-Id: <20240726231512.92867-8-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240726231512.92867-1-justintee8345@gmail.com> References: <20240726231512.92867-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Update lpfc version to 14.4.0.4 Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 7ac9ef281881..2fe0386a1fee 100644 --- a/drivers/scsi/lpfc/lpfc_version.h +++ b/drivers/scsi/lpfc/lpfc_version.h @@ -20,7 +20,7 @@ * included with this package. * *******************************************************************/ -#define LPFC_DRIVER_VERSION "14.4.0.3" +#define LPFC_DRIVER_VERSION "14.4.0.4" #define LPFC_DRIVER_NAME "lpfc" /* Used for SLI 2/3 */ From patchwork Fri Jul 26 23:15:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13743257 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 720F314A4DB for ; Fri, 26 Jul 2024 23:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034812; cv=none; b=cJVyCkPnoz7OscWDr1FCETSNmM/PZ40tjfM86/LBjWtTuTIHXJKbcDd1Ee3HSpIA17tUZ79VSL21YWL6NoxZiogOD2R+CUWKnWho4K676aARqR/eAsnapsBfg1R16xr9roml/sUuqazMMAdo1NAP6rPLKmJhzorl6NM5SzUL3Rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722034812; c=relaxed/simple; bh=0UaRDiv2hfbk2XcjYfDPp24lTkJ/tVj0wDLqKlLVGLA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=e32hXEm2T9SAt/mT8fXokL1v1JHWSA3DJA/DZEmcjhYWext+YwSeiZlxS4hbYiL3Cj/XO6Gm3EdUKgRDBJ0cIYhBOv8o3t1/EeLeXEMUADE3dGUguc3VkUsmcE6lWN5iaGP/cEHON7U7CM1KfUDiEbT6dVospEiMmjAhNvvOvQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=axc3wQIp; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="axc3wQIp" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2cdae2bc04dso241223a91.0 for ; Fri, 26 Jul 2024 16:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722034810; x=1722639610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rdc70V33+T1cbKKu300daghyfQbyMg5bNzX/qsatImA=; b=axc3wQIp4bW9LNAGsU4wuVrunyQtMb2UtLyzPMvgBZ5Uej/w+Jzv96nSfhvtHsfbjr +ZPww253Jhp8d1kS+prdQDZ0akdBUP1KZ5l/hZ9oyuqA3KckkaKbiCN4lsd7MgzGgkG7 ZOW3dQj58poUJBEO9tvGcrheJH70oU1vbL3KHWKl7n+c+RmkWp27eohfFNIriwd0zkbg E+Ih4rJXI5yFWsATPEvIZ4w8MpWKYqfJGenmmYvEJP8tZXPlhDdeZicdoloEhm0eS8Ic PxZR4vt25kbRGCpcry5Z43cLdAtFzwhrB2zGiBYrIHhB8QZU16EqhbgxtW8B0DaBsJsd RcNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722034810; x=1722639610; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rdc70V33+T1cbKKu300daghyfQbyMg5bNzX/qsatImA=; b=f3/rDCK24BA5netshMtcEXSPBBhSL/LH6VZHianBo2zOShupYITBokgqID/z04PLIg OEPwra6WRtNvnub/FUu8KJTd5VojjsFUsW0I4ftrbPTyRfqi7b9dzAlTvOLm2mERXNN8 B8QR9rN86MULufOEVEGaCLAlPU5IOoIfrEEcDSFiYaT4JAD2a6MPNP8uqaOxAWca6K8+ PjMAoVUOQo7BG6ml5jVIn9IUvRdzE/G0Zuo/U00/KjT7iJYpcyW9i/4QZrQjhJs1R5Hx SIq7kZVtSCZsZhNr09desSfZw1O/wVFO0NEn1Lc05GTbFRDLqd7xi1Awj8865ASC2423 Hdlg== X-Gm-Message-State: AOJu0YzPkju0Iutla8/Ne4niqy6aw868jt2GHi4NXJaOwVrt4RJSWePc YpxtuxLi5dilgfLoGA9Uj/YcpKG7Guvyim+57iVTv7NWG4RRFm/5VaSeIw== X-Google-Smtp-Source: AGHT+IFpEVJIXCsv4KEHBnrnquaNQ7AG1fzK9vbUKxnVBiVaClTa6A6Md8M3oX2EK/UDeVgzMQelvg== X-Received: by 2002:a05:6a00:6f4f:b0:70a:f156:fda with SMTP id d2e1a72fcca58-70eac95e22cmr5107316b3a.1.1722034810443; Fri, 26 Jul 2024 16:00:10 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70ead8834b1sm3308540b3a.178.2024.07.26.16.00.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 16:00:10 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 8/8] lpfc: Copyright updates for 14.4.0.4 patches Date: Fri, 26 Jul 2024 16:15:12 -0700 Message-Id: <20240726231512.92867-9-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20240726231512.92867-1-justintee8345@gmail.com> References: <20240726231512.92867-1-justintee8345@gmail.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Update copyrights to 2024 for files modified in the 14.4.0.4 patch set. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_vmid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_vmid.c b/drivers/scsi/lpfc/lpfc_vmid.c index cf8ba840d0ea..cc3e4736f2fe 100644 --- a/drivers/scsi/lpfc/lpfc_vmid.c +++ b/drivers/scsi/lpfc/lpfc_vmid.c @@ -1,7 +1,7 @@ /******************************************************************* * This file is part of the Emulex Linux Device Driver for * * Fibre Channel Host Bus Adapters. * - * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term * + * Copyright (C) 2017-2024 Broadcom. All Rights Reserved. The term * * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. * * Copyright (C) 2004-2016 Emulex. All rights reserved. * * EMULEX and SLI are trademarks of Emulex. *