From patchwork Tue Jul 30 21:28:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Santiago_Ruano_Rinc=C3=B3n?= X-Patchwork-Id: 13747898 Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931331AA3FF; Tue, 30 Jul 2024 21:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.252.153.129 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722374943; cv=none; b=VzVVvQgybJS7fGd+BwMREf1Wxh4XZY6pKj3E5svWJTFjtG16GyT1/Uy41OgGzbr4XM2dp8SYH7bQos8MFbBQbcVBn/kY/OiCqcOvD9kV+8Zf4hVc7AobCvawj/fySAT7EnSWLg7njwKusnfEgjIwohoVp5CCdLVhNXd+0lz8+L4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722374943; c=relaxed/simple; bh=d9DOTRd8kAc5fw35sUzIu6WzsI7yQjrSEqrfuiFNqYU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=mG75mp3v+WWkdurTjG6U+YzkHTq8HaLuQIbSfC2af86MjVFV4I+GtJp3/5wJ9CH8N0l5GwyzQe7HQNCMM2XXGn1n5sUGQdmKEUFelMRGBCsMGh/aJZI/akgk5XtWOXLos0wfHiyJIkscLfUgTGQ+uMsfnpjlPYbqle0/1FSlI/I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net; spf=pass smtp.mailfrom=riseup.net; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b=r5v4qWLv; arc=none smtp.client-ip=198.252.153.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riseup.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b="r5v4qWLv" Received: from fews01-sea.riseup.net (fews01-sea-pn.riseup.net [10.0.1.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4WYSyz5ckCzDqP4; Tue, 30 Jul 2024 21:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1722374940; bh=d9DOTRd8kAc5fw35sUzIu6WzsI7yQjrSEqrfuiFNqYU=; h=From:To:Cc:Subject:Date:From; b=r5v4qWLvY4/kGsvFw1l0EuORSd7UcVGRmb6wgORcG7y1hed/N22dH34KKS9gpgrG+ f0iKMvwycIR1QJ+hM2D+QLGIC9Y1iVI74nbC5EgvO/njW6faT7Jmwkf+JpZp4UuQXI iNaBENHjU0RsW47rB0wf1J+pacwFPB6DJMPvy+jc= X-Riseup-User-ID: 7192E67EA91FC2267A7FC0DECF5ABE72E1EF159850640A75E2FA476C35DB71A3 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews01-sea.riseup.net (Postfix) with ESMTPSA id 4WYSyy0yn3zJtLb; Tue, 30 Jul 2024 21:28:57 +0000 (UTC) From: =?utf-8?q?Santiago_Ruano_Rinc=C3=B3n?= To: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: helen.koike@collabora.com, ~lkcamp/patches@lists.sr.ht Subject: [PATCH v3 1/2] staging: media: sdis: move open brace to a new line Date: Wed, 31 Jul 2024 06:28:53 +0900 Message-Id: <20240730212854.474708-1-santiagorr@riseup.net> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fix checkpatch error "ERROR: open brace '{' following function definitions go on the next line" in sdis_1.0/ia_css_sdis.host.c:239. Signed-off-by: Santiago Ruano Rincón --- This is one of my first patches. Could you please tell me if is there anything wrong with it? Thank you. V3: Insert the change history (including for V2) V2: Remove spurious [PATCH] header from the Subject, inserted by mistake --- .../atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c index bf0a768f8..cabacfc84 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c @@ -239,7 +239,8 @@ void ia_css_sdis_clear_coefficients( int ia_css_get_dvs_statistics( struct ia_css_dvs_statistics *host_stats, - const struct ia_css_isp_dvs_statistics *isp_stats) { + const struct ia_css_isp_dvs_statistics *isp_stats) +{ struct ia_css_isp_dvs_statistics_map *map; int ret = 0; From patchwork Tue Jul 30 21:28:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Santiago_Ruano_Rinc=C3=B3n?= X-Patchwork-Id: 13747899 Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54D5B18E03A; Tue, 30 Jul 2024 21:29:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.252.153.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722374957; cv=none; b=N1+kLqWNTf/vY0kbKCNNTdeDj9mNThXkYdoYm6NPUur3yQ2H5SvndT4WB4z9ETM0Dy+5NiIVT3ZobLX0LJRbnLshN08X3ft0MWZLNViPN5ZLM4rUCcZakDh/ena/yHYVVhLJxBo+3lF+gCsgXGJ05ZryJADxRVGGs0DamB0OHVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722374957; c=relaxed/simple; bh=C6VSGx8RupmJLdmFxZP9iZzz+DlZoP0RzAD1ZTJ0how=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=Yf/dI0iwXn0w/J5vhidGNEv2SKqVc8r/tn29HUhkzkuTNKtKjpRCoeNqoD9s8D45tFizyTg7ssFXVOFyLaWxeosxNM93zAHpcCDL97r5VGln6DBkr8EEZ84ZYHG0pH8WT88YDEddrvo81A9CMVpxHK512y1IQhXg/UGPQeNrg0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net; spf=pass smtp.mailfrom=riseup.net; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b=V5L7ipvg; arc=none smtp.client-ip=198.252.153.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riseup.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=riseup.net header.i=@riseup.net header.b="V5L7ipvg" Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx0.riseup.net (Postfix) with ESMTPS id 4WYSzG3Pp0z9wZt; Tue, 30 Jul 2024 21:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1722374954; bh=C6VSGx8RupmJLdmFxZP9iZzz+DlZoP0RzAD1ZTJ0how=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V5L7ipvgVlzC91Pzne7nAADR7bQtYLQzbxxoAp1O7ESB5SeV3FyVCUBU3cyad1vtg ni/E3TkldiiLdrQnCxdXeS3hwwiFBMfNEeRl48LWXqxyX12SfmWdcHwC1/LtsxCei4 t8/Gi2l7+LqzksIymXFx78BPkCWNxhtmFoZ9eDh0= X-Riseup-User-ID: BDB4D0B77CB8B1A37EA613107467F4BD0693762E86973698D43FFCD98055D728 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4WYSz20qdPzFvlN; Tue, 30 Jul 2024 21:29:01 +0000 (UTC) From: =?utf-8?q?Santiago_Ruano_Rinc=C3=B3n?= To: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: helen.koike@collabora.com, ~lkcamp/patches@lists.sr.ht Subject: [PATCH v3 2/2] staging: media: sdis: move open braces to the previous line Date: Wed, 31 Jul 2024 06:28:54 +0900 Message-Id: <20240730212854.474708-2-santiagorr@riseup.net> In-Reply-To: <20240730212854.474708-1-santiagorr@riseup.net> References: <20240730212854.474708-1-santiagorr@riseup.net> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fix checkpatch error "ERROR: that open brace { should be on the previous line" in ia_css_sdis.host.c:253 and :258. Signed-off-by: Santiago Ruano Rincón Reviewed-by: Dan Carpenter --- This is one of my first patches. Could you please if is there anything wrong with it? Thank you V3: Insert the change history (including for V2) V2: Remove spurious [PATCH] header from the Subject, inserted by mistake --- .../pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c index cabacfc84..467572d84 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c @@ -250,13 +250,11 @@ ia_css_get_dvs_statistics( assert(isp_stats); map = ia_css_isp_dvs_statistics_map_allocate(isp_stats, NULL); - if (map) - { + if (map) { hmm_load(isp_stats->data_ptr, map->data_ptr, isp_stats->size); ia_css_translate_dvs_statistics(host_stats, map); ia_css_isp_dvs_statistics_map_free(map); - } else - { + } else { IA_CSS_ERROR("out of memory"); ret = -ENOMEM; }