From patchwork Mon Mar 4 20:19:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10838539 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2ECF417E0 for ; Mon, 4 Mar 2019 20:19:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1F11F2AACC for ; Mon, 4 Mar 2019 20:19:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 107482B2F6; Mon, 4 Mar 2019 20:19:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A37F42AACC for ; Mon, 4 Mar 2019 20:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726054AbfCDUTq (ORCPT ); Mon, 4 Mar 2019 15:19:46 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:56693 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfCDUTq (ORCPT ); Mon, 4 Mar 2019 15:19:46 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1MbAUg-1hXkuF3S0m-00bZFT; Mon, 04 Mar 2019 21:19:35 +0100 From: Arnd Bergmann To: "Enrico Weigelt, metux IT consult" , Darren Hart , Andy Shevchenko Cc: Linus Walleij , Andy Shevchenko , linux-gpio@vger.kernel.org, Arnd Bergmann , Linus Walleij , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] x86: apuv2: remove unused variable Date: Mon, 4 Mar 2019 21:19:19 +0100 Message-Id: <20190304201930.1622839-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:pHrE99LD4Az19jjq1RhzvjHdL9Am2S8ct42IpJYIyShcAj8j0iZ r2pQv5FzE8vV5r4fegmHgWct+3GHGV4OCkR1xTOJjdLsYJAwIdBJ9A9gLIpEH53x5iEJPE6 fZ49UGI8JoPJHIsgdFheEIiKCtCpOO1h3M9fgWJMHxSWpHlc0s+JtMQs62RO5miDyOHodw8 Mf9UG8EKEPKr0Q+6NGTlA== X-UI-Out-Filterresults: notjunk:1;V03:K0:/pFOLIY+nbA=:4HiDGKoz2TZWstJ0S3n+jX FYxCXB+yTQZJJnPg5B/Y1Gfqd6M5QAnysAOOkLV5aOros6IEI1dzrvU50hURojtbG+E0XT/EI OduWxBBMLC0WHs7mS/4QQJq/6l694jQknerWAS0b1T3ynXBs9W7Ru1aKg0V2yKi0b46NeAowK Rq74CrfU6ANsN2/3F1WvnKwH5SEQo5oMEZ9+8RQY5pEKCjNUPC3+BQN6l/mKY/4nUZF1EYFmu 1Y9AlGfbfvj6qoUZu7xMasY0B0NbFSHtgOqrAQPtqKRDbhELBsoOudP+NUeCTfgRbYe8ugUKq g7LM/AfPPF1/AJZHCzIYjR/XN/8CiJXB/oSoryVGB7j2OVkmqD1ihLOQPjgDnlHqP9JhnKI37 Psp5LyDgIi0N6p5o5ewjomdUAbAJX5suojcoZLCDUc2Am9Wha/hYgNZT8+BC3TX2fgmuZR2Ii tjsbCADH7OajN5OW3HwCvyWOxGWcZx3AxkYMGNfKBLGTzN10Z4eJF86vBmlc76t7KG/KjR6+a IvfeZX9jsDZCni5ldktrNVVFhOwtwhf50mmNU4oHpB7Igs0++j92hw+n4WurBXhO2uy1XTFZX 5/9QnqfMRP3JOb/9IU8eagMu9pgYyyYbIAMCbdXqYIek+21ZkzPX3U2YRVHW1fM6apBbJlYbI fdxXR6vPdXX3Lrx0g0hcpSjxbFpCtaXiD5NDPtlen0Y+akZA7g8v9n3zzb1R93Fhn6VWVEugw PE8bArLkAdwzmFiCE3TgTFiI/efVxKQSaxymQNMnrpsPlBL41IsbKOp5TEszHDPOBZjUvlWxt gJGSIQC6F6VhNL+iTwAknsMZHsdj+U/8G723JqR7ZjDps2qzjnrwhvrvNhccVmtO0x0Lya/y6 10hiFTdWQCkd2V85iP3x1twJb3WQ8OlajvSw+ifs4L5Qldnn5hARlTbaZtIRNu Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver was newly introduced but the version that got merged produces a harmless compiler warning: drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init': drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable] Remove the evidently useless variable. Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver") Signed-off-by: Arnd Bergmann Reviewed-By: Enrico Weigelt, metux IT consult --- drivers/platform/x86/pcengines-apuv2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c index dcb084f6b892..c1ca931e1fab 100644 --- a/drivers/platform/x86/pcengines-apuv2.c +++ b/drivers/platform/x86/pcengines-apuv2.c @@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev( static int __init apu_board_init(void) { - int rc; const struct dmi_system_id *id; id = dmi_first_match(apu_gpio_dmi_table); From patchwork Mon Mar 4 20:19:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10838543 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 52DAF1869 for ; Mon, 4 Mar 2019 20:19:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 403B02AACC for ; Mon, 4 Mar 2019 20:19:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 348852B2F6; Mon, 4 Mar 2019 20:19:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD7542AACC for ; Mon, 4 Mar 2019 20:19:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726227AbfCDUTz (ORCPT ); Mon, 4 Mar 2019 15:19:55 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:59245 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfCDUTz (ORCPT ); Mon, 4 Mar 2019 15:19:55 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1MryOx-1hLRlX3AF3-00nweE; Mon, 04 Mar 2019 21:19:46 +0100 From: Arnd Bergmann To: Darren Hart , Andy Shevchenko Cc: Linus Walleij , Enrico Weigelt , Andy Shevchenko , linux-gpio@vger.kernel.org, Arnd Bergmann , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] x86: apuv2: fix input dependencies Date: Mon, 4 Mar 2019 21:19:20 +0100 Message-Id: <20190304201930.1622839-2-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20190304201930.1622839-1-arnd@arndb.de> References: <20190304201930.1622839-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:ylsiu+1WUSKbU/xQv18irdCbEBXfU0nongfEalQpp7PDSOC7332 atWBq/XLdpiw1EP4DY6RKEptDAndTP46Xwg9RqMRI9rO2cJqVmam4msuRpBVhZXxv6odnvV g5K+xFLc+po/Jn9ZNcP4khEv8+/RZj94nQkKoje0zmnnVMlWLgnx3jORpqQ9/D1MMbP5vxl wLJkmznkS5bzcL66mN1pA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Vxi3d1CkIjM=:Kv/xz16e0cT2tVvFcjLiTm ep0vrQiqkLICd611ziJE7MHcpUhHAYbUtgQKrk87S15p6o5gkb9lm33+MyCOWCB8JsKnwabOm Cc2IjFIpiQlRzHh03tHH9T8rc7cqpG1sEvTFvWY8TnTX5osZ0K55aKv2P+6j+uY4dmi+zyEzN XN7LuThxVYvUvOY2GBOZwMcPHZqgYEW8ti5Lg4EiIqAvdxRvjh6ivBAeokJlfTvivm1xrCCMm Ph94g0uDcWoLq/AN57WEt4cIzk+fpZCQ9XWcur4Kwc8uM6Z9i8D1MjfcpRu2X0FQ0e8I93Frq asCv1rieGK5BaRwXJlHLcup6PvML9jH+oeZvSzzxblCdR5RFLp2pLoIsr+O9yEPJ86fOA7ykt BuJk6kGtDMSDohW1+AXyWd3UEqbm4mmHDuRrXdDHmb1xICCO/sTchrtGR2h3SQ3wchTU9ILgx z5902sy+tPPqceXWe0SDzqNPGSrMO2IunO8Y53XEMJ8bz5snhQzT03L5tfcBqdEil1bS7eniS 2QoOtfNOX8gBet/xVAz9j3fbAUkRhN10ubXh5Qz7Tk+QNdqgiS7ybyvjuMtOooJ6NytA2qQ8D wkLnXIpOQzC0Obx3ELte3B6lJQ6q8qumnHTfBVWHR1WgNDp+upazaQ665kgriTDQpOTpm8tuQ MCb/fsKWBswV5V2N1q9Aiu0NUkrPsSg2Cxw479I1UCn+z2shwn2cmftDPE0Bbb6YTrY6+0gqU SvO9vaQAggb/UaHl0Hj+nW0SngNYSkS1xjjTdQ== Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We cannot select KEYBOARD_GPIO_POLLED if CONFIG_INPUT or CONFIG_INPUT_KEYBOARD are disabled: WARNING: unmet direct dependencies detected for KEYBOARD_GPIO_POLLED Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n] && GPIOLIB [=y] Selected by [y]: - PCENGINES_APU2 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] This could be fixed using either a dependency or a 'select' statement. I'm chosen 'depends on' here since it is simpler has a lower risk of introducing circular dependencies. Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver") Signed-off-by: Arnd Bergmann --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 851ea921a58d..4d65d37b0c86 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1305,6 +1305,7 @@ config HUAWEI_WMI config PCENGINES_APU2 tristate "PC Engines APUv2/3 front button and LEDs driver" + depends on INPUT && INPUT_KEYBOARD select GPIO_AMD_FCH select KEYBOARD_GPIO_POLLED select LEDS_GPIO From patchwork Mon Mar 4 20:19:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10838545 X-Patchwork-Delegate: andy.shevchenko@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 90E4417E0 for ; Mon, 4 Mar 2019 20:20:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7C8F82B301 for ; Mon, 4 Mar 2019 20:20:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB6612B402; Mon, 4 Mar 2019 20:20:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7535A2B33F for ; Mon, 4 Mar 2019 20:20:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726095AbfCDUUR (ORCPT ); Mon, 4 Mar 2019 15:20:17 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:38953 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfCDUUQ (ORCPT ); Mon, 4 Mar 2019 15:20:16 -0500 Received: from wuerfel.lan ([109.192.41.194]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1MA7Om-1gqTvu3VRy-00Bc9J; Mon, 04 Mar 2019 21:20:01 +0100 From: Arnd Bergmann To: Darren Hart , Andy Shevchenko Cc: Linus Walleij , Enrico Weigelt , Andy Shevchenko , linux-gpio@vger.kernel.org, Arnd Bergmann , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] x86: apuv2: select LEDS_CLASS Date: Mon, 4 Mar 2019 21:19:21 +0100 Message-Id: <20190304201930.1622839-3-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20190304201930.1622839-1-arnd@arndb.de> References: <20190304201930.1622839-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:XxZake0ndRPH2Ze0SqTH+/cZJhpugBiJnivixjyNibLQYQRltrn uzh413UijeTtvWABuqQBX3hSKVtrl3R1r1CT9T7bq9inQf+GFBXqE2Fi3wGK8rMl7fNXjWu adIZqQRZ11L0Llnxp4jFe7Cg25j9TNakZRPrXY9vWvkU/DqcPx8yTX2Okt5jW5/Cy2UzNHe A6FhDrLcgv+TBynHQyduw== X-UI-Out-Filterresults: notjunk:1;V03:K0:C7yVC/s2SHQ=:Uhek1oloFFbUBzhFbH3Pr0 A0lTJoIgpx5/JL0tU8BZu8YbG7B28e+xuvTXEy8vrFw03X6dfACKpIaQfFfB5XnMuJGBRONPn qwoQDCntYZRn9K8jtdloyTEHuBmErt2pBAcGebq9pNyB18+m1fntfI4NtPgXGyEO8dJYDho6J I8nap/loWLG1FSjA99lohztkFCAh+RHbojNtJjmXFs1xYtlbit9HXI3v30CaLy6i0Qw/fxL0K UUdRz4M04Tl/WgApnViJow/hX4D4EY3ICSihuIl3W+86njaZ578b6yBdDK/ZZhyC9O6rjo+Lt 3C9fnqZjUWx8rkj11XiFjyRQ7kVE3OAgleQVBIHGWFPM8j5S7jtb2q+cHG9g/YC4Ixv9ipZa8 QlXBDHowPd1N+D8qzYDvGa/mSTYn0UHEgKijKVVi6nGgsIbovqqck1vrtPh05mvJhXc8ulxvX xbHIt5rAOzi1+j9NGIGvg/z8e38rhSi/Kx+BLholSXO0Ysctg0hE+t5l/ysA+RoW9UxFR8Dde EBzf7jdwJssDG2XBrimzzGaf+BLkmyfZugbVgGdDcPI9WYowYLlLXXXzYc4ti2zWHHaB+yl26 P4bZ/hh2+1EA69BzR4AJQEsD+0tH4mpwu6UiCT7RvFErmbRGJ07ChE9fPVibxU0WVntnTdOwo 7ZkVff0RoCHNSbs4bCW+SyplpA9l9q9uhmPPgRQlkX+02kywOIuNoEdQjEwNIetq6HX4McVIv z8qZJe35iWbTCKeXAslOgyZZbickszWYLLNSSA== Sender: platform-driver-x86-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP LEDS_GPIO can only be selected when LEDS_CLASS is already enabled: WARNING: unmet direct dependencies detected for LEDS_GPIO Depends on [m]: NEW_LEDS [=y] && LEDS_CLASS [=m] && (GPIOLIB [=y] || COMPILE_TEST [=y]) Selected by [y]: - PCENGINES_APU2 [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && INPUT_KEYBOARD [=y] Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver") Signed-off-by: Arnd Bergmann Reviewed-by: Enrico Weigelt, metux It consult --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 4d65d37b0c86..d64529352a9c 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -1308,6 +1308,7 @@ config PCENGINES_APU2 depends on INPUT && INPUT_KEYBOARD select GPIO_AMD_FCH select KEYBOARD_GPIO_POLLED + select LEDS_CLASS select LEDS_GPIO help This driver provides support for the front button and LEDs on