From patchwork Sat Aug 3 06:30:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cuigaosheng X-Patchwork-Id: 13752292 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4AA982D98 for ; Sat, 3 Aug 2024 06:30:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722666637; cv=none; b=JdpW2RXmU1KyiyS7G0ahCrsR9ztV5YJEaTj9PvVRfXUJ/0/WTZ3UdyEl30vjCwfxHzCQiQWiFjTJ6mmW9ZfyWmgQWYX/qqjAaVZimdKlIrQAljQvs+Og9oBsE7mFjQR9XPkZ5RzUvEnh1Ogk4Ys/8+sl0a3AaWJ263DJoxZlnws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722666637; c=relaxed/simple; bh=I49B2DPWtx+voZl+4eUfFxTiVTNG7b4TJmp2W/RDMM4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GyP/5rvx/F1UTbrXojSMeC/HRTBw9GLptHUcKcro7Q8yYySGa9EZCI/pfg2XKhiOPDfd2d8k9656Yp9Nm+q50N7nRfV6LPpwEG+61kPueFOxFMe74S/rEW0WjF8UVB9wqjVJQZTM5TsZVI/gkkTvMOqavyOKiPuci8IQ+DX3VyY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WbXpJ3jTqzfZVK; Sat, 3 Aug 2024 14:28:40 +0800 (CST) Received: from kwepemd200011.china.huawei.com (unknown [7.221.188.251]) by mail.maildlp.com (Postfix) with ESMTPS id 5BF421400DC; Sat, 3 Aug 2024 14:30:32 +0800 (CST) Received: from cgs.huawei.com (10.244.148.83) by kwepemd200011.china.huawei.com (7.221.188.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Sat, 3 Aug 2024 14:30:31 +0800 From: Gaosheng Cui To: , , , , , , , , , , , , , , , , , , CC: , , Subject: [PATCH -next 1/3] drm/exynos: Add missing clk_disable_unprepare in exynos_fimd_resume Date: Sat, 3 Aug 2024 14:30:28 +0800 Message-ID: <20240803063030.316390-2-cuigaosheng1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240803063030.316390-1-cuigaosheng1@huawei.com> References: <20240803063030.316390-1-cuigaosheng1@huawei.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd200011.china.huawei.com (7.221.188.251) Add the missing clk_disable_unprepare() before return in exynos_fimd_resume(). Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index f57df8c48139..7be90f120a7e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -1312,6 +1312,7 @@ static int exynos_fimd_resume(struct device *dev) DRM_DEV_ERROR(dev, "Failed to prepare_enable the lcd clk [%d]\n", ret); + clk_disable_unprepare(ctx->bus_clk); return ret; } From patchwork Sat Aug 3 06:30:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cuigaosheng X-Patchwork-Id: 13752293 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F1C8A943 for ; Sat, 3 Aug 2024 06:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722666637; cv=none; b=ERX6kSQugQsxn8iPPcGVatPekt9095JxBa8N5fx3aeRrZQRnNO8tTTjbNiqTmyDWteBdYdQNeMJ1LoV4MQeG0FsUzTARg9RBsycCeMciQLvFoEZCsfS6fyrsKq4A5UFgh/AFd/9cnn9GU1z6O1uepXjOC+uKCbHt+ywCYP7ab8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722666637; c=relaxed/simple; bh=TqTyXuTVCudV4nZ4m4nsTxzNqGpFxws6iOQdHZjCRBg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SMW9ku1zMfO40x0zj2+DK+QmUpAC5TrMnOqea3jUpnQK4llZs+P/ByDrpVWJ7x90FTaKBlP0enHeaS0Z8N63URJkZw9huPfqgAAOHr2T0/MqETlO3dpD+mxfoeEEzQeQPD6yDfSrIgJY0IdccYfwm8udheVqvS74hER/yk2Ilrc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WbXpK22wkzfZMT; Sat, 3 Aug 2024 14:28:41 +0800 (CST) Received: from kwepemd200011.china.huawei.com (unknown [7.221.188.251]) by mail.maildlp.com (Postfix) with ESMTPS id 23C361400D1; Sat, 3 Aug 2024 14:30:33 +0800 (CST) Received: from cgs.huawei.com (10.244.148.83) by kwepemd200011.china.huawei.com (7.221.188.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Sat, 3 Aug 2024 14:30:32 +0800 From: Gaosheng Cui To: , , , , , , , , , , , , , , , , , , CC: , , Subject: [PATCH -next 2/3] drm/gem: Add missing clk_disable_unprepare in ade_power_up Date: Sat, 3 Aug 2024 14:30:29 +0800 Message-ID: <20240803063030.316390-3-cuigaosheng1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240803063030.316390-1-cuigaosheng1@huawei.com> References: <20240803063030.316390-1-cuigaosheng1@huawei.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd200011.china.huawei.com (7.221.188.251) Add the missing clk_disable_unprepare() before return in ade_power_up(). Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c index 871f79a6b17e..942560a717ff 100644 --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c @@ -229,12 +229,14 @@ static int ade_power_up(struct ade_hw_ctx *ctx) ret = reset_control_deassert(ctx->reset); if (ret) { DRM_ERROR("failed to deassert reset\n"); + clk_disable_unprepare(ctx->media_noc_clk); return ret; } ret = clk_prepare_enable(ctx->ade_core_clk); if (ret) { DRM_ERROR("failed to enable ade_core_clk (%d)\n", ret); + clk_disable_unprepare(ctx->media_noc_clk); return ret; } From patchwork Sat Aug 3 06:30:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cuigaosheng X-Patchwork-Id: 13752291 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB33F76036 for ; Sat, 3 Aug 2024 06:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722666637; cv=none; b=QhnJF7c7WDZf9jKCZaVqOjVdsmsm8NHqdqSlhfFamXrwh0+d+mjP775KYmPakkHK6eqCHmZ12DZYkc+cvMaWjpJnCJ7tX92N7EIO4wKe2t8PJjkCcOG8G02U9d39Hplj70qXdLhabNkEkYTX9ILMOwWB/99fywPdbTda/9CTKe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722666637; c=relaxed/simple; bh=aWscC1sPf4N36Y9mqhch8iZYcRzvxEfBmb61a8PIt3A=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QQZ3Ihm8QSl2tRtcMe5yiO6ORGh+gg4gPDD8VlS24CVun1OVdSDCT51W2YcbxLsgrCjYxPqqmFChI3/nrMb308IilWoM7XQ1485XOiTPBRTD2qHNlllV4yv1hLiRc2Hrxu9HhtD8VpphdoWpl+eoQmIUqGIk4ifQRPxzm0mCL3s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WbXrR2JvgzcdRj; Sat, 3 Aug 2024 14:30:31 +0800 (CST) Received: from kwepemd200011.china.huawei.com (unknown [7.221.188.251]) by mail.maildlp.com (Postfix) with ESMTPS id EADEB1800A4; Sat, 3 Aug 2024 14:30:33 +0800 (CST) Received: from cgs.huawei.com (10.244.148.83) by kwepemd200011.china.huawei.com (7.221.188.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Sat, 3 Aug 2024 14:30:32 +0800 From: Gaosheng Cui To: , , , , , , , , , , , , , , , , , , CC: , , Subject: [PATCH -next 3/3] drm/kmb: Add missing clk_disable_unprepare in kmb_dsi_clk_enable Date: Sat, 3 Aug 2024 14:30:30 +0800 Message-ID: <20240803063030.316390-4-cuigaosheng1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240803063030.316390-1-cuigaosheng1@huawei.com> References: <20240803063030.316390-1-cuigaosheng1@huawei.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemd200011.china.huawei.com (7.221.188.251) Add the missing clk_disable_unprepare() before return in kmb_dsi_clk_enable(). Signed-off-by: Gaosheng Cui --- drivers/gpu/drm/kmb/kmb_dsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index cf7cf0b07541..02141ac593c6 100644 --- a/drivers/gpu/drm/kmb/kmb_dsi.c +++ b/drivers/gpu/drm/kmb/kmb_dsi.c @@ -1494,12 +1494,15 @@ static int kmb_dsi_clk_enable(struct kmb_dsi *kmb_dsi) ret = clk_prepare_enable(kmb_dsi->clk_mipi_ecfg); if (ret) { dev_err(dev, "Failed to enable MIPI_ECFG clock: %d\n", ret); + clk_disable_unprepare(kmb_dsi->clk_mipi); return ret; } ret = clk_prepare_enable(kmb_dsi->clk_mipi_cfg); if (ret) { dev_err(dev, "Failed to enable MIPI_CFG clock: %d\n", ret); + clk_disable_unprepare(kmb_dsi->clk_mipi); + clk_disable_unprepare(kmb_dsi->clk_mipi_ecfg); return ret; }