From patchwork Wed Aug 14 10:18:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13763235 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D55A21AAE38 for ; Wed, 14 Aug 2024 10:18:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630735; cv=none; b=hZWDMIyez5xXGhExNH9WU/V4++Oz1jrXky5t6YW9qlaArfkONPXwG5aQhcLEHHKSJxjrrSDYUIa2u59nTvUegcPgAt6HQqHR92AOc9Nd4UH5s8Zb7nGi1MN4eF3xO8xmBFu0PBb1cjQ3M4LcJCH3ahY/8vJmSNAi6zVAv2RV49Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630735; c=relaxed/simple; bh=VoIUTKlyGldU32MZSlDYD6KmvPIa8tx53ppKsKBdjS0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SOjqMRmIQxq54b68dkFQyjh+SEj7bMWVZ8Bn+v3S+J8F9+FsHxESo2mn4lyLqtJhu4hNu+Wovm9VWWJCA5zPg2ESrldgsxqmHE2FXCTXbsIHo9E6DLFNuPlhBj9SyuMsb4/ZymZ4WppYfrPZHmlswlLSrDJDX7xwfrgptxMZZD8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RYPRlP3b; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RYPRlP3b" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-368526b1333so421726f8f.1 for ; Wed, 14 Aug 2024 03:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723630732; x=1724235532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VniZOaq6gdFHYm/HVi9M3gxl2wi+7Y1v4x6YyCs0zik=; b=RYPRlP3bIeCcooS0wEtOREffAgAk5yDUxoREPDTFFnL9XcB9yBsDAnX9Nb9k9oU1/6 CkVFNRB0F+kfs7/kSRp9BzjiqeMj+G4EkqtagAoBFr07WPOHdRq9HNUiN9q1JvmY7ogM cWV9l4ibd2n2SE/vF1KH28ia4MOzlL6O7Etyd3lK7pLJpQt6yZioDB+Lfur/6+mVtc2t mft3iNx48/fIX8FkMY/eO6cVP7Vbtc1UD/ELQdU0iiLSOKbWA59PFKacxfZTUq1i6xwt DPP3NWh1xzon3b0cS0FlVirT1TJ5X2m8fiLV+gtwNfdZl5PONhKacDDb1xtStCuV9+Wg E4Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723630732; x=1724235532; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VniZOaq6gdFHYm/HVi9M3gxl2wi+7Y1v4x6YyCs0zik=; b=HraRp3ZDRa1bseApldo2yuUx2/olb1KEmUmquF9kYzeh2EdOuPkKfnaAc92oXDCLsM txcgPGvVLVzbBj8pxCe73uQIADTAXluPxalvP6p+TYQXq19hMknGmWshluYEuss6+Oe7 Uo9YGOinxSBTpQJKSYnr+RmikoTUY7YyXoZg2j9EtvMHu1dUwsbcJ/tK5imCTrNp3z81 x6cJqBn38dvFdYbbgQwX9jQNQ9fgf8kHUlKWmJQ9XRqm3xAvKQDUs9z0PTwzv/ya/Prt W60d+4vaaG8z2RwcW9WfatIDadzNLgTVBCNDGpVfnkIoPpTcEr6P+gPKsnDdM6lTerOp rOGA== X-Forwarded-Encrypted: i=1; AJvYcCVBFI5ZXocfaaAvcl62ZJ5NzSwctsZHXrgLx07mh6n0U9qDix3e80PfgfU9Zy3c218SdbDatguWBeZg@vger.kernel.org X-Gm-Message-State: AOJu0YyY2JcdLeWRW8u69iiWskD/BehYGNKFvBgeUQpUuKa62ekdVHaX FgWSXz46vZJvwhgLMcSiwyEMYKH37ko/X9hoEqs+xgPHoHOEc2jJKdeRrmgogqE= X-Google-Smtp-Source: AGHT+IFtDsJPyLphAshdk30vTR0Sl8aU6sagYCDNH5sXB4NQUBZ21n39kniHa9yrRYMarUHR64R6JA== X-Received: by 2002:adf:fc86:0:b0:367:8418:fde4 with SMTP id ffacd0b85a97d-3717960863fmr1393954f8f.7.1723630732067; Wed, 14 Aug 2024 03:18:52 -0700 (PDT) Received: from krzk-bin.. ([178.197.215.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4e51ebcdsm12487737f8f.78.2024.08.14.03.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 03:18:51 -0700 (PDT) From: Krzysztof Kozlowski To: Thinh Nguyen , Greg Kroah-Hartman , Michal Simek , Grygorii Strashko , Vignesh R , Felipe Balbi , Radhey Shyam Pandey , Piyush Mehta , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH 1/2] usb: dwc3: omap: add missing depopulate in probe error path Date: Wed, 14 Aug 2024 12:18:47 +0200 Message-ID: <20240814101848.67501-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Depopulate device in probe error paths to fix leak of children resources. Fixes: ee249b455494 ("usb: dwc3: omap: remove IRQ_NOAUTOEN used with shared irq") Cc: Signed-off-by: Krzysztof Kozlowski Acked-by: Thinh Nguyen --- drivers/usb/dwc3/dwc3-omap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index d5c77db4daa9..2a11fc0ee84f 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/dwc3-omap.c @@ -522,11 +522,13 @@ static int dwc3_omap_probe(struct platform_device *pdev) if (ret) { dev_err(dev, "failed to request IRQ #%d --> %d\n", omap->irq, ret); - goto err1; + goto err2; } dwc3_omap_enable_irqs(omap); return 0; +err2: + of_platform_depopulate(dev); err1: pm_runtime_put_sync(dev); pm_runtime_disable(dev); From patchwork Wed Aug 14 10:18:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13763236 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ACB139879 for ; Wed, 14 Aug 2024 10:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630736; cv=none; b=JxROliTBfsyVvSE3xYzWEJPjUe75ygvPRfGDUiBwRYATTies0RbPOQg7uEKB/HJWLGASAbvOU+vaXBAKaAVcwlsVyLd44lHurCG4ouEzRBL3fGRCCD6aV+D9xDkI1FxXS2NBasMUkY6thJ2zs9JFwm/+M2M9/77TIwuWp3N4NlM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630736; c=relaxed/simple; bh=gMMEesu7531ovk1t3pp1ZaBof5UtMxEfANDAyFyEQg8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ty3N+1N5Z2EeJcDWNTNoqHCKoWBKIWHTSerVVKesLu9wc/WNpPmv/3C7hJDovv+FlCsFiFUtt8Ht3Xa8MT6mrT7N3o7vcaRakWBpCBVslcgBD4wp3fl8Zd2sh6Dnvp7B0ozCSO0xSSKG/vwbs4hBGqpxdvgm8meoQeNRfaJe1Mo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g/DJlaGJ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g/DJlaGJ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-428119da952so45061405e9.0 for ; Wed, 14 Aug 2024 03:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723630734; x=1724235534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hlcn3l35uWBmsmhhZa4sbReBOtxyCW7iBKefFzSaEj0=; b=g/DJlaGJeOw6w6KsZTYz7fufly0SFZ0nRMEk11ZDaG2OfEDS1j0hvlEpdsuiE0AXeN WUX9XjUg4+qqJSxD5fIsxFRiN5YocOR7A8voEerrQcDECA0Z5mJesAw1pGrmxevd5EvB LUDQv651UgIhddOX+km1d4I9uoMB9f7E7KYOJfcgJYsFbAifjenrYmuOeD+l+NSWnl1Y YQzR2lOr9MouSiSKVnziyZ/WfYXOpsxY5E/X10vbJikOV1dcd1zu/mK/01iCvFdd9QwX fdYLn43A9UbS3cP+0KKbIdTF3OoLmenbfCYdBmR6Cw1bJA3ZCvhb2D1bUdtesiuK2v0Q UTjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723630734; x=1724235534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hlcn3l35uWBmsmhhZa4sbReBOtxyCW7iBKefFzSaEj0=; b=IhFX0qGEBcgQ+5GBorX5qqtrZXg0EAwm7+tnsCKg5B4lPig8pZfjMxPdTxTC7TUHLb 2X4i5HuyT4CAwpv25b0J1j7K7tORcCOpvh3VNk86WQe5wAb8JbHymvkSuBQ+AYPJ1mZY 35Yw+I3Ezr+yzxtMeyD5h1INXthCL0fYHeouIOMzphXId6G67fOgFFqImTpYbc55Qkd7 zH7S4u5KEC66B+gFIsYceVHPU5ck2S/xrCL7S0W3K2LcKkE9BbxCFNiqyFshOP1wexgP +n4DsDPBPyrGxOBMiWchXom2xGVK4s6l9LtK+0khs3Mjibk6yFJHLL4RPR7hx7eINoDp GWaQ== X-Forwarded-Encrypted: i=1; AJvYcCXV+bTdgg+03lZo5L2Wv6yERflVhLwdieNk1Q/GIJ+fVX/OmWX+8SWMJFVdTWjbbgDBq9Qv3SYu6IujxcMP8f6nH+A5vmtGDea//w== X-Gm-Message-State: AOJu0Yz4CDfUSXBol6QeiOkWk7GHtSQTQY4t6HMzRwBi6Sp4SAX/GTf7 pPuISnHeCcn6jHeaZZULx/OFNPI9ruTHZ/Zttd3r1zeV3Cvei2Yi4PBuan+HHzg= X-Google-Smtp-Source: AGHT+IGGCYxMm5pwJ0kqTr0pa1ANOyDh7JooCs78TDBUnUD1W1Z/CNBLZN1iX4ifTQinRs8vqf79gw== X-Received: by 2002:a05:600c:4754:b0:427:d72a:6c26 with SMTP id 5b1f17b1804b1-429dd22f463mr16562315e9.6.1723630733794; Wed, 14 Aug 2024 03:18:53 -0700 (PDT) Received: from krzk-bin.. ([178.197.215.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4e51ebcdsm12487737f8f.78.2024.08.14.03.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 03:18:53 -0700 (PDT) From: Krzysztof Kozlowski To: Thinh Nguyen , Greg Kroah-Hartman , Michal Simek , Grygorii Strashko , Vignesh R , Felipe Balbi , Radhey Shyam Pandey , Piyush Mehta , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH 2/2] usb: dwc3: xilinx: add missing depopulate in probe error path Date: Wed, 14 Aug 2024 12:18:48 +0200 Message-ID: <20240814101848.67501-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240814101848.67501-1-krzysztof.kozlowski@linaro.org> References: <20240814101848.67501-1-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: linux-omap@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Depopulate device in probe error paths to fix leak of children resources. Fixes: 53b5ff83d893 ("usb: dwc3: xilinx: improve error handling for PM APIs") Cc: Signed-off-by: Krzysztof Kozlowski Reviewed-by: Radhey Shyam Pandey --- drivers/usb/dwc3/dwc3-xilinx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c index bb4d894c16e9..b7613a106da6 100644 --- a/drivers/usb/dwc3/dwc3-xilinx.c +++ b/drivers/usb/dwc3/dwc3-xilinx.c @@ -330,6 +330,7 @@ static int dwc3_xlnx_probe(struct platform_device *pdev) return pm_runtime_resume_and_get(dev); err_pm_set_suspended: + of_platform_depopulate(dev); pm_runtime_set_suspended(dev); err_clk_put: