From patchwork Tue Mar 5 21:19:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 10840137 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4795E1869 for ; Tue, 5 Mar 2019 21:19:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 265BC2C747 for ; Tue, 5 Mar 2019 21:19:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1AAB42CA1A; Tue, 5 Mar 2019 21:19:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 659082C747 for ; Tue, 5 Mar 2019 21:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbfCEVT4 (ORCPT ); Tue, 5 Mar 2019 16:19:56 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:9231 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbfCEVT4 (ORCPT ); Tue, 5 Mar 2019 16:19:56 -0500 X-IronPort-AV: E=Sophos;i="5.58,445,1544482800"; d="scan'208";a="372075028" Received: from abo-58-107-68.mrs.modulonet.fr (HELO hadrien) ([85.68.107.58]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 22:19:54 +0100 Date: Tue, 5 Mar 2019 22:19:54 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Saurav Kashyap cc: martin.petersen@oracle.com, QLogic-Storage-Upstream@cavium.com, linux-scsi@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] qedf: fix itnull.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: kbuild test robot Iterator variable bound on line 800 cannot be NULL Generated by: scripts/coccinelle/iterators/itnull.cocci Fixes: 9d8755adeaf0 ("qedf: Wait for upload and link down processing during soft ctx reset.") CC: Chad Dupuis Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Saurav-Kashyap/qedf-Misc-fixes-for-the-driver/20190305-205913 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next :::::: branch date: 8 hours ago :::::: commit date: 8 hours ago Please take the patch only if it's a positive warning. Thanks! qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -798,7 +798,7 @@ bool qedf_wait_for_upload(struct qedf_ct rcu_read_lock(); list_for_each_entry_rcu(fcport, &qedf->fcports, peers) { - if (fcport && test_bit(QEDF_RPORT_SESSION_READY, + if (test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) { if (fcport->rdata) QEDF_ERR(&qedf->dbg_ctx,