From patchwork Wed Mar 6 13:25:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841101 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB49C1803 for ; Wed, 6 Mar 2019 13:25:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C766C2D95F for ; Wed, 6 Mar 2019 13:25:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB88C2D96E; Wed, 6 Mar 2019 13:25:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60C962D95F for ; Wed, 6 Mar 2019 13:25:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbfCFNZO (ORCPT ); Wed, 6 Mar 2019 08:25:14 -0500 Received: from mail-eopbgr00067.outbound.protection.outlook.com ([40.107.0.67]:27534 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726882AbfCFNZO (ORCPT ); Wed, 6 Mar 2019 08:25:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qLnXgPwWUG37nyYymuZxDZbjc8/U+mMsYxMB1GSBj4=; b=lQHUd82SWH1rrdlvuf44uW/qy00TAez//NqK4PPD95Iy0Akd6Ki29H1999bHOWEaOV+4tUdPoxqv2CQJZGm2ol5laXaJwRCWp7EyjQEZC14lCmLFvn6vZLazvONXa8WuaXjF1It6zE7iGWwec/9KHpfyPXshyV9A6tob7Apui5k= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:12 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:12 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "dongas86@gmail.com" , dl-linux-imx , "rjw@rjwysocki.net" , "ulf.hansson@linaro.org" , "khilman@kernel.org" , Aisheng Dong Subject: [PATCH 1/6] PM / Domains: Improve warn for multiple states but no governor in genpd Thread-Topic: [PATCH 1/6] PM / Domains: Improve warn for multiple states but no governor in genpd Thread-Index: AQHU1CAG9faKd1tVckmbMj06d/iqUA== Date: Wed, 6 Mar 2019 13:25:12 +0000 Message-ID: <1551878302-8146-2-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51ec0e42-2259-427e-a1db-08d6a237292c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM0PR04MB5345=3B23=3AxW?= =?iso-8859-1?q?Sl7PN/9cA+FEmeYCtEqun7tAY3yP3fdOH8cECfD32JOfyBu3SxaUkPIH6eKM?= =?iso-8859-1?q?Zcg7DKMSKjvRSJx6OxoX5itKuF5Wz8l+P5smxrnUgGxHmGpCM2tNniR4NP8T?= =?iso-8859-1?q?sT7b5Q9OeMURBHUpyGDeZ7tEcq3L4ccuLzWuYhz0YCIC1p60vk7OEqr1fWp1?= =?iso-8859-1?q?wgL1kmC14q0zs2alWh+Js4McYBOt1nPy/+YAjK4brDKDDAHRL2f/07kfxOti?= =?iso-8859-1?q?SOvBzMU0zXhIYKntQN5A5ik5VsvfORwozwuUcSRRH2SWqxobYiv6jg5DLqC7?= =?iso-8859-1?q?oWBcs8wpXq3OdPt2kXQf3syRhrvI/xA5c7vI3rUEZbexzpA3E6oypK+y9die?= =?iso-8859-1?q?U59dmWBJ3EdfEIs7xjGC3fIbC2rgOHS/a6LFV7Tp1M/r2nxUr6LDbth58TzY?= =?iso-8859-1?q?Yb1fL4OZ9FlhCTQ4FNXvD20MS43dhCmEXKxjiM5OT+ppZYqGgok9lM9E5s4R?= =?iso-8859-1?q?Vmccmdf+ZlUYQzidwxP3tbvMAamOrIpfGnguauGjebW7FKURmR2MEAGQJ/eu?= =?iso-8859-1?q?jWlyng58b1+PZWSWA3vh1NDQoGrqWxYFgGLRMrsZPGmtgDenmVVBqqAQJZMd?= =?iso-8859-1?q?zdc5LrwdvK9+oAAa9ZP4woAu41zhjsgAogif7KTHIecqtv7pRlhaznnffBbR?= =?iso-8859-1?q?CdQ9OwhJnBJAmVR+21LVH8y67e4syy5mRmIfG0hVKP4it/f2EpAT+L8XV0xP?= =?iso-8859-1?q?EnI31FHj9RrVRC0sbbknq2gpCAw6vRUzOgvg59wNpTnRA2dvFIJEnafr3Iuq?= =?iso-8859-1?q?kxvV4an2zhzeojDefesrKfXpl1CRQ0RHVOBZBec2abUOFp7p7wLkOy4tL+zT?= =?iso-8859-1?q?XpXVchhTwCGwubUO2GlbOpsfSu9/xXQ3O5rTHVx5I+o+HNQ6nOC9NhQvY28r?= =?iso-8859-1?q?IZQDPgQhijU9moINtJxRxhhEJOYw4NP1QMmoBVS37JK92OiKJoT7iUVYC4iS?= =?iso-8859-1?q?5D96ir5JaBA8vSM+Ck4+/hqzD1P2EnDVglbat3QiL23bjDX8AKmsEIKfYsGp?= =?iso-8859-1?q?XaB8CoD2JgfHWsfw15Hmy0xkj5ifFXI6/CxaS59kZiEIf+ivQDfIpTxBfWQU?= =?iso-8859-1?q?3fsMUqwVZhXpJEE8JGfcKgrse8ThxHWBcloAheLpyJRB3fD9sne5z8Tc4HJE?= =?iso-8859-1?q?8WqxQALGXBYGe4phPq/8HvpLOr7ZYqdwzUwzytK7bl5IaTMy73KXfY7r+gUt?= =?iso-8859-1?q?oWhodrp+ms8IpakTXcNfUAamDWc0M9YcHgdQvKc1z0kxl6rQ/sAgqE3127HN?= =?iso-8859-1?q?ijpTroz2Fw0YbD3VXclbjskv7IKkwZ+ez3ZZjE0DllGTacsvDOtcRR+oB25T?= =?iso-8859-1?q?E=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(4744005)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB5345;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +A+jq9+CJX/BjUeN/WOeeYaiGFv+3Dzi4QuES/fhQlaRvpNYubFg+FK7tuYA0qfb/26qrqSyBG+DMITlPccNJYfEigOa4j4AYRMa49Bwn0Q/vqYp80o1Hi0fTPQy/45hIKLQn5OFw8EVJjo943j3FOxS/xv1K3sE987HrNUM+nLFlkBStrntieGm0XSwLOFpP4zguSib0kkdEwCugwHruzSYloE3lFxHrssBcm3Ro2YUpsCLy14vER3PqrZJgPnyogO8+rOzK/9YFPqSxAIXGO1hXxCJqvld0ARJut2wmhW9fxdCYzsJzATtmx8lUopOD5zAIXgD8XMg67eV6HJScjAlg9iFp+Bvxl3R/yiDO/IWjT8nHfukP4S0NvcKEp7OtW6wbtwY7IltvStHrgdEOxwJzsciRyLosGroPJU3XxI= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51ec0e42-2259-427e-a1db-08d6a237292c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:12.1818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's possible a PM domain defines only one state and it does not need a governor to work. For such case, a warning actually is not necessary. Signed-off-by: Dong Aisheng Reviewed-by: Ulf Hansson --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 2c334c0..394f9da 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1766,7 +1766,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd, ret = genpd_set_default_power_state(genpd); if (ret) return ret; - } else if (!gov) { + } else if (!gov && genpd->state_count > 1) { pr_warn("%s : no governor for states\n", genpd->name); } From patchwork Wed Mar 6 13:25:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841103 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0E42D1803 for ; Wed, 6 Mar 2019 13:25:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE4A62D95F for ; Wed, 6 Mar 2019 13:25:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E238F2D96E; Wed, 6 Mar 2019 13:25:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A4272D95F for ; Wed, 6 Mar 2019 13:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728747AbfCFNZT (ORCPT ); Wed, 6 Mar 2019 08:25:19 -0500 Received: from mail-eopbgr00085.outbound.protection.outlook.com ([40.107.0.85]:39492 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726882AbfCFNZS (ORCPT ); Wed, 6 Mar 2019 08:25:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7nkgWBuioz+922pJOcaiisSpu1jNZ4+FFA1b2Hk11gs=; b=LYlu9ROgnsrqoJ2eTZH8Us/wjuUJsuGOh7jJ+Kc9b3AoyE7XnCWgs44ZVl99Pq6VZ9d2Nz1bBYmD6MBoswEdzugikqGfLzyOxVSsICbWHFYiEWxjSltUcecrymEL5apsRK9/HsEAr2vnfzghimguBtQO4qKOxAAbJh+rj2oT740= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:15 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:15 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "dongas86@gmail.com" , dl-linux-imx , "rjw@rjwysocki.net" , "ulf.hansson@linaro.org" , "khilman@kernel.org" , Aisheng Dong Subject: [PATCH 2/6] PM / Domains: Return for all error cases in _genpd_power_off Thread-Topic: [PATCH 2/6] PM / Domains: Return for all error cases in _genpd_power_off Thread-Index: AQHU1CAJEYbz4lRmTECgXbYWCDIjjQ== Date: Wed, 6 Mar 2019 13:25:15 +0000 Message-ID: <1551878302-8146-3-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 832138c6-98b5-4365-e3d8-08d6a2372b3b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM0PR04MB5345=3B23=3A72?= =?iso-8859-1?q?DGiHVjh6UkqnAwPtDJVtHrGMlta7A5rRslJUvayu0LFFpv8GlZ3aOIU3/0H+?= =?iso-8859-1?q?5loeWiJz2OoTyD9qzZthVtKlMhaj/okS+pcxuubyLkz6YwqGOwZPQcYtcfsD?= =?iso-8859-1?q?nhPd0rFBGuo9477Ie85vjKacp5S3IqrtZ9NglTXL6jX1riL+aBDM+WxlWYOd?= =?iso-8859-1?q?TH1n/uoF8GWWKNJrzNY7X5JrBQrL6lo6h9dUTE+zSR2+Yuo+cay54QnO1rvk?= =?iso-8859-1?q?hprfaMY3RV/CUC8ojmEfbiysf1hhzOVa1/N1iuq/C4dsHqNiIJA2Z6uRKmAN?= =?iso-8859-1?q?P7FfpNyc1nV5UPR2j9G1pYAPbnf8QsfVBRMRAoRLvvt3vaySsq7qqy/4923P?= =?iso-8859-1?q?puR4KjKc69JcNwprixpQw7G6DtJYSVn403wQ5rCZyEKp27SFhHymMT3ryJU9?= =?iso-8859-1?q?89spaez4ADasz+Niux+cUdPZlKLA/lbV1OxJ4zk7N/9AMXuVJurHKss1mS6l?= =?iso-8859-1?q?EFwX6P+b3FWQbpCg1V8rDguCWk/XgIiE6oYALFYPgv7U2auDJGGsO+vTnJGd?= =?iso-8859-1?q?RQD2FyEOGZxT3V3lOCthHxvG4xj7DvSlWmW8hX6sV480y6kGLOmxkDP6BM1h?= =?iso-8859-1?q?N0qA3WxMVHAiljNJoV0Vw8Kw6Moaqe2Vb1LnPQwSXMO7FDRyxS61hNmgilz/?= =?iso-8859-1?q?uCJt7M0rJPPnJxxyoBAM2qhGyUK6ko2TNON5+CKfZ45mIvz4YMTJomZMYaRe?= =?iso-8859-1?q?mE/1yOaNsBOtBMu7s4Qly63D9zs36Ik0e/SkAoI5IB6oFCcuhBAmAReopTX1?= =?iso-8859-1?q?ME+HxnIQtMwPhjH029N+YZSZqA7EbIbtZvc5DV/G9ensIhJ3kbcM7fX+hZNY?= =?iso-8859-1?q?fmu4nqTGXREwEDeHJ1gWuzgE0CogCkh+Hx++Pwm1ZSe8ACQtQG7yS0Z1lrGW?= =?iso-8859-1?q?JD4UFdMz2Ac6pvqqWbACZBJjrnSu66LxpCBkJD9dLcle6+ObcyOubWf7CLfI?= =?iso-8859-1?q?2qs9dKBPh6wqJOLDkx/b2O3cbfqjm7EQIPeEj/r/D3aIC/GnOGVIj1R6hyb2?= =?iso-8859-1?q?7m5G+quEwWu7GxSkD1qLvRm2j9VVyotwPR7hWIap5Wq6U47/rgWliAOy8FgS?= =?iso-8859-1?q?j6P+lfaXGKqrxLWpYK5NrUzP4QT3+bPCIgM7nPtAXu0IckPQoaUZchirqrHk?= =?iso-8859-1?q?Mp4x7v3u+et0dpmSEerrGApfdo+Z9Cit1EXusD6/zfGSpKO175RtM2RQf40J?= =?iso-8859-1?q?emOXkPDj15DUPMS+RJQiIrzlG7nySiYnQqAT8XWTtNSiKPyxLYlnKeRkFYvC?= =?iso-8859-1?q?w0qgKjclSNJvUUim9z?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB5345;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 54rfaafomUOU8hxbHFq97xXkaobDK7uHThB81gCJg7fxorkTZiVXfIa/zGklP3nEmgTmArYVJK35QFSDQOc/TM6oQdpikgbsOIUEZBWZ/Hl13b57hoJnWlgFf7RmxitTVSr+H8g3M++T3il3MF4gZ5+ZQrwhHwzisL9JAw1Lp5q4W8YGRYovopxHEsplTvIWxyNzHlBP1el8zF4ANV6CLPx3b7VAVQrAaDK+4Z6Vy/Kiext0+i8DDZcz4vmKx5x+BV9ae+9NvGj5HtkmC9kfu9SOH9ZWHhIL8yaIBB6qPkr8eEWpqra3gmgK+LsSAcSYPUtoHODGIs68AlVP9yd2emD6RBzodRe8nnT4yyE6QId1PMDGzTLtsFjq1lnL3nf72mPWYMwiRHsXLiiedgFGMBc6CwRbBueX9fjKYLAsWPI= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 832138c6-98b5-4365-e3d8-08d6a2372b3b X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:15.7183 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It is strange to only return early for -EBUSY state and left other errors to be still measured execution time. As for error cases, the elapsed_ns computed actually is not quite accurate and meaningful for governor to use. So let's simply return for all error cases. Signed-off-by: Dong Aisheng Reviewed-by: Ulf Hansson --- drivers/base/power/domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 394f9da..f012576 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -457,19 +457,19 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed) time_start = ktime_get(); ret = genpd->power_off(genpd); - if (ret == -EBUSY) + if (ret) return ret; elapsed_ns = ktime_to_ns(ktime_sub(ktime_get(), time_start)); if (elapsed_ns <= genpd->states[state_idx].power_off_latency_ns) - return ret; + return 0; genpd->states[state_idx].power_off_latency_ns = elapsed_ns; genpd->max_off_time_changed = true; pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n", genpd->name, "off", elapsed_ns); - return ret; + return 0; } /** From patchwork Wed Mar 6 13:25:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841113 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8FD881803 for ; Wed, 6 Mar 2019 13:26:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7BCE32D96D for ; Wed, 6 Mar 2019 13:26:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FE622D976; Wed, 6 Mar 2019 13:26:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, TVD_SUBJ_WIPE_DEBT autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 15C342D96D for ; Wed, 6 Mar 2019 13:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728800AbfCFN0C (ORCPT ); Wed, 6 Mar 2019 08:26:02 -0500 Received: from mail-eopbgr00089.outbound.protection.outlook.com ([40.107.0.89]:42629 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726882AbfCFN0C (ORCPT ); Wed, 6 Mar 2019 08:26:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y3gLM0Ep3WXLLGMnQhSS5jXJYa4NVBZga3MU5w3OOzk=; b=Hcl33a1y5r5V7h1Y5Fd9SjKxoeSStVjS0/GKrBcVw4LLnLIdYGseQ9hhq3TkRnfzkELq1Jigq37VUI0CaPVzQtQcLpGcSGi/G84G2NjUNddG9/UDumk/gGIqm+MMeBLlTspLZ95DTr8zTiNTx5sTWYCbHw3QAX9KVhOmRgduD2U= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:19 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:19 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "dongas86@gmail.com" , dl-linux-imx , "rjw@rjwysocki.net" , "ulf.hansson@linaro.org" , "khilman@kernel.org" , Aisheng Dong Subject: [PATCH 3/6] PM / Domains: Remove the unnecessary ->power_off() check in genpd_power_off Thread-Topic: [PATCH 3/6] PM / Domains: Remove the unnecessary ->power_off() check in genpd_power_off Thread-Index: AQHU1CALGa0PmZep30ehAvf1aptxPA== Date: Wed, 6 Mar 2019 13:25:18 +0000 Message-ID: <1551878302-8146-4-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e8ffba3-da54-4616-203e-08d6a2372d58 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM0PR04MB5345=3B23=3AuQ?= =?iso-8859-1?q?6Ud3DGHsLWt/PZ0G7lsUhQ0IEhV1yStOCbpCFWfXGyiu8HajFhmHkR8Hq6Ma?= =?iso-8859-1?q?lhRJfm37wQkNnhf9JYJ2haRHIzojgda/se4OUmv02ZrUwSHqqA0gjhdLx4Kg?= =?iso-8859-1?q?hPL+GWGnvO2vXOJJGbGjmjZS1wzbnwDl8OJLCucJ4vOIby6w8zcjFPaC9MJR?= =?iso-8859-1?q?1eLUHJI8z5pNZLqtPUaDkKKBAE5cXKyuDkanqaARajVXsFN/k91u/I4om4xj?= =?iso-8859-1?q?kqVii1ilSA+UdnrfJY1GmbXONkIpZRBDNf4bo0ynzHDm43Hd5tbDuBnnXnzV?= =?iso-8859-1?q?n6F1KC6baqFDWw4DiCGc2FaJkithn4AEIkd1y16Ck/AmLc/1Vdos8xXUgZpH?= =?iso-8859-1?q?PCeCxiHGNZ0q6DWlZwf6CukFSR8UJ29yn+lqxL8RlPZIjdYkcDHNGflSPyqd?= =?iso-8859-1?q?JvkMBb2YCOoy+QSqU5BOcKaq4F/7U6Xvdo+KHODKdSk1Q0ScKh1RKt9SswLi?= =?iso-8859-1?q?DICDnbx7sIDq240S3ASrPeclzbom4m2Z+Kdg3Qjd0skrWcz1SjiU6fjOZTtT?= =?iso-8859-1?q?4zOTgHdIalSOXwDlJNYnknrmFSJ3BDYfbqtU4/ciHOnmAinQOQ+w+U5ARpWD?= =?iso-8859-1?q?UAXUt4ccLQHrzF29e0hTJTiklT2Pniz1Jru8wUrymOXaXSk2ACvpw0GdxPst?= =?iso-8859-1?q?DryKgzuDggiYRywCZgCAXu56snAyKUy4f3kflSjigUO/zeRZ1l2vfPNlJtsK?= =?iso-8859-1?q?2XB3x7K6xxaiM7uogzXS/D63M4PTQ9HFsmPemPDDCXqL8XSBWbyav2u2Z1zR?= =?iso-8859-1?q?KZ6GfPhM6NBPRC0T5tGwTq8Ge9Hcj9Xw0j64uOIaCT/glx+YqHH3mbUD2LOs?= =?iso-8859-1?q?K7t5oM1brlD6o+p/LsUrFoAR60/fbt/1WU3bDL4cykl46EvWDwoxt1cPT5Pn?= =?iso-8859-1?q?Iy29QYfOLkKObn4jJ1M9oYek5C2a2d++XPGTHdnZzZBaa0wNLduAaIs2y/D+?= =?iso-8859-1?q?eAcwshm0utefHu1ZOsdHbcpjKGQmcaC3XupqBWrRCXKPPK4/yAY5ACBnbk9b?= =?iso-8859-1?q?mCvrsessfMePvs5KuFFrRO+rj4+XKqrATke0ZMXgvKC28KiWeKRSCluJ7XGk?= =?iso-8859-1?q?EdPoIrJbadiAHvG6ajlGUD1oztsFOnOUE7rF5i6LapWwkcmwTs8BoIZsfCUH?= =?iso-8859-1?q?zwNsApr+sb5ximrDB0saPLHpOEKpDkrJioWzlo+E8XMb9MW3fW2SYKy3VblV?= =?iso-8859-1?q?h2btfh0ljnLT0ind7FRvisPo7kQ+bxkzXS3EAZ1+rqFrwZFEWD76/bY75Zzl?= =?iso-8859-1?q?2ITLa8uCj4AJVA56UhUElW32h6GPhcd9Uetmjn9A=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB5345;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: X2Uiag33iWD+5oF7ZU+vXkCul2USrviIpWp+lDicnd8OUUwHyaQzLv7ekiOgBMIWGJyrzTKuGBj91G37m3xjVHMVhJFFmyguoTTrxy2O40LkoxuIcaM+MmP7LDb7/ZlvF3L9SSy4iJGA4+o8wOoEPnwkNAd6D8NIANARfZC0xcThJwAz+Vuad7190eJvk3u8f7oMODWOPAxmwOWD26DUiQ5aA116hTBQj1xfjGOvTdr4uuxJY+Htfg84DKdImL3bqU/R2Ig7IKsh+FHHRuBq2N261KaZfOd8WcWs7Rdoga8gvi8ytmeGjn0e+JCjmOyC4Sz1GcWkGNqT/wO4KncxB2pMLOlzXmRL0/1qsjaQr4bzlvU5rhKlEPjK1X+XmWRL/HxYsCc+hIkADvvk9/pTOxvbHN+oXmBLaEjmC8ktNG8= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e8ffba3-da54-4616-203e-08d6a2372d58 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:18.9997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's already a check in _genpd_power_off, so caller can directly call it without checking. Signed-off-by: Dong Aisheng --- drivers/base/power/domain.c | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index f012576..591f37f 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -501,6 +501,7 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, struct pm_domain_data *pdd; struct gpd_link *link; unsigned int not_suspended = 0; + int ret; /* * Do not try to power off the domain in the following situations: @@ -546,24 +547,20 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, if (!genpd->gov) genpd->state_idx = 0; - if (genpd->power_off) { - int ret; - - if (atomic_read(&genpd->sd_count) > 0) - return -EBUSY; + if (atomic_read(&genpd->sd_count) > 0) + return -EBUSY; - /* - * If sd_count > 0 at this point, one of the subdomains hasn't - * managed to call genpd_power_on() for the master yet after - * incrementing it. In that case genpd_power_on() will wait - * for us to drop the lock, so we can call .power_off() and let - * the genpd_power_on() restore power for us (this shouldn't - * happen very often). - */ - ret = _genpd_power_off(genpd, true); - if (ret) - return ret; - } + /* + * If sd_count > 0 at this point, one of the subdomains hasn't + * managed to call genpd_power_on() for the master yet after + * incrementing it. In that case genpd_power_on() will wait + * for us to drop the lock, so we can call .power_off() and let + * the genpd_power_on() restore power for us (this shouldn't + * happen very often). + */ + ret = _genpd_power_off(genpd, true); + if (ret) + return ret; genpd->status = GPD_STATE_POWER_OFF; genpd_update_accounting(genpd); From patchwork Wed Mar 6 13:25:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841123 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1AB321803 for ; Wed, 6 Mar 2019 13:26:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 036BC2D96E for ; Wed, 6 Mar 2019 13:26:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E9FE62D977; Wed, 6 Mar 2019 13:26:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 85EE32D96E for ; Wed, 6 Mar 2019 13:26:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbfCFN0l (ORCPT ); Wed, 6 Mar 2019 08:26:41 -0500 Received: from mail-eopbgr00075.outbound.protection.outlook.com ([40.107.0.75]:12354 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727304AbfCFN0k (ORCPT ); Wed, 6 Mar 2019 08:26:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y/xuxisU4vv5vRzHAShWyRDcg2nis3Q//bBEKXXRVb8=; b=NQ5uSdAyfI+7Lfyup71zjfiNBIO39uQQYrVJuNkHXApZjeBJaG0D7QENj8/aYVQGNxTY23LgFg4Dikp2JsARZEf6eA/GtQWDqsAR52UZeb22a96g1Ql9cBeOMUXYjejeXwMEGI3uGZEqu6IQcPKr+HPsCNHyj6yQ1IpN+nJp+0E= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:22 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:22 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "dongas86@gmail.com" , dl-linux-imx , "rjw@rjwysocki.net" , "ulf.hansson@linaro.org" , "khilman@kernel.org" , Aisheng Dong Subject: [PATCH 4/6] PM / Domains: Move the Subdomain check into _genpd_power_off Thread-Topic: [PATCH 4/6] PM / Domains: Move the Subdomain check into _genpd_power_off Thread-Index: AQHU1CAMzk547olF3kOGQCSlDNQFUQ== Date: Wed, 6 Mar 2019 13:25:22 +0000 Message-ID: <1551878302-8146-5-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 519f0d6d-6b6b-43fc-d089-08d6a2372f4c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM0PR04MB5345=3B23=3AeJ?= =?iso-8859-1?q?YEuWzAw+JqpTJUy8mwdNPHY70+Yoo8pbSz0hh8nbTgpwW66Om/YEgdVaQibJ?= =?iso-8859-1?q?EW6NE8HkX8VtApURqFhTbzr+rW/ceXQsU9OejS6RB2IyIh4EjTGSPufRdBfk?= =?iso-8859-1?q?8I8sFdxd6NN9ctMzhTT0+9eUic5nC+/qHZlungL70gQAWVB9V6RiOTRYRV3N?= =?iso-8859-1?q?DP8pKcTUILZ6W42nO5aZAUK0E6r2efrJFhy7QjXN+kgWOko+1h15Ijp0/iOj?= =?iso-8859-1?q?JhOf8eh4DnmACksntmG/D7Ah7hXTITuDJprqs8cHmf3ohjH6QOIMV7lyyh92?= =?iso-8859-1?q?S65uFs/l+5NJ2guyFhz1/NVXnOnuNi+EsJmYHNSnJnLTJJSXZdoTDTEnTMx7?= =?iso-8859-1?q?wpJdp64hIIAeCdQCaF6JhwZ4UiC0lxd7oXiv/5wK7De8iszwutFSXZU21zRq?= =?iso-8859-1?q?NlqL4diPtYtmqhGzzaKAxgGs7EUEWeB8MfRMYspeU76+czkDexb0mtPViNyX?= =?iso-8859-1?q?1BU61IPd7iGN9G1r7GjVH+Nh9QGlwpFatHDDkztpK5UvLs8pEcU7A4cR3PA2?= =?iso-8859-1?q?t/X9OJyZIwdi26l7+pVNiFnoJkYuQoDCp5CHd9GOyePR2Mf8nJLf8zdHK1Ci?= =?iso-8859-1?q?ppdV9NtwyHnQf6a9bK+X/mVWo9m6pIxg6C+2FRav18d8hzYgba2IUyzVwqEx?= =?iso-8859-1?q?Jj9obj5hzCLowjqtaABcHXWc0w9yx1g7queDfVJ3UZMxuOqZxRb+CDAIAIQ4?= =?iso-8859-1?q?8ARUn9oVM4pRsRoeQuvjKwdchcwBLAMD1zn4wdG5u/75deXm1yFCmY+B/SH/?= =?iso-8859-1?q?WD10aESD1P/3T/DLT/gkWvv4nREmVR26M9sENOEBLjaTD+CJONGCGWbQT64H?= =?iso-8859-1?q?ZmqkG97N9fIK/Uwzy2vU5XKpZmueTJTtMebPWCaVP4F+J/wQu+esPGMxNAgN?= =?iso-8859-1?q?Uge7UqQUIWPKeatCq2Ts7cGpaydnwCp8DJWdMOFdS43SsBDDUsy/sRJORbNB?= =?iso-8859-1?q?fAKTpz85E18fCcRdM0k5ls6XINsVVj8V3I41+MeP4p2n2YveZ+l+6cFjvZHI?= =?iso-8859-1?q?jzC5cerj/v3omBm4pMt5ixehEHSH8aC0NMeIMp1pdNcZVCtgFxrdEDyXHlDe?= =?iso-8859-1?q?GefO6QJ14onnSuAGX74xg+NFiXoblKdoNNnmOHrRZ/gXzYV4fbBzpz2lNaYW?= =?iso-8859-1?q?DtTk9XGfHycfmzsifz1nVBL4B1rtYfFTp619/rvkPRxmNTbgJoXG+8xPABVO?= =?iso-8859-1?q?p7BWdf6NXevC0lTUxpuXkZzpFWHlNvKrp/6nwyE+j0S9s5vyJG+ibWMQxUS9?= =?iso-8859-1?q?BUExjzdLYCryeQCpv/JKQmKXFlXYPiJz+KGBtv/A=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB5345;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: aO51EvjtVxFXkrDz1AY3lDXVIN2+ICX4lp1yaQQkcpd6fXWgB/NV0Cjy8PaHhqd/5oHeorzIALG7pXCdh6BxdQBiJze0WRCWbKnszuNwWwYHGbX/ERBklWlTKBI/nuHiOLvdvDC/GVdpVvQjA8inzSwzXeRZeFEHae58qmcWrUljPlN5dEs+BwZpQZrVsddeVC1M8FZR5xG4kxy9bKFa73NYvsT+/rnukRzEJTcKgYuAMTGDCDXFGvYpMse8LQHibOG+FtsrepHsUh52TAWhIgWutFBwT7rUXbWaZd9bDslntnvKQVHS5i0mAu3DU32EzmOa6alRA1jgqPW8tlycQ1kc10ON+Kxb1ZPBuJgoGvooAqyEppYnp2dy9MFBhR2vbjfLw6aJFv/l78+jOTMj8Y024ikEXEpDpEfnJlTG7+k= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 519f0d6d-6b6b-43fc-d089-08d6a2372f4c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:22.2630 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Move the Subdomain check into _genpd_power_off, then the caller does not have to check it each time. This also ensures a double check of &genpd->sd_count before really power off domain in case it's increased asynchronously by subdomains. This is the same behavior as the original genpd_power_off() does. Signed-off-by: Dong Aisheng --- drivers/base/power/domain.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 591f37f..61cd500 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -452,6 +452,9 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed) if (!genpd->power_off) return 0; + if (atomic_read(&genpd->sd_count) > 0) + return -EBUSY; + if (!timed) return genpd->power_off(genpd); @@ -547,9 +550,6 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, if (!genpd->gov) genpd->state_idx = 0; - if (atomic_read(&genpd->sd_count) > 0) - return -EBUSY; - /* * If sd_count > 0 at this point, one of the subdomains hasn't * managed to call genpd_power_on() for the master yet after @@ -962,8 +962,7 @@ static void genpd_sync_power_off(struct generic_pm_domain *genpd, bool use_lock, if (!genpd_status_on(genpd) || genpd_is_always_on(genpd)) return; - if (genpd->suspended_count != genpd->device_count - || atomic_read(&genpd->sd_count) > 0) + if (genpd->suspended_count != genpd->device_count) return; /* Choose the deepest state when suspending */ From patchwork Wed Mar 6 13:25:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841115 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 48AC914DE for ; Wed, 6 Mar 2019 13:26:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 350C92D96D for ; Wed, 6 Mar 2019 13:26:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 289EE2D976; Wed, 6 Mar 2019 13:26:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD04F2D96D for ; Wed, 6 Mar 2019 13:26:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728803AbfCFN0E (ORCPT ); Wed, 6 Mar 2019 08:26:04 -0500 Received: from mail-eopbgr00089.outbound.protection.outlook.com ([40.107.0.89]:42629 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728748AbfCFN0E (ORCPT ); Wed, 6 Mar 2019 08:26:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u8Inpm01HuN06vC0hunGcQTPeTA77qZA1/PYKqUYVrw=; b=DwIXkuUf/Ho82rNeZoUknnZo5v9pBMKWvEBvrFKeeGIiR+MFc3mi77PsEegvwJxD5vTyYeou50ttgUcmpAjgYqzb98k59B2sH6mDgvq3EiGWvxIKpfTI+if4G2kI2APr3iWo8/WcIKaOfAg95VOPMeDPMvlIz9vee2xibEPxzYo= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:25 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:25 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "dongas86@gmail.com" , dl-linux-imx , "rjw@rjwysocki.net" , "ulf.hansson@linaro.org" , "khilman@kernel.org" , Aisheng Dong Subject: [PATCH 5/6] PM / QoS: Fix a typo in file description Thread-Topic: [PATCH 5/6] PM / QoS: Fix a typo in file description Thread-Index: AQHU1CAP/M2cmYJ/UUG4SZb/w6VvKg== Date: Wed, 6 Mar 2019 13:25:25 +0000 Message-ID: <1551878302-8146-6-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48283d63-982a-4172-616d-08d6a237313d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM0PR04MB5345=3B23=3A2U?= =?iso-8859-1?q?68A/dfu9dpwxhbqAKfIWxrUjJOkcgkQNgbkEBxO3N4O+eio4ZjlUQgDrVYPn?= =?iso-8859-1?q?bK8N/drPnc7cNb7HfJpQIkDREp48CwWf1+ZkHGlc/DNHzpP5akAP/4z128i0?= =?iso-8859-1?q?i6J9PqslIB2JRPg+kVSK5N/rDBWs8ySTMx1y44DIDHInfbHqHFG/C9pMBjO1?= =?iso-8859-1?q?oYTY6NofPOD0IrZUaKg2dD693cjD+y3NYDJXKEXtAlnKnJyGZvzeihsMFb2/?= =?iso-8859-1?q?IwMkB3N1/rwGKN8g0PcXww9cDGXZqCRqv9I09VIeQWwyDfh+eGuTMlZXRI4V?= =?iso-8859-1?q?bloJGcooQVuQWCZG4YekETgte4tLHxU89Cqil+HH9IRK6OkXfSOL7fBV8l26?= =?iso-8859-1?q?OZIOyN59/MBmNX4lRxd9F2yRQ3QqYEVK6G7tX7ufi/stWUs7knZd2aIp1+So?= =?iso-8859-1?q?AK7ZIR7PLJFyYoDmPtswHuR9CwfMKOWa6hcfKnmtlJwKdOCc5DZSkeJRINwo?= =?iso-8859-1?q?3IUsYJ7rHUnAGXu0O3B9s990LADoqce9+7V/yYJrsHaVz/fhm3Ny/+fYfcUF?= =?iso-8859-1?q?ZSoXGTW0LyEfcZZtHelOqRn4M6oCQ/1z7C8zKjwQvAaKCm4qV634i9OKMlYV?= =?iso-8859-1?q?yP+uLIBGmSahmsQCFcWo5CecQli2/vryqzXz9uGaKbKtLHDSJDooIfUCKNdK?= =?iso-8859-1?q?hfZmcFrfmWWM3xUevEussUbjH/qd6Ugj4QpOrugi+rBAT3wwkLFreLqv7V7o?= =?iso-8859-1?q?+ZwkwpZ2K3i8jSBHoxm5vXRE5ckTfdY48Pbf94XpjbKgZN+ltY36b6u4SuUj?= =?iso-8859-1?q?oGgfK3sosXQC3FP7D4uKs2BWfvi26W9RGYpZ60cT2wXZgBcRcJHMv/D4M5EU?= =?iso-8859-1?q?P2UO4Dku8ASXvc5AWMCE8NpyguzKolhYw/tx8xmDs6XISGnjAhYSl0Q8HVCi?= =?iso-8859-1?q?HF/tLsTJXlTXUg8rrsoOllC48Nl1hu/67j0JRqH38Mksc3+iXvZAlKWh3H4W?= =?iso-8859-1?q?VYw8oK8s3+dEwDcV1NRi4WcO4Qdug5AtMyOzqRjecpDKo4X8ZRPhrfImSMV6?= =?iso-8859-1?q?9vr7UMMRR8v90m6bRsehjzRPPfozcFZFxG6JZNDzMueS1iMAcyJGEtOKz8e7?= =?iso-8859-1?q?t/dEr6lov/LplzC78l6EYGpCWUz72P1DBJ3IcWzdbb1R04U68JAB1hcaseIo?= =?iso-8859-1?q?bb8bi4ZlRnpWEz/gsT4HLOWi8nhG0dxDeW/S0EhXd50bdqi4rvgAJk1GuqzM?= =?iso-8859-1?q?fDUfH4KuSQYL4EfvflZ4JHDsdKgcdEt5nfCgelExf3CfaOjwn1zx21alFV5K?= =?iso-8859-1?q?p58knwVcbiBiTwgRzrcuhnaGXba5F7Ff8ESJSC2jXGzzQ3HD9WYssJJvh66p?= =?iso-8859-1?q?I=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(4744005)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB5345;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: J7NjUri5RUMCR+yxgrEsMmi62nT6MEW7SSCLzxbCB3LAsLuQryXihggnds9GbUOawPMY8ddk94aa2MlWTIQmr0uDoSGJG8IbaQl4krDhOoloJ98X0Hyhypga2o0i94lWozaJ2iOD2ysr0M6rhsdjfr7RDTFopnOgN3VuJBrpf6M9N02YqMcql8Ot7fjYvZqKFwBQPtN1sZasXxxMkHvxwNYI8CebCHoKOAIlK5/PyNVWERUzjtgLfhjK17OEe/Ndchu/hSOT4Kq6zW3kt5ai3F3+FVntn7GXaiURv1AINPkhfihW+skxO5ynL1e7MrrPqdLfqg8qlNcs8VXUskeyNY8D46WbFE5XkyWl3pKgBzhTirHu55rYiEw5VNlmCqIhm2xKJsafKwhHe+A2hbyPag7gJVUWMC3XxXSAsm2sgyQ= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48283d63-982a-4172-616d-08d6a237313d X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:25.7264 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix a typo in file description Signed-off-by: Dong Aisheng --- drivers/base/power/qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c index 3382542..f80e402 100644 --- a/drivers/base/power/qos.c +++ b/drivers/base/power/qos.c @@ -22,7 +22,7 @@ * per-device constraint data struct. * * Note about the per-device constraint data struct allocation: - * . The per-device constraints data struct ptr is tored into the device + * . The per-device constraints data struct ptr is stored into the device * dev_pm_info. * . To minimize the data usage by the per-device constraints, the data struct * is only allocated at the first call to dev_pm_qos_add_request. From patchwork Wed Mar 6 13:25:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841117 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0437F1803 for ; Wed, 6 Mar 2019 13:26:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E5B952D96D for ; Wed, 6 Mar 2019 13:26:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DA4842D975; Wed, 6 Mar 2019 13:26:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 909ED2D96D for ; Wed, 6 Mar 2019 13:26:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728748AbfCFN0G (ORCPT ); Wed, 6 Mar 2019 08:26:06 -0500 Received: from mail-eopbgr00089.outbound.protection.outlook.com ([40.107.0.89]:42629 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726882AbfCFN0F (ORCPT ); Wed, 6 Mar 2019 08:26:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8oNdiJyQaTZ8oEUyQVRFD7WhzX2hNsmaiAMeSBst6hY=; b=KqOl/eWSqT00laubM7eWXXC1Ncb/m6ryGfpsDjNQB29heLEJ5rrox6eg615J+eyik1avyEcFGaczCTSXtzQF957QNzRwfOZDu0oTn/ijjzmdInRvk/aTdYryOkADBpORdQ9odn25B8GxzxXhFq70WF5pMoqW5gX3ty7ar5033JE= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:29 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:29 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "dongas86@gmail.com" , dl-linux-imx , "rjw@rjwysocki.net" , "ulf.hansson@linaro.org" , "khilman@kernel.org" , Aisheng Dong Subject: [PATCH 6/6] PM / domains: Remove one unnecessary blank line Thread-Topic: [PATCH 6/6] PM / domains: Remove one unnecessary blank line Thread-Index: AQHU1CARZTO2kTZNHkGtrmdCJoOMbg== Date: Wed, 6 Mar 2019 13:25:29 +0000 Message-ID: <1551878302-8146-7-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 221dd8c5-a40e-4ecd-18a4-08d6a237334d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM0PR04MB5345=3B23=3ADT?= =?iso-8859-1?q?j0xRHhf9e4EeEYYhSY6tnSR3yFE4K0oxYyig7aIinJZMUqMrvjcTfELPco9I?= =?iso-8859-1?q?Gce6tpM+KVbL0pu25dpcEy22gdpWmYgsGQ0CUKH63NivQXfmns5SN7yhgbYg?= =?iso-8859-1?q?HBsJY/UQ6AN1Au5C/Mk/JuxPSREM3jDALAuJYiEHBSaVEzQ6EeoPPDY4SltS?= =?iso-8859-1?q?pNQ1FonIRttEXjlgSgJx8kvjNBSXpvnBdR7rMWp/3n8uJK3wy4ylPUUpQmVI?= =?iso-8859-1?q?E4H+Lcoxzh0t/4IrxYA0pBkcg4vD20HiZ/oYCJC7WpuUet5DztUNbZMK3BAh?= =?iso-8859-1?q?w7oO7UfRFYSP7tBi/bq4n8UysE+MqmOV+h4UZbi9u4WdzSJ4+jR2//ICc+dA?= =?iso-8859-1?q?XPbkh1fBMgQFSYOrHYc3XUIanxw2/EPa7Xh8/jQRPCEY9FC7uZEoGo6Ykrho?= =?iso-8859-1?q?ywOnyoTwOkE8Ea9ul3CZedYvf/qWanHpoiGDo0wX+75jirnj2st+7GQKhtO2?= =?iso-8859-1?q?o7rzf7rUGJfuq150esyNzF/UqXxG83xtr3dq2iIm8pXoI/Qk8FWfRpZy/w4N?= =?iso-8859-1?q?rPC3yP5HQ/9C551ww/in3HtJa5L+Z+Xv58wh2Nj4rq40Aim1vslYc/8PqNla?= =?iso-8859-1?q?6grsKS4OakR34+JKmi/PKcicHKU5w7fZ45rXnBADCU+tTus1SXTSxg9wjLPP?= =?iso-8859-1?q?Qk8DaDy5jAkAf8XGyLe0UZR8R+tLoDKnTgZFrQNtlovUTsIp1QEXIE9qxhvz?= =?iso-8859-1?q?jkWFJG39aRfvEv3OzR2yo8QznYb92ntRD9Kmsanlu+80e1kfxVJPgzbrgm1s?= =?iso-8859-1?q?kXfjdVSfkg/iEN1+lRs2nUGHVSWIl5j7lZ4NYb650U+h6ob30ora+FNlREjY?= =?iso-8859-1?q?7zckbpv6bCisPNqvqC2SrN3k2fzLwCqNE9ZNakqqIyf/0RPtkquhd93X6V97?= =?iso-8859-1?q?9KwG8wvxwqzjNNI3EpCx7K2pB+eaYMpEwVgBCdO+BtFH17CQPuusc3Pv8OUq?= =?iso-8859-1?q?e4Ki03vsgg9KExvho2qAyHJZu/DgMFlepKA2yoBFqZEbfYN9rtWg9zFgLjCQ?= =?iso-8859-1?q?GYZtXncaQWTNjNgDnn1FKqebLRLxD4V2gKF+YvrIvHulqVlxQdHSROYBQUUQ?= =?iso-8859-1?q?eZfDeyWGYPK3Ve5BV5FIXppRb4EFS8iZlNdw79fO8N8VkaibW+G8a42RRU6N?= =?iso-8859-1?q?aoKrzdniz1UWHJlc17Bh4UzH6eTFLVkc5LBBAED4isHnspFiaIV/4tLrPmIP?= =?iso-8859-1?q?Htd78APVK5HbHPNLFxjVaZGrE9FaFJPh6TdO9M6K3xR+3oQ1Ox0CCwEn8kxY?= =?iso-8859-1?q?F33fy4Df4iqCXRQROg4EKGTahgf6HIfPq5PwOpqfLEtaa8K5PGVBUwNmMrI2?= =?iso-8859-1?q?M=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(4744005)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB5345;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: DWuvNsl2kHIsQtaC1H88zKlq/xS2evhqdxkBht1qOUrfjCIhCOQ4BVf/SRQkqP1bUkPfEaNl2+JcnNIlBInD+I68/wu1o//GHJwvUAqNonveULBhurvhe6EiCe4eDwoPujOn9eAMl8hSS+eqMk2scXJ3fX4LaMu03Tn3OkCB5XkG9nIPTbWCbG9qty7RASN8eo3iQSHif+yfoelOszkXHaB8CrK37rLxrBxwS8jroaSMxQfvZI3Udyg9B6ehT44DFRt14QwpJX9qUIXD4nsgP7C8hZQdfRwnctkGdS7apxxdCHXo3q3NucJeXM5u60djvM5eXg+f+ICdCbauu6aL3tOyd+xnFgWSXJpwAmYVkRqJAn4SyqBPJTerbgnDTk988ZQsESlBQ2eoRBTTtWCxGQOopBVdZU+bVxz3hFadU4s= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 221dd8c5-a40e-4ecd-18a4-08d6a237334d X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:29.2579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove one unnecessary blank line Signed-off-by: Dong Aisheng --- drivers/base/power/domain_governor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c index 99896fb..4d07e38 100644 --- a/drivers/base/power/domain_governor.c +++ b/drivers/base/power/domain_governor.c @@ -128,7 +128,6 @@ static bool __default_power_down_ok(struct dev_pm_domain *pd, off_on_time_ns = genpd->states[state].power_off_latency_ns + genpd->states[state].power_on_latency_ns; - min_off_time_ns = -1; /* * Check if subdomains can be off for enough time.