From patchwork Mon Aug 26 13:04:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Perchanov X-Patchwork-Id: 13777926 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D1951E519; Mon, 26 Aug 2024 13:04:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724677498; cv=none; b=DAzHzmqlIfBm2WmptFyIEqIVtNnW9ppunbg3ABY2uC7OwQggLdt5IPmWeR+8/dMAaLk0Re02F+uY58P4lfnge2tUVbe82JCg0gnbw5l4TaSiRCJJIDovEaETrDPRbU6cY51jJke4UxOJqrdZCEYgmFmNGOIe44ZPQ6Xre0Aeq14= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724677498; c=relaxed/simple; bh=BhEgjFc9NXhQffGqP/J/E4Mmj/rFv807sRpr3uVxgpA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eQR44oPdCHtQRA+hCzovCH8d/9TbHvWef77nnzDvczO2jjUHilP9bcVbNtuYRdfk/b+IEniNauyAe9qgYpyRieOEeO+E5XddBG2j+jgiZmt/MgYmJtuIGkFb7uCa+V5zkLzjqQrNGPkw4z6upyvNQm7wzCejpj4p7zVvKEIJ63s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jdRW4S8l; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jdRW4S8l" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724677497; x=1756213497; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=BhEgjFc9NXhQffGqP/J/E4Mmj/rFv807sRpr3uVxgpA=; b=jdRW4S8lPX7gZ74yjaFMIAbOoBJlOxhjZESOfn5H+Tbh3xX1WcSYnSwt 55aVbtmU/gs0gf2KF2dYj2hTh3TKAHW2ZW37uXcuG2OSoXro4R0rtm7ip pbi2WjoyaeRL8g68A+Kwde+4GJaXMdF+IKylvIb7UNxptksJyQNwZaczt v+rAh4lAxoB+dIB8JYbiJ5i2tQtARTeZCnt9+uW/RXhBjiWl1I9kALpGW QflOKKyGETVPLkZWTInY0M6fyMWimgqDzOZkqRMOZjO9wLJ1pMCxLAapb hzjyVdg+5TysYc6PrJRA7cDiR+IXikX5jCMlcDPyNI7C8m3PLjjVSWMM3 Q==; X-CSE-ConnectionGUID: MG4lRH2SQ/iKyeBivibMTA== X-CSE-MsgGUID: vccGpQ/yRiOkfkk64M+/Aw== X-IronPort-AV: E=McAfee;i="6700,10204,11176"; a="22966203" X-IronPort-AV: E=Sophos;i="6.10,177,1719903600"; d="scan'208";a="22966203" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2024 06:04:56 -0700 X-CSE-ConnectionGUID: iVyaQ6i9SeKGp0tCg0vc5w== X-CSE-MsgGUID: nUp855TQSYCOaqCJIdRQWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,177,1719903600"; d="scan'208";a="63038816" Received: from ubuntu24.iil.intel.com ([143.185.122.15]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2024 06:04:54 -0700 Message-ID: <568efbd75290e286b8ad9e7347b5f43745121020.camel@intel.com> Subject: [PATCH 1/2] v4l: Add luma 16-bit interlaced pixel format From: Dmitry Perchanov To: linux-media@vger.kernel.org, linux-usb@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, sakari.ailus@iki.fi, demisrael@gmail.com, gregkh@linuxfoundation.org Date: Mon, 26 Aug 2024 16:04:23 +0300 In-Reply-To: References: User-Agent: Evolution 3.52.3-0ubuntu1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The formats added by this patch are: V4L2_PIX_FMT_Y16I Interlaced lumina format primary use in RealSense Depth cameras with stereo stream for left and right image sensors. Signed-off-by: Dmitry Perchanov Reviewed-by: Laurent Pinchart --- .../userspace-api/media/v4l/pixfmt-y16i.rst | 74 +++++++++++++++++++ .../userspace-api/media/v4l/yuv-formats.rst | 1 + drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 4 files changed, 77 insertions(+) create mode 100644 Documentation/userspace-api/media/v4l/pixfmt-y16i.rst diff --git a/Documentation/userspace-api/media/v4l/pixfmt-y16i.rst b/Documentation/userspace-api/media/v4l/pixfmt-y16i.rst new file mode 100644 index 000000000000..fe4f441cd63c --- /dev/null +++ b/Documentation/userspace-api/media/v4l/pixfmt-y16i.rst @@ -0,0 +1,74 @@ +.. SPDX-License-Identifier: GFDL-1.1-no-invariants-or-later + +.. _V4L2-PIX-FMT-Y16I: + +************************** +V4L2_PIX_FMT_Y16I ('Y16I') +************************** + +Interleaved grey-scale image, e.g. from a stereo-pair + + +Description +=========== + +This is a grey-scale image with a depth of 16 bits per pixel, but with +pixels from 2 sources interleaved and unpacked. Each pixel is stored +in a 16-bit word in the little-endian order. +The first pixel is from the left source. + +**Pixel unpacked representation.** +Left/Right pixels 16-bit unpacked - 16-bit for each interleaved pixel. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - Y'\ :sub:`0L[7:0]` + - Y'\ :sub:`0L[15:8]` + - Y'\ :sub:`0R[7:0]` + - Y'\ :sub:`0R[15:8]` + +**Byte Order.** +Each cell is one byte. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - start + 0: + - Y'\ :sub:`00Llow` + - Y'\ :sub:`00Lhigh` + - Y'\ :sub:`00Rlow` + - Y'\ :sub:`00Rhigh` + - Y'\ :sub:`01Llow` + - Y'\ :sub:`01Lhigh` + - Y'\ :sub:`01Rlow` + - Y'\ :sub:`01Rhigh` + * - start + 8: + - Y'\ :sub:`10Llow` + - Y'\ :sub:`10Lhigh` + - Y'\ :sub:`10Rlow` + - Y'\ :sub:`10Rhigh` + - Y'\ :sub:`11Llow` + - Y'\ :sub:`11Lhigh` + - Y'\ :sub:`11Rlow` + - Y'\ :sub:`11Rhigh` + * - start + 16: + - Y'\ :sub:`20Llow` + - Y'\ :sub:`20Lhigh` + - Y'\ :sub:`20Rlow` + - Y'\ :sub:`20Rhigh` + - Y'\ :sub:`21Llow` + - Y'\ :sub:`21Lhigh` + - Y'\ :sub:`21Rlow` + - Y'\ :sub:`21Rhigh` + * - start + 24: + - Y'\ :sub:`30Llow` + - Y'\ :sub:`30Lhigh` + - Y'\ :sub:`30Rlow` + - Y'\ :sub:`30Rhigh` + - Y'\ :sub:`31Llow` + - Y'\ :sub:`31Lhigh` + - Y'\ :sub:`31Rlow` + - Y'\ :sub:`31Rhigh` diff --git a/Documentation/userspace-api/media/v4l/yuv-formats.rst b/Documentation/userspace-api/media/v4l/yuv-formats.rst index 24b34cdfa6fe..78ee406d7647 100644 --- a/Documentation/userspace-api/media/v4l/yuv-formats.rst +++ b/Documentation/userspace-api/media/v4l/yuv-formats.rst @@ -269,5 +269,6 @@ image. pixfmt-yuv-luma pixfmt-y8i pixfmt-y12i + pixfmt-y16i pixfmt-uv8 pixfmt-m420 diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index 5eb4d797d259..4fffa5739895 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -1327,6 +1327,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) case V4L2_PIX_FMT_Y14P: descr = "14-bit Greyscale (MIPI Packed)"; break; case V4L2_PIX_FMT_Y8I: descr = "Interleaved 8-bit Greyscale"; break; case V4L2_PIX_FMT_Y12I: descr = "Interleaved 12-bit Greyscale"; break; + case V4L2_PIX_FMT_Y16I: descr = "Interleaved 16-bit Greyscale"; break; case V4L2_PIX_FMT_Z16: descr = "16-bit Depth"; break; case V4L2_PIX_FMT_INZI: descr = "Planar 10:16 Greyscale Depth"; break; case V4L2_PIX_FMT_CNF4: descr = "4-bit Depth Confidence (Packed)"; break; diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 4e91362da6da..46f616e43ad6 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -797,6 +797,7 @@ struct v4l2_pix_format { #define V4L2_PIX_FMT_S5C_UYVY_JPG v4l2_fourcc('S', '5', 'C', 'I') /* S5C73M3 interleaved UYVY/JPEG */ #define V4L2_PIX_FMT_Y8I v4l2_fourcc('Y', '8', 'I', ' ') /* Greyscale 8-bit L/R interleaved */ #define V4L2_PIX_FMT_Y12I v4l2_fourcc('Y', '1', '2', 'I') /* Greyscale 12-bit L/R interleaved */ +#define V4L2_PIX_FMT_Y16I v4l2_fourcc('Y', '1', '6', 'I') /* Greyscale 16-bit L/R interleaved */ #define V4L2_PIX_FMT_Z16 v4l2_fourcc('Z', '1', '6', ' ') /* Depth data 16-bit */ #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1') /* Mediatek compressed block mode */ #define V4L2_PIX_FMT_MM21 v4l2_fourcc('M', 'M', '2', '1') /* Mediatek 8-bit block mode, two non-contiguous planes */ From patchwork Mon Aug 26 13:05:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Perchanov X-Patchwork-Id: 13777927 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433A91E519; Mon, 26 Aug 2024 13:05:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724677539; cv=none; b=IeBmOh1hPhXvYhnQQU+nZ5Dd52iVylHPMaStrLOoXJ5IdsH8jlZxNYkisa35JkK1tXHqGP9FTiR8Z8zejY0BSVGi5hOuBfGMf12zcPmK89HdQau/sKM9N7kSgJfKJpG1D+ex5PyK+qqnfyNAcFQoIQLZryKwU3HZDnPRlmH66s0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724677539; c=relaxed/simple; bh=j2r/lmA61y33v49zUYY94K+XWBgzrrigQwUGGXBaxnA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qsAXcAplIYJ/psFPdFfmQGA4/2ei7qXDwFbBE+jcI6l6eipoHB3SEmEF0b5oGmZz01OKwoTIxGuqZ0RWetjo/zxKxVa/0w5rycinYq/AeT+WYIu543VhWkz7R+3uDAAR0iI9iV0MC9X9blDFoE+rPtu6Yu8CZLVHMqBTkU9pun8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OvVYuUsc; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OvVYuUsc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724677539; x=1756213539; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=j2r/lmA61y33v49zUYY94K+XWBgzrrigQwUGGXBaxnA=; b=OvVYuUscftYu5LoOLM3zaoHslGilEyx/hs0dCFYqUUtYixx87j8BwVnv ZSFrp+HzYZzU8zpasKveYY7NLwUpFtF7KO+ElkypRXzMd3l160QcR9My1 KTwm7u2Fg2Gvgq9mrrnzT97QwErwa6JrdBWg5Zpwoxaj6QDIbYUsiPKW4 3HpldILtIom1FTcd9T3DhS+wS8nKx5x3a5AoUr7FY/BG339Z8lS8O2i1n pW52fHYiv3NwAQHuM4xDPoYW4hUht/Mr54obBMQnYLYWJQh18YAZzMmRQ 5Hm8awroT3XCjoZM67TJUC89hqWKRUfWaMxfTHIkgBoj5ZeoRm+QgAATl w==; X-CSE-ConnectionGUID: 8WDY/3BCRBybOO2zd49+zw== X-CSE-MsgGUID: ISYQkqrRRWyO40GtdEGjfQ== X-IronPort-AV: E=McAfee;i="6700,10204,11176"; a="23278408" X-IronPort-AV: E=Sophos;i="6.10,177,1719903600"; d="scan'208";a="23278408" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2024 06:05:38 -0700 X-CSE-ConnectionGUID: wD9i0zzqSICHlsUqseS50g== X-CSE-MsgGUID: j/b2cHPOQ6aqXtTFrfh/hQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,177,1719903600"; d="scan'208";a="62476672" Received: from ubuntu24.iil.intel.com ([143.185.122.15]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2024 06:05:35 -0700 Message-ID: Subject: [PATCH 2/2] uvc: Add luma 16-bit interlaced pixel format From: Dmitry Perchanov To: linux-media@vger.kernel.org, linux-usb@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, mchehab@kernel.org, sakari.ailus@iki.fi, demisrael@gmail.com, gregkh@linuxfoundation.org Date: Mon, 26 Aug 2024 16:05:04 +0300 In-Reply-To: References: User-Agent: Evolution 3.52.3-0ubuntu1 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The formats added by this patch are: UVC_GUID_FORMAT_Y16I Interlaced lumina format primary use in RealSense Depth cameras with stereo stream for left and right image sensors. Signed-off-by: Dmitry Perchanov Reviewed-by: Laurent Pinchart --- drivers/media/common/uvc.c | 4 ++++ include/linux/usb/uvc.h | 3 +++ 2 files changed, 7 insertions(+) diff --git a/drivers/media/common/uvc.c b/drivers/media/common/uvc.c index c54c2268fee6..027498d37464 100644 --- a/drivers/media/common/uvc.c +++ b/drivers/media/common/uvc.c @@ -120,6 +120,10 @@ static const struct uvc_format_desc uvc_fmts[] = { .guid = UVC_GUID_FORMAT_Y12I, .fcc = V4L2_PIX_FMT_Y12I, }, + { + .guid = UVC_GUID_FORMAT_Y16I, + .fcc = V4L2_PIX_FMT_Y16I, + }, { .guid = UVC_GUID_FORMAT_Z16, .fcc = V4L2_PIX_FMT_Z16, diff --git a/include/linux/usb/uvc.h b/include/linux/usb/uvc.h index 88d96095bcb1..1c16be20c966 100644 --- a/include/linux/usb/uvc.h +++ b/include/linux/usb/uvc.h @@ -118,6 +118,9 @@ #define UVC_GUID_FORMAT_Y12I \ { 'Y', '1', '2', 'I', 0x00, 0x00, 0x10, 0x00, \ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} +#define UVC_GUID_FORMAT_Y16I \ + { 'Y', '1', '6', 'I', 0x00, 0x00, 0x10, 0x00, \ + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} #define UVC_GUID_FORMAT_Z16 \ { 'Z', '1', '6', ' ', 0x00, 0x00, 0x10, 0x00, \ 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}