From patchwork Fri Aug 30 02:56:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 13784136 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BF2BCA0ED2 for ; Fri, 30 Aug 2024 02:56:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 242BC6B007B; Thu, 29 Aug 2024 22:56:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F24A6B0082; Thu, 29 Aug 2024 22:56:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BA7B6B0085; Thu, 29 Aug 2024 22:56:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D95486B007B for ; Thu, 29 Aug 2024 22:56:55 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E9F0AAE20 for ; Fri, 30 Aug 2024 02:56:55 +0000 (UTC) X-FDA: 82507399590.01.98E068C Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf06.hostedemail.com (Postfix) with ESMTP id 9D36318000B for ; Fri, 30 Aug 2024 02:56:53 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HRDQl3Uo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724986592; a=rsa-sha256; cv=none; b=mY+IIgK4s6Cv14UqyXjmZ+zjQXRH6LvqS+r9UFxJqzhGkjsJNCqJr1b+j/KTpn+h2Rs2cK kMmug8W/7DrOlYDIKUOZFEP9jO5WkeuKBgzhmb+47+6cda0Sts3TZGmzSCAFuz2LElis30 AG0GhxSY3sTqOdr3E0zrE8RIt+LKrXE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HRDQl3Uo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724986592; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=/dWcGP7lF3rvbADfUWVIKm8PmrsKIHRmRgI9oDFmyn8=; b=DnuolPXF1ixKf9qr4wwUaw9Vo9BBSC5gtUMZ+eMP/JW2NSPUEaXB0Ezjbity7ewd09KO92 6qvbkfh/z5gUfOPQr5+XpnyF6ySyanU3acAE5gGgRv7V2d0UHiiSlIwT8+Ft//y83NRYAV KeuFF4teNAH/ZtoiyWBPD+8ZZA/8Zfk= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5bf0261f162so1399173a12.0 for ; Thu, 29 Aug 2024 19:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724986612; x=1725591412; darn=kvack.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/dWcGP7lF3rvbADfUWVIKm8PmrsKIHRmRgI9oDFmyn8=; b=HRDQl3UoVTmLlMflSQR3lZ096Ch3iBIt45fARLBhEp+t4TNjNb4rnwW7Jz0V2NTurH ZEIMCQdohHbJ1asHSg+/cVomkGcOo6NJrULUnuveipXeMsQoCepnAhxqbGeAJHb7viQj mdNXbnkGevWDSuq+gNq5TsCbuACCzQBy5mXU7FKVZzT7OmBs/WFI2Lkn6fk0DpVrX4u0 6ISFIxOJdwsJwbL9Sh0nfIRF0fE0J/Afcub3cAacqXdJagSsim2XSP+dML8tjqAz8KIJ aj4HD0aLco9g1fJdyC7uq7rQMUdAawIJTLf52IORlbBjYNSPpdG7JyokL3bS0Ou+wh8u dmTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724986612; x=1725591412; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/dWcGP7lF3rvbADfUWVIKm8PmrsKIHRmRgI9oDFmyn8=; b=svANzilmLERVjmmGcgML6gcIsgdh2NoxSj1qu77BAH5W5RDKKBKj27oPRiO0ZNFR+8 Kb7BXILIvDjjmV1xXlQ0rPHhPnqDB/GRGYavw8nkSYUgJFVrDHAqRzb3nsEZM2gmRApY SXo5Pr71Za2adgTtBZLKNzGDTNNHE8ov70Af3gnd3eCJKnaShB3oBt6l5mUeRnk2+2Hv 6ZUScztvc2km596ckrBmwCGc4WH0ROZGilo0nLMoKJXG9RoUW4N//annlC4W+7z+eBz7 rR56DemD3fZ5YPz7Cw0gr7enAVxJl7GBsbUr13wbBZ4KXlNzmkMZ0AWU2fHEusj6EsvO UD6g== X-Forwarded-Encrypted: i=1; AJvYcCXFWcme+ZfM7dc4bvrES1xejZTYP0SmWoQyTQk80K3ILnG+O7sqXRJ87TwRo7QC8wfPXZq1ucSeLQ==@kvack.org X-Gm-Message-State: AOJu0YygvINfPyO7y9FXSj4TLhmnMbSC6j1nxCGGnWX81cCBiMJZ2xQp 8gBaVQd9HRWfCWhB5SzeyvNtxDX0JCAfatpQ5vOvM7Qkzoeya6M3 X-Google-Smtp-Source: AGHT+IHkxWMYAEs00upuo2HVIQfRnumAgWQaPa/+4nh6iZhLF775S/OzDiYhI2olZpHRjHh4x59Phw== X-Received: by 2002:a05:6402:35c5:b0:5c0:9fd0:c0b4 with SMTP id 4fb4d7f45d1cf-5c21ed9fe80mr4158471a12.33.1724986611452; Thu, 29 Aug 2024 19:56:51 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c226c72d4bsm1425799a12.37.2024.08.29.19.56.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Aug 2024 19:56:50 -0700 (PDT) From: Wei Yang To: Liam.Howlett@oracle.com, akpm@linux-foundation.org Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, Wei Yang Subject: [PATCH v2] maple_tree: cleanup interface descriptions Date: Fri, 30 Aug 2024 02:56:48 +0000 Message-Id: <20240830025648.22224-1-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 X-Rspam-User: X-Rspamd-Queue-Id: 9D36318000B X-Rspamd-Server: rspam01 X-Stat-Signature: ur4y4hdjowbfin11qw4m7raworky6e4i X-HE-Tag: 1724986613-749791 X-HE-Meta: U2FsdGVkX19yTAKqnpLg8eBb1eDumZYfcfAApSi7MgUC8o2v49kCAR4/2xab0++rZLIbADMomuUkBH9TsDaG2BSBPzvJkelrfhWtbG5pSC1taC4R4YOA3zBYzHFmli8j8pjyD/MGP4s7bjn6cnGVC5CF/I05MdX1m7Cm8C2KGnSKLOmgYH8RQ8bSsT1OQnky9GlZIJ32VR8DgJCyifMBpQ+VipqYvyRMDYrt21wGbNBpolShGlX7JyUvtPePqpj1RToz/mOaLdKJC/iVoGQbxL74Kt3cvHMGS3BQsVJp49FgN3hvzJoL33WGQKGyPuu7b6vE/4CD+C67lTBz7VQZwWNgZ9RfgoN93Ka23Vt0qqhXMcKHVVWS8zbPbWqrtb4WKBBVTzA9vBFEULASwrEF0XZ0Mv4HSaiAYAavvcFOuGuDkgeC8zTV7jngjly7K31j1S9lfg9gkdejM8zCk27JkJi+Eq+HtxFb961F3fbPk1m8mholfmpiTZsicoP/MP3/T/I6wGbSh5wyfkBKgU/v31fr1M3ywrwpgDug9cob9cqiBFXHN6o+4ZisW5n4rTdeWAzTlbGrw6JuAYMO+QD+2yUEa3pQPObOQ5V3bZdy6+1jR5uw8wFkLBlo0qnLU4qZQP3f4wCWWQvQgy/PEe/9of7DLF0w5VpWzdcGKigha51oUuyMhRK707uJFay2HiNDDS8mNOqF7WnDyq/kqj8VFboizoUvIvRwrefWlYjUpNdWD5p7oFiaNoHHlx1bH3rJA2aNz4IDPqErJ9w0DCxGQuJluCGaytHae9Xrk7Ob6dwtnayWrLHRpCc4xvhDcdEwVmw/SL4j3r5y762UjHeNfC08qPJ1nkWb+aJVwpMHPdWJcZdqo8ptiDj/aA4VIXbsskHqSYhXQD3ddKazLLYhiMCp1KhdgTwp10MHG/wVjV7+fFzjHQwV01gD+xuzdmbeYAWiZpfYplU7hqiqAyQ oeYEUOkW EVu9HaG5nRnOuhYUYCgtT3S2WJMoX1vliSYCSbBg21WRaDE8o+dnaRX5y/8ZaEAr5+biup2fgI8zn60XGRu77UMmfjeAbQ4FRuy6412PtzH8zsRWa02Cmihwc4UtnrMet5AyfSrAYgEIXpWYG1ACp93TA9tgeS46yiefwXVBQfw5Lz77E+17FuKHMOGEuCYBtwSr7rMxxDLYiPoQbVYjoH/EpOscPpXblMxuHdLE7strLiqlj1qDft8foW11+F569EJNjOlbqBoi2NNDwuTMwDqFPqhH3Z0qSgiu7uz4KgHz+VkKQ1W4jSiuuZfzgSe8v+Cq9oip3Ziz7rigkNNaqDyU3TljnHA875umWC4H4T1NxV+QNV1Eo6AkFB6BLZQOAtlMt7Nb+YlgYLkwecWCru8mgFtkVTUHIIGzO2SWHFkpeeU/+BmJp32KvdmQmL3EGiem0USSOWcPvpck= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patch tries to cleanup some interface description: * function name mismatch * parameter name mismatch * parameter all end up with ':' * not prefix '*' if parameter is a pointer There is still some missing description of parameters, I didn't add them since I am not sure the exact meaning. Signed-off-by: Wei Yang --- v2: * not change them to kernel doc since they are internal interface --- lib/maple_tree.c | 105 +++++++++++++++++++++-------------------------- 1 file changed, 47 insertions(+), 58 deletions(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index 43e184f91461..a2367564f627 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -474,6 +474,7 @@ enum maple_type mas_parent_type(struct ma_state *mas, struct maple_enode *enode) /* * mas_set_parent() - Set the parent node and encode the slot + * @mas: The maple state * @enode: The encoded maple node. * @parent: The encoded maple node that is the parent of @enode. * @slot: The slot that @enode resides in @parent. @@ -534,7 +535,7 @@ unsigned int mte_parent_slot(const struct maple_enode *enode) /* * mte_parent() - Get the parent of @node. - * @node: The encoded maple node. + * @enode: The encoded maple node. * * Return: The parent maple node. */ @@ -641,8 +642,8 @@ static inline unsigned int mas_alloc_req(const struct ma_state *mas) /* * ma_pivots() - Get a pointer to the maple node pivots. - * @node - the maple node - * @type - the node type + * @node: the maple node + * @type: the node type * * In the event of a dead node, this array may be %NULL * @@ -665,8 +666,8 @@ static inline unsigned long *ma_pivots(struct maple_node *node, /* * ma_gaps() - Get a pointer to the maple node gaps. - * @node - the maple node - * @type - the node type + * @node: the maple node + * @type: the node type * * Return: A pointer to the maple node gaps */ @@ -880,8 +881,6 @@ static inline void ma_set_meta(struct maple_node *mn, enum maple_type mt, * @mt: The maple tree * @mn: The maple node * @type: The maple node type - * @offset: The offset of the highest sub-gap in this node. - * @end: The end of the data in this node. */ static inline void mt_clear_meta(struct maple_tree *mt, struct maple_node *mn, enum maple_type type) @@ -939,7 +938,7 @@ static inline unsigned char ma_meta_gap(struct maple_node *mn) /* * ma_set_meta_gap() - Set the largest gap location in a nodes metadata * @mn: The maple node - * @mn: The maple node type + * @mt: The maple node type * @offset: The location of the largest gap. */ static inline void ma_set_meta_gap(struct maple_node *mn, enum maple_type mt, @@ -953,8 +952,8 @@ static inline void ma_set_meta_gap(struct maple_node *mn, enum maple_type mt, /* * mat_add() - Add a @dead_enode to the ma_topiary of a list of dead nodes. - * @mat - the ma_topiary, a linked list of dead nodes. - * @dead_enode - the node to be marked as dead and added to the tail of the list + * @mat: the ma_topiary, a linked list of dead nodes. + * @dead_enode: the node to be marked as dead and added to the tail of the list * * Add the @dead_enode to the linked list in @mat. */ @@ -977,8 +976,8 @@ static void mt_destroy_walk(struct maple_enode *enode, struct maple_tree *mt, bool free); /* * mas_mat_destroy() - Free all nodes and subtrees in a dead list. - * @mas - the maple state - * @mat - the ma_topiary linked list of dead nodes to free. + * @mas: the maple state + * @mat: the ma_topiary linked list of dead nodes to free. * * Destroy walk a dead list. */ @@ -999,7 +998,7 @@ static void mas_mat_destroy(struct ma_state *mas, struct ma_topiary *mat) } /* * mas_descend() - Descend into the slot stored in the ma_state. - * @mas - the maple state. + * @mas: the maple state. * * Note: Not RCU safe, only use in write side or debug code. */ @@ -1462,7 +1461,7 @@ static inline unsigned char mas_data_end(struct ma_state *mas) /* * mas_leaf_max_gap() - Returns the largest gap in a leaf node - * @mas - the maple state + * @mas: the maple state * * Return: The maximum gap in the leaf. */ @@ -1544,7 +1543,7 @@ static unsigned long mas_leaf_max_gap(struct ma_state *mas) * @node: The maple node * @gaps: The pointer to the gaps * @mt: The maple node type - * @*off: Pointer to store the offset location of the gap. + * @off: Pointer to store the offset location of the gap. * * Uses the metadata data end to scan backwards across set gaps. * @@ -1648,7 +1647,7 @@ static inline void mas_parent_gap(struct ma_state *mas, unsigned long new) /* * mas_update_gap() - Update a nodes gaps and propagate up if necessary. - * @mas - the maple state. + * @mas: the maple state. */ static inline void mas_update_gap(struct ma_state *mas) { @@ -1664,8 +1663,8 @@ static inline void mas_update_gap(struct ma_state *mas) /* * mas_adopt_children() - Set the parent pointer of all nodes in @parent to * @parent with the slot encoded. - * @mas - the maple state (for the tree) - * @parent - the maple encoded node containing the children. + * @mas: the maple state (for the tree) + * @parent: the maple encoded node containing the children. */ static inline void mas_adopt_children(struct ma_state *mas, struct maple_enode *parent) @@ -1687,8 +1686,8 @@ static inline void mas_adopt_children(struct ma_state *mas, /* * mas_put_in_tree() - Put a new node in the tree, smp_wmb(), and mark the old * node as dead. - * @mas - the maple state with the new node - * @old_enode - The old maple encoded node to replace. + * @mas: the maple state with the new node + * @old_enode: The old maple encoded node to replace. */ static inline void mas_put_in_tree(struct ma_state *mas, struct maple_enode *old_enode) @@ -1716,8 +1715,8 @@ static inline void mas_put_in_tree(struct ma_state *mas, * mas_replace_node() - Replace a node by putting it in the tree, marking it * dead, and freeing it. * the parent encoding to locate the maple node in the tree. - * @mas - the ma_state with @mas->node pointing to the new node. - * @old_enode - The old maple encoded node. + * @mas: the ma_state with @mas->node pointing to the new node. + * @old_enode: The old maple encoded node. */ static inline void mas_replace_node(struct ma_state *mas, struct maple_enode *old_enode) @@ -1782,7 +1781,6 @@ static inline void mab_shift_right(struct maple_big_node *b_node, /* * mab_middle_node() - Check if a middle node is needed (unlikely) * @b_node: the maple_big_node that contains the data. - * @size: the amount of data in the b_node * @split: the potential split location * @slot_count: the size that can be stored in a single node being considered. * @@ -1830,6 +1828,7 @@ static inline int mab_no_null_split(struct maple_big_node *b_node, /* * mab_calc_split() - Calculate the split location and if there needs to be two * splits. + * @mas: The maple state * @bn: The maple_big_node with the data * @mid_split: The second split, if required. 0 otherwise. * @@ -2156,7 +2155,8 @@ static inline bool mas_next_sibling(struct ma_state *mas) } /* - * mte_node_or_none() - Set the enode and state. + * mas_node_or_none() - Set the enode and state. + * @mas: the maple state * @enode: The encoded maple node. * * Set the node to the enode and the status. @@ -2207,7 +2207,6 @@ static inline void mas_wr_node_walk(struct ma_wr_state *wr_mas) /* * mast_rebalance_next() - Rebalance against the next node * @mast: The maple subtree state - * @old_r: The encoded maple node to the right (next node). */ static inline void mast_rebalance_next(struct maple_subtree_state *mast) { @@ -2221,7 +2220,6 @@ static inline void mast_rebalance_next(struct maple_subtree_state *mast) /* * mast_rebalance_prev() - Rebalance against the previous node * @mast: The maple subtree state - * @old_l: The encoded maple node to the left (previous node) */ static inline void mast_rebalance_prev(struct maple_subtree_state *mast) { @@ -2372,9 +2370,9 @@ static inline unsigned char mas_mab_to_node(struct ma_state *mas, /* * mab_set_b_end() - Add entry to b_node at b_node->b_end and increment the end * pointer. - * @b_node - the big node to add the entry - * @mas - the maple state to get the pivot (mas->max) - * @entry - the entry to add, if NULL nothing happens. + * @b_node: the big node to add the entry + * @mas: the maple state to get the pivot (mas->max) + * @entry: the entry to add, if NULL nothing happens. */ static inline void mab_set_b_end(struct maple_big_node *b_node, struct ma_state *mas, @@ -2393,11 +2391,11 @@ static inline void mab_set_b_end(struct maple_big_node *b_node, * mas_set_split_parent() - combine_then_separate helper function. Sets the parent * of @mas->node to either @left or @right, depending on @slot and @split * - * @mas - the maple state with the node that needs a parent - * @left - possible parent 1 - * @right - possible parent 2 - * @slot - the slot the mas->node was placed - * @split - the split location between @left and @right + * @mas: the maple state with the node that needs a parent + * @left: possible parent 1 + * @right: possible parent 2 + * @slot: the slot the mas->node was placed + * @split: the split location between @left and @right */ static inline void mas_set_split_parent(struct ma_state *mas, struct maple_enode *left, @@ -2417,11 +2415,11 @@ static inline void mas_set_split_parent(struct ma_state *mas, /* * mte_mid_split_check() - Check if the next node passes the mid-split - * @**l: Pointer to left encoded maple node. - * @**m: Pointer to middle encoded maple node. - * @**r: Pointer to right encoded maple node. + * @l: Pointer to left encoded maple node. + * @m: Pointer to middle encoded maple node. + * @r: Pointer to right encoded maple node. * @slot: The offset - * @*split: The split location. + * @split: The split location. * @mid_split: The middle split. */ static inline void mte_mid_split_check(struct maple_enode **l, @@ -2445,10 +2443,10 @@ static inline void mte_mid_split_check(struct maple_enode **l, /* * mast_set_split_parents() - Helper function to set three nodes parents. Slot * is taken from @mast->l. - * @mast - the maple subtree state - * @left - the left node - * @right - the right node - * @split - the split location. + * @mast: the maple subtree state + * @left: the left node + * @right: the right node + * @split: the split location. */ static inline void mast_set_split_parents(struct maple_subtree_state *mast, struct maple_enode *left, @@ -2482,7 +2480,6 @@ static inline void mast_set_split_parents(struct maple_subtree_state *mast, /* * mas_topiary_node() - Dispose of a single node * @mas: The maple state for pushing nodes - * @enode: The encoded maple node * @in_rcu: If the tree is in rcu mode * * The node will either be RCU freed or pushed back on the maple state. @@ -2614,7 +2611,7 @@ static inline void mas_topiary_replace(struct ma_state *mas, /* * mas_wmb_replace() - Write memory barrier and replace * @mas: The maple state - * @old: The old maple encoded node that is being replaced. + * @old_enode: The old maple encoded node that is being replaced. * * Updates gap as necessary. */ @@ -3505,10 +3502,7 @@ static inline void mas_store_root(struct ma_state *mas, void *entry) /* * mas_is_span_wr() - Check if the write needs to be treated as a write that * spans the node. - * @mas: The maple state - * @piv: The pivot value being written - * @type: The maple node type - * @entry: The data to write + * @wr_mas: The maple write state * * Spanning writes are writes that start in one node and end in another OR if * the write of a %NULL will cause the node to end with a %NULL. @@ -4173,10 +4167,7 @@ static inline void mas_wr_modify(struct ma_wr_state *wr_mas) /* * mas_wr_store_entry() - Internal call to store a value - * @mas: The maple state - * @entry: The entry to store. - * - * Return: The contents that was stored at the index. + * @wr_mas: The maple write state */ static inline void mas_wr_store_entry(struct ma_wr_state *wr_mas) { @@ -4415,9 +4406,8 @@ static int mas_prev_node(struct ma_state *mas, unsigned long min) * mas_prev_slot() - Get the entry in the previous slot * * @mas: The maple state - * @max: The minimum starting range + * @min: The minimum starting range * @empty: Can be empty - * @set_underflow: Set the @mas->node to underflow state on limit. * * Return: The entry in the previous slot which is possibly NULL */ @@ -4500,6 +4490,7 @@ static void *mas_prev_slot(struct ma_state *mas, unsigned long min, bool empty) /* * mas_next_node() - Get the next node at the same level in the tree. * @mas: The maple state + * @node: The maple node * @max: The maximum pivot value to check. * * The next value will be mas->node[mas->offset] or the status will have @@ -4590,8 +4581,6 @@ static int mas_next_node(struct ma_state *mas, struct maple_node *node, * @mas: The maple state * @max: The maximum starting range * @empty: Can be empty - * @set_overflow: Should @mas->node be set to overflow when the limit is - * reached. * * Return: The entry in the next slot which is possibly NULL */ @@ -5125,9 +5114,9 @@ EXPORT_SYMBOL_GPL(mas_empty_area_rev); /* * mte_dead_leaves() - Mark all leaves of a node as dead. - * @mas: The maple state + * @enode: the encoded node + * @mt: the maple tree * @slots: Pointer to the slot array - * @type: The maple node type * * Must hold the write lock. *