From patchwork Tue Sep 3 12:31:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tang Bin X-Patchwork-Id: 13788643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D79CCD3420 for ; Tue, 3 Sep 2024 12:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=GHEoScZF8S/j9jUjNfU0PDFLUR0xitGOh3TxFw6WR0c=; b=kgT6TKJpI4rnGnAUF+Djn/BSc9 P3hS2k+zxUlECddPiz7XFefxnuiQbhbKNN5yI579vhrrI6a1M77IVqdgSNcorf8S5JXkL7orq+se/ dmo+qZl0FVRSWoyX+YGOVf5ehTF8iYEYiY0NH2hnwV6HMALKij/AeYt+GTb9toQA0WODDIdU9GP47 6bVHzyQw8h8yPA1DmTX73+dUNcxA91RksQaJBuFFWwTP6i4iwqvTD6kL+bKA7p8jrG2IuYqwPe1Dk f/szhRO4JDG5LFpb80nsDHEBqNaysMsHPXWOSLaFZLk2RXSq7B4PD7Ra4pFyga1TO67BzIdXoFYD5 2KcPGXWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slSid-00000000AwK-2Llv; Tue, 03 Sep 2024 12:33:11 +0000 Received: from cmccmta6.chinamobile.com ([111.22.67.139] helo=cmccmta3.chinamobile.com) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slShg-00000000AkO-0RqI for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 12:32:14 +0000 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from spf.mail.chinamobile.com (unknown[10.188.0.87]) by rmmx-syy-dmz-app09-12009 (RichMail) with SMTP id 2ee966d701c3078-e307c; Tue, 03 Sep 2024 20:32:04 +0800 (CST) X-RM-TRANSID: 2ee966d701c3078-e307c X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.108.79.97]) by rmsmtp-syy-appsvr10-12010 (RichMail) with SMTP id 2eea66d701c1cbf-e51bd; Tue, 03 Sep 2024 20:32:04 +0800 (CST) X-RM-TRANSID: 2eea66d701c1cbf-e51bd From: tangbin To: neal_liu@aspeedtech.com, gregkh@linuxfoundation.org, joel@jms.id.au, andrew@codeconstruct.com.au Cc: linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tangbin Subject: [PATCH] usb: gadget: aspeed_udc: use the defined variable to simplify code Date: Tue, 3 Sep 2024 20:31:52 +0800 Message-Id: <20240903123152.6980-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_053212_725050_435266EB X-CRM114-Status: GOOD ( 10.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the defined variable 'dev' to make the code cleaner. Signed-off-by: tangbin --- drivers/usb/gadget/udc/aspeed_udc.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c index f4781e611..702d4806c 100644 --- a/drivers/usb/gadget/udc/aspeed_udc.c +++ b/drivers/usb/gadget/udc/aspeed_udc.c @@ -1479,7 +1479,7 @@ static int ast_udc_probe(struct platform_device *pdev) struct ast_udc_dev *udc; int rc; - udc = devm_kzalloc(&pdev->dev, sizeof(struct ast_udc_dev), GFP_KERNEL); + udc = devm_kzalloc(dev, sizeof(struct ast_udc_dev), GFP_KERNEL); if (!udc) return -ENOMEM; @@ -1494,32 +1494,32 @@ static int ast_udc_probe(struct platform_device *pdev) udc->reg = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(udc->reg)) { - dev_err(&pdev->dev, "Failed to map resources\n"); + dev_err(dev, "Failed to map resources\n"); return PTR_ERR(udc->reg); } platform_set_drvdata(pdev, udc); - udc->clk = devm_clk_get(&pdev->dev, NULL); + udc->clk = devm_clk_get(dev, NULL); if (IS_ERR(udc->clk)) { rc = PTR_ERR(udc->clk); goto err; } rc = clk_prepare_enable(udc->clk); if (rc) { - dev_err(&pdev->dev, "Failed to enable clock (0x%x)\n", rc); + dev_err(dev, "Failed to enable clock (0x%x)\n", rc); goto err; } /* Check if we need to limit the HW to USB1 */ - max_speed = usb_get_maximum_speed(&pdev->dev); + max_speed = usb_get_maximum_speed(dev); if (max_speed != USB_SPEED_UNKNOWN && max_speed < USB_SPEED_HIGH) udc->force_usb1 = true; /* * Allocate DMA buffers for all EPs in one chunk */ - udc->ep0_buf = dma_alloc_coherent(&pdev->dev, + udc->ep0_buf = dma_alloc_coherent(dev, AST_UDC_EP_DMA_SIZE * AST_UDC_NUM_ENDPOINTS, &udc->ep0_buf_dma, GFP_KERNEL); @@ -1534,7 +1534,7 @@ static int ast_udc_probe(struct platform_device *pdev) */ udc->desc_mode = AST_UDC_DESC_MODE; - dev_info(&pdev->dev, "DMA %s\n", udc->desc_mode ? + dev_info(dev, "DMA %s\n", udc->desc_mode ? "descriptor mode" : "single mode"); INIT_LIST_HEAD(&udc->gadget.ep_list); @@ -1556,26 +1556,26 @@ static int ast_udc_probe(struct platform_device *pdev) goto err; } - rc = devm_request_irq(&pdev->dev, udc->irq, ast_udc_isr, 0, + rc = devm_request_irq(dev, udc->irq, ast_udc_isr, 0, KBUILD_MODNAME, udc); if (rc) { - dev_err(&pdev->dev, "Failed to request interrupt\n"); + dev_err(dev, "Failed to request interrupt\n"); goto err; } - rc = usb_add_gadget_udc(&pdev->dev, &udc->gadget); + rc = usb_add_gadget_udc(dev, &udc->gadget); if (rc) { - dev_err(&pdev->dev, "Failed to add gadget udc\n"); + dev_err(dev, "Failed to add gadget udc\n"); goto err; } - dev_info(&pdev->dev, "Initialized udc in USB%s mode\n", + dev_info(dev, "Initialized udc in USB%s mode\n", udc->force_usb1 ? "1" : "2"); return 0; err: - dev_err(&pdev->dev, "Failed to udc probe, rc:0x%x\n", rc); + dev_err(dev, "Failed to udc probe, rc:0x%x\n", rc); ast_udc_remove(pdev); return rc;