From patchwork Wed Mar 6 22:55:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 10842357 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2030517E4 for ; Thu, 7 Mar 2019 08:16:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F3482D3E2 for ; Thu, 7 Mar 2019 08:16:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 024AC2D450; Thu, 7 Mar 2019 08:16:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 741252D3E2 for ; Thu, 7 Mar 2019 08:16:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA2C66E25E; Thu, 7 Mar 2019 08:16:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by gabe.freedesktop.org (Postfix) with ESMTPS id 17E586E1CF for ; Wed, 6 Mar 2019 22:57:05 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id z23so10203428lfe.0 for ; Wed, 06 Mar 2019 14:57:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UbUatogV1OYtO8p60xMbel10SeB8vF3N6/iddbJzbnY=; b=FI672O1HrpZVOr6eTPuh8+hi2V9C5AlLnseQ/VNGkBxizf5MjK8BSRt62vUD1fsQPQ 3Umrnms+/Rsy73kHdWecnAMz71ji0Wpl83iuR1OSJTA1Z+j4KcN5mn346+gHNOIn4Jg/ 7CXBthDwBQVI4ELSBoGcqvsxIKV4Y9Fi9WY/HQJZBXTuinItneE+RNe3E9Yo+HDcTsQg sWtkYHF5mJenNxkRfnFY9L65s4pFvPTu1+wN8yDsy/1/SE3TjA16I6ifh69FH4gri03i Dv7gjV0ksf8e36nzwPRr3NVbay0F20eDaqFtOmsrSlVQhvhgvf+5UxZjUJjoFS+id20G zPng== X-Gm-Message-State: APjAAAW8xWIamnB9ffCQ/ISI5V9Z+6Zj/AIMlzw8DVs1iepLI6FkGrAP mqh/IgRVwQnfTq4Wt8L4OtJ9f9qw X-Google-Smtp-Source: APXvYqwRyPoKx9Y4I4Ed2288fN9kjVyt+GmHuVRlsst029M8DomUo2/0aZnxaiacCjGbvHn9xBPOUg== X-Received: by 2002:ac2:51c7:: with SMTP id u7mr5192220lfm.30.1551913023035; Wed, 06 Mar 2019 14:57:03 -0800 (PST) Received: from localhost.localdomain (ppp94-29-37-86.pppoe.spdop.ru. [94.29.37.86]) by smtp.gmail.com with ESMTPSA id a196sm4833lfa.89.2019.03.06.14.57.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 14:57:02 -0800 (PST) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter Subject: [PATCH v1] drm/tegra: gem: Fix CPU-cache maintenance for BO's allocated using get_pages() Date: Thu, 7 Mar 2019 01:55:19 +0300 Message-Id: <20190306225519.4538-1-digetx@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 07 Mar 2019 08:16:24 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UbUatogV1OYtO8p60xMbel10SeB8vF3N6/iddbJzbnY=; b=G3Ahw9/D+GKmLvjDPbIMcmjTuUjQXN5v2QPj4bDHJ/TPC1ajrtO8r7JOCpVnr3MhGa AHbojOME5P6fqFoyhaKFJ8xdNPv3CtR/p4wflquseE0yumSJskf3vORXiLQkIoy9j3vD NnSN1eNxWzcCM7sX3fsWXGV+2zctYToRPM+lpuqVhYDEmwvh4TDoMWjmbOGLjMEo6XzO rUm9X4HH9QadRhoamY6fPT1f8B4z8U3SyRS7G8qOSvMciTK4MFGUoUZJ9OX9KQVwGffX q+EThJLnBiZA7s1c5NZLqgguz05iRaWpR8EhGUiTHf3uJJDS/74JlNUpwKdm3suWGBS7 tKaA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The allocated pages need to be invalidated in CPU caches. On ARM32 the DMA_BIDIRECTIONAL flag only ensures that data is written-back to DRAM and the data stays in CPU cache lines. While the DMA_FROM_DEVICE flag ensures that the corresponding CPU cache lines are getting invalidated and nothing more, that's exactly what is needed for a newly allocated pages. This fixes randomly failing rendercheck tests on Tegra30 using the Opentegra driver for tests that use small-sized pixmaps (10x10 and less, i.e. 1-2 memory pages) because apparently CPU reads out stale data from caches and/or that data is getting evicted to DRAM at the time of HW job execution. Cc: stable Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c index 4f80100ff5f3..4cce11fd8836 100644 --- a/drivers/gpu/drm/tegra/gem.c +++ b/drivers/gpu/drm/tegra/gem.c @@ -204,7 +204,7 @@ static void tegra_bo_free(struct drm_device *drm, struct tegra_bo *bo) { if (bo->pages) { dma_unmap_sg(drm->dev, bo->sgt->sgl, bo->sgt->nents, - DMA_BIDIRECTIONAL); + DMA_FROM_DEVICE); drm_gem_put_pages(&bo->gem, bo->pages, true, true); sg_free_table(bo->sgt); kfree(bo->sgt); @@ -230,7 +230,7 @@ static int tegra_bo_get_pages(struct drm_device *drm, struct tegra_bo *bo) } err = dma_map_sg(drm->dev, bo->sgt->sgl, bo->sgt->nents, - DMA_BIDIRECTIONAL); + DMA_FROM_DEVICE); if (err == 0) { err = -EFAULT; goto free_sgt;