From patchwork Thu Mar 7 15:05:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10843063 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E1E82922 for ; Thu, 7 Mar 2019 15:05:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CFC732F337 for ; Thu, 7 Mar 2019 15:05:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C411B2F343; Thu, 7 Mar 2019 15:05:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9405E2F337 for ; Thu, 7 Mar 2019 15:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726172AbfCGPFk (ORCPT ); Thu, 7 Mar 2019 10:05:40 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:40365 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbfCGPFk (ORCPT ); Thu, 7 Mar 2019 10:05:40 -0500 Received: by mail-wm1-f67.google.com with SMTP id g20so9487049wmh.5 for ; Thu, 07 Mar 2019 07:05:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u2lo2WEDRuEdyIPOfJAVbLGdfhu/OMhY0/4TDFAALgs=; b=dgH89FRD6ZRSfkqe6Sy5UiKDPSlC9lSSGEhxek9+8hymXvtCYgvCVXQgaWcEVOgQp4 U0RnJC9oU7esEpEF28e37NAEjjO0mPQY2XvQt/xeQ9Rin5p7XW8qzY7MWsQmytTO6m2Y 8yoSt1p7snJRwU+/wijNE+MQxs+7rpg0/Q0qJQKgWchYRJSbIQ0wMxp172K3NP9IWdjS eF3tBKtozImeCToDTtq/ObJW9dUlY/mxBDiftIu8+KpbmJm21AWtAdDg09bipAV4RM8w WnCE/F9HJP9VmBwibxFqFwnQe3fpdvEa21ZkCNsNG+jWKIMA+XvUheZ9DOV9C2TjgdXf vkhQ== X-Gm-Message-State: APjAAAVm9VjLr/k6Ra46ewvwZrDviCb7i5PxtU8uAtjwdXeCt4bRPUpV G4DTl6IdtNzWMOJmMwCWX/k0l2JZ/aA= X-Google-Smtp-Source: APXvYqzCROTQEuPyLgTlC+pxsbZzmXxY99diZELMcUTikSACPm/CQ+Fnl3eTITIbv9PR+mrfUBGrZA== X-Received: by 2002:a7b:cf27:: with SMTP id m7mr6018412wmg.80.1551971138429; Thu, 07 Mar 2019 07:05:38 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id d15sm10281274wrw.36.2019.03.07.07.05.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 07:05:38 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 1/4] kernel-shark: Specify the OpenGL interface used by KernelShark Date: Thu, 7 Mar 2019 17:05:08 +0200 Message-Id: <20190307150511.17246-2-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190307150511.17246-1-ykaradzhov@vmware.com> References: <20190307150511.17246-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We instruct CMAKE to prefer using the legacy libGL library, if available. Although this is the default choice, the latest versions of CMAKE are printing a warning message in the case when no explicit preference is provided. Suggested-by: Slavomir Kaslev Signed-off-by: Yordan Karadzhov --- kernel-shark/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel-shark/CMakeLists.txt b/kernel-shark/CMakeLists.txt index 9460026..20ced14 100644 --- a/kernel-shark/CMakeLists.txt +++ b/kernel-shark/CMakeLists.txt @@ -22,6 +22,7 @@ include(${KS_DIR}/build/FindJSONC.cmake) find_package(Doxygen) +set(OpenGL_GL_PREFERENCE LEGACY) find_package(OpenGL) find_package(GLUT) From patchwork Thu Mar 7 15:05:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10843065 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 57D621823 for ; Thu, 7 Mar 2019 15:05:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 41FD22F337 for ; Thu, 7 Mar 2019 15:05:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3640B2F340; Thu, 7 Mar 2019 15:05:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D91332F346 for ; Thu, 7 Mar 2019 15:05:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726234AbfCGPFl (ORCPT ); Thu, 7 Mar 2019 10:05:41 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40376 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbfCGPFl (ORCPT ); Thu, 7 Mar 2019 10:05:41 -0500 Received: by mail-wm1-f68.google.com with SMTP id g20so9487162wmh.5 for ; Thu, 07 Mar 2019 07:05:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ThKcWGp17T1PGZIGkYv9fgJ3BuOcNijCTQQSZYbvuBQ=; b=GHHycF8T44mOkFd7JSmVfbJUxpPEoGTms1x/Pyq9mbvENUKFTOy+o8g4cyGNg/6n/V VIXxY5ECS7PQlVHZrh2S0K0OqXwEW40e6puUHNwyCtKY9yUu6DBB6keFZSPqPFjo5nIS Pls7R37TOFuH7VZDFtdoLHfHlihilRP+GtGCUyPLmcVDIaXLeDasIpOZ8fnezjD7ubZc UysBKuP4bRmjudpcWOF0vrutoQkCTY0odfV3xEcmsXvy0uqNxeqyqY6WYu/0rhe0ny0X btzVpCZxdGVN331hDXkJo0NIPg4wQsbSfFGkOI1jTdOJziYFoTc8fb0OsfrVII//47A+ 5vWA== X-Gm-Message-State: APjAAAVrUVEXG2oakPFXSloWMLhxv4S8G0o9byMfQ6BLXnX2hsr1xmlo 7D8UTUiSfo1nlqOJMHbB5z8= X-Google-Smtp-Source: APXvYqzSjkxds6HixxnbT2jVWjiY8m8/AszlmFBM0TVhwpu9tcxnP68uSTft2NSte1a+H17rFhu3Ng== X-Received: by 2002:a1c:4e19:: with SMTP id g25mr6298701wmh.106.1551971139896; Thu, 07 Mar 2019 07:05:39 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id d15sm10281274wrw.36.2019.03.07.07.05.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 07:05:39 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 2/4] kernel-shark: Fix a bug in ksmodel_zoom Date: Thu, 7 Mar 2019 17:05:09 +0200 Message-Id: <20190307150511.17246-3-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190307150511.17246-1-ykaradzhov@vmware.com> References: <20190307150511.17246-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When zooming-in the model is supposed to avoid over-zooming by recalculation the Scale factor. The new value of the Scale factor is supposed to be such that the size of the bin cannot be smaller than 5 ns. This patch fixes a naive bug in the way the new scale value is calculated. The bug was introduced in f97e31f00 ("kernel-shark-qt: Introduce the visualization model used by the Qt-based KS") but had no effect until 94efea960 ("kernel-shark-qt: Handle the case when the range of the model is too small") because the ridiculous value of the Scale factor resulted in a very small model range and because of this such modification of the model was always rejected. Fixes: f97e31f00 ("kernel-shark-qt: Introduce the visualization model used by the Qt-based KS") Signed-off-by: Yordan Karadzhov --- kernel-shark/src/libkshark-model.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel-shark/src/libkshark-model.c b/kernel-shark/src/libkshark-model.c index 4bd1e2c..7574cbe 100644 --- a/kernel-shark/src/libkshark-model.c +++ b/kernel-shark/src/libkshark-model.c @@ -648,8 +648,8 @@ static void ksmodel_zoom(struct kshark_trace_histo *histo, * Avoid overzooming. If needed, adjust the Scale factor to a the value * which provides bin_size >= 5. */ - if (zoom_in && range * (1 - r) < histo->n_bins * 5) - r = 1 - (histo->n_bins * 5) / range; + if (zoom_in && int (range * (1. - r)) < histo->n_bins * 5) + r = 1. - (histo->n_bins * 5.) / range; /* * Now calculate the new range of the histo. Use the bin of the marker From patchwork Thu Mar 7 15:05:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10843067 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BD7A11575 for ; Thu, 7 Mar 2019 15:05:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ABE282F337 for ; Thu, 7 Mar 2019 15:05:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A07002F343; Thu, 7 Mar 2019 15:05:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B21F2F337 for ; Thu, 7 Mar 2019 15:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbfCGPFn (ORCPT ); Thu, 7 Mar 2019 10:05:43 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:37547 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbfCGPFn (ORCPT ); Thu, 7 Mar 2019 10:05:43 -0500 Received: by mail-wm1-f66.google.com with SMTP id x10so9511226wmg.2 for ; Thu, 07 Mar 2019 07:05:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b88oxwvPmWDVA/FBp3A71q2ZVukyxicVOA5F9lDyxEU=; b=HtHUBA1hXnPci/yaznzCBY8nmC2rKYMrp2lrXWVhfOJCIOeW/odPJE+v+qGA0R4eSc 30mHkh25BU8Xhc0ZohZpFAvwX2ep9uqnKAZJbkQXmTn82z8/5hq30V/byu6F+J0MUnPD Aa/wG5lrIIrOvkNHhKx7VUsDwrvSEa2A73XQUK0R2zaimNYSggmkcXzag/xwOuGSqFGD G1WzT61Lw8DLwIF71bporCQBe2cXkgTP5hiubULRj5KjBTFoTyx1EHri1YIEy+vveJn+ ZnpbQdZDIyFe2/4tCX3mwoInAtMVo/CWGwgtTvnQ6Yb9V5bD0+iCVmKcQFVsjzI/yaDe CDLQ== X-Gm-Message-State: APjAAAW4X9NNriNGQWIchpOUvh3NzFdOvqegSknxpvWHm501wxUz94Yq 8ryTL+VsZdkZZwTWL+Zgr+0= X-Google-Smtp-Source: APXvYqzIyJW1bwdemyRi0PnfhLyT36tH/nM0zDavGv9XAPJgwwzOZtb5PCP8ywUbWW6RKdggSTFJzg== X-Received: by 2002:a1c:9c02:: with SMTP id f2mr5837985wme.91.1551971141151; Thu, 07 Mar 2019 07:05:41 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id d15sm10281274wrw.36.2019.03.07.07.05.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 07:05:40 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 3/4] kernel-shark: Fix Doxygen warning from sched_events Date: Thu, 7 Mar 2019 17:05:10 +0200 Message-Id: <20190307150511.17246-4-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190307150511.17246-1-ykaradzhov@vmware.com> References: <20190307150511.17246-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no reason for find_wakeup_pid being non-static. In the same time, because it is non-static, Doxygen complains about missing documentation for this function. Signed-off-by: Yordan Karadzhov --- kernel-shark/src/plugins/sched_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel-shark/src/plugins/sched_events.c b/kernel-shark/src/plugins/sched_events.c index c52fb29..724aa19 100644 --- a/kernel-shark/src/plugins/sched_events.c +++ b/kernel-shark/src/plugins/sched_events.c @@ -148,7 +148,7 @@ static void plugin_register_command(struct kshark_context *kshark_ctx, tep_register_comm(kshark_ctx->pevent, comm, pid); } -int find_wakeup_pid(struct kshark_context *kshark_ctx, struct kshark_entry *e, +static int find_wakeup_pid(struct kshark_context *kshark_ctx, struct kshark_entry *e, struct tep_event *wakeup_event, struct tep_format_field *pid_field) { struct tep_record *record; From patchwork Thu Mar 7 15:05:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 10843069 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 08DAB1575 for ; Thu, 7 Mar 2019 15:05:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB58D2F337 for ; Thu, 7 Mar 2019 15:05:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DFB1E2F343; Thu, 7 Mar 2019 15:05:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86E0D2F337 for ; Thu, 7 Mar 2019 15:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726127AbfCGPFo (ORCPT ); Thu, 7 Mar 2019 10:05:44 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46124 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbfCGPFo (ORCPT ); Thu, 7 Mar 2019 10:05:44 -0500 Received: by mail-wr1-f66.google.com with SMTP id i16so17798894wrs.13 for ; Thu, 07 Mar 2019 07:05:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NdMzN8MIJtdVLbpS/kta7Rs50VSBU0N/4h520Ka2nEs=; b=dFoeTI6jRpQuv6R8xPl/rvsV1ZdGo+FY2/s3xusAyyEQUE3MRnGtnVEAqpzz6jrHw4 gL9VwKCnfTkfhvMfwpUMD10iSt3aXP+clEnp7dfRZ1Bx7vnfAFOx8qubW3468l2yzQIM mUazyTu6llf6HwqnS2P+MmxAYaJFafL+Gq7Lr8yY/t0iLu2oe1xxdHztMkbTfqB4x+Yu s8HIpMcm8mtG91wqCzi5rQTru8Ib3kmu/qULO7I7IyN3emhcyG6G21MA2tZLwQ6q6t6N aTaTeR6r6FIPH0/DFg0X0ULvwwpcR1CX+NzSQHvWvi/8Me1btcTv9Ap0S6NFiZH2Enmz lhTA== X-Gm-Message-State: APjAAAUkuADuKc+WCP/yWbo4WHDeUfui7XzfXW3yebxJ2mXkUmhnt7wx LBx97K2qlrAF4ipQ+ckpXkEF4cB0dYA= X-Google-Smtp-Source: APXvYqw7w74Q2E0RB8xz8SJ+/qy6tLtB7NiGArjPocqfXyM68cetHXdskwM22gxx2EWNyAMOu+DUzQ== X-Received: by 2002:adf:cd0b:: with SMTP id w11mr2340615wrm.95.1551971142436; Thu, 07 Mar 2019 07:05:42 -0800 (PST) Received: from localhost.localdomain ([95.87.198.56]) by smtp.gmail.com with ESMTPSA id d15sm10281274wrw.36.2019.03.07.07.05.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 07:05:42 -0800 (PST) From: Yordan Karadzhov To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org, Yordan Karadzhov Subject: [PATCH 4/4] kernel-shark: Fix a bug in KsPluginManager Date: Thu, 7 Mar 2019 17:05:11 +0200 Message-Id: <20190307150511.17246-5-ykaradzhov@vmware.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190307150511.17246-1-ykaradzhov@vmware.com> References: <20190307150511.17246-1-ykaradzhov@vmware.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP const char *lib = plugin.toStdString().c_str(); This line is a bad idea because the returned array may (will) be invalidated when the destructor of std::string is called. Fixes: 18cf94f485("kernel-shark-qt: Add KernalShark Utils") Signed-off-by: Yordan Karadzhov --- kernel-shark/src/KsUtils.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel-shark/src/KsUtils.cpp b/kernel-shark/src/KsUtils.cpp index 34b2e2d..d7b1753 100644 --- a/kernel-shark/src/KsUtils.cpp +++ b/kernel-shark/src/KsUtils.cpp @@ -439,7 +439,7 @@ void KsPluginManager::registerFromList(kshark_context *kshark_ctx) auto lamRegUser = [&kshark_ctx](const QString &plugin) { - const char *lib = plugin.toStdString().c_str(); + const char *lib = plugin.toLocal8Bit().data(); kshark_register_plugin(kshark_ctx, lib); }; @@ -474,7 +474,7 @@ void KsPluginManager::unregisterFromList(kshark_context *kshark_ctx) auto lamUregUser = [&kshark_ctx](const QString &plugin) { - const char *lib = plugin.toStdString().c_str(); + const char *lib = plugin.toLocal8Bit().data(); kshark_unregister_plugin(kshark_ctx, lib); };