From patchwork Mon Sep 16 11:58:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 13805353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D1E7C3ABB2 for ; Mon, 16 Sep 2024 11:58:34 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.799445.1209426 (Exim 4.92) (envelope-from ) id 1sqAMz-00024L-N5; Mon, 16 Sep 2024 11:58:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 799445.1209426; Mon, 16 Sep 2024 11:58:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sqAMz-00024E-Jx; Mon, 16 Sep 2024 11:58:17 +0000 Received: by outflank-mailman (input) for mailman id 799445; Mon, 16 Sep 2024 11:58:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sqAMy-000245-KM for xen-devel@lists.xenproject.org; Mon, 16 Sep 2024 11:58:16 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f4a7762e-7422-11ef-a0b6-8be0dac302b0; Mon, 16 Sep 2024 13:58:15 +0200 (CEST) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5c3d209db94so5415251a12.3 for ; Mon, 16 Sep 2024 04:58:15 -0700 (PDT) Received: from andrewcoop.eng.citrite.net ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c42bb89e2asm2500130a12.73.2024.09.16.04.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 04:58:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4a7762e-7422-11ef-a0b6-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1726487894; x=1727092694; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Wgli94T5IvKHrvjdJOUG8o91INAl/rQ7Yqo8UEG2KRo=; b=ppKhakFkYB3u1hrFkjOXmeFehOvg+TdMGmZcTJArVCENMD+WGpaDB4uJJ2w2hZqUnN zr1Jqq1Oxj8fleGUJixH26cPT6fEEenq+IQKk6R/20QmuyuK6p4iotypwmGeuCv61YMf Ko/uqOcM40sSjBWbNmIZx08zCOPZmpNLavNQo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726487894; x=1727092694; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Wgli94T5IvKHrvjdJOUG8o91INAl/rQ7Yqo8UEG2KRo=; b=nEv0/YI973IDhfhi6CEobWaZy77c5IWtKciCYzgoZwSMC/ePQc5QOvvqmUIw5n2Hyy pKkH2yUuJP4Va+rynS1U0NQd+t6sVCedfAXqsdG7wUUWtbGM9lRhc3WX6v2t7yBLFcC3 eNlReJxRt32+HUzaWf3cdTf+OeQor10VVMR8p1lfIRiKBx7XpBiHoxb1gN82PykspzOZ ktYWI7X75f+lYiCiEB+r8SyggwswqCoIK1X/w+mEhp60haBchmB1FsOvGj9jH+vzSndc ezVlXKqk/bnf5dp4sUMfUrbDOzQ8bDI2LH3TqBD6XHSOGhFOlwJvUEDlCbRZzh9CSolD KsHg== X-Gm-Message-State: AOJu0YwyliRM3uJWXU2oPUmYs2jbNQF9Oi4/gBRtH9lZYa14EjJ+0NiW 8QjMFTMSFgb5obkUR5cyWrAHPwGNPCLD2pIgWh1CFcjN8qUYERkZwKOUxcOTcikcdymJMHV/flm b X-Google-Smtp-Source: AGHT+IEiYNbxJR2X7/ijr6rofODyq0phRo8bDyjb7Jc3KymtlRi/GrwhzXz42ovCHoFOjxPwnCFBvQ== X-Received: by 2002:a05:6402:5114:b0:5c4:233a:4d3 with SMTP id 4fb4d7f45d1cf-5c4233a07f9mr8886419a12.5.1726487893695; Mon, 16 Sep 2024 04:58:13 -0700 (PDT) From: Andrew Cooper To: Xen-devel Cc: Andrew Cooper , Jan Beulich , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Frediano Ziglio Subject: [PATCH] x86/boot: Drop stale comment about zeroing the stack Date: Mon, 16 Sep 2024 12:58:11 +0100 Message-Id: <20240916115811.2076392-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 This used to be true, but was altered by commit 37786b23b027 ("x86/cet: Remove writeable mapping of the BSPs shadow stack") which moved cpu0_stack into .init.bss.stack_aligned. Fixes: 37786b23b027 ("x86/cet: Remove writeable mapping of the BSPs shadow stack") Signed-off-by: Andrew Cooper Acked-by: Frediano Ziglio Acked-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Frediano Ziglio --- xen/arch/x86/boot/head.S | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) base-commit: a8bf14f6f331d4f428010b4277b67c33f561ed19 diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 12bbb97f33d4..cfc5a7b47d29 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -652,11 +652,7 @@ trampoline_setup: cmpb $0, sym_esi(efi_platform) jnz 1f - /* - * Initialise the BSS. - * - * !!! WARNING - also zeroes the current stack !!! - */ + /* Initialise the BSS. */ lea sym_esi(__bss_start), %edi lea sym_esi(__bss_end), %ecx sub %edi,%ecx