From patchwork Fri Oct 4 06:15:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nobuhiro Iwamatsu X-Patchwork-Id: 13821803 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C86BACFA74A for ; Fri, 4 Oct 2024 06:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=CiPQ7lESH5Gy691au9mdhveuFFHiiywWJe9zyxWKyzs=; b=Sl9lJUFLj/962BLl66Z+R3rZn6 pdzMzLqFDqUAH5V3HnMn3gVg9olsu0hocOYBmnfVkam62OaKGTjaEvUzkmOCtX0LnIL4SMfczfTQK eIILxKNrneZTNPgb60Q0yVJuzmcAEEQs36jIki63H03CtrROlz/0xiNzkUpKQBGsLtkL9IT8BlNUD cS/fKs4VvQxk0YteXeuH3yUj5EHaF4whwoj8/JiZpBdFhCr3oL+78eiKl6JZwQ4CpbLD5RIM3rTDS /4D3emQHvo1uIV/LiBRbmHNrSP8hggVZVisZAJxG8cQLZNQHEM6OCYbZTJ46oldg0eYB0/GLgYHm6 SA5mWDOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swbd0-0000000B75T-2B0s; Fri, 04 Oct 2024 06:17:26 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swbbf-0000000B6zn-2FkW for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2024 06:16:08 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2e082f2a427so1364371a91.3 for ; Thu, 03 Oct 2024 23:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nigauri-org.20230601.gappssmtp.com; s=20230601; t=1728022562; x=1728627362; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CiPQ7lESH5Gy691au9mdhveuFFHiiywWJe9zyxWKyzs=; b=psPAnoIweeL413yX0wKcZEJQIJbLA9KAJ6qx7Jl3WdRH6jCeIIk5KsiA+tjrmhEVbz xEHKxbQBlLuW7TCn5xCAPRJycWE1960lAUrCA9O93C4at1TAtM8EjAm4F7iSpHERt3lx 0vVeKtTGL8j1/vCEfLKToz5YS7kl0YingdEa1yh7MCMUZGlCgzetWAxIGwvt5MOPqLew MM/z5jSI2P3TIwv1Mb7RCT0woix7iwxGBAV6JWLuoUKeKGap7FDihP4CDsPHfFFHAm5S aImqtfsIkc/OoXEQ9wrm3pL4kxQKZOCOWDzZtJlHwLp/TU1x1031O8FEg+2nL75naXZx 5ipg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728022562; x=1728627362; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CiPQ7lESH5Gy691au9mdhveuFFHiiywWJe9zyxWKyzs=; b=YnqihB4ustPrtYcveMSEiuqe4d9IQcuHpyYLCenJqIa5HHPOs5bgviWsDObQfqL5Ne TdqufOsxK4LEDqYXysNnwgysK5g8a099VSoGTxWLZ7B3mteDY5XzitQ6i7WUsncOg9Th nIBdl37T73VbXc/mpQUKv1+DvMqCNOq5lHQaG0fT0QvLsiJ3ku5g0QZXcYt8UnkM5T27 4ZVzonA3ld/3x1tk8sWNx0yz/TI/9L5p1ac1VY5P+p8MGWX52PRYh4/n3mdyz5ClUq8f FBkqOsnglAf2eWnx1ZNvqB6S9QuoSDEHMuDkiE5ZxMxMFGdiQyr9ph4MdbNpaz7lVWJW Dxtw== X-Gm-Message-State: AOJu0Yw149v4ngRJN35bRjDv3H3ydEWBRazWk7gPcDSnsG+tiH3p9sNu 7LNFpy+mh8XM92ZjQyo4d09QDCi5OqP5FCew95rmHri8LqRSzoFIiyHyk3GY X-Google-Smtp-Source: AGHT+IHtbGb53QIqfIfaHFTTKzwgD4vmCfhsKiGIH6YMCbaEJi/On/jh5vfbtaP4ptDCa90Hd1a7vw== X-Received: by 2002:a17:90b:4ac7:b0:2e1:cda1:12c6 with SMTP id 98e67ed59e1d1-2e1e63c58c8mr1636571a91.40.1728022561835; Thu, 03 Oct 2024 23:16:01 -0700 (PDT) Received: from localhost ([2405:6581:5360:1800:97a9:b968:cde4:c75e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e1e862328csm672661a91.44.2024.10.03.23.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 23:16:01 -0700 (PDT) From: Nobuhiro Iwamatsu X-Google-Original-From: Nobuhiro Iwamatsu To: robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dinguyen@kernel.org Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Nobuhiro Iwamatsu , stable@vger.kernel.org Subject: [PATCH] ARM: dts: socfpga: sodia: Fix mdio bus probe and PHY ID Date: Fri, 4 Oct 2024 15:15:41 +0900 Message-ID: <20241004061541.1666280-1-nobuhiro1.iwamatsu@toshiba.co.jp> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241003_231603_869309_822732FC X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nobuhiro Iwamatsu On SoCFPGA/Sodia board, mdio bus cannot be probed, so the PHY cannot be found and the network device does not work. ``` stmmaceth ff702000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19) ``` To probe the mdio bus, add "snps,dwmac-mdio" as compatible string of the mdio bus. Also the PHY ID connected to this board is 4. Therefore, change to 4. Fixes: 8fbc10b995a5 ("net: stmmac: check fwnode for phy device before scanning for phy") Cc: stable@vger.kernel.org # 6.3+ Signed-off-by: Nobuhiro Iwamatsu --- arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts index ce0d6514eeb571..e4794ccb8e413f 100644 --- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts +++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_sodia.dts @@ -66,8 +66,10 @@ &gmac1 { mdio0 { #address-cells = <1>; #size-cells = <0>; - phy0: ethernet-phy@0 { - reg = <0>; + compatible = "snps,dwmac-mdio"; + + phy0: ethernet-phy@4 { + reg = <4>; rxd0-skew-ps = <0>; rxd1-skew-ps = <0>; rxd2-skew-ps = <0>;