From patchwork Mon Oct 7 19:32:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Stark X-Patchwork-Id: 13825230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72BB6CFB456 for ; Mon, 7 Oct 2024 19:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xOckyWlx3vfGFI8gSU4IjntaqtjFggaI/dlsC8fZYpo=; b=cz3nyV8DZk7SDLzVQPgEEgOu1m 9IUPSRCHFJ7xxC1fcr26fQJISL6mcue5g2aBjZUV8+235al4ZUnabC/2R2GPqaXnrgKDxQ+MMcO2P GpzlcDT8/y/FG0GdSd2B9C2OUhsYXt6oww1iHIwINWGz9se3PcboFap1DjfDnLn1VIGrTGJ956oZz S6D/iYpaSs4rrCV4tikHV1aWUIjbA0zt2PSXmso3uoNAB7I9S014iQ6MeFqEaZ5B6CIe4DKbvWd3V Och6Qb884ltEo2YxGiYoHgV2hbqd+4uUEjYDwSlv4V1mMcMu7wUwHzir3+zxrYzLdF0I1sVhqvC3M MKNML4gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxtY2-00000003dO5-2gGc; Mon, 07 Oct 2024 19:37:38 +0000 Received: from mx2.sberdevices.ru ([45.89.224.132] helo=mx1.sberdevices.ru) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxtSt-00000003cTP-1SA3; Mon, 07 Oct 2024 19:32:27 +0000 Received: from p-infra-ksmg-sc-msk02.sberdevices.ru (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 66CFB120011; Mon, 7 Oct 2024 22:32:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 66CFB120011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1728329531; bh=xOckyWlx3vfGFI8gSU4IjntaqtjFggaI/dlsC8fZYpo=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=kBcuh6tw/ljgY6WKuadYzahlegMbUQpFsrHDYHAZR5pe1luhrLm1wKPRgDxPGEkR8 Vju4e4SUbTgzannQvSkrjA6eOkzFuSh4Z1y9rebep2BGy7GsoZvqz9Jfutk5Qs71Ts z7vylzWUDZiraYRDtBb7sPB8Fdu/TYZsHZV7ChQNLn79kQE9y3tJCXZkYfSX0M6lJo 3UADjt6mXPwqHkeklptHERWq2IqpQ2Ljm9utS6NjyN7fskVn1anDJg0Awdcu7omaxB dy6tanu6XO9GPwyRAfd24LteN9CpWwMJL8wXFEY4/8gpno2a1Fr4iJ+5P+wPQYDigU +ZEPlX/7ii6eg== Received: from smtp.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Mon, 7 Oct 2024 22:32:11 +0300 (MSK) From: George Stark To: , , , , CC: , , , , , George Stark Subject: [PATCH 1/3] pwm: meson: Support constant and polarity bits Date: Mon, 7 Oct 2024 22:32:01 +0300 Message-ID: <20241007193203.1753326-2-gnstark@salutedevices.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241007193203.1753326-1-gnstark@salutedevices.com> References: <20241007193203.1753326-1-gnstark@salutedevices.com> MIME-Version: 1.0 X-Originating-IP: [172.28.192.106] X-ClientProxiedBy: p-i-exch-a-m2.sberdevices.ru (172.24.196.120) To p-i-exch-a-m1.sberdevices.ru (172.24.196.116) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 188276 [Oct 07 2024] X-KSMG-AntiSpam-Version: 6.1.0.4 X-KSMG-AntiSpam-Envelope-From: gnstark@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 39 0.3.39 e168d0b3ce73b485ab2648dd465313add1404cce, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;smtp.sberdevices.ru:5.0.1,7.1.1;salutedevices.com:7.1.1, FromAlignment: s X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/10/07 17:50:00 #26714324 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_123219_927232_43E74AE0 X-CRM114-Status: GOOD ( 22.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Newer meson PWM IPs support constant and polarity bits. Support them to correctly implement constant and inverted output levels. Using constant bit allows to have truly stable low or high output level. Since hi and low regs internally increment its values by 1 just writing zero to any of them gives 1 clock count impulse. If constant bit is set zero value in hi and low regs is not incremented. Using polarity bit instead of swapping hi and low reg values allows to correctly identify inversion in .get_state(). Signed-off-by: George Stark --- drivers/pwm/pwm-meson.c | 75 +++++++++++++++++++++++++++++++++++++---- 1 file changed, 69 insertions(+), 6 deletions(-) -- 2.25.1 diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 98e6c1533312..5d51404bdce3 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -6,7 +6,7 @@ * PWM output is achieved by calculating a clock that permits calculating * two periods (low and high). The counter then has to be set to switch after * N cycles for the first half period. - * The hardware has no "polarity" setting. This driver reverses the period + * Partly the hardware has no "polarity" setting. This driver reverses the period * cycles (the low length is inverted with the high length) for * PWM_POLARITY_INVERSED. This means that .get_state cannot read the polarity * from the hardware. @@ -56,6 +56,10 @@ #define MISC_B_CLK_SEL_SHIFT 6 #define MISC_A_CLK_SEL_SHIFT 4 #define MISC_CLK_SEL_MASK 0x3 +#define MISC_B_CONSTANT_EN BIT(29) +#define MISC_A_CONSTANT_EN BIT(28) +#define MISC_B_INVERT_EN BIT(27) +#define MISC_A_INVERT_EN BIT(26) #define MISC_B_EN BIT(1) #define MISC_A_EN BIT(0) @@ -68,6 +72,8 @@ static struct meson_pwm_channel_data { u8 clk_div_shift; u8 clk_en_shift; u32 pwm_en_mask; + u32 const_en_mask; + u32 inv_en_mask; } meson_pwm_per_channel_data[MESON_NUM_PWMS] = { { .reg_offset = REG_PWM_A, @@ -75,6 +81,8 @@ static struct meson_pwm_channel_data { .clk_div_shift = MISC_A_CLK_DIV_SHIFT, .clk_en_shift = MISC_A_CLK_EN_SHIFT, .pwm_en_mask = MISC_A_EN, + .const_en_mask = MISC_A_CONSTANT_EN, + .inv_en_mask = MISC_A_INVERT_EN, }, { .reg_offset = REG_PWM_B, @@ -82,6 +90,8 @@ static struct meson_pwm_channel_data { .clk_div_shift = MISC_B_CLK_DIV_SHIFT, .clk_en_shift = MISC_B_CLK_EN_SHIFT, .pwm_en_mask = MISC_B_EN, + .const_en_mask = MISC_B_CONSTANT_EN, + .inv_en_mask = MISC_B_INVERT_EN, } }; @@ -99,6 +109,8 @@ struct meson_pwm_channel { struct meson_pwm_data { const char *const parent_names[MESON_NUM_MUX_PARENTS]; int (*channels_init)(struct pwm_chip *chip); + bool has_constant; + bool has_polarity; }; struct meson_pwm { @@ -160,7 +172,7 @@ static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, * Fixing this needs some care however as some machines might rely on * this. */ - if (state->polarity == PWM_POLARITY_INVERSED) + if (state->polarity == PWM_POLARITY_INVERSED && !meson->data->has_polarity) duty = period - duty; freq = div64_u64(NSEC_PER_SEC * 0xffffULL, period); @@ -204,6 +216,46 @@ static int meson_pwm_calc(struct pwm_chip *chip, struct pwm_device *pwm, return 0; } +static void meson_pwm_set_polarity(struct pwm_chip *chip, struct pwm_device *pwm, + bool inverted) +{ + struct meson_pwm *meson = to_meson_pwm(chip); + const struct meson_pwm_channel_data *channel_data; + unsigned long flags; + u32 value; + + channel_data = &meson_pwm_per_channel_data[pwm->hwpwm]; + + spin_lock_irqsave(&meson->lock, flags); + value = readl(meson->base + REG_MISC_AB); + if (inverted) + value |= channel_data->inv_en_mask; + else + value &= ~channel_data->inv_en_mask; + writel(value, meson->base + REG_MISC_AB); + spin_unlock_irqrestore(&meson->lock, flags); +} + +static void meson_pwm_set_constant(struct pwm_chip *chip, struct pwm_device *pwm, + bool enable) +{ + struct meson_pwm *meson = to_meson_pwm(chip); + const struct meson_pwm_channel_data *channel_data; + unsigned long flags; + u32 value; + + channel_data = &meson_pwm_per_channel_data[pwm->hwpwm]; + + spin_lock_irqsave(&meson->lock, flags); + value = readl(meson->base + REG_MISC_AB); + if (enable) + value |= channel_data->const_en_mask; + else + value &= ~channel_data->const_en_mask; + writel(value, meson->base + REG_MISC_AB); + spin_unlock_irqrestore(&meson->lock, flags); +} + static void meson_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) { struct meson_pwm *meson = to_meson_pwm(chip); @@ -255,9 +307,9 @@ static int meson_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, int err = 0; if (!state->enabled) { - if (state->polarity == PWM_POLARITY_INVERSED) { + if (state->polarity == PWM_POLARITY_INVERSED && !meson->data->has_polarity) { /* - * This IP block revision doesn't have an "always high" + * Some of IP block revisions don't have an "always high" * setting which we can use for "inverted disabled". * Instead we achieve this by setting mux parent with * highest rate and minimum divider value, resulting @@ -284,6 +336,14 @@ static int meson_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, meson_pwm_enable(chip, pwm); } + if (meson->data->has_constant) + meson_pwm_set_constant(chip, pwm, + state->duty_cycle == state->period || + !state->duty_cycle); + if (meson->data->has_polarity) + meson_pwm_set_polarity(chip, pwm, + !(state->polarity == PWM_POLARITY_NORMAL)); + return 0; } @@ -318,6 +378,11 @@ static int meson_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, value = readl(meson->base + REG_MISC_AB); state->enabled = value & channel_data->pwm_en_mask; + if (meson->data->has_polarity && (value & channel_data->inv_en_mask)) + state->polarity = PWM_POLARITY_INVERSED; + else + state->polarity = PWM_POLARITY_NORMAL; + value = readl(meson->base + channel_data->reg_offset); channel->lo = FIELD_GET(PWM_LOW_MASK, value); channel->hi = FIELD_GET(PWM_HIGH_MASK, value); @@ -325,8 +390,6 @@ static int meson_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm, state->period = meson_pwm_cnt_to_ns(chip, pwm, channel->lo + channel->hi); state->duty_cycle = meson_pwm_cnt_to_ns(chip, pwm, channel->hi); - state->polarity = PWM_POLARITY_NORMAL; - return 0; } From patchwork Mon Oct 7 19:32:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Stark X-Patchwork-Id: 13825229 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CADFACFB456 for ; Mon, 7 Oct 2024 19:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h07xMRo79t9BDqK2U7E8zsHG7AI21nJZGqYv+D883f8=; b=wvLTYYZP8zW11514Yg3VeyASiS vBoxZ0LfmNVBdxLOtFu8RlRka9UYs2nJufKKjoHeBWCfLbBoSHN4yDES6GF8bvc7HE7SFNhmKs610 XVBNu5iS1obUl/hb+x3e6oadTaUk8E4AJs0tq6+g0Z8C1Lia1duoCgDOkCJ/FGF1jD0tqF8gJXUlZ 6iLgZkdSRMbFBc+owNFLqVTQWYHU4qq0P/1Kbr+Y9beEUwxuVMDZMdWlbB5uDnif/r5V1CLVSZyW2 mgH6mO42MNdIfUQIIoCB36PHiPR1UTug96KntuSUTYGLaUUonsBkddZNwFw6GplRM5HvpYsmn/ch2 uQcO15ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxtWm-00000003d92-1Eze; Mon, 07 Oct 2024 19:36:20 +0000 Received: from mx2.sberdevices.ru ([45.89.224.132] helo=mx1.sberdevices.ru) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxtSt-00000003cTO-1UlJ; Mon, 07 Oct 2024 19:32:27 +0000 Received: from p-infra-ksmg-sc-msk02.sberdevices.ru (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id B0EDE120012; Mon, 7 Oct 2024 22:32:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru B0EDE120012 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1728329531; bh=h07xMRo79t9BDqK2U7E8zsHG7AI21nJZGqYv+D883f8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=Up/f+KOU0JMgy+NoT01VK0xEX8f4CYJJG46N8jslqlXinJ/s52lxJpvS6dGcmgmvw xWcXHjW3PsdDEwq3UpISlz14a/xfu7o3/W2y9AeihE9RKYnXlw7Gb5HBISxtUMWDuI 2WZ9xkkzZtGxyHHbLYCDNE/agtRzjxIaEUEOacoiU/ulPC0Bp+iWP2qwp2ZgP+z77u 9UZHTz6YYlgWi/wAZdzfb/j3wHzU931Xggfxe205Z5ql/KfzKMZ9SDQGPAHFYiAVau 987wPq3MadREpxRi7jvPtwx3N1+EhCVXE0qOvFi9HAmYTtJ3HwlNRXMy3O77I8VtOc n9TP+5UKyQadw== Received: from smtp.sberdevices.ru (p-i-exch-sc-m02.sberdevices.ru [172.16.192.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Mon, 7 Oct 2024 22:32:11 +0300 (MSK) From: George Stark To: , , , , CC: , , , , , George Stark Subject: [PATCH 2/3] pwm: meson: Use separate chip data struct for g12a-ee-pwm Date: Mon, 7 Oct 2024 22:32:02 +0300 Message-ID: <20241007193203.1753326-3-gnstark@salutedevices.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241007193203.1753326-1-gnstark@salutedevices.com> References: <20241007193203.1753326-1-gnstark@salutedevices.com> MIME-Version: 1.0 X-Originating-IP: [172.28.192.106] X-ClientProxiedBy: p-i-exch-a-m2.sberdevices.ru (172.24.196.120) To p-i-exch-a-m1.sberdevices.ru (172.24.196.116) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 188276 [Oct 07 2024] X-KSMG-AntiSpam-Version: 6.1.0.4 X-KSMG-AntiSpam-Envelope-From: gnstark@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 39 0.3.39 e168d0b3ce73b485ab2648dd465313add1404cce, {Tracking_from_domain_doesnt_match_to}, 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;smtp.sberdevices.ru:5.0.1,7.1.1;salutedevices.com:7.1.1, FromAlignment: s X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/10/07 17:50:00 #26714324 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_123219_923609_21B9CDE1 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org PWM module of g12a SoC family has different set of features than meson8 so use separate chip data struct for it. Signed-off-by: George Stark Reviewed-by: Neil Armstrong --- drivers/pwm/pwm-meson.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 5d51404bdce3..6701738c55e3 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -578,6 +578,11 @@ static const struct meson_pwm_data pwm_axg_ao_data = { .channels_init = meson_pwm_init_channels_meson8b_legacy, }; +static const struct meson_pwm_data pwm_g12a_ee_data = { + .parent_names = { "xtal", NULL, "fclk_div4", "fclk_div3" }, + .channels_init = meson_pwm_init_channels_meson8b_legacy, +}; + static const struct meson_pwm_data pwm_g12a_ao_ab_data = { .parent_names = { "xtal", "g12a_ao_clk81", "fclk_div4", "fclk_div5" }, .channels_init = meson_pwm_init_channels_meson8b_legacy, @@ -624,7 +629,7 @@ static const struct of_device_id meson_pwm_matches[] = { }, { .compatible = "amlogic,meson-g12a-ee-pwm", - .data = &pwm_meson8b_data + .data = &pwm_g12a_ee_data }, { .compatible = "amlogic,meson-g12a-ao-pwm-ab", From patchwork Mon Oct 7 19:32:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: George Stark X-Patchwork-Id: 13825228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D4BACFB440 for ; Mon, 7 Oct 2024 19:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JJ23VCJzDOZTr2V6x1enTRhokP19rysAyyD6vIuZ+ys=; b=eRxx7eNTUj5NAtxcsfUWFMmR1w ZrvVsMH6opJpwyaLKOY2zYuBU2vKFWhG83ysbWzA4b9EwSvCDZmNWlKR35k52mC7jlTKLSAfAx/VD QEjNoib5EyzztXF0SP8j5Lm+evQrXwjRlvMlmNLKJkOYXHm7pFnJjtZwpPcqa3GuWFMmelPyw7+j1 HWyWL2li8L8LCjfhHrHnhVHv68GRBzJz2oQMFxRegX3hXmmQoGQW3zuM9gWU0qnZ3OArPDSA2crPx UiYyXmklEJ/pXrCfKc+d5+9r3gqZ5W51jpPI+1HCTkkH4dFap1slD/m5dry99q6utt1xn7rQfFiVb RvuCkSXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sxtVV-00000003crS-0CHH; Mon, 07 Oct 2024 19:35:01 +0000 Received: from mx1.sberdevices.ru ([37.18.73.165]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxtSt-00000003cTQ-1TAF; Mon, 07 Oct 2024 19:32:24 +0000 Received: from p-infra-ksmg-sc-msk01.sberdevices.ru (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id EA44810000C; Mon, 7 Oct 2024 22:32:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru EA44810000C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1728329531; bh=JJ23VCJzDOZTr2V6x1enTRhokP19rysAyyD6vIuZ+ys=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=gdmlOQcn/wWaHGlTSWkXrGCI2dhv99T3tV30ubn9XEDCXSo3c4fGmOtut4td3n5P9 /U8tp92h5fxr3nmgpNMVGGd61MCP3cD5LWWXyhspyQZDKJg8FtT78xXxWLS9zpjjBa dk+ARcrsmFswgHuJL5GWCbZp701xPkFq7iQWsq/GiIuE8lK0lz5O+24l7bAjNTnQA1 /iqcJ7bW2eVf8WQcGuU5Kt4JG3nAV9xlSM882lWZU7UitBw2ogLBwSsf5LtQ1Elqkw xfDLwBy6h7/oNM0uVUbRG44FxW8BiUO3ALNs76UQy0I1IE//79QkwfSufvhn/hCY0V jGyoQql3XW+sA== Received: from smtp.sberdevices.ru (unknown [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Mon, 7 Oct 2024 22:32:11 +0300 (MSK) From: George Stark To: , , , , CC: , , , , , George Stark Subject: [PATCH 3/3] pwm: meson: Enable constant and polarity features for g12, axg, s4 Date: Mon, 7 Oct 2024 22:32:03 +0300 Message-ID: <20241007193203.1753326-4-gnstark@salutedevices.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241007193203.1753326-1-gnstark@salutedevices.com> References: <20241007193203.1753326-1-gnstark@salutedevices.com> MIME-Version: 1.0 X-Originating-IP: [172.28.192.106] X-ClientProxiedBy: p-i-exch-a-m2.sberdevices.ru (172.24.196.120) To p-i-exch-a-m1.sberdevices.ru (172.24.196.116) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 188277 [Oct 07 2024] X-KSMG-AntiSpam-Version: 6.1.0.4 X-KSMG-AntiSpam-Envelope-From: gnstark@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 39 0.3.39 e168d0b3ce73b485ab2648dd465313add1404cce, {Tracking_from_domain_doesnt_match_to}, salutedevices.com:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;smtp.sberdevices.ru:5.0.1,7.1.1, FromAlignment: s X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/10/07 17:50:00 #26714324 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_123219_923351_908716D4 X-CRM114-Status: UNSURE ( 9.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org g12, axg and s4 SoC families support constant and polarity bits so enable those features in corresponding chip data structs. Signed-off-by: George Stark Reviewed-by: Neil Armstrong --- drivers/pwm/pwm-meson.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 6701738c55e3..c6f032bdfe78 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -571,26 +571,36 @@ static const struct meson_pwm_data pwm_gxbb_ao_data = { static const struct meson_pwm_data pwm_axg_ee_data = { .parent_names = { "xtal", "fclk_div5", "fclk_div4", "fclk_div3" }, .channels_init = meson_pwm_init_channels_meson8b_legacy, + .has_constant = true, + .has_polarity = true, }; static const struct meson_pwm_data pwm_axg_ao_data = { .parent_names = { "xtal", "axg_ao_clk81", "fclk_div4", "fclk_div5" }, .channels_init = meson_pwm_init_channels_meson8b_legacy, + .has_constant = true, + .has_polarity = true, }; static const struct meson_pwm_data pwm_g12a_ee_data = { .parent_names = { "xtal", NULL, "fclk_div4", "fclk_div3" }, .channels_init = meson_pwm_init_channels_meson8b_legacy, + .has_constant = true, + .has_polarity = true, }; static const struct meson_pwm_data pwm_g12a_ao_ab_data = { .parent_names = { "xtal", "g12a_ao_clk81", "fclk_div4", "fclk_div5" }, .channels_init = meson_pwm_init_channels_meson8b_legacy, + .has_constant = true, + .has_polarity = true, }; static const struct meson_pwm_data pwm_g12a_ao_cd_data = { .parent_names = { "xtal", "g12a_ao_clk81", NULL, NULL }, .channels_init = meson_pwm_init_channels_meson8b_legacy, + .has_constant = true, + .has_polarity = true, }; static const struct meson_pwm_data pwm_meson8_v2_data = { @@ -599,6 +609,8 @@ static const struct meson_pwm_data pwm_meson8_v2_data = { static const struct meson_pwm_data pwm_s4_data = { .channels_init = meson_pwm_init_channels_s4, + .has_constant = true, + .has_polarity = true, }; static const struct of_device_id meson_pwm_matches[] = {