From patchwork Tue Oct 8 09:13:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkata Prasad Potturu X-Patchwork-Id: 13826076 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2069.outbound.protection.outlook.com [40.107.236.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B69013AA4E; Tue, 8 Oct 2024 09:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378841; cv=fail; b=AClYnGHqcYLY3wqKZf6zxZGdra/tGrRAp8ZKWza8ri25yH62y9CgF8DGBEtB2jEQ10u9JhX5X2Z4fBoUPjo7CWbylc6i8Ei54AuEY0TSEGDYgxaVgA6/2cpJ7rCEMRMBrqhaXNy91+bmvrCFqaOqNJeQK7BCt3ch+5WFEZ0Ta2o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378841; c=relaxed/simple; bh=Y4415IW4b47NOHa94W5QgQujaXNkCHHhhhHysWGYUSg=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=YKWoCDHHofvf1to0M6oOFbU+bHN37K0wouKeyrTu2M2CvwXwdavvJVmCnC0mJOaS8lrRHVWEGQCtb+qXvAGK/U4Zbbv+q3EX+NdVZDyc2J4vXTs9Vv86hzvmPRIYRnq8JKWcq3GPJkBu4LUXG3J1o6P+03jZAW9cGXHAQOLmHVc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=fTvZpkPF; arc=fail smtp.client-ip=40.107.236.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="fTvZpkPF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I4K6CDSzTr5aR9eWtOKNGeubKx6epZ9USBmZXNuXe9lIbDdtZ1lhJz639JXNIo+4JCdqS+8V+v9wIkKfI91bU+xinr/9yYWNYppHv+hHrdCpWeBsYJIVis/MvSQKpojzkSdkFYxywNUbJGfUoZntDLXuAEP8RcanT9PF1IRUOUFvuEqbh5ln1Yw5EolM/D/wqlGA45QO5tUh/w6LKLy6GnDc4RJDla/73bf3GUSaQl9M7Co7XfwPy54Hdp/Su/8AslkETViCl8rn99LSVSv/MB/Cl9rBricKaoC/qk05V5C+IUcQQHCS9dn9HnG5JBDSU8b+4H78MxoAc7sdmRKnNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btev7VOB2+6dFD2GdLn1YhVxSRoYERr9HQMuDPaEmQA=; b=NzbHYCrId/oYmCfZA7KZQ5WtQbA3T6OV6m8/ZNIjtS48tAKf23F8yWhc4VkIWBMaFMFckVVfmunPv477hmMSQwE5y0FC/5X9YWRSplPo4qZFBx2qy7AWvMuNUE3Je+xeKUYSHNMDNB/bzXSRQ8ThplcQdoIsdrLfrYuRlwsz/niThHybHB0ejCcMx9gtfgEldlSTsXwreq8oyASD98g5mb6rqy708763m7G+PDML95tT8r2yDROEp382iG+RPXVIgZD273E82109OXjViaExXp2wKlHObC2tj4PdM10oPrSCKcgtpfIUJ7nZM1EwlM7t7e7DkkpoLb1W9TyNZN12xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=btev7VOB2+6dFD2GdLn1YhVxSRoYERr9HQMuDPaEmQA=; b=fTvZpkPFIp02Tp/YBYtNklDQV9qMtQRaiCDlNfWYUo8S+tP6iEHjy8osht2uoj3Ov7uHykJRaeIp3Cj2AEDiuwREvrjp9QPLQ0BtgmzQEiPQcToNdDq6ycp7U0dLgBqTxvsgZ2BylxqYnP8DN4eVunBc26Uw0e+JH7PPFAeR5Mk= Received: from PH7P221CA0081.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:328::33) by SA0PR12MB7477.namprd12.prod.outlook.com (2603:10b6:806:24b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.24; Tue, 8 Oct 2024 09:13:56 +0000 Received: from CY4PEPF0000EDD4.namprd03.prod.outlook.com (2603:10b6:510:328:cafe::cb) by PH7P221CA0081.outlook.office365.com (2603:10b6:510:328::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23 via Frontend Transport; Tue, 8 Oct 2024 09:13:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000EDD4.mail.protection.outlook.com (10.167.241.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8048.13 via Frontend Transport; Tue, 8 Oct 2024 09:13:55 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 8 Oct 2024 04:13:53 -0500 Received: from prasad-r9-mach.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 8 Oct 2024 04:13:48 -0500 From: Venkata Prasad Potturu To: , CC: , , , , "Venkata Prasad Potturu" , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , Emil Velikov , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , "open list" Subject: [PATCH 1/2] ASoC: SOF: amd: Add error log for DSP firmware validation failure Date: Tue, 8 Oct 2024 14:43:44 +0530 Message-ID: <20241008091347.594378-1-venkataprasad.potturu@amd.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received-SPF: None (SATLEXMB03.amd.com: venkataprasad.potturu@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD4:EE_|SA0PR12MB7477:EE_ X-MS-Office365-Filtering-Correlation-Id: 150a4e59-fcfa-4d5a-c477-08dce7798954 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|7416014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: bKe4e3HeRGUf1BXwHaqwGfyL6zEiz1a2Hzk/zY19QO3Fv+qb4AgvXUvxZ4IcjdUkNsRRJPF3T1mPkmPHGE4x26fCrMToKkjMZ3oJJFk73rl8k28TjywJ0PBHs26upVUCR/oDdzhUmqtYOUURG6A+anliHNxeg/Lkj2CjuJicv7HHaGlDbFfKKWZOFy2dRP+48x7HOlYfstzF6IqmNjND60n8KLm1K3Mknn+7xClCNZa+D4db74tbZURnTd6dgFkSeEnzcYGBlsPzNSDupL6FI4pJKZCTEiq/v9IMtDWE2AFj9w8EZO+4ZeRcc9ioH3YDEIKgeznnNNRWie/Un01B5YDsDc9nCnQmaVAJZjoDd6GXTS7f46SJc1KOTxXG36cJUqu5bQ02z6JdALuCoFNcF2USMilHDGjrg8zs726fdbdVbaIM0Ho11juZw5UsG5qPtGM9nz8gJaLPvUdYlgDDrfU6a3ioTLZsmhktysemupmsLZW3mtKV7ciIqS3/7C5WlM2V7ELN9EbEN5smDRHys3UxgrV7TP/ZGjqZQdIMZWp6ggH5YuP4oswisxrfnUYWMw9EITQTsyAlO0WHDoceMGJLddZyN1P/Z/JbliiiYYv2UjgTyIoKQn2HAg+HY3LqyBOpBiEBQyf/ymbFB0PrbZ+XNHp7FDD3OD0vpjuQBPyvuOllXvcdVFHlngR9x2a9rtZlJcjQSgPM3i7ZSagOMX5yGL0r/O1BiYppzlz607uM99rIXsq0mLRek8bwLDyGYrtAvoJetjP6Iknj7tMMeo/H1dUGwR3ZPhz8jdztJuqgsbkXXyw53hF7mu0nvHXfOv5MZ0wUKGUVXCOghwiddoxAt1kMRftjLocKHt4yFc7A+ifQWTf5i2CWuQa1GXAoWNdoX53g87ZUz+k18tkW4lSVxs5vTCiYkLBRTrRJDhjT+r0FDEibZU0wcGIYCj9ALaPZvKDV4XdbH/BEjzY4fky3BPXPxzZEPchwW02Kk9VXRWCVfAqT+abTENP3FdJ2rr0xRslnjXRmi8qnKtyHDa4WXiuzWj2zpbSCXL+NtBUxbt/8uoD/wFcxHR6/kmZcUzJb8uTfNZReLhvY/7QljHvxLfYV/KMchRGw9aacAKYjMNn0YxqmzqpbAuFjr0gVivuBK8vM2GeAPgpN6wszcr4IfevV9T0SMOxg+bJt1I+tqxxKmuNJVAph47VgMhD/tnzGPFaLNdlwWSid2qYdD8I59QwxbH0VMuF+Zj/4eDUunrs8Bxaf/8TtViOp0IEVQThH45vHzZ+BTYBHJtDP/9kiH5qhQixEv/KThkChSB2hxmC1Ny9x6UKMXN5bWYLaVltBRzmkEtaHhF9g4VWejkl74fFyZwhyoFkJDObBlxAIlynjq9jdv0W4wEyiB5Jg X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(7416014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 09:13:55.8829 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 150a4e59-fcfa-4d5a-c477-08dce7798954 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7477 Add dev_err to print ACP_SHA_DSP_FW_QUALIFIER and ACP_SHA_PSP_ACK register values for PSP firmware validation failure case. Signed-off-by: Venkata Prasad Potturu --- sound/soc/sof/amd/acp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c index d579c3849392..de3001f5b9bb 100644 --- a/sound/soc/sof/amd/acp.c +++ b/sound/soc/sof/amd/acp.c @@ -329,7 +329,9 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr, fw_qualifier, fw_qualifier & DSP_FW_RUN_ENABLE, ACP_REG_POLL_INTERVAL, ACP_DMA_COMPLETE_TIMEOUT_US); if (ret < 0) { - dev_err(sdev->dev, "PSP validation failed\n"); + val = snd_sof_dsp_read(sdev, ACP_DSP_BAR, ACP_SHA_PSP_ACK); + dev_err(sdev->dev, "PSP validation failed: fw_qualifier = %#x, ACP_SHA_PSP_ACK = %#x\n", + fw_qualifier, val); return ret; } From patchwork Tue Oct 8 09:13:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkata Prasad Potturu X-Patchwork-Id: 13826077 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2054.outbound.protection.outlook.com [40.107.92.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09C5A17A5A1; Tue, 8 Oct 2024 09:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378847; cv=fail; b=oW3wtfukmHwjPIu7bh/itgYAtb7Y9ZcfMooKZg+hh7eBJOnLM5LB9pdvtrfVKzuHw/XuyrN9D19R6sZwmgBnvFfM5R+psRs74g7UZRp/b6MB9lkb7Ac4KhIBzHEDZgy54PAXAd2YtWV0jX4AnmrEKtb0PGTDk/dMSPGcAv9kl+Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378847; c=relaxed/simple; bh=QvG5+r9eSiVTbOEVFY6pDQBB1C6tpRemaoO9zdM6KVQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EChHg3jGs07wkivZGl0zhHUqx8bBUFnRT5kZ23FL0A+5oZE7CEeCR84/R9WahvD1wCqCikLmeTg2vRYhPsfopc40rfpPbRD8HSnpEPkhcR9COKSWaMtIb407+LEovWGk6YR6yMse97f5wG/0EmHKTVHvJMzV5o0cYm+f3y+RtdM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Ix+873GI; arc=fail smtp.client-ip=40.107.92.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Ix+873GI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qFb3y5FxHPkM9A4nZxGHEXvV+POBIFpN5z1Pnu3OVud5Pl5z5iCp4A+g6uYoNYbFQ9k3rcEwrTyToseMY5++jEZG+c4jPwDj9W/dyG7dz2QXnfkNNwoMsGCuLJIxUP5KJpBhQHpGChSujrkvn3P4xPYUcfZPhZS/FIVSocgrZy0eAzIqz/S/a6fvQ1keAzv8z0FmHRIkOLEngTyCAHxwrFdelF6GutEsCvazln+lbk+TBARbFHUEGBgs/Sxtv4PpUDUIPrkEJXUGqmCjhBcnF0KrcZ2iN+Dv4sXLcFGECIrk7Jzj5jqjiEuUdyYDmoFD2E0XpvWy25ktIz+G+iFshA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xno093WOtphFC3g8IBRpej/BGbPTEmoOWEqMGFOX6u4=; b=mfopqvhvXaMu9mFQ1pzSXJA34twoLe5E2WcIcy6SxEnJhHd/azR6vqfwJ2JAF5XU2V0AHyIpawJNmgL0gdh52JxWG5RHHAOUgpvO3Vu3Y2pzMoMfMJakli//mtP70DXvU4TXJO+mMuszXjL4CHQgZzhncAdZOE4nssb2URh1IaLz0jVrw53Xp9phK8W6FJH7kZVNxXfXJ8OjYy6xmjKTtXbamm+Q7JSr4KZF2iu2GbDR40g37Y9ZfQAw2jmES3kD5gQRVqzOhvZ9+YSEsnwmkg4T56nrPlN4Fcc55cPJwDGpo9RyA/A5PJDsMmHieM5YjYl32JAeK0UEnDaL+j6TJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xno093WOtphFC3g8IBRpej/BGbPTEmoOWEqMGFOX6u4=; b=Ix+873GIC71AhjDg541x+8Uh6tNdEzOi8eHUoGtq+YMGT8ejGf7IMQ8iCyJzApjj3Xd5WxRHEVf2p2DCqQcg9wkgS6+p6J4YOKntvR/yyAckAZuMwX2q3FvgTASsRReGPTXFTDG8NqO5pybpS7N5e/idmaU+55u+8v9iJbECRVo= Received: from MN2PR07CA0007.namprd07.prod.outlook.com (2603:10b6:208:1a0::17) by MN0PR12MB5763.namprd12.prod.outlook.com (2603:10b6:208:376::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.22; Tue, 8 Oct 2024 09:14:02 +0000 Received: from MN1PEPF0000F0E2.namprd04.prod.outlook.com (2603:10b6:208:1a0:cafe::6b) by MN2PR07CA0007.outlook.office365.com (2603:10b6:208:1a0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.23 via Frontend Transport; Tue, 8 Oct 2024 09:14:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MN1PEPF0000F0E2.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8048.13 via Frontend Transport; Tue, 8 Oct 2024 09:14:02 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 8 Oct 2024 04:14:00 -0500 Received: from prasad-r9-mach.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 8 Oct 2024 04:13:55 -0500 From: Venkata Prasad Potturu To: , CC: , , , , "Venkata Prasad Potturu" , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 2/2] ASoC: SOF: amd: Fix for ACP SRAM addr for acp7.0 platform Date: Tue, 8 Oct 2024 14:43:45 +0530 Message-ID: <20241008091347.594378-2-venkataprasad.potturu@amd.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241008091347.594378-1-venkataprasad.potturu@amd.com> References: <20241008091347.594378-1-venkataprasad.potturu@amd.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Received-SPF: None (SATLEXMB04.amd.com: venkataprasad.potturu@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E2:EE_|MN0PR12MB5763:EE_ X-MS-Office365-Filtering-Correlation-Id: cdc51081-45fb-4b68-9800-08dce7798d5d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: Zc9Plh7k6id1L6sgfmH2fwWhV4fBJikLvEazE5JSyTpHUVSDT+1zHjYNjrYcwX8ZqdSQOgalp4Ip/HR1MAjTXQvUNMXQus33r2ficlENR+0+oIX9CMXD8U1GR3iBIO7VZexVGGbjH9KOeWUDAydqPNucsNIkyP4jAfh6Nkwp2tnTa+rZPrwePh7/9qhM4gLBRGRkiD977PPdxHDKkyCa2Yudj53z2bGFHwXq4uFqjTppNwRiVAJwm1A1aK9l5YINc7beDeA7rhgx19ckFaEB115UeavQgNMZ0v+zHbDiwlyTNnknN+Sp0GnhuQt97Iv9aCWnQjVdjPuPjgwUJzzcQDMtDV0NNDDOAF8wbPdKIFf+5Kk0/bhl6GizWWfHbhpV/5pOPhzxSOO4y0R/AvAMTa8B3oQbsnLBOorVB2wVYgERl9mo+dtplSELaPFNlBqjrXEmWM9Ej/XMSGOyzlQnbdCChwlJ9EoabRgCqaKxWslwX6nfrddf0ugCX/aYXUVkgsvWHSuEcgn1xm2RF9Yx20xfMuuBcCig0Xah+ThXPYX+nDf2B1Nk/XZQ3uXHszIrZqXpBYiDAcRM+dGDzIxzElDcRNZrPsCHNkXjfCMyJiXkNy6aui9faFkewIxM+vSdGojpy6cbqovGGWJKMzWVfVYSaRDMcmuc329VQuVrJ/myrtWAACaPa/MVT+MZILXRPrCH4u6uM88h5IoNY5o/pdVS8KK0+y5c1Bw89oMlSVwlT5b5sLTQe4JTqqs/s4YRaem8eWEjxdxd9FR1H1TSnnoQnu/pWuWOXITD66B0gTmrvMQKEluzv8rrmjQNABswfWdCc0V+B5jOKFkOsgrYwwZ5s+fJnLfri1icql/PmkveSicXyODNKyq6CsvLn8BKizLBnpC+uBL3uWqCuC2s9sPAgwUk/NYqmXx1yk3VY61msYeGz03vuGsdHFFIq9EZ2nW5dn+DBDmwApFoUkw/AlbYVkgpFHq8BHH/Fxp0lQjALIRA1DAefLFlcGat5NeeUQ/J1Qs6C8Jxb0FXdi1ibNWtLvBYuLHd3e4ZFWScSqcxPB07WShXzhqwCsFeyOmfvKmRcC1L5bLnkAhvfOaQIJ5sWT9XNtMLFklUh/n0QWfTQl+wDCA5920QpDx4hoTs4aNbaHK6XcycqxBO0glK2PJL9m0W1jhwjsaeemJdvWprCaYjiSMMAgnAwsOPMMATT4pQiYz7QSL2Ao/xNmILaPeblzQPtSI4qIUJ4NwNnEAywgxQwdvopz8ztxY9zZoxHlsMXL3YTCoMp/4Q3wzZuKyzsLnoMDn484wzz9ABCQpLXVrlFcHQcMHXO5QKw1i/QaNXdjt3KxWqc+oHjwqY6pQwoZ3l+857O+W6weGTsMmdAsePMFjl3C+T1vg2aIOl X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2024 09:14:02.7610 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cdc51081-45fb-4b68-9800-08dce7798d5d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E2.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5763 Incorrect SRAM base addr for acp7.0 platform results firmware boot failure. Add condition check to support SRAM addr for various platforms. Fixes: 145d7e5ae8f4 ("ASoC: SOF: amd: add option to use sram for data bin loading") Signed-off-by: Venkata Prasad Potturu --- sound/soc/sof/amd/acp-loader.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/sof/amd/acp-loader.c b/sound/soc/sof/amd/acp-loader.c index 9489c7f5c4e6..3a532d69566e 100644 --- a/sound/soc/sof/amd/acp-loader.c +++ b/sound/soc/sof/amd/acp-loader.c @@ -206,7 +206,10 @@ int acp_dsp_pre_fw_run(struct snd_sof_dev *sdev) configure_pte_for_fw_loading(FW_SRAM_DATA_BIN, ACP_SRAM_PAGE_COUNT, adata); src_addr = ACP_SYSTEM_MEMORY_WINDOW + ACP_DEFAULT_SRAM_LENGTH + (page_count * ACP_PAGE_SIZE); - dest_addr = ACP_SRAM_BASE_ADDRESS; + if (adata->pci_rev > ACP63_PCI_ID) + dest_addr = ACP7X_SRAM_BASE_ADDRESS; + else + dest_addr = ACP_SRAM_BASE_ADDRESS; ret = configure_and_run_dma(adata, src_addr, dest_addr, adata->fw_sram_data_bin_size);