From patchwork Tue Oct 8 09:14:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 13826092 X-Patchwork-Delegate: geert@linux-m68k.org Received: from michel.telenet-ops.be (michel.telenet-ops.be [195.130.137.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE14D192B8D for ; Tue, 8 Oct 2024 09:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.130.137.88 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378879; cv=none; b=dl6rWZEjDEze3Y30odvHhA0H8amCIVAm6rvpIeKodrSxKD25bK+grY7REb/+eaRDU5F0XLgh54TgBX+xJ8QCiOMWQs3N318/QL7q7Jyoe7pnIKpX5ErzFmAgQpqZ1ym6p/HO4Oz086NRNyj7b7OjmHzzezVxr3niLqdo4JEvXk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378879; c=relaxed/simple; bh=RbAAAptohwkXGF/lWasQYEt4BriFrYvFkoZCqLFBweA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lisP+qgzeb70JSk1LhLEF3fgd2P/AAvfPf9oIHrAnSL+1uy14239rkuo+2DREuDy6e8mn2Yth+GRu6+3HvkJZHuEXbnGoPXc/EUp2y58jhI9dZz5EQ7J/zarfsLb6C8eFkOePcuIWK1wu2CRuS53Xn/LCgm90NOG1Bo969eHnhI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be; spf=none smtp.mailfrom=linux-m68k.org; arc=none smtp.client-ip=195.130.137.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed80:af78:ce2e:2b4b:9f2a]) by michel.telenet-ops.be with cmsmtp id MlET2D0090Eqs9l06lETAF; Tue, 08 Oct 2024 11:14:28 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1sy6IL-003RYJ-1y; Tue, 08 Oct 2024 11:14:27 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1sy6IV-00D2DE-HA; Tue, 08 Oct 2024 11:14:27 +0200 From: Geert Uytterhoeven To: Lukasz Luba , Magnus Damm Cc: Kuninori Morimoto , Lad Prabhakar , linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH/RFC 1/2] arm64: dts: renesas: r8a774c0: Re-add voltages to OPP table Date: Tue, 8 Oct 2024 11:14:20 +0200 Message-Id: <2046da75f3db95b62f86c0482063c4d04c2b47d5.1728377971.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When CONFIG_ENERGY_MODEL=y: cpu cpu0: EM: invalid perf. state: -22 When removing the (incorrect) voltages from the Operating Points Parameters tables, it was assumed they were optional, and unused, when none of the CPU nodes is tied to a regulator using the "cpu-supply" property. This assumption turned out to be incorrect, causing the reported error message. Fix this by re-adding the (correct) voltages. Note that because all voltages are identical, all operating points are considered to have the same efficiency, and the energy model always picks the one with the highest clock rate. Reported-by: Renesas Test Team via Kuninori Morimoto Fixes: 554edc3e9239bb81 ("arm64: dts: renesas: r8a774c0: Remove bogus voltages from OPP table") Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi index 7655d5e3a034166e..5d4db20033212218 100644 --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi @@ -49,14 +49,17 @@ cluster1_opp: opp-table-1 { opp-shared; opp-800000000 { opp-hz = /bits/ 64 <800000000>; + opp-microvolt = <1030000>; clock-latency-ns = <300000>; }; opp-1000000000 { opp-hz = /bits/ 64 <1000000000>; + opp-microvolt = <1030000>; clock-latency-ns = <300000>; }; opp-1200000000 { opp-hz = /bits/ 64 <1200000000>; + opp-microvolt = <1030000>; clock-latency-ns = <300000>; opp-suspend; }; From patchwork Tue Oct 8 09:14:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 13826093 X-Patchwork-Delegate: geert@linux-m68k.org Received: from michel.telenet-ops.be (michel.telenet-ops.be [195.130.137.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE223192D92 for ; Tue, 8 Oct 2024 09:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.130.137.88 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378879; cv=none; b=h7upSvP8/oc4UyAgRhNa64JJjJSRKDHGuTEdry6+t/ZsP4E4w8HvMWc4Z6jSrra61o01Gvo/BYMaLcplzErfLmPxlQichQPWw13bEy/dPjrviNgzksd2miY1DvRjFR9a67r4y6sOxugd0Y/9BixuGD/5iZKiVFzhxlRDWqAQwSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728378879; c=relaxed/simple; bh=tmCFPHOafuY/kvSSZhoNdE4swoZXJSjmXCm7P4fMpwE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rijCUTmAFibWmC9oPv/FuaUmQNaB9SkBUqExcIez/IbTjaqND6v90Wz+VuAX/CIeyGZieCfs7NxXjfi7JdVaVVg7wQoDPhgbTEjUh/etnJuPu9PcgOhfVh2bmqU8mXtXe8zdu+IqjXLtvz8q9A3hAShdHfowvCKXw7iWM9Jeml4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be; spf=none smtp.mailfrom=linux-m68k.org; arc=none smtp.client-ip=195.130.137.88 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=glider.be Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed80:af78:ce2e:2b4b:9f2a]) by michel.telenet-ops.be with cmsmtp id MlET2D00A0Eqs9l06lETAG; Tue, 08 Oct 2024 11:14:28 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1sy6IL-003RYL-2R; Tue, 08 Oct 2024 11:14:27 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1sy6IV-00D2DH-Hn; Tue, 08 Oct 2024 11:14:27 +0200 From: Geert Uytterhoeven To: Lukasz Luba , Magnus Damm Cc: Kuninori Morimoto , Lad Prabhakar , linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH/RFC 2/2] arm64: dts: renesas: r8a77990: Re-add voltages to OPP table Date: Tue, 8 Oct 2024 11:14:21 +0200 Message-Id: <80890bc244670bc3e8d6fc89fb2c3cb23e7025f5.1728377971.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When CONFIG_ENERGY_MODEL=y: cpu cpu0: EM: invalid perf. state: -22 When removing the (incorrect) voltages from the Operating Points Parameters tables, it was assumed they were optional, and unused, when none of the CPU nodes is tied to a regulator using the "cpu-supply" property. This assumption turned out to be incorrect, causing the reported error message. Fix this by re-adding the (correct) voltages. Note that because all voltages are identical, all operating points are considered to have the same efficiency, and the energy model always picks the one with the highest clock rate. Reported-by: Renesas Test Team via Kuninori Morimoto Fixes: fb76b0fae3ca8803 ("arm64: dts: renesas: r8a77990: Remove bogus voltages from OPP table") Signed-off-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index 233af3081e84a407..26d08f2cbcb6417b 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi @@ -49,14 +49,17 @@ cluster1_opp: opp-table-1 { opp-shared; opp-800000000 { opp-hz = /bits/ 64 <800000000>; + opp-microvolt = <1030000>; clock-latency-ns = <300000>; }; opp-1000000000 { opp-hz = /bits/ 64 <1000000000>; + opp-microvolt = <1030000>; clock-latency-ns = <300000>; }; opp-1200000000 { opp-hz = /bits/ 64 <1200000000>; + opp-microvolt = <1030000>; clock-latency-ns = <300000>; opp-suspend; };